@abaplint/core 2.85.9 → 2.85.13

package/README.md

@@ -2,6 +2,6 @@
 
 [abaplint](https://abaplint.org/) core library
 
-Exposes functionallity like the parser and rules, which can be used in other projects.
+Exposes functionality like the parser and rules, which can be used in other projects.
 
 For more information see https://github.com/abaplint/abaplint

package/build/src/abap/2_statements/expressions/type_table_key.js

@@ -9,7 +9,7 @@ class TypeTableKey extends combi_1.Expression {
         const uniqueness = (0, combi_1.alt)("NON-UNIQUE", "UNIQUE");
         const defaultKey = "DEFAULT KEY";
         const emptyKey = (0, combi_1.ver)(version_1.Version.v740sp02, "EMPTY KEY");
-        const key = (0, combi_1.seq)("WITH", (0, combi_1.opt)(uniqueness), (0, combi_1.altPrio)(defaultKey, emptyKey, (0, combi_1.seq)((0, combi_1.opt)((0, combi_1.alt)("SORTED", "HASHED")), "KEY", (0, combi_1.alt)((0, combi_1.seq)(_1.Field, "COMPONENTS", (0, combi_1.plus)(_1.FieldSub)), (0, combi_1.plus)(_1.FieldSub)))));
+        const key = (0, combi_1.seq)("WITH", (0, combi_1.opt)(uniqueness), (0, combi_1.altPrio)(defaultKey, emptyKey, (0, combi_1.seq)((0, combi_1.opt)((0, combi_1.alt)("SORTED", "HASHED")), "KEY", (0, combi_1.alt)((0, combi_1.seq)(_1.Field, "COMPONENTS", (0, combi_1.plus)(_1.FieldSub)), (0, combi_1.plus)(_1.FieldSub)))), (0, combi_1.optPrio)("READ-ONLY"));
         return key;
     }
 }

package/build/src/abap/5_syntax/_type_utils.js

@@ -7,6 +7,9 @@ class TypeUtils {
         if (type === undefined) {
             return false;
         }
+        else if (type instanceof basic_1.TableType && type.isWithHeader()) {
+            return this.isCharLike(type.getRowType());
+        }
         else if (type instanceof basic_1.StructureType) {
             for (const c of type.getComponents()) {
                 if (this.isCharLike(c.type) === false) {
@@ -20,6 +23,13 @@ class TypeUtils {
             || type instanceof basic_1.AnyType
             || type instanceof basic_1.UnknownType
             || type instanceof basic_1.NumericType
+            || type instanceof basic_1.IntegerType
+            || type instanceof basic_1.FloatType
+            || type instanceof basic_1.FloatingPointType
+            || type instanceof basic_1.DecFloatType
+            || type instanceof basic_1.DecFloat16Type
+            || type instanceof basic_1.DecFloat34Type
+            || type instanceof basic_1.NumericGenericType
             || type instanceof basic_1.CSequenceType
             || type instanceof basic_1.DateType
             || type instanceof basic_1.CLikeType
@@ -53,8 +63,8 @@ class TypeUtils {
     }
     static isAssignable(source, target) {
         /*
-        console.dir(source);
-        console.dir(target);
+            console.dir(source);
+            console.dir(target);
         */
         if (target instanceof basic_1.TableType) {
             if (target.isWithHeader()) {
@@ -97,8 +107,13 @@ class TypeUtils {
                 || source instanceof basic_1.UnknownType) {
                 return true;
             }
-            else if (this.isCharLike(target)
-                && (this.isCharLike(source) || source instanceof basic_1.IntegerType)) {
+            else if (target.containsVoid() === true) {
+                return true;
+            }
+            else if (source instanceof basic_1.IntegerType) {
+                return false;
+            }
+            else if (this.isCharLike(target) && this.isCharLike(source)) {
                 return true;
             }
             return false;

package/build/src/abap/5_syntax/expressions/attribute_chain.js

@@ -18,7 +18,7 @@ class AttributeChain {
         if (!(first.get() instanceof expressions_1.AttributeName)) {
             throw new Error("AttributeChain, unexpected first child");
         }
-        const def = scope.findClassDefinition(inputContext.getIdentifierName());
+        const def = scope.findObjectDefinition(inputContext.getIdentifierName());
         if (def === undefined) {
             throw new Error("Definition for \"" + inputContext.getIdentifierName() + "\" not found in scope(AttributeChain)");
         }

package/build/src/abap/5_syntax/expressions/constant.js

@@ -8,6 +8,9 @@ class Constant {
         if (node.findDirectExpression(expressions_1.Integer)) {
             return new basic_1.IntegerType("I");
         }
+        else if (node.getFirstToken().getStr().startsWith("'")) {
+            return new basic_1.CharacterType(10);
+        }
         else {
             return new basic_1.StringType("STRING");
         }

package/build/src/abap/5_syntax/statements/write.js

@@ -5,11 +5,18 @@ const Expressions = require("../../2_statements/expressions");
 const source_1 = require("../expressions/source");
 const target_1 = require("../expressions/target");
 const dynamic_1 = require("../expressions/dynamic");
+const _type_utils_1 = require("../_type_utils");
 class Write {
     runSyntax(node, scope, filename) {
         // todo, more
+        const second = node.getChildren()[1];
         for (const s of node.findAllExpressions(Expressions.Source)) {
-            new source_1.Source().runSyntax(s, scope, filename);
+            const type = new source_1.Source().runSyntax(s, scope, filename);
+            if (s === second
+                && _type_utils_1.TypeUtils.isCharLike(type) === false
+                && _type_utils_1.TypeUtils.isHexLike(type) === false) {
+                throw new Error("Source not character like");
+            }
         }
         for (const s of node.findAllExpressions(Expressions.Dynamic)) {
             new dynamic_1.Dynamic().runSyntax(s, scope, filename);

package/build/src/abap/types/basic/structure_type.js

@@ -43,7 +43,7 @@ class StructureType extends _abstract_type_1.AbstractType {
         return "StructureTypetoABAPtodo";
     }
     containsVoid() {
-        return this.getComponents().some(c => { c.type.containsVoid(); });
+        return this.getComponents().some(c => { return c.type.containsVoid(); });
     }
     toCDS() {
         return "abap.TODO_STRUCTURE";

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.85.9";
+        return "2.85.13";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/identical_contents.js

@@ -19,8 +19,8 @@ class IdenticalContents extends _abap_rule_1.ABAPRule {
         return {
             key: "identical_contents",
             title: "Identical contents",
-            shortDescription: `Find identical contents in blocks inside IFs, both in the beginning and in the end.
-
+            shortDescription: `Find identical contents in blocks inside IFs, both in the beginning and in the end.`,
+            extendedInformation: `
 Prerequsites: code is pretty printed with identical cAsE
 
 Chained statments are ignored`,

package/build/src/rules/local_testclass_location.js

@@ -6,6 +6,7 @@ const _abap_rule_1 = require("./_abap_rule");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const objects_1 = require("../objects");
 const _irule_1 = require("./_irule");
+const version_1 = require("../version");
 class LocalTestclassLocationConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.LocalTestclassLocationConf = LocalTestclassLocationConf;
@@ -33,6 +34,10 @@ class LocalTestclassLocation extends _abap_rule_1.ABAPRule {
     }
     runParsed(file, obj) {
         const issues = [];
+        if (this.reg.getConfig().getVersion() === version_1.Version.v700) {
+            // 700 does not have testclass includes
+            return [];
+        }
         if (!(obj instanceof objects_1.Class)) {
             return [];
         }

package/build/src/rules/unused_variables.js

@@ -66,7 +66,7 @@ class UnusedVariables {
             shortDescription: `Checks for unused variables and constants`,
             extendedInformation: `WARNING: slow
 
-Experimental, might give false positives. Skips event parameters.
+Skips event parameters.
 
 Note that this currently does not work if the source code uses macros.
 

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.85.9",
+    "version": "2.85.13",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -48,7 +48,7 @@
         "@microsoft/api-extractor": "^7.19.4",
         "@types/chai": "^4.3.0",
         "@types/mocha": "^9.1.0",
-        "@types/node": "^17.0.14",
+        "@types/node": "^17.0.16",
         "chai": "^4.3.6",
         "eslint": "^8.8.0",
         "mocha": "^9.2.0",
@@ -58,7 +58,7 @@
         "typescript": "^4.5.5"
     },
     "dependencies": {
-        "fast-xml-parser": "^4.0.1",
+        "fast-xml-parser": "^4.0.2",
         "json5": "^2.2.0",
         "vscode-languageserver-protocol": "^3.16.0",
         "vscode-languageserver-types": "^3.16.0"