@abaplint/core 2.85.7 → 2.85.11

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (97) hide show
  1. package/README.md +6 -6
  2. package/build/src/abap/2_statements/combi.js +20 -4
  3. package/build/src/abap/2_statements/expressions/simple_source3.js +1 -1
  4. package/build/src/abap/2_statements/expressions/sql_cds_parameters.js +1 -1
  5. package/build/src/abap/2_statements/expressions/sql_compare.js +7 -7
  6. package/build/src/abap/2_statements/expressions/sql_from_source.js +1 -1
  7. package/build/src/abap/2_statements/expressions/sql_source.js +2 -3
  8. package/build/src/abap/2_statements/expressions/sql_source_simple.js +3 -3
  9. package/build/src/abap/2_statements/expressions/type_table_key.js +1 -1
  10. package/build/src/abap/5_syntax/_type_utils.js +11 -4
  11. package/build/src/abap/5_syntax/expressions/attribute_chain.js +1 -1
  12. package/build/src/abap/5_syntax/expressions/constant.js +3 -0
  13. package/build/src/abap/5_syntax/expressions/field_chain.js +3 -0
  14. package/build/src/abap/5_syntax/expressions/select.js +3 -0
  15. package/build/src/abap/5_syntax/expressions/sql_for_all_entries.js +4 -1
  16. package/build/src/abap/5_syntax/statements/create_data.js +5 -0
  17. package/build/src/abap/5_syntax/statements/delete_database.js +3 -0
  18. package/build/src/abap/5_syntax/statements/insert_database.js +3 -0
  19. package/build/src/abap/5_syntax/statements/modify_database.js +7 -0
  20. package/build/src/abap/5_syntax/statements/update_database.js +3 -0
  21. package/build/src/abap/5_syntax/statements/write.js +8 -1
  22. package/build/src/abap/flow/flow_graph.js +7 -7
  23. package/build/src/abap/types/basic/structure_type.js +1 -1
  24. package/build/src/lsp/help.js +7 -7
  25. package/build/src/registry.js +1 -1
  26. package/build/src/rules/7bit_ascii.js +2 -2
  27. package/build/src/rules/abapdoc.js +1 -1
  28. package/build/src/rules/align_parameters.js +33 -33
  29. package/build/src/rules/ambiguous_statement.js +5 -5
  30. package/build/src/rules/avoid_use.js +6 -6
  31. package/build/src/rules/begin_end_names.js +4 -4
  32. package/build/src/rules/begin_single_include.js +12 -12
  33. package/build/src/rules/call_transaction_authority_check.js +3 -3
  34. package/build/src/rules/chain_mainly_declarations.js +4 -4
  35. package/build/src/rules/check_abstract.js +2 -2
  36. package/build/src/rules/check_comments.js +4 -4
  37. package/build/src/rules/check_include.js +3 -3
  38. package/build/src/rules/check_no_handler_pragma.js +8 -8
  39. package/build/src/rules/check_subrc.js +8 -8
  40. package/build/src/rules/commented_code.js +1 -1
  41. package/build/src/rules/constructor_visibility_public.js +4 -4
  42. package/build/src/rules/contains_tab.js +2 -2
  43. package/build/src/rules/dangerous_statement.js +1 -1
  44. package/build/src/rules/downport.js +45 -45
  45. package/build/src/rules/exit_or_check.js +3 -3
  46. package/build/src/rules/exporting.js +1 -1
  47. package/build/src/rules/forbidden_identifier.js +1 -1
  48. package/build/src/rules/forbidden_void_type.js +2 -2
  49. package/build/src/rules/functional_writing.js +17 -17
  50. package/build/src/rules/global_class.js +10 -10
  51. package/build/src/rules/identical_conditions.js +2 -2
  52. package/build/src/rules/identical_contents.js +15 -15
  53. package/build/src/rules/identical_descriptions.js +4 -4
  54. package/build/src/rules/if_in_if.js +7 -7
  55. package/build/src/rules/implement_methods.js +3 -3
  56. package/build/src/rules/in_statement_indentation.js +11 -11
  57. package/build/src/rules/intf_referencing_clas.js +3 -3
  58. package/build/src/rules/line_break_style.js +2 -2
  59. package/build/src/rules/line_length.js +1 -1
  60. package/build/src/rules/line_only_punc.js +1 -1
  61. package/build/src/rules/local_testclass_location.js +5 -0
  62. package/build/src/rules/local_variable_names.js +2 -2
  63. package/build/src/rules/many_parentheses.js +10 -10
  64. package/build/src/rules/max_one_method_parameter_per_line.js +7 -7
  65. package/build/src/rules/max_one_statement.js +3 -3
  66. package/build/src/rules/nesting.js +1 -1
  67. package/build/src/rules/no_chained_assignment.js +1 -1
  68. package/build/src/rules/no_public_attributes.js +1 -1
  69. package/build/src/rules/no_yoda_conditions.js +4 -4
  70. package/build/src/rules/obsolete_statement.js +40 -40
  71. package/build/src/rules/omit_parameter_name.js +3 -3
  72. package/build/src/rules/omit_receiving.js +13 -13
  73. package/build/src/rules/parser_702_chaining.js +2 -2
  74. package/build/src/rules/parser_error.js +2 -2
  75. package/build/src/rules/parser_missing_space.js +1 -1
  76. package/build/src/rules/prefer_inline.js +16 -16
  77. package/build/src/rules/prefer_is_not.js +7 -7
  78. package/build/src/rules/prefer_raise_exception_new.js +3 -3
  79. package/build/src/rules/prefer_returning_to_exporting.js +1 -1
  80. package/build/src/rules/prefer_xsdbool.js +2 -2
  81. package/build/src/rules/remove_descriptions.js +4 -4
  82. package/build/src/rules/rfc_error_handling.js +9 -9
  83. package/build/src/rules/select_add_order_by.js +5 -5
  84. package/build/src/rules/select_performance.js +2 -2
  85. package/build/src/rules/sicf_consistency.js +4 -4
  86. package/build/src/rules/space_before_dot.js +2 -2
  87. package/build/src/rules/sql_escape_host_variables.js +2 -1
  88. package/build/src/rules/start_at_tab.js +1 -1
  89. package/build/src/rules/sy_modification.js +2 -2
  90. package/build/src/rules/tabl_enhancement_category.js +2 -2
  91. package/build/src/rules/unused_methods.js +9 -9
  92. package/build/src/rules/unused_variables.js +6 -6
  93. package/build/src/rules/use_bool_expression.js +8 -8
  94. package/build/src/rules/use_line_exists.js +6 -6
  95. package/build/src/rules/use_new.js +2 -2
  96. package/build/src/rules/when_others_last.js +6 -6
  97. package/package.json +66 -66
@@ -45,10 +45,10 @@ class ChainMainlyDeclarations extends _abap_rule_1.ABAPRule {
45
45
  key: "chain_mainly_declarations",
46
46
  title: "Chain mainly declarations",
47
47
  shortDescription: `Chain mainly declarations, allows chaining for the configured statements, reports errors for other statements.`,
48
- extendedInformation: `
49
- https://docs.abapopenchecks.org/checks/23/
50
-
51
- https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
48
+ extendedInformation: `
49
+ https://docs.abapopenchecks.org/checks/23/
50
+
51
+ https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
52
52
  `,
53
53
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
54
54
  badExample: `CALL METHOD: bar.`,
@@ -23,8 +23,8 @@ class CheckAbstract extends _abap_rule_1.ABAPRule {
23
23
  return {
24
24
  key: "check_abstract",
25
25
  title: "Check abstract methods and classes",
26
- shortDescription: `Checks abstract methods and classes:
27
- - class defined as abstract and final,
26
+ shortDescription: `Checks abstract methods and classes:
27
+ - class defined as abstract and final,
28
28
  - non-abstract class contains abstract methods`,
29
29
  extendedInformation: `If a class defines only constants, use an interface instead`,
30
30
  tags: [_irule_1.RuleTag.SingleFile],
@@ -27,11 +27,11 @@ class CheckComments extends _abap_rule_1.ABAPRule {
27
27
  return {
28
28
  key: "check_comments",
29
29
  title: "Check Comments",
30
- shortDescription: `
30
+ shortDescription: `
31
31
  Various checks for comment usage.`,
32
- extendedInformation: `
33
- * End of line comments. Comments starting with "#EC" or "##" are ignored
34
-
32
+ extendedInformation: `
33
+ * End of line comments. Comments starting with "#EC" or "##" are ignored
34
+
35
35
  https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#put-comments-before-the-statement-they-relate-to`,
36
36
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
37
37
  };
@@ -17,9 +17,9 @@ class CheckInclude {
17
17
  key: "check_include",
18
18
  title: "Check INCLUDEs",
19
19
  shortDescription: `Checks INCLUDE statements`,
20
- extendedInformation: `
21
- * Reports unused includes
22
- * Errors if the includes are not found
20
+ extendedInformation: `
21
+ * Reports unused includes
22
+ * Errors if the includes are not found
23
23
  * Error if including a main program`,
24
24
  tags: [_irule_1.RuleTag.Syntax],
25
25
  };
@@ -21,15 +21,15 @@ class CheckNoHandlerPragma extends _abap_rule_1.ABAPRule {
21
21
  title: "Check if NO_HANDLER can be removed",
22
22
  shortDescription: `Checks NO_HANDLER pragmas that can be removed`,
23
23
  tags: [_irule_1.RuleTag.SingleFile],
24
- badExample: `TRY.
25
- ...
26
- CATCH zcx_abapgit_exception ##NO_HANDLER.
27
- RETURN. " it has a handler
24
+ badExample: `TRY.
25
+ ...
26
+ CATCH zcx_abapgit_exception ##NO_HANDLER.
27
+ RETURN. " it has a handler
28
28
  ENDTRY.`,
29
- goodExample: `TRY.
30
- ...
31
- CATCH zcx_abapgit_exception.
32
- RETURN.
29
+ goodExample: `TRY.
30
+ ...
31
+ CATCH zcx_abapgit_exception.
32
+ RETURN.
33
33
  ENDTRY.`,
34
34
  };
35
35
  }
@@ -34,14 +34,14 @@ class CheckSubrc extends _abap_rule_1.ABAPRule {
34
34
  key: "check_subrc",
35
35
  title: "Check sy-subrc",
36
36
  shortDescription: `Check sy-subrc`,
37
- extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
38
-
39
- If sy-dbcnt is checked after database statements, it is considered okay.
40
-
41
- "SELECT SINGLE @abap_true FROM " is considered as an existence check
42
-
43
- If IS ASSIGNED is checked after assigning, it is considered okay.
44
-
37
+ extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
38
+
39
+ If sy-dbcnt is checked after database statements, it is considered okay.
40
+
41
+ "SELECT SINGLE @abap_true FROM " is considered as an existence check
42
+
43
+ If IS ASSIGNED is checked after assigning, it is considered okay.
44
+
45
45
  FIND statement with MATCH COUNT is considered okay if subrc is not checked`,
46
46
  tags: [_irule_1.RuleTag.SingleFile],
47
47
  pseudoComment: "EC CI_SUBRC",
@@ -30,7 +30,7 @@ class CommentedCode extends _abap_rule_1.ABAPRule {
30
30
  key: "commented_code",
31
31
  title: "Find commented code",
32
32
  shortDescription: `Detects usage of commented out code.`,
33
- extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
33
+ extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
34
34
  https://docs.abapopenchecks.org/checks/14/`,
35
35
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
36
36
  };
@@ -18,10 +18,10 @@ class ConstructorVisibilityPublic {
18
18
  key: "constructor_visibility_public",
19
19
  title: "Check constructor visibility is public",
20
20
  shortDescription: `Constructor must be placed in the public section, even if the class is not CREATE PUBLIC.`,
21
- extendedInformation: `
22
- This only applies to global classes.
23
-
24
- https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
21
+ extendedInformation: `
22
+ This only applies to global classes.
23
+
24
+ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
25
25
  https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abeninstance_constructor_guidl.htm`,
26
26
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
27
27
  };
@@ -25,8 +25,8 @@ class ContainsTab extends _abap_rule_1.ABAPRule {
25
25
  key: "contains_tab",
26
26
  title: "Code contains tab",
27
27
  shortDescription: `Checks for usage of tabs (enable to enforce spaces)`,
28
- extendedInformation: `
29
- https://docs.abapopenchecks.org/checks/09/
28
+ extendedInformation: `
29
+ https://docs.abapopenchecks.org/checks/09/
30
30
  https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#indent-and-snap-to-tab`,
31
31
  tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
32
32
  };
@@ -40,7 +40,7 @@ class DangerousStatement extends _abap_rule_1.ABAPRule {
40
40
  key: "dangerous_statement",
41
41
  title: "Dangerous statement",
42
42
  shortDescription: `Detects potentially dangerous statements`,
43
- extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
43
+ extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
44
44
  dynamic SQL can potentially create SQL injection problems`,
45
45
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
46
46
  };
@@ -33,30 +33,30 @@ class Downport {
33
33
  key: "downport",
34
34
  title: "Downport statement",
35
35
  shortDescription: `Experimental downport functionality`,
36
- extendedInformation: `Much like the 'commented_code' rule this rule loops through unknown statements and tries parsing with
37
- a higher level language version. If successful, various rules are applied to downport the statement.
38
- Target downport version is always v702, thus rule is only enabled if target version is v702.
39
-
40
- Current rules:
41
- * NEW transformed to CREATE OBJECT, opposite of https://rules.abaplint.org/use_new/
42
- * DATA() definitions are outlined, opposite of https://rules.abaplint.org/prefer_inline/
43
- * FIELD-SYMBOL() definitions are outlined
44
- * CONV is outlined
45
- * COND is outlined
46
- * REDUCE is outlined
47
- * EMPTY KEY is changed to DEFAULT KEY, opposite of DEFAULT KEY in https://rules.abaplint.org/avoid_use/
48
- * CAST changed to ?=
49
- * LOOP AT method_call( ) is outlined
50
- * VALUE # with structure fields
51
- * VALUE # with internal table lines
52
- * Table Expressions[ index ] are outlined
53
- * SELECT INTO @DATA definitions are outlined
54
- * Some occurrences of string template formatting option ALPHA changed to function module call
55
- * SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
56
- * PARTIALLY IMPLEMENTED removed, it can be quick fixed via rule implement_methods
57
- * RAISE EXCEPTION ... MESSAGE
58
- * APPEND expression is outlined
59
-
36
+ extendedInformation: `Much like the 'commented_code' rule this rule loops through unknown statements and tries parsing with
37
+ a higher level language version. If successful, various rules are applied to downport the statement.
38
+ Target downport version is always v702, thus rule is only enabled if target version is v702.
39
+
40
+ Current rules:
41
+ * NEW transformed to CREATE OBJECT, opposite of https://rules.abaplint.org/use_new/
42
+ * DATA() definitions are outlined, opposite of https://rules.abaplint.org/prefer_inline/
43
+ * FIELD-SYMBOL() definitions are outlined
44
+ * CONV is outlined
45
+ * COND is outlined
46
+ * REDUCE is outlined
47
+ * EMPTY KEY is changed to DEFAULT KEY, opposite of DEFAULT KEY in https://rules.abaplint.org/avoid_use/
48
+ * CAST changed to ?=
49
+ * LOOP AT method_call( ) is outlined
50
+ * VALUE # with structure fields
51
+ * VALUE # with internal table lines
52
+ * Table Expressions[ index ] are outlined
53
+ * SELECT INTO @DATA definitions are outlined
54
+ * Some occurrences of string template formatting option ALPHA changed to function module call
55
+ * SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
56
+ * PARTIALLY IMPLEMENTED removed, it can be quick fixed via rule implement_methods
57
+ * RAISE EXCEPTION ... MESSAGE
58
+ * APPEND expression is outlined
59
+
60
60
  Only one transformation is applied to a statement at a time, so multiple steps might be required to do the full downport.`,
61
61
  tags: [_irule_1.RuleTag.Experimental, _irule_1.RuleTag.Downport, _irule_1.RuleTag.Quickfix],
62
62
  };
@@ -326,10 +326,10 @@ Only one transformation is applied to a statement at a time, so multiple steps m
326
326
  const fieldName = f.concatTokens();
327
327
  fieldDefinition += indentation + " " + fieldName + " TYPE " + tableName + "-" + fieldName + ",\n";
328
328
  }
329
- fieldDefinition = `DATA: BEGIN OF ${name},
329
+ fieldDefinition = `DATA: BEGIN OF ${name},
330
330
  ${fieldDefinition}${indentation} END OF ${name}.`;
331
331
  }
332
- const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `${fieldDefinition}
332
+ const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `${fieldDefinition}
333
333
  ${indentation}`);
334
334
  const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, inlineData.getFirstToken().getStart(), inlineData.getLastToken().getEnd(), name);
335
335
  const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -365,12 +365,12 @@ ${indentation}`);
365
365
  }
366
366
  const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
367
367
  const name = ((_c = inlineData.findFirstExpression(Expressions.TargetField)) === null || _c === void 0 ? void 0 : _c.concatTokens()) || "error";
368
- let fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `TYPES: BEGIN OF ${uniqueName},
369
- ${fieldDefinitions}${indentation} END OF ${uniqueName}.
370
- ${indentation}DATA ${name} TYPE STANDARD TABLE OF ${uniqueName} WITH DEFAULT KEY.
368
+ let fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `TYPES: BEGIN OF ${uniqueName},
369
+ ${fieldDefinitions}${indentation} END OF ${uniqueName}.
370
+ ${indentation}DATA ${name} TYPE STANDARD TABLE OF ${uniqueName} WITH DEFAULT KEY.
371
371
  ${indentation}`);
372
372
  if (fieldDefinitions === "") {
373
- fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `DATA ${name} TYPE STANDARD TABLE OF ${tableName} WITH DEFAULT KEY.
373
+ fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `DATA ${name} TYPE STANDARD TABLE OF ${tableName} WITH DEFAULT KEY.
374
374
  ${indentation}`);
375
375
  }
376
376
  const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, inlineData.getFirstToken().getStart(), inlineData.getLastToken().getEnd(), name);
@@ -391,7 +391,7 @@ ${indentation}`);
391
391
  const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
392
392
  const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
393
393
  const firstToken = high.getFirstToken();
394
- const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${target === null || target === void 0 ? void 0 : target.concatTokens()}.
394
+ const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${target === null || target === void 0 ? void 0 : target.concatTokens()}.
395
395
  ${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
396
396
  const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, source.getFirstToken().getStart(), source.getLastToken().getEnd(), uniqueName);
397
397
  const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -427,11 +427,11 @@ ${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
427
427
  const uniqueName = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
428
428
  const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
429
429
  const firstToken = node.getFirstToken();
430
- const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${pre}.
431
- ${indentation}READ TABLE ${pre} INDEX ${(_a = tableExpression.findFirstExpression(Expressions.Source)) === null || _a === void 0 ? void 0 : _a.concatTokens()} INTO ${uniqueName}.
432
- ${indentation}IF sy-subrc <> 0.
433
- ${indentation} RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
434
- ${indentation}ENDIF.
430
+ const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${pre}.
431
+ ${indentation}READ TABLE ${pre} INDEX ${(_a = tableExpression.findFirstExpression(Expressions.Source)) === null || _a === void 0 ? void 0 : _a.concatTokens()} INTO ${uniqueName}.
432
+ ${indentation}IF sy-subrc <> 0.
433
+ ${indentation} RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
434
+ ${indentation}ENDIF.
435
435
  ${indentation}`);
436
436
  const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, startToken.getStart(), tableExpression.getLastToken().getEnd(), uniqueName);
437
437
  const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -529,11 +529,11 @@ ${indentation}`);
529
529
  const uniqueName1 = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
530
530
  const uniqueName2 = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
531
531
  const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
532
- const abap = `DATA ${uniqueName1} LIKE if_t100_message=>t100key.
533
- ${indentation}${uniqueName1}-msgid = ${id}.
534
- ${indentation}${uniqueName1}-msgno = ${number}.
535
- ${indentation}DATA ${uniqueName2} TYPE REF TO ${className}.
536
- ${indentation}CREATE OBJECT ${uniqueName2} EXPORTING textid = ${uniqueName1}.
532
+ const abap = `DATA ${uniqueName1} LIKE if_t100_message=>t100key.
533
+ ${indentation}${uniqueName1}-msgid = ${id}.
534
+ ${indentation}${uniqueName1}-msgno = ${number}.
535
+ ${indentation}DATA ${uniqueName2} TYPE REF TO ${className}.
536
+ ${indentation}CREATE OBJECT ${uniqueName2} EXPORTING textid = ${uniqueName1}.
537
537
  ${indentation}RAISE EXCEPTION ${uniqueName2}.`;
538
538
  const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getStart(), node.getEnd(), abap);
539
539
  return issue_1.Issue.atToken(lowFile, startToken, "Downport RAISE MESSAGE", this.getMetadata().key, this.conf.severity, fix);
@@ -596,10 +596,10 @@ ${indentation}RAISE EXCEPTION ${uniqueName2}.`;
596
596
  const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
597
597
  const source = (_b = templateSource === null || templateSource === void 0 ? void 0 : templateSource.findDirectExpression(Expressions.Source)) === null || _b === void 0 ? void 0 : _b.concatTokens();
598
598
  const topTarget = (_c = node.findDirectExpression(Expressions.Target)) === null || _c === void 0 ? void 0 : _c.concatTokens();
599
- const code = `CALL FUNCTION '${functionName}'
600
- ${indentation} EXPORTING
601
- ${indentation} input = ${source}
602
- ${indentation} IMPORTING
599
+ const code = `CALL FUNCTION '${functionName}'
600
+ ${indentation} EXPORTING
601
+ ${indentation} input = ${source}
602
+ ${indentation} IMPORTING
603
603
  ${indentation} output = ${topTarget}.`;
604
604
  const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getFirstToken().getStart(), node.getLastToken().getEnd(), code);
605
605
  return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Downport ALPHA", this.getMetadata().key, this.conf.severity, fix);
@@ -24,10 +24,10 @@ class ExitOrCheck extends _abap_rule_1.ABAPRule {
24
24
  return {
25
25
  key: "exit_or_check",
26
26
  title: "Find EXIT or CHECK outside loops",
27
- shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
27
+ shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
28
28
  Use RETURN to leave procesing blocks instead.`,
29
- extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
30
- https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
29
+ extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
30
+ https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
31
31
  https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-return`,
32
32
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
33
33
  };
@@ -22,7 +22,7 @@ class Exporting extends _abap_rule_1.ABAPRule {
22
22
  shortDescription: `Detects EXPORTING statements which can be omitted.`,
23
23
  badExample: `call_method( EXPORTING foo = bar ).`,
24
24
  goodExample: `call_method( foo = bar ).`,
25
- extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-optional-keyword-exporting
25
+ extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-optional-keyword-exporting
26
26
  https://docs.abapopenchecks.org/checks/30/`,
27
27
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
28
28
  };
@@ -26,7 +26,7 @@ class ForbiddenIdentifier extends _abap_rule_1.ABAPRule {
26
26
  key: "forbidden_identifier",
27
27
  title: "Forbidden Identifier",
28
28
  shortDescription: `Forbid use of specified identifiers, list of regex.`,
29
- extendedInformation: `Used in the transpiler to find javascript keywords in ABAP identifiers,
29
+ extendedInformation: `Used in the transpiler to find javascript keywords in ABAP identifiers,
30
30
  https://github.com/abaplint/transpiler/blob/bda94b8b56e2b7f2f87be2168f12361aa530220e/packages/transpiler/src/validation.ts#L44`,
31
31
  tags: [_irule_1.RuleTag.SingleFile],
32
32
  };
@@ -28,8 +28,8 @@ class ForbiddenVoidType {
28
28
  key: "forbidden_void_type",
29
29
  title: "Forbidden Void Types",
30
30
  shortDescription: `Avoid usage of specified void types.`,
31
- extendedInformation: `Inspiration:
32
- BOOLEAN, BOOLE_D, CHAR01, CHAR1, CHAR10, CHAR12, CHAR128, CHAR2, CHAR20, CHAR4, CHAR70,
31
+ extendedInformation: `Inspiration:
32
+ BOOLEAN, BOOLE_D, CHAR01, CHAR1, CHAR10, CHAR12, CHAR128, CHAR2, CHAR20, CHAR4, CHAR70,
33
33
  DATS, TIMS, DATUM, FLAG, INT4, NUMC3, NUMC4, SAP_BOOL, TEXT25, TEXT80, X255, XFELD`,
34
34
  };
35
35
  }
@@ -28,26 +28,26 @@ class FunctionalWriting extends _abap_rule_1.ABAPRule {
28
28
  key: "functional_writing",
29
29
  title: "Use functional writing",
30
30
  shortDescription: `Detects usage of call method when functional style calls can be used.`,
31
- extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-calls
31
+ extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-calls
32
32
  https://docs.abapopenchecks.org/checks/07/`,
33
33
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
34
- badExample: `CALL METHOD zcl_class=>method( ).
35
- CALL METHOD cl_abap_typedescr=>describe_by_name
36
- EXPORTING
37
- p_name = 'NAME'
38
- RECEIVING
39
- p_descr_ref = lr_typedescr
40
- EXCEPTIONS
41
- type_not_found = 1
34
+ badExample: `CALL METHOD zcl_class=>method( ).
35
+ CALL METHOD cl_abap_typedescr=>describe_by_name
36
+ EXPORTING
37
+ p_name = 'NAME'
38
+ RECEIVING
39
+ p_descr_ref = lr_typedescr
40
+ EXCEPTIONS
41
+ type_not_found = 1
42
42
  OTHERS = 2.`,
43
- goodExample: `zcl_class=>method( ).
44
- cl_abap_typedescr=>describe_by_name(
45
- EXPORTING
46
- p_name = 'NAME'
47
- RECEIVING
48
- p_descr_ref = lr_typedescr
49
- EXCEPTIONS
50
- type_not_found = 1
43
+ goodExample: `zcl_class=>method( ).
44
+ cl_abap_typedescr=>describe_by_name(
45
+ EXPORTING
46
+ p_name = 'NAME'
47
+ RECEIVING
48
+ p_descr_ref = lr_typedescr
49
+ EXCEPTIONS
50
+ type_not_found = 1
51
51
  OTHERS = 2 ).`,
52
52
  };
53
53
  }
@@ -18,16 +18,16 @@ class GlobalClass extends _abap_rule_1.ABAPRule {
18
18
  return {
19
19
  key: "global_class",
20
20
  title: "Global class checks",
21
- shortDescription: `Checks related to global classes.
22
-
23
- * global classes must be in own files
24
-
25
- * file names must match class name
26
-
27
- * file names must match interface name
28
-
29
- * global classes must be global definitions
30
-
21
+ shortDescription: `Checks related to global classes.
22
+
23
+ * global classes must be in own files
24
+
25
+ * file names must match class name
26
+
27
+ * file names must match interface name
28
+
29
+ * global classes must be global definitions
30
+
31
31
  * global interfaces must be global definitions`,
32
32
  tags: [_irule_1.RuleTag.Syntax],
33
33
  };
@@ -33,8 +33,8 @@ class IdenticalConditions extends _abap_rule_1.ABAPRule {
33
33
  return {
34
34
  key: "identical_conditions",
35
35
  title: "Identical conditions",
36
- shortDescription: `Find identical conditions in IF + CASE + WHILE etc
37
-
36
+ shortDescription: `Find identical conditions in IF + CASE + WHILE etc
37
+
38
38
  Prerequsites: code is pretty printed with identical cAsE`,
39
39
  tags: [_irule_1.RuleTag.SingleFile],
40
40
  };
@@ -19,24 +19,24 @@ class IdenticalContents extends _abap_rule_1.ABAPRule {
19
19
  return {
20
20
  key: "identical_contents",
21
21
  title: "Identical contents",
22
- shortDescription: `Find identical contents in blocks inside IFs, both in the beginning and in the end.
23
-
24
- Prerequsites: code is pretty printed with identical cAsE
25
-
22
+ shortDescription: `Find identical contents in blocks inside IFs, both in the beginning and in the end.`,
23
+ extendedInformation: `
24
+ Prerequsites: code is pretty printed with identical cAsE
25
+
26
26
  Chained statments are ignored`,
27
27
  tags: [_irule_1.RuleTag.SingleFile],
28
- badExample: `IF foo = bar.
29
- WRITE 'bar'.
30
- WRITE 'world'.
31
- ELSE.
32
- WRITE 'foo'.
33
- WRITE 'world'.
28
+ badExample: `IF foo = bar.
29
+ WRITE 'bar'.
30
+ WRITE 'world'.
31
+ ELSE.
32
+ WRITE 'foo'.
33
+ WRITE 'world'.
34
34
  ENDIF.`,
35
- goodExample: `IF foo = bar.
36
- WRITE 'bar'.
37
- ELSE.
38
- WRITE 'foo'.
39
- ENDIF.
35
+ goodExample: `IF foo = bar.
36
+ WRITE 'bar'.
37
+ ELSE.
38
+ WRITE 'foo'.
39
+ ENDIF.
40
40
  WRITE 'world'.`,
41
41
  };
42
42
  }
@@ -16,10 +16,10 @@ class IdenticalDescriptions {
16
16
  key: "identical_descriptions",
17
17
  title: "Identical descriptions",
18
18
  shortDescription: `Searches for objects with the same type and same description`,
19
- extendedInformation: `Case insensitive
20
-
21
- Only checks the master language descriptions
22
-
19
+ extendedInformation: `Case insensitive
20
+
21
+ Only checks the master language descriptions
22
+
23
23
  Works for: INTF, CLAS, DOMA, DTEL, FUNC in same FUGR`,
24
24
  tags: [],
25
25
  };
@@ -19,15 +19,15 @@ class IfInIf extends _abap_rule_1.ABAPRule {
19
19
  key: "if_in_if",
20
20
  title: "IF in IF",
21
21
  shortDescription: `Detects nested ifs which can be refactored to a single condition using AND.`,
22
- extendedInformation: `https://docs.abapopenchecks.org/checks/01/
22
+ extendedInformation: `https://docs.abapopenchecks.org/checks/01/
23
23
  https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#keep-the-nesting-depth-low`,
24
- badExample: `IF condition1.
25
- IF condition2.
26
- ...
27
- ENDIF.
24
+ badExample: `IF condition1.
25
+ IF condition2.
26
+ ...
27
+ ENDIF.
28
28
  ENDIF.`,
29
- goodExample: `IF ( condition1 ) AND ( condition2 ).
30
- ...
29
+ goodExample: `IF ( condition1 ) AND ( condition2 ).
30
+ ...
31
31
  ENDIF.`,
32
32
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
33
33
  };
@@ -102,9 +102,9 @@ class ImplementMethods extends _abap_rule_1.ABAPRule {
102
102
  for (const i of ((_a = file.getStructure()) === null || _a === void 0 ? void 0 : _a.findAllStatements(Statements.ClassImplementation)) || []) {
103
103
  const name = (_b = i.findFirstExpression(Expressions.ClassName)) === null || _b === void 0 ? void 0 : _b.getFirstToken().getStr().toUpperCase();
104
104
  if (name === impl.identifier.getName().toUpperCase()) {
105
- return edit_helper_1.EditHelper.insertAt(file, i.getLastToken().getEnd(), `
106
- METHOD ${methodName.toLowerCase()}.
107
- RETURN. " todo, implement method
105
+ return edit_helper_1.EditHelper.insertAt(file, i.getLastToken().getEnd(), `
106
+ METHOD ${methodName.toLowerCase()}.
107
+ RETURN. " todo, implement method
108
108
  ENDMETHOD.`);
109
109
  }
110
110
  }
@@ -31,19 +31,19 @@ class InStatementIndentation extends _abap_rule_1.ABAPRule {
31
31
  key: "in_statement_indentation",
32
32
  title: "In-statement indentation",
33
33
  shortDescription: "Checks alignment within statements which span multiple lines.",
34
- extendedInformation: `Lines following the first line should be indented once (2 spaces).
35
-
36
- For block declaration statements, lines after the first should be indented an additional time (default: +2 spaces)
34
+ extendedInformation: `Lines following the first line should be indented once (2 spaces).
35
+
36
+ For block declaration statements, lines after the first should be indented an additional time (default: +2 spaces)
37
37
  to distinguish them better from code within the block.`,
38
- badExample: `IF 1 = 1
39
- AND 2 = 2.
40
- WRITE 'hello' &&
41
- 'world'.
38
+ badExample: `IF 1 = 1
39
+ AND 2 = 2.
40
+ WRITE 'hello' &&
41
+ 'world'.
42
42
  ENDIF.`,
43
- goodExample: `IF 1 = 1
44
- AND 2 = 2.
45
- WRITE 'hello' &&
46
- 'world'.
43
+ goodExample: `IF 1 = 1
44
+ AND 2 = 2.
45
+ WRITE 'hello' &&
46
+ 'world'.
47
47
  ENDIF.`,
48
48
  tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
49
49
  };
@@ -26,9 +26,9 @@ class IntfReferencingClas {
26
26
  key: "intf_referencing_clas",
27
27
  title: "INTF referencing CLAS",
28
28
  shortDescription: `Interface contains references to class`,
29
- extendedInformation: `Only global interfaces are checked.
30
- Only first level references are checked.
31
- Exception class references are ignored.
29
+ extendedInformation: `Only global interfaces are checked.
30
+ Only first level references are checked.
31
+ Exception class references are ignored.
32
32
  Void references are ignored.`,
33
33
  };
34
34
  }
@@ -15,8 +15,8 @@ class LineBreakStyle {
15
15
  return {
16
16
  key: "line_break_style",
17
17
  title: "Makes sure line breaks are consistent in the ABAP code",
18
- shortDescription: `Enforces LF as newlines in ABAP files
19
-
18
+ shortDescription: `Enforces LF as newlines in ABAP files
19
+
20
20
  abapGit does not work with CRLF`,
21
21
  tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.SingleFile],
22
22
  };
@@ -23,7 +23,7 @@ class LineLength extends _abap_rule_1.ABAPRule {
23
23
  key: "line_length",
24
24
  title: "Line length",
25
25
  shortDescription: `Detects lines exceeding the provided maximum length.`,
26
- extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#stick-to-a-reasonable-line-length
26
+ extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#stick-to-a-reasonable-line-length
27
27
  https://docs.abapopenchecks.org/checks/04/`,
28
28
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
29
29
  };
@@ -27,7 +27,7 @@ class LineOnlyPunc extends _abap_rule_1.ABAPRule {
27
27
  key: "line_only_punc",
28
28
  title: "Line containing only punctuation",
29
29
  shortDescription: `Detects lines containing only punctuation.`,
30
- extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#close-brackets-at-line-end
30
+ extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#close-brackets-at-line-end
31
31
  https://docs.abapopenchecks.org/checks/16/`,
32
32
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
33
33
  badExample: "zcl_class=>method(\n).",
@@ -6,6 +6,7 @@ const _abap_rule_1 = require("./_abap_rule");
6
6
  const _basic_rule_config_1 = require("./_basic_rule_config");
7
7
  const objects_1 = require("../objects");
8
8
  const _irule_1 = require("./_irule");
9
+ const version_1 = require("../version");
9
10
  class LocalTestclassLocationConf extends _basic_rule_config_1.BasicRuleConfig {
10
11
  }
11
12
  exports.LocalTestclassLocationConf = LocalTestclassLocationConf;
@@ -33,6 +34,10 @@ class LocalTestclassLocation extends _abap_rule_1.ABAPRule {
33
34
  }
34
35
  runParsed(file, obj) {
35
36
  const issues = [];
37
+ if (this.reg.getConfig().getVersion() === version_1.Version.v700) {
38
+ // 700 does not have testclass includes
39
+ return [];
40
+ }
36
41
  if (!(obj instanceof objects_1.Class)) {
37
42
  return [];
38
43
  }