@abaplint/core 2.85.54 → 2.86.2

package/build/src/abap/5_syntax/expressions/source.js

@@ -23,6 +23,7 @@ const corresponding_body_1 = require("./corresponding_body");
 const _builtin_1 = require("../_builtin");
 const attribute_chain_1 = require("./attribute_chain");
 const dereference_1 = require("./dereference");
+const _typed_identifier_1 = require("../../types/_typed_identifier");
 /*
 * Type interference, valid scenarios:
 * typed = VALUE #( ... ).         right hand side must follow left hand type
@@ -170,11 +171,16 @@ class Source {
         const typeExpression = node.findFirstExpression(Expressions.TypeNameOrInfer);
         const typeToken = typeExpression === null || typeExpression === void 0 ? void 0 : typeExpression.getFirstToken();
         const typeName = typeToken === null || typeToken === void 0 ? void 0 : typeToken.getStr();
-        if (typeName === "#" && inferredType) {
+        if (typeName === "#" && inferredType && typeToken) {
             const found = basic.lookupQualifiedName(inferredType.getQualifiedName());
             if (found) {
                 scope.addReference(typeToken, found, _reference_1.ReferenceType.InferredType, filename);
             }
+            else if (inferredType instanceof basic_1.CharacterType) {
+                // character is bit special it does not have a qualified name eg "TYPE c LENGTH 6"
+                const tid = new _typed_identifier_1.TypedIdentifier(typeToken, filename, inferredType);
+                scope.addReference(typeToken, tid, _reference_1.ReferenceType.InferredType, filename);
+            }
         }
     }
     determineType(node, scope, filename, targetType) {

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.85.54";
+        return "2.86.2";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/avoid_use.js

@@ -41,7 +41,9 @@ Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_gu
 
 STATICS: use CLASS-DATA instead
 
-DESCRIBE TABLE LINES: use lines() instead (quickfix exists)`,
+DESCRIBE TABLE LINES: use lines() instead (quickfix exists)
+
+TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-test-seams-as-temporary-workaround`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };
     }
@@ -79,6 +81,9 @@ DESCRIBE TABLE LINES: use lines() instead (quickfix exists)`,
             else if (this.conf.statics && statement instanceof Statements.StaticEnd) {
                 isStaticsBlock = false;
             }
+            else if (this.conf.statics && statement instanceof Statements.TestSeam) {
+                message = "TEST-SEAM";
+            }
             else if (this.conf.statics && statement instanceof Statements.Static && isStaticsBlock === false) {
                 message = "STATICS";
             }

package/build/src/rules/check_text_elements.js

@@ -43,17 +43,20 @@ class CheckTextElements {
             }
             let texts;
             let mainName = undefined;
-            const mains = this.graph.listMainForInclude(file.getFilename());
-            if (mains.length === 1) {
-                // todo, this only checks the first main
-                mainName = mains[0];
-                const main1 = this.reg.findObjectForFile(this.reg.getFileByName(mains[0]));
-                texts = main1.getTexts();
-            }
-            else {
-                texts = obj.getTexts();
-            }
             const expressions = stru.findAllExpressionsMulti([Expressions.TextElement, Expressions.TextElementString]);
+            // optimize: no need to find main and texts if there are no expressions to check
+            if (expressions.length > 0) {
+                const mains = this.graph.listMainForInclude(file.getFilename());
+                if (mains.length === 1) {
+                    // todo, this only checks the first main
+                    mainName = mains[0];
+                    const main1 = this.reg.findObjectForFile(this.reg.getFileByName(mains[0]));
+                    texts = main1.getTexts();
+                }
+                else {
+                    texts = obj.getTexts();
+                }
+            }
             for (const e of expressions) {
                 if (e.get() instanceof Expressions.TextElement) {
                     const token = e.findFirstExpression(Expressions.TextElementKey).getFirstToken();

package/build/src/rules/downport.js

@@ -933,7 +933,7 @@ ${indentation}    output = ${topTarget}.`;
         return { body, end };
     }
     outlineSwitch(node, lowFile, highSyntax) {
-        var _a, _b, _c;
+        var _a, _b, _c, _d;
         for (const i of node.findAllExpressionsRecursive(Expressions.Source)) {
             const firstToken = i.getFirstToken();
             if (firstToken.getStr().toUpperCase() !== "SWITCH") {
@@ -941,8 +941,10 @@ ${indentation}    output = ${topTarget}.`;
             }
             let type = this.findType(i, lowFile, highSyntax);
             if (type === undefined) {
-                if (node.get() instanceof Statements.Move && node.findDirectExpression(Expressions.Source) === i) {
-                    type = "LIKE " + ((_a = node.findDirectExpression(Expressions.Target)) === null || _a === void 0 ? void 0 : _a.concatTokens());
+                if (node.get() instanceof Statements.Move
+                    && node.findDirectExpression(Expressions.Source) === i
+                    && ((_a = node.findDirectExpression(Expressions.Target)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.TargetField)) !== undefined) {
+                    type = "LIKE " + ((_b = node.findDirectExpression(Expressions.Target)) === null || _b === void 0 ? void 0 : _b.concatTokens());
                 }
                 if (type === undefined) {
                     continue;
@@ -959,9 +961,9 @@ ${indentation}    output = ${topTarget}.`;
             if (switchBody === undefined) {
                 continue;
             }
-            for (const l of ((_b = switchBody === null || switchBody === void 0 ? void 0 : switchBody.findDirectExpression(Expressions.Let)) === null || _b === void 0 ? void 0 : _b.findDirectExpressions(Expressions.InlineFieldDefinition)) || []) {
+            for (const l of ((_c = switchBody === null || switchBody === void 0 ? void 0 : switchBody.findDirectExpression(Expressions.Let)) === null || _c === void 0 ? void 0 : _c.findDirectExpressions(Expressions.InlineFieldDefinition)) || []) {
                 name = l.getFirstToken().getStr();
-                body += indentation + `DATA(${name}) = ${(_c = switchBody.findFirstExpression(Expressions.Source)) === null || _c === void 0 ? void 0 : _c.concatTokens()}.\n`;
+                body += indentation + `DATA(${name}) = ${(_d = switchBody.findFirstExpression(Expressions.Source)) === null || _d === void 0 ? void 0 : _d.concatTokens()}.\n`;
             }
             body += `DATA ${uniqueName} ${type}.\n`;
             let firstSource = false;
@@ -1267,6 +1269,7 @@ ${indentation}    output = ${topTarget}.`;
         return undefined;
     }
     outlineCond(node, lowFile, highSyntax) {
+        var _a, _b;
         for (const i of node.findAllExpressionsRecursive(Expressions.Source)) {
             if (i.getFirstToken().getStr().toUpperCase() !== "COND") {
                 continue;
@@ -1276,10 +1279,23 @@ ${indentation}    output = ${topTarget}.`;
                 continue;
             }
             const uniqueName = this.uniqueName(i.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
-            const type = this.findType(i, lowFile, highSyntax);
+            let type = this.findType(i, lowFile, highSyntax);
+            if (type === undefined) {
+                if (node.get() instanceof Statements.Move
+                    && node.findDirectExpression(Expressions.Source) === i
+                    && ((_a = node.findDirectExpression(Expressions.Target)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.TargetField)) !== undefined) {
+                    type = "LIKE " + ((_b = node.findDirectExpression(Expressions.Target)) === null || _b === void 0 ? void 0 : _b.concatTokens());
+                }
+                if (type === undefined) {
+                    continue;
+                }
+            }
+            else {
+                type = "TYPE " + type;
+            }
             const indent = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
             const bodyCode = this.buildCondBody(body, uniqueName, indent, lowFile, highSyntax);
-            const abap = `DATA ${uniqueName} TYPE ${type}.\n` + bodyCode;
+            const abap = `DATA ${uniqueName} ${type}.\n` + bodyCode;
             const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getFirstToken().getStart(), abap);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, i.getFirstToken().getStart(), i.getLastToken().getEnd(), uniqueName);
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);

package/build/src/rules/index.js

@@ -101,6 +101,7 @@ __exportStar(require("./no_aliases"), exports);
 __exportStar(require("./no_chained_assignment"), exports);
 __exportStar(require("./no_public_attributes"), exports);
 __exportStar(require("./no_yoda_conditions"), exports);
+__exportStar(require("./nrob_consistency"), exports);
 __exportStar(require("./object_naming"), exports);
 __exportStar(require("./obsolete_statement"), exports);
 __exportStar(require("./omit_parameter_name"), exports);

package/build/src/rules/many_parentheses.js

@@ -68,9 +68,28 @@ ENDIF.
         for (const m of structure.findAllStatements(Statements.Move)) {
             issues.push(...this.analyzeMove(file, m));
         }
+        for (const m of structure.findAllStatements(Statements.Select)) {
+            issues.push(...this.analyzeInto(file, m));
+        }
         return issues;
     }
     ////////////////////
+    analyzeInto(file, m) {
+        const into = m.findFirstExpression(Expressions.SQLIntoStructure);
+        if (into === undefined) {
+            return [];
+        }
+        const second = into.getAllTokens()[1];
+        if (second === undefined || second.getStr() !== "(") {
+            return [];
+        }
+        const concat = into.concatTokens();
+        if (concat.endsWith(")") === true && concat.includes(",") === false) {
+            const issue = issue_1.Issue.atStatement(file, m, "Too many parentheses", this.getMetadata().key, this.conf.severity);
+            return [issue];
+        }
+        return [];
+    }
     analyzeMove(file, m) {
         const issues = [];
         const children = m.getChildren();

package/build/src/rules/nrob_consistency.js

@@ -0,0 +1,60 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.NROBConsistency = exports.NROBConsistencyConf = void 0;
+const _irule_1 = require("./_irule");
+const issue_1 = require("../issue");
+const Objects = require("../objects");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+class NROBConsistencyConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.NROBConsistencyConf = NROBConsistencyConf;
+class NROBConsistency {
+    constructor() {
+        this.conf = new NROBConsistencyConf();
+    }
+    getMetadata() {
+        return {
+            key: "nrob_consistency",
+            title: "Number range consistency",
+            shortDescription: `Consistency checks for number ranges`,
+            extendedInformation: `Issue reported if percentage warning is over 50%
+
+Issue reported if the referenced domain is not found(taking error namespace into account)`,
+            tags: [_irule_1.RuleTag.SingleFile],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    initialize(reg) {
+        this.reg = reg;
+        return this;
+    }
+    run(obj) {
+        if (!(obj instanceof Objects.NumberRange)) {
+            return [];
+        }
+        const issues = [];
+        const id = obj.getIdentifier();
+        if (id === undefined) {
+            return [];
+        }
+        if (obj.getPercentage() || 0 > 50) {
+            const message = "Percentage more than 50";
+            issues.push(issue_1.Issue.atIdentifier(id, message, this.getMetadata().key, this.getConfig().severity));
+        }
+        const domain = obj.getDomain();
+        if (domain
+            && this.reg.getObject("DOMA", domain) === undefined
+            && this.reg.inErrorNamespace(domain) === true) {
+            const message = "Domain " + domain + " not found";
+            issues.push(issue_1.Issue.atIdentifier(id, message, this.getMetadata().key, this.getConfig().severity));
+        }
+        return [];
+    }
+}
+exports.NROBConsistency = NROBConsistency;
+//# sourceMappingURL=nrob_consistency.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.85.54",
+    "version": "2.86.2",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",