@abaplint/core 2.85.53 → 2.86.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (83) hide show
  1. package/README.md +6 -6
  2. package/build/abaplint.d.ts +5 -0
  3. package/build/src/abap/2_statements/expressions/index.js +1 -0
  4. package/build/src/abap/2_statements/expressions/value_body.js +2 -1
  5. package/build/src/abap/2_statements/expressions/value_body_lines.js +14 -0
  6. package/build/src/abap/5_syntax/expressions/source.js +7 -1
  7. package/build/src/abap/flow/flow_graph.js +7 -7
  8. package/build/src/lsp/help.js +7 -7
  9. package/build/src/registry.js +1 -1
  10. package/build/src/rules/7bit_ascii.js +2 -2
  11. package/build/src/rules/abapdoc.js +1 -1
  12. package/build/src/rules/align_parameters.js +33 -33
  13. package/build/src/rules/ambiguous_statement.js +5 -5
  14. package/build/src/rules/avoid_use.js +12 -7
  15. package/build/src/rules/begin_end_names.js +4 -4
  16. package/build/src/rules/begin_single_include.js +12 -12
  17. package/build/src/rules/call_transaction_authority_check.js +3 -3
  18. package/build/src/rules/chain_mainly_declarations.js +4 -4
  19. package/build/src/rules/check_abstract.js +2 -2
  20. package/build/src/rules/check_comments.js +4 -4
  21. package/build/src/rules/check_include.js +3 -3
  22. package/build/src/rules/check_no_handler_pragma.js +8 -8
  23. package/build/src/rules/check_subrc.js +8 -8
  24. package/build/src/rules/check_text_elements.js +13 -10
  25. package/build/src/rules/commented_code.js +1 -1
  26. package/build/src/rules/constructor_visibility_public.js +4 -4
  27. package/build/src/rules/contains_tab.js +2 -2
  28. package/build/src/rules/dangerous_statement.js +1 -1
  29. package/build/src/rules/downport.js +97 -75
  30. package/build/src/rules/exit_or_check.js +3 -3
  31. package/build/src/rules/exporting.js +1 -1
  32. package/build/src/rules/forbidden_identifier.js +1 -1
  33. package/build/src/rules/forbidden_void_type.js +2 -2
  34. package/build/src/rules/functional_writing.js +17 -17
  35. package/build/src/rules/global_class.js +10 -10
  36. package/build/src/rules/identical_conditions.js +2 -2
  37. package/build/src/rules/identical_contents.js +14 -14
  38. package/build/src/rules/identical_descriptions.js +4 -4
  39. package/build/src/rules/if_in_if.js +7 -7
  40. package/build/src/rules/implement_methods.js +3 -3
  41. package/build/src/rules/in_statement_indentation.js +11 -11
  42. package/build/src/rules/index.js +1 -0
  43. package/build/src/rules/intf_referencing_clas.js +3 -3
  44. package/build/src/rules/line_break_style.js +2 -2
  45. package/build/src/rules/line_length.js +1 -1
  46. package/build/src/rules/line_only_punc.js +1 -1
  47. package/build/src/rules/local_variable_names.js +2 -2
  48. package/build/src/rules/many_parentheses.js +29 -10
  49. package/build/src/rules/max_one_method_parameter_per_line.js +7 -7
  50. package/build/src/rules/max_one_statement.js +3 -3
  51. package/build/src/rules/method_overwrites_builtin.js +2 -2
  52. package/build/src/rules/nesting.js +1 -1
  53. package/build/src/rules/no_chained_assignment.js +1 -1
  54. package/build/src/rules/no_public_attributes.js +1 -1
  55. package/build/src/rules/no_yoda_conditions.js +4 -4
  56. package/build/src/rules/nrob_consistency.js +60 -0
  57. package/build/src/rules/obsolete_statement.js +40 -40
  58. package/build/src/rules/omit_parameter_name.js +3 -3
  59. package/build/src/rules/omit_receiving.js +13 -13
  60. package/build/src/rules/parser_702_chaining.js +2 -2
  61. package/build/src/rules/parser_error.js +2 -2
  62. package/build/src/rules/parser_missing_space.js +1 -1
  63. package/build/src/rules/prefer_inline.js +16 -16
  64. package/build/src/rules/prefer_is_not.js +7 -7
  65. package/build/src/rules/prefer_raise_exception_new.js +3 -3
  66. package/build/src/rules/prefer_returning_to_exporting.js +1 -1
  67. package/build/src/rules/prefer_xsdbool.js +2 -2
  68. package/build/src/rules/remove_descriptions.js +4 -4
  69. package/build/src/rules/rfc_error_handling.js +9 -9
  70. package/build/src/rules/select_add_order_by.js +5 -5
  71. package/build/src/rules/select_performance.js +2 -2
  72. package/build/src/rules/sicf_consistency.js +4 -4
  73. package/build/src/rules/space_before_dot.js +2 -2
  74. package/build/src/rules/start_at_tab.js +1 -1
  75. package/build/src/rules/sy_modification.js +2 -2
  76. package/build/src/rules/tabl_enhancement_category.js +2 -2
  77. package/build/src/rules/unused_methods.js +9 -9
  78. package/build/src/rules/unused_variables.js +6 -6
  79. package/build/src/rules/use_bool_expression.js +8 -8
  80. package/build/src/rules/use_line_exists.js +6 -6
  81. package/build/src/rules/use_new.js +4 -4
  82. package/build/src/rules/when_others_last.js +6 -6
  83. package/package.json +66 -66
package/README.md CHANGED
@@ -1,7 +1,7 @@
1
- # @abaplint/core
2
-
3
- [abaplint](https://abaplint.org/) core library
4
-
5
- Exposes functionality like the parser and rules, which can be used in other projects.
6
-
1
+ # @abaplint/core
2
+
3
+ [abaplint](https://abaplint.org/) core library
4
+
5
+ Exposes functionality like the parser and rules, which can be used in other projects.
6
+
7
7
  For more information see https://github.com/abaplint/abaplint
@@ -1953,6 +1953,7 @@ declare namespace Expressions {
1953
1953
  TypeTable,
1954
1954
  Type_2 as Type,
1955
1955
  ValueBody,
1956
+ ValueBodyLines,
1956
1957
  Value,
1957
1958
  WithName,
1958
1959
  WriteOffsetLength
@@ -6006,6 +6007,10 @@ declare class ValueBody extends Expression {
6006
6007
  getRunnable(): IStatementRunnable;
6007
6008
  }
6008
6009
 
6010
+ declare class ValueBodyLines extends Expression {
6011
+ getRunnable(): IStatementRunnable;
6012
+ }
6013
+
6009
6014
  export declare enum Version {
6010
6015
  OpenABAP = "open-abap",
6011
6016
  v700 = "v700",
@@ -201,6 +201,7 @@ __exportStar(require("./type_table_key"), exports);
201
201
  __exportStar(require("./type_table"), exports);
202
202
  __exportStar(require("./type"), exports);
203
203
  __exportStar(require("./value_body"), exports);
204
+ __exportStar(require("./value_body_lines"), exports);
204
205
  __exportStar(require("./value"), exports);
205
206
  __exportStar(require("./with_name"), exports);
206
207
  __exportStar(require("./write_offset_length"), exports);
@@ -5,11 +5,12 @@ const combi_1 = require("../combi");
5
5
  const tokens_1 = require("../../1_lexer/tokens");
6
6
  const _1 = require(".");
7
7
  const version_1 = require("../../../version");
8
+ const value_body_lines_1 = require("./value_body_lines");
8
9
  class ValueBody extends combi_1.Expression {
9
10
  getRunnable() {
10
11
  const base = (0, combi_1.seq)("BASE", _1.Source);
11
12
  // missing spaces caught by rule "parser_missing_space"
12
- const foo = (0, combi_1.seq)((0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.WParenLeftW), (0, combi_1.tok)(tokens_1.WParenLeft)), (0, combi_1.optPrio)((0, combi_1.altPrio)((0, combi_1.plusPrio)(_1.FieldAssignment), (0, combi_1.seq)((0, combi_1.optPrio)("LINES OF"), _1.Source))), (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.WParenRightW), (0, combi_1.tok)(tokens_1.ParenRightW)));
13
+ const foo = (0, combi_1.seq)((0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.WParenLeftW), (0, combi_1.tok)(tokens_1.WParenLeft)), (0, combi_1.optPrio)((0, combi_1.altPrio)((0, combi_1.plusPrio)(_1.FieldAssignment), value_body_lines_1.ValueBodyLines, _1.Source)), (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.WParenRightW), (0, combi_1.tok)(tokens_1.ParenRightW)));
13
14
  const strucOrTab = (0, combi_1.seq)((0, combi_1.optPrio)(_1.Let), (0, combi_1.optPrio)(base), (0, combi_1.star)(_1.For), (0, combi_1.plusPrio)((0, combi_1.altPrio)(_1.FieldAssignment, foo)));
14
15
  const tabdef = (0, combi_1.ver)(version_1.Version.v740sp08, (0, combi_1.altPrio)("OPTIONAL", (0, combi_1.seq)("DEFAULT", _1.Source)));
15
16
  return (0, combi_1.optPrio)((0, combi_1.altPrio)(strucOrTab, (0, combi_1.seq)(_1.Source, (0, combi_1.optPrio)(tabdef))));
@@ -0,0 +1,14 @@
1
+ "use strict";
2
+ Object.defineProperty(exports, "__esModule", { value: true });
3
+ exports.ValueBodyLines = void 0;
4
+ const combi_1 = require("../combi");
5
+ const _1 = require(".");
6
+ class ValueBodyLines extends combi_1.Expression {
7
+ getRunnable() {
8
+ const range = (0, combi_1.seq)((0, combi_1.optPrio)((0, combi_1.seq)("FROM", _1.Source)), (0, combi_1.optPrio)((0, combi_1.seq)("TO", _1.Source)));
9
+ const lines = (0, combi_1.seq)("LINES OF", _1.Source, range);
10
+ return lines;
11
+ }
12
+ }
13
+ exports.ValueBodyLines = ValueBodyLines;
14
+ //# sourceMappingURL=value_body_lines.js.map
@@ -23,6 +23,7 @@ const corresponding_body_1 = require("./corresponding_body");
23
23
  const _builtin_1 = require("../_builtin");
24
24
  const attribute_chain_1 = require("./attribute_chain");
25
25
  const dereference_1 = require("./dereference");
26
+ const _typed_identifier_1 = require("../../types/_typed_identifier");
26
27
  /*
27
28
  * Type interference, valid scenarios:
28
29
  * typed = VALUE #( ... ). right hand side must follow left hand type
@@ -170,11 +171,16 @@ class Source {
170
171
  const typeExpression = node.findFirstExpression(Expressions.TypeNameOrInfer);
171
172
  const typeToken = typeExpression === null || typeExpression === void 0 ? void 0 : typeExpression.getFirstToken();
172
173
  const typeName = typeToken === null || typeToken === void 0 ? void 0 : typeToken.getStr();
173
- if (typeName === "#" && inferredType) {
174
+ if (typeName === "#" && inferredType && typeToken) {
174
175
  const found = basic.lookupQualifiedName(inferredType.getQualifiedName());
175
176
  if (found) {
176
177
  scope.addReference(typeToken, found, _reference_1.ReferenceType.InferredType, filename);
177
178
  }
179
+ else if (inferredType instanceof basic_1.CharacterType) {
180
+ // character is bit special it does not have a qualified name eg "TYPE c LENGTH 6"
181
+ const tid = new _typed_identifier_1.TypedIdentifier(typeToken, filename, inferredType);
182
+ scope.addReference(typeToken, tid, _reference_1.ReferenceType.InferredType, filename);
183
+ }
178
184
  }
179
185
  }
180
186
  determineType(node, scope, filename, targetType) {
@@ -72,13 +72,13 @@ class FlowGraph {
72
72
  this.label = label;
73
73
  }
74
74
  toDigraph() {
75
- return `digraph G {
76
- labelloc="t";
77
- label="${this.label}";
78
- graph [fontname = "helvetica"];
79
- node [fontname = "helvetica", shape="box"];
80
- edge [fontname = "helvetica"];
81
- ${this.toTextEdges()}
75
+ return `digraph G {
76
+ labelloc="t";
77
+ label="${this.label}";
78
+ graph [fontname = "helvetica"];
79
+ node [fontname = "helvetica", shape="box"];
80
+ edge [fontname = "helvetica"];
81
+ ${this.toTextEdges()}
82
82
  }`;
83
83
  }
84
84
  listSources(node) {
@@ -19,13 +19,13 @@ class Help {
19
19
  /////////////////////////////////////////////////
20
20
  static dumpABAP(file, reg, textDocument, position) {
21
21
  let content = "";
22
- content = `
23
- <a href="#_tokens" rel="no-refresh">Tokens</a> |
24
- <a href="#_statements" rel="no-refresh">Statements</a> |
25
- <a href="#_structure" rel="no-refresh">Structure</a> |
26
- <a href="#_files" rel="no-refresh">Files</a> |
27
- <a href="#_info" rel="no-refresh">Info Dump</a>
28
- <hr>
22
+ content = `
23
+ <a href="#_tokens" rel="no-refresh">Tokens</a> |
24
+ <a href="#_statements" rel="no-refresh">Statements</a> |
25
+ <a href="#_structure" rel="no-refresh">Structure</a> |
26
+ <a href="#_files" rel="no-refresh">Files</a> |
27
+ <a href="#_info" rel="no-refresh">Info Dump</a>
28
+ <hr>
29
29
  ` +
30
30
  "<tt>" + textDocument.uri + " (" +
31
31
  (position.line + 1) + ", " +
@@ -68,7 +68,7 @@ class Registry {
68
68
  }
69
69
  static abaplintVersion() {
70
70
  // magic, see build script "version.sh"
71
- return "2.85.53";
71
+ return "2.86.1";
72
72
  }
73
73
  getDDICReferences() {
74
74
  return this.references;
@@ -17,8 +17,8 @@ class SevenBitAscii {
17
17
  key: "7bit_ascii",
18
18
  title: "Check for 7bit ascii",
19
19
  shortDescription: `Only allow characters from the 7bit ASCII set.`,
20
- extendedInformation: `https://docs.abapopenchecks.org/checks/05/
21
-
20
+ extendedInformation: `https://docs.abapopenchecks.org/checks/05/
21
+
22
22
  Checkes files with extension ".abap" and ".asddls"`,
23
23
  tags: [_irule_1.RuleTag.SingleFile],
24
24
  };
@@ -23,7 +23,7 @@ class Abapdoc extends _abap_rule_1.ABAPRule {
23
23
  return {
24
24
  key: "abapdoc",
25
25
  title: "Check abapdoc",
26
- shortDescription: `Various checks regarding abapdoc.
26
+ shortDescription: `Various checks regarding abapdoc.
27
27
  Base rule checks for existence of abapdoc for public class methods and all interface methods.`,
28
28
  tags: [_irule_1.RuleTag.SingleFile],
29
29
  };
@@ -20,42 +20,42 @@ class AlignParameters extends _abap_rule_1.ABAPRule {
20
20
  key: "align_parameters",
21
21
  title: "Align Parameters",
22
22
  shortDescription: `Checks for vertially aligned parameters`,
23
- extendedInformation: `Checks:
24
- * function module calls
25
- * method calls
26
- * VALUE constructors
27
- * NEW constructors
28
- * RAISE EXCEPTION statements
29
- * CREATE OBJECT statements
30
- * RAISE EVENT statements
31
-
32
- https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
33
-
34
- Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
35
-
23
+ extendedInformation: `Checks:
24
+ * function module calls
25
+ * method calls
26
+ * VALUE constructors
27
+ * NEW constructors
28
+ * RAISE EXCEPTION statements
29
+ * CREATE OBJECT statements
30
+ * RAISE EVENT statements
31
+
32
+ https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
33
+
34
+ Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
35
+
36
36
  Also https://rules.abaplint.org/max_one_method_parameter_per_line/ can help aligning parameter syntax`,
37
37
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide],
38
- badExample: `CALL FUNCTION 'FOOBAR'
39
- EXPORTING
40
- foo = 2
41
- parameter = 3.
42
-
43
- foobar( moo = 1
44
- param = 1 ).
45
-
46
- foo = VALUE #(
47
- foo = bar
38
+ badExample: `CALL FUNCTION 'FOOBAR'
39
+ EXPORTING
40
+ foo = 2
41
+ parameter = 3.
42
+
43
+ foobar( moo = 1
44
+ param = 1 ).
45
+
46
+ foo = VALUE #(
47
+ foo = bar
48
48
  moo = 2 ).`,
49
- goodExample: `CALL FUNCTION 'FOOBAR'
50
- EXPORTING
51
- foo = 2
52
- parameter = 3.
53
-
54
- foobar( moo = 1
55
- param = 1 ).
56
-
57
- foo = VALUE #(
58
- foo = bar
49
+ goodExample: `CALL FUNCTION 'FOOBAR'
50
+ EXPORTING
51
+ foo = 2
52
+ parameter = 3.
53
+
54
+ foobar( moo = 1
55
+ param = 1 ).
56
+
57
+ foo = VALUE #(
58
+ foo = bar
59
59
  moo = 2 ).`,
60
60
  };
61
61
  }
@@ -20,14 +20,14 @@ class AmbiguousStatement extends _abap_rule_1.ABAPRule {
20
20
  return {
21
21
  key: "ambiguous_statement",
22
22
  title: "Check for ambigious statements",
23
- shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
24
- Add "TABLE" keyword or "@" for escaping SQL variables
25
-
23
+ shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
24
+ Add "TABLE" keyword or "@" for escaping SQL variables
25
+
26
26
  Only works if the target version is 740sp05 or above`,
27
27
  tags: [_irule_1.RuleTag.SingleFile],
28
- badExample: `DELETE foo FROM bar.
28
+ badExample: `DELETE foo FROM bar.
29
29
  MODIFY foo FROM bar.`,
30
- goodExample: `DELETE foo FROM @bar.
30
+ goodExample: `DELETE foo FROM @bar.
31
31
  MODIFY TABLE foo FROM bar.`,
32
32
  };
33
33
  }
@@ -35,13 +35,15 @@ class AvoidUse extends _abap_rule_1.ABAPRule {
35
35
  key: "avoid_use",
36
36
  title: "Avoid use of certain statements",
37
37
  shortDescription: `Detects usage of certain statements.`,
38
- extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
39
-
40
- Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
41
-
42
- STATICS: use CLASS-DATA instead
43
-
44
- DESCRIBE TABLE LINES: use lines() instead (quickfix exists)`,
38
+ extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
39
+
40
+ Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
41
+
42
+ STATICS: use CLASS-DATA instead
43
+
44
+ DESCRIBE TABLE LINES: use lines() instead (quickfix exists)
45
+
46
+ TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-test-seams-as-temporary-workaround`,
45
47
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
46
48
  };
47
49
  }
@@ -79,6 +81,9 @@ DESCRIBE TABLE LINES: use lines() instead (quickfix exists)`,
79
81
  else if (this.conf.statics && statement instanceof Statements.StaticEnd) {
80
82
  isStaticsBlock = false;
81
83
  }
84
+ else if (this.conf.statics && statement instanceof Statements.TestSeam) {
85
+ message = "TEST-SEAM";
86
+ }
82
87
  else if (this.conf.statics && statement instanceof Statements.Static && isStaticsBlock === false) {
83
88
  message = "STATICS";
84
89
  }
@@ -23,11 +23,11 @@ class BeginEndNames extends _abap_rule_1.ABAPRule {
23
23
  title: "Check BEGIN END names",
24
24
  shortDescription: `Check BEGIN OF and END OF names match, plus there must be statements between BEGIN and END`,
25
25
  tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
26
- badExample: `DATA: BEGIN OF stru,
27
- field TYPE i,
26
+ badExample: `DATA: BEGIN OF stru,
27
+ field TYPE i,
28
28
  END OF structure_not_the_same.`,
29
- goodExample: `DATA: BEGIN OF stru,
30
- field TYPE i,
29
+ goodExample: `DATA: BEGIN OF stru,
30
+ field TYPE i,
31
31
  END OF stru.`,
32
32
  };
33
33
  }
@@ -21,19 +21,19 @@ class BeginSingleInclude extends _abap_rule_1.ABAPRule {
21
21
  title: "BEGIN contains single INCLUDE",
22
22
  shortDescription: `Finds TYPE BEGIN with just one INCLUDE TYPE, and DATA with single INCLUDE STRUCTURE`,
23
23
  tags: [_irule_1.RuleTag.SingleFile],
24
- badExample: `TYPES: BEGIN OF dummy1.
25
- INCLUDE TYPE dselc.
26
- TYPES: END OF dummy1.
27
-
28
- DATA BEGIN OF foo.
29
- INCLUDE STRUCTURE syst.
30
- DATA END OF foo.
31
-
32
- STATICS BEGIN OF bar.
33
- INCLUDE STRUCTURE syst.
24
+ badExample: `TYPES: BEGIN OF dummy1.
25
+ INCLUDE TYPE dselc.
26
+ TYPES: END OF dummy1.
27
+
28
+ DATA BEGIN OF foo.
29
+ INCLUDE STRUCTURE syst.
30
+ DATA END OF foo.
31
+
32
+ STATICS BEGIN OF bar.
33
+ INCLUDE STRUCTURE syst.
34
34
  STATICS END OF bar.`,
35
- goodExample: `DATA BEGIN OF foo.
36
- INCLUDE STRUCTURE dselc.
35
+ goodExample: `DATA BEGIN OF foo.
36
+ INCLUDE STRUCTURE dselc.
37
37
  DATA END OF foo.`,
38
38
  };
39
39
  }
@@ -24,9 +24,9 @@ class CallTransactionAuthorityCheck extends _abap_rule_1.ABAPRule {
24
24
  extendedInformation: `https://docs.abapopenchecks.org/checks/54/`,
25
25
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
26
26
  badExample: `CALL TRANSACTION 'FOO'.`,
27
- goodExample: `TRY.
28
- CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.
29
- CATCH cx_sy_authorization_error.
27
+ goodExample: `TRY.
28
+ CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.
29
+ CATCH cx_sy_authorization_error.
30
30
  ENDTRY.`,
31
31
  };
32
32
  }
@@ -45,10 +45,10 @@ class ChainMainlyDeclarations extends _abap_rule_1.ABAPRule {
45
45
  key: "chain_mainly_declarations",
46
46
  title: "Chain mainly declarations",
47
47
  shortDescription: `Chain mainly declarations, allows chaining for the configured statements, reports errors for other statements.`,
48
- extendedInformation: `
49
- https://docs.abapopenchecks.org/checks/23/
50
-
51
- https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
48
+ extendedInformation: `
49
+ https://docs.abapopenchecks.org/checks/23/
50
+
51
+ https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
52
52
  `,
53
53
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
54
54
  badExample: `CALL METHOD: bar.`,
@@ -23,8 +23,8 @@ class CheckAbstract extends _abap_rule_1.ABAPRule {
23
23
  return {
24
24
  key: "check_abstract",
25
25
  title: "Check abstract methods and classes",
26
- shortDescription: `Checks abstract methods and classes:
27
- - class defined as abstract and final,
26
+ shortDescription: `Checks abstract methods and classes:
27
+ - class defined as abstract and final,
28
28
  - non-abstract class contains abstract methods`,
29
29
  extendedInformation: `If a class defines only constants, use an interface instead`,
30
30
  tags: [_irule_1.RuleTag.SingleFile],
@@ -27,11 +27,11 @@ class CheckComments extends _abap_rule_1.ABAPRule {
27
27
  return {
28
28
  key: "check_comments",
29
29
  title: "Check Comments",
30
- shortDescription: `
30
+ shortDescription: `
31
31
  Various checks for comment usage.`,
32
- extendedInformation: `
33
- * End of line comments. Comments starting with "#EC" or "##" are ignored
34
-
32
+ extendedInformation: `
33
+ * End of line comments. Comments starting with "#EC" or "##" are ignored
34
+
35
35
  https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#put-comments-before-the-statement-they-relate-to`,
36
36
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
37
37
  };
@@ -17,9 +17,9 @@ class CheckInclude {
17
17
  key: "check_include",
18
18
  title: "Check INCLUDEs",
19
19
  shortDescription: `Checks INCLUDE statements`,
20
- extendedInformation: `
21
- * Reports unused includes
22
- * Errors if the includes are not found
20
+ extendedInformation: `
21
+ * Reports unused includes
22
+ * Errors if the includes are not found
23
23
  * Error if including a main program`,
24
24
  tags: [_irule_1.RuleTag.Syntax],
25
25
  };
@@ -21,15 +21,15 @@ class CheckNoHandlerPragma extends _abap_rule_1.ABAPRule {
21
21
  title: "Check if NO_HANDLER can be removed",
22
22
  shortDescription: `Checks NO_HANDLER pragmas that can be removed`,
23
23
  tags: [_irule_1.RuleTag.SingleFile],
24
- badExample: `TRY.
25
- ...
26
- CATCH zcx_abapgit_exception ##NO_HANDLER.
27
- RETURN. " it has a handler
24
+ badExample: `TRY.
25
+ ...
26
+ CATCH zcx_abapgit_exception ##NO_HANDLER.
27
+ RETURN. " it has a handler
28
28
  ENDTRY.`,
29
- goodExample: `TRY.
30
- ...
31
- CATCH zcx_abapgit_exception.
32
- RETURN.
29
+ goodExample: `TRY.
30
+ ...
31
+ CATCH zcx_abapgit_exception.
32
+ RETURN.
33
33
  ENDTRY.`,
34
34
  };
35
35
  }
@@ -34,14 +34,14 @@ class CheckSubrc extends _abap_rule_1.ABAPRule {
34
34
  key: "check_subrc",
35
35
  title: "Check sy-subrc",
36
36
  shortDescription: `Check sy-subrc`,
37
- extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
38
-
39
- If sy-dbcnt is checked after database statements, it is considered okay.
40
-
41
- "SELECT SINGLE @abap_true FROM " is considered as an existence check
42
-
43
- If IS ASSIGNED is checked after assigning, it is considered okay.
44
-
37
+ extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
38
+
39
+ If sy-dbcnt is checked after database statements, it is considered okay.
40
+
41
+ "SELECT SINGLE @abap_true FROM " is considered as an existence check
42
+
43
+ If IS ASSIGNED is checked after assigning, it is considered okay.
44
+
45
45
  FIND statement with MATCH COUNT is considered okay if subrc is not checked`,
46
46
  tags: [_irule_1.RuleTag.SingleFile],
47
47
  pseudoComment: "EC CI_SUBRC",
@@ -43,17 +43,20 @@ class CheckTextElements {
43
43
  }
44
44
  let texts;
45
45
  let mainName = undefined;
46
- const mains = this.graph.listMainForInclude(file.getFilename());
47
- if (mains.length === 1) {
48
- // todo, this only checks the first main
49
- mainName = mains[0];
50
- const main1 = this.reg.findObjectForFile(this.reg.getFileByName(mains[0]));
51
- texts = main1.getTexts();
52
- }
53
- else {
54
- texts = obj.getTexts();
55
- }
56
46
  const expressions = stru.findAllExpressionsMulti([Expressions.TextElement, Expressions.TextElementString]);
47
+ // optimize: no need to find main and texts if there are no expressions to check
48
+ if (expressions.length > 0) {
49
+ const mains = this.graph.listMainForInclude(file.getFilename());
50
+ if (mains.length === 1) {
51
+ // todo, this only checks the first main
52
+ mainName = mains[0];
53
+ const main1 = this.reg.findObjectForFile(this.reg.getFileByName(mains[0]));
54
+ texts = main1.getTexts();
55
+ }
56
+ else {
57
+ texts = obj.getTexts();
58
+ }
59
+ }
57
60
  for (const e of expressions) {
58
61
  if (e.get() instanceof Expressions.TextElement) {
59
62
  const token = e.findFirstExpression(Expressions.TextElementKey).getFirstToken();
@@ -30,7 +30,7 @@ class CommentedCode extends _abap_rule_1.ABAPRule {
30
30
  key: "commented_code",
31
31
  title: "Find commented code",
32
32
  shortDescription: `Detects usage of commented out code.`,
33
- extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
33
+ extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
34
34
  https://docs.abapopenchecks.org/checks/14/`,
35
35
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
36
36
  };
@@ -18,10 +18,10 @@ class ConstructorVisibilityPublic {
18
18
  key: "constructor_visibility_public",
19
19
  title: "Check constructor visibility is public",
20
20
  shortDescription: `Constructor must be placed in the public section, even if the class is not CREATE PUBLIC.`,
21
- extendedInformation: `
22
- This only applies to global classes.
23
-
24
- https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
21
+ extendedInformation: `
22
+ This only applies to global classes.
23
+
24
+ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
25
25
  https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abeninstance_constructor_guidl.htm`,
26
26
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
27
27
  };
@@ -25,8 +25,8 @@ class ContainsTab extends _abap_rule_1.ABAPRule {
25
25
  key: "contains_tab",
26
26
  title: "Code contains tab",
27
27
  shortDescription: `Checks for usage of tabs (enable to enforce spaces)`,
28
- extendedInformation: `
29
- https://docs.abapopenchecks.org/checks/09/
28
+ extendedInformation: `
29
+ https://docs.abapopenchecks.org/checks/09/
30
30
  https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#indent-and-snap-to-tab`,
31
31
  tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
32
32
  };
@@ -40,7 +40,7 @@ class DangerousStatement extends _abap_rule_1.ABAPRule {
40
40
  key: "dangerous_statement",
41
41
  title: "Dangerous statement",
42
42
  shortDescription: `Detects potentially dangerous statements`,
43
- extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
43
+ extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
44
44
  dynamic SQL can potentially create SQL injection problems`,
45
45
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
46
46
  };