@abaplint/core 2.85.50 → 2.85.53
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +6 -6
- package/build/src/abap/2_statements/expressions/for.js +2 -2
- package/build/src/abap/2_statements/expressions/reduce_body.js +1 -1
- package/build/src/abap/2_statements/expressions/value_body.js +1 -1
- package/build/src/abap/5_syntax/expressions/reduce_body.js +2 -3
- package/build/src/abap/5_syntax/expressions/value_body.js +2 -3
- package/build/src/abap/flow/flow_graph.js +7 -7
- package/build/src/lsp/help.js +7 -7
- package/build/src/registry.js +1 -1
- package/build/src/rules/7bit_ascii.js +2 -2
- package/build/src/rules/abapdoc.js +1 -1
- package/build/src/rules/align_parameters.js +33 -33
- package/build/src/rules/ambiguous_statement.js +5 -5
- package/build/src/rules/avoid_use.js +6 -6
- package/build/src/rules/begin_end_names.js +4 -4
- package/build/src/rules/begin_single_include.js +12 -12
- package/build/src/rules/call_transaction_authority_check.js +3 -3
- package/build/src/rules/chain_mainly_declarations.js +4 -4
- package/build/src/rules/check_abstract.js +2 -2
- package/build/src/rules/check_comments.js +4 -4
- package/build/src/rules/check_include.js +3 -3
- package/build/src/rules/check_no_handler_pragma.js +8 -8
- package/build/src/rules/check_subrc.js +8 -8
- package/build/src/rules/commented_code.js +1 -1
- package/build/src/rules/constructor_visibility_public.js +4 -4
- package/build/src/rules/contains_tab.js +2 -2
- package/build/src/rules/dangerous_statement.js +1 -1
- package/build/src/rules/downport.js +80 -68
- package/build/src/rules/exit_or_check.js +3 -3
- package/build/src/rules/exporting.js +1 -1
- package/build/src/rules/forbidden_identifier.js +1 -1
- package/build/src/rules/forbidden_void_type.js +2 -2
- package/build/src/rules/functional_writing.js +17 -17
- package/build/src/rules/global_class.js +10 -10
- package/build/src/rules/identical_conditions.js +2 -2
- package/build/src/rules/identical_contents.js +14 -14
- package/build/src/rules/identical_descriptions.js +4 -4
- package/build/src/rules/if_in_if.js +7 -7
- package/build/src/rules/implement_methods.js +3 -3
- package/build/src/rules/in_statement_indentation.js +11 -11
- package/build/src/rules/intf_referencing_clas.js +3 -3
- package/build/src/rules/line_break_style.js +2 -2
- package/build/src/rules/line_length.js +1 -1
- package/build/src/rules/line_only_punc.js +1 -1
- package/build/src/rules/local_variable_names.js +2 -2
- package/build/src/rules/many_parentheses.js +10 -10
- package/build/src/rules/max_one_method_parameter_per_line.js +7 -7
- package/build/src/rules/max_one_statement.js +3 -3
- package/build/src/rules/method_overwrites_builtin.js +2 -2
- package/build/src/rules/nesting.js +1 -1
- package/build/src/rules/no_chained_assignment.js +1 -1
- package/build/src/rules/no_public_attributes.js +1 -1
- package/build/src/rules/no_yoda_conditions.js +4 -4
- package/build/src/rules/obsolete_statement.js +40 -40
- package/build/src/rules/omit_parameter_name.js +3 -3
- package/build/src/rules/omit_receiving.js +13 -13
- package/build/src/rules/parser_702_chaining.js +2 -2
- package/build/src/rules/parser_error.js +2 -2
- package/build/src/rules/parser_missing_space.js +1 -1
- package/build/src/rules/prefer_inline.js +16 -16
- package/build/src/rules/prefer_is_not.js +7 -7
- package/build/src/rules/prefer_raise_exception_new.js +3 -3
- package/build/src/rules/prefer_returning_to_exporting.js +1 -1
- package/build/src/rules/prefer_xsdbool.js +2 -2
- package/build/src/rules/remove_descriptions.js +4 -4
- package/build/src/rules/rfc_error_handling.js +9 -9
- package/build/src/rules/select_add_order_by.js +5 -5
- package/build/src/rules/select_performance.js +2 -2
- package/build/src/rules/sicf_consistency.js +4 -4
- package/build/src/rules/space_before_dot.js +2 -2
- package/build/src/rules/start_at_tab.js +1 -1
- package/build/src/rules/sy_modification.js +2 -2
- package/build/src/rules/tabl_enhancement_category.js +2 -2
- package/build/src/rules/unused_methods.js +9 -9
- package/build/src/rules/unused_variables.js +6 -6
- package/build/src/rules/use_bool_expression.js +8 -8
- package/build/src/rules/use_line_exists.js +6 -6
- package/build/src/rules/use_new.js +4 -4
- package/build/src/rules/when_others_last.js +6 -6
- package/package.json +66 -66
|
@@ -35,33 +35,33 @@ class Downport {
|
|
|
35
35
|
key: "downport",
|
|
36
36
|
title: "Downport statement",
|
|
37
37
|
shortDescription: `Experimental downport functionality`,
|
|
38
|
-
extendedInformation: `Much like the 'commented_code' rule this rule loops through unknown statements and tries parsing with
|
|
39
|
-
a higher level language version. If successful, various rules are applied to downport the statement.
|
|
40
|
-
Target downport version is always v702, thus rule is only enabled if target version is v702.
|
|
41
|
-
|
|
42
|
-
Current rules:
|
|
43
|
-
* NEW transformed to CREATE OBJECT, opposite of https://rules.abaplint.org/use_new/
|
|
44
|
-
* DATA() definitions are outlined, opposite of https://rules.abaplint.org/prefer_inline/
|
|
45
|
-
* FIELD-SYMBOL() definitions are outlined
|
|
46
|
-
* CONV is outlined
|
|
47
|
-
* COND is outlined
|
|
48
|
-
* REDUCE is outlined
|
|
49
|
-
* SWITCH is outlined
|
|
50
|
-
* APPEND expression is outlined
|
|
51
|
-
* EMPTY KEY is changed to DEFAULT KEY, opposite of DEFAULT KEY in https://rules.abaplint.org/avoid_use/
|
|
52
|
-
* CAST changed to ?=
|
|
53
|
-
* LOOP AT method_call( ) is outlined
|
|
54
|
-
* VALUE # with structure fields
|
|
55
|
-
* VALUE # with internal table lines
|
|
56
|
-
* Table Expressions are outlined
|
|
57
|
-
* SELECT INTO @DATA definitions are outlined
|
|
58
|
-
* Some occurrences of string template formatting option ALPHA changed to function module call
|
|
59
|
-
* SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
|
|
60
|
-
* PARTIALLY IMPLEMENTED removed, it can be quick fixed via rule implement_methods
|
|
61
|
-
* RAISE EXCEPTION ... MESSAGE
|
|
62
|
-
* Moving with +=, -=, /=, *=, &&= is expanded
|
|
63
|
-
* line_exists and line_index is downported to READ TABLE
|
|
64
|
-
|
|
38
|
+
extendedInformation: `Much like the 'commented_code' rule this rule loops through unknown statements and tries parsing with
|
|
39
|
+
a higher level language version. If successful, various rules are applied to downport the statement.
|
|
40
|
+
Target downport version is always v702, thus rule is only enabled if target version is v702.
|
|
41
|
+
|
|
42
|
+
Current rules:
|
|
43
|
+
* NEW transformed to CREATE OBJECT, opposite of https://rules.abaplint.org/use_new/
|
|
44
|
+
* DATA() definitions are outlined, opposite of https://rules.abaplint.org/prefer_inline/
|
|
45
|
+
* FIELD-SYMBOL() definitions are outlined
|
|
46
|
+
* CONV is outlined
|
|
47
|
+
* COND is outlined
|
|
48
|
+
* REDUCE is outlined
|
|
49
|
+
* SWITCH is outlined
|
|
50
|
+
* APPEND expression is outlined
|
|
51
|
+
* EMPTY KEY is changed to DEFAULT KEY, opposite of DEFAULT KEY in https://rules.abaplint.org/avoid_use/
|
|
52
|
+
* CAST changed to ?=
|
|
53
|
+
* LOOP AT method_call( ) is outlined
|
|
54
|
+
* VALUE # with structure fields
|
|
55
|
+
* VALUE # with internal table lines
|
|
56
|
+
* Table Expressions are outlined
|
|
57
|
+
* SELECT INTO @DATA definitions are outlined
|
|
58
|
+
* Some occurrences of string template formatting option ALPHA changed to function module call
|
|
59
|
+
* SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
|
|
60
|
+
* PARTIALLY IMPLEMENTED removed, it can be quick fixed via rule implement_methods
|
|
61
|
+
* RAISE EXCEPTION ... MESSAGE
|
|
62
|
+
* Moving with +=, -=, /=, *=, &&= is expanded
|
|
63
|
+
* line_exists and line_index is downported to READ TABLE
|
|
64
|
+
|
|
65
65
|
Only one transformation is applied to a statement at a time, so multiple steps might be required to do the full downport.`,
|
|
66
66
|
tags: [_irule_1.RuleTag.Experimental, _irule_1.RuleTag.Downport, _irule_1.RuleTag.Quickfix],
|
|
67
67
|
};
|
|
@@ -390,10 +390,10 @@ Only one transformation is applied to a statement at a time, so multiple steps m
|
|
|
390
390
|
const fieldName = f.concatTokens();
|
|
391
391
|
fieldDefinition += indentation + " " + fieldName + " TYPE " + tableName + "-" + fieldName + ",\n";
|
|
392
392
|
}
|
|
393
|
-
fieldDefinition = `DATA: BEGIN OF ${name},
|
|
393
|
+
fieldDefinition = `DATA: BEGIN OF ${name},
|
|
394
394
|
${fieldDefinition}${indentation} END OF ${name}.`;
|
|
395
395
|
}
|
|
396
|
-
const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `${fieldDefinition}
|
|
396
|
+
const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `${fieldDefinition}
|
|
397
397
|
${indentation}`);
|
|
398
398
|
const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, inlineData.getFirstToken().getStart(), inlineData.getLastToken().getEnd(), name);
|
|
399
399
|
const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
|
|
@@ -434,12 +434,12 @@ ${indentation}`);
|
|
|
434
434
|
}
|
|
435
435
|
const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
|
|
436
436
|
const name = ((_c = inlineData.findFirstExpression(Expressions.TargetField)) === null || _c === void 0 ? void 0 : _c.concatTokens()) || "error";
|
|
437
|
-
let fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `TYPES: BEGIN OF ${uniqueName},
|
|
438
|
-
${fieldDefinitions}${indentation} END OF ${uniqueName}.
|
|
439
|
-
${indentation}DATA ${name} TYPE STANDARD TABLE OF ${uniqueName} WITH DEFAULT KEY.
|
|
437
|
+
let fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `TYPES: BEGIN OF ${uniqueName},
|
|
438
|
+
${fieldDefinitions}${indentation} END OF ${uniqueName}.
|
|
439
|
+
${indentation}DATA ${name} TYPE STANDARD TABLE OF ${uniqueName} WITH DEFAULT KEY.
|
|
440
440
|
${indentation}`);
|
|
441
441
|
if (fieldDefinitions === "") {
|
|
442
|
-
fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `DATA ${name} TYPE STANDARD TABLE OF ${tableName} WITH DEFAULT KEY.
|
|
442
|
+
fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `DATA ${name} TYPE STANDARD TABLE OF ${tableName} WITH DEFAULT KEY.
|
|
443
443
|
${indentation}`);
|
|
444
444
|
}
|
|
445
445
|
const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, inlineData.getFirstToken().getStart(), inlineData.getLastToken().getEnd(), name);
|
|
@@ -460,7 +460,7 @@ ${indentation}`);
|
|
|
460
460
|
const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
|
|
461
461
|
const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
|
|
462
462
|
const firstToken = high.getFirstToken();
|
|
463
|
-
const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${target === null || target === void 0 ? void 0 : target.concatTokens()}.
|
|
463
|
+
const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${target === null || target === void 0 ? void 0 : target.concatTokens()}.
|
|
464
464
|
${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
|
|
465
465
|
const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, source.getFirstToken().getStart(), source.getLastToken().getEnd(), uniqueName);
|
|
466
466
|
const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
|
|
@@ -509,11 +509,11 @@ ${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
|
|
|
509
509
|
const uniqueName = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
|
|
510
510
|
const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
|
|
511
511
|
const firstToken = node.getFirstToken();
|
|
512
|
-
const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${pre}.
|
|
513
|
-
${indentation}READ TABLE ${pre} ${condition}INTO ${uniqueName}.
|
|
514
|
-
${indentation}IF sy-subrc <> 0.
|
|
515
|
-
${indentation} RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
|
|
516
|
-
${indentation}ENDIF.
|
|
512
|
+
const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${pre}.
|
|
513
|
+
${indentation}READ TABLE ${pre} ${condition}INTO ${uniqueName}.
|
|
514
|
+
${indentation}IF sy-subrc <> 0.
|
|
515
|
+
${indentation} RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
|
|
516
|
+
${indentation}ENDIF.
|
|
517
517
|
${indentation}`);
|
|
518
518
|
const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, startToken.getStart(), tableExpression.getLastToken().getEnd(), uniqueName);
|
|
519
519
|
const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
|
|
@@ -538,7 +538,7 @@ ${indentation}`);
|
|
|
538
538
|
const className = classNames[0].concatTokens();
|
|
539
539
|
const targetName = (_b = target.findFirstExpression(Expressions.TargetField)) === null || _b === void 0 ? void 0 : _b.concatTokens();
|
|
540
540
|
const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
|
|
541
|
-
const code = ` DATA ${targetName} TYPE REF TO ${className}.
|
|
541
|
+
const code = ` DATA ${targetName} TYPE REF TO ${className}.
|
|
542
542
|
${indentation}CATCH ${className} INTO ${targetName}.`;
|
|
543
543
|
const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getStart(), node.getEnd(), code);
|
|
544
544
|
return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Outline DATA", this.getMetadata().key, this.conf.severity, fix);
|
|
@@ -649,11 +649,11 @@ ${indentation}CATCH ${className} INTO ${targetName}.`;
|
|
|
649
649
|
const uniqueName1 = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
|
|
650
650
|
const uniqueName2 = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
|
|
651
651
|
const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
|
|
652
|
-
const abap = `DATA ${uniqueName1} LIKE if_t100_message=>t100key.
|
|
653
|
-
${indentation}${uniqueName1}-msgid = ${id}.
|
|
654
|
-
${indentation}${uniqueName1}-msgno = ${number}.
|
|
655
|
-
${indentation}DATA ${uniqueName2} TYPE REF TO ${className}.
|
|
656
|
-
${indentation}CREATE OBJECT ${uniqueName2} EXPORTING textid = ${uniqueName1}.
|
|
652
|
+
const abap = `DATA ${uniqueName1} LIKE if_t100_message=>t100key.
|
|
653
|
+
${indentation}${uniqueName1}-msgid = ${id}.
|
|
654
|
+
${indentation}${uniqueName1}-msgno = ${number}.
|
|
655
|
+
${indentation}DATA ${uniqueName2} TYPE REF TO ${className}.
|
|
656
|
+
${indentation}CREATE OBJECT ${uniqueName2} EXPORTING textid = ${uniqueName1}.
|
|
657
657
|
${indentation}RAISE EXCEPTION ${uniqueName2}.`;
|
|
658
658
|
const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getStart(), node.getEnd(), abap);
|
|
659
659
|
return issue_1.Issue.atToken(lowFile, startToken, "Downport RAISE MESSAGE", this.getMetadata().key, this.conf.severity, fix);
|
|
@@ -732,11 +732,11 @@ ${indentation}RAISE EXCEPTION ${uniqueName2}.`;
|
|
|
732
732
|
uniqueName = `<${uniqueName}>`;
|
|
733
733
|
const tName = target.concatTokens().split("[")[0];
|
|
734
734
|
const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
|
|
735
|
-
const code = `FIELD-SYMBOLS ${uniqueName} LIKE LINE OF ${tName}.
|
|
736
|
-
${indentation}READ TABLE ${tName} INDEX ${index === null || index === void 0 ? void 0 : index.concatTokens()} ASSIGNING ${uniqueName}.
|
|
737
|
-
${indentation}IF sy-subrc <> 0.
|
|
738
|
-
${indentation} RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
|
|
739
|
-
${indentation}ENDIF.
|
|
735
|
+
const code = `FIELD-SYMBOLS ${uniqueName} LIKE LINE OF ${tName}.
|
|
736
|
+
${indentation}READ TABLE ${tName} INDEX ${index === null || index === void 0 ? void 0 : index.concatTokens()} ASSIGNING ${uniqueName}.
|
|
737
|
+
${indentation}IF sy-subrc <> 0.
|
|
738
|
+
${indentation} RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
|
|
739
|
+
${indentation}ENDIF.
|
|
740
740
|
${uniqueName}`;
|
|
741
741
|
const start = target.getFirstToken().getStart();
|
|
742
742
|
const end = target.getLastToken().getEnd();
|
|
@@ -821,10 +821,10 @@ ${indentation}ENDIF.
|
|
|
821
821
|
const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
|
|
822
822
|
const source = (_b = templateSource === null || templateSource === void 0 ? void 0 : templateSource.findDirectExpression(Expressions.Source)) === null || _b === void 0 ? void 0 : _b.concatTokens();
|
|
823
823
|
const topTarget = (_c = node.findDirectExpression(Expressions.Target)) === null || _c === void 0 ? void 0 : _c.concatTokens();
|
|
824
|
-
const code = `CALL FUNCTION '${functionName}'
|
|
825
|
-
${indentation} EXPORTING
|
|
826
|
-
${indentation} input = ${source}
|
|
827
|
-
${indentation} IMPORTING
|
|
824
|
+
const code = `CALL FUNCTION '${functionName}'
|
|
825
|
+
${indentation} EXPORTING
|
|
826
|
+
${indentation} input = ${source}
|
|
827
|
+
${indentation} IMPORTING
|
|
828
828
|
${indentation} output = ${topTarget}.`;
|
|
829
829
|
const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getFirstToken().getStart(), node.getLastToken().getEnd(), code);
|
|
830
830
|
return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Downport ALPHA", this.getMetadata().key, this.conf.severity, fix);
|
|
@@ -884,7 +884,7 @@ ${indentation} output = ${topTarget}.`;
|
|
|
884
884
|
}
|
|
885
885
|
return undefined;
|
|
886
886
|
}
|
|
887
|
-
outlineFor(forLoop, indentation) {
|
|
887
|
+
outlineFor(forLoop, indentation, lowFile, highSyntax) {
|
|
888
888
|
var _a, _b, _c, _d, _e, _f, _g, _h, _j;
|
|
889
889
|
let body = "";
|
|
890
890
|
let end = "";
|
|
@@ -917,18 +917,30 @@ ${indentation} output = ${topTarget}.`;
|
|
|
917
917
|
body += indentation + `LOOP AT ${loopSource} ASSIGNING FIELD-SYMBOL(${loopTargetFieldSymbol}).\n`;
|
|
918
918
|
end = "ENDLOOP";
|
|
919
919
|
}
|
|
920
|
+
const l = forLoop.findDirectExpression(Expressions.Let);
|
|
921
|
+
if (l) {
|
|
922
|
+
body += this.outlineLet(l, indentation, highSyntax, lowFile);
|
|
923
|
+
}
|
|
920
924
|
return { body, end };
|
|
921
925
|
}
|
|
922
926
|
outlineSwitch(node, lowFile, highSyntax) {
|
|
923
|
-
var _a, _b;
|
|
927
|
+
var _a, _b, _c;
|
|
924
928
|
for (const i of node.findAllExpressionsRecursive(Expressions.Source)) {
|
|
925
929
|
const firstToken = i.getFirstToken();
|
|
926
930
|
if (firstToken.getStr().toUpperCase() !== "SWITCH") {
|
|
927
931
|
continue;
|
|
928
932
|
}
|
|
929
|
-
|
|
933
|
+
let type = this.findType(i, lowFile, highSyntax);
|
|
930
934
|
if (type === undefined) {
|
|
931
|
-
|
|
935
|
+
if (node.get() instanceof Statements.Move && node.findDirectExpression(Expressions.Source) === i) {
|
|
936
|
+
type = "LIKE " + ((_a = node.findDirectExpression(Expressions.Target)) === null || _a === void 0 ? void 0 : _a.concatTokens());
|
|
937
|
+
}
|
|
938
|
+
if (type === undefined) {
|
|
939
|
+
continue;
|
|
940
|
+
}
|
|
941
|
+
}
|
|
942
|
+
else {
|
|
943
|
+
type = "TYPE " + type;
|
|
932
944
|
}
|
|
933
945
|
const uniqueName = this.uniqueName(firstToken.getStart(), lowFile.getFilename(), highSyntax);
|
|
934
946
|
const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
|
|
@@ -938,11 +950,11 @@ ${indentation} output = ${topTarget}.`;
|
|
|
938
950
|
if (switchBody === undefined) {
|
|
939
951
|
continue;
|
|
940
952
|
}
|
|
941
|
-
for (const l of ((
|
|
953
|
+
for (const l of ((_b = switchBody === null || switchBody === void 0 ? void 0 : switchBody.findDirectExpression(Expressions.Let)) === null || _b === void 0 ? void 0 : _b.findDirectExpressions(Expressions.InlineFieldDefinition)) || []) {
|
|
942
954
|
name = l.getFirstToken().getStr();
|
|
943
|
-
body += indentation + `DATA(${name}) = ${(
|
|
955
|
+
body += indentation + `DATA(${name}) = ${(_c = switchBody.findFirstExpression(Expressions.Source)) === null || _c === void 0 ? void 0 : _c.concatTokens()}.\n`;
|
|
944
956
|
}
|
|
945
|
-
body += `DATA ${uniqueName}
|
|
957
|
+
body += `DATA ${uniqueName} ${type}.\n`;
|
|
946
958
|
let firstSource = false;
|
|
947
959
|
let inWhen = false;
|
|
948
960
|
for (const c of switchBody.getChildren()) {
|
|
@@ -1007,7 +1019,7 @@ ${indentation} output = ${topTarget}.`;
|
|
|
1007
1019
|
if (forLoop === undefined) {
|
|
1008
1020
|
continue;
|
|
1009
1021
|
}
|
|
1010
|
-
const outlineFor = this.outlineFor(forLoop, indentation);
|
|
1022
|
+
const outlineFor = this.outlineFor(forLoop, indentation, lowFile, highSyntax);
|
|
1011
1023
|
body += outlineFor.body;
|
|
1012
1024
|
const next = reduceBody.findDirectExpression(Expressions.ReduceNext);
|
|
1013
1025
|
if (next === undefined) {
|
|
@@ -1064,11 +1076,11 @@ ${indentation} output = ${topTarget}.`;
|
|
|
1064
1076
|
const uniqueName = this.uniqueName(firstToken.getStart(), lowFile.getFilename(), highSyntax);
|
|
1065
1077
|
let indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
|
|
1066
1078
|
let body = "";
|
|
1067
|
-
|
|
1068
|
-
|
|
1069
|
-
|
|
1070
|
-
outlineFor = this.outlineFor(forLoop, indentation);
|
|
1079
|
+
let end = "";
|
|
1080
|
+
for (const forLoop of (valueBody === null || valueBody === void 0 ? void 0 : valueBody.findDirectExpressions(Expressions.For)) || []) {
|
|
1081
|
+
const outlineFor = this.outlineFor(forLoop, indentation, lowFile, highSyntax);
|
|
1071
1082
|
body += outlineFor.body;
|
|
1083
|
+
end = outlineFor.end + `.\n` + end;
|
|
1072
1084
|
indentation += " ";
|
|
1073
1085
|
}
|
|
1074
1086
|
let structureName = uniqueName;
|
|
@@ -1102,9 +1114,9 @@ ${indentation} output = ${topTarget}.`;
|
|
|
1102
1114
|
}
|
|
1103
1115
|
previous = b;
|
|
1104
1116
|
}
|
|
1105
|
-
if (
|
|
1117
|
+
if (end !== "") {
|
|
1106
1118
|
indentation = indentation.substring(2);
|
|
1107
|
-
body += indentation +
|
|
1119
|
+
body += indentation + end;
|
|
1108
1120
|
}
|
|
1109
1121
|
const abap = `DATA ${uniqueName} ${type}.\n` +
|
|
1110
1122
|
body +
|
|
@@ -24,10 +24,10 @@ class ExitOrCheck extends _abap_rule_1.ABAPRule {
|
|
|
24
24
|
return {
|
|
25
25
|
key: "exit_or_check",
|
|
26
26
|
title: "Find EXIT or CHECK outside loops",
|
|
27
|
-
shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
|
|
27
|
+
shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
|
|
28
28
|
Use RETURN to leave procesing blocks instead.`,
|
|
29
|
-
extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
|
|
30
|
-
https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
|
|
29
|
+
extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
|
|
30
|
+
https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
|
|
31
31
|
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-return`,
|
|
32
32
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
|
|
33
33
|
};
|
|
@@ -22,7 +22,7 @@ class Exporting extends _abap_rule_1.ABAPRule {
|
|
|
22
22
|
shortDescription: `Detects EXPORTING statements which can be omitted.`,
|
|
23
23
|
badExample: `call_method( EXPORTING foo = bar ).`,
|
|
24
24
|
goodExample: `call_method( foo = bar ).`,
|
|
25
|
-
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-optional-keyword-exporting
|
|
25
|
+
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-optional-keyword-exporting
|
|
26
26
|
https://docs.abapopenchecks.org/checks/30/`,
|
|
27
27
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
|
|
28
28
|
};
|
|
@@ -26,7 +26,7 @@ class ForbiddenIdentifier extends _abap_rule_1.ABAPRule {
|
|
|
26
26
|
key: "forbidden_identifier",
|
|
27
27
|
title: "Forbidden Identifier",
|
|
28
28
|
shortDescription: `Forbid use of specified identifiers, list of regex.`,
|
|
29
|
-
extendedInformation: `Used in the transpiler to find javascript keywords in ABAP identifiers,
|
|
29
|
+
extendedInformation: `Used in the transpiler to find javascript keywords in ABAP identifiers,
|
|
30
30
|
https://github.com/abaplint/transpiler/blob/bda94b8b56e2b7f2f87be2168f12361aa530220e/packages/transpiler/src/validation.ts#L44`,
|
|
31
31
|
tags: [_irule_1.RuleTag.SingleFile],
|
|
32
32
|
};
|
|
@@ -28,8 +28,8 @@ class ForbiddenVoidType {
|
|
|
28
28
|
key: "forbidden_void_type",
|
|
29
29
|
title: "Forbidden Void Types",
|
|
30
30
|
shortDescription: `Avoid usage of specified void types.`,
|
|
31
|
-
extendedInformation: `Inspiration:
|
|
32
|
-
BOOLEAN, BOOLE_D, CHAR01, CHAR1, CHAR10, CHAR12, CHAR128, CHAR2, CHAR20, CHAR4, CHAR70,
|
|
31
|
+
extendedInformation: `Inspiration:
|
|
32
|
+
BOOLEAN, BOOLE_D, CHAR01, CHAR1, CHAR10, CHAR12, CHAR128, CHAR2, CHAR20, CHAR4, CHAR70,
|
|
33
33
|
DATS, TIMS, DATUM, FLAG, INT4, NUMC3, NUMC4, SAP_BOOL, TEXT25, TEXT80, X255, XFELD`,
|
|
34
34
|
};
|
|
35
35
|
}
|
|
@@ -28,26 +28,26 @@ class FunctionalWriting extends _abap_rule_1.ABAPRule {
|
|
|
28
28
|
key: "functional_writing",
|
|
29
29
|
title: "Use functional writing",
|
|
30
30
|
shortDescription: `Detects usage of call method when functional style calls can be used.`,
|
|
31
|
-
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-calls
|
|
31
|
+
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-calls
|
|
32
32
|
https://docs.abapopenchecks.org/checks/07/`,
|
|
33
33
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
|
|
34
|
-
badExample: `CALL METHOD zcl_class=>method( ).
|
|
35
|
-
CALL METHOD cl_abap_typedescr=>describe_by_name
|
|
36
|
-
EXPORTING
|
|
37
|
-
p_name = 'NAME'
|
|
38
|
-
RECEIVING
|
|
39
|
-
p_descr_ref = lr_typedescr
|
|
40
|
-
EXCEPTIONS
|
|
41
|
-
type_not_found = 1
|
|
34
|
+
badExample: `CALL METHOD zcl_class=>method( ).
|
|
35
|
+
CALL METHOD cl_abap_typedescr=>describe_by_name
|
|
36
|
+
EXPORTING
|
|
37
|
+
p_name = 'NAME'
|
|
38
|
+
RECEIVING
|
|
39
|
+
p_descr_ref = lr_typedescr
|
|
40
|
+
EXCEPTIONS
|
|
41
|
+
type_not_found = 1
|
|
42
42
|
OTHERS = 2.`,
|
|
43
|
-
goodExample: `zcl_class=>method( ).
|
|
44
|
-
cl_abap_typedescr=>describe_by_name(
|
|
45
|
-
EXPORTING
|
|
46
|
-
p_name = 'NAME'
|
|
47
|
-
RECEIVING
|
|
48
|
-
p_descr_ref = lr_typedescr
|
|
49
|
-
EXCEPTIONS
|
|
50
|
-
type_not_found = 1
|
|
43
|
+
goodExample: `zcl_class=>method( ).
|
|
44
|
+
cl_abap_typedescr=>describe_by_name(
|
|
45
|
+
EXPORTING
|
|
46
|
+
p_name = 'NAME'
|
|
47
|
+
RECEIVING
|
|
48
|
+
p_descr_ref = lr_typedescr
|
|
49
|
+
EXCEPTIONS
|
|
50
|
+
type_not_found = 1
|
|
51
51
|
OTHERS = 2 ).`,
|
|
52
52
|
};
|
|
53
53
|
}
|
|
@@ -18,16 +18,16 @@ class GlobalClass extends _abap_rule_1.ABAPRule {
|
|
|
18
18
|
return {
|
|
19
19
|
key: "global_class",
|
|
20
20
|
title: "Global class checks",
|
|
21
|
-
shortDescription: `Checks related to global classes.
|
|
22
|
-
|
|
23
|
-
* global classes must be in own files
|
|
24
|
-
|
|
25
|
-
* file names must match class name
|
|
26
|
-
|
|
27
|
-
* file names must match interface name
|
|
28
|
-
|
|
29
|
-
* global classes must be global definitions
|
|
30
|
-
|
|
21
|
+
shortDescription: `Checks related to global classes.
|
|
22
|
+
|
|
23
|
+
* global classes must be in own files
|
|
24
|
+
|
|
25
|
+
* file names must match class name
|
|
26
|
+
|
|
27
|
+
* file names must match interface name
|
|
28
|
+
|
|
29
|
+
* global classes must be global definitions
|
|
30
|
+
|
|
31
31
|
* global interfaces must be global definitions`,
|
|
32
32
|
tags: [_irule_1.RuleTag.Syntax],
|
|
33
33
|
};
|
|
@@ -33,8 +33,8 @@ class IdenticalConditions extends _abap_rule_1.ABAPRule {
|
|
|
33
33
|
return {
|
|
34
34
|
key: "identical_conditions",
|
|
35
35
|
title: "Identical conditions",
|
|
36
|
-
shortDescription: `Find identical conditions in IF + CASE + WHILE etc
|
|
37
|
-
|
|
36
|
+
shortDescription: `Find identical conditions in IF + CASE + WHILE etc
|
|
37
|
+
|
|
38
38
|
Prerequsites: code is pretty printed with identical cAsE`,
|
|
39
39
|
tags: [_irule_1.RuleTag.SingleFile],
|
|
40
40
|
};
|
|
@@ -20,23 +20,23 @@ class IdenticalContents extends _abap_rule_1.ABAPRule {
|
|
|
20
20
|
key: "identical_contents",
|
|
21
21
|
title: "Identical contents",
|
|
22
22
|
shortDescription: `Find identical contents in blocks inside IFs, both in the beginning and in the end.`,
|
|
23
|
-
extendedInformation: `
|
|
24
|
-
Prerequsites: code is pretty printed with identical cAsE
|
|
25
|
-
|
|
23
|
+
extendedInformation: `
|
|
24
|
+
Prerequsites: code is pretty printed with identical cAsE
|
|
25
|
+
|
|
26
26
|
Chained statments are ignored`,
|
|
27
27
|
tags: [_irule_1.RuleTag.SingleFile],
|
|
28
|
-
badExample: `IF foo = bar.
|
|
29
|
-
WRITE 'bar'.
|
|
30
|
-
WRITE 'world'.
|
|
31
|
-
ELSE.
|
|
32
|
-
WRITE 'foo'.
|
|
33
|
-
WRITE 'world'.
|
|
28
|
+
badExample: `IF foo = bar.
|
|
29
|
+
WRITE 'bar'.
|
|
30
|
+
WRITE 'world'.
|
|
31
|
+
ELSE.
|
|
32
|
+
WRITE 'foo'.
|
|
33
|
+
WRITE 'world'.
|
|
34
34
|
ENDIF.`,
|
|
35
|
-
goodExample: `IF foo = bar.
|
|
36
|
-
WRITE 'bar'.
|
|
37
|
-
ELSE.
|
|
38
|
-
WRITE 'foo'.
|
|
39
|
-
ENDIF.
|
|
35
|
+
goodExample: `IF foo = bar.
|
|
36
|
+
WRITE 'bar'.
|
|
37
|
+
ELSE.
|
|
38
|
+
WRITE 'foo'.
|
|
39
|
+
ENDIF.
|
|
40
40
|
WRITE 'world'.`,
|
|
41
41
|
};
|
|
42
42
|
}
|
|
@@ -16,10 +16,10 @@ class IdenticalDescriptions {
|
|
|
16
16
|
key: "identical_descriptions",
|
|
17
17
|
title: "Identical descriptions",
|
|
18
18
|
shortDescription: `Searches for objects with the same type and same description`,
|
|
19
|
-
extendedInformation: `Case insensitive
|
|
20
|
-
|
|
21
|
-
Only checks the master language descriptions
|
|
22
|
-
|
|
19
|
+
extendedInformation: `Case insensitive
|
|
20
|
+
|
|
21
|
+
Only checks the master language descriptions
|
|
22
|
+
|
|
23
23
|
Works for: INTF, CLAS, DOMA, DTEL, FUNC in same FUGR`,
|
|
24
24
|
tags: [],
|
|
25
25
|
};
|
|
@@ -19,15 +19,15 @@ class IfInIf extends _abap_rule_1.ABAPRule {
|
|
|
19
19
|
key: "if_in_if",
|
|
20
20
|
title: "IF in IF",
|
|
21
21
|
shortDescription: `Detects nested ifs which can be refactored to a single condition using AND.`,
|
|
22
|
-
extendedInformation: `https://docs.abapopenchecks.org/checks/01/
|
|
22
|
+
extendedInformation: `https://docs.abapopenchecks.org/checks/01/
|
|
23
23
|
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#keep-the-nesting-depth-low`,
|
|
24
|
-
badExample: `IF condition1.
|
|
25
|
-
IF condition2.
|
|
26
|
-
...
|
|
27
|
-
ENDIF.
|
|
24
|
+
badExample: `IF condition1.
|
|
25
|
+
IF condition2.
|
|
26
|
+
...
|
|
27
|
+
ENDIF.
|
|
28
28
|
ENDIF.`,
|
|
29
|
-
goodExample: `IF ( condition1 ) AND ( condition2 ).
|
|
30
|
-
...
|
|
29
|
+
goodExample: `IF ( condition1 ) AND ( condition2 ).
|
|
30
|
+
...
|
|
31
31
|
ENDIF.`,
|
|
32
32
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
|
|
33
33
|
};
|
|
@@ -102,9 +102,9 @@ class ImplementMethods extends _abap_rule_1.ABAPRule {
|
|
|
102
102
|
for (const i of ((_a = file.getStructure()) === null || _a === void 0 ? void 0 : _a.findAllStatements(Statements.ClassImplementation)) || []) {
|
|
103
103
|
const name = (_b = i.findFirstExpression(Expressions.ClassName)) === null || _b === void 0 ? void 0 : _b.getFirstToken().getStr().toUpperCase();
|
|
104
104
|
if (name === impl.identifier.getName().toUpperCase()) {
|
|
105
|
-
return edit_helper_1.EditHelper.insertAt(file, i.getLastToken().getEnd(), `
|
|
106
|
-
METHOD ${methodName.toLowerCase()}.
|
|
107
|
-
RETURN. " todo, implement method
|
|
105
|
+
return edit_helper_1.EditHelper.insertAt(file, i.getLastToken().getEnd(), `
|
|
106
|
+
METHOD ${methodName.toLowerCase()}.
|
|
107
|
+
RETURN. " todo, implement method
|
|
108
108
|
ENDMETHOD.`);
|
|
109
109
|
}
|
|
110
110
|
}
|
|
@@ -31,19 +31,19 @@ class InStatementIndentation extends _abap_rule_1.ABAPRule {
|
|
|
31
31
|
key: "in_statement_indentation",
|
|
32
32
|
title: "In-statement indentation",
|
|
33
33
|
shortDescription: "Checks alignment within statements which span multiple lines.",
|
|
34
|
-
extendedInformation: `Lines following the first line should be indented once (2 spaces).
|
|
35
|
-
|
|
36
|
-
For block declaration statements, lines after the first should be indented an additional time (default: +2 spaces)
|
|
34
|
+
extendedInformation: `Lines following the first line should be indented once (2 spaces).
|
|
35
|
+
|
|
36
|
+
For block declaration statements, lines after the first should be indented an additional time (default: +2 spaces)
|
|
37
37
|
to distinguish them better from code within the block.`,
|
|
38
|
-
badExample: `IF 1 = 1
|
|
39
|
-
AND 2 = 2.
|
|
40
|
-
WRITE 'hello' &&
|
|
41
|
-
'world'.
|
|
38
|
+
badExample: `IF 1 = 1
|
|
39
|
+
AND 2 = 2.
|
|
40
|
+
WRITE 'hello' &&
|
|
41
|
+
'world'.
|
|
42
42
|
ENDIF.`,
|
|
43
|
-
goodExample: `IF 1 = 1
|
|
44
|
-
AND 2 = 2.
|
|
45
|
-
WRITE 'hello' &&
|
|
46
|
-
'world'.
|
|
43
|
+
goodExample: `IF 1 = 1
|
|
44
|
+
AND 2 = 2.
|
|
45
|
+
WRITE 'hello' &&
|
|
46
|
+
'world'.
|
|
47
47
|
ENDIF.`,
|
|
48
48
|
tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
|
|
49
49
|
};
|
|
@@ -26,9 +26,9 @@ class IntfReferencingClas {
|
|
|
26
26
|
key: "intf_referencing_clas",
|
|
27
27
|
title: "INTF referencing CLAS",
|
|
28
28
|
shortDescription: `Interface contains references to class`,
|
|
29
|
-
extendedInformation: `Only global interfaces are checked.
|
|
30
|
-
Only first level references are checked.
|
|
31
|
-
Exception class references are ignored.
|
|
29
|
+
extendedInformation: `Only global interfaces are checked.
|
|
30
|
+
Only first level references are checked.
|
|
31
|
+
Exception class references are ignored.
|
|
32
32
|
Void references are ignored.`,
|
|
33
33
|
};
|
|
34
34
|
}
|
|
@@ -15,8 +15,8 @@ class LineBreakStyle {
|
|
|
15
15
|
return {
|
|
16
16
|
key: "line_break_style",
|
|
17
17
|
title: "Makes sure line breaks are consistent in the ABAP code",
|
|
18
|
-
shortDescription: `Enforces LF as newlines in ABAP files
|
|
19
|
-
|
|
18
|
+
shortDescription: `Enforces LF as newlines in ABAP files
|
|
19
|
+
|
|
20
20
|
abapGit does not work with CRLF`,
|
|
21
21
|
tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.SingleFile],
|
|
22
22
|
};
|
|
@@ -23,7 +23,7 @@ class LineLength extends _abap_rule_1.ABAPRule {
|
|
|
23
23
|
key: "line_length",
|
|
24
24
|
title: "Line length",
|
|
25
25
|
shortDescription: `Detects lines exceeding the provided maximum length.`,
|
|
26
|
-
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#stick-to-a-reasonable-line-length
|
|
26
|
+
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#stick-to-a-reasonable-line-length
|
|
27
27
|
https://docs.abapopenchecks.org/checks/04/`,
|
|
28
28
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
|
|
29
29
|
};
|
|
@@ -27,7 +27,7 @@ class LineOnlyPunc extends _abap_rule_1.ABAPRule {
|
|
|
27
27
|
key: "line_only_punc",
|
|
28
28
|
title: "Line containing only punctuation",
|
|
29
29
|
shortDescription: `Detects lines containing only punctuation.`,
|
|
30
|
-
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#close-brackets-at-line-end
|
|
30
|
+
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#close-brackets-at-line-end
|
|
31
31
|
https://docs.abapopenchecks.org/checks/16/`,
|
|
32
32
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
|
|
33
33
|
badExample: "zcl_class=>method(\n).",
|
|
@@ -30,8 +30,8 @@ class LocalVariableNames extends _abap_rule_1.ABAPRule {
|
|
|
30
30
|
return {
|
|
31
31
|
key: "local_variable_names",
|
|
32
32
|
title: "Local variable naming conventions",
|
|
33
|
-
shortDescription: `
|
|
34
|
-
Allows you to enforce a pattern, such as a prefix, for local variables, constants and field symbols.
|
|
33
|
+
shortDescription: `
|
|
34
|
+
Allows you to enforce a pattern, such as a prefix, for local variables, constants and field symbols.
|
|
35
35
|
Regexes are case-insensitive.`,
|
|
36
36
|
tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.SingleFile],
|
|
37
37
|
};
|
|
@@ -23,17 +23,17 @@ class ManyParentheses extends _abap_rule_1.ABAPRule {
|
|
|
23
23
|
title: "Too many parentheses",
|
|
24
24
|
shortDescription: `Searches for expressions where extra parentheses can safely be removed`,
|
|
25
25
|
tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
|
|
26
|
-
badExample: `
|
|
27
|
-
IF ( destination IS INITIAL ).
|
|
28
|
-
ENDIF.
|
|
29
|
-
IF foo = boo AND ( bar = lar AND moo = loo ).
|
|
30
|
-
ENDIF.
|
|
26
|
+
badExample: `
|
|
27
|
+
IF ( destination IS INITIAL ).
|
|
28
|
+
ENDIF.
|
|
29
|
+
IF foo = boo AND ( bar = lar AND moo = loo ).
|
|
30
|
+
ENDIF.
|
|
31
31
|
`,
|
|
32
|
-
goodExample: `
|
|
33
|
-
IF destination IS INITIAL.
|
|
34
|
-
ENDIF.
|
|
35
|
-
IF foo = boo AND bar = lar AND moo = loo.
|
|
36
|
-
ENDIF.
|
|
32
|
+
goodExample: `
|
|
33
|
+
IF destination IS INITIAL.
|
|
34
|
+
ENDIF.
|
|
35
|
+
IF foo = boo AND bar = lar AND moo = loo.
|
|
36
|
+
ENDIF.
|
|
37
37
|
`,
|
|
38
38
|
};
|
|
39
39
|
}
|
|
@@ -21,14 +21,14 @@ class MaxOneMethodParameterPerLine extends _abap_rule_1.ABAPRule {
|
|
|
21
21
|
title: "Max one method parameter definition per line",
|
|
22
22
|
shortDescription: `Keep max one method parameter description per line`,
|
|
23
23
|
tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace],
|
|
24
|
-
badExample: `
|
|
25
|
-
METHODS apps_scope_token
|
|
26
|
-
IMPORTING
|
|
24
|
+
badExample: `
|
|
25
|
+
METHODS apps_scope_token
|
|
26
|
+
IMPORTING
|
|
27
27
|
body TYPE bodyapps_scope_token client_id TYPE str.`,
|
|
28
|
-
goodExample: `
|
|
29
|
-
METHODS apps_scope_token
|
|
30
|
-
IMPORTING
|
|
31
|
-
body TYPE bodyapps_scope_token
|
|
28
|
+
goodExample: `
|
|
29
|
+
METHODS apps_scope_token
|
|
30
|
+
IMPORTING
|
|
31
|
+
body TYPE bodyapps_scope_token
|
|
32
32
|
client_id TYPE str.`,
|
|
33
33
|
};
|
|
34
34
|
}
|