@abaplint/core 2.85.42 → 2.85.45

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (83) hide show
  1. package/README.md +6 -6
  2. package/build/abaplint.d.ts +4 -0
  3. package/build/src/abap/4_file_information/abap_file_information.js +1 -0
  4. package/build/src/abap/5_syntax/_type_utils.js +27 -0
  5. package/build/src/abap/5_syntax/statements/catch.js +6 -1
  6. package/build/src/abap/5_syntax/statements/split.js +17 -2
  7. package/build/src/abap/flow/flow_graph.js +7 -7
  8. package/build/src/abap/types/class_definition.js +4 -0
  9. package/build/src/lsp/help.js +7 -7
  10. package/build/src/registry.js +1 -1
  11. package/build/src/rules/7bit_ascii.js +2 -2
  12. package/build/src/rules/abapdoc.js +1 -1
  13. package/build/src/rules/align_parameters.js +33 -33
  14. package/build/src/rules/ambiguous_statement.js +5 -5
  15. package/build/src/rules/avoid_use.js +6 -6
  16. package/build/src/rules/begin_end_names.js +4 -4
  17. package/build/src/rules/begin_single_include.js +12 -12
  18. package/build/src/rules/call_transaction_authority_check.js +3 -3
  19. package/build/src/rules/chain_mainly_declarations.js +4 -4
  20. package/build/src/rules/check_abstract.js +2 -2
  21. package/build/src/rules/check_comments.js +4 -4
  22. package/build/src/rules/check_include.js +3 -3
  23. package/build/src/rules/check_no_handler_pragma.js +8 -8
  24. package/build/src/rules/check_subrc.js +8 -8
  25. package/build/src/rules/commented_code.js +1 -1
  26. package/build/src/rules/constructor_visibility_public.js +4 -4
  27. package/build/src/rules/contains_tab.js +2 -2
  28. package/build/src/rules/cyclic_oo.js +7 -1
  29. package/build/src/rules/dangerous_statement.js +1 -1
  30. package/build/src/rules/downport.js +125 -49
  31. package/build/src/rules/exit_or_check.js +3 -3
  32. package/build/src/rules/exporting.js +1 -1
  33. package/build/src/rules/forbidden_identifier.js +1 -1
  34. package/build/src/rules/forbidden_void_type.js +2 -2
  35. package/build/src/rules/functional_writing.js +17 -17
  36. package/build/src/rules/global_class.js +10 -10
  37. package/build/src/rules/identical_conditions.js +2 -2
  38. package/build/src/rules/identical_contents.js +14 -14
  39. package/build/src/rules/identical_descriptions.js +4 -4
  40. package/build/src/rules/if_in_if.js +7 -7
  41. package/build/src/rules/implement_methods.js +3 -3
  42. package/build/src/rules/in_statement_indentation.js +11 -11
  43. package/build/src/rules/intf_referencing_clas.js +3 -3
  44. package/build/src/rules/line_break_style.js +2 -2
  45. package/build/src/rules/line_length.js +1 -1
  46. package/build/src/rules/line_only_punc.js +1 -1
  47. package/build/src/rules/local_variable_names.js +2 -2
  48. package/build/src/rules/many_parentheses.js +10 -10
  49. package/build/src/rules/max_one_method_parameter_per_line.js +7 -7
  50. package/build/src/rules/max_one_statement.js +3 -3
  51. package/build/src/rules/method_overwrites_builtin.js +4 -2
  52. package/build/src/rules/nesting.js +1 -1
  53. package/build/src/rules/no_chained_assignment.js +1 -1
  54. package/build/src/rules/no_public_attributes.js +1 -1
  55. package/build/src/rules/no_yoda_conditions.js +4 -4
  56. package/build/src/rules/obsolete_statement.js +40 -40
  57. package/build/src/rules/omit_parameter_name.js +3 -3
  58. package/build/src/rules/omit_receiving.js +13 -13
  59. package/build/src/rules/parser_702_chaining.js +2 -2
  60. package/build/src/rules/parser_error.js +2 -2
  61. package/build/src/rules/parser_missing_space.js +1 -1
  62. package/build/src/rules/pragma_placement.js +2 -1
  63. package/build/src/rules/prefer_inline.js +16 -16
  64. package/build/src/rules/prefer_is_not.js +7 -7
  65. package/build/src/rules/prefer_raise_exception_new.js +3 -3
  66. package/build/src/rules/prefer_returning_to_exporting.js +1 -1
  67. package/build/src/rules/prefer_xsdbool.js +2 -2
  68. package/build/src/rules/remove_descriptions.js +4 -4
  69. package/build/src/rules/rfc_error_handling.js +9 -9
  70. package/build/src/rules/select_add_order_by.js +5 -5
  71. package/build/src/rules/select_performance.js +2 -2
  72. package/build/src/rules/sicf_consistency.js +4 -4
  73. package/build/src/rules/space_before_dot.js +2 -2
  74. package/build/src/rules/start_at_tab.js +1 -1
  75. package/build/src/rules/sy_modification.js +2 -2
  76. package/build/src/rules/tabl_enhancement_category.js +2 -2
  77. package/build/src/rules/unused_methods.js +9 -9
  78. package/build/src/rules/unused_variables.js +6 -6
  79. package/build/src/rules/use_bool_expression.js +8 -8
  80. package/build/src/rules/use_line_exists.js +6 -6
  81. package/build/src/rules/use_new.js +7 -4
  82. package/build/src/rules/when_others_last.js +6 -6
  83. package/package.json +66 -66
package/README.md CHANGED
@@ -1,7 +1,7 @@
1
- # @abaplint/core
2
-
3
- [abaplint](https://abaplint.org/) core library
4
-
5
- Exposes functionality like the parser and rules, which can be used in other projects.
6
-
1
+ # @abaplint/core
2
+
3
+ [abaplint](https://abaplint.org/) core library
4
+
5
+ Exposes functionality like the parser and rules, which can be used in other projects.
6
+
7
7
  For more information see https://github.com/abaplint/abaplint
@@ -805,6 +805,7 @@ declare class ClassDefinition_3 extends Identifier implements IClassDefinition {
805
805
  private readonly implementing;
806
806
  private readonly testing;
807
807
  private readonly abstract;
808
+ private readonly sharedMemory;
808
809
  private aliases;
809
810
  constructor(node: StructureNode, filename: string, scope: CurrentScope);
810
811
  getFriends(): string[];
@@ -819,6 +820,7 @@ declare class ClassDefinition_3 extends Identifier implements IClassDefinition {
819
820
  getAliases(): IAliases;
820
821
  isForTesting(): boolean;
821
822
  isAbstract(): boolean;
823
+ isSharedMemory(): boolean;
822
824
  private findSuper;
823
825
  private findFriends;
824
826
  private addReference;
@@ -2553,6 +2555,7 @@ export declare interface IClassDefinition extends IInterfaceDefinition {
2553
2555
  isFinal(): boolean;
2554
2556
  isForTesting(): boolean;
2555
2557
  isAbstract(): boolean;
2558
+ isSharedMemory(): boolean;
2556
2559
  getFriends(): string[];
2557
2560
  }
2558
2561
 
@@ -2882,6 +2885,7 @@ declare interface InfoClassDefinition extends InfoInterfaceDefinition {
2882
2885
  isFinal: boolean;
2883
2886
  interfaces: readonly InfoImplementing[];
2884
2887
  isForTesting: boolean;
2888
+ isSharedMemory: boolean;
2885
2889
  }
2886
2890
 
2887
2891
  declare interface InfoClassImplementation {
@@ -144,6 +144,7 @@ class ABAPFileInformation {
144
144
  interfaces: this.getImplementing(found),
145
145
  isForTesting: concat.includes(" FOR TESTING"),
146
146
  isAbstract: concat.includes(" ABSTRACT"),
147
+ isSharedMemory: concat.includes(" SHARED MEMORY ENABLED"),
147
148
  isFinal: found.findFirstExpression(Expressions.ClassFinal) !== undefined,
148
149
  aliases,
149
150
  attributes,
@@ -7,6 +7,33 @@ class TypeUtils {
7
7
  constructor(scope) {
8
8
  this.scope = scope;
9
9
  }
10
+ isCharLikeStrict(type) {
11
+ if (type === undefined) {
12
+ return false;
13
+ }
14
+ else if (type instanceof basic_1.StructureType) {
15
+ for (const c of type.getComponents()) {
16
+ if (this.isCharLikeStrict(c.type) === false) {
17
+ return false;
18
+ }
19
+ }
20
+ return true;
21
+ }
22
+ else if (type instanceof basic_1.StringType
23
+ || type instanceof basic_1.AnyType
24
+ || type instanceof basic_1.CharacterType
25
+ || type instanceof basic_1.CLikeType
26
+ || type instanceof basic_1.DateType
27
+ || type instanceof basic_1.CSequenceType
28
+ || type instanceof basic_1.NumericGenericType
29
+ || type instanceof basic_1.NumericType
30
+ || type instanceof basic_1.TimeType
31
+ || type instanceof basic_1.UnknownType
32
+ || type instanceof basic_1.VoidType) {
33
+ return true;
34
+ }
35
+ return false;
36
+ }
10
37
  isCharLike(type) {
11
38
  if (type === undefined) {
12
39
  return false;
@@ -10,9 +10,10 @@ const _reference_1 = require("../_reference");
10
10
  class Catch {
11
11
  runSyntax(node, scope, filename) {
12
12
  var _a, _b;
13
+ const names = new Set();
13
14
  for (const c of node.findDirectExpressions(Expressions.ClassName)) {
14
15
  const token = c.getFirstToken();
15
- const className = token.getStr();
16
+ const className = token.getStr().toUpperCase();
16
17
  const found = scope.existsObject(className);
17
18
  if (found.found === true && found.id) {
18
19
  scope.addReference(token, found.id, found.type, filename);
@@ -24,6 +25,10 @@ class Catch {
24
25
  else {
25
26
  throw new Error("CATCH, unknown class " + className);
26
27
  }
28
+ if (names.has(className)) {
29
+ throw new Error("Duplicate class name in CATCH: " + className);
30
+ }
31
+ names.add(className);
27
32
  }
28
33
  const target = node.findDirectExpression(Expressions.Target);
29
34
  const firstClassName = (_a = node.findDirectExpression(Expressions.ClassName)) === null || _a === void 0 ? void 0 : _a.getFirstToken().getStr();
@@ -6,16 +6,31 @@ const basic_1 = require("../../types/basic");
6
6
  const inline_data_1 = require("../expressions/inline_data");
7
7
  const source_1 = require("../expressions/source");
8
8
  const target_1 = require("../expressions/target");
9
+ const _type_utils_1 = require("../_type_utils");
9
10
  class Split {
10
11
  runSyntax(node, scope, filename) {
11
- const type = node.findTokenSequencePosition("INTO", "TABLE") ? new basic_1.TableType(new basic_1.StringType(), { withHeader: false }) : new basic_1.StringType();
12
+ const intoTable = node.findTokenSequencePosition("INTO", "TABLE") !== undefined;
13
+ const type = intoTable ? new basic_1.TableType(new basic_1.StringType(), { withHeader: false }) : new basic_1.StringType();
12
14
  for (const target of node.findAllExpressions(Expressions.Target)) {
13
15
  const inline = target.findDirectExpression(Expressions.InlineData);
14
16
  if (inline) {
15
17
  new inline_data_1.InlineData().runSyntax(inline, scope, filename, type);
16
18
  }
17
19
  else {
18
- new target_1.Target().runSyntax(target, scope, filename);
20
+ let targetType = new target_1.Target().runSyntax(target, scope, filename);
21
+ if (intoTable) {
22
+ if (!(targetType instanceof basic_1.TableType)
23
+ && !(targetType instanceof basic_1.UnknownType)
24
+ && !(targetType instanceof basic_1.VoidType)) {
25
+ throw new Error("Into must be table typed");
26
+ }
27
+ if (targetType instanceof basic_1.TableType) {
28
+ targetType = targetType.getRowType();
29
+ }
30
+ }
31
+ if (new _type_utils_1.TypeUtils(scope).isCharLikeStrict(targetType) === false) {
32
+ throw new Error("Incompatible, target not character like");
33
+ }
19
34
  }
20
35
  }
21
36
  for (const s of node.findDirectExpressions(Expressions.Source)) {
@@ -72,13 +72,13 @@ class FlowGraph {
72
72
  this.label = label;
73
73
  }
74
74
  toDigraph() {
75
- return `digraph G {
76
- labelloc="t";
77
- label="${this.label}";
78
- graph [fontname = "helvetica"];
79
- node [fontname = "helvetica", shape="box"];
80
- edge [fontname = "helvetica"];
81
- ${this.toTextEdges()}
75
+ return `digraph G {
76
+ labelloc="t";
77
+ label="${this.label}";
78
+ graph [fontname = "helvetica"];
79
+ node [fontname = "helvetica", shape="box"];
80
+ edge [fontname = "helvetica"];
81
+ ${this.toTextEdges()}
82
82
  }`;
83
83
  }
84
84
  listSources(node) {
@@ -43,6 +43,7 @@ class ClassDefinition extends _identifier_1.Identifier {
43
43
  scope.pop(node.getLastToken().getEnd());
44
44
  const concat = this.node.findFirstStatement(Statements.ClassDefinition).concatTokens().toUpperCase();
45
45
  this.testing = concat.includes(" FOR TESTING");
46
+ this.sharedMemory = concat.includes(" SHARED MEMORY ENABLED");
46
47
  this.abstract = concat.includes(" ABSTRACT");
47
48
  }
48
49
  getFriends() {
@@ -81,6 +82,9 @@ class ClassDefinition extends _identifier_1.Identifier {
81
82
  isAbstract() {
82
83
  return this.abstract;
83
84
  }
85
+ isSharedMemory() {
86
+ return this.sharedMemory;
87
+ }
84
88
  /*
85
89
  public getEvents() {
86
90
  }
@@ -19,13 +19,13 @@ class Help {
19
19
  /////////////////////////////////////////////////
20
20
  static dumpABAP(file, reg, textDocument, position) {
21
21
  let content = "";
22
- content = `
23
- <a href="#_tokens" rel="no-refresh">Tokens</a> |
24
- <a href="#_statements" rel="no-refresh">Statements</a> |
25
- <a href="#_structure" rel="no-refresh">Structure</a> |
26
- <a href="#_files" rel="no-refresh">Files</a> |
27
- <a href="#_info" rel="no-refresh">Info Dump</a>
28
- <hr>
22
+ content = `
23
+ <a href="#_tokens" rel="no-refresh">Tokens</a> |
24
+ <a href="#_statements" rel="no-refresh">Statements</a> |
25
+ <a href="#_structure" rel="no-refresh">Structure</a> |
26
+ <a href="#_files" rel="no-refresh">Files</a> |
27
+ <a href="#_info" rel="no-refresh">Info Dump</a>
28
+ <hr>
29
29
  ` +
30
30
  "<tt>" + textDocument.uri + " (" +
31
31
  (position.line + 1) + ", " +
@@ -68,7 +68,7 @@ class Registry {
68
68
  }
69
69
  static abaplintVersion() {
70
70
  // magic, see build script "version.sh"
71
- return "2.85.42";
71
+ return "2.85.45";
72
72
  }
73
73
  getDDICReferences() {
74
74
  return this.references;
@@ -17,8 +17,8 @@ class SevenBitAscii {
17
17
  key: "7bit_ascii",
18
18
  title: "Check for 7bit ascii",
19
19
  shortDescription: `Only allow characters from the 7bit ASCII set.`,
20
- extendedInformation: `https://docs.abapopenchecks.org/checks/05/
21
-
20
+ extendedInformation: `https://docs.abapopenchecks.org/checks/05/
21
+
22
22
  Checkes files with extension ".abap" and ".asddls"`,
23
23
  tags: [_irule_1.RuleTag.SingleFile],
24
24
  };
@@ -23,7 +23,7 @@ class Abapdoc extends _abap_rule_1.ABAPRule {
23
23
  return {
24
24
  key: "abapdoc",
25
25
  title: "Check abapdoc",
26
- shortDescription: `Various checks regarding abapdoc.
26
+ shortDescription: `Various checks regarding abapdoc.
27
27
  Base rule checks for existence of abapdoc for public class methods and all interface methods.`,
28
28
  tags: [_irule_1.RuleTag.SingleFile],
29
29
  };
@@ -20,42 +20,42 @@ class AlignParameters extends _abap_rule_1.ABAPRule {
20
20
  key: "align_parameters",
21
21
  title: "Align Parameters",
22
22
  shortDescription: `Checks for vertially aligned parameters`,
23
- extendedInformation: `Checks:
24
- * function module calls
25
- * method calls
26
- * VALUE constructors
27
- * NEW constructors
28
- * RAISE EXCEPTION statements
29
- * CREATE OBJECT statements
30
- * RAISE EVENT statements
31
-
32
- https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
33
-
34
- Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
35
-
23
+ extendedInformation: `Checks:
24
+ * function module calls
25
+ * method calls
26
+ * VALUE constructors
27
+ * NEW constructors
28
+ * RAISE EXCEPTION statements
29
+ * CREATE OBJECT statements
30
+ * RAISE EVENT statements
31
+
32
+ https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
33
+
34
+ Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
35
+
36
36
  Also https://rules.abaplint.org/max_one_method_parameter_per_line/ can help aligning parameter syntax`,
37
37
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide],
38
- badExample: `CALL FUNCTION 'FOOBAR'
39
- EXPORTING
40
- foo = 2
41
- parameter = 3.
42
-
43
- foobar( moo = 1
44
- param = 1 ).
45
-
46
- foo = VALUE #(
47
- foo = bar
38
+ badExample: `CALL FUNCTION 'FOOBAR'
39
+ EXPORTING
40
+ foo = 2
41
+ parameter = 3.
42
+
43
+ foobar( moo = 1
44
+ param = 1 ).
45
+
46
+ foo = VALUE #(
47
+ foo = bar
48
48
  moo = 2 ).`,
49
- goodExample: `CALL FUNCTION 'FOOBAR'
50
- EXPORTING
51
- foo = 2
52
- parameter = 3.
53
-
54
- foobar( moo = 1
55
- param = 1 ).
56
-
57
- foo = VALUE #(
58
- foo = bar
49
+ goodExample: `CALL FUNCTION 'FOOBAR'
50
+ EXPORTING
51
+ foo = 2
52
+ parameter = 3.
53
+
54
+ foobar( moo = 1
55
+ param = 1 ).
56
+
57
+ foo = VALUE #(
58
+ foo = bar
59
59
  moo = 2 ).`,
60
60
  };
61
61
  }
@@ -20,14 +20,14 @@ class AmbiguousStatement extends _abap_rule_1.ABAPRule {
20
20
  return {
21
21
  key: "ambiguous_statement",
22
22
  title: "Check for ambigious statements",
23
- shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
24
- Add "TABLE" keyword or "@" for escaping SQL variables
25
-
23
+ shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
24
+ Add "TABLE" keyword or "@" for escaping SQL variables
25
+
26
26
  Only works if the target version is 740sp05 or above`,
27
27
  tags: [_irule_1.RuleTag.SingleFile],
28
- badExample: `DELETE foo FROM bar.
28
+ badExample: `DELETE foo FROM bar.
29
29
  MODIFY foo FROM bar.`,
30
- goodExample: `DELETE foo FROM @bar.
30
+ goodExample: `DELETE foo FROM @bar.
31
31
  MODIFY TABLE foo FROM bar.`,
32
32
  };
33
33
  }
@@ -35,12 +35,12 @@ class AvoidUse extends _abap_rule_1.ABAPRule {
35
35
  key: "avoid_use",
36
36
  title: "Avoid use of certain statements",
37
37
  shortDescription: `Detects usage of certain statements.`,
38
- extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
39
-
40
- Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
41
-
42
- STATICS: use CLASS-DATA instead
43
-
38
+ extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
39
+
40
+ Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
41
+
42
+ STATICS: use CLASS-DATA instead
43
+
44
44
  DESCRIBE TABLE LINES: use lines() instead (quickfix exists)`,
45
45
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
46
46
  };
@@ -23,11 +23,11 @@ class BeginEndNames extends _abap_rule_1.ABAPRule {
23
23
  title: "Check BEGIN END names",
24
24
  shortDescription: `Check BEGIN OF and END OF names match, plus there must be statements between BEGIN and END`,
25
25
  tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
26
- badExample: `DATA: BEGIN OF stru,
27
- field TYPE i,
26
+ badExample: `DATA: BEGIN OF stru,
27
+ field TYPE i,
28
28
  END OF structure_not_the_same.`,
29
- goodExample: `DATA: BEGIN OF stru,
30
- field TYPE i,
29
+ goodExample: `DATA: BEGIN OF stru,
30
+ field TYPE i,
31
31
  END OF stru.`,
32
32
  };
33
33
  }
@@ -21,19 +21,19 @@ class BeginSingleInclude extends _abap_rule_1.ABAPRule {
21
21
  title: "BEGIN contains single INCLUDE",
22
22
  shortDescription: `Finds TYPE BEGIN with just one INCLUDE TYPE, and DATA with single INCLUDE STRUCTURE`,
23
23
  tags: [_irule_1.RuleTag.SingleFile],
24
- badExample: `TYPES: BEGIN OF dummy1.
25
- INCLUDE TYPE dselc.
26
- TYPES: END OF dummy1.
27
-
28
- DATA BEGIN OF foo.
29
- INCLUDE STRUCTURE syst.
30
- DATA END OF foo.
31
-
32
- STATICS BEGIN OF bar.
33
- INCLUDE STRUCTURE syst.
24
+ badExample: `TYPES: BEGIN OF dummy1.
25
+ INCLUDE TYPE dselc.
26
+ TYPES: END OF dummy1.
27
+
28
+ DATA BEGIN OF foo.
29
+ INCLUDE STRUCTURE syst.
30
+ DATA END OF foo.
31
+
32
+ STATICS BEGIN OF bar.
33
+ INCLUDE STRUCTURE syst.
34
34
  STATICS END OF bar.`,
35
- goodExample: `DATA BEGIN OF foo.
36
- INCLUDE STRUCTURE dselc.
35
+ goodExample: `DATA BEGIN OF foo.
36
+ INCLUDE STRUCTURE dselc.
37
37
  DATA END OF foo.`,
38
38
  };
39
39
  }
@@ -24,9 +24,9 @@ class CallTransactionAuthorityCheck extends _abap_rule_1.ABAPRule {
24
24
  extendedInformation: `https://docs.abapopenchecks.org/checks/54/`,
25
25
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
26
26
  badExample: `CALL TRANSACTION 'FOO'.`,
27
- goodExample: `TRY.
28
- CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.
29
- CATCH cx_sy_authorization_error.
27
+ goodExample: `TRY.
28
+ CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.
29
+ CATCH cx_sy_authorization_error.
30
30
  ENDTRY.`,
31
31
  };
32
32
  }
@@ -45,10 +45,10 @@ class ChainMainlyDeclarations extends _abap_rule_1.ABAPRule {
45
45
  key: "chain_mainly_declarations",
46
46
  title: "Chain mainly declarations",
47
47
  shortDescription: `Chain mainly declarations, allows chaining for the configured statements, reports errors for other statements.`,
48
- extendedInformation: `
49
- https://docs.abapopenchecks.org/checks/23/
50
-
51
- https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
48
+ extendedInformation: `
49
+ https://docs.abapopenchecks.org/checks/23/
50
+
51
+ https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
52
52
  `,
53
53
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
54
54
  badExample: `CALL METHOD: bar.`,
@@ -23,8 +23,8 @@ class CheckAbstract extends _abap_rule_1.ABAPRule {
23
23
  return {
24
24
  key: "check_abstract",
25
25
  title: "Check abstract methods and classes",
26
- shortDescription: `Checks abstract methods and classes:
27
- - class defined as abstract and final,
26
+ shortDescription: `Checks abstract methods and classes:
27
+ - class defined as abstract and final,
28
28
  - non-abstract class contains abstract methods`,
29
29
  extendedInformation: `If a class defines only constants, use an interface instead`,
30
30
  tags: [_irule_1.RuleTag.SingleFile],
@@ -27,11 +27,11 @@ class CheckComments extends _abap_rule_1.ABAPRule {
27
27
  return {
28
28
  key: "check_comments",
29
29
  title: "Check Comments",
30
- shortDescription: `
30
+ shortDescription: `
31
31
  Various checks for comment usage.`,
32
- extendedInformation: `
33
- * End of line comments. Comments starting with "#EC" or "##" are ignored
34
-
32
+ extendedInformation: `
33
+ * End of line comments. Comments starting with "#EC" or "##" are ignored
34
+
35
35
  https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#put-comments-before-the-statement-they-relate-to`,
36
36
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
37
37
  };
@@ -17,9 +17,9 @@ class CheckInclude {
17
17
  key: "check_include",
18
18
  title: "Check INCLUDEs",
19
19
  shortDescription: `Checks INCLUDE statements`,
20
- extendedInformation: `
21
- * Reports unused includes
22
- * Errors if the includes are not found
20
+ extendedInformation: `
21
+ * Reports unused includes
22
+ * Errors if the includes are not found
23
23
  * Error if including a main program`,
24
24
  tags: [_irule_1.RuleTag.Syntax],
25
25
  };
@@ -21,15 +21,15 @@ class CheckNoHandlerPragma extends _abap_rule_1.ABAPRule {
21
21
  title: "Check if NO_HANDLER can be removed",
22
22
  shortDescription: `Checks NO_HANDLER pragmas that can be removed`,
23
23
  tags: [_irule_1.RuleTag.SingleFile],
24
- badExample: `TRY.
25
- ...
26
- CATCH zcx_abapgit_exception ##NO_HANDLER.
27
- RETURN. " it has a handler
24
+ badExample: `TRY.
25
+ ...
26
+ CATCH zcx_abapgit_exception ##NO_HANDLER.
27
+ RETURN. " it has a handler
28
28
  ENDTRY.`,
29
- goodExample: `TRY.
30
- ...
31
- CATCH zcx_abapgit_exception.
32
- RETURN.
29
+ goodExample: `TRY.
30
+ ...
31
+ CATCH zcx_abapgit_exception.
32
+ RETURN.
33
33
  ENDTRY.`,
34
34
  };
35
35
  }
@@ -34,14 +34,14 @@ class CheckSubrc extends _abap_rule_1.ABAPRule {
34
34
  key: "check_subrc",
35
35
  title: "Check sy-subrc",
36
36
  shortDescription: `Check sy-subrc`,
37
- extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
38
-
39
- If sy-dbcnt is checked after database statements, it is considered okay.
40
-
41
- "SELECT SINGLE @abap_true FROM " is considered as an existence check
42
-
43
- If IS ASSIGNED is checked after assigning, it is considered okay.
44
-
37
+ extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
38
+
39
+ If sy-dbcnt is checked after database statements, it is considered okay.
40
+
41
+ "SELECT SINGLE @abap_true FROM " is considered as an existence check
42
+
43
+ If IS ASSIGNED is checked after assigning, it is considered okay.
44
+
45
45
  FIND statement with MATCH COUNT is considered okay if subrc is not checked`,
46
46
  tags: [_irule_1.RuleTag.SingleFile],
47
47
  pseudoComment: "EC CI_SUBRC",
@@ -30,7 +30,7 @@ class CommentedCode extends _abap_rule_1.ABAPRule {
30
30
  key: "commented_code",
31
31
  title: "Find commented code",
32
32
  shortDescription: `Detects usage of commented out code.`,
33
- extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
33
+ extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
34
34
  https://docs.abapopenchecks.org/checks/14/`,
35
35
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
36
36
  };
@@ -18,10 +18,10 @@ class ConstructorVisibilityPublic {
18
18
  key: "constructor_visibility_public",
19
19
  title: "Check constructor visibility is public",
20
20
  shortDescription: `Constructor must be placed in the public section, even if the class is not CREATE PUBLIC.`,
21
- extendedInformation: `
22
- This only applies to global classes.
23
-
24
- https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
21
+ extendedInformation: `
22
+ This only applies to global classes.
23
+
24
+ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
25
25
  https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abeninstance_constructor_guidl.htm`,
26
26
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
27
27
  };
@@ -25,8 +25,8 @@ class ContainsTab extends _abap_rule_1.ABAPRule {
25
25
  key: "contains_tab",
26
26
  title: "Code contains tab",
27
27
  shortDescription: `Checks for usage of tabs (enable to enforce spaces)`,
28
- extendedInformation: `
29
- https://docs.abapopenchecks.org/checks/09/
28
+ extendedInformation: `
29
+ https://docs.abapopenchecks.org/checks/09/
30
30
  https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#indent-and-snap-to-tab`,
31
31
  tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
32
32
  };
@@ -15,6 +15,8 @@ class CyclicOOConf extends _basic_rule_config_1.BasicRuleConfig {
15
15
  * @uniqueItems true
16
16
  */
17
17
  this.skip = [];
18
+ /** Skips shared memory enabled classes*/
19
+ this.skipSharedMemory = true;
18
20
  }
19
21
  }
20
22
  exports.CyclicOOConf = CyclicOOConf;
@@ -41,16 +43,20 @@ class CyclicOO {
41
43
  }
42
44
  }
43
45
  initialize(reg) {
46
+ var _a;
44
47
  this.reg = reg;
45
48
  this.edges = {};
46
49
  for (const obj of this.reg.getObjectsByType("CLAS")) {
47
50
  const name = obj.getName().toUpperCase();
48
- if (!(obj instanceof _abap_object_1.ABAPObject)) {
51
+ if (!(obj instanceof objects_1.Class)) {
49
52
  continue;
50
53
  }
51
54
  else if (this.conf.skip.indexOf(name) >= 0) {
52
55
  continue;
53
56
  }
57
+ else if (this.conf.skipSharedMemory === true && ((_a = obj.getClassDefinition()) === null || _a === void 0 ? void 0 : _a.isSharedMemory) === true) {
58
+ continue;
59
+ }
54
60
  this.buildEdges(name, new syntax_1.SyntaxLogic(this.reg, obj).run().spaghetti.getTop());
55
61
  }
56
62
  for (const obj of this.reg.getObjectsByType("INTF")) {
@@ -40,7 +40,7 @@ class DangerousStatement extends _abap_rule_1.ABAPRule {
40
40
  key: "dangerous_statement",
41
41
  title: "Dangerous statement",
42
42
  shortDescription: `Detects potentially dangerous statements`,
43
- extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
43
+ extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
44
44
  dynamic SQL can potentially create SQL injection problems`,
45
45
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
46
46
  };