@abaplint/core 2.85.30 → 2.85.33

package/build/src/rules/constructor_visibility_public.js

@@ -18,10 +18,10 @@ class ConstructorVisibilityPublic {
             key: "constructor_visibility_public",
             title: "Check constructor visibility is public",
             shortDescription: `Constructor must be placed in the public section, even if the class is not CREATE PUBLIC.`,
-            extendedInformation: `
-This only applies to global classes.
-
-https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
+            extendedInformation: `
+This only applies to global classes.
+
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
 https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abeninstance_constructor_guidl.htm`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/contains_tab.js

@@ -25,8 +25,8 @@ class ContainsTab extends _abap_rule_1.ABAPRule {
             key: "contains_tab",
             title: "Code contains tab",
             shortDescription: `Checks for usage of tabs (enable to enforce spaces)`,
-            extendedInformation: `
-https://docs.abapopenchecks.org/checks/09/
+            extendedInformation: `
+https://docs.abapopenchecks.org/checks/09/
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#indent-and-snap-to-tab`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/dangerous_statement.js

@@ -40,7 +40,7 @@ class DangerousStatement extends _abap_rule_1.ABAPRule {
             key: "dangerous_statement",
             title: "Dangerous statement",
             shortDescription: `Detects potentially dangerous statements`,
-            extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
+            extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
 dynamic SQL can potentially create SQL injection problems`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
         };

package/build/src/rules/downport.js

@@ -33,33 +33,33 @@ class Downport {
             key: "downport",
             title: "Downport statement",
             shortDescription: `Experimental downport functionality`,
-            extendedInformation: `Much like the 'commented_code' rule this rule loops through unknown statements and tries parsing with
-a higher level language version. If successful, various rules are applied to downport the statement.
-Target downport version is always v702, thus rule is only enabled if target version is v702.
-
-Current rules:
-* NEW transformed to CREATE OBJECT, opposite of https://rules.abaplint.org/use_new/
-* DATA() definitions are outlined, opposite of https://rules.abaplint.org/prefer_inline/
-* FIELD-SYMBOL() definitions are outlined
-* CONV is outlined
-* COND is outlined
-* REDUCE is outlined
-* SWITCH is outlined
-* APPEND expression is outlined
-* EMPTY KEY is changed to DEFAULT KEY, opposite of DEFAULT KEY in https://rules.abaplint.org/avoid_use/
-* CAST changed to ?=
-* LOOP AT method_call( ) is outlined
-* VALUE # with structure fields
-* VALUE # with internal table lines
-* Table Expressions are outlined
-* SELECT INTO @DATA definitions are outlined
-* Some occurrences of string template formatting option ALPHA changed to function module call
-* SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
-* PARTIALLY IMPLEMENTED removed, it can be quick fixed via rule implement_methods
-* RAISE EXCEPTION ... MESSAGE
-* Moving with +=, -=, /=, *=, &&= is expanded
-* line_exists and line_index is downported to READ TABLE
-
+            extendedInformation: `Much like the 'commented_code' rule this rule loops through unknown statements and tries parsing with
+a higher level language version. If successful, various rules are applied to downport the statement.
+Target downport version is always v702, thus rule is only enabled if target version is v702.
+
+Current rules:
+* NEW transformed to CREATE OBJECT, opposite of https://rules.abaplint.org/use_new/
+* DATA() definitions are outlined, opposite of https://rules.abaplint.org/prefer_inline/
+* FIELD-SYMBOL() definitions are outlined
+* CONV is outlined
+* COND is outlined
+* REDUCE is outlined
+* SWITCH is outlined
+* APPEND expression is outlined
+* EMPTY KEY is changed to DEFAULT KEY, opposite of DEFAULT KEY in https://rules.abaplint.org/avoid_use/
+* CAST changed to ?=
+* LOOP AT method_call( ) is outlined
+* VALUE # with structure fields
+* VALUE # with internal table lines
+* Table Expressions are outlined
+* SELECT INTO @DATA definitions are outlined
+* Some occurrences of string template formatting option ALPHA changed to function module call
+* SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
+* PARTIALLY IMPLEMENTED removed, it can be quick fixed via rule implement_methods
+* RAISE EXCEPTION ... MESSAGE
+* Moving with +=, -=, /=, *=, &&= is expanded
+* line_exists and line_index is downported to READ TABLE
+
 Only one transformation is applied to a statement at a time, so multiple steps might be required to do the full downport.`,
             tags: [_irule_1.RuleTag.Experimental, _irule_1.RuleTag.Downport, _irule_1.RuleTag.Quickfix],
         };
@@ -170,6 +170,10 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         if (found) {
             return found;
         }
+        found = this.moveWithSimpleValue(high, lowFile);
+        if (found) {
+            return found;
+        }
         found = this.downportSelectInline(low, high, lowFile, highSyntax);
         if (found) {
             return found;
@@ -291,8 +295,10 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         }
     }
     downportSelectInline(low, high, lowFile, highSyntax) {
-        if (!(low.get() instanceof _statement_1.Unknown)
-            || !(high.get() instanceof Statements.Select)) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        else if (!(high.get() instanceof Statements.Select) && !(high.get() instanceof Statements.SelectLoop)) {
             return undefined;
         }
         // as first step outline the @DATA, note that void types are okay, as long the field names are specified
@@ -307,7 +313,7 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         return undefined;
     }
     downportSelectSingleInline(_low, high, lowFile, _highSyntax) {
-        var _a, _b, _c;
+        var _a, _b, _c, _d;
         const targets = ((_a = high.findFirstExpression(Expressions.SQLIntoStructure)) === null || _a === void 0 ? void 0 : _a.findDirectExpressions(Expressions.SQLTarget)) || [];
         if (targets.length !== 1) {
             return undefined;
@@ -325,7 +331,10 @@ Only one transformation is applied to a statement at a time, so multiple steps m
             return undefined;
         }
         const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
-        const fieldList = high.findFirstExpression(Expressions.SQLFieldList);
+        let fieldList = high.findFirstExpression(Expressions.SQLFieldList);
+        if (fieldList === undefined) {
+            fieldList = high.findFirstExpression(Expressions.SQLFieldListLoop);
+        }
         if (fieldList === undefined) {
             return undefined;
         }
@@ -341,15 +350,22 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         else if (fieldList.concatTokens().toUpperCase() === "COUNT( * )") {
             fieldDefinition = `DATA ${name} TYPE i.`;
         }
+        else if (fieldList.getChildren().length === 1 && fieldList.getChildren()[0].get() instanceof Expressions.SQLAggregation) {
+            const c = fieldList.getChildren()[0];
+            if (c instanceof nodes_1.ExpressionNode) {
+                const concat = (_d = c.findFirstExpression(Expressions.SQLArithmetics)) === null || _d === void 0 ? void 0 : _d.concatTokens();
+                fieldDefinition = `DATA ${name} TYPE ${tableName}-${concat}.`;
+            }
+        }
         else {
             for (const f of fields) {
                 const fieldName = f.concatTokens();
                 fieldDefinition += indentation + "        " + fieldName + " TYPE " + tableName + "-" + fieldName + ",\n";
             }
-            fieldDefinition = `DATA: BEGIN OF ${name},
+            fieldDefinition = `DATA: BEGIN OF ${name},
 ${fieldDefinition}${indentation}      END OF ${name}.`;
         }
-        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `${fieldDefinition}
+        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `${fieldDefinition}
 ${indentation}`);
         const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, inlineData.getFirstToken().getStart(), inlineData.getLastToken().getEnd(), name);
         const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -361,36 +377,41 @@ ${indentation}`);
         if (targets.length !== 1) {
             return undefined;
         }
+        const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
         const inlineData = targets[0].findFirstExpression(Expressions.InlineData);
         if (inlineData === undefined) {
             return undefined;
         }
         const sqlFrom = high.findAllExpressions(Expressions.SQLFromSource);
-        if (sqlFrom.length !== 1) {
-            return undefined;
+        if (sqlFrom.length === 0) {
+            return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Error outlining, sqlFrom not found", this.getMetadata().key, this.conf.severity);
         }
-        const tableName = (_b = sqlFrom[0].findDirectExpression(Expressions.DatabaseTable)) === null || _b === void 0 ? void 0 : _b.concatTokens();
+        let tableName = (_b = sqlFrom[0].findDirectExpression(Expressions.DatabaseTable)) === null || _b === void 0 ? void 0 : _b.concatTokens();
         if (tableName === undefined) {
             return undefined;
         }
-        const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
         const fieldList = high.findFirstExpression(Expressions.SQLFieldList);
         if (fieldList === undefined) {
             return undefined;
         }
         let fieldDefinitions = "";
         for (const f of fieldList.findDirectExpressions(Expressions.SQLFieldName)) {
-            const fieldName = f.concatTokens();
+            let fieldName = f.concatTokens();
+            if (fieldName.includes("~")) {
+                const split = fieldName.split("~");
+                tableName = split[0];
+                fieldName = split[1];
+            }
             fieldDefinitions += indentation + "        " + fieldName + " TYPE " + tableName + "-" + fieldName + ",\n";
         }
         const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
         const name = ((_c = inlineData.findFirstExpression(Expressions.TargetField)) === null || _c === void 0 ? void 0 : _c.concatTokens()) || "error";
-        let fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `TYPES: BEGIN OF ${uniqueName},
-${fieldDefinitions}${indentation}      END OF ${uniqueName}.
-${indentation}DATA ${name} TYPE STANDARD TABLE OF ${uniqueName} WITH DEFAULT KEY.
+        let fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `TYPES: BEGIN OF ${uniqueName},
+${fieldDefinitions}${indentation}      END OF ${uniqueName}.
+${indentation}DATA ${name} TYPE STANDARD TABLE OF ${uniqueName} WITH DEFAULT KEY.
 ${indentation}`);
         if (fieldDefinitions === "") {
-            fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `DATA ${name} TYPE STANDARD TABLE OF ${tableName} WITH DEFAULT KEY.
+            fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `DATA ${name} TYPE STANDARD TABLE OF ${tableName} WITH DEFAULT KEY.
 ${indentation}`);
         }
         const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, inlineData.getFirstToken().getStart(), inlineData.getLastToken().getEnd(), name);
@@ -411,7 +432,7 @@ ${indentation}`);
             const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
             const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
             const firstToken = high.getFirstToken();
-            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${target === null || target === void 0 ? void 0 : target.concatTokens()}.
+            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${target === null || target === void 0 ? void 0 : target.concatTokens()}.
 ${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, source.getFirstToken().getStart(), source.getLastToken().getEnd(), uniqueName);
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -455,11 +476,11 @@ ${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
             const uniqueName = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
             const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
             const firstToken = node.getFirstToken();
-            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${pre}.
-${indentation}READ TABLE ${pre} ${condition}INTO ${uniqueName}.
-${indentation}IF sy-subrc <> 0.
-${indentation}  RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
-${indentation}ENDIF.
+            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${pre}.
+${indentation}READ TABLE ${pre} ${condition}INTO ${uniqueName}.
+${indentation}IF sy-subrc <> 0.
+${indentation}  RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
+${indentation}ENDIF.
 ${indentation}`);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, startToken.getStart(), tableExpression.getLastToken().getEnd(), uniqueName);
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -477,6 +498,7 @@ ${indentation}`);
         if (!(((_a = target === null || target === void 0 ? void 0 : target.getFirstChild()) === null || _a === void 0 ? void 0 : _a.get()) instanceof Expressions.InlineData)) {
             return undefined;
         }
+        let type = "";
         const source = node.findFirstExpression(Expressions.Source);
         if (source === undefined) {
             return undefined;
@@ -494,13 +516,25 @@ ${indentation}`);
             return undefined;
         }
         else if (source.findFirstExpression(Expressions.TableExpression)) {
-            return undefined;
+            const chain = source.findDirectExpression(Expressions.FieldChain);
+            if (chain !== undefined
+                && chain.getChildren().length === 2
+                && chain.getChildren()[0].get() instanceof Expressions.SourceField
+                && chain.getChildren()[1].get() instanceof Expressions.TableExpression) {
+                type = "LINE OF " + chain.getChildren()[0].concatTokens();
+            }
+            else {
+                return undefined;
+            }
+        }
+        else {
+            type = source.concatTokens();
         }
         const targetName = (_c = target.findFirstExpression(Expressions.TargetField)) === null || _c === void 0 ? void 0 : _c.concatTokens();
         const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
         const firstToken = node.getFirstToken();
         const lastToken = node.getLastToken();
-        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${targetName} LIKE ${source.concatTokens()}.\n${indentation}`);
+        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${targetName} LIKE ${type}.\n${indentation}`);
         const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, firstToken.getStart(), lastToken.getEnd(), `${targetName} = ${source.concatTokens()}.`);
         const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
         return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Outline DATA", this.getMetadata().key, this.conf.severity, fix);
@@ -560,11 +594,11 @@ ${indentation}`);
             const uniqueName1 = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
             const uniqueName2 = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
             const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
-            const abap = `DATA ${uniqueName1} LIKE if_t100_message=>t100key.
-${indentation}${uniqueName1}-msgid = ${id}.
-${indentation}${uniqueName1}-msgno = ${number}.
-${indentation}DATA ${uniqueName2} TYPE REF TO ${className}.
-${indentation}CREATE OBJECT ${uniqueName2} EXPORTING textid = ${uniqueName1}.
+            const abap = `DATA ${uniqueName1} LIKE if_t100_message=>t100key.
+${indentation}${uniqueName1}-msgid = ${id}.
+${indentation}${uniqueName1}-msgno = ${number}.
+${indentation}DATA ${uniqueName2} TYPE REF TO ${className}.
+${indentation}CREATE OBJECT ${uniqueName2} EXPORTING textid = ${uniqueName1}.
 ${indentation}RAISE EXCEPTION ${uniqueName2}.`;
             const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getStart(), node.getEnd(), abap);
             return issue_1.Issue.atToken(lowFile, startToken, "Downport RAISE MESSAGE", this.getMetadata().key, this.conf.severity, fix);
@@ -591,6 +625,38 @@ ${indentation}RAISE EXCEPTION ${uniqueName2}.`;
         }
         return undefined;
     }
+    moveWithSimpleValue(high, lowFile) {
+        if (!(high.get() instanceof Statements.Move)
+            || high.getChildren().length !== 4) {
+            return undefined;
+        }
+        const target = high.findDirectExpression(Expressions.Target);
+        if (target === undefined) {
+            return undefined;
+        }
+        const source = high.findDirectExpression(Expressions.Source);
+        if (source === undefined) {
+            return undefined;
+        }
+        const field = target.findDirectExpression(Expressions.TargetField);
+        if (field === undefined) {
+            return;
+        }
+        const valueBody = source.findDirectExpression(Expressions.ValueBody);
+        if (valueBody === undefined || valueBody.getChildren().length !== 1) {
+            return;
+        }
+        const fieldAssignment = valueBody.findDirectExpression(Expressions.FieldAssignment);
+        if (fieldAssignment === undefined) {
+            return;
+        }
+        const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
+        const code = `CLEAR ${target.concatTokens()}.\n` + indentation + target.concatTokens() + "-" + fieldAssignment.concatTokens();
+        const start = high.getFirstToken().getStart();
+        const end = high.getLastToken().getStart();
+        const fix = edit_helper_1.EditHelper.replaceRange(lowFile, start, end, code);
+        return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Downport, Reduce statement", this.getMetadata().key, this.conf.severity, fix);
+    }
     moveWithOperator(high, lowFile) {
         var _a, _b, _c;
         if (!(high.get() instanceof Statements.Move)) {
@@ -669,10 +735,10 @@ ${indentation}RAISE EXCEPTION ${uniqueName2}.`;
         const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
         const source = (_b = templateSource === null || templateSource === void 0 ? void 0 : templateSource.findDirectExpression(Expressions.Source)) === null || _b === void 0 ? void 0 : _b.concatTokens();
         const topTarget = (_c = node.findDirectExpression(Expressions.Target)) === null || _c === void 0 ? void 0 : _c.concatTokens();
-        const code = `CALL FUNCTION '${functionName}'
-${indentation}  EXPORTING
-${indentation}    input  = ${source}
-${indentation}  IMPORTING
+        const code = `CALL FUNCTION '${functionName}'
+${indentation}  EXPORTING
+${indentation}    input  = ${source}
+${indentation}  IMPORTING
 ${indentation}    output = ${topTarget}.`;
         const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getFirstToken().getStart(), node.getLastToken().getEnd(), code);
         return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Downport ALPHA", this.getMetadata().key, this.conf.severity, fix);
@@ -1007,15 +1073,22 @@ ${indentation}    output = ${topTarget}.`;
             if (spag === undefined) {
                 continue;
             }
-            const found = spag.findVariable(name);
-            if (found === undefined) {
-                continue;
+            let type = "";
+            if (node.concatTokens().toUpperCase().startsWith("APPEND INITIAL LINE TO ")) {
+                type = "LIKE LINE OF " + ((_b = node.findFirstExpression(Expressions.Target)) === null || _b === void 0 ? void 0 : _b.concatTokens());
             }
-            else if (found.getType() instanceof basic_1.VoidType) {
-                return issue_1.Issue.atToken(lowFile, i.getFirstToken(), "Error outlining voided type", this.getMetadata().key, this.conf.severity);
+            else {
+                const found = spag.findVariable(name);
+                if (found === undefined) {
+                    continue;
+                }
+                else if (found.getType() instanceof basic_1.VoidType) {
+                    return issue_1.Issue.atToken(lowFile, i.getFirstToken(), "Error outlining voided type", this.getMetadata().key, this.conf.severity);
+                }
+                type = "TYPE ";
+                type += found.getType().getQualifiedName() ? found.getType().getQualifiedName().toLowerCase() : found.getType().toABAP();
             }
-            const type = found.getType().getQualifiedName() ? (_b = found.getType().getQualifiedName()) === null || _b === void 0 ? void 0 : _b.toLowerCase() : found.getType().toABAP();
-            const code = `FIELD-SYMBOLS ${name} TYPE ${type}.\n` +
+            const code = `FIELD-SYMBOLS ${name} ${type}.\n` +
                 " ".repeat(node.getFirstToken().getStart().getCol() - 1);
             const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getFirstToken().getStart(), code);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, i.getFirstToken().getStart(), i.getLastToken().getEnd(), name);
@@ -1076,11 +1149,18 @@ ${indentation}    output = ${topTarget}.`;
     }
     buildCondBody(body, uniqueName, indent, lowFile, highSyntax) {
         let code = "";
+        let first = true;
         for (const c of body.getChildren()) {
             if (c instanceof nodes_1.TokenNode) {
                 switch (c.getFirstToken().getStr().toUpperCase()) {
                     case "WHEN":
-                        code += indent + "IF ";
+                        if (first === true) {
+                            code += indent + "IF ";
+                            first = false;
+                        }
+                        else {
+                            code += indent + "ELSEIF ";
+                        }
                         break;
                     case "THEN":
                         code += ".\n";

package/build/src/rules/empty_structure.js

@@ -25,7 +25,9 @@ class EmptyStructureConf extends _basic_rule_config_1.BasicRuleConfig {
         this.at = true;
         /** Checks for empty TRY blocks */
         this.try = true;
-        // todo, other category containing WHEN, ELSE
+        /** Checks for empty WHEN blocks */
+        this.when = true;
+        // todo, other category containing ELSE
     }
 }
 exports.EmptyStructureConf = EmptyStructureConf;
@@ -108,6 +110,17 @@ class EmptyStructure extends _abap_rule_1.ABAPRule {
                 }
             }
         }
+        if (this.getConfig().when === true) {
+            const tries = stru.findAllStructures(Structures.When);
+            for (const t of tries) {
+                if (t.getChildren().length === 1) {
+                    const token = t.getFirstToken();
+                    const message = this.getDescription(t.get().constructor.name);
+                    const issue = issue_1.Issue.atToken(file, token, message, this.getMetadata().key, this.conf.severity);
+                    issues.push(issue);
+                }
+            }
+        }
         return issues;
     }
 }

package/build/src/rules/exit_or_check.js

@@ -24,10 +24,10 @@ class ExitOrCheck extends _abap_rule_1.ABAPRule {
         return {
             key: "exit_or_check",
             title: "Find EXIT or CHECK outside loops",
-            shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
+            shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
 Use RETURN to leave procesing blocks instead.`,
-            extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
-https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
+            extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
+https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-return`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
         };

package/build/src/rules/exporting.js

@@ -22,7 +22,7 @@ class Exporting extends _abap_rule_1.ABAPRule {
             shortDescription: `Detects EXPORTING statements which can be omitted.`,
             badExample: `call_method( EXPORTING foo = bar ).`,
             goodExample: `call_method( foo = bar ).`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-optional-keyword-exporting
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-optional-keyword-exporting
 https://docs.abapopenchecks.org/checks/30/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/forbidden_identifier.js

@@ -26,7 +26,7 @@ class ForbiddenIdentifier extends _abap_rule_1.ABAPRule {
             key: "forbidden_identifier",
             title: "Forbidden Identifier",
             shortDescription: `Forbid use of specified identifiers, list of regex.`,
-            extendedInformation: `Used in the transpiler to find javascript keywords in ABAP identifiers,
+            extendedInformation: `Used in the transpiler to find javascript keywords in ABAP identifiers,
 https://github.com/abaplint/transpiler/blob/bda94b8b56e2b7f2f87be2168f12361aa530220e/packages/transpiler/src/validation.ts#L44`,
             tags: [_irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/forbidden_void_type.js

@@ -28,8 +28,8 @@ class ForbiddenVoidType {
             key: "forbidden_void_type",
             title: "Forbidden Void Types",
             shortDescription: `Avoid usage of specified void types.`,
-            extendedInformation: `Inspiration:
-BOOLEAN, BOOLE_D, CHAR01, CHAR1, CHAR10, CHAR12, CHAR128, CHAR2, CHAR20, CHAR4, CHAR70,
+            extendedInformation: `Inspiration:
+BOOLEAN, BOOLE_D, CHAR01, CHAR1, CHAR10, CHAR12, CHAR128, CHAR2, CHAR20, CHAR4, CHAR70,
 DATS, TIMS, DATUM, FLAG, INT4, NUMC3, NUMC4, SAP_BOOL, TEXT25, TEXT80, X255, XFELD`,
         };
     }

package/build/src/rules/functional_writing.js

@@ -28,26 +28,26 @@ class FunctionalWriting extends _abap_rule_1.ABAPRule {
             key: "functional_writing",
             title: "Use functional writing",
             shortDescription: `Detects usage of call method when functional style calls can be used.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-calls
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-calls
 https://docs.abapopenchecks.org/checks/07/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
-            badExample: `CALL METHOD zcl_class=>method( ).
-CALL METHOD cl_abap_typedescr=>describe_by_name
-  EXPORTING
-    p_name         = 'NAME'
-  RECEIVING
-    p_descr_ref    = lr_typedescr
-  EXCEPTIONS
-    type_not_found = 1
+            badExample: `CALL METHOD zcl_class=>method( ).
+CALL METHOD cl_abap_typedescr=>describe_by_name
+  EXPORTING
+    p_name         = 'NAME'
+  RECEIVING
+    p_descr_ref    = lr_typedescr
+  EXCEPTIONS
+    type_not_found = 1
     OTHERS         = 2.`,
-            goodExample: `zcl_class=>method( ).
-cl_abap_typedescr=>describe_by_name(
-  EXPORTING
-    p_name         = 'NAME'
-  RECEIVING
-    p_descr_ref    = lr_typedescr
-  EXCEPTIONS
-    type_not_found = 1
+            goodExample: `zcl_class=>method( ).
+cl_abap_typedescr=>describe_by_name(
+  EXPORTING
+    p_name         = 'NAME'
+  RECEIVING
+    p_descr_ref    = lr_typedescr
+  EXCEPTIONS
+    type_not_found = 1
     OTHERS         = 2 ).`,
         };
     }

package/build/src/rules/global_class.js

@@ -18,16 +18,16 @@ class GlobalClass extends _abap_rule_1.ABAPRule {
         return {
             key: "global_class",
             title: "Global class checks",
-            shortDescription: `Checks related to global classes.
-
-* global classes must be in own files
-
-* file names must match class name
-
-* file names must match interface name
-
-* global classes must be global definitions
-
+            shortDescription: `Checks related to global classes.
+
+* global classes must be in own files
+
+* file names must match class name
+
+* file names must match interface name
+
+* global classes must be global definitions
+
 * global interfaces must be global definitions`,
             tags: [_irule_1.RuleTag.Syntax],
         };

package/build/src/rules/identical_conditions.js

@@ -33,8 +33,8 @@ class IdenticalConditions extends _abap_rule_1.ABAPRule {
         return {
             key: "identical_conditions",
             title: "Identical conditions",
-            shortDescription: `Find identical conditions in IF + CASE + WHILE etc
-
+            shortDescription: `Find identical conditions in IF + CASE + WHILE etc
+
 Prerequsites: code is pretty printed with identical cAsE`,
             tags: [_irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/identical_contents.js

@@ -20,23 +20,23 @@ class IdenticalContents extends _abap_rule_1.ABAPRule {
             key: "identical_contents",
             title: "Identical contents",
             shortDescription: `Find identical contents in blocks inside IFs, both in the beginning and in the end.`,
-            extendedInformation: `
-Prerequsites: code is pretty printed with identical cAsE
-
+            extendedInformation: `
+Prerequsites: code is pretty printed with identical cAsE
+
 Chained statments are ignored`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `IF foo = bar.
-  WRITE 'bar'.
-  WRITE 'world'.
-ELSE.
-  WRITE 'foo'.
-  WRITE 'world'.
+            badExample: `IF foo = bar.
+  WRITE 'bar'.
+  WRITE 'world'.
+ELSE.
+  WRITE 'foo'.
+  WRITE 'world'.
 ENDIF.`,
-            goodExample: `IF foo = bar.
-  WRITE 'bar'.
-ELSE.
-  WRITE 'foo'.
-ENDIF.
+            goodExample: `IF foo = bar.
+  WRITE 'bar'.
+ELSE.
+  WRITE 'foo'.
+ENDIF.
 WRITE 'world'.`,
         };
     }

package/build/src/rules/identical_descriptions.js

@@ -16,10 +16,10 @@ class IdenticalDescriptions {
             key: "identical_descriptions",
             title: "Identical descriptions",
             shortDescription: `Searches for objects with the same type and same description`,
-            extendedInformation: `Case insensitive
-
-Only checks the master language descriptions
-
+            extendedInformation: `Case insensitive
+
+Only checks the master language descriptions
+
 Works for: INTF, CLAS, DOMA, DTEL, FUNC in same FUGR`,
             tags: [],
         };

package/build/src/rules/if_in_if.js

@@ -19,15 +19,15 @@ class IfInIf extends _abap_rule_1.ABAPRule {
             key: "if_in_if",
             title: "IF in IF",
             shortDescription: `Detects nested ifs which can be refactored to a single condition using AND.`,
-            extendedInformation: `https://docs.abapopenchecks.org/checks/01/
+            extendedInformation: `https://docs.abapopenchecks.org/checks/01/
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#keep-the-nesting-depth-low`,
-            badExample: `IF condition1.
-  IF condition2.
-    ...
-  ENDIF.
+            badExample: `IF condition1.
+  IF condition2.
+    ...
+  ENDIF.
 ENDIF.`,
-            goodExample: `IF ( condition1 ) AND ( condition2 ).
-  ...
+            goodExample: `IF ( condition1 ) AND ( condition2 ).
+  ...
 ENDIF.`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };