@abaplint/core 2.85.27 → 2.85.30

package/build/src/abap/2_statements/statement_parser.js

@@ -103,7 +103,9 @@ class StatementParser {
     lazyUnknown(wa) {
         const result = [];
         for (let statement of wa.statements) {
-            if (statement.get() instanceof _statement_1.Unknown) {
+            // dont use CALL METHOD, when executing lazy, it easily gives a Move for the last statment if lazy logic is evaluated
+            if (statement.get() instanceof _statement_1.Unknown
+                && statement.concatTokens().toUpperCase().startsWith("CALL METHOD ") === false) {
                 for (const { first, second } of this.buildSplits(statement.getTokens())) {
                     const s = this.categorizeStatement(new nodes_1.StatementNode(new _statement_1.Unknown()).setChildren(this.tokensToNodes(second)));
                     if (!(s.get() instanceof _statement_1.Unknown)) {

package/build/src/abap/5_syntax/expressions/method_source.js

@@ -36,10 +36,11 @@ class MethodSource {
                         ooType: "CLAS"
                     };
                     scope.addReference(last.getFirstToken(), foundMethod, _reference_1.ReferenceType.MethodReference, filename, extra);
+                    return foundMethod;
                 }
             }
             else if (context instanceof basic_1.VoidType) {
-                return;
+                return context;
             }
             else {
                 throw new Error("MethodSource, not a object reference, " + node.concatTokens());
@@ -61,6 +62,7 @@ class MethodSource {
           new Dynamic().runSyntax(d, scope, filename);
         }
         */
+        return undefined;
     }
 }
 exports.MethodSource = MethodSource;

package/build/src/abap/5_syntax/statements/call.js

@@ -17,11 +17,11 @@ class Call {
         if (methodSource === undefined) {
             throw new Error("Call, child MethodSource not found");
         }
-        new method_source_1.MethodSource().runSyntax(methodSource, scope, filename);
+        const methodDef = new method_source_1.MethodSource().runSyntax(methodSource, scope, filename);
         const body = node.findDirectExpression(Expressions.MethodCallBody);
         if (body) {
             // todo, resolve the method definition above and pass, if possible, in case of dynamic pass void
-            new method_call_body_1.MethodCallBody().runSyntax(body, scope, filename, new void_type_1.VoidType("CallTODO"));
+            new method_call_body_1.MethodCallBody().runSyntax(body, scope, filename, methodDef || new void_type_1.VoidType("CallTODO"));
         }
     }
 }

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.85.27";
+        return "2.85.30";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/downport.js

@@ -338,6 +338,9 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         else if (fieldList.concatTokens() === "*") {
             fieldDefinition = `DATA ${name} TYPE ${tableName}.`;
         }
+        else if (fieldList.concatTokens().toUpperCase() === "COUNT( * )") {
+            fieldDefinition = `DATA ${name} TYPE i.`;
+        }
         else {
             for (const f of fields) {
                 const fieldName = f.concatTokens();
@@ -490,6 +493,9 @@ ${indentation}`);
         else if (source.findFirstExpression(Expressions.FieldLength)) {
             return undefined;
         }
+        else if (source.findFirstExpression(Expressions.TableExpression)) {
+            return undefined;
+        }
         const targetName = (_c = target.findFirstExpression(Expressions.TargetField)) === null || _c === void 0 ? void 0 : _c.concatTokens();
         const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
         const firstToken = node.getFirstToken();
@@ -1147,7 +1153,9 @@ ${indentation}    output = ${topTarget}.`;
     uniqueName(position, filename, highSyntax) {
         const spag = highSyntax.spaghetti.lookupPosition(position, filename);
         if (spag === undefined) {
-            return "uniqueErrorSpag";
+            const name = "temprr" + this.counter;
+            this.counter++;
+            return name;
         }
         while (true) {
             const name = "temp" + this.counter;

package/build/src/rules/many_parentheses.js

@@ -2,6 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ManyParentheses = exports.ManyParenthesesConf = void 0;
 const Expressions = require("../abap/2_statements/expressions");
+const Statements = require("../abap/2_statements/statements");
 const issue_1 = require("../issue");
 const _abap_rule_1 = require("./_abap_rule");
 const _basic_rule_config_1 = require("./_basic_rule_config");
@@ -64,9 +65,25 @@ ENDIF.
                 issues.push(issue);
             }
         }
+        for (const m of structure.findAllStatements(Statements.Move)) {
+            issues.push(...this.analyzeMove(file, m));
+        }
         return issues;
     }
     ////////////////////
+    analyzeMove(file, m) {
+        const issues = [];
+        const children = m.getChildren();
+        const last = children[children.length - 2];
+        const lastChildren = last.getChildren();
+        if (lastChildren.length === 3
+            && lastChildren[0].getFirstToken().getStr() === "("
+            && lastChildren[2].getFirstToken().getStr() === ")") {
+            const issue = issue_1.Issue.atToken(file, last.getFirstToken(), "Too many parentheses", this.getMetadata().key, this.conf.severity);
+            issues.push(issue);
+        }
+        return issues;
+    }
     analyze(file, cond) {
         const issues = [];
         let comparator = "";

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.85.27",
+    "version": "2.85.30",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",