@abaplint/core 2.85.18 → 2.85.19

package/build/src/abap/5_syntax/expressions/raise_with.js

@@ -0,0 +1,14 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RaiseWith = void 0;
+const Expressions = require("../../2_statements/expressions");
+const source_1 = require("./source");
+class RaiseWith {
+    runSyntax(node, scope, filename) {
+        for (const f of node.findDirectExpressions(Expressions.Source)) {
+            new source_1.Source().runSyntax(f, scope, filename);
+        }
+    }
+}
+exports.RaiseWith = RaiseWith;
+//# sourceMappingURL=raise_with.js.map

package/build/src/abap/5_syntax/statements/raise.js

@@ -7,6 +7,7 @@ const source_1 = require("../expressions/source");
 const _reference_1 = require("../_reference");
 const basic_1 = require("../../types/basic");
 const message_source_1 = require("../expressions/message_source");
+const raise_with_1 = require("../expressions/raise_with");
 class Raise {
     runSyntax(node, scope, filename) {
         // todo
@@ -47,6 +48,9 @@ class Raise {
                 new source_1.Source().runSyntax(s, scope, filename);
             }
         }
+        for (const s of node.findDirectExpressions(Expressions.RaiseWith)) {
+            new raise_with_1.RaiseWith().runSyntax(s, scope, filename);
+        }
         for (const s of node.findDirectExpressions(Expressions.Source)) {
             new source_1.Source().runSyntax(s, scope, filename);
         }

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.85.18";
+        return "2.85.19";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/downport.js

@@ -56,6 +56,7 @@ Current rules:
 * PARTIALLY IMPLEMENTED removed, it can be quick fixed via rule implement_methods
 * RAISE EXCEPTION ... MESSAGE
 * APPEND expression is outlined
+* Moving with +=, -=, /=, *=, &&=
 
 Only one transformation is applied to a statement at a time, so multiple steps might be required to do the full downport.`,
             tags: [_irule_1.RuleTag.Experimental, _irule_1.RuleTag.Downport, _irule_1.RuleTag.Quickfix],
@@ -163,6 +164,10 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         if (found) {
             return found;
         }
+        found = this.moveWithOperator(high, lowFile);
+        if (found) {
+            return found;
+        }
         found = this.downportSelectInline(low, high, lowFile, highSyntax);
         if (found) {
             return found;
@@ -560,6 +565,48 @@ ${indentation}RAISE EXCEPTION ${uniqueName2}.`;
         }
         return undefined;
     }
+    moveWithOperator(high, lowFile) {
+        var _a, _b, _c;
+        if (!(high.get() instanceof Statements.Move)) {
+            return undefined;
+        }
+        const children = high.getChildren();
+        const secondChild = children[1];
+        if (secondChild === undefined) {
+            return undefined;
+        }
+        const op = secondChild.getFirstToken();
+        let operator = "";
+        switch (op.getStr()) {
+            case "+":
+                operator = " + ";
+                break;
+            case "-":
+                operator = " - ";
+                break;
+            case "/=":
+                operator = " / ";
+                break;
+            case "*=":
+                operator = " * ";
+                break;
+            case "&&=":
+                operator = " && ";
+                break;
+            default:
+                return undefined;
+        }
+        const target = (_a = high.findDirectExpression(Expressions.Target)) === null || _a === void 0 ? void 0 : _a.concatTokens();
+        if (target === undefined) {
+            return;
+        }
+        const sourceStart = (_c = (_b = high.findDirectExpression(Expressions.Source)) === null || _b === void 0 ? void 0 : _b.getFirstChild()) === null || _c === void 0 ? void 0 : _c.getFirstToken().getStart();
+        if (sourceStart === undefined) {
+            return;
+        }
+        const fix = edit_helper_1.EditHelper.replaceRange(lowFile, op.getStart(), sourceStart, "= " + target + operator);
+        return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Expand operator", this.getMetadata().key, this.conf.severity, fix);
+    }
     // must be very simple string templates, like "|{ ls_line-no ALPHA = IN }|"
     stringTemplateAlpha(node, lowFile) {
         var _a, _b, _c;

package/build/src/rules/function_module_recommendations.js

@@ -32,6 +32,8 @@ class FunctionModuleRecommendationsConf extends _basic_rule_config_1.BasicRuleCo
             { name: "REUSE_ALV_GRID_DISPLAY", replace: "use CL_SALV_TABLE=>FACTORY or CL_GUI_ALV_GRID" },
             { name: "CALCULATE_HASH_FOR_RAW", replace: "use CL_ABAP_HMAC" },
             { name: "FUNCTION_EXISTS", replace: "surround with try-catch CX_SY_DYN_CALL_ILLEGAL_METHOD instead" },
+            { name: "IGN_TIMESTAMP_DIFFERENCE", replace: "use CL_ABAP_TSTMP" },
+            { name: "IGN_TIMESTAMP_PLUSMINUS", replace: "use CL_ABAP_TSTMP" },
         ];
     }
 }
@@ -45,7 +47,7 @@ class FunctionModuleRecommendations extends _abap_rule_1.ABAPRule {
         return {
             key: "function_module_recommendations",
             title: "Function Module Recommendations",
-            shortDescription: `Function Module Recommendations`,
+            shortDescription: `Suggests replacements for various function modules`,
             extendedInformation: `https://docs.abapopenchecks.org/checks/53/`,
             tags: [_irule_1.RuleTag.SingleFile],
         };

package/build/src/version.js

@@ -18,7 +18,7 @@ var Version;
     Version["v756"] = "v756";
     Version["Cloud"] = "Cloud";
 })(Version = exports.Version || (exports.Version = {}));
-exports.defaultVersion = Version.v755;
+exports.defaultVersion = Version.v756;
 function getPreviousVersion(v) {
     if (v === Version.OpenABAP) {
         return Version.v702;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.85.18",
+    "version": "2.85.19",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -48,17 +48,17 @@
         "@microsoft/api-extractor": "^7.19.4",
         "@types/chai": "^4.3.0",
         "@types/mocha": "^9.1.0",
-        "@types/node": "^17.0.17",
+        "@types/node": "^17.0.18",
         "chai": "^4.3.6",
         "eslint": "^8.9.0",
         "mocha": "^9.2.0",
         "c8": "^7.11.0",
         "source-map-support": "^0.5.21",
-        "ts-json-schema-generator": "^0.97.0",
+        "ts-json-schema-generator": "^0.98.0",
         "typescript": "^4.5.5"
     },
     "dependencies": {
-        "fast-xml-parser": "^4.0.2",
+        "fast-xml-parser": "^4.0.3",
         "json5": "^2.2.0",
         "vscode-languageserver-protocol": "^3.16.0",
         "vscode-languageserver-types": "^3.16.0"