@abaplint/core 2.85.11 → 2.85.15

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (83) hide show
  1. package/README.md +6 -6
  2. package/build/abaplint.d.ts +2 -1
  3. package/build/src/abap/2_statements/statements/raise.js +1 -1
  4. package/build/src/abap/5_syntax/_builtin.js +2 -2
  5. package/build/src/abap/5_syntax/_type_utils.js +8 -0
  6. package/build/src/abap/5_syntax/basic_types.js +2 -1
  7. package/build/src/abap/5_syntax/expressions/method_call_param.js +0 -1
  8. package/build/src/abap/5_syntax/expressions/method_parameters.js +13 -15
  9. package/build/src/abap/flow/flow_graph.js +7 -7
  10. package/build/src/lsp/help.js +7 -7
  11. package/build/src/objects/domain.js +2 -1
  12. package/build/src/registry.js +1 -1
  13. package/build/src/rules/7bit_ascii.js +2 -2
  14. package/build/src/rules/abapdoc.js +1 -1
  15. package/build/src/rules/align_parameters.js +33 -33
  16. package/build/src/rules/ambiguous_statement.js +5 -5
  17. package/build/src/rules/avoid_use.js +6 -6
  18. package/build/src/rules/begin_end_names.js +4 -4
  19. package/build/src/rules/begin_single_include.js +12 -12
  20. package/build/src/rules/call_transaction_authority_check.js +3 -3
  21. package/build/src/rules/chain_mainly_declarations.js +4 -4
  22. package/build/src/rules/check_abstract.js +2 -2
  23. package/build/src/rules/check_comments.js +4 -4
  24. package/build/src/rules/check_include.js +3 -3
  25. package/build/src/rules/check_no_handler_pragma.js +8 -8
  26. package/build/src/rules/check_subrc.js +8 -8
  27. package/build/src/rules/commented_code.js +1 -1
  28. package/build/src/rules/constant_classes.js +3 -3
  29. package/build/src/rules/constructor_visibility_public.js +4 -4
  30. package/build/src/rules/contains_tab.js +2 -2
  31. package/build/src/rules/dangerous_statement.js +1 -1
  32. package/build/src/rules/downport.js +45 -45
  33. package/build/src/rules/exit_or_check.js +3 -3
  34. package/build/src/rules/exporting.js +1 -1
  35. package/build/src/rules/forbidden_identifier.js +1 -1
  36. package/build/src/rules/forbidden_void_type.js +2 -2
  37. package/build/src/rules/functional_writing.js +17 -17
  38. package/build/src/rules/global_class.js +10 -10
  39. package/build/src/rules/identical_conditions.js +2 -2
  40. package/build/src/rules/identical_contents.js +14 -14
  41. package/build/src/rules/identical_descriptions.js +4 -4
  42. package/build/src/rules/if_in_if.js +7 -7
  43. package/build/src/rules/implement_methods.js +3 -3
  44. package/build/src/rules/in_statement_indentation.js +11 -11
  45. package/build/src/rules/intf_referencing_clas.js +3 -3
  46. package/build/src/rules/line_break_style.js +2 -2
  47. package/build/src/rules/line_length.js +1 -1
  48. package/build/src/rules/line_only_punc.js +1 -1
  49. package/build/src/rules/local_variable_names.js +2 -2
  50. package/build/src/rules/many_parentheses.js +10 -10
  51. package/build/src/rules/max_one_method_parameter_per_line.js +7 -7
  52. package/build/src/rules/max_one_statement.js +3 -3
  53. package/build/src/rules/nesting.js +1 -1
  54. package/build/src/rules/no_chained_assignment.js +1 -1
  55. package/build/src/rules/no_public_attributes.js +1 -1
  56. package/build/src/rules/no_yoda_conditions.js +4 -4
  57. package/build/src/rules/obsolete_statement.js +40 -40
  58. package/build/src/rules/omit_parameter_name.js +3 -3
  59. package/build/src/rules/omit_receiving.js +13 -13
  60. package/build/src/rules/parser_702_chaining.js +2 -2
  61. package/build/src/rules/parser_error.js +2 -2
  62. package/build/src/rules/parser_missing_space.js +1 -1
  63. package/build/src/rules/prefer_inline.js +16 -16
  64. package/build/src/rules/prefer_is_not.js +7 -7
  65. package/build/src/rules/prefer_raise_exception_new.js +3 -3
  66. package/build/src/rules/prefer_returning_to_exporting.js +1 -1
  67. package/build/src/rules/prefer_xsdbool.js +2 -2
  68. package/build/src/rules/remove_descriptions.js +4 -4
  69. package/build/src/rules/rfc_error_handling.js +9 -9
  70. package/build/src/rules/select_add_order_by.js +5 -5
  71. package/build/src/rules/select_performance.js +2 -2
  72. package/build/src/rules/sicf_consistency.js +4 -4
  73. package/build/src/rules/space_before_dot.js +2 -2
  74. package/build/src/rules/start_at_tab.js +1 -1
  75. package/build/src/rules/sy_modification.js +2 -2
  76. package/build/src/rules/tabl_enhancement_category.js +2 -2
  77. package/build/src/rules/unused_methods.js +9 -9
  78. package/build/src/rules/unused_variables.js +6 -6
  79. package/build/src/rules/use_bool_expression.js +8 -8
  80. package/build/src/rules/use_line_exists.js +6 -6
  81. package/build/src/rules/use_new.js +2 -2
  82. package/build/src/rules/when_others_last.js +6 -6
  83. package/package.json +66 -66
package/README.md CHANGED
@@ -1,7 +1,7 @@
1
- # @abaplint/core
2
-
3
- [abaplint](https://abaplint.org/) core library
4
-
5
- Exposes functionallity like the parser and rules, which can be used in other projects.
6
-
1
+ # @abaplint/core
2
+
3
+ [abaplint](https://abaplint.org/) core library
4
+
5
+ Exposes functionality like the parser and rules, which can be used in other projects.
6
+
7
7
  For more information see https://github.com/abaplint/abaplint
@@ -1480,7 +1480,8 @@ declare class Domain extends AbstractObject {
1480
1480
 
1481
1481
  declare interface DomainValue {
1482
1482
  language: string;
1483
- value: string;
1483
+ low: string;
1484
+ high: string;
1484
1485
  description: string;
1485
1486
  }
1486
1487
 
@@ -11,7 +11,7 @@ class Raise {
11
11
  const exporting = (0, combi_1.seq)("EXPORTING", expressions_1.ParameterListS);
12
12
  const from = (0, combi_1.seq)("TYPE", expressions_1.ClassName, (0, combi_1.opt)((0, combi_1.alt)((0, combi_1.ver)(version_1.Version.v750, (0, combi_1.alt)(mess, messid)), (0, combi_1.ver)(version_1.Version.v752, "USING MESSAGE"))), (0, combi_1.optPrio)(exporting));
13
13
  const clas = (0, combi_1.seq)((0, combi_1.optPrio)("RESUMABLE"), "EXCEPTION", (0, combi_1.altPrio)(from, (0, combi_1.ver)(version_1.Version.v752, expressions_1.Source), expressions_1.SimpleSource2));
14
- const ret = (0, combi_1.seq)("RAISE", (0, combi_1.altPrio)(clas, expressions_1.Field));
14
+ const ret = (0, combi_1.seq)("RAISE", (0, combi_1.altPrio)(clas, expressions_1.ExceptionName));
15
15
  return ret;
16
16
  }
17
17
  }
@@ -42,7 +42,7 @@ class BuiltInMethod extends _identifier_1.Identifier {
42
42
  }
43
43
  const keys = Object.keys(this.method.mandatory);
44
44
  if (keys.length === 1) {
45
- return keys[0];
45
+ return keys[0].toUpperCase();
46
46
  }
47
47
  return undefined;
48
48
  }
@@ -651,7 +651,7 @@ BuiltIn.methods = [
651
651
  {
652
652
  name: "LINE_EXISTS",
653
653
  mandatory: {
654
- "val": new basic_1.TableType(new basic_1.AnyType(), { withHeader: false }),
654
+ "val": new basic_1.AnyType(),
655
655
  },
656
656
  return: new basic_1.CharacterType(1),
657
657
  version: version_1.Version.v740sp02,
@@ -7,6 +7,9 @@ class TypeUtils {
7
7
  if (type === undefined) {
8
8
  return false;
9
9
  }
10
+ else if (type instanceof basic_1.TableType && type.isWithHeader()) {
11
+ return this.isCharLike(type.getRowType());
12
+ }
10
13
  else if (type instanceof basic_1.StructureType) {
11
14
  for (const c of type.getComponents()) {
12
15
  if (this.isCharLike(c.type) === false) {
@@ -21,6 +24,11 @@ class TypeUtils {
21
24
  || type instanceof basic_1.UnknownType
22
25
  || type instanceof basic_1.NumericType
23
26
  || type instanceof basic_1.IntegerType
27
+ || type instanceof basic_1.FloatType
28
+ || type instanceof basic_1.FloatingPointType
29
+ || type instanceof basic_1.DecFloatType
30
+ || type instanceof basic_1.DecFloat16Type
31
+ || type instanceof basic_1.DecFloat34Type
24
32
  || type instanceof basic_1.NumericGenericType
25
33
  || type instanceof basic_1.CSequenceType
26
34
  || type instanceof basic_1.DateType
@@ -515,7 +515,8 @@ class BasicTypes {
515
515
  }
516
516
  subs.shift();
517
517
  while (subs.length > 0) {
518
- if (foundType instanceof Types.UnknownType) {
518
+ if (foundType instanceof Types.UnknownType
519
+ || foundType instanceof Types.VoidType) {
519
520
  return foundType;
520
521
  }
521
522
  else if (!(foundType instanceof Types.StructureType)) {
@@ -25,7 +25,6 @@ class MethodCallParam {
25
25
  throw new Error("Parameter \"" + required[0].getName() + "\" must be supplied");
26
26
  }
27
27
  }
28
- return;
29
28
  }
30
29
  else if (child instanceof nodes_1.ExpressionNode && child.get() instanceof Expressions.Source) {
31
30
  if (!(method instanceof basic_1.VoidType) && method.getParameters().getImporting().length === 0) {
@@ -7,6 +7,7 @@ const nodes_1 = require("../../nodes");
7
7
  const inline_data_1 = require("./inline_data");
8
8
  const target_1 = require("./target");
9
9
  const source_1 = require("./source");
10
+ const _type_utils_1 = require("../_type_utils");
10
11
  class MethodParameters {
11
12
  constructor() {
12
13
  this.requiredParameters = undefined;
@@ -63,7 +64,10 @@ class MethodParameters {
63
64
  new inline_data_1.InlineData().runSyntax(inline, scope, filename, type);
64
65
  }
65
66
  else if (target) {
66
- new target_1.Target().runSyntax(target, scope, filename);
67
+ const targetType = new target_1.Target().runSyntax(target, scope, filename);
68
+ if (targetType && _type_utils_1.TypeUtils.isAssignable(type, targetType) === false) {
69
+ throw new Error("Method returning value not type compatible");
70
+ }
67
71
  }
68
72
  }
69
73
  checkImporting(node, scope, method, filename) {
@@ -86,8 +90,8 @@ class MethodParameters {
86
90
  else if (item.targetType === undefined) {
87
91
  throw new Error("Could not determine target type");
88
92
  }
89
- else if (item.targetType) {
90
- // todo, check that targetType and parameterType are compatible
93
+ else if (item.targetType && _type_utils_1.TypeUtils.isAssignable(parameterType, item.targetType) === false) {
94
+ throw new Error("Method parameter type not compatible, " + item.name);
91
95
  }
92
96
  }
93
97
  }
@@ -105,34 +109,28 @@ class MethodParameters {
105
109
  }
106
110
  parameterType = parameter.getType();
107
111
  }
108
- if (item.targetType) {
109
- // todo, check that targetType and parameterType are compatible
110
- if (0) {
111
- console.log(parameterType); // todo
112
- }
112
+ if (item.targetType && _type_utils_1.TypeUtils.isAssignable(parameterType, item.targetType) === false) {
113
+ throw new Error("Method parameter type not compatible, " + item.name);
113
114
  }
114
115
  (_a = this.requiredParameters) === null || _a === void 0 ? void 0 : _a.delete(item.name);
115
116
  }
116
117
  }
117
118
  checkExporting(node, scope, method, filename, errors = true) {
119
+ const items = this.parameterListS(node, scope, filename, method);
118
120
  if (method instanceof basic_1.VoidType) {
119
- this.parameterListS(node, scope, filename, method);
120
121
  return;
121
122
  }
122
123
  const allImporting = method.getParameters().getImporting();
123
124
  if (this.requiredParameters === undefined) {
124
125
  this.requiredParameters = new Set(method.getParameters().getRequiredParameters().map(i => i.getName().toUpperCase()));
125
126
  }
126
- for (const item of this.parameterListS(node, scope, filename, method)) {
127
- let parameterType = undefined;
127
+ for (const item of items) {
128
128
  const parameter = allImporting.find(p => p.getName().toUpperCase() === item.name);
129
129
  if (parameter === undefined) {
130
130
  throw new Error("Method importing parameter \"" + item.name + "\" does not exist");
131
131
  }
132
- parameterType = parameter.getType();
133
- // todo, check that targetType and parameterType are compatible
134
- if (0) {
135
- console.log(parameterType); // todo
132
+ else if (_type_utils_1.TypeUtils.isAssignable(parameter.getType(), item.sourceType) === false) {
133
+ throw new Error("Method parameter type not compatible, " + item.name);
136
134
  }
137
135
  this.requiredParameters.delete(item.name);
138
136
  }
@@ -72,13 +72,13 @@ class FlowGraph {
72
72
  this.label = label;
73
73
  }
74
74
  toDigraph() {
75
- return `digraph G {
76
- labelloc="t";
77
- label="${this.label}";
78
- graph [fontname = "helvetica"];
79
- node [fontname = "helvetica", shape="box"];
80
- edge [fontname = "helvetica"];
81
- ${this.toTextEdges()}
75
+ return `digraph G {
76
+ labelloc="t";
77
+ label="${this.label}";
78
+ graph [fontname = "helvetica"];
79
+ node [fontname = "helvetica", shape="box"];
80
+ edge [fontname = "helvetica"];
81
+ ${this.toTextEdges()}
82
82
  }`;
83
83
  }
84
84
  listSources(node) {
@@ -19,13 +19,13 @@ class Help {
19
19
  /////////////////////////////////////////////////
20
20
  static dumpABAP(file, reg, textDocument, position) {
21
21
  let content = "";
22
- content = `
23
- <a href="#_tokens" rel="no-refresh">Tokens</a> |
24
- <a href="#_statements" rel="no-refresh">Statements</a> |
25
- <a href="#_structure" rel="no-refresh">Structure</a> |
26
- <a href="#_files" rel="no-refresh">Files</a> |
27
- <a href="#_info" rel="no-refresh">Info Dump</a>
28
- <hr>
22
+ content = `
23
+ <a href="#_tokens" rel="no-refresh">Tokens</a> |
24
+ <a href="#_statements" rel="no-refresh">Statements</a> |
25
+ <a href="#_structure" rel="no-refresh">Structure</a> |
26
+ <a href="#_files" rel="no-refresh">Files</a> |
27
+ <a href="#_info" rel="no-refresh">Info Dump</a>
28
+ <hr>
29
29
  ` +
30
30
  "<tt>" + textDocument.uri + " (" +
31
31
  (position.line + 1) + ", " +
@@ -52,7 +52,8 @@ class Domain extends _abstract_object_1.AbstractObject {
52
52
  for (const ddo7v of dd07v_tab) {
53
53
  const value = {
54
54
  description: ddo7v === null || ddo7v === void 0 ? void 0 : ddo7v.DDTEXT,
55
- value: ddo7v === null || ddo7v === void 0 ? void 0 : ddo7v.DOMVALUE_L,
55
+ low: ddo7v === null || ddo7v === void 0 ? void 0 : ddo7v.DOMVALUE_L,
56
+ high: ddo7v === null || ddo7v === void 0 ? void 0 : ddo7v.DOMVALUE_H,
56
57
  language: ddo7v === null || ddo7v === void 0 ? void 0 : ddo7v.DDLANGUAGE,
57
58
  };
58
59
  values.push(value);
@@ -68,7 +68,7 @@ class Registry {
68
68
  }
69
69
  static abaplintVersion() {
70
70
  // magic, see build script "version.sh"
71
- return "2.85.11";
71
+ return "2.85.15";
72
72
  }
73
73
  getDDICReferences() {
74
74
  return this.references;
@@ -17,8 +17,8 @@ class SevenBitAscii {
17
17
  key: "7bit_ascii",
18
18
  title: "Check for 7bit ascii",
19
19
  shortDescription: `Only allow characters from the 7bit ASCII set.`,
20
- extendedInformation: `https://docs.abapopenchecks.org/checks/05/
21
-
20
+ extendedInformation: `https://docs.abapopenchecks.org/checks/05/
21
+
22
22
  Checkes files with extension ".abap" and ".asddls"`,
23
23
  tags: [_irule_1.RuleTag.SingleFile],
24
24
  };
@@ -23,7 +23,7 @@ class Abapdoc extends _abap_rule_1.ABAPRule {
23
23
  return {
24
24
  key: "abapdoc",
25
25
  title: "Check abapdoc",
26
- shortDescription: `Various checks regarding abapdoc.
26
+ shortDescription: `Various checks regarding abapdoc.
27
27
  Base rule checks for existence of abapdoc for public class methods and all interface methods.`,
28
28
  tags: [_irule_1.RuleTag.SingleFile],
29
29
  };
@@ -20,42 +20,42 @@ class AlignParameters extends _abap_rule_1.ABAPRule {
20
20
  key: "align_parameters",
21
21
  title: "Align Parameters",
22
22
  shortDescription: `Checks for vertially aligned parameters`,
23
- extendedInformation: `Checks:
24
- * function module calls
25
- * method calls
26
- * VALUE constructors
27
- * NEW constructors
28
- * RAISE EXCEPTION statements
29
- * CREATE OBJECT statements
30
- * RAISE EVENT statements
31
-
32
- https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
33
-
34
- Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
35
-
23
+ extendedInformation: `Checks:
24
+ * function module calls
25
+ * method calls
26
+ * VALUE constructors
27
+ * NEW constructors
28
+ * RAISE EXCEPTION statements
29
+ * CREATE OBJECT statements
30
+ * RAISE EVENT statements
31
+
32
+ https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
33
+
34
+ Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
35
+
36
36
  Also https://rules.abaplint.org/max_one_method_parameter_per_line/ can help aligning parameter syntax`,
37
37
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide],
38
- badExample: `CALL FUNCTION 'FOOBAR'
39
- EXPORTING
40
- foo = 2
41
- parameter = 3.
42
-
43
- foobar( moo = 1
44
- param = 1 ).
45
-
46
- foo = VALUE #(
47
- foo = bar
38
+ badExample: `CALL FUNCTION 'FOOBAR'
39
+ EXPORTING
40
+ foo = 2
41
+ parameter = 3.
42
+
43
+ foobar( moo = 1
44
+ param = 1 ).
45
+
46
+ foo = VALUE #(
47
+ foo = bar
48
48
  moo = 2 ).`,
49
- goodExample: `CALL FUNCTION 'FOOBAR'
50
- EXPORTING
51
- foo = 2
52
- parameter = 3.
53
-
54
- foobar( moo = 1
55
- param = 1 ).
56
-
57
- foo = VALUE #(
58
- foo = bar
49
+ goodExample: `CALL FUNCTION 'FOOBAR'
50
+ EXPORTING
51
+ foo = 2
52
+ parameter = 3.
53
+
54
+ foobar( moo = 1
55
+ param = 1 ).
56
+
57
+ foo = VALUE #(
58
+ foo = bar
59
59
  moo = 2 ).`,
60
60
  };
61
61
  }
@@ -20,14 +20,14 @@ class AmbiguousStatement extends _abap_rule_1.ABAPRule {
20
20
  return {
21
21
  key: "ambiguous_statement",
22
22
  title: "Check for ambigious statements",
23
- shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
24
- Add "TABLE" keyword or "@" for escaping SQL variables
25
-
23
+ shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
24
+ Add "TABLE" keyword or "@" for escaping SQL variables
25
+
26
26
  Only works if the target version is 740sp05 or above`,
27
27
  tags: [_irule_1.RuleTag.SingleFile],
28
- badExample: `DELETE foo FROM bar.
28
+ badExample: `DELETE foo FROM bar.
29
29
  MODIFY foo FROM bar.`,
30
- goodExample: `DELETE foo FROM @bar.
30
+ goodExample: `DELETE foo FROM @bar.
31
31
  MODIFY TABLE foo FROM bar.`,
32
32
  };
33
33
  }
@@ -35,12 +35,12 @@ class AvoidUse extends _abap_rule_1.ABAPRule {
35
35
  key: "avoid_use",
36
36
  title: "Avoid use of certain statements",
37
37
  shortDescription: `Detects usage of certain statements.`,
38
- extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
39
-
40
- Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
41
-
42
- STATICS: use CLASS-DATA instead
43
-
38
+ extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
39
+
40
+ Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
41
+
42
+ STATICS: use CLASS-DATA instead
43
+
44
44
  DESCRIBE TABLE LINES: use lines() instead (quickfix exists)`,
45
45
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
46
46
  };
@@ -23,11 +23,11 @@ class BeginEndNames extends _abap_rule_1.ABAPRule {
23
23
  title: "Check BEGIN END names",
24
24
  shortDescription: `Check BEGIN OF and END OF names match, plus there must be statements between BEGIN and END`,
25
25
  tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
26
- badExample: `DATA: BEGIN OF stru,
27
- field TYPE i,
26
+ badExample: `DATA: BEGIN OF stru,
27
+ field TYPE i,
28
28
  END OF structure_not_the_same.`,
29
- goodExample: `DATA: BEGIN OF stru,
30
- field TYPE i,
29
+ goodExample: `DATA: BEGIN OF stru,
30
+ field TYPE i,
31
31
  END OF stru.`,
32
32
  };
33
33
  }
@@ -21,19 +21,19 @@ class BeginSingleInclude extends _abap_rule_1.ABAPRule {
21
21
  title: "BEGIN contains single INCLUDE",
22
22
  shortDescription: `Finds TYPE BEGIN with just one INCLUDE TYPE, and DATA with single INCLUDE STRUCTURE`,
23
23
  tags: [_irule_1.RuleTag.SingleFile],
24
- badExample: `TYPES: BEGIN OF dummy1.
25
- INCLUDE TYPE dselc.
26
- TYPES: END OF dummy1.
27
-
28
- DATA BEGIN OF foo.
29
- INCLUDE STRUCTURE syst.
30
- DATA END OF foo.
31
-
32
- STATICS BEGIN OF bar.
33
- INCLUDE STRUCTURE syst.
24
+ badExample: `TYPES: BEGIN OF dummy1.
25
+ INCLUDE TYPE dselc.
26
+ TYPES: END OF dummy1.
27
+
28
+ DATA BEGIN OF foo.
29
+ INCLUDE STRUCTURE syst.
30
+ DATA END OF foo.
31
+
32
+ STATICS BEGIN OF bar.
33
+ INCLUDE STRUCTURE syst.
34
34
  STATICS END OF bar.`,
35
- goodExample: `DATA BEGIN OF foo.
36
- INCLUDE STRUCTURE dselc.
35
+ goodExample: `DATA BEGIN OF foo.
36
+ INCLUDE STRUCTURE dselc.
37
37
  DATA END OF foo.`,
38
38
  };
39
39
  }
@@ -24,9 +24,9 @@ class CallTransactionAuthorityCheck extends _abap_rule_1.ABAPRule {
24
24
  extendedInformation: `https://docs.abapopenchecks.org/checks/54/`,
25
25
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
26
26
  badExample: `CALL TRANSACTION 'FOO'.`,
27
- goodExample: `TRY.
28
- CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.
29
- CATCH cx_sy_authorization_error.
27
+ goodExample: `TRY.
28
+ CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.
29
+ CATCH cx_sy_authorization_error.
30
30
  ENDTRY.`,
31
31
  };
32
32
  }
@@ -45,10 +45,10 @@ class ChainMainlyDeclarations extends _abap_rule_1.ABAPRule {
45
45
  key: "chain_mainly_declarations",
46
46
  title: "Chain mainly declarations",
47
47
  shortDescription: `Chain mainly declarations, allows chaining for the configured statements, reports errors for other statements.`,
48
- extendedInformation: `
49
- https://docs.abapopenchecks.org/checks/23/
50
-
51
- https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
48
+ extendedInformation: `
49
+ https://docs.abapopenchecks.org/checks/23/
50
+
51
+ https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
52
52
  `,
53
53
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
54
54
  badExample: `CALL METHOD: bar.`,
@@ -23,8 +23,8 @@ class CheckAbstract extends _abap_rule_1.ABAPRule {
23
23
  return {
24
24
  key: "check_abstract",
25
25
  title: "Check abstract methods and classes",
26
- shortDescription: `Checks abstract methods and classes:
27
- - class defined as abstract and final,
26
+ shortDescription: `Checks abstract methods and classes:
27
+ - class defined as abstract and final,
28
28
  - non-abstract class contains abstract methods`,
29
29
  extendedInformation: `If a class defines only constants, use an interface instead`,
30
30
  tags: [_irule_1.RuleTag.SingleFile],
@@ -27,11 +27,11 @@ class CheckComments extends _abap_rule_1.ABAPRule {
27
27
  return {
28
28
  key: "check_comments",
29
29
  title: "Check Comments",
30
- shortDescription: `
30
+ shortDescription: `
31
31
  Various checks for comment usage.`,
32
- extendedInformation: `
33
- * End of line comments. Comments starting with "#EC" or "##" are ignored
34
-
32
+ extendedInformation: `
33
+ * End of line comments. Comments starting with "#EC" or "##" are ignored
34
+
35
35
  https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#put-comments-before-the-statement-they-relate-to`,
36
36
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
37
37
  };
@@ -17,9 +17,9 @@ class CheckInclude {
17
17
  key: "check_include",
18
18
  title: "Check INCLUDEs",
19
19
  shortDescription: `Checks INCLUDE statements`,
20
- extendedInformation: `
21
- * Reports unused includes
22
- * Errors if the includes are not found
20
+ extendedInformation: `
21
+ * Reports unused includes
22
+ * Errors if the includes are not found
23
23
  * Error if including a main program`,
24
24
  tags: [_irule_1.RuleTag.Syntax],
25
25
  };
@@ -21,15 +21,15 @@ class CheckNoHandlerPragma extends _abap_rule_1.ABAPRule {
21
21
  title: "Check if NO_HANDLER can be removed",
22
22
  shortDescription: `Checks NO_HANDLER pragmas that can be removed`,
23
23
  tags: [_irule_1.RuleTag.SingleFile],
24
- badExample: `TRY.
25
- ...
26
- CATCH zcx_abapgit_exception ##NO_HANDLER.
27
- RETURN. " it has a handler
24
+ badExample: `TRY.
25
+ ...
26
+ CATCH zcx_abapgit_exception ##NO_HANDLER.
27
+ RETURN. " it has a handler
28
28
  ENDTRY.`,
29
- goodExample: `TRY.
30
- ...
31
- CATCH zcx_abapgit_exception.
32
- RETURN.
29
+ goodExample: `TRY.
30
+ ...
31
+ CATCH zcx_abapgit_exception.
32
+ RETURN.
33
33
  ENDTRY.`,
34
34
  };
35
35
  }
@@ -34,14 +34,14 @@ class CheckSubrc extends _abap_rule_1.ABAPRule {
34
34
  key: "check_subrc",
35
35
  title: "Check sy-subrc",
36
36
  shortDescription: `Check sy-subrc`,
37
- extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
38
-
39
- If sy-dbcnt is checked after database statements, it is considered okay.
40
-
41
- "SELECT SINGLE @abap_true FROM " is considered as an existence check
42
-
43
- If IS ASSIGNED is checked after assigning, it is considered okay.
44
-
37
+ extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
38
+
39
+ If sy-dbcnt is checked after database statements, it is considered okay.
40
+
41
+ "SELECT SINGLE @abap_true FROM " is considered as an existence check
42
+
43
+ If IS ASSIGNED is checked after assigning, it is considered okay.
44
+
45
45
  FIND statement with MATCH COUNT is considered okay if subrc is not checked`,
46
46
  tags: [_irule_1.RuleTag.SingleFile],
47
47
  pseudoComment: "EC CI_SUBRC",
@@ -30,7 +30,7 @@ class CommentedCode extends _abap_rule_1.ABAPRule {
30
30
  key: "commented_code",
31
31
  title: "Find commented code",
32
32
  shortDescription: `Detects usage of commented out code.`,
33
- extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
33
+ extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
34
34
  https://docs.abapopenchecks.org/checks/14/`,
35
35
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
36
36
  };
@@ -61,7 +61,7 @@ class ConstantClasses {
61
61
  return [];
62
62
  }
63
63
  const domainValueInfo = obj.getFixedValues();
64
- const domainValues = domainValueInfo.map(x => x.value);
64
+ const domainValues = domainValueInfo.map(x => x.low);
65
65
  const issues = [];
66
66
  if (obj.getFixedValues().length === 0) {
67
67
  // possibly this is not even a domain with fixed values
@@ -94,8 +94,8 @@ class ConstantClasses {
94
94
  }
95
95
  }
96
96
  for (const d of domainValueInfo) {
97
- if (!def.constants.find(c => c.value === d.value)) {
98
- issues.push(issue_1.Issue.atStatement(classContents, classContents.getStatements()[0], `Missing constant for ${d.value} (domain ${configEntry.domain})`, this.getMetadata().key, this.conf.severity));
97
+ if (!def.constants.find(c => c.value === d.low)) {
98
+ issues.push(issue_1.Issue.atStatement(classContents, classContents.getStatements()[0], `Missing constant for ${d.low} (domain ${configEntry.domain})`, this.getMetadata().key, this.conf.severity));
99
99
  // quickfix will add constant
100
100
  }
101
101
  }
@@ -18,10 +18,10 @@ class ConstructorVisibilityPublic {
18
18
  key: "constructor_visibility_public",
19
19
  title: "Check constructor visibility is public",
20
20
  shortDescription: `Constructor must be placed in the public section, even if the class is not CREATE PUBLIC.`,
21
- extendedInformation: `
22
- This only applies to global classes.
23
-
24
- https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
21
+ extendedInformation: `
22
+ This only applies to global classes.
23
+
24
+ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
25
25
  https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abeninstance_constructor_guidl.htm`,
26
26
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
27
27
  };
@@ -25,8 +25,8 @@ class ContainsTab extends _abap_rule_1.ABAPRule {
25
25
  key: "contains_tab",
26
26
  title: "Code contains tab",
27
27
  shortDescription: `Checks for usage of tabs (enable to enforce spaces)`,
28
- extendedInformation: `
29
- https://docs.abapopenchecks.org/checks/09/
28
+ extendedInformation: `
29
+ https://docs.abapopenchecks.org/checks/09/
30
30
  https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#indent-and-snap-to-tab`,
31
31
  tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
32
32
  };
@@ -40,7 +40,7 @@ class DangerousStatement extends _abap_rule_1.ABAPRule {
40
40
  key: "dangerous_statement",
41
41
  title: "Dangerous statement",
42
42
  shortDescription: `Detects potentially dangerous statements`,
43
- extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
43
+ extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
44
44
  dynamic SQL can potentially create SQL injection problems`,
45
45
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
46
46
  };