@abaplint/core 2.85.10 → 2.85.14

package/README.md

@@ -2,6 +2,6 @@
 
 [abaplint](https://abaplint.org/) core library
 
-Exposes functionallity like the parser and rules, which can be used in other projects.
+Exposes functionality like the parser and rules, which can be used in other projects.
 
 For more information see https://github.com/abaplint/abaplint

package/build/abaplint.d.ts

@@ -1480,7 +1480,8 @@ declare class Domain extends AbstractObject {
 
 declare interface DomainValue {
     language: string;
-    value: string;
+    low: string;
+    high: string;
     description: string;
 }
 

package/build/src/abap/2_statements/statements/raise.js

@@ -11,7 +11,7 @@ class Raise {
         const exporting = (0, combi_1.seq)("EXPORTING", expressions_1.ParameterListS);
         const from = (0, combi_1.seq)("TYPE", expressions_1.ClassName, (0, combi_1.opt)((0, combi_1.alt)((0, combi_1.ver)(version_1.Version.v750, (0, combi_1.alt)(mess, messid)), (0, combi_1.ver)(version_1.Version.v752, "USING MESSAGE"))), (0, combi_1.optPrio)(exporting));
         const clas = (0, combi_1.seq)((0, combi_1.optPrio)("RESUMABLE"), "EXCEPTION", (0, combi_1.altPrio)(from, (0, combi_1.ver)(version_1.Version.v752, expressions_1.Source), expressions_1.SimpleSource2));
-        const ret = (0, combi_1.seq)("RAISE", (0, combi_1.altPrio)(clas, expressions_1.Field));
+        const ret = (0, combi_1.seq)("RAISE", (0, combi_1.altPrio)(clas, expressions_1.ExceptionName));
         return ret;
     }
 }

package/build/src/abap/5_syntax/_builtin.js

@@ -42,7 +42,7 @@ class BuiltInMethod extends _identifier_1.Identifier {
         }
         const keys = Object.keys(this.method.mandatory);
         if (keys.length === 1) {
-            return keys[0];
+            return keys[0].toUpperCase();
         }
         return undefined;
     }
@@ -651,7 +651,7 @@ BuiltIn.methods = [
     {
         name: "LINE_EXISTS",
         mandatory: {
-            "val": new basic_1.TableType(new basic_1.AnyType(), { withHeader: false }),
+            "val": new basic_1.AnyType(),
         },
         return: new basic_1.CharacterType(1),
         version: version_1.Version.v740sp02,

package/build/src/abap/5_syntax/_type_utils.js

@@ -7,6 +7,9 @@ class TypeUtils {
         if (type === undefined) {
             return false;
         }
+        else if (type instanceof basic_1.TableType && type.isWithHeader()) {
+            return this.isCharLike(type.getRowType());
+        }
         else if (type instanceof basic_1.StructureType) {
             for (const c of type.getComponents()) {
                 if (this.isCharLike(c.type) === false) {
@@ -20,6 +23,13 @@ class TypeUtils {
             || type instanceof basic_1.AnyType
             || type instanceof basic_1.UnknownType
             || type instanceof basic_1.NumericType
+            || type instanceof basic_1.IntegerType
+            || type instanceof basic_1.FloatType
+            || type instanceof basic_1.FloatingPointType
+            || type instanceof basic_1.DecFloatType
+            || type instanceof basic_1.DecFloat16Type
+            || type instanceof basic_1.DecFloat34Type
+            || type instanceof basic_1.NumericGenericType
             || type instanceof basic_1.CSequenceType
             || type instanceof basic_1.DateType
             || type instanceof basic_1.CLikeType
@@ -53,8 +63,8 @@ class TypeUtils {
     }
     static isAssignable(source, target) {
         /*
-        console.dir(source);
-        console.dir(target);
+            console.dir(source);
+            console.dir(target);
         */
         if (target instanceof basic_1.TableType) {
             if (target.isWithHeader()) {
@@ -97,8 +107,13 @@ class TypeUtils {
                 || source instanceof basic_1.UnknownType) {
                 return true;
             }
-            else if (this.isCharLike(target)
-                && (this.isCharLike(source) || source instanceof basic_1.IntegerType)) {
+            else if (target.containsVoid() === true) {
+                return true;
+            }
+            else if (source instanceof basic_1.IntegerType) {
+                return false;
+            }
+            else if (this.isCharLike(target) && this.isCharLike(source)) {
                 return true;
             }
             return false;

package/build/src/abap/5_syntax/expressions/attribute_chain.js

@@ -18,7 +18,7 @@ class AttributeChain {
         if (!(first.get() instanceof expressions_1.AttributeName)) {
             throw new Error("AttributeChain, unexpected first child");
         }
-        const def = scope.findClassDefinition(inputContext.getIdentifierName());
+        const def = scope.findObjectDefinition(inputContext.getIdentifierName());
         if (def === undefined) {
             throw new Error("Definition for \"" + inputContext.getIdentifierName() + "\" not found in scope(AttributeChain)");
         }

package/build/src/abap/5_syntax/expressions/constant.js

@@ -8,6 +8,9 @@ class Constant {
         if (node.findDirectExpression(expressions_1.Integer)) {
             return new basic_1.IntegerType("I");
         }
+        else if (node.getFirstToken().getStr().startsWith("'")) {
+            return new basic_1.CharacterType(10);
+        }
         else {
             return new basic_1.StringType("STRING");
         }

package/build/src/abap/5_syntax/expressions/method_call_param.js

@@ -25,7 +25,6 @@ class MethodCallParam {
                     throw new Error("Parameter \"" + required[0].getName() + "\" must be supplied");
                 }
             }
-            return;
         }
         else if (child instanceof nodes_1.ExpressionNode && child.get() instanceof Expressions.Source) {
             if (!(method instanceof basic_1.VoidType) && method.getParameters().getImporting().length === 0) {

package/build/src/abap/5_syntax/expressions/method_parameters.js

@@ -7,6 +7,7 @@ const nodes_1 = require("../../nodes");
 const inline_data_1 = require("./inline_data");
 const target_1 = require("./target");
 const source_1 = require("./source");
+const _type_utils_1 = require("../_type_utils");
 class MethodParameters {
     constructor() {
         this.requiredParameters = undefined;
@@ -63,7 +64,10 @@ class MethodParameters {
             new inline_data_1.InlineData().runSyntax(inline, scope, filename, type);
         }
         else if (target) {
-            new target_1.Target().runSyntax(target, scope, filename);
+            const targetType = new target_1.Target().runSyntax(target, scope, filename);
+            if (targetType && _type_utils_1.TypeUtils.isAssignable(type, targetType) === false) {
+                throw new Error("Method returning value not type compatible");
+            }
         }
     }
     checkImporting(node, scope, method, filename) {
@@ -86,8 +90,8 @@ class MethodParameters {
             else if (item.targetType === undefined) {
                 throw new Error("Could not determine target type");
             }
-            else if (item.targetType) {
-                // todo, check that targetType and parameterType are compatible
+            else if (item.targetType && _type_utils_1.TypeUtils.isAssignable(parameterType, item.targetType) === false) {
+                throw new Error("Method parameter type not compatible, " + item.name);
             }
         }
     }
@@ -105,34 +109,28 @@ class MethodParameters {
                 }
                 parameterType = parameter.getType();
             }
-            if (item.targetType) {
-                // todo, check that targetType and parameterType are compatible
-                if (0) {
-                    console.log(parameterType); // todo
-                }
+            if (item.targetType && _type_utils_1.TypeUtils.isAssignable(parameterType, item.targetType) === false) {
+                throw new Error("Method parameter type not compatible, " + item.name);
             }
             (_a = this.requiredParameters) === null || _a === void 0 ? void 0 : _a.delete(item.name);
         }
     }
     checkExporting(node, scope, method, filename, errors = true) {
+        const items = this.parameterListS(node, scope, filename, method);
         if (method instanceof basic_1.VoidType) {
-            this.parameterListS(node, scope, filename, method);
             return;
         }
         const allImporting = method.getParameters().getImporting();
         if (this.requiredParameters === undefined) {
             this.requiredParameters = new Set(method.getParameters().getRequiredParameters().map(i => i.getName().toUpperCase()));
         }
-        for (const item of this.parameterListS(node, scope, filename, method)) {
-            let parameterType = undefined;
+        for (const item of items) {
             const parameter = allImporting.find(p => p.getName().toUpperCase() === item.name);
             if (parameter === undefined) {
                 throw new Error("Method importing parameter \"" + item.name + "\" does not exist");
             }
-            parameterType = parameter.getType();
-            // todo, check that targetType and parameterType are compatible
-            if (0) {
-                console.log(parameterType); // todo
+            else if (_type_utils_1.TypeUtils.isAssignable(parameter.getType(), item.sourceType) === false) {
+                throw new Error("Method parameter type not compatible, " + item.name);
             }
             this.requiredParameters.delete(item.name);
         }

package/build/src/abap/5_syntax/statements/write.js

@@ -5,11 +5,18 @@ const Expressions = require("../../2_statements/expressions");
 const source_1 = require("../expressions/source");
 const target_1 = require("../expressions/target");
 const dynamic_1 = require("../expressions/dynamic");
+const _type_utils_1 = require("../_type_utils");
 class Write {
     runSyntax(node, scope, filename) {
         // todo, more
+        const second = node.getChildren()[1];
         for (const s of node.findAllExpressions(Expressions.Source)) {
-            new source_1.Source().runSyntax(s, scope, filename);
+            const type = new source_1.Source().runSyntax(s, scope, filename);
+            if (s === second
+                && _type_utils_1.TypeUtils.isCharLike(type) === false
+                && _type_utils_1.TypeUtils.isHexLike(type) === false) {
+                throw new Error("Source not character like");
+            }
         }
         for (const s of node.findAllExpressions(Expressions.Dynamic)) {
             new dynamic_1.Dynamic().runSyntax(s, scope, filename);

package/build/src/abap/types/basic/structure_type.js

@@ -43,7 +43,7 @@ class StructureType extends _abstract_type_1.AbstractType {
         return "StructureTypetoABAPtodo";
     }
     containsVoid() {
-        return this.getComponents().some(c => { c.type.containsVoid(); });
+        return this.getComponents().some(c => { return c.type.containsVoid(); });
     }
     toCDS() {
         return "abap.TODO_STRUCTURE";

package/build/src/objects/domain.js

@@ -52,7 +52,8 @@ class Domain extends _abstract_object_1.AbstractObject {
         for (const ddo7v of dd07v_tab) {
             const value = {
                 description: ddo7v === null || ddo7v === void 0 ? void 0 : ddo7v.DDTEXT,
-                value: ddo7v === null || ddo7v === void 0 ? void 0 : ddo7v.DOMVALUE_L,
+                low: ddo7v === null || ddo7v === void 0 ? void 0 : ddo7v.DOMVALUE_L,
+                high: ddo7v === null || ddo7v === void 0 ? void 0 : ddo7v.DOMVALUE_H,
                 language: ddo7v === null || ddo7v === void 0 ? void 0 : ddo7v.DDLANGUAGE,
             };
             values.push(value);

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.85.10";
+        return "2.85.14";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/constant_classes.js

@@ -61,7 +61,7 @@ class ConstantClasses {
                 return [];
             }
             const domainValueInfo = obj.getFixedValues();
-            const domainValues = domainValueInfo.map(x => x.value);
+            const domainValues = domainValueInfo.map(x => x.low);
             const issues = [];
             if (obj.getFixedValues().length === 0) {
                 // possibly this is not even a domain with fixed values
@@ -94,8 +94,8 @@ class ConstantClasses {
                 }
             }
             for (const d of domainValueInfo) {
-                if (!def.constants.find(c => c.value === d.value)) {
-                    issues.push(issue_1.Issue.atStatement(classContents, classContents.getStatements()[0], `Missing constant for ${d.value} (domain ${configEntry.domain})`, this.getMetadata().key, this.conf.severity));
+                if (!def.constants.find(c => c.value === d.low)) {
+                    issues.push(issue_1.Issue.atStatement(classContents, classContents.getStatements()[0], `Missing constant for ${d.low} (domain ${configEntry.domain})`, this.getMetadata().key, this.conf.severity));
                     // quickfix will add constant
                 }
             }

package/build/src/rules/unused_variables.js

@@ -66,7 +66,7 @@ class UnusedVariables {
             shortDescription: `Checks for unused variables and constants`,
             extendedInformation: `WARNING: slow
 
-Experimental, might give false positives. Skips event parameters.
+Skips event parameters.
 
 Note that this currently does not work if the source code uses macros.
 

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.85.10",
+    "version": "2.85.14",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -48,7 +48,7 @@
         "@microsoft/api-extractor": "^7.19.4",
         "@types/chai": "^4.3.0",
         "@types/mocha": "^9.1.0",
-        "@types/node": "^17.0.15",
+        "@types/node": "^17.0.17",
         "chai": "^4.3.6",
         "eslint": "^8.8.0",
         "mocha": "^9.2.0",