@abaplint/core 2.84.12 → 2.85.3

package/build/abaplint.d.ts

@@ -25,7 +25,7 @@ export declare abstract class ABAPObject extends AbstractObject {
     abstract getDescription(): string | undefined;
     constructor(name: string);
     static is(x: any): x is ABAPObject;
-    parse(version: Version, globalMacros?: readonly string[]): IParseResult;
+    parse(version: Version, globalMacros?: readonly string[], reg?: IRegistry): IParseResult;
     setDirty(): void;
     getABAPFiles(): readonly ABAPFile[];
     getABAPFileByName(filename: string): ABAPFile | undefined;
@@ -79,7 +79,7 @@ declare abstract class AbstractObject implements IObject {
     abstract getDescription(): string | undefined;
     constructor(name: string);
     getParsingIssues(): readonly Issue[];
-    parse(_version?: Version, _globalMacros?: readonly string[]): IParseResult;
+    parse(_version?: Version, _globalMacros?: readonly string[], _reg?: IRegistry): IParseResult;
     getName(): string;
     setDirty(): void;
     addFile(file: IFile): void;
@@ -3100,8 +3100,10 @@ export declare interface IObject extends IArtifact {
     getDescription(): string | undefined;
     setDirty(): void;
     isDirty(): boolean;
-    /** returns true if the object was parsed, false if no changes since last parse */
-    parse(version?: Version, globalMacros?: readonly string[], globalExclude?: readonly string[]): IParseResult;
+    /** returns true if the object was parsed, false if no changes since last parse
+     * registry for global cross object macros
+     */
+    parse(version?: Version, globalMacros?: readonly string[], reg?: IRegistry): IParseResult;
     getParsingIssues(): readonly Issue[];
     getFiles(): readonly IFile[];
     addFile(file: IFile): void;

package/build/src/abap/1_lexer/lexer.js

@@ -319,7 +319,12 @@ class Lexer {
                 && ahead !== "`") {
                 // end of ping
                 this.add();
-                this.m = Mode.Normal;
+                if (ahead === `"`) {
+                    this.m = Mode.Comment;
+                }
+                else {
+                    this.m = Mode.Normal;
+                }
             }
             else if (this.m === Mode.Template
                 && buf.length > 1

package/build/src/abap/2_statements/expand_macros.js

@@ -2,6 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ExpandMacros = void 0;
 const Statements = require("./statements");
+const Expressions = require("./expressions");
 const Tokens = require("../1_lexer/tokens");
 const _statement_1 = require("./statements/_statement");
 const statement_node_1 = require("../nodes/statement_node");
@@ -37,11 +38,15 @@ class Macros {
     }
 }
 class ExpandMacros {
-    constructor(globalMacros, version) {
+    // "reg" must be supplied if there are cross object macros via INCLUDE
+    constructor(globalMacros, version, reg) {
         this.macros = new Macros(globalMacros);
         this.version = version;
+        this.globalMacros = globalMacros;
+        this.reg = reg;
     }
     find(statements) {
+        var _a, _b;
         let name = undefined;
         let contents = [];
         for (let i = 0; i < statements.length; i++) {
@@ -52,6 +57,19 @@ class ExpandMacros {
                 name = statement.getTokens()[1].getStr();
                 contents = [];
             }
+            else if (type instanceof Statements.Include) {
+                const includeName = (_a = statement.findDirectExpression(Expressions.IncludeName)) === null || _a === void 0 ? void 0 : _a.concatTokens();
+                // todo, this does not take function module includes into account
+                const prog = (_b = this.reg) === null || _b === void 0 ? void 0 : _b.getObject("PROG", includeName);
+                if (prog) {
+                    prog.parse(this.version, this.globalMacros, this.reg);
+                    const main = prog.getMainABAPFile();
+                    if (main) {
+                        // slow, this copies everything,
+                        this.find([...main.getStatements()]);
+                    }
+                }
+            }
             else if (name) {
                 if (type instanceof Statements.EndOfDefinition) {
                     this.macros.addMacro(name, contents);
@@ -116,7 +134,7 @@ class ExpandMacros {
         }
         const file = new memory_file_1.MemoryFile("expand_macros.abap.prog", str);
         const lexerResult = lexer_1.Lexer.run(file, statement.getFirstToken().getStart());
-        const result = new statement_parser_1.StatementParser(this.version).run([lexerResult], this.macros.listMacroNames());
+        const result = new statement_parser_1.StatementParser(this.version, this.reg).run([lexerResult], this.macros.listMacroNames());
         return result[0].statements;
     }
     buildInput(statement) {

package/build/src/abap/2_statements/expressions/concatenated_constant.js

@@ -4,8 +4,9 @@ exports.ConcatenatedConstant = void 0;
 const combi_1 = require("../combi");
 class ConcatenatedConstant extends combi_1.Expression {
     getRunnable() {
-        // todo: replace optPrio with plusPrio when its implemented, below is a workaround
-        return (0, combi_1.seq)((0, combi_1.regex)(/^`.*`$/), "&", (0, combi_1.regex)(/^`.*`$/), (0, combi_1.optPrio)((0, combi_1.seq)("&", (0, combi_1.regex)(/^`.*`$/))), (0, combi_1.optPrio)((0, combi_1.seq)("&", (0, combi_1.regex)(/^`.*`$/))), (0, combi_1.optPrio)((0, combi_1.seq)("&", (0, combi_1.regex)(/^`.*`$/))));
+        const str = (0, combi_1.seq)((0, combi_1.regex)(/^`.*`$/), (0, combi_1.plusPrio)((0, combi_1.seq)("&", (0, combi_1.regex)(/^`.*`$/))));
+        const char = (0, combi_1.seq)((0, combi_1.regex)(/^'.*'$/), (0, combi_1.plusPrio)((0, combi_1.seq)("&", (0, combi_1.regex)(/^'.*'$/))));
+        return (0, combi_1.altPrio)(str, char);
     }
 }
 exports.ConcatenatedConstant = ConcatenatedConstant;

package/build/src/abap/2_statements/expressions/form_param.js

@@ -5,7 +5,7 @@ const combi_1 = require("../combi");
 const _1 = require(".");
 class FormParam extends combi_1.Expression {
     getRunnable() {
-        const stru = (0, combi_1.seq)("STRUCTURE", _1.NamespaceSimpleName);
+        const stru = (0, combi_1.seq)("STRUCTURE", _1.SimpleFieldChain);
         const ret = (0, combi_1.seq)((0, combi_1.altPrio)(_1.PassByValue, _1.FormParamName), (0, combi_1.optPrio)((0, combi_1.altPrio)(_1.FormParamType, stru)));
         return ret;
     }

package/build/src/abap/2_statements/expressions/sql_alias_field.js

@@ -4,7 +4,7 @@ exports.SQLAliasField = void 0;
 const combi_1 = require("../combi");
 class SQLAliasField extends combi_1.Expression {
     getRunnable() {
-        return (0, combi_1.regex)(/^\w+~\w+$/);
+        return (0, combi_1.regex)(/^(\/\w+\/)?\w+~\w+$/);
     }
 }
 exports.SQLAliasField = SQLAliasField;

package/build/src/abap/2_statements/statement_parser.js

@@ -63,15 +63,16 @@ class WorkArea {
     }
 }
 class StatementParser {
-    constructor(version) {
+    constructor(version, reg) {
         if (!StatementParser.map) {
             StatementParser.map = new StatementMap();
         }
         this.version = version;
+        this.reg = reg;
     }
     /** input is one full object */
     run(input, globalMacros) {
-        const macros = new expand_macros_1.ExpandMacros(globalMacros, this.version);
+        const macros = new expand_macros_1.ExpandMacros(globalMacros, this.version, this.reg);
         const wa = input.map(i => new WorkArea(i.file, i.tokens));
         for (const w of wa) {
             this.process(w);

package/build/src/abap/5_syntax/_object_oriented.js

@@ -195,13 +195,14 @@ class ObjectOriented {
         if (def === undefined || name === undefined) {
             return undefined;
         }
+        const upper = name.toUpperCase();
         for (const a of def.getAttributes().getConstants()) {
-            if (a.getName().toUpperCase() === name.toUpperCase()) {
+            if (a.getName().toUpperCase() === upper) {
                 return a;
             }
         }
         for (const a of def.getAliases().getAll()) {
-            if (a.getName().toUpperCase() === name.toUpperCase()) {
+            if (a.getName().toUpperCase() === upper) {
                 const comp = a.getComponent();
                 const res = this.searchConstantName(this.scope.findObjectDefinition(comp.split("~")[0]), comp.split("~")[1]);
                 if (res) {
@@ -209,6 +210,12 @@ class ObjectOriented {
                 }
             }
         }
+        if (name.includes("~")) {
+            const interfaceName = upper.split("~")[0];
+            if (def.getImplementing().some((a) => a.name.toUpperCase() === interfaceName)) {
+                return this.searchConstantName(this.scope.findInterfaceDefinition(interfaceName), name.split("~")[1]);
+            }
+        }
         const sup = def.getSuperClass();
         if (sup) {
             return this.searchConstantName(this.findSuperDefinition(sup), name);

package/build/src/abap/5_syntax/basic_types.js

@@ -65,6 +65,9 @@ class BasicTypes {
         if (chain === undefined) {
             chain = node.findFirstExpression(Expressions.FieldSub);
         }
+        if (chain === undefined) {
+            chain = node.findFirstExpression(Expressions.SimpleFieldChain);
+        }
         if (chain === undefined) {
             throw new Error("resolveLikeName, chain undefined");
         }

package/build/src/abap/5_syntax/expressions/form_param.js

@@ -11,7 +11,7 @@ class FormParam {
         const nameToken = (_a = node.findFirstExpression(expressions_1.FormParamName)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
         if (node.findDirectTokenByText("STRUCTURE") && nameToken) {
             // STRUCTURES typing
-            const typeName = (_b = node.findDirectExpression(expressions_1.NamespaceSimpleName)) === null || _b === void 0 ? void 0 : _b.getFirstToken().getStr();
+            const typeName = (_b = node.findDirectExpression(expressions_1.SimpleFieldChain)) === null || _b === void 0 ? void 0 : _b.getFirstToken().getStr();
             let type = undefined;
             if (typeName) {
                 type = (_c = scope.findType(typeName)) === null || _c === void 0 ? void 0 : _c.getType();

package/build/src/abap/abap_parser.js

@@ -8,9 +8,10 @@ const structure_parser_1 = require("./3_structures/structure_parser");
 const abap_file_information_1 = require("./4_file_information/abap_file_information");
 const abap_file_1 = require("./abap_file");
 class ABAPParser {
-    constructor(version, globalMacros) {
+    constructor(version, globalMacros, reg) {
         this.version = version ? version : version_1.defaultVersion;
         this.globalMacros = globalMacros ? globalMacros : [];
+        this.reg = reg;
     }
     // files is input for a single object
     parse(files) {
@@ -23,7 +24,7 @@ class ABAPParser {
         const lexingRuntime = Date.now() - b1;
         // 2: statements
         const b2 = Date.now();
-        const statementResult = new statement_parser_1.StatementParser(this.version).run(lexerResult, this.globalMacros);
+        const statementResult = new statement_parser_1.StatementParser(this.version, this.reg).run(lexerResult, this.globalMacros);
         const statementsRuntime = Date.now() - b2;
         // 3: structures
         const b3 = Date.now();

package/build/src/abap/types/class_definition.js

@@ -35,11 +35,11 @@ class ClassDefinition extends _identifier_1.Identifier {
         helper.addAliasedTypes(this.aliases);
         this.attributes = new class_attributes_1.Attributes(this.node, this.filename, scope);
         this.types = this.attributes.getTypes();
-        this.methodDefs = new method_definitions_1.MethodDefinitions(this.node, this.filename, scope);
         const events = this.node.findAllStatements(Statements.Events);
         for (const e of events) {
             this.events.push(new event_definition_1.EventDefinition(e, visibility_1.Visibility.Public, this.filename, scope)); // todo, all these are not Public
         }
+        this.methodDefs = new method_definitions_1.MethodDefinitions(this.node, this.filename, scope);
         scope.pop(node.getLastToken().getEnd());
         const concat = this.node.findFirstStatement(Statements.ClassDefinition).concatTokens().toUpperCase();
         this.testing = concat.includes(" FOR TESTING");

package/build/src/objects/_abap_object.js

@@ -13,12 +13,12 @@ class ABAPObject extends _abstract_object_1.AbstractObject {
     static is(x) {
         return !!x && x instanceof ABAPObject;
     }
-    parse(version, globalMacros) {
+    parse(version, globalMacros, reg) {
         if (this.isDirty() === false) {
             return { updated: false, runtime: 0 };
         }
         const abapFiles = this.getFiles().filter(f => f.getFilename().endsWith(".abap"));
-        const result = new abap_parser_1.ABAPParser(version, globalMacros).parse(abapFiles);
+        const result = new abap_parser_1.ABAPParser(version, globalMacros, reg).parse(abapFiles);
         this.parsed = result.output;
         this.old = result.issues;
         this.dirty = false;

package/build/src/objects/_abstract_object.js

@@ -15,7 +15,7 @@ class AbstractObject {
     getParsingIssues() {
         return this.old;
     }
-    parse(_version, _globalMacros) {
+    parse(_version, _globalMacros, _reg) {
         return { updated: false, runtime: 0 };
     }
     getName() {

package/build/src/objects/table.js

@@ -93,10 +93,8 @@ class Table extends _abstract_object_1.AbstractObject {
                     if (field.GROUPNAME !== undefined) {
                         components.push({ name: field.GROUPNAME, type: found });
                     }
-                    else {
-                        for (const c of found.getComponents()) {
-                            components.push({ name: c.name, type: c.type });
-                        }
+                    for (const c of found.getComponents()) {
+                        components.push({ name: c.name, type: c.type });
                     }
                 }
                 else if ((((_a = field.PRECFIELD) === null || _a === void 0 ? void 0 : _a.startsWith("CI_")) || ((_b = field.PRECFIELD) === null || _b === void 0 ? void 0 : _b.startsWith("SI_")))

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.84.12";
+        return "2.85.3";
     }
     getDDICReferences() {
         return this.references;
@@ -259,7 +259,7 @@ class Registry {
     // todo, refactor, this is a mess, see where-used, a lot of the code should be in this method instead
     parsePrivate(input) {
         const config = this.getConfig();
-        const result = input.parse(config.getVersion(), config.getSyntaxSetttings().globalMacros);
+        const result = input.parse(config.getVersion(), config.getSyntaxSetttings().globalMacros, this);
         ParsingPerformance.push(input, result);
     }
     isDirty() {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.84.12",
+    "version": "2.85.3",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",