@abaplint/core 2.83.25 → 2.84.0

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.83.25";
+        return "2.84.0";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/downport.js

@@ -365,10 +365,14 @@ ${indentation}`);
         }
         const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
         const name = ((_c = inlineData.findFirstExpression(Expressions.TargetField)) === null || _c === void 0 ? void 0 : _c.concatTokens()) || "error";
-        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `TYPES: BEGIN OF ${uniqueName},
+        let fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `TYPES: BEGIN OF ${uniqueName},
 ${fieldDefinitions}${indentation}      END OF ${uniqueName}.
 ${indentation}DATA ${name} TYPE STANDARD TABLE OF ${uniqueName} WITH DEFAULT KEY.
 ${indentation}`);
+        if (fieldDefinitions === "") {
+            fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `DATA ${name} TYPE STANDARD TABLE OF ${tableName} WITH DEFAULT KEY.
+${indentation}`);
+        }
         const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, inlineData.getFirstToken().getStart(), inlineData.getLastToken().getEnd(), name);
         const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
         return issue_1.Issue.atToken(lowFile, inlineData.getFirstToken(), "Outline SELECT @DATA", this.getMetadata().key, this.conf.severity, fix);

package/build/src/rules/index.js

@@ -100,6 +100,7 @@ __exportStar(require("./no_yoda_conditions"), exports);
 __exportStar(require("./object_naming"), exports);
 __exportStar(require("./obsolete_statement"), exports);
 __exportStar(require("./omit_parameter_name"), exports);
+__exportStar(require("./omit_preceding_zeros"), exports);
 __exportStar(require("./omit_receiving"), exports);
 __exportStar(require("./parser_702_chaining"), exports);
 __exportStar(require("./parser_error"), exports);

package/build/src/rules/method_length.js

@@ -38,13 +38,13 @@ class MethodLength {
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };
     }
-    getDescription(issueType, actual) {
+    getDescription(issueType, actual, type) {
         switch (issueType) {
             case IssueType.EmptyMethod: {
-                return "Empty method/form";
+                return "Empty " + type;
             }
             case IssueType.MaxStatements: {
-                return "Reduce method/form length to max " + this.conf.statements + " statements, currently " + actual;
+                return "Reduce " + type + " length to max " + this.conf.statements + " statements, currently " + actual;
             }
             default: {
                 return "";
@@ -62,15 +62,16 @@ class MethodLength {
     }
     run(obj) {
         const methodStats = method_length_stats_1.MethodLengthStats.run(obj);
-        const methodIssues = this.check(methodStats);
+        const methodIssues = this.check(methodStats, "METHOD");
         let formIssues = [];
         if (this.conf.checkForms) {
             const formStats = form_length_stats_1.FormLengthStats.run(obj);
-            formIssues = this.check(formStats);
+            formIssues = this.check(formStats, "FORM");
         }
         return methodIssues.concat(formIssues);
     }
-    check(stats) {
+    // ***********************
+    check(stats, type) {
         const issues = [];
         for (const s of stats) {
             if ((this.conf.ignoreTestClasses === true)
@@ -78,12 +79,12 @@ class MethodLength {
                 continue;
             }
             if (s.count === 0 && this.conf.errorWhenEmpty === true) {
-                const issue = issue_1.Issue.atPosition(s.file, s.pos, this.getDescription(IssueType.EmptyMethod, "0"), this.getMetadata().key, this.conf.severity);
+                const issue = issue_1.Issue.atPosition(s.file, s.pos, this.getDescription(IssueType.EmptyMethod, "0", type), this.getMetadata().key, this.conf.severity);
                 issues.push(issue);
                 continue;
             }
             if (s.count > this.conf.statements) {
-                const message = this.getDescription(IssueType.MaxStatements, s.count.toString());
+                const message = this.getDescription(IssueType.MaxStatements, s.count.toString(), type);
                 const issue = issue_1.Issue.atPosition(s.file, s.pos, message, this.getMetadata().key, this.conf.severity);
                 issues.push(issue);
             }

package/build/src/rules/omit_preceding_zeros.js

@@ -0,0 +1,47 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.OmitPrecedingZeros = exports.OmitPrecedingZerosConf = void 0;
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const issue_1 = require("../issue");
+const Expressions = require("../abap/2_statements/expressions");
+const _irule_1 = require("./_irule");
+class OmitPrecedingZerosConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.OmitPrecedingZerosConf = OmitPrecedingZerosConf;
+class OmitPrecedingZeros extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new OmitPrecedingZerosConf();
+    }
+    getMetadata() {
+        return {
+            key: "omit_preceding_zeros",
+            title: "Omit preceding zeros",
+            shortDescription: `Omit preceding zeros from integer constants`,
+            tags: [_irule_1.RuleTag.SingleFile],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        var _a;
+        const issues = [];
+        for (const i of ((_a = file.getStructure()) === null || _a === void 0 ? void 0 : _a.findAllExpressions(Expressions.Integer)) || []) {
+            const token = i.getLastToken();
+            const str = token.getStr();
+            if (str.length > 1 && str.startsWith("0")) {
+                const message = "Omit preceding zeros";
+                const issue = issue_1.Issue.atToken(file, token, message, this.getMetadata().key, this.getConfig().severity);
+                issues.push(issue);
+            }
+        }
+        return issues;
+    }
+}
+exports.OmitPrecedingZeros = OmitPrecedingZeros;
+//# sourceMappingURL=omit_preceding_zeros.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.83.25",
+    "version": "2.84.0",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",