@abaplint/core 2.83.17 → 2.83.21

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.83.17";
+        return "2.83.21";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/align_parameters.js

@@ -190,6 +190,18 @@ foo = VALUE #(
                     right: children[2],
                 });
             }
+            const ex = raise.findDirectExpression(Expressions.ParameterListExceptions);
+            for (const e of (ex === null || ex === void 0 ? void 0 : ex.getChildren()) || []) {
+                const children = e.getChildren();
+                if (children.length < 3) {
+                    continue; // unexpected
+                }
+                parameters.push({
+                    left: children[0],
+                    eq: children[1].getFirstToken().getStart(),
+                    right: children[2],
+                });
+            }
             if (parameters.length > 0) {
                 candidates.push({ parameters });
             }

package/build/src/rules/definitions_top.js

@@ -47,10 +47,10 @@ class DefinitionsTop extends _abap_rule_1.ABAPRule {
         if (structure === undefined) {
             return [];
         }
-        // one fix per file
-        this.fixed = false;
         const routines = structure.findAllStructures(Structures.Form).concat(structure.findAllStructures(Structures.Method));
         for (const r of routines) {
+            // one fix per routine
+            this.fixed = false;
             this.mode = DEFINITION;
             this.moveTo = r.getFirstStatement();
             const found = this.walk(r, file);
@@ -89,7 +89,7 @@ class DefinitionsTop extends _abap_rule_1.ABAPRule {
                     || c.get() instanceof Statements.Static
                     || c.get() instanceof Statements.FieldSymbol)) {
                 if (this.mode === AFTER) {
-                    // only one fix per file, as it reorders a lot
+                    // only one fix per routine, as it reorders a lot
                     let fix = undefined;
                     if (this.fixed === false && this.moveTo) {
                         fix = this.buildFix(file, c, this.moveTo);

package/build/src/rules/downport.js

@@ -55,6 +55,7 @@ Current rules:
 * SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
 * PARTIALLY IMPLEMENTED removed, it can be quick fixed via rule implement_methods
 * RAISE EXCEPTION ... MESSAGE
+* APPEND expression is outlined
 
 Only one transformation is applied to a statement at a time, so multiple steps might be required to do the full downport.`,
             tags: [_irule_1.RuleTag.Experimental, _irule_1.RuleTag.Downport, _irule_1.RuleTag.Quickfix],
@@ -223,6 +224,10 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         if (found) {
             return found;
         }
+        found = this.replaceAppendExpression(high, lowFile, highSyntax);
+        if (found) {
+            return found;
+        }
         // todo, add more rules here
         return undefined;
     }
@@ -364,6 +369,28 @@ ${indentation}`);
         const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
         return issue_1.Issue.atToken(lowFile, inlineData.getFirstToken(), "Outline SELECT @DATA", this.getMetadata().key, this.conf.severity, fix);
     }
+    replaceAppendExpression(high, lowFile, highSyntax) {
+        if (!(high.get() instanceof Statements.Append)) {
+            return undefined;
+        }
+        const children = high.getChildren();
+        if (children[1].get() instanceof Expressions.Source) {
+            const source = children[1];
+            const target = high.findDirectExpression(Expressions.Target);
+            if (target === undefined) {
+                return undefined;
+            }
+            const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+            const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
+            const firstToken = high.getFirstToken();
+            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${target === null || target === void 0 ? void 0 : target.concatTokens()}.
+${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
+            const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, source.getFirstToken().getStart(), source.getLastToken().getEnd(), uniqueName);
+            const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
+            return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Outline APPEND source expression", this.getMetadata().key, this.conf.severity, fix);
+        }
+        return undefined;
+    }
     replaceTableExpression(node, lowFile, highSyntax) {
         var _a;
         for (const fieldChain of node.findAllExpressionsRecursive(Expressions.FieldChain)) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.83.17",
+    "version": "2.83.21",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -48,7 +48,7 @@
         "@microsoft/api-extractor": "^7.19.3",
         "@types/chai": "^4.3.0",
         "@types/mocha": "^9.0.0",
-        "@types/node": "^17.0.5",
+        "@types/node": "^17.0.8",
         "chai": "^4.3.4",
         "eslint": "^8.6.0",
         "mocha": "^9.1.3",