@abaplint/core 2.83.13 → 2.83.17

package/build/abaplint.d.ts

@@ -1857,6 +1857,7 @@ declare namespace Expressions {
         MethodDefImporting,
         MethodDefRaising,
         MethodDefReturning,
+        MethodDefExceptions,
         MethodName,
         MethodParamName,
         MethodParamOptional,
@@ -1880,6 +1881,7 @@ declare namespace Expressions {
         PerformTables,
         PerformUsing,
         RadioGroupName,
+        RaiseWith,
         ReadTableTarget,
         ReceiveParameters,
         Redefinition,
@@ -2776,6 +2778,7 @@ export declare interface IMethodDefinition extends Identifier {
     isEventHandler(): boolean;
     getParameters(): IMethodParameters;
     getRaising(): readonly string[];
+    getExceptions(): readonly string[];
 }
 
 declare interface IMethodDefinitions {
@@ -3586,6 +3589,10 @@ declare class MethodDefChanging extends Expression {
     getRunnable(): IStatementRunnable;
 }
 
+declare class MethodDefExceptions extends Expression {
+    getRunnable(): IStatementRunnable;
+}
+
 declare class MethodDefExporting extends Expression {
     getRunnable(): IStatementRunnable;
 }
@@ -3602,6 +3609,7 @@ declare class MethodDefinition extends Identifier implements IMethodDefinition {
     private readonly abstract;
     private readonly static;
     private readonly raising;
+    private readonly exceptions;
     constructor(node: StatementNode, visibility: Visibility, filename: string, scope: CurrentScope);
     getVisibility(): Visibility;
     isRedefinition(): boolean;
@@ -3610,6 +3618,7 @@ declare class MethodDefinition extends Identifier implements IMethodDefinition {
     isEventHandler(): boolean;
     getParameters(): MethodParameters_2;
     getRaising(): readonly string[];
+    getExceptions(): readonly string[];
 }
 
 declare class MethodDefinitions implements IMethodDefinitions {
@@ -4256,6 +4265,10 @@ declare class RaiseEvent implements IStatement {
     getMatcher(): IStatementRunnable;
 }
 
+declare class RaiseWith extends Expression {
+    getRunnable(): IStatementRunnable;
+}
+
 declare class Ranges implements IStatement {
     getMatcher(): IStatementRunnable;
 }

package/build/src/abap/2_statements/expressions/index.js

@@ -105,6 +105,7 @@ __exportStar(require("./method_def_exporting"), exports);
 __exportStar(require("./method_def_importing"), exports);
 __exportStar(require("./method_def_raising"), exports);
 __exportStar(require("./method_def_returning"), exports);
+__exportStar(require("./method_def_exceptions"), exports);
 __exportStar(require("./method_name"), exports);
 __exportStar(require("./method_param_name"), exports);
 __exportStar(require("./method_param_optional"), exports);
@@ -128,6 +129,7 @@ __exportStar(require("./perform_changing"), exports);
 __exportStar(require("./perform_tables"), exports);
 __exportStar(require("./perform_using"), exports);
 __exportStar(require("./radio_group_name"), exports);
+__exportStar(require("./raise_with"), exports);
 __exportStar(require("./read_table_target"), exports);
 __exportStar(require("./receive_parameters"), exports);
 __exportStar(require("./redefinition"), exports);

package/build/src/abap/2_statements/expressions/method_def_exceptions.js

@@ -0,0 +1,13 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.MethodDefExceptions = void 0;
+const combi_1 = require("../combi");
+const _1 = require(".");
+class MethodDefExceptions extends combi_1.Expression {
+    getRunnable() {
+        const exceptions = (0, combi_1.seq)("EXCEPTIONS", (0, combi_1.plusPrio)(_1.NamespaceSimpleName));
+        return exceptions;
+    }
+}
+exports.MethodDefExceptions = MethodDefExceptions;
+//# sourceMappingURL=method_def_exceptions.js.map

package/build/src/abap/2_statements/expressions/raise_with.js

@@ -0,0 +1,13 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RaiseWith = void 0;
+const combi_1 = require("../combi");
+const _1 = require(".");
+class RaiseWith extends combi_1.Expression {
+    getRunnable() {
+        const wit = (0, combi_1.seq)("WITH", _1.Source, (0, combi_1.opt)(_1.Source), (0, combi_1.opt)(_1.Source), (0, combi_1.opt)(_1.Source));
+        return wit;
+    }
+}
+exports.RaiseWith = RaiseWith;
+//# sourceMappingURL=raise_with.js.map

package/build/src/abap/2_statements/statements/method_def.js

@@ -6,10 +6,9 @@ const combi_1 = require("../combi");
 const expressions_1 = require("../expressions");
 class MethodDef {
     getMatcher() {
-        const exceptions = (0, combi_1.seq)("EXCEPTIONS", (0, combi_1.plusPrio)(expressions_1.NamespaceSimpleName));
         const def = (0, combi_1.ver)(version_1.Version.v740sp08, (0, combi_1.seq)("DEFAULT", (0, combi_1.altPrio)("FAIL", "IGNORE")));
-        const parameters = (0, combi_1.seq)((0, combi_1.optPrio)((0, combi_1.altPrio)("FINAL", def, expressions_1.Abstract)), (0, combi_1.optPrio)(expressions_1.MethodDefImporting), (0, combi_1.optPrio)(expressions_1.MethodDefExporting), (0, combi_1.optPrio)(expressions_1.MethodDefChanging), (0, combi_1.optPrio)(expressions_1.MethodDefReturning), (0, combi_1.optPrio)((0, combi_1.altPrio)(expressions_1.MethodDefRaising, exceptions)));
-        const testing = (0, combi_1.seq)((0, combi_1.optPrio)(expressions_1.Abstract), "FOR TESTING", (0, combi_1.optPrio)((0, combi_1.altPrio)(expressions_1.MethodDefRaising, exceptions)));
+        const parameters = (0, combi_1.seq)((0, combi_1.optPrio)((0, combi_1.altPrio)("FINAL", def, expressions_1.Abstract)), (0, combi_1.optPrio)(expressions_1.MethodDefImporting), (0, combi_1.optPrio)(expressions_1.MethodDefExporting), (0, combi_1.optPrio)(expressions_1.MethodDefChanging), (0, combi_1.optPrio)(expressions_1.MethodDefReturning), (0, combi_1.optPrio)((0, combi_1.altPrio)(expressions_1.MethodDefRaising, expressions_1.MethodDefExceptions)));
+        const testing = (0, combi_1.seq)((0, combi_1.optPrio)(expressions_1.Abstract), "FOR TESTING", (0, combi_1.optPrio)((0, combi_1.altPrio)(expressions_1.MethodDefRaising, expressions_1.MethodDefExceptions)));
         // todo, this is only from version something
         const tableFunction = (0, combi_1.seq)("FOR TABLE FUNCTION", (0, combi_1.regex)(/^\w+?$/));
         // todo, this is only from version something

package/build/src/abap/2_statements/statements/raise.js

@@ -6,9 +6,8 @@ const version_1 = require("../../../version");
 const expressions_1 = require("../expressions");
 class Raise {
     getMatcher() {
-        const wit = (0, combi_1.seq)("WITH", expressions_1.Source, (0, combi_1.opt)(expressions_1.Source), (0, combi_1.opt)(expressions_1.Source), (0, combi_1.opt)(expressions_1.Source));
-        const mess = (0, combi_1.seq)("MESSAGE", expressions_1.MessageSource, (0, combi_1.opt)(wit));
-        const messid = (0, combi_1.seq)("MESSAGE ID", expressions_1.Source, "NUMBER", expressions_1.Source, (0, combi_1.optPrio)(wit));
+        const mess = (0, combi_1.seq)("MESSAGE", expressions_1.MessageSource, (0, combi_1.opt)(expressions_1.RaiseWith));
+        const messid = (0, combi_1.seq)("MESSAGE ID", expressions_1.Source, "NUMBER", expressions_1.Source, (0, combi_1.optPrio)(expressions_1.RaiseWith));
         const exporting = (0, combi_1.seq)("EXPORTING", expressions_1.ParameterListS);
         const from = (0, combi_1.seq)("TYPE", expressions_1.ClassName, (0, combi_1.opt)((0, combi_1.alt)((0, combi_1.ver)(version_1.Version.v750, (0, combi_1.alt)(mess, messid)), (0, combi_1.ver)(version_1.Version.v752, "USING MESSAGE"))), (0, combi_1.optPrio)(exporting));
         const clas = (0, combi_1.seq)((0, combi_1.optPrio)("RESUMABLE"), "EXCEPTION", (0, combi_1.altPrio)(from, (0, combi_1.ver)(version_1.Version.v752, expressions_1.Source), expressions_1.SimpleSource2));

package/build/src/abap/2_statements/statements/selectoption.js

@@ -9,7 +9,7 @@ class SelectOption {
         const sourc = (0, combi_1.alt)(expressions_1.Constant, expressions_1.FieldChain);
         const to = (0, combi_1.seq)("TO", sourc);
         const def = (0, combi_1.seq)("DEFAULT", sourc, (0, combi_1.opt)(to));
-        const option = (0, combi_1.seq)("OPTION", expressions_1.Field);
+        const option = (0, combi_1.seq)("OPTION", (0, combi_1.alt)("CP", expressions_1.Field));
         const sign = (0, combi_1.seq)("SIGN", expressions_1.Field);
         const memory = (0, combi_1.seq)("MEMORY ID", expressions_1.SimpleSource1);
         const match = (0, combi_1.seq)("MATCHCODE OBJECT", expressions_1.Field);

package/build/src/abap/types/method_definition.js

@@ -9,7 +9,7 @@ const _reference_1 = require("../5_syntax/_reference");
 class MethodDefinition extends _identifier_1.Identifier {
     // todo: final flag
     constructor(node, visibility, filename, scope) {
-        var _a;
+        var _a, _b;
         if (!(node.get() instanceof statements_1.MethodDef)) {
             throw new Error("MethodDefinition, expected MethodDef as part of input node");
         }
@@ -58,6 +58,12 @@ class MethodDefinition extends _identifier_1.Identifier {
                 scope.addReference(token, clas, _reference_1.ReferenceType.ObjectOrientedUnknownReference, filename, { ooName: name.toUpperCase(), ooType: "CLAS" });
             }
         }
+        this.exceptions = [];
+        for (const r of ((_b = node.findDirectExpression(Expressions.MethodDefExceptions)) === null || _b === void 0 ? void 0 : _b.findAllExpressions(Expressions.NamespaceSimpleName)) || []) {
+            const token = r.getFirstToken();
+            const name = token.getStr();
+            this.exceptions.push(name);
+        }
         this.visibility = visibility;
         this.parameters = new method_parameters_1.MethodParameters(node, this.filename, scope);
     }
@@ -82,6 +88,9 @@ class MethodDefinition extends _identifier_1.Identifier {
     getRaising() {
         return this.raising;
     }
+    getExceptions() {
+        return this.exceptions;
+    }
 }
 exports.MethodDefinition = MethodDefinition;
 //# sourceMappingURL=method_definition.js.map

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.83.13";
+        return "2.83.17";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/downport.js

@@ -19,7 +19,8 @@ const _typed_identifier_1 = require("../abap/types/_typed_identifier");
 const basic_1 = require("../abap/types/basic");
 const config_1 = require("../config");
 const tokens_1 = require("../abap/1_lexer/tokens");
-// todo: refactor each sub-rule to new classes
+// todo: refactor each sub-rule to new classes?
+// todo: add configuration
 class DownportConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.DownportConf = DownportConf;
@@ -52,6 +53,8 @@ Current rules:
 * SELECT INTO @DATA definitions are outlined
 * Some occurrences of string template formatting option ALPHA changed to function module call
 * SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
+* PARTIALLY IMPLEMENTED removed, it can be quick fixed via rule implement_methods
+* RAISE EXCEPTION ... MESSAGE
 
 Only one transformation is applied to a statement at a time, so multiple steps might be required to do the full downport.`,
             tags: [_irule_1.RuleTag.Experimental, _irule_1.RuleTag.Downport, _irule_1.RuleTag.Quickfix],
@@ -143,7 +146,15 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         if (low.getFirstToken().getStart() instanceof position_1.VirtualPosition) {
             return undefined;
         }
-        let found = this.emptyKey(high, lowFile);
+        let found = this.partiallyImplemented(high, lowFile);
+        if (found) {
+            return found;
+        }
+        found = this.raiseException(high, lowFile, highSyntax);
+        if (found) {
+            return found;
+        }
+        found = this.emptyKey(high, lowFile);
         if (found) {
             return found;
         }
@@ -428,6 +439,65 @@ ${indentation}`);
         const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
         return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Outline DATA", this.getMetadata().key, this.conf.severity, fix);
     }
+    partiallyImplemented(node, lowFile) {
+        if (node.get() instanceof Statements.InterfaceDef) {
+            const partially = node.findDirectTokenByText("PARTIALLY");
+            if (partially === undefined) {
+                return undefined;
+            }
+            const implemented = node.findDirectTokenByText("IMPLEMENTED");
+            if (implemented === undefined) {
+                return undefined;
+            }
+            const fix = edit_helper_1.EditHelper.deleteRange(lowFile, partially.getStart(), implemented.getEnd());
+            return issue_1.Issue.atToken(lowFile, partially, "Downport PARTIALLY IMPLEMENTED", this.getMetadata().key, this.conf.severity, fix);
+        }
+        return undefined;
+    }
+    raiseException(node, lowFile, highSyntax) {
+        /*
+        Note: IF_T100_DYN_MSG does not exist in 702, so this rule is mostly relevant for the transpiler
+    
+        DATA foo LIKE if_t100_message=>t100key.
+        foo-msgid = 'ZHVAM'.
+        foo-msgno = '001'.
+        foo-attr1 = 'IF_T100_DYN_MSG~MSGV1'.
+        foo-attr2 = 'IF_T100_DYN_MSG~MSGV2'.
+        foo-attr3 = 'IF_T100_DYN_MSG~MSGV3'.
+        foo-attr4 = 'IF_T100_DYN_MSG~MSGV4'.
+        DATA bar TYPE REF TO zcl_hvam_exception.
+        CREATE OBJECT bar EXPORTING textid = foo.
+        bar->if_t100_dyn_msg~msgty = 'E'.
+        bar->if_t100_dyn_msg~msgv1 = 'abc'.
+        bar->if_t100_dyn_msg~msgv2 = 'abc'.
+        bar->if_t100_dyn_msg~msgv3 = 'abc'.
+        bar->if_t100_dyn_msg~msgv4 = 'abc'.
+        RAISE EXCEPTION bar.
+        */
+        var _a;
+        if (node.get() instanceof Statements.Raise) {
+            const startToken = node.findDirectTokenByText("ID");
+            if (startToken === undefined) {
+                return undefined;
+            }
+            const sources = node.findDirectExpressions(Expressions.Source);
+            const id = sources[0].concatTokens();
+            const number = sources[1].concatTokens();
+            const className = ((_a = node.findDirectExpression(Expressions.ClassName)) === null || _a === void 0 ? void 0 : _a.concatTokens()) || "ERROR";
+            const uniqueName1 = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+            const uniqueName2 = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+            const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
+            const abap = `DATA ${uniqueName1} LIKE if_t100_message=>t100key.
+${indentation}${uniqueName1}-msgid = ${id}.
+${indentation}${uniqueName1}-msgno = ${number}.
+${indentation}DATA ${uniqueName2} TYPE REF TO ${className}.
+${indentation}CREATE OBJECT ${uniqueName2} EXPORTING textid = ${uniqueName1}.
+${indentation}RAISE EXCEPTION ${uniqueName2}.`;
+            const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getStart(), node.getEnd(), abap);
+            return issue_1.Issue.atToken(lowFile, startToken, "Downport RAISE MESSAGE", this.getMetadata().key, this.conf.severity, fix);
+        }
+        return undefined;
+    }
     emptyKey(node, lowFile) {
         for (let i of node.findAllExpressions(Expressions.TypeTable)) {
             const key = i.findDirectExpression(Expressions.TypeTableKey);

package/build/src/rules/unnecessary_chaining.js

@@ -58,7 +58,7 @@ class UnnecessaryChaining extends _abap_rule_1.ABAPRule {
             }
             const fix = edit_helper_1.EditHelper.deleteRange(file, colon.getStart(), colon.getEnd());
             const message = "Unnecessary chaining";
-            const issue = issue_1.Issue.atStatement(file, statements[i], message, this.getMetadata().key, this.conf.severity, fix);
+            const issue = issue_1.Issue.atToken(file, colon, message, this.getMetadata().key, this.conf.severity, fix);
             issues.push(issue);
         }
         return issues;

package/build/src/rules/use_class_based_exceptions.js

@@ -5,6 +5,7 @@ const _basic_rule_config_1 = require("./_basic_rule_config");
 const _abap_rule_1 = require("./_abap_rule");
 const _irule_1 = require("./_irule");
 const Statements = require("../abap/2_statements/statements");
+const Expressions = require("../abap/2_statements/expressions");
 const issue_1 = require("../issue");
 class UseClassBasedExceptionsConf extends _basic_rule_config_1.BasicRuleConfig {
 }
@@ -36,7 +37,7 @@ class UseClassBasedExceptions extends _abap_rule_1.ABAPRule {
         var _a;
         const issues = [];
         for (const s of ((_a = file.getStructure()) === null || _a === void 0 ? void 0 : _a.findAllStatements(Statements.MethodDef)) || []) {
-            if (s.findDirectTokenByText("EXCEPTIONS")) {
+            if (s.findDirectExpression(Expressions.MethodDefExceptions)) {
                 issues.push(issue_1.Issue.atStatement(file, s, this.getMessage(), this.getMetadata().key));
             }
         }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.83.13",
+    "version": "2.83.17",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -50,9 +50,9 @@
         "@types/mocha": "^9.0.0",
         "@types/node": "^17.0.5",
         "chai": "^4.3.4",
-        "eslint": "^8.5.0",
+        "eslint": "^8.6.0",
         "mocha": "^9.1.3",
-        "c8": "^7.10.0",
+        "c8": "^7.11.0",
         "source-map-support": "^0.5.21",
         "ts-json-schema-generator": "^0.97.0",
         "typescript": "^4.5.4"