@abaplint/core 2.83.13 → 2.83.14

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.83.13";
+        return "2.83.14";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/downport.js

@@ -19,7 +19,7 @@ const _typed_identifier_1 = require("../abap/types/_typed_identifier");
 const basic_1 = require("../abap/types/basic");
 const config_1 = require("../config");
 const tokens_1 = require("../abap/1_lexer/tokens");
-// todo: refactor each sub-rule to new classes
+// todo: refactor each sub-rule to new classes?
 class DownportConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.DownportConf = DownportConf;
@@ -52,6 +52,7 @@ Current rules:
 * SELECT INTO @DATA definitions are outlined
 * Some occurrences of string template formatting option ALPHA changed to function module call
 * SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
+* PARTIALLY IMPLEMENTED removed, it can be quick fixed via rule implement_methods
 
 Only one transformation is applied to a statement at a time, so multiple steps might be required to do the full downport.`,
             tags: [_irule_1.RuleTag.Experimental, _irule_1.RuleTag.Downport, _irule_1.RuleTag.Quickfix],
@@ -143,7 +144,11 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         if (low.getFirstToken().getStart() instanceof position_1.VirtualPosition) {
             return undefined;
         }
-        let found = this.emptyKey(high, lowFile);
+        let found = this.partiallyImplemented(high, lowFile);
+        if (found) {
+            return found;
+        }
+        found = this.emptyKey(high, lowFile);
         if (found) {
             return found;
         }
@@ -428,6 +433,21 @@ ${indentation}`);
         const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
         return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Outline DATA", this.getMetadata().key, this.conf.severity, fix);
     }
+    partiallyImplemented(node, lowFile) {
+        if (node.get() instanceof Statements.InterfaceDef) {
+            const partially = node.findDirectTokenByText("PARTIALLY");
+            if (partially === undefined) {
+                return undefined;
+            }
+            const implemented = node.findDirectTokenByText("IMPLEMENTED");
+            if (implemented === undefined) {
+                return undefined;
+            }
+            const fix = edit_helper_1.EditHelper.deleteRange(lowFile, partially.getStart(), implemented.getEnd());
+            return issue_1.Issue.atToken(lowFile, partially, "Downport PARTIALLY IMPLEMENTED", this.getMetadata().key, this.conf.severity, fix);
+        }
+        return undefined;
+    }
     emptyKey(node, lowFile) {
         for (let i of node.findAllExpressions(Expressions.TypeTable)) {
             const key = i.findDirectExpression(Expressions.TypeTableKey);

package/build/src/rules/unnecessary_chaining.js

@@ -58,7 +58,7 @@ class UnnecessaryChaining extends _abap_rule_1.ABAPRule {
             }
             const fix = edit_helper_1.EditHelper.deleteRange(file, colon.getStart(), colon.getEnd());
             const message = "Unnecessary chaining";
-            const issue = issue_1.Issue.atStatement(file, statements[i], message, this.getMetadata().key, this.conf.severity, fix);
+            const issue = issue_1.Issue.atToken(file, colon, message, this.getMetadata().key, this.conf.severity, fix);
             issues.push(issue);
         }
         return issues;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.83.13",
+    "version": "2.83.14",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -52,7 +52,7 @@
         "chai": "^4.3.4",
         "eslint": "^8.5.0",
         "mocha": "^9.1.3",
-        "c8": "^7.10.0",
+        "c8": "^7.11.0",
         "source-map-support": "^0.5.21",
         "ts-json-schema-generator": "^0.97.0",
         "typescript": "^4.5.4"