@abaplint/core 2.83.11 → 2.83.15

package/build/abaplint.d.ts

@@ -1242,6 +1242,7 @@ declare class DataDefinition extends AbstractObject {
         allowNamespace: boolean;
     };
     getSQLViewName(): string | undefined;
+    getDefinitionName(): string | undefined;
     getDescription(): string | undefined;
     parseType(reg: IRegistry): AbstractType;
     getParsedData(): ParsedDataDefinition | undefined;
@@ -1879,6 +1880,7 @@ declare namespace Expressions {
         PerformTables,
         PerformUsing,
         RadioGroupName,
+        RaiseWith,
         ReadTableTarget,
         ReceiveParameters,
         Redefinition,
@@ -4079,6 +4081,7 @@ declare class ParenRightW extends Token {
 
 declare type ParsedDataDefinition = {
     sqlViewName: string | undefined;
+    definitionName: string | undefined;
     fields: {
         key: boolean;
         name: string;
@@ -4254,6 +4257,10 @@ declare class RaiseEvent implements IStatement {
     getMatcher(): IStatementRunnable;
 }
 
+declare class RaiseWith extends Expression {
+    getRunnable(): IStatementRunnable;
+}
+
 declare class Ranges implements IStatement {
     getMatcher(): IStatementRunnable;
 }

package/build/src/abap/2_statements/expressions/index.js

@@ -128,6 +128,7 @@ __exportStar(require("./perform_changing"), exports);
 __exportStar(require("./perform_tables"), exports);
 __exportStar(require("./perform_using"), exports);
 __exportStar(require("./radio_group_name"), exports);
+__exportStar(require("./raise_with"), exports);
 __exportStar(require("./read_table_target"), exports);
 __exportStar(require("./receive_parameters"), exports);
 __exportStar(require("./redefinition"), exports);

package/build/src/abap/2_statements/expressions/raise_with.js

@@ -0,0 +1,13 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RaiseWith = void 0;
+const combi_1 = require("../combi");
+const _1 = require(".");
+class RaiseWith extends combi_1.Expression {
+    getRunnable() {
+        const wit = (0, combi_1.seq)("WITH", _1.Source, (0, combi_1.opt)(_1.Source), (0, combi_1.opt)(_1.Source), (0, combi_1.opt)(_1.Source));
+        return wit;
+    }
+}
+exports.RaiseWith = RaiseWith;
+//# sourceMappingURL=raise_with.js.map

package/build/src/abap/2_statements/statements/raise.js

@@ -6,9 +6,8 @@ const version_1 = require("../../../version");
 const expressions_1 = require("../expressions");
 class Raise {
     getMatcher() {
-        const wit = (0, combi_1.seq)("WITH", expressions_1.Source, (0, combi_1.opt)(expressions_1.Source), (0, combi_1.opt)(expressions_1.Source), (0, combi_1.opt)(expressions_1.Source));
-        const mess = (0, combi_1.seq)("MESSAGE", expressions_1.MessageSource, (0, combi_1.opt)(wit));
-        const messid = (0, combi_1.seq)("MESSAGE ID", expressions_1.Source, "NUMBER", expressions_1.Source, (0, combi_1.optPrio)(wit));
+        const mess = (0, combi_1.seq)("MESSAGE", expressions_1.MessageSource, (0, combi_1.opt)(expressions_1.RaiseWith));
+        const messid = (0, combi_1.seq)("MESSAGE ID", expressions_1.Source, "NUMBER", expressions_1.Source, (0, combi_1.optPrio)(expressions_1.RaiseWith));
         const exporting = (0, combi_1.seq)("EXPORTING", expressions_1.ParameterListS);
         const from = (0, combi_1.seq)("TYPE", expressions_1.ClassName, (0, combi_1.opt)((0, combi_1.alt)((0, combi_1.ver)(version_1.Version.v750, (0, combi_1.alt)(mess, messid)), (0, combi_1.ver)(version_1.Version.v752, "USING MESSAGE"))), (0, combi_1.optPrio)(exporting));
         const clas = (0, combi_1.seq)((0, combi_1.optPrio)("RESUMABLE"), "EXCEPTION", (0, combi_1.altPrio)(from, (0, combi_1.ver)(version_1.Version.v752, expressions_1.Source), expressions_1.SimpleSource2));

package/build/src/ddic.js

@@ -143,6 +143,7 @@ class DDIC {
         }
     }
     lookupNoVoid(name) {
+        var _a;
         const foundTABL = this.reg.getObject("TABL", name);
         if (foundTABL) {
             return { type: foundTABL.parseType(this.reg), object: foundTABL };
@@ -155,10 +156,6 @@ class DDIC {
         if (foundTTYP) {
             return { type: foundTTYP.parseType(this.reg), object: foundTTYP };
         }
-        const foundDDLS = this.reg.getObject("DDLS", name);
-        if (foundDDLS) {
-            return { type: foundDDLS.parseType(this.reg), object: foundDDLS };
-        }
         const foundDTEL = this.reg.getObject("DTEL", name);
         if (foundDTEL) {
             return { type: foundDTEL.parseType(this.reg), object: foundDTEL };
@@ -166,7 +163,7 @@ class DDIC {
         const upper = name.toUpperCase();
         for (const obj of this.reg.getObjectsByType("DDLS")) {
             const ddls = obj;
-            if (ddls.getSQLViewName() === upper) {
+            if (ddls.getSQLViewName() === upper || ((_a = ddls.getDefinitionName()) === null || _a === void 0 ? void 0 : _a.toUpperCase()) === upper) {
                 return { type: ddls.parseType(this.reg), object: obj };
             }
         }
@@ -213,6 +210,7 @@ class DDIC {
         }
     }
     lookupTableOrView(name) {
+        var _a;
         if (name === undefined) {
             return { type: new Types.UnknownType("undefined, lookupTableOrView") };
         }
@@ -220,20 +218,17 @@ class DDIC {
         if (foundTABL) {
             return { type: foundTABL.parseType(this.reg), object: foundTABL };
         }
-        const foundDDLS = this.reg.getObject("DDLS", name);
-        if (foundDDLS) {
-            return { type: foundDDLS.parseType(this.reg), object: foundDDLS };
-        }
         const upper = name.toUpperCase();
         for (const obj of this.reg.getObjectsByType("DDLS")) {
             const ddls = obj;
-            if (ddls.getSQLViewName() === upper) {
+            if (ddls.getSQLViewName() === upper || ((_a = ddls.getDefinitionName()) === null || _a === void 0 ? void 0 : _a.toUpperCase()) === upper) {
                 return { type: ddls.parseType(this.reg), object: ddls };
             }
         }
         return this.lookupView(name);
     }
     lookupTableOrView2(name) {
+        var _a;
         if (name === undefined) {
             return undefined;
         }
@@ -245,14 +240,10 @@ class DDIC {
         if (foundVIEW) {
             return foundVIEW;
         }
-        const foundDDLS = this.reg.getObject("DDLS", name);
-        if (foundDDLS) {
-            return foundDDLS;
-        }
         const upper = name.toUpperCase();
         for (const obj of this.reg.getObjectsByType("DDLS")) {
             const ddls = obj;
-            if (ddls.getSQLViewName() === upper) {
+            if (ddls.getSQLViewName() === upper || ((_a = ddls.getDefinitionName()) === null || _a === void 0 ? void 0 : _a.toUpperCase()) === upper) {
                 return ddls;
             }
         }

package/build/src/objects/data_definition.js

@@ -25,6 +25,11 @@ class DataDefinition extends _abstract_object_1.AbstractObject {
         this.parse();
         return (_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.sqlViewName;
     }
+    getDefinitionName() {
+        var _a;
+        this.parse();
+        return (_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.definitionName;
+    }
     getDescription() {
         // todo
         return undefined;
@@ -53,12 +58,14 @@ class DataDefinition extends _abstract_object_1.AbstractObject {
         return this.parserError;
     }
     parse() {
+        var _a, _b;
         if (this.isDirty() === false) {
             return { updated: false, runtime: 0 };
         }
         const start = Date.now();
         this.parsedData = {
             sqlViewName: undefined,
+            definitionName: undefined,
             fields: [],
             sources: [],
             relations: [],
@@ -68,6 +75,7 @@ class DataDefinition extends _abstract_object_1.AbstractObject {
         this.findSQLViewName();
         this.parsedData.tree = new cds_parser_1.CDSParser().parse(this.findSourceFile());
         if (this.parsedData.tree) {
+            this.parsedData.definitionName = (_b = (_a = this.parsedData.tree) === null || _a === void 0 ? void 0 : _a.findFirstExpression(expressions_1.CDSName)) === null || _b === void 0 ? void 0 : _b.getFirstToken().getStr();
             this.findSourcesAndRelations(this.parsedData.tree);
             this.findFieldNames(this.parsedData.tree);
         }

package/build/src/objects/table.js

@@ -90,8 +90,13 @@ class Table extends _abstract_object_1.AbstractObject {
                     found = found.getType();
                 }
                 if (found instanceof Types.StructureType) {
-                    for (const c of found.getComponents()) {
-                        components.push({ name: c.name, type: c.type });
+                    if (field.GROUPNAME !== undefined) {
+                        components.push({ name: field.GROUPNAME, type: found });
+                    }
+                    else {
+                        for (const c of found.getComponents()) {
+                            components.push({ name: c.name, type: c.type });
+                        }
                     }
                 }
                 else if ((((_a = field.PRECFIELD) === null || _a === void 0 ? void 0 : _a.startsWith("CI_")) || ((_b = field.PRECFIELD) === null || _b === void 0 ? void 0 : _b.startsWith("SI_")))
@@ -241,6 +246,7 @@ class Table extends _abstract_object_1.AbstractObject {
                 DATATYPE: field.DATATYPE,
                 DECIMALS: field.DECIMALS,
                 KEYFLAG: field.KEYFLAG,
+                GROUPNAME: field.GROUPNAME,
             });
         }
     }

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.83.11";
+        return "2.83.15";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/downport.js

@@ -19,7 +19,8 @@ const _typed_identifier_1 = require("../abap/types/_typed_identifier");
 const basic_1 = require("../abap/types/basic");
 const config_1 = require("../config");
 const tokens_1 = require("../abap/1_lexer/tokens");
-// todo: refactor each sub-rule to new classes
+// todo: refactor each sub-rule to new classes?
+// todo: add configuration
 class DownportConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.DownportConf = DownportConf;
@@ -52,6 +53,8 @@ Current rules:
 * SELECT INTO @DATA definitions are outlined
 * Some occurrences of string template formatting option ALPHA changed to function module call
 * SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
+* PARTIALLY IMPLEMENTED removed, it can be quick fixed via rule implement_methods
+* RAISE EXCEPTION ... MESSAGE
 
 Only one transformation is applied to a statement at a time, so multiple steps might be required to do the full downport.`,
             tags: [_irule_1.RuleTag.Experimental, _irule_1.RuleTag.Downport, _irule_1.RuleTag.Quickfix],
@@ -143,7 +146,15 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         if (low.getFirstToken().getStart() instanceof position_1.VirtualPosition) {
             return undefined;
         }
-        let found = this.emptyKey(high, lowFile);
+        let found = this.partiallyImplemented(high, lowFile);
+        if (found) {
+            return found;
+        }
+        found = this.raiseException(high, lowFile, highSyntax);
+        if (found) {
+            return found;
+        }
+        found = this.emptyKey(high, lowFile);
         if (found) {
             return found;
         }
@@ -428,6 +439,65 @@ ${indentation}`);
         const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
         return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Outline DATA", this.getMetadata().key, this.conf.severity, fix);
     }
+    partiallyImplemented(node, lowFile) {
+        if (node.get() instanceof Statements.InterfaceDef) {
+            const partially = node.findDirectTokenByText("PARTIALLY");
+            if (partially === undefined) {
+                return undefined;
+            }
+            const implemented = node.findDirectTokenByText("IMPLEMENTED");
+            if (implemented === undefined) {
+                return undefined;
+            }
+            const fix = edit_helper_1.EditHelper.deleteRange(lowFile, partially.getStart(), implemented.getEnd());
+            return issue_1.Issue.atToken(lowFile, partially, "Downport PARTIALLY IMPLEMENTED", this.getMetadata().key, this.conf.severity, fix);
+        }
+        return undefined;
+    }
+    raiseException(node, lowFile, highSyntax) {
+        /*
+        Note: IF_T100_DYN_MSG does not exist in 702, so this rule is mostly relevant for the transpiler
+    
+        DATA foo LIKE if_t100_message=>t100key.
+        foo-msgid = 'ZHVAM'.
+        foo-msgno = '001'.
+        foo-attr1 = 'IF_T100_DYN_MSG~MSGV1'.
+        foo-attr2 = 'IF_T100_DYN_MSG~MSGV2'.
+        foo-attr3 = 'IF_T100_DYN_MSG~MSGV3'.
+        foo-attr4 = 'IF_T100_DYN_MSG~MSGV4'.
+        DATA bar TYPE REF TO zcl_hvam_exception.
+        CREATE OBJECT bar EXPORTING textid = foo.
+        bar->if_t100_dyn_msg~msgty = 'E'.
+        bar->if_t100_dyn_msg~msgv1 = 'abc'.
+        bar->if_t100_dyn_msg~msgv2 = 'abc'.
+        bar->if_t100_dyn_msg~msgv3 = 'abc'.
+        bar->if_t100_dyn_msg~msgv4 = 'abc'.
+        RAISE EXCEPTION bar.
+        */
+        var _a;
+        if (node.get() instanceof Statements.Raise) {
+            const startToken = node.findDirectTokenByText("ID");
+            if (startToken === undefined) {
+                return undefined;
+            }
+            const sources = node.findDirectExpressions(Expressions.Source);
+            const id = sources[0].concatTokens();
+            const number = sources[1].concatTokens();
+            const className = ((_a = node.findDirectExpression(Expressions.ClassName)) === null || _a === void 0 ? void 0 : _a.concatTokens()) || "ERROR";
+            const uniqueName1 = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+            const uniqueName2 = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+            const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
+            const abap = `DATA ${uniqueName1} LIKE if_t100_message=>t100key.
+${indentation}${uniqueName1}-msgid = ${id}.
+${indentation}${uniqueName1}-msgno = ${number}.
+${indentation}DATA ${uniqueName2} TYPE REF TO ${className}.
+${indentation}CREATE OBJECT ${uniqueName2} EXPORTING textid = ${uniqueName1}.
+${indentation}RAISE EXCEPTION ${uniqueName2}.`;
+            const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getStart(), node.getEnd(), abap);
+            return issue_1.Issue.atToken(lowFile, startToken, "Downport RAISE MESSAGE", this.getMetadata().key, this.conf.severity, fix);
+        }
+        return undefined;
+    }
     emptyKey(node, lowFile) {
         for (let i of node.findAllExpressions(Expressions.TypeTable)) {
             const key = i.findDirectExpression(Expressions.TypeTableKey);

package/build/src/rules/unnecessary_chaining.js

@@ -58,7 +58,7 @@ class UnnecessaryChaining extends _abap_rule_1.ABAPRule {
             }
             const fix = edit_helper_1.EditHelper.deleteRange(file, colon.getStart(), colon.getEnd());
             const message = "Unnecessary chaining";
-            const issue = issue_1.Issue.atStatement(file, statements[i], message, this.getMetadata().key, this.conf.severity, fix);
+            const issue = issue_1.Issue.atToken(file, colon, message, this.getMetadata().key, this.conf.severity, fix);
             issues.push(issue);
         }
         return issues;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.83.11",
+    "version": "2.83.15",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -52,7 +52,7 @@
         "chai": "^4.3.4",
         "eslint": "^8.5.0",
         "mocha": "^9.1.3",
-        "c8": "^7.10.0",
+        "c8": "^7.11.0",
         "source-map-support": "^0.5.21",
         "ts-json-schema-generator": "^0.97.0",
         "typescript": "^4.5.4"