@abaplint/core 2.82.17 → 2.83.3

package/build/abaplint.d.ts

@@ -170,7 +170,7 @@ declare class ArrowOrDash extends Expression {
     getRunnable(): IStatementRunnable;
 }
 
-export declare class Artifacts {
+export declare class ArtifactsABAP {
     static getStructures(): IStructure[];
     static getExpressions(): (new () => Expression)[];
     static getStatements(): IStatement[];
@@ -1114,6 +1114,9 @@ declare class DataControl extends AbstractObject {
 
 declare class DataDefinition extends AbstractObject {
     private sqlViewName;
+    private parserError;
+    private fieldNames;
+    private sources;
     getType(): string;
     getAllowedNaming(): {
         maxLength: number;
@@ -1122,8 +1125,16 @@ declare class DataDefinition extends AbstractObject {
     getSQLViewName(): string | undefined;
     getDescription(): string | undefined;
     parseType(_reg: IRegistry): AbstractType;
+    listSources(): {
+        name: string;
+        as: string | undefined;
+    }[];
     setDirty(): void;
+    findSourceFile(): IFile | undefined;
+    hasParserError(): boolean | undefined;
     parse(): IParseResult;
+    private findFieldNames;
+    private findSources;
 }
 
 declare class DataDefinition_2 extends Expression {
@@ -1188,44 +1199,16 @@ declare class DDIC {
     textToType(text: string | undefined, length: string | undefined, decimals: string | undefined, parent: string, qualify?: boolean): AbstractType;
 }
 
-declare class DDLInclude extends Expression {
-    getRunnable(): IStatementRunnable;
-}
-
 declare enum DDLKind {
     Structure = "structure",
     Table = "table"
 }
 
-declare class DDLName extends Expression {
-    getRunnable(): IStatementRunnable;
-}
-
 export declare class DDLParser {
     parse(file: IFile): IDDLParserResult | undefined;
     private parsedToResult;
 }
 
-declare class DDLStructure extends Expression {
-    getRunnable(): IStatementRunnable;
-}
-
-declare class DDLStructureField extends Expression {
-    getRunnable(): IStatementRunnable;
-}
-
-declare class DDLTable extends Expression {
-    getRunnable(): IStatementRunnable;
-}
-
-declare class DDLTableField extends Expression {
-    getRunnable(): IStatementRunnable;
-}
-
-declare class DDLType extends Expression {
-    getRunnable(): IStatementRunnable;
-}
-
 declare class DecFloat16Type extends AbstractType {
     toText(): string;
     isGeneric(): boolean;
@@ -1689,13 +1672,6 @@ declare namespace Expressions {
         DataDefinition_2 as DataDefinition,
         DatabaseConnection,
         DatabaseTable,
-        DDLInclude,
-        DDLName,
-        DDLStructureField,
-        DDLStructure,
-        DDLTableField,
-        DDLTable,
-        DDLType,
         Decimals,
         Default,
         DefinitionName,
@@ -2573,10 +2549,14 @@ declare interface IGlobalConfig {
     useApackDependencies?: boolean;
     /** Do not report any issues for includes without main programs */
     skipIncludesWithoutMain?: boolean;
-    /** list of files to exclude, case insensitive regex
+    /** list of files to exclude, these files are not added when running syntax check or any other rules, case insensitive regex
      * @uniqueItems true
      */
     exclude?: string[];
+    /** list of files to not report any issues for, case insensitive regex
+     * @uniqueItems true
+     */
+    noIssues?: string[];
 }
 
 declare interface IImplementing {

package/build/src/abap/2_statements/expressions/index.js

@@ -47,13 +47,6 @@ __exportStar(require("./corresponding_body"), exports);
 __exportStar(require("./data_definition"), exports);
 __exportStar(require("./database_connection"), exports);
 __exportStar(require("./database_table"), exports);
-__exportStar(require("./ddl/ddl_include"), exports);
-__exportStar(require("./ddl/ddl_name"), exports);
-__exportStar(require("./ddl/ddl_structure_field"), exports);
-__exportStar(require("./ddl/ddl_structure"), exports);
-__exportStar(require("./ddl/ddl_table_field"), exports);
-__exportStar(require("./ddl/ddl_table"), exports);
-__exportStar(require("./ddl/ddl_type"), exports);
 __exportStar(require("./decimals"), exports);
 __exportStar(require("./default"), exports);
 __exportStar(require("./definition_name"), exports);

package/build/src/abap/2_statements/statement_parser.js

@@ -14,7 +14,7 @@ exports.STATEMENT_MAX_TOKENS = 1000;
 class StatementMap {
     constructor() {
         this.map = {};
-        for (const stat of artifacts_1.Artifacts.getStatements()) {
+        for (const stat of artifacts_1.ArtifactsABAP.getStatements()) {
             const f = stat.getMatcher().first();
             if (f.length === 0) {
                 throw new Error("StatementMap, first must have contents");

package/build/src/abap/2_statements/statements/call_function.js

@@ -9,7 +9,7 @@ class CallFunction {
         const starting = (0, combi_1.seq)("STARTING NEW TASK", expressions_1.SimpleSource2);
         const update = (0, combi_1.str)("IN UPDATE TASK");
         const unit = (0, combi_1.seq)("UNIT", expressions_1.Source);
-        const background = (0, combi_1.seq)("IN BACKGROUND", (0, combi_1.alt)("TASK", unit));
+        const background = (0, combi_1.verNot)(version_1.Version.Cloud, (0, combi_1.seq)("IN BACKGROUND", (0, combi_1.alt)("TASK", unit)));
         const calling = (0, combi_1.seq)("CALLING", expressions_1.MethodName, "ON END OF TASK");
         const performing = (0, combi_1.seq)("PERFORMING", expressions_1.FormName, "ON END OF TASK");
         const separate = (0, combi_1.str)("AS SEPARATE UNIT");

package/build/src/abap/artifacts.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.Artifacts = void 0;
+exports.ArtifactsABAP = void 0;
 const Statements = require("./2_statements/statements");
 const Expressions = require("./2_statements/expressions");
 const combi_1 = require("./2_statements/combi");
@@ -35,7 +35,7 @@ class List {
 function className(cla) {
     return cla.constructor.name;
 }
-class Artifacts {
+class ArtifactsABAP {
     static getStructures() {
         const ret = [];
         const list = Structures;
@@ -77,5 +77,5 @@ class Artifacts {
         return list.get();
     }
 }
-exports.Artifacts = Artifacts;
+exports.ArtifactsABAP = ArtifactsABAP;
 //# sourceMappingURL=artifacts.js.map

package/build/src/cds/artifacts.js

@@ -0,0 +1,18 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.ArtifactsCDS = void 0;
+const Expressions = require("./expressions");
+class ArtifactsCDS {
+    static getExpressions() {
+        const ret = [];
+        const list = Expressions;
+        for (const key in Expressions) {
+            if (typeof list[key] === "function") {
+                ret.push(list[key]);
+            }
+        }
+        return ret;
+    }
+}
+exports.ArtifactsCDS = ArtifactsCDS;
+//# sourceMappingURL=artifacts.js.map

package/build/src/cds/cds_lexer.js

@@ -0,0 +1,113 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CDSLexer = void 0;
+const tokens_1 = require("../abap/1_lexer/tokens");
+const position_1 = require("../position");
+// todo: Keywords must be all uppercase, all lowercase, or in lowercase with an
+// uppercase initial letter. Other mixes of uppercase and lowercase are not allowed
+class Stream {
+    constructor(buffer) {
+        this.buffer = buffer;
+    }
+    takeNext() {
+        const next = this.buffer.substring(0, 1);
+        this.buffer = this.buffer.substring(1);
+        return next;
+    }
+    peekNext() {
+        const next = this.buffer.substring(0, 1);
+        return next;
+    }
+    length() {
+        return this.buffer.length;
+    }
+}
+class Result {
+    constructor() {
+        this.result = [];
+    }
+    add(text, row, col) {
+        if (text.length > 0) {
+            this.result.push(new tokens_1.Identifier(new position_1.Position(row, col), text));
+        }
+        return "";
+    }
+    get() {
+        return this.result;
+    }
+}
+var Mode;
+(function (Mode) {
+    Mode[Mode["Default"] = 0] = "Default";
+    Mode[Mode["String"] = 1] = "String";
+    Mode[Mode["SingleLineComment"] = 2] = "SingleLineComment";
+    Mode[Mode["MultiLineComment"] = 3] = "MultiLineComment";
+})(Mode || (Mode = {}));
+class CDSLexer {
+    static run(file) {
+        const result = new Result();
+        let mode = Mode.Default;
+        let row = 1;
+        let col = 1;
+        let build = "";
+        const stream = new Stream(file.getRaw());
+        while (stream.length() > 0) {
+            const next = stream.takeNext();
+            const nextNext = stream.peekNext();
+            col++;
+            if (mode === Mode.String) {
+                build += next;
+                if (next === "'") {
+                    build = result.add(build, row, col);
+                    mode = Mode.Default;
+                }
+                continue;
+            }
+            if (mode === Mode.SingleLineComment) {
+                if (next === "\n") {
+                    mode = Mode.Default;
+                }
+                continue;
+            }
+            else if (mode === Mode.Default && next === "/" && nextNext === "/") {
+                mode = Mode.SingleLineComment;
+                build = result.add(build, row, col);
+                continue;
+            }
+            switch (next) {
+                case "'":
+                    mode = Mode.String;
+                    build += next;
+                    break;
+                case " ":
+                    build = result.add(build, row, col);
+                    break;
+                case "\n":
+                    build = result.add(build, row, col);
+                    row++;
+                    col = 0;
+                    break;
+                case ";":
+                case ":":
+                case ",":
+                case ".":
+                case "{":
+                case "}":
+                case "(":
+                case ")":
+                case "[":
+                case "]":
+                    build = result.add(build, row, col);
+                    result.add(next, row, col);
+                    break;
+                default:
+                    build += next;
+                    break;
+            }
+        }
+        result.add(build, row, col);
+        return result.get();
+    }
+}
+exports.CDSLexer = CDSLexer;
+//# sourceMappingURL=cds_lexer.js.map

package/build/src/cds/cds_parser.js

@@ -0,0 +1,25 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CDSParser = void 0;
+const combi_1 = require("../abap/2_statements/combi");
+const nodes_1 = require("../abap/nodes");
+const version_1 = require("../version");
+const cds_lexer_1 = require("./cds_lexer");
+const Expressions = require("./expressions");
+// todo: the names of the ABAP + CDS + DDL expressions might overlap, if overlapping the singleton will fail
+class CDSParser {
+    parse(file) {
+        if (file === undefined) {
+            return undefined;
+        }
+        const tokens = cds_lexer_1.CDSLexer.run(file);
+        // console.dir(tokens);
+        const res = combi_1.Combi.run(new Expressions.CDSDefineView(), tokens, version_1.defaultVersion);
+        if (res === undefined || !(res[0] instanceof nodes_1.ExpressionNode)) {
+            return undefined;
+        }
+        return res[0];
+    }
+}
+exports.CDSParser = CDSParser;
+//# sourceMappingURL=cds_parser.js.map

package/build/src/cds/expressions/cds_annotation.js

@@ -0,0 +1,16 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CDSAnnotation = void 0;
+const _1 = require(".");
+const combi_1 = require("../../abap/2_statements/combi");
+class CDSAnnotation extends combi_1.Expression {
+    getRunnable() {
+        // todo: add all the known annotations
+        const value = (0, combi_1.alt)((0, combi_1.regex)(/^'[\w ]+'$/), "true", "false", (0, combi_1.regex)(/^\d+$/), (0, combi_1.seq)((0, combi_1.regex)(/^\d+$/), ".", (0, combi_1.regex)(/^\d+$/)), (0, combi_1.regex)(/^#\w+$/));
+        const valueList = (0, combi_1.seq)("[", value, (0, combi_1.star)((0, combi_1.seq)(",", value)), "]");
+        const valueNested = (0, combi_1.seq)("{", _1.CDSName, (0, combi_1.star)((0, combi_1.seq)(".", _1.CDSName)), ":", value, "}");
+        return (0, combi_1.seq)((0, combi_1.regex)(/^@\w+$/), (0, combi_1.star)((0, combi_1.seq)(".", (0, combi_1.regex)(/^\w+$/))), (0, combi_1.opt)(":"), (0, combi_1.opt)((0, combi_1.alt)(valueList, valueNested, value)));
+    }
+}
+exports.CDSAnnotation = CDSAnnotation;
+//# sourceMappingURL=cds_annotation.js.map

package/build/src/cds/expressions/cds_as.js

@@ -0,0 +1,12 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CDSAs = void 0;
+const _1 = require(".");
+const combi_1 = require("../../abap/2_statements/combi");
+class CDSAs extends combi_1.Expression {
+    getRunnable() {
+        return (0, combi_1.seq)("AS", _1.CDSName);
+    }
+}
+exports.CDSAs = CDSAs;
+//# sourceMappingURL=cds_as.js.map

package/build/src/cds/expressions/cds_association.js

@@ -0,0 +1,17 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CDSAssociation = void 0;
+const _1 = require(".");
+const combi_1 = require("../../abap/2_statements/combi");
+class CDSAssociation extends combi_1.Expression {
+    getRunnable() {
+        const cardinality = (0, combi_1.seq)("[", (0, combi_1.alt)("0", "1"), ".", ".", (0, combi_1.alt)("0", "1", "*"), "]");
+        const as = (0, combi_1.seq)("AS", _1.CDSName);
+        const name = (0, combi_1.seq)(_1.CDSName, (0, combi_1.plus)((0, combi_1.seq)(".", _1.CDSName)));
+        const cond = (0, combi_1.seq)(name, "=", name);
+        const and = (0, combi_1.seq)("AND", cond);
+        return (0, combi_1.seq)("ASSOCIATION", cardinality, "TO", _1.CDSName, (0, combi_1.opt)(as), "ON", cond, (0, combi_1.star)(and));
+    }
+}
+exports.CDSAssociation = CDSAssociation;
+//# sourceMappingURL=cds_association.js.map

package/build/src/cds/expressions/cds_cast.js

@@ -0,0 +1,13 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CDSCast = void 0;
+const _1 = require(".");
+const combi_1 = require("../../abap/2_statements/combi");
+class CDSCast extends combi_1.Expression {
+    getRunnable() {
+        const name = (0, combi_1.seq)(_1.CDSName, (0, combi_1.opt)((0, combi_1.seq)(".", _1.CDSName)));
+        return (0, combi_1.seq)("CAST", "(", (0, combi_1.alt)(name, _1.CDSFunction), "AS", _1.CDSName, (0, combi_1.opt)((0, combi_1.seq)("PRESERVING", "TYPE")), ")");
+    }
+}
+exports.CDSCast = CDSCast;
+//# sourceMappingURL=cds_cast.js.map

package/build/src/cds/expressions/cds_define_view.js

@@ -0,0 +1,14 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CDSDefineView = void 0;
+const _1 = require(".");
+const combi_1 = require("../../abap/2_statements/combi");
+const cds_name_1 = require("./cds_name");
+const cds_select_1 = require("./cds_select");
+class CDSDefineView extends combi_1.Expression {
+    getRunnable() {
+        return (0, combi_1.seq)((0, combi_1.star)(_1.CDSAnnotation), (0, combi_1.str)("DEFINE VIEW"), cds_name_1.CDSName, "AS", cds_select_1.CDSSelect, (0, combi_1.opt)(";"));
+    }
+}
+exports.CDSDefineView = CDSDefineView;
+//# sourceMappingURL=cds_define_view.js.map

package/build/src/cds/expressions/cds_element.js

@@ -0,0 +1,14 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CDSElement = void 0;
+const _1 = require(".");
+const combi_1 = require("../../abap/2_statements/combi");
+const cds_as_1 = require("./cds_as");
+const cds_cast_1 = require("./cds_cast");
+class CDSElement extends combi_1.Expression {
+    getRunnable() {
+        return (0, combi_1.seq)((0, combi_1.star)(_1.CDSAnnotation), (0, combi_1.optPrio)("KEY"), (0, combi_1.alt)(_1.CDSName, cds_cast_1.CDSCast), (0, combi_1.optPrio)(cds_as_1.CDSAs));
+    }
+}
+exports.CDSElement = CDSElement;
+//# sourceMappingURL=cds_element.js.map

package/build/src/cds/expressions/cds_function.js

@@ -0,0 +1,17 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CDSFunction = void 0;
+const _1 = require(".");
+const combi_1 = require("../../abap/2_statements/combi");
+class CDSFunction extends combi_1.Expression {
+    getRunnable() {
+        const input = (0, combi_1.alt)(_1.CDSName, (0, combi_1.regex)(/^\d+$/));
+        const coalesce = (0, combi_1.seq)("COALESCE", "(", input, ",", input, ")");
+        const concat = (0, combi_1.seq)("CONCAT", "(", input, ",", input, ")");
+        const concat_with_space = (0, combi_1.seq)("CONCAT_WITH_SPACE", "(", input, ",", input, ",", input, ")");
+        const substring = (0, combi_1.seq)("SUBSTRING", "(", input, ",", input, ",", input, ")");
+        return (0, combi_1.alt)(substring, coalesce, concat, concat_with_space);
+    }
+}
+exports.CDSFunction = CDSFunction;
+//# sourceMappingURL=cds_function.js.map

package/build/src/cds/expressions/cds_join.js

@@ -0,0 +1,13 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CDSJoin = void 0;
+const _1 = require(".");
+const combi_1 = require("../../abap/2_statements/combi");
+class CDSJoin extends combi_1.Expression {
+    getRunnable() {
+        const name = (0, combi_1.seq)(_1.CDSName, ".", _1.CDSName);
+        return (0, combi_1.seq)("INNER JOIN", _1.CDSSource, "ON", name, "=", name);
+    }
+}
+exports.CDSJoin = CDSJoin;
+//# sourceMappingURL=cds_join.js.map

package/build/src/cds/expressions/cds_name.js

@@ -0,0 +1,11 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CDSName = void 0;
+const combi_1 = require("../../abap/2_statements/combi");
+class CDSName extends combi_1.Expression {
+    getRunnable() {
+        return (0, combi_1.regex)(/^\$?[\w_]+$/);
+    }
+}
+exports.CDSName = CDSName;
+//# sourceMappingURL=cds_name.js.map

package/build/src/cds/expressions/cds_select.js

@@ -0,0 +1,15 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CDSSelect = void 0;
+const _1 = require(".");
+const combi_1 = require("../../abap/2_statements/combi");
+const cds_association_1 = require("./cds_association");
+const cds_element_1 = require("./cds_element");
+const cds_join_1 = require("./cds_join");
+class CDSSelect extends combi_1.Expression {
+    getRunnable() {
+        return (0, combi_1.seq)((0, combi_1.str)("SELECT FROM"), _1.CDSSource, (0, combi_1.opt)(cds_join_1.CDSJoin), (0, combi_1.star)(cds_association_1.CDSAssociation), (0, combi_1.str)("{"), (0, combi_1.plus)(cds_element_1.CDSElement), (0, combi_1.star)((0, combi_1.seq)(",", cds_element_1.CDSElement)), (0, combi_1.str)("}"), (0, combi_1.opt)(_1.CDSWhere));
+    }
+}
+exports.CDSSelect = CDSSelect;
+//# sourceMappingURL=cds_select.js.map

package/build/src/cds/expressions/cds_source.js

@@ -0,0 +1,12 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CDSSource = void 0;
+const _1 = require(".");
+const combi_1 = require("../../abap/2_statements/combi");
+class CDSSource extends combi_1.Expression {
+    getRunnable() {
+        return (0, combi_1.seq)((0, combi_1.regex)(/^[\w_]+$/), (0, combi_1.opt)(_1.CDSAs));
+    }
+}
+exports.CDSSource = CDSSource;
+//# sourceMappingURL=cds_source.js.map

package/build/src/cds/expressions/cds_where.js

@@ -0,0 +1,15 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CDSWhere = void 0;
+const _1 = require(".");
+const combi_1 = require("../../abap/2_statements/combi");
+class CDSWhere extends combi_1.Expression {
+    getRunnable() {
+        const constant = (0, combi_1.regex)(/^'[\w ]+'$/);
+        const field = (0, combi_1.seq)(_1.CDSName, (0, combi_1.star)((0, combi_1.seq)(".", _1.CDSName)));
+        const condition = (0, combi_1.seq)(field, "=", (0, combi_1.alt)(constant, field));
+        return (0, combi_1.seq)("WHERE", condition, (0, combi_1.star)((0, combi_1.seq)("AND", condition)));
+    }
+}
+exports.CDSWhere = CDSWhere;
+//# sourceMappingURL=cds_where.js.map

package/build/src/cds/expressions/index.js

@@ -0,0 +1,25 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    Object.defineProperty(o, k2, { enumerable: true, get: function() { return m[k]; } });
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __exportStar = (this && this.__exportStar) || function(m, exports) {
+    for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+__exportStar(require("./cds_annotation"), exports);
+__exportStar(require("./cds_as"), exports);
+__exportStar(require("./cds_association"), exports);
+__exportStar(require("./cds_cast"), exports);
+__exportStar(require("./cds_define_view"), exports);
+__exportStar(require("./cds_element"), exports);
+__exportStar(require("./cds_function"), exports);
+__exportStar(require("./cds_join"), exports);
+__exportStar(require("./cds_name"), exports);
+__exportStar(require("./cds_select"), exports);
+__exportStar(require("./cds_source"), exports);
+__exportStar(require("./cds_where"), exports);
+//# sourceMappingURL=index.js.map

package/build/src/config.js

@@ -46,6 +46,7 @@ class Config {
             global: {
                 files: "/src/**/*.*",
                 exclude: [],
+                noIssues: [],
                 skipGeneratedGatewayClasses: true,
                 skipGeneratedPersistentClasses: true,
                 skipGeneratedFunctionGroups: true,

package/build/src/ddl/artifacts.js

@@ -0,0 +1,18 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.ArtifactsDDL = void 0;
+const Expressions = require("./expressions");
+class ArtifactsDDL {
+    static getExpressions() {
+        const ret = [];
+        const list = Expressions;
+        for (const key in Expressions) {
+            if (typeof list[key] === "function") {
+                ret.push(list[key]);
+            }
+        }
+        return ret;
+    }
+}
+exports.ArtifactsDDL = ArtifactsDDL;
+//# sourceMappingURL=artifacts.js.map

package/build/src/ddl/ddl_parser.js

@@ -5,7 +5,7 @@ const combi_1 = require("../abap/2_statements/combi");
 const nodes_1 = require("../abap/nodes");
 const version_1 = require("../version");
 const ddl_lexer_1 = require("./ddl_lexer");
-const Expressions = require("../abap/2_statements/expressions");
+const Expressions = require("./expressions");
 var DDLKind;
 (function (DDLKind) {
     DDLKind["Structure"] = "structure";

package/build/src/{abap/2_statements/expressions/ddl → ddl/expressions}/ddl_include.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.DDLInclude = void 0;
-const combi_1 = require("../../combi");
+const combi_1 = require("../../abap/2_statements/combi");
 const ddl_name_1 = require("./ddl_name");
 class DDLInclude extends combi_1.Expression {
     getRunnable() {

package/build/src/{abap/2_statements/expressions/ddl → ddl/expressions}/ddl_name.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.DDLName = void 0;
-const combi_1 = require("../../combi");
+const combi_1 = require("../../abap/2_statements/combi");
 class DDLName extends combi_1.Expression {
     getRunnable() {
         return (0, combi_1.regex)(/^\w+$/);

package/build/src/{abap/2_statements/expressions/ddl → ddl/expressions}/ddl_structure.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.DDLStructure = void 0;
-const combi_1 = require("../../combi");
+const combi_1 = require("../../abap/2_statements/combi");
 const ddl_structure_field_1 = require("./ddl_structure_field");
 const ddl_name_1 = require("./ddl_name");
 const ddl_include_1 = require("./ddl_include");

package/build/src/{abap/2_statements/expressions/ddl → ddl/expressions}/ddl_structure_field.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.DDLStructureField = void 0;
-const combi_1 = require("../../combi");
+const combi_1 = require("../../abap/2_statements/combi");
 const ddl_name_1 = require("./ddl_name");
 const ddl_type_1 = require("./ddl_type");
 class DDLStructureField extends combi_1.Expression {

package/build/src/{abap/2_statements/expressions/ddl → ddl/expressions}/ddl_table.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.DDLTable = void 0;
-const combi_1 = require("../../combi");
+const combi_1 = require("../../abap/2_statements/combi");
 const ddl_include_1 = require("./ddl_include");
 const ddl_name_1 = require("./ddl_name");
 const ddl_table_field_1 = require("./ddl_table_field");

package/build/src/{abap/2_statements/expressions/ddl → ddl/expressions}/ddl_table_field.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.DDLTableField = void 0;
-const combi_1 = require("../../combi");
+const combi_1 = require("../../abap/2_statements/combi");
 const ddl_name_1 = require("./ddl_name");
 const ddl_type_1 = require("./ddl_type");
 class DDLTableField extends combi_1.Expression {

package/build/src/{abap/2_statements/expressions/ddl → ddl/expressions}/ddl_type.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.DDLType = void 0;
-const combi_1 = require("../../combi");
+const combi_1 = require("../../abap/2_statements/combi");
 class DDLType extends combi_1.Expression {
     getRunnable() {
         return (0, combi_1.regex)(/^(abap\.)?\w+(\(\d+\))?$/);

package/build/src/ddl/expressions/index.js

@@ -0,0 +1,20 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    Object.defineProperty(o, k2, { enumerable: true, get: function() { return m[k]; } });
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __exportStar = (this && this.__exportStar) || function(m, exports) {
+    for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+__exportStar(require("./ddl_include"), exports);
+__exportStar(require("./ddl_name"), exports);
+__exportStar(require("./ddl_structure_field"), exports);
+__exportStar(require("./ddl_structure"), exports);
+__exportStar(require("./ddl_table_field"), exports);
+__exportStar(require("./ddl_table"), exports);
+__exportStar(require("./ddl_type"), exports);
+//# sourceMappingURL=index.js.map

package/build/src/index.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.Severity = exports.Visibility = exports.Info = exports.Rename = exports.PrettyPrinter = exports.Position = exports.CurrentScope = exports.ABAPFile = exports.SpaghettiScope = exports.SyntaxLogic = exports.ABAPObject = exports.Tokens = exports.LanguageServerTypes = exports.DDLParser = exports.applyEditList = exports.applyEditSingle = exports.SpaghettiScopeNode = exports.AbstractFile = exports.Token = exports.ScopeType = exports.BasicTypes = exports.TypedIdentifier = exports.AbstractType = exports.VirtualPosition = exports.Comment = exports.Unknown = exports.Empty = exports.Identifier = exports.Nodes = exports.Types = exports.Expressions = exports.Statements = exports.Structures = exports.Objects = exports.ArtifactsRules = exports.ArtifactsObjects = exports.Artifacts = exports.BuiltIn = exports.MethodLengthStats = exports.LanguageServer = exports.Registry = exports.ReferenceType = exports.Version = exports.Config = exports.Issue = exports.MemoryFile = void 0;
+exports.Severity = exports.Visibility = exports.Info = exports.Rename = exports.PrettyPrinter = exports.Position = exports.CurrentScope = exports.ABAPFile = exports.SpaghettiScope = exports.SyntaxLogic = exports.ABAPObject = exports.Tokens = exports.LanguageServerTypes = exports.DDLParser = exports.applyEditList = exports.applyEditSingle = exports.SpaghettiScopeNode = exports.AbstractFile = exports.Token = exports.ScopeType = exports.BasicTypes = exports.TypedIdentifier = exports.AbstractType = exports.VirtualPosition = exports.Comment = exports.Unknown = exports.Empty = exports.Identifier = exports.Nodes = exports.Types = exports.Expressions = exports.Statements = exports.Structures = exports.Objects = exports.ArtifactsRules = exports.ArtifactsObjects = exports.ArtifactsABAP = exports.BuiltIn = exports.MethodLengthStats = exports.LanguageServer = exports.Registry = exports.ReferenceType = exports.Version = exports.Config = exports.Issue = exports.MemoryFile = void 0;
 const issue_1 = require("./issue");
 Object.defineProperty(exports, "Issue", { enumerable: true, get: function () { return issue_1.Issue; } });
 const config_1 = require("./config");
@@ -16,7 +16,7 @@ Object.defineProperty(exports, "LanguageServer", { enumerable: true, get: functi
 const LanguageServerTypes = require("./lsp/_interfaces");
 exports.LanguageServerTypes = LanguageServerTypes;
 const artifacts_1 = require("./abap/artifacts");
-Object.defineProperty(exports, "Artifacts", { enumerable: true, get: function () { return artifacts_1.Artifacts; } });
+Object.defineProperty(exports, "ArtifactsABAP", { enumerable: true, get: function () { return artifacts_1.ArtifactsABAP; } });
 const artifacts_objects_1 = require("./artifacts_objects");
 Object.defineProperty(exports, "ArtifactsObjects", { enumerable: true, get: function () { return artifacts_objects_1.ArtifactsObjects; } });
 const artifacts_rules_1 = require("./artifacts_rules");

package/build/src/objects/data_definition.js

@@ -2,11 +2,16 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.DataDefinition = void 0;
 const basic_1 = require("../abap/types/basic");
+const cds_parser_1 = require("../cds/cds_parser");
+const expressions_1 = require("../cds/expressions");
 const _abstract_object_1 = require("./_abstract_object");
 class DataDefinition extends _abstract_object_1.AbstractObject {
     constructor() {
         super(...arguments);
         this.sqlViewName = undefined;
+        this.parserError = undefined;
+        this.fieldNames = [];
+        this.sources = [];
     }
     getType() {
         return "DDLS";
@@ -25,24 +30,81 @@ class DataDefinition extends _abstract_object_1.AbstractObject {
         return undefined;
     }
     parseType(_reg) {
-        return new basic_1.VoidType("DDLS:todo");
+        this.parse();
+        if (this.fieldNames.length === 0) {
+            return new basic_1.VoidType("DDLS:todo");
+        }
+        else {
+            const components = [];
+            for (const f of this.fieldNames) {
+                components.push({
+                    name: f,
+                    type: new basic_1.VoidType("DDLS:fieldname"),
+                });
+            }
+            return new basic_1.StructureType(components);
+        }
+    }
+    listSources() {
+        return this.sources;
     }
     setDirty() {
         this.sqlViewName = undefined;
+        this.parserError = undefined;
+        this.fieldNames = [];
+        this.sources = [];
         super.setDirty();
     }
+    findSourceFile() {
+        return this.getFiles().find(f => f.getFilename().endsWith(".asddls"));
+    }
+    hasParserError() {
+        return this.parserError;
+    }
     parse() {
+        var _a;
         if (this.isDirty() === false) {
             return { updated: false, runtime: 0 };
         }
         this.sqlViewName = undefined;
-        const asddls = this.getFiles().find(f => f.getFilename().endsWith(".asddls"));
-        const match = asddls === null || asddls === void 0 ? void 0 : asddls.getRaw().match(/@AbapCatalog\.sqlViewName: '(\w+)'/);
+        const match = (_a = this.findSourceFile()) === null || _a === void 0 ? void 0 : _a.getRaw().match(/@AbapCatalog\.sqlViewName: '(\w+)'/);
         if (match) {
             this.sqlViewName = match[1].toUpperCase();
         }
+        const tree = new cds_parser_1.CDSParser().parse(this.findSourceFile());
+        if (tree) {
+            this.findFieldNames(tree);
+            this.findSources(tree);
+        }
+        else {
+            this.parserError = true;
+        }
+        this.dirty = false;
         return { updated: true, runtime: 0 };
     }
+    findFieldNames(tree) {
+        var _a;
+        this.fieldNames = [];
+        for (const e of tree.findAllExpressions(expressions_1.CDSElement)) {
+            let found = (_a = e.findDirectExpression(expressions_1.CDSAs)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(expressions_1.CDSName);
+            if (found === undefined) {
+                found = e.findDirectExpression(expressions_1.CDSName);
+            }
+            if (found === undefined) {
+                continue;
+            }
+            this.fieldNames.push(found === null || found === void 0 ? void 0 : found.concatTokens());
+        }
+    }
+    findSources(tree) {
+        var _a, _b;
+        this.sources = [];
+        for (const e of tree.findAllExpressions(expressions_1.CDSSource)) {
+            const name = e.getFirstToken().getStr();
+            const as = (_b = (_a = e.findDirectExpression(expressions_1.CDSAs)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(expressions_1.CDSName)) === null || _b === void 0 ? void 0 : _b.getFirstToken().getStr();
+            this.sources.push({ name, as });
+        }
+    }
 }
 exports.DataDefinition = DataDefinition;
 //# sourceMappingURL=data_definition.js.map

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.82.17";
+        return "2.83.3";
     }
     getDDICReferences() {
         return this.references;
@@ -326,10 +326,23 @@ class Registry {
     excludeIssues(issues) {
         var _a;
         const ret = issues;
+        const globalNoIssues = this.conf.getGlobal().noIssues || [];
+        const globalNoIssuesPatterns = globalNoIssues.map(x => new RegExp(x, "i"));
+        if (globalNoIssuesPatterns.length > 0) {
+            for (let i = ret.length - 1; i >= 0; i--) {
+                const filename = ret[i].getFilename();
+                if (excludeHelper_1.ExcludeHelper.isExcluded(filename, globalNoIssuesPatterns)) {
+                    ret.splice(i, 1);
+                }
+            }
+        }
         // exclude issues, as now we know both the filename and issue key
         for (const rule of artifacts_rules_1.ArtifactsRules.getRules()) {
             const key = rule.getMetadata().key;
-            const ruleExclude = ((_a = this.conf.readByKey(key, "exclude")) !== null && _a !== void 0 ? _a : []);
+            const ruleExclude = (_a = this.conf.readByKey(key, "exclude")) !== null && _a !== void 0 ? _a : [];
+            if (ruleExclude.length === 0) {
+                continue;
+            }
             const ruleExcludePatterns = ruleExclude.map(x => new RegExp(x, "i"));
             for (let i = ret.length - 1; i >= 0; i--) {
                 if (ret[i].getKey() !== key) {

package/build/src/rules/cds_parser_error.js

@@ -0,0 +1,46 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CDSParserError = exports.CDSParserErrorConf = void 0;
+const issue_1 = require("../issue");
+const _irule_1 = require("./_irule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const objects_1 = require("../objects");
+class CDSParserErrorConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.CDSParserErrorConf = CDSParserErrorConf;
+class CDSParserError {
+    constructor() {
+        this.conf = new CDSParserErrorConf();
+    }
+    getMetadata() {
+        return {
+            key: "cds_parser_error",
+            title: "CDS Parser Error",
+            shortDescription: `CDS parsing, experimental`,
+            extendedInformation: ``,
+            tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Experimental],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    initialize(_reg) {
+        return this;
+    }
+    run(o) {
+        const issues = [];
+        if (o.getType() === "DDLS" && o instanceof objects_1.DataDefinition) {
+            const hasError = o.hasParserError();
+            const file = o.findSourceFile();
+            if (hasError === true && file) {
+                issues.push(issue_1.Issue.atRow(file, 1, "CDS Parser error", this.getMetadata().key));
+            }
+        }
+        return issues;
+    }
+}
+exports.CDSParserError = CDSParserError;
+//# sourceMappingURL=cds_parser_error.js.map

package/build/src/rules/index.js

@@ -20,6 +20,7 @@ __exportStar(require("./avoid_use"), exports);
 __exportStar(require("./begin_end_names"), exports);
 __exportStar(require("./begin_single_include"), exports);
 __exportStar(require("./call_transaction_authority_check"), exports);
+__exportStar(require("./cds_parser_error"), exports);
 __exportStar(require("./chain_mainly_declarations"), exports);
 __exportStar(require("./check_abstract"), exports);
 __exportStar(require("./check_comments"), exports);
@@ -92,6 +93,7 @@ __exportStar(require("./msag_consistency"), exports);
 __exportStar(require("./names_no_dash"), exports);
 __exportStar(require("./nesting"), exports);
 __exportStar(require("./newline_between_methods"), exports);
+__exportStar(require("./no_aliases"), exports);
 __exportStar(require("./no_chained_assignment"), exports);
 __exportStar(require("./no_public_attributes"), exports);
 __exportStar(require("./no_yoda_conditions"), exports);
@@ -103,6 +105,7 @@ __exportStar(require("./parser_702_chaining"), exports);
 __exportStar(require("./parser_error"), exports);
 __exportStar(require("./parser_missing_space"), exports);
 __exportStar(require("./pragma_placement"), exports);
+__exportStar(require("./prefer_corresponding"), exports);
 __exportStar(require("./prefer_inline"), exports);
 __exportStar(require("./prefer_is_not"), exports);
 __exportStar(require("./prefer_raise_exception_new"), exports);

package/build/src/rules/no_aliases.js

@@ -0,0 +1,43 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.NoAliases = exports.NoAliasesConf = void 0;
+const issue_1 = require("../issue");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _abap_rule_1 = require("./_abap_rule");
+const Statements = require("../abap/2_statements/statements");
+const _irule_1 = require("./_irule");
+class NoAliasesConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.NoAliasesConf = NoAliasesConf;
+class NoAliases extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new NoAliasesConf();
+    }
+    getMetadata() {
+        return {
+            key: "no_aliases",
+            title: "No ALIASES",
+            shortDescription: `Detects use of the ALIAS statement`,
+            tags: [_irule_1.RuleTag.SingleFile],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        const message = "Do not use ALIASES";
+        for (const stat of file.getStatements()) {
+            if (stat.get() instanceof Statements.Aliases) {
+                issues.push(issue_1.Issue.atStatement(file, stat, message, this.getMetadata().key, this.conf.severity));
+            }
+        }
+        return issues;
+    }
+}
+exports.NoAliases = NoAliases;
+//# sourceMappingURL=no_aliases.js.map

package/build/src/rules/obsolete_statement.js

@@ -106,6 +106,8 @@ RANGES: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abapranges.ht
 
 PACK: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abappack.htm
 
+MOVE: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapmove_obs.htm
+
 SELECT without INTO: https://help.sap.com/doc/abapdocu_731_index_htm/7.31/en-US/abapselect_obsolete.htm
 SELECT COUNT(*) is considered okay
 

package/build/src/rules/prefer_corresponding.js

@@ -0,0 +1,48 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.PreferCorresponding = exports.PreferCorrespondingConf = void 0;
+const issue_1 = require("../issue");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _abap_rule_1 = require("./_abap_rule");
+const Statements = require("../abap/2_statements/statements");
+const _irule_1 = require("./_irule");
+const version_1 = require("../version");
+class PreferCorrespondingConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.PreferCorrespondingConf = PreferCorrespondingConf;
+class PreferCorresponding extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new PreferCorrespondingConf();
+    }
+    getMetadata() {
+        return {
+            key: "prefer_corresponding",
+            title: "Prefer corresponding( ) to MOVE-CORRESPONDING",
+            shortDescription: `Prefer corresponding( ) to MOVE-CORRESPONDING, from v740sp05 and up`,
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Upport],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        if (this.reg.getConfig().getVersion() < version_1.Version.v740sp05) {
+            return issues;
+        }
+        const message = "Use CORRESPONDING type( ... ) instead";
+        for (const stat of file.getStatements()) {
+            if (stat.get() instanceof Statements.MoveCorresponding
+                && stat.getChildren().length === 7) {
+                issues.push(issue_1.Issue.atStatement(file, stat, message, this.getMetadata().key, this.conf.severity));
+            }
+        }
+        return issues;
+    }
+}
+exports.PreferCorresponding = PreferCorresponding;
+//# sourceMappingURL=prefer_corresponding.js.map

package/build/src/rules/select_add_order_by.js

@@ -41,7 +41,7 @@ If the target is a sorted/hashed table, no issue is reported`,
         this.conf = conf;
     }
     run(obj) {
-        var _a, _b, _c;
+        var _a;
         const issues = [];
         if (!(obj instanceof _abap_object_1.ABAPObject) || obj.getType() === "INTF") {
             return [];
@@ -67,21 +67,36 @@ If the target is a sorted/hashed table, no issue is reported`,
                 else if (s.findFirstExpression(Expressions.SQLOrderBy)) {
                     continue;
                 }
-                const target = (_b = s.findFirstExpression(Expressions.SQLIntoTable)) === null || _b === void 0 ? void 0 : _b.findFirstExpression(Expressions.Target);
-                if (target) {
-                    const start = target.getFirstToken().getStart();
-                    const scope = spaghetti.lookupPosition(start, file.getFilename());
-                    const type = (_c = scope === null || scope === void 0 ? void 0 : scope.findWriteReference(start)) === null || _c === void 0 ? void 0 : _c.getType();
-                    if (type instanceof basic_1.TableType
-                        && ((type === null || type === void 0 ? void 0 : type.getAccessType()) === basic_1.TableAccessType.sorted || (type === null || type === void 0 ? void 0 : type.getAccessType()) === basic_1.TableAccessType.hashed)) {
-                        continue;
-                    }
+                if (this.isTargetSortedOrHashed(s, spaghetti, file)) {
+                    continue;
                 }
                 issues.push(issue_1.Issue.atStatement(file, s, "Add ORDER BY", this.getMetadata().key, this.conf.severity));
             }
         }
         return issues;
     }
+    isTargetSortedOrHashed(s, spaghetti, file) {
+        var _a, _b;
+        const target = (_a = s.findFirstExpression(Expressions.SQLIntoTable)) === null || _a === void 0 ? void 0 : _a.findFirstExpression(Expressions.Target);
+        if (target) {
+            const start = target.getFirstToken().getStart();
+            const scope = spaghetti.lookupPosition(start, file.getFilename());
+            let type = (_b = scope === null || scope === void 0 ? void 0 : scope.findWriteReference(start)) === null || _b === void 0 ? void 0 : _b.getType();
+            const children = target.getChildren();
+            if (type instanceof basic_1.StructureType && children.length >= 3 && children[1].concatTokens() === "-") {
+                const found = type.getComponentByName(children[2].concatTokens());
+                if (found === undefined) {
+                    return false;
+                }
+                type = found;
+            }
+            if (type instanceof basic_1.TableType
+                && ((type === null || type === void 0 ? void 0 : type.getAccessType()) === basic_1.TableAccessType.sorted || (type === null || type === void 0 ? void 0 : type.getAccessType()) === basic_1.TableAccessType.hashed)) {
+                return true;
+            }
+        }
+        return false;
+    }
 }
 exports.SelectAddOrderBy = SelectAddOrderBy;
 //# sourceMappingURL=select_add_order_by.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.82.17",
+    "version": "2.83.3",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -48,14 +48,14 @@
         "@microsoft/api-extractor": "^7.19.2",
         "@types/chai": "^4.3.0",
         "@types/mocha": "^9.0.0",
-        "@types/node": "^16.11.12",
+        "@types/node": "^17.0.4",
         "chai": "^4.3.4",
-        "eslint": "^8.4.1",
+        "eslint": "^8.5.0",
         "mocha": "^9.1.3",
         "c8": "^7.10.0",
         "source-map-support": "^0.5.21",
         "ts-json-schema-generator": "^0.97.0",
-        "typescript": "^4.5.3"
+        "typescript": "^4.5.4"
     },
     "dependencies": {
         "fast-xml-parser": "^3.21.1",