@abaplint/core 2.82.15 → 2.83.1

package/build/abaplint.d.ts

@@ -1139,6 +1139,7 @@ declare class DataElement extends AbstractObject {
         allowNamespace: boolean;
     };
     setDirty(): void;
+    getDomainName(): string | undefined;
     parseType(reg: IRegistry): AbstractType;
     parse(): {
         updated: boolean;
@@ -1177,7 +1178,7 @@ declare class DDIC {
     lookupNoVoid(name: string): ILookupResult | undefined;
     /** lookup with voiding and unknown types */
     lookup(name: string): ILookupResult;
-    lookupDomain(name: string): ILookupResult;
+    lookupDomain(name: string, parent?: string): ILookupResult;
     lookupDataElement(name: string | undefined): ILookupResult;
     lookupTableOrView(name: string | undefined): ILookupResult;
     lookupTableOrView2(name: string | undefined): Table | DataDefinition | View | undefined;
@@ -1358,7 +1359,7 @@ declare class Domain extends AbstractObject {
         allowNamespace: boolean;
     };
     setDirty(): void;
-    parseType(reg: IRegistry): AbstractType;
+    parseType(reg: IRegistry, parent?: string): AbstractType;
     parse(): {
         updated: boolean;
         runtime: number;
@@ -2572,10 +2573,14 @@ declare interface IGlobalConfig {
     useApackDependencies?: boolean;
     /** Do not report any issues for includes without main programs */
     skipIncludesWithoutMain?: boolean;
-    /** list of files to exclude, case insensitive regex
+    /** list of files to exclude, these files are not added when running syntax check or any other rules, case insensitive regex
      * @uniqueItems true
      */
     exclude?: string[];
+    /** list of files to not report any issues for, case insensitive regex
+     * @uniqueItems true
+     */
+    noIssues?: string[];
 }
 
 declare interface IImplementing {

package/build/src/abap/2_statements/statements/call_function.js

@@ -9,7 +9,7 @@ class CallFunction {
         const starting = (0, combi_1.seq)("STARTING NEW TASK", expressions_1.SimpleSource2);
         const update = (0, combi_1.str)("IN UPDATE TASK");
         const unit = (0, combi_1.seq)("UNIT", expressions_1.Source);
-        const background = (0, combi_1.seq)("IN BACKGROUND", (0, combi_1.alt)("TASK", unit));
+        const background = (0, combi_1.verNot)(version_1.Version.Cloud, (0, combi_1.seq)("IN BACKGROUND", (0, combi_1.alt)("TASK", unit)));
         const calling = (0, combi_1.seq)("CALLING", expressions_1.MethodName, "ON END OF TASK");
         const performing = (0, combi_1.seq)("PERFORMING", expressions_1.FormName, "ON END OF TASK");
         const separate = (0, combi_1.str)("AS SEPARATE UNIT");

package/build/src/ddic.js

@@ -185,10 +185,10 @@ class DDIC {
             return { type: new Types.VoidType(name) };
         }
     }
-    lookupDomain(name) {
+    lookupDomain(name, parent) {
         const found = this.reg.getObject("DOMA", name);
         if (found) {
-            return { type: found.parseType(this.reg), object: found };
+            return { type: found.parseType(this.reg, parent), object: found };
         }
         else if (this.reg.inErrorNamespace(name)) {
             return { type: new Types.UnknownType(name + ", lookupDomain"), object: undefined };

package/build/src/objects/data_element.js

@@ -26,6 +26,11 @@ class DataElement extends _abstract_object_1.AbstractObject {
         this.parsedXML = undefined;
         super.setDirty();
     }
+    getDomainName() {
+        var _a;
+        this.parse();
+        return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.domname;
+    }
     parseType(reg) {
         const references = [];
         let lookup = undefined;
@@ -39,7 +44,7 @@ class DataElement extends _abstract_object_1.AbstractObject {
                     lookup = { type: new Types.UnknownType("DOMNAME unexpectely empty in " + this.getName()) };
                 }
                 else {
-                    lookup = ddic.lookupDomain(this.parsedXML.domname);
+                    lookup = ddic.lookupDomain(this.parsedXML.domname, this.getName());
                 }
             }
             else if (this.parsedXML.refkind === "R") {

package/build/src/objects/domain.js

@@ -24,7 +24,7 @@ class Domain extends _abstract_object_1.AbstractObject {
         this.parsedType = undefined;
         super.setDirty();
     }
-    parseType(reg) {
+    parseType(reg, parent) {
         if (this.parsedType) {
             return this.parsedType;
         }
@@ -32,7 +32,7 @@ class Domain extends _abstract_object_1.AbstractObject {
             return new Types.UnknownType("Domain " + this.getName() + " parser error", this.getName());
         }
         const ddic = new ddic_1.DDIC(reg);
-        this.parsedType = ddic.textToType(this.parsedXML.datatype, this.parsedXML.length, this.parsedXML.decimals, this.getName());
+        this.parsedType = ddic.textToType(this.parsedXML.datatype, this.parsedXML.length, this.parsedXML.decimals, parent || this.getName(), parent !== undefined);
         return this.parsedType;
     }
     parse() {

package/build/src/objects/table.js

@@ -175,7 +175,7 @@ class Table extends _abstract_object_1.AbstractObject {
                 const length = field.LENG ? field.LENG : field.INTLEN;
                 components.push({
                     name: field.FIELDNAME,
-                    type: ddic.textToType(datatype, length, field.DECIMALS, this.getName())
+                    type: ddic.textToType(datatype, length, field.DECIMALS, this.getName() + "-" + field.FIELDNAME)
                 });
             }
             else {

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.82.15";
+        return "2.83.1";
     }
     getDDICReferences() {
         return this.references;
@@ -326,10 +326,23 @@ class Registry {
     excludeIssues(issues) {
         var _a;
         const ret = issues;
+        const globalNoIssues = this.conf.getGlobal().noIssues || [];
+        const globalNoIssuesPatterns = globalNoIssues.map(x => new RegExp(x, "i"));
+        if (globalNoIssuesPatterns.length > 0) {
+            for (let i = ret.length - 1; i >= 0; i--) {
+                const filename = ret[i].getFilename();
+                if (excludeHelper_1.ExcludeHelper.isExcluded(filename, globalNoIssuesPatterns)) {
+                    ret.splice(i, 1);
+                }
+            }
+        }
         // exclude issues, as now we know both the filename and issue key
         for (const rule of artifacts_rules_1.ArtifactsRules.getRules()) {
             const key = rule.getMetadata().key;
-            const ruleExclude = ((_a = this.conf.readByKey(key, "exclude")) !== null && _a !== void 0 ? _a : []);
+            const ruleExclude = (_a = this.conf.readByKey(key, "exclude")) !== null && _a !== void 0 ? _a : [];
+            if (ruleExclude.length === 0) {
+                continue;
+            }
             const ruleExcludePatterns = ruleExclude.map(x => new RegExp(x, "i"));
             for (let i = ret.length - 1; i >= 0; i--) {
                 if (ret[i].getKey() !== key) {

package/build/src/rules/implement_methods.js

@@ -4,6 +4,7 @@ exports.ImplementMethods = exports.ImplementMethodsConf = void 0;
 const issue_1 = require("../issue");
 const _abap_rule_1 = require("./_abap_rule");
 const _basic_rule_config_1 = require("./_basic_rule_config");
+const objects_1 = require("../objects");
 const Statements = require("../abap/2_statements/statements");
 const Expressions = require("../abap/2_statements/expressions");
 const _irule_1 = require("./_irule");
@@ -22,6 +23,7 @@ class ImplementMethods extends _abap_rule_1.ABAPRule {
             key: "implement_methods",
             title: "Implement methods",
             shortDescription: `Checks for abstract methods and methods from interfaces which need implementing.`,
+            extendedInformation: `INCLUDE programs are only checked in connection with their main programs.`,
             tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Quickfix],
         };
     }
@@ -36,6 +38,9 @@ class ImplementMethods extends _abap_rule_1.ABAPRule {
         if (file.getStructure() === undefined) {
             return [];
         }
+        else if (obj instanceof objects_1.Program && obj.isInclude() === true) {
+            return [];
+        }
         this.obj = obj;
         for (const classDefinition of file.getInfo().listClassDefinitions()) {
             const classImplementation = this.lookupImplementationInObject(classDefinition.name, obj);

package/build/src/rules/index.js

@@ -92,6 +92,7 @@ __exportStar(require("./msag_consistency"), exports);
 __exportStar(require("./names_no_dash"), exports);
 __exportStar(require("./nesting"), exports);
 __exportStar(require("./newline_between_methods"), exports);
+__exportStar(require("./no_aliases"), exports);
 __exportStar(require("./no_chained_assignment"), exports);
 __exportStar(require("./no_public_attributes"), exports);
 __exportStar(require("./no_yoda_conditions"), exports);
@@ -103,6 +104,7 @@ __exportStar(require("./parser_702_chaining"), exports);
 __exportStar(require("./parser_error"), exports);
 __exportStar(require("./parser_missing_space"), exports);
 __exportStar(require("./pragma_placement"), exports);
+__exportStar(require("./prefer_corresponding"), exports);
 __exportStar(require("./prefer_inline"), exports);
 __exportStar(require("./prefer_is_not"), exports);
 __exportStar(require("./prefer_raise_exception_new"), exports);

package/build/src/rules/no_aliases.js

@@ -0,0 +1,43 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.NoAliases = exports.NoAliasesConf = void 0;
+const issue_1 = require("../issue");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _abap_rule_1 = require("./_abap_rule");
+const Statements = require("../abap/2_statements/statements");
+const _irule_1 = require("./_irule");
+class NoAliasesConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.NoAliasesConf = NoAliasesConf;
+class NoAliases extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new NoAliasesConf();
+    }
+    getMetadata() {
+        return {
+            key: "no_aliases",
+            title: "No ALIASES",
+            shortDescription: `Detects use of the ALIAS statement`,
+            tags: [_irule_1.RuleTag.SingleFile],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        const message = "Do not use ALIASES";
+        for (const stat of file.getStatements()) {
+            if (stat.get() instanceof Statements.Aliases) {
+                issues.push(issue_1.Issue.atStatement(file, stat, message, this.getMetadata().key, this.conf.severity));
+            }
+        }
+        return issues;
+    }
+}
+exports.NoAliases = NoAliases;
+//# sourceMappingURL=no_aliases.js.map

package/build/src/rules/obsolete_statement.js

@@ -63,6 +63,8 @@ class ObsoleteStatementConf extends _basic_rule_config_1.BasicRuleConfig {
         this.callTransformation = true;
         /** Check for POSIX REGEX usage */
         this.regex = true;
+        /** Check for OCCURENCES vs OCCURRENCES usage */
+        this.occurences = true;
     }
 }
 exports.ObsoleteStatementConf = ObsoleteStatementConf;
@@ -113,7 +115,9 @@ SORT BY FS: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abapsort_
 
 CALL TRANSFORMATION OBJECTS: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abapcall_transformation_objects.htm
 
-POSIX REGEX: https://help.sap.com/doc/abapdocu_755_index_htm/7.55/en-US/index.htm`,
+POSIX REGEX: https://help.sap.com/doc/abapdocu_755_index_htm/7.55/en-US/index.htm
+
+OCCURENCES: check for OCCURENCES vs OCCURRENCES`,
         };
     }
     getConfig() {
@@ -270,6 +274,13 @@ POSIX REGEX: https://help.sap.com/doc/abapdocu_755_index_htm/7.55/en-US/index.ht
                     issues.push(issue);
                 }
             }
+            if (this.conf.occurences && sta instanceof Statements.Replace) {
+                const concat = staNode.concatTokens().toUpperCase();
+                if (concat.includes(" OCCURENCES ")) {
+                    const issue = issue_1.Issue.atStatement(file, staNode, "Use \"OCCURRENCES\"", this.getMetadata().key, this.conf.severity);
+                    issues.push(issue);
+                }
+            }
             if (configVersion >= version_1.Version.v756 && this.conf.regex) {
                 if (sta instanceof Statements.Find || sta instanceof Statements.Replace) {
                     if ((_c = staNode.findFirstExpression(Expressions.FindType)) === null || _c === void 0 ? void 0 : _c.concatTokens().includes("REGEX")) {

package/build/src/rules/prefer_corresponding.js

@@ -0,0 +1,48 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.PreferCorresponding = exports.PreferCorrespondingConf = void 0;
+const issue_1 = require("../issue");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _abap_rule_1 = require("./_abap_rule");
+const Statements = require("../abap/2_statements/statements");
+const _irule_1 = require("./_irule");
+const version_1 = require("../version");
+class PreferCorrespondingConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.PreferCorrespondingConf = PreferCorrespondingConf;
+class PreferCorresponding extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new PreferCorrespondingConf();
+    }
+    getMetadata() {
+        return {
+            key: "prefer_corresponding",
+            title: "Prefer corresponding( ) to MOVE-CORRESPONDING",
+            shortDescription: `Prefer corresponding( ) to MOVE-CORRESPONDING, from v740sp05 and up`,
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Upport],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        if (this.reg.getConfig().getVersion() < version_1.Version.v740sp05) {
+            return issues;
+        }
+        const message = "Use CORRESPONDING type( ... ) instead";
+        for (const stat of file.getStatements()) {
+            if (stat.get() instanceof Statements.MoveCorresponding
+                && stat.getChildren().length === 7) {
+                issues.push(issue_1.Issue.atStatement(file, stat, message, this.getMetadata().key, this.conf.severity));
+            }
+        }
+        return issues;
+    }
+}
+exports.PreferCorresponding = PreferCorresponding;
+//# sourceMappingURL=prefer_corresponding.js.map

package/build/src/rules/select_add_order_by.js

@@ -41,7 +41,7 @@ If the target is a sorted/hashed table, no issue is reported`,
         this.conf = conf;
     }
     run(obj) {
-        var _a, _b, _c;
+        var _a;
         const issues = [];
         if (!(obj instanceof _abap_object_1.ABAPObject) || obj.getType() === "INTF") {
             return [];
@@ -67,21 +67,36 @@ If the target is a sorted/hashed table, no issue is reported`,
                 else if (s.findFirstExpression(Expressions.SQLOrderBy)) {
                     continue;
                 }
-                const target = (_b = s.findFirstExpression(Expressions.SQLIntoTable)) === null || _b === void 0 ? void 0 : _b.findFirstExpression(Expressions.Target);
-                if (target) {
-                    const start = target.getFirstToken().getStart();
-                    const scope = spaghetti.lookupPosition(start, file.getFilename());
-                    const type = (_c = scope === null || scope === void 0 ? void 0 : scope.findWriteReference(start)) === null || _c === void 0 ? void 0 : _c.getType();
-                    if (type instanceof basic_1.TableType
-                        && ((type === null || type === void 0 ? void 0 : type.getAccessType()) === basic_1.TableAccessType.sorted || (type === null || type === void 0 ? void 0 : type.getAccessType()) === basic_1.TableAccessType.hashed)) {
-                        continue;
-                    }
+                if (this.isTargetSortedOrHashed(s, spaghetti, file)) {
+                    continue;
                 }
                 issues.push(issue_1.Issue.atStatement(file, s, "Add ORDER BY", this.getMetadata().key, this.conf.severity));
             }
         }
         return issues;
     }
+    isTargetSortedOrHashed(s, spaghetti, file) {
+        var _a, _b;
+        const target = (_a = s.findFirstExpression(Expressions.SQLIntoTable)) === null || _a === void 0 ? void 0 : _a.findFirstExpression(Expressions.Target);
+        if (target) {
+            const start = target.getFirstToken().getStart();
+            const scope = spaghetti.lookupPosition(start, file.getFilename());
+            let type = (_b = scope === null || scope === void 0 ? void 0 : scope.findWriteReference(start)) === null || _b === void 0 ? void 0 : _b.getType();
+            const children = target.getChildren();
+            if (type instanceof basic_1.StructureType && children.length >= 3 && children[1].concatTokens() === "-") {
+                const found = type.getComponentByName(children[2].concatTokens());
+                if (found === undefined) {
+                    return false;
+                }
+                type = found;
+            }
+            if (type instanceof basic_1.TableType
+                && ((type === null || type === void 0 ? void 0 : type.getAccessType()) === basic_1.TableAccessType.sorted || (type === null || type === void 0 ? void 0 : type.getAccessType()) === basic_1.TableAccessType.hashed)) {
+                return true;
+            }
+        }
+        return false;
+    }
 }
 exports.SelectAddOrderBy = SelectAddOrderBy;
 //# sourceMappingURL=select_add_order_by.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.82.15",
+    "version": "2.83.1",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -45,17 +45,17 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.18.21",
-        "@types/chai": "^4.2.22",
+        "@microsoft/api-extractor": "^7.19.2",
+        "@types/chai": "^4.3.0",
         "@types/mocha": "^9.0.0",
-        "@types/node": "^16.11.12",
+        "@types/node": "^17.0.1",
         "chai": "^4.3.4",
-        "eslint": "^8.4.1",
+        "eslint": "^8.5.0",
         "mocha": "^9.1.3",
         "c8": "^7.10.0",
         "source-map-support": "^0.5.21",
         "ts-json-schema-generator": "^0.97.0",
-        "typescript": "^4.5.2"
+        "typescript": "^4.5.4"
     },
     "dependencies": {
         "fast-xml-parser": "^3.21.1",