@abaplint/core 2.82.13 → 2.82.14

package/build/abaplint.d.ts

@@ -879,10 +879,7 @@ declare class ConcatenatedConstant extends Expression {
 
 declare class ConceptsOfPackage extends AbstractObject {
     getType(): string;
-    getAllowedNaming(): {
-        maxLength: number;
-        allowNamespace: boolean;
-    };
+    getAllowedNaming(): IAllowedNaming;
     getDescription(): string | undefined;
 }
 
@@ -2347,12 +2344,15 @@ declare interface IAliases {
     getAll(): readonly Alias[];
 }
 
+declare interface IAllowedNaming {
+    maxLength: number;
+    allowNamespace: boolean;
+    customRegex?: RegExp;
+}
+
 declare interface IArtifact {
     getType(): string;
-    getAllowedNaming(): {
-        maxLength: number;
-        allowNamespace: boolean;
-    };
+    getAllowedNaming(): IAllowedNaming;
 }
 
 declare interface IAttributes {
@@ -3608,10 +3608,7 @@ declare class Multiply implements IStatement {
 
 declare class Namespace extends AbstractObject {
     getType(): string;
-    getAllowedNaming(): {
-        maxLength: number;
-        allowNamespace: boolean;
-    };
+    getAllowedNaming(): IAllowedNaming;
     getDescription(): string | undefined;
 }
 
@@ -5911,10 +5908,7 @@ declare class WebDynproComponentConfiguration extends AbstractObject {
 
 declare class WebMIME extends AbstractObject {
     getType(): string;
-    getAllowedNaming(): {
-        maxLength: number;
-        allowNamespace: boolean;
-    };
+    getAllowedNaming(): IAllowedNaming;
     getDescription(): string | undefined;
 }
 

package/build/src/abap/5_syntax/statements/get_badi.js

@@ -7,7 +7,7 @@ const target_1 = require("../expressions/target");
 const dynamic_1 = require("../expressions/dynamic");
 class GetBadi {
     runSyntax(node, scope, filename) {
-        for (const s of node.findDirectExpressions(Expressions.Source)) {
+        for (const s of node.findAllExpressions(Expressions.Source)) {
             new source_1.Source().runSyntax(s, scope, filename);
         }
         for (const t of node.findDirectExpressions(Expressions.Target)) {

package/build/src/objects/concepts_of_package.js

@@ -10,6 +10,7 @@ class ConceptsOfPackage extends _abstract_object_1.AbstractObject {
         return {
             maxLength: 30,
             allowNamespace: true,
+            customRegex: new RegExp(/^(\/[A-Z_\d]{3,8}\/)?[A-Z_-\d<> ]+$/i),
         };
     }
     getDescription() {

package/build/src/objects/namespace.js

@@ -10,6 +10,7 @@ class Namespace extends _abstract_object_1.AbstractObject {
         return {
             maxLength: 10,
             allowNamespace: true,
+            customRegex: new RegExp(/^\/[A-Z_\d]{3,8}\/$/i),
         };
     }
     getDescription() {

package/build/src/objects/web_mime.js

@@ -10,6 +10,7 @@ class WebMIME extends _abstract_object_1.AbstractObject {
         return {
             maxLength: 40,
             allowNamespace: true,
+            customRegex: new RegExp(/^[A-Z_-\d/<> ]+$/i),
         };
     }
     getDescription() {

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.82.13";
+        return "2.82.14";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/allowed_object_naming.js

@@ -30,19 +30,20 @@ class AllowedObjectNaming {
     }
     run(obj) {
         const allowed = obj.getAllowedNaming();
+        const name = obj.getName();
         let message = "";
-        if (obj.getName().length > allowed.maxLength) {
+        if (name.length > allowed.maxLength) {
             message = "Name exceeds max length";
         }
-        else if (allowed.allowNamespace === false && obj.getName().indexOf("/") >= 0) {
+        else if (allowed.allowNamespace === false && name.indexOf("/") >= 0) {
             message = "Namespace not allowed for object type";
         }
-        else if (obj.getType() === "NSPC") {
-            if (obj.getName().match(/^\/[A-Z_\d]{3,8}\/$/i) === null) {
+        else if (allowed.customRegex !== undefined) {
+            if (name.match(allowed.customRegex) === null) {
                 message = "Name not allowed";
             }
         }
-        else if (obj.getName().match(/^(\/[A-Z_\d]{3,8}\/)?[A-Z_-\d<> ]+$/i) === null) {
+        else if (name.match(/^(\/[A-Z_\d]{3,8}\/)?[A-Z_\d<> ]+$/i) === null) {
             message = "Name not allowed";
         }
         if (message.length > 0) {

package/build/src/rules/unnecessary_chaining.js

@@ -5,6 +5,7 @@ const issue_1 = require("../issue");
 const _abap_rule_1 = require("./_abap_rule");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const _irule_1 = require("./_irule");
+const edit_helper_1 = require("../edit_helper");
 class UnnecessaryChainingConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.UnnecessaryChainingConf = UnnecessaryChainingConf;
@@ -19,7 +20,7 @@ class UnnecessaryChaining extends _abap_rule_1.ABAPRule {
             title: "Unnecessary Chaining",
             shortDescription: `Find unnecessary chaining, all statements are checked`,
             extendedInformation: ``,
-            tags: [_irule_1.RuleTag.SingleFile],
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
             badExample: `WRITE: bar.`,
             goodExample: `WRITE bar.`,
         };
@@ -47,8 +48,9 @@ class UnnecessaryChaining extends _abap_rule_1.ABAPRule {
             else if (prev !== undefined && colon.getStart().equals(prev.getStart())) {
                 continue;
             }
+            const fix = edit_helper_1.EditHelper.deleteRange(file, colon.getStart(), colon.getEnd());
             const message = "Unnecessary chaining";
-            const issue = issue_1.Issue.atStatement(file, statements[i], message, this.getMetadata().key);
+            const issue = issue_1.Issue.atStatement(file, statements[i], message, this.getMetadata().key, this.conf.severity, fix);
             issues.push(issue);
         }
         return issues;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.82.13",
+    "version": "2.82.14",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -50,7 +50,7 @@
         "@types/mocha": "^9.0.0",
         "@types/node": "^16.11.11",
         "chai": "^4.3.4",
-        "eslint": "^8.3.0",
+        "eslint": "^8.4.0",
         "mocha": "^9.1.3",
         "c8": "^7.10.0",
         "source-map-support": "^0.5.21",