@abaplint/core 2.80.10 → 2.81.0

package/build/src/abap/2_statements/statements/move.js

@@ -10,9 +10,10 @@ class Move {
         const mov = (0, combi_1.verNot)(version_1.Version.Cloud, "MOVE");
         const move = (0, combi_1.seq)(mov, (0, combi_1.altPrio)((0, combi_1.seq)("EXACT", expressions_1.Source, "TO", expressions_1.Target), (0, combi_1.seq)(expressions_1.Source, (0, combi_1.altPrio)("?TO", "TO"), expressions_1.Target)));
         const calcAssign = (0, combi_1.ver)(version_1.Version.v754, (0, combi_1.alt)((0, combi_1.seq)((0, combi_1.tok)(tokens_1.WPlus), "="), (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WDash), "="), "/=", "*=", "&&="));
-        const equals = (0, combi_1.altPrio)((0, combi_1.altPrio)("=", "?="), calcAssign);
+        const chained = (0, combi_1.seq)("=", (0, combi_1.star)((0, combi_1.seq)(expressions_1.Target, "=")));
+        const equals = (0, combi_1.altPrio)((0, combi_1.altPrio)(chained, "?="), calcAssign);
         // todo, move "?=" to CAST?
-        const eq = (0, combi_1.seq)((0, combi_1.plus)((0, combi_1.seq)(expressions_1.Target, equals)), expressions_1.Source);
+        const eq = (0, combi_1.seq)(expressions_1.Target, equals, expressions_1.Source);
         return (0, combi_1.altPrio)(move, eq);
     }
 }

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.80.10";
+        return "2.81.0";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/index.js

@@ -92,6 +92,7 @@ __exportStar(require("./msag_consistency"), exports);
 __exportStar(require("./names_no_dash"), exports);
 __exportStar(require("./nesting"), exports);
 __exportStar(require("./newline_between_methods"), exports);
+__exportStar(require("./no_chained_assignment"), exports);
 __exportStar(require("./no_public_attributes"), exports);
 __exportStar(require("./no_yoda_conditions"), exports);
 __exportStar(require("./object_naming"), exports);
@@ -131,6 +132,7 @@ __exportStar(require("./type_form_parameters"), exports);
 __exportStar(require("./types_naming"), exports);
 __exportStar(require("./uncaught_exception"), exports);
 __exportStar(require("./unknown_types"), exports);
+__exportStar(require("./unnecessary_chaining"), exports);
 __exportStar(require("./unreachable_code"), exports);
 __exportStar(require("./unsecure_fae"), exports);
 __exportStar(require("./unused_ddic"), exports);

package/build/src/rules/no_chained_assignment.js

@@ -0,0 +1,56 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.NoChainedAssignment = exports.NoChainedAssignmentConf = void 0;
+const Expressions = require("../abap/2_statements/expressions");
+const Statements = require("../abap/2_statements/statements");
+const issue_1 = require("../issue");
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+class NoChainedAssignmentConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        this.onlyConstants = false;
+    }
+}
+exports.NoChainedAssignmentConf = NoChainedAssignmentConf;
+class NoChainedAssignment extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new NoChainedAssignmentConf();
+    }
+    getMetadata() {
+        return {
+            key: "no_chained_assignment",
+            title: "No chained assignment",
+            shortDescription: `Find chained assingments and reports issues`,
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#dont-chain-assignments`,
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide],
+            badExample: `var1 = var2 = var3.`,
+            goodExample: `var2 = var3.
+var1 = var3.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        for (const s of file.getStatements()) {
+            if (!(s.get() instanceof Statements.Move)) {
+                continue;
+            }
+            if (s.findDirectExpressions(Expressions.Target).length >= 2) {
+                const message = "No chained assignment";
+                const issue = issue_1.Issue.atStatement(file, s, message, this.getMetadata().key);
+                issues.push(issue);
+            }
+        }
+        return issues;
+    }
+}
+exports.NoChainedAssignment = NoChainedAssignment;
+//# sourceMappingURL=no_chained_assignment.js.map

package/build/src/rules/prefer_inline.js

@@ -74,7 +74,7 @@ DATA(percentage) = CONV decfloat34( comment_number / abs_statement_number ) * 10
     }
     ///////////////////////////
     analyzeScope(node, obj) {
-        var _a;
+        var _a, _b;
         const ret = [];
         const vars = node.getData().vars;
         for (const name in vars) {
@@ -113,7 +113,8 @@ DATA(percentage) = CONV decfloat34( comment_number / abs_statement_number ) * 10
                 || statementType instanceof Statements.Catch
                 || statementType instanceof Statements.ReadTable
                 || statementType instanceof Statements.Loop)
-                || ((_a = writeStatement === null || writeStatement === void 0 ? void 0 : writeStatement.concatTokens()) === null || _a === void 0 ? void 0 : _a.includes("?="))) {
+                || ((_a = writeStatement === null || writeStatement === void 0 ? void 0 : writeStatement.concatTokens()) === null || _a === void 0 ? void 0 : _a.includes("?="))
+                || ((_b = writeStatement === null || writeStatement === void 0 ? void 0 : writeStatement.concatTokens()) === null || _b === void 0 ? void 0 : _b.includes(" #("))) {
                 continue;
             }
             const statement = edit_helper_1.EditHelper.findStatement(identifier.getToken(), file);

package/build/src/rules/unnecessary_chaining.js

@@ -0,0 +1,62 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.UnnecessaryChaining = exports.UnnecessaryChainingConf = void 0;
+const issue_1 = require("../issue");
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+class UnnecessaryChainingConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        this.onlyConstants = false;
+    }
+}
+exports.UnnecessaryChainingConf = UnnecessaryChainingConf;
+class UnnecessaryChaining extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new UnnecessaryChainingConf();
+    }
+    getMetadata() {
+        return {
+            key: "unnecessary_chaining",
+            title: "Unnecessary Chaining",
+            shortDescription: `Find unnecessary chaining, all statements are checked`,
+            extendedInformation: ``,
+            tags: [_irule_1.RuleTag.SingleFile],
+            badExample: `WRITE: bar.`,
+            goodExample: `WRITE bar.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        var _a, _b;
+        const issues = [];
+        const statements = file.getStatements();
+        for (let i = 0; i < statements.length; i++) {
+            const colon = statements[i].getColon();
+            if (colon === undefined) {
+                continue;
+            }
+            const next = (_a = statements[i + 1]) === null || _a === void 0 ? void 0 : _a.getColon();
+            const prev = (_b = statements[i - 1]) === null || _b === void 0 ? void 0 : _b.getColon();
+            if (next !== undefined && colon.getStart().equals(next.getStart())) {
+                continue;
+            }
+            else if (prev !== undefined && colon.getStart().equals(prev.getStart())) {
+                continue;
+            }
+            const message = "Unnecessary chaining";
+            const issue = issue_1.Issue.atStatement(file, statements[i], message, this.getMetadata().key);
+            issues.push(issue);
+        }
+        return issues;
+    }
+}
+exports.UnnecessaryChaining = UnnecessaryChaining;
+//# sourceMappingURL=unnecessary_chaining.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.80.10",
+    "version": "2.81.0",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -13,6 +13,7 @@
         "test:parallel": "npm run compile && mocha --timeout 1000 --parallel --reporter dot",
         "coverage": "npm run compile && c8 mocha && c8 report --reporter=html",
         "schema": "node scripts/schema.js > scripts/schema.ts && ts-json-schema-generator --tsconfig tsconfig_schema.json --jsDoc extended --path scripts/schema.ts > scripts/schema.json && node scripts/schema_post.js",
+        "publish:minor": "npm --no-git-tag-version version minor && rm -rf build && npm install && npm run test && npm publish --access public",
         "publish:patch": "npm --no-git-tag-version version patch && rm -rf build && npm install && npm run test && npm publish --access public"
     },
     "mocha": {