@abaplint/core 2.80.0 → 2.80.4

package/README.md

@@ -1,7 +1,7 @@
-# @abaplint/core
-
-[abaplint](https://abaplint.org/) core library
-
-Exposes functionallity like the parser and rules, which can be used in other projects.
-
+# @abaplint/core
+
+[abaplint](https://abaplint.org/) core library
+
+Exposes functionallity like the parser and rules, which can be used in other projects.
+
 For more information see https://github.com/abaplint/abaplint

package/build/src/abap/2_statements/statements/replace.js

@@ -7,7 +7,7 @@ class Replace {
     getMatcher() {
         const length = (0, combi_1.seq)("LENGTH", expressions_1.Source);
         const offset = (0, combi_1.seq)("OFFSET", expressions_1.Source);
-        const section = (0, combi_1.seq)((0, combi_1.opt)("IN"), "SECTION", (0, combi_1.per)(offset, length), "OF", expressions_1.Source);
+        const section = (0, combi_1.seq)((0, combi_1.opt)("IN"), "SECTION", (0, combi_1.per)(offset, length), "OF", expressions_1.Target);
         const source = (0, combi_1.seq)((0, combi_1.opt)("OF"), expressions_1.FindType, expressions_1.Source);
         const cas = (0, combi_1.alt)("IGNORING CASE", "RESPECTING CASE");
         const repl = (0, combi_1.seq)("REPLACEMENT COUNT", expressions_1.Target);

package/build/src/abap/5_syntax/basic_types.js

@@ -455,6 +455,7 @@ class BasicTypes {
                 // lookup in local and global scope
                 const obj = this.scope.findObjectDefinition(className);
                 if (obj === undefined && this.scope.getDDIC().inErrorNamespace(className) === false) {
+                    this.scope.addReference(expr.getFirstToken(), undefined, _reference_1.ReferenceType.ObjectOrientedVoidReference, this.filename, { ooName: className.toUpperCase() });
                     return new Types.VoidType(className);
                 }
                 else if (obj === undefined) {

package/build/src/abap/flow/statement_flow.js

@@ -1,14 +1,23 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.StatementFlow = exports.dumpFlow = void 0;
+exports.StatementFlow = exports.dumpFlows = exports.dumpFlowsWithDescription = void 0;
 const nodes_1 = require("../nodes");
 const Structures = require("../3_structures/structures");
 const Statements = require("../2_statements/statements");
-function dumpFlow(flows) {
+const Expressions = require("../2_statements/expressions");
+function dumpFlowsWithDescription(flows) {
+    let ret = "";
+    for (const f of flows) {
+        ret += f.description + ": [" + f.statements.map(b => b === null || b === void 0 ? void 0 : b.get().constructor.name).join(",") + "]\n";
+    }
+    return ret.trim();
+}
+exports.dumpFlowsWithDescription = dumpFlowsWithDescription;
+function dumpFlows(flows) {
     const ret = "[" + flows.map(f => "[" + f.statements.map(b => b === null || b === void 0 ? void 0 : b.get().constructor.name).join(",") + "]").join(",");
     return ret + "]";
 }
-exports.dumpFlow = dumpFlow;
+exports.dumpFlows = dumpFlows;
 function findBody(f) {
     var _a;
     return ((_a = f.findDirectStructure(Structures.Body)) === null || _a === void 0 ? void 0 : _a.getChildren()) || [];
@@ -52,14 +61,21 @@ function pruneByStatement(flows, type) {
 ////////////////////////////////////////////////////////////////
 class StatementFlow {
     build(stru) {
+        var _a, _b;
         const ret = [];
         const forms = stru.findAllStructures(Structures.Form);
         for (const f of forms) {
-            ret.push(...this.traverseBody(findBody(f)));
+            let body = this.traverseBody(findBody(f));
+            const formName = (_a = f.findFirstExpression(Expressions.FormName)) === null || _a === void 0 ? void 0 : _a.concatTokens();
+            body = body.map((b) => { return { description: "FORM " + formName, statements: b.statements }; });
+            ret.push(...body);
         }
         const methods = stru.findAllStructures(Structures.Method);
         for (const f of methods) {
-            ret.push(...this.traverseBody(findBody(f)));
+            let body = this.traverseBody(findBody(f));
+            const methodName = (_b = f.findFirstExpression(Expressions.MethodName)) === null || _b === void 0 ? void 0 : _b.concatTokens();
+            body = body.map((b) => { return { description: "METHOD " + methodName, statements: b.statements }; });
+            ret.push(...body);
         }
         return ret;
     }

package/build/src/abap/types/method_definition.js

@@ -49,7 +49,13 @@ class MethodDefinition extends _identifier_1.Identifier {
             this.raising.push(name);
             const clas = scope.findClassDefinition(name);
             if (clas) {
-                scope.addReference(token, clas, _reference_1.ReferenceType.ObjectOrientedReference, filename);
+                scope.addReference(token, clas, _reference_1.ReferenceType.ObjectOrientedReference, filename, { ooName: name.toUpperCase(), ooType: "CLAS" });
+            }
+            else if (scope.getDDIC().inErrorNamespace(name) === false) {
+                scope.addReference(token, clas, _reference_1.ReferenceType.ObjectOrientedVoidReference, filename, { ooName: name.toUpperCase(), ooType: "CLAS" });
+            }
+            else {
+                scope.addReference(token, clas, _reference_1.ReferenceType.ObjectOrientedUnknownReference, filename, { ooName: name.toUpperCase(), ooType: "CLAS" });
             }
         }
         this.visibility = visibility;

package/build/src/lsp/help.js

@@ -9,13 +9,13 @@ const dump_scope_1 = require("./dump_scope");
 class Help {
     static find(reg, textDocument, position) {
         let content = "";
-        content = `
-    <a href="#_tokens" rel="no-refresh">Tokens</a> |
-    <a href="#_statements" rel="no-refresh">Statements</a> |
-    <a href="#_structure" rel="no-refresh">Structure</a> |
-    <a href="#_files" rel="no-refresh">Files</a> |
-    <a href="#_info" rel="no-refresh">Info Dump</a>
-    <hr>
+        content = `
+    <a href="#_tokens" rel="no-refresh">Tokens</a> |
+    <a href="#_statements" rel="no-refresh">Statements</a> |
+    <a href="#_structure" rel="no-refresh">Structure</a> |
+    <a href="#_files" rel="no-refresh">Files</a> |
+    <a href="#_info" rel="no-refresh">Info Dump</a>
+    <hr>
     ` +
             "<tt>" + textDocument.uri + " (" +
             (position.line + 1) + ", " +

package/build/src/lsp/language_server.js

@@ -121,7 +121,7 @@ class LanguageServer {
         if (stru === undefined) {
             return "empty structure";
         }
-        return (0, statement_flow_1.dumpFlow)(new statement_flow_1.StatementFlow().build(stru)).replace(/\],\[/, "],\n[");
+        return (0, statement_flow_1.dumpFlowsWithDescription)(new statement_flow_1.StatementFlow().build(stru)).replace(/\],\[/, "],\n[");
     }
 }
 exports.LanguageServer = LanguageServer;

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.80.0";
+        return "2.80.4";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/abapdoc.js

@@ -23,7 +23,7 @@ class Abapdoc extends _abap_rule_1.ABAPRule {
         return {
             key: "abapdoc",
             title: "Check abapdoc",
-            shortDescription: `Various checks regarding abapdoc.
+            shortDescription: `Various checks regarding abapdoc.
 Base rule checks for existence of abapdoc for public class methods and all interface methods.`,
             tags: [_irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/align_parameters.js

@@ -6,6 +6,7 @@ const Expressions = require("../abap/2_statements/expressions");
 const _abap_rule_1 = require("./_abap_rule");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const _irule_1 = require("./_irule");
+const __1 = require("..");
 class AlignParametersConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.AlignParametersConf = AlignParametersConf;
@@ -18,17 +19,44 @@ class AlignParameters extends _abap_rule_1.ABAPRule {
         return {
             key: "align_parameters",
             title: "Align Parameters",
-            shortDescription: `Checks for aligned parameters in function module calls.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters`,
-            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide],
-            badExample: `CALL FUNCTION 'FOOBAR'
-  EXPORTING
-    foo = 2
-    parameter = 3.`,
-            goodExample: `CALL FUNCTION 'FOOBAR'
-  EXPORTING
-    foo       = 2
-    parameter = 3.`,
+            shortDescription: `Checks for vertially aligned parameters`,
+            extendedInformation: `Checks:
+* function module calls
+* method calls
+* VALUE constructors
+* NEW constructors
+* RAISE EXCEPTION statements
+* CREATE OBJECT statements
+* RAISE EVENT statements
+
+https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
+
+Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
+
+Also https://rules.abaplint.org/max_one_method_parameter_per_line/ can help aligning parameter syntax`,
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide],
+            badExample: `CALL FUNCTION 'FOOBAR'
+  EXPORTING
+    foo = 2
+    parameter = 3.
+
+foobar( moo = 1
+  param = 1 ).
+
+foo = VALUE #(
+    foo = bar
+        moo = 2 ).`,
+            goodExample: `CALL FUNCTION 'FOOBAR'
+  EXPORTING
+    foo       = 2
+    parameter = 3.
+
+foobar( moo   = 1
+        param = 1 ).
+
+foo = VALUE #(
+    foo = bar
+    moo = 2 ).`,
         };
     }
     getConfig() {
@@ -45,11 +73,10 @@ class AlignParameters extends _abap_rule_1.ABAPRule {
         }
         const candidates = [];
         candidates.push(...this.functionParameterCandidates(stru));
-        /* TODO,
-        stru.findAllExpressionsRecursive(Expressions.MethodCallParam);
-        stru.findAllExpressionsRecursive(Expressions.MethodParameters);
-        stru.findAllExpressionsRecursive(Expressions.ValueBody);
-        */
+        candidates.push(...this.methodCallParamCandidates(stru));
+        candidates.push(...this.valueBodyCandidates(stru));
+        candidates.push(...this.raiseAndCreateCandidates(stru));
+        candidates.push(...this.newCandidates(stru));
         for (const c of candidates) {
             const i = this.checkCandidate(c, file);
             if (i) {
@@ -71,13 +98,176 @@ class AlignParameters extends _abap_rule_1.ABAPRule {
         }
         for (const p of candidate.parameters) {
             if (p.eq.getCol() !== expectedEqualsColumn) {
-                const pos = candidate.parameters[0].eq;
                 const message = "Align parameters to column " + expectedEqualsColumn;
-                return issue_1.Issue.atPosition(file, pos, message, this.getMetadata().key);
+                return issue_1.Issue.atPosition(file, p.eq, message, this.getMetadata().key);
             }
         }
         return undefined;
     }
+    newCandidates(stru) {
+        const candidates = [];
+        for (const vb of stru.findAllExpressionsRecursive(Expressions.NewObject)) {
+            const parameters = [];
+            const fieldAssignments = vb.findDirectExpressions(Expressions.FieldAssignment);
+            if (fieldAssignments.length >= 2) {
+                for (const fs of fieldAssignments) {
+                    const children = fs.getChildren();
+                    if (children.length < 3) {
+                        continue; // unexpected
+                    }
+                    parameters.push({
+                        left: children[0],
+                        eq: children[1].getFirstToken().getStart(),
+                        right: children[2],
+                    });
+                }
+                if (parameters.length > 0) {
+                    candidates.push({ parameters });
+                    continue;
+                }
+            }
+            const list = vb.findDirectExpression(Expressions.ParameterListS);
+            if (list) {
+                for (const c of list.getChildren()) {
+                    const children = c.getChildren();
+                    if (children.length < 3) {
+                        continue; // unexpected
+                    }
+                    parameters.push({
+                        left: children[0],
+                        eq: children[1].getFirstToken().getStart(),
+                        right: children[2],
+                    });
+                }
+                if (parameters.length > 0) {
+                    candidates.push({ parameters });
+                }
+            }
+        }
+        return candidates;
+    }
+    valueBodyCandidates(stru) {
+        const candidates = [];
+        for (const vb of stru.findAllExpressionsRecursive(Expressions.ValueBody)) {
+            const parameters = [];
+            const fieldAssignments = vb.findDirectExpressions(Expressions.FieldAssignment);
+            if (fieldAssignments.length <= 1) {
+                continue;
+            }
+            for (const fs of fieldAssignments) {
+                const children = fs.getChildren();
+                if (children.length < 3) {
+                    continue; // unexpected
+                }
+                parameters.push({
+                    left: children[0],
+                    eq: children[1].getFirstToken().getStart(),
+                    right: children[2],
+                });
+            }
+            if (parameters.length > 0) {
+                candidates.push({ parameters });
+            }
+        }
+        return candidates;
+    }
+    raiseAndCreateCandidates(stru) {
+        const candidates = [];
+        const statements = stru.findAllStatements(__1.Statements.Raise);
+        statements.push(...stru.findAllStatements(__1.Statements.CreateObject));
+        statements.push(...stru.findAllStatements(__1.Statements.RaiseEvent));
+        for (const raise of statements) {
+            const parameters = [];
+            const param = raise.findDirectExpression(Expressions.ParameterListS);
+            for (const p of (param === null || param === void 0 ? void 0 : param.getChildren()) || []) {
+                const children = p.getChildren();
+                if (children.length < 3) {
+                    continue; // unexpected
+                }
+                parameters.push({
+                    left: children[0],
+                    eq: children[1].getFirstToken().getStart(),
+                    right: children[2],
+                });
+            }
+            if (parameters.length > 0) {
+                candidates.push({ parameters });
+            }
+        }
+        return candidates;
+    }
+    methodCallParamCandidates(stru) {
+        var _a, _b, _c;
+        const candidates = [];
+        for (const mcp of stru.findAllExpressionsRecursive(Expressions.MethodCallParam)) {
+            const parameters = [];
+            for (const param of ((_a = mcp.findDirectExpression(Expressions.ParameterListS)) === null || _a === void 0 ? void 0 : _a.getChildren()) || []) {
+                const children = param.getChildren();
+                if (children.length < 3) {
+                    continue; // unexpected
+                }
+                parameters.push({
+                    left: children[0],
+                    eq: children[1].getFirstToken().getStart(),
+                    right: children[2],
+                });
+            }
+            const mp = mcp.findDirectExpression(Expressions.MethodParameters);
+            if (mp) {
+                for (const p of ((_b = mp.findDirectExpression(Expressions.ParameterListS)) === null || _b === void 0 ? void 0 : _b.getChildren()) || []) {
+                    const children = p.getChildren();
+                    if (children.length < 3) {
+                        continue; // unexpected
+                    }
+                    parameters.push({
+                        left: children[0],
+                        eq: children[1].getFirstToken().getStart(),
+                        right: children[2],
+                    });
+                }
+                for (const l of mp.findDirectExpressions(Expressions.ParameterListT)) {
+                    for (const p of l.findDirectExpressions(Expressions.ParameterT) || []) {
+                        const children = p.getChildren();
+                        if (children.length < 3) {
+                            continue; // unexpected
+                        }
+                        parameters.push({
+                            left: children[0],
+                            eq: children[1].getFirstToken().getStart(),
+                            right: children[2],
+                        });
+                    }
+                }
+                const rec = mp.findDirectExpression(Expressions.ParameterT);
+                if (rec) {
+                    const children = rec.getChildren();
+                    if (children.length < 3) {
+                        continue; // unexpected
+                    }
+                    parameters.push({
+                        left: children[0],
+                        eq: children[1].getFirstToken().getStart(),
+                        right: children[2],
+                    });
+                }
+                for (const ex of ((_c = mp.findDirectExpression(Expressions.ParameterListExceptions)) === null || _c === void 0 ? void 0 : _c.getChildren()) || []) {
+                    const children = ex.getChildren();
+                    if (children.length < 3) {
+                        continue; // unexpected
+                    }
+                    parameters.push({
+                        left: children[0],
+                        eq: children[1].getFirstToken().getStart(),
+                        right: children[2],
+                    });
+                }
+            }
+            if (parameters.length > 0) {
+                candidates.push({ parameters });
+            }
+        }
+        return candidates;
+    }
     functionParameterCandidates(stru) {
         const candidates = [];
         for (const fp of stru.findAllExpressionsRecursive(Expressions.FunctionParameters)) {

package/build/src/rules/ambiguous_statement.js

@@ -20,14 +20,14 @@ class AmbiguousStatement extends _abap_rule_1.ABAPRule {
         return {
             key: "ambiguous_statement",
             title: "Check for ambigious statements",
-            shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
-Add "TABLE" keyword or "@" for escaping SQL variables
-
+            shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
+Add "TABLE" keyword or "@" for escaping SQL variables
+
 Only works if the target version is 740sp05 or above`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `DELETE foo FROM bar.
+            badExample: `DELETE foo FROM bar.
 MODIFY foo FROM bar.`,
-            goodExample: `DELETE foo FROM @bar.
+            goodExample: `DELETE foo FROM @bar.
 MODIFY TABLE foo FROM bar.`,
         };
     }

package/build/src/rules/avoid_use.js

@@ -35,12 +35,12 @@ class AvoidUse extends _abap_rule_1.ABAPRule {
             key: "avoid_use",
             title: "Avoid use of certain statements",
             shortDescription: `Detects usage of certain statements.`,
-            extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
-
-Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
-
-STATICS: use CLASS-DATA instead
-
+            extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
+
+Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
+
+STATICS: use CLASS-DATA instead
+
 DESCRIBE TABLE LINES: use lines() instead (quickfix exists)`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/begin_end_names.js

@@ -23,11 +23,11 @@ class BeginEndNames extends _abap_rule_1.ABAPRule {
             title: "Check BEGIN END names",
             shortDescription: `Check BEGIN OF and END OF names match, plus there must be statements between BEGIN and END`,
             tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
-            badExample: `DATA: BEGIN OF stru,
-      field TYPE i,
+            badExample: `DATA: BEGIN OF stru,
+      field TYPE i,
     END OF structure_not_the_same.`,
-            goodExample: `DATA: BEGIN OF stru,
-      field TYPE i,
+            goodExample: `DATA: BEGIN OF stru,
+      field TYPE i,
     END OF stru.`,
         };
     }

package/build/src/rules/begin_single_include.js

@@ -21,19 +21,19 @@ class BeginSingleInclude extends _abap_rule_1.ABAPRule {
             title: "BEGIN contains single INCLUDE",
             shortDescription: `Finds TYPE BEGIN with just one INCLUDE TYPE, and DATA with single INCLUDE STRUCTURE`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `TYPES: BEGIN OF dummy1.
-  INCLUDE TYPE dselc.
-TYPES: END OF dummy1.
-
-DATA BEGIN OF foo.
-INCLUDE STRUCTURE syst.
-DATA END OF foo.
-
-STATICS BEGIN OF bar.
-INCLUDE STRUCTURE syst.
+            badExample: `TYPES: BEGIN OF dummy1.
+  INCLUDE TYPE dselc.
+TYPES: END OF dummy1.
+
+DATA BEGIN OF foo.
+INCLUDE STRUCTURE syst.
+DATA END OF foo.
+
+STATICS BEGIN OF bar.
+INCLUDE STRUCTURE syst.
 STATICS END OF bar.`,
-            goodExample: `DATA BEGIN OF foo.
-INCLUDE STRUCTURE dselc.
+            goodExample: `DATA BEGIN OF foo.
+INCLUDE STRUCTURE dselc.
 DATA END OF foo.`,
         };
     }

package/build/src/rules/call_transaction_authority_check.js

@@ -24,9 +24,9 @@ class CallTransactionAuthorityCheck extends _abap_rule_1.ABAPRule {
             extendedInformation: `https://docs.abapopenchecks.org/checks/54/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
             badExample: `CALL TRANSACTION 'FOO'.`,
-            goodExample: `TRY.
-    CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.
-  CATCH cx_sy_authorization_error.
+            goodExample: `TRY.
+    CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.
+  CATCH cx_sy_authorization_error.
 ENDTRY.`,
         };
     }

package/build/src/rules/chain_mainly_declarations.js

@@ -45,10 +45,10 @@ class ChainMainlyDeclarations extends _abap_rule_1.ABAPRule {
             key: "chain_mainly_declarations",
             title: "Chain mainly declarations",
             shortDescription: `Chain mainly declarations, allows chaining for the configured statements, reports errors for other statements.`,
-            extendedInformation: `
-https://docs.abapopenchecks.org/checks/23/
-
-https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
+            extendedInformation: `
+https://docs.abapopenchecks.org/checks/23/
+
+https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
 `,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
             badExample: `CALL METHOD: bar.`,

package/build/src/rules/check_abstract.js

@@ -23,8 +23,8 @@ class CheckAbstract extends _abap_rule_1.ABAPRule {
         return {
             key: "check_abstract",
             title: "Check abstract methods and classes",
-            shortDescription: `Checks abstract methods and classes:
-- class defined as abstract and final,
+            shortDescription: `Checks abstract methods and classes:
+- class defined as abstract and final,
 - non-abstract class contains abstract methods`,
             extendedInformation: `If a class defines only constants, use an interface instead`,
             tags: [_irule_1.RuleTag.SingleFile],

package/build/src/rules/check_comments.js

@@ -27,9 +27,9 @@ class CheckComments extends _abap_rule_1.ABAPRule {
         return {
             key: "check_comments",
             title: "Check Comments",
-            shortDescription: `
-Various checks for comment usage.
-
+            shortDescription: `
+Various checks for comment usage.
+
 * End of line comments. Comments starting with "#EC" or "##" are ignored`,
             extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#put-comments-before-the-statement-they-relate-to`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],

package/build/src/rules/check_include.js

@@ -17,9 +17,9 @@ class CheckInclude {
             key: "check_include",
             title: "Check INCLUDEs",
             shortDescription: `Checks INCLUDE statements`,
-            extendedInformation: `
-* Reports unused includes
-* Errors if the includes are not found
+            extendedInformation: `
+* Reports unused includes
+* Errors if the includes are not found
 * Error if including a main program`,
             tags: [_irule_1.RuleTag.Syntax],
         };

package/build/src/rules/check_no_handler_pragma.js

@@ -21,15 +21,15 @@ class CheckNoHandlerPragma extends _abap_rule_1.ABAPRule {
             title: "Check if NO_HANDLER can be removed",
             shortDescription: `Checks NO_HANDLER pragmas that can be removed`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `TRY.
-    ...
-  CATCH zcx_abapgit_exception ##NO_HANDLER.
-    RETURN. " it has a handler
+            badExample: `TRY.
+    ...
+  CATCH zcx_abapgit_exception ##NO_HANDLER.
+    RETURN. " it has a handler
 ENDTRY.`,
-            goodExample: `TRY.
-    ...
-  CATCH zcx_abapgit_exception.
-    RETURN.
+            goodExample: `TRY.
+    ...
+  CATCH zcx_abapgit_exception.
+    RETURN.
 ENDTRY.`,
         };
     }

package/build/src/rules/check_subrc.js

@@ -34,14 +34,14 @@ class CheckSubrc extends _abap_rule_1.ABAPRule {
             key: "check_subrc",
             title: "Check sy-subrc",
             shortDescription: `Check sy-subrc`,
-            extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
-
-If sy-dbcnt is checked after database statements, it is considered okay.
-
-"SELECT SINGLE @abap_true FROM " is considered as an existence check
-
-If IS ASSIGNED is checked after assigning, it is considered okay.
-
+            extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
+
+If sy-dbcnt is checked after database statements, it is considered okay.
+
+"SELECT SINGLE @abap_true FROM " is considered as an existence check
+
+If IS ASSIGNED is checked after assigning, it is considered okay.
+
 FIND statement with MATCH COUNT is considered okay if subrc is not checked`,
             tags: [_irule_1.RuleTag.SingleFile],
             pseudoComment: "EC CI_SUBRC",

package/build/src/rules/commented_code.js

@@ -30,7 +30,7 @@ class CommentedCode extends _abap_rule_1.ABAPRule {
             key: "commented_code",
             title: "Find commented code",
             shortDescription: `Detects usage of commented out code.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
 https://docs.abapopenchecks.org/checks/14/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/constructor_visibility_public.js

@@ -18,10 +18,10 @@ class ConstructorVisibilityPublic {
             key: "constructor_visibility_public",
             title: "Check constructor visibility is public",
             shortDescription: `Constructor must be placed in the public section, even if the class is not CREATE PUBLIC.`,
-            extendedInformation: `
-This only applies to global classes.
-
-https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
+            extendedInformation: `
+This only applies to global classes.
+
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
 https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abeninstance_constructor_guidl.htm`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };