@abaplint/core 2.79.7 → 2.79.11

package/build/abaplint.d.ts

@@ -2398,13 +2398,15 @@ declare interface IConfiguration {
 }
 
 declare interface IDDICReferences {
-    setUsing(obj: IObject, using: readonly IObject[]): void;
-    addUsing(obj: IObject, using: IObject | undefined): void;
+    setUsing(obj: IObject, using: readonly IObjectAndToken[]): void;
+    addUsing(obj: IObject, using: IObjectAndToken | undefined): void;
     clear(obj: IObject): void;
-    listUsing(obj: IObject): readonly IObject[];
+    listUsing(obj: IObject): readonly IObjectAndToken[];
     listWhereUsed(obj: IObject): {
         type: string;
         name: string;
+        token?: Token;
+        filename?: string;
     }[];
 }
 
@@ -2908,6 +2910,12 @@ export declare interface IObject extends IArtifact {
     getXML(): string | undefined;
 }
 
+declare interface IObjectAndToken {
+    object?: IObject;
+    token?: Token;
+    filename?: string;
+}
+
 declare interface IParseResult {
     updated: boolean;
     runtime: number;

package/build/src/abap/5_syntax/_builtin.js

@@ -249,6 +249,7 @@ class BuiltIn {
         components.push({ name: "index", type: new basic_1.IntegerType() });
         components.push({ name: "langu", type: new basic_1.CharacterType(1) });
         components.push({ name: "ldbpg", type: new basic_1.CharacterType(40) });
+        components.push({ name: "pdest", type: new basic_1.CharacterType(4) });
         components.push({ name: "lilli", type: new basic_1.IntegerType() });
         components.push({ name: "linct", type: new basic_1.IntegerType() });
         components.push({ name: "linno", type: new basic_1.IntegerType() });

package/build/src/abap/5_syntax/basic_types.js

@@ -163,7 +163,7 @@ class BasicTypes {
         }
         const ddic = this.scope.getDDIC().lookup(chainText);
         if (ddic) {
-            this.scope.getDDICReferences().addUsing(this.scope.getParentObj(), ddic.object);
+            this.scope.getDDICReferences().addUsing(this.scope.getParentObj(), { object: ddic.object, token: typeName.getFirstToken(), filename: this.filename });
             if (ddic.type instanceof _typed_identifier_1.TypedIdentifier) {
                 this.scope.addReference(typeName.getFirstToken(), ddic.type, _reference_1.ReferenceType.TypeReference, this.filename);
             }
@@ -469,7 +469,7 @@ class BasicTypes {
             foundType = found === null || found === void 0 ? void 0 : found.getType();
             if (foundType === undefined) {
                 const f = this.scope.getDDIC().lookupTableOrView(subs[0]);
-                this.scope.getDDICReferences().addUsing(this.scope.getParentObj(), f.object);
+                this.scope.getDDICReferences().addUsing(this.scope.getParentObj(), { object: f.object });
                 if (f.type instanceof _typed_identifier_1.TypedIdentifier) {
                     foundType = f.type.getType();
                 }

package/build/src/abap/5_syntax/statements/delete_cluster.js

@@ -13,7 +13,7 @@ class DeleteCluster {
         if (databaseName) {
             const found = (_a = scope.getDDIC()) === null || _a === void 0 ? void 0 : _a.lookupTableOrView(databaseName.concatTokens());
             if (found) {
-                scope.getDDICReferences().addUsing(scope.getParentObj(), found.object);
+                scope.getDDICReferences().addUsing(scope.getParentObj(), { object: found.object });
             }
         }
     }

package/build/src/abap/5_syntax/statements/export.js

@@ -17,7 +17,7 @@ class Export {
         if (databaseName) {
             const found = (_a = scope.getDDIC()) === null || _a === void 0 ? void 0 : _a.lookupTableOrView(databaseName.concatTokens());
             if (found) {
-                scope.getDDICReferences().addUsing(scope.getParentObj(), found.object);
+                scope.getDDICReferences().addUsing(scope.getParentObj(), { object: found.object });
             }
         }
     }

package/build/src/abap/5_syntax/statements/import.js

@@ -17,7 +17,7 @@ class Import {
         if (databaseName) {
             const found = (_a = scope.getDDIC()) === null || _a === void 0 ? void 0 : _a.lookupTableOrView(databaseName.concatTokens());
             if (found) {
-                scope.getDDICReferences().addUsing(scope.getParentObj(), found.object);
+                scope.getDDICReferences().addUsing(scope.getParentObj(), { object: found.object });
             }
         }
     }

package/build/src/abap/5_syntax/statements/tables.js

@@ -17,7 +17,7 @@ class Tables {
         }
         const found = (_b = scope.getDDIC()) === null || _b === void 0 ? void 0 : _b.lookupTableOrView(name);
         if (found) {
-            scope.getDDICReferences().addUsing(scope.getParentObj(), found.object);
+            scope.getDDICReferences().addUsing(scope.getParentObj(), { object: found.object });
             scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(nameToken, filename, found.type));
             return;
         }

package/build/src/ddic_references.js

@@ -50,8 +50,8 @@ class DDICReferences {
         for (const name in this.index) {
             for (const type in this.index[name]) {
                 for (const f of this.index[name][type]) {
-                    if (f.getType() === searchType && f.getName() === searchName) {
-                        ret.push({ type, name });
+                    if (f.object && f.object.getType() === searchType && f.object.getName() === searchName) {
+                        ret.push({ type, name, token: f.token, filename: f.filename });
                         break; // current outermost loop
                     }
                 }

package/build/src/objects/data_element.js

@@ -60,7 +60,7 @@ class DataElement extends _abstract_object_1.AbstractObject {
             }
         }
         if (lookup.object) {
-            references.push(lookup.object);
+            references.push({ object: lookup.object });
         }
         reg.getDDICReferences().setUsing(this, references);
         return lookup.type;

package/build/src/objects/rename/rename_data_element.js

@@ -0,0 +1,26 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RenameDataElement = void 0;
+const __1 = require("..");
+const renamer_helper_1 = require("./renamer_helper");
+class RenameDataElement {
+    constructor(reg) {
+        this.reg = reg;
+    }
+    buildEdits(obj, oldName, newName) {
+        if (!(obj instanceof __1.DataElement)) {
+            throw new Error("RenameDataElement, not a data element");
+        }
+        let changes = [];
+        const helper = new renamer_helper_1.RenamerHelper(this.reg);
+        changes = changes.concat(helper.buildXMLFileEdits(obj, "ROLLNAME", oldName, newName));
+        changes = changes.concat(helper.renameFiles(obj, oldName, newName));
+        changes = changes.concat(helper.renameDDICCodeReferences(obj, oldName, newName));
+        changes = changes.concat(helper.renameDDICTABLReferences(obj, oldName, newName));
+        return {
+            documentChanges: changes,
+        };
+    }
+}
+exports.RenameDataElement = RenameDataElement;
+//# sourceMappingURL=rename_data_element.js.map

package/build/src/objects/rename/rename_domain.js

@@ -0,0 +1,25 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RenameDomain = void 0;
+const __1 = require("..");
+const renamer_helper_1 = require("./renamer_helper");
+class RenameDomain {
+    constructor(reg) {
+        this.reg = reg;
+    }
+    buildEdits(obj, oldName, newName) {
+        if (!(obj instanceof __1.Domain)) {
+            throw new Error("RenameDomain, not a domain");
+        }
+        let changes = [];
+        const helper = new renamer_helper_1.RenamerHelper(this.reg);
+        changes = changes.concat(helper.buildXMLFileEdits(obj, "DOMNAME", oldName, newName));
+        changes = changes.concat(helper.renameFiles(obj, oldName, newName));
+        changes = changes.concat(helper.renameDDICDTELReferences(obj, oldName, newName));
+        return {
+            documentChanges: changes,
+        };
+    }
+}
+exports.RenameDomain = RenameDomain;
+//# sourceMappingURL=rename_domain.js.map

package/build/src/objects/rename/renamer.js

@@ -3,6 +3,8 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.Renamer = void 0;
 const vscode_languageserver_types_1 = require("vscode-languageserver-types");
 const memory_file_1 = require("../../files/memory_file");
+const rename_data_element_1 = require("./rename_data_element");
+const rename_domain_1 = require("./rename_domain");
 const rename_global_class_1 = require("./rename_global_class");
 const rename_global_interface_1 = require("./rename_global_interface");
 class Renamer {
@@ -40,6 +42,10 @@ class Renamer {
         switch (type) {
             case "CLAS":
                 return new rename_global_class_1.RenameGlobalClass(this.reg);
+            case "DTEL":
+                return new rename_data_element_1.RenameDataElement(this.reg);
+            case "DOMA":
+                return new rename_domain_1.RenameDomain(this.reg);
             case "INTF":
                 return new rename_global_interface_1.RenameGlobalInterface(this.reg);
             default:

package/build/src/objects/rename/renamer_helper.js

@@ -27,19 +27,62 @@ class RenamerHelper {
         // start with the last reference in the file first, if there are multiple refs per line
         return this.replaceRefs(refs, oldName, newName).reverse();
     }
-    buildXMLFileEdits(clas, xmlTag, oldName, newName) {
+    renameDDICCodeReferences(obj, oldName, newName) {
         const changes = [];
-        const xml = clas.getXMLFile();
+        const used = this.reg.getDDICReferences().listWhereUsed(obj);
+        for (const u of used) {
+            if (u.token === undefined || u.filename === undefined) {
+                continue;
+            }
+            const range = vscode_languageserver_types_1.Range.create(u.token.getStart().getRow() - 1, u.token.getStart().getCol() - 1, u.token.getStart().getRow() - 1, u.token.getStart().getCol() - 1 + oldName.length);
+            changes.push(vscode_languageserver_types_1.TextDocumentEdit.create({ uri: u.filename, version: 1 }, [vscode_languageserver_types_1.TextEdit.replace(range, newName.toLowerCase())]));
+        }
+        return changes;
+    }
+    renameDDICTABLReferences(obj, oldName, newName) {
+        const changes = [];
+        const used = this.reg.getDDICReferences().listWhereUsed(obj);
+        for (const u of used) {
+            if (u.type !== "TABL") {
+                continue;
+            }
+            const tabl = this.reg.getObject(u.type, u.name);
+            if (tabl === undefined) {
+                continue;
+            }
+            changes.push(...this.buildXMLFileEdits(tabl, "ROLLNAME", oldName, newName));
+        }
+        return changes;
+    }
+    renameDDICDTELReferences(obj, oldName, newName) {
+        const changes = [];
+        const used = this.reg.getDDICReferences().listWhereUsed(obj);
+        for (const u of used) {
+            if (u.type !== "DTEL") {
+                continue;
+            }
+            const tabl = this.reg.getObject(u.type, u.name);
+            if (tabl === undefined) {
+                continue;
+            }
+            changes.push(...this.buildXMLFileEdits(tabl, "DOMNAME", oldName, newName));
+        }
+        return changes;
+    }
+    buildXMLFileEdits(object, xmlTag, oldName, newName) {
+        const changes = [];
+        const xml = object.getXMLFile();
         if (xml === undefined) {
             return [];
         }
         const tag = xmlTag.toUpperCase();
         const search = "<" + tag + ">" + oldName.toUpperCase() + "</" + tag + ">";
+        const length = tag.length + 2;
         const rows = xml.getRawRows();
         for (let i = 0; i < rows.length; i++) {
             const index = rows[i].indexOf(search);
             if (index >= 0) {
-                const range = vscode_languageserver_types_1.Range.create(i, index + 9, i, index + oldName.length + 9);
+                const range = vscode_languageserver_types_1.Range.create(i, index + length, i, index + oldName.length + length);
                 changes.push(vscode_languageserver_types_1.TextDocumentEdit.create({ uri: xml.getFilename(), version: 1 }, [vscode_languageserver_types_1.TextEdit.replace(range, newName.toUpperCase())]));
             }
         }

package/build/src/objects/table.js

@@ -74,7 +74,7 @@ class Table extends _abstract_object_1.AbstractObject {
                 const lookup = ddic.lookupDataElement(field.ROLLNAME);
                 components.push({ name: field.FIELDNAME, type: lookup.type });
                 if (lookup.object) {
-                    references.push(lookup.object);
+                    references.push({ object: lookup.object });
                 }
             }
             else if (field.FIELDNAME === ".INCLUDE" || field.FIELDNAME === ".INCLU--AP") { // incude or append structure
@@ -84,7 +84,7 @@ class Table extends _abstract_object_1.AbstractObject {
                 const lookup = ddic.lookupTableOrView(field.PRECFIELD);
                 let found = lookup.type;
                 if (lookup.object) {
-                    references.push(lookup.object);
+                    references.push({ object: lookup.object });
                 }
                 if (found instanceof _typed_identifier_1.TypedIdentifier) {
                     found = found.getType();
@@ -119,7 +119,7 @@ class Table extends _abstract_object_1.AbstractObject {
                 const lookup = ddic.lookupTableOrView(field.ROLLNAME);
                 components.push({ name: field.FIELDNAME, type: lookup.type });
                 if (lookup.object) {
-                    references.push(lookup.object);
+                    references.push({ object: lookup.object });
                 }
             }
             else if (comptype === "R") {
@@ -136,7 +136,7 @@ class Table extends _abstract_object_1.AbstractObject {
                     const lookup = ddic.lookupObject(field.ROLLNAME);
                     components.push({ name: field.FIELDNAME, type: lookup.type });
                     if (lookup.object) {
-                        references.push(lookup.object);
+                        references.push({ object: lookup.object });
                     }
                 }
             }
@@ -144,7 +144,7 @@ class Table extends _abstract_object_1.AbstractObject {
                 const lookup = ddic.lookupTableType(field.ROLLNAME);
                 components.push({ name: field.FIELDNAME, type: lookup.type });
                 if (lookup.object) {
-                    references.push(lookup.object);
+                    references.push({ object: lookup.object });
                 }
             }
             else if (comptype === "") { // built in

package/build/src/objects/table_type.js

@@ -38,28 +38,28 @@ class TableType extends _abstract_object_1.AbstractObject {
             const lookup = ddic.lookupTableOrView(this.parsedXML.rowtype);
             type = new Types.TableType(lookup.type, { withHeader: false }, this.getName());
             if (lookup.object) {
-                references.push(lookup.object);
+                references.push({ object: lookup.object });
             }
         }
         else if (this.parsedXML.rowkind === "E") {
             const lookup = ddic.lookupDataElement(this.parsedXML.rowtype);
             type = new Types.TableType(lookup.type, { withHeader: false }, this.getName());
             if (lookup.object) {
-                references.push(lookup.object);
+                references.push({ object: lookup.object });
             }
         }
         else if (this.parsedXML.rowkind === "L") {
             const lookup = ddic.lookupTableType(this.parsedXML.rowtype);
             type = new Types.TableType(lookup.type, { withHeader: false }, this.getName());
             if (lookup.object) {
-                references.push(lookup.object);
+                references.push({ object: lookup.object });
             }
         }
         else if (this.parsedXML.rowkind === "R" && this.parsedXML.rowtype !== undefined) {
             const lookup = ddic.lookupObject(this.parsedXML.rowtype);
             type = new Types.TableType(lookup.type, { withHeader: false }, this.getName());
             if (lookup.object) {
-                references.push(lookup.object);
+                references.push({ object: lookup.object });
             }
         }
         else if (this.parsedXML.rowkind === "") {

package/build/src/objects/view.js

@@ -5,7 +5,6 @@ const Types = require("../abap/types/basic");
 const _abstract_object_1 = require("./_abstract_object");
 const xml_utils_1 = require("../xml_utils");
 const ddic_1 = require("../ddic");
-const _typed_identifier_1 = require("../abap/types/_typed_identifier");
 class View extends _abstract_object_1.AbstractObject {
     getType() {
         return "VIEW";
@@ -36,12 +35,13 @@ class View extends _abstract_object_1.AbstractObject {
                 continue;
             }
             const lookup = ddic.lookupTableOrView(field.TABNAME);
+            let found = lookup.type;
             if (lookup.object) {
-                references.push(lookup.object);
+                references.push({ object: lookup.object });
             }
-            let found = lookup.type;
-            if (found instanceof _typed_identifier_1.TypedIdentifier) {
-                found = found.getType();
+            if (field.VIEWFIELD === ".APPEND") {
+                // it is already expanded in the abapGit xml
+                continue;
             }
             if (found instanceof Types.StructureType) {
                 const s = found.getComponentByName(field.FIELDNAME);

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.79.7";
+        return "2.79.11";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/avoid_use.js

@@ -35,11 +35,12 @@ class AvoidUse extends _abap_rule_1.ABAPRule {
             key: "avoid_use",
             title: "Avoid use of certain statements",
             shortDescription: `Detects usage of certain statements.`,
-            extendedInformation: `
-DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
+            extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
 
 Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
 
+STATICS: use CLASS-DATA instead
+
 DESCRIBE TABLE LINES: use lines() instead (quickfix exists)`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/constant_classes.js

@@ -7,6 +7,11 @@ const _irule_1 = require("./_irule");
 const __1 = require("..");
 /** Checks that constants classes are in sync with domain fixed values */
 class ConstantClassesConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        /** Specify a list of domain-class pairs which will be validated */
+        this.mapping = [];
+    }
 }
 exports.ConstantClassesConf = ConstantClassesConf;
 class ConstantClasses {

package/build/src/rules/exit_or_check.js

@@ -26,11 +26,9 @@ class ExitOrCheck extends _abap_rule_1.ABAPRule {
             title: "Find EXIT or CHECK outside loops",
             shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
 Use RETURN to leave procesing blocks instead.`,
-            extendedInformation: `
-https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
+            extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
 https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
-https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-return
-`,
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-return`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
         };
     }
@@ -44,19 +42,20 @@ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-re
         const issues = [];
         const stack = [];
         for (const statement of file.getStatements()) {
-            if (statement.get() instanceof Statements.Loop
-                || statement.get() instanceof Statements.While
-                || statement.get() instanceof Statements.SelectLoop
-                || statement.get() instanceof Statements.Do) {
+            const get = statement.get();
+            if (get instanceof Statements.Loop
+                || get instanceof Statements.While
+                || get instanceof Statements.SelectLoop
+                || get instanceof Statements.Do) {
                 stack.push(statement);
             }
-            else if (statement.get() instanceof Statements.EndLoop
-                || statement.get() instanceof Statements.EndWhile
-                || statement.get() instanceof Statements.EndSelect
-                || statement.get() instanceof Statements.EndDo) {
+            else if (get instanceof Statements.EndLoop
+                || get instanceof Statements.EndWhile
+                || get instanceof Statements.EndSelect
+                || get instanceof Statements.EndDo) {
                 stack.pop();
             }
-            else if (this.conf.allowCheck === false && statement.get() instanceof Statements.Check && stack.length === 0) {
+            else if (this.conf.allowCheck === false && get instanceof Statements.Check && stack.length === 0) {
                 const message = "CHECK is not allowed outside of loops";
                 let tokensString = statement.concatTokens();
                 tokensString = tokensString.slice(statement.getFirstToken().getEnd().getCol());
@@ -65,7 +64,7 @@ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-re
                 const issue = issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity, fix);
                 issues.push(issue);
             }
-            else if (this.conf.allowExit === false && statement.get() instanceof Statements.Exit && stack.length === 0) {
+            else if (this.conf.allowExit === false && get instanceof Statements.Exit && stack.length === 0) {
                 const message = "EXIT is not allowed outside of loops";
                 const fix = edit_helper_1.EditHelper.replaceToken(file, statement.getFirstToken(), "RETURN");
                 const issue = issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity, fix);

package/build/src/rules/unused_variables.js

@@ -186,12 +186,10 @@ class UnusedVariables {
         if (statement === undefined) {
             return undefined;
         }
-        else if (statement.get() instanceof Statements.FunctionModule) {
-            return undefined; // function module parameters are not part of the code
-        }
-        else {
+        else if (statement.get() instanceof Statements.Data) {
             return edit_helper_1.EditHelper.deleteStatement(file, statement);
         }
+        return undefined;
     }
 }
 exports.UnusedVariables = UnusedVariables;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.79.7",
+    "version": "2.79.11",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -54,21 +54,21 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.18.10",
+        "@microsoft/api-extractor": "^7.18.11",
         "@types/chai": "^4.2.22",
         "@types/mocha": "^9.0.0",
-        "@types/node": "^16.9.6",
+        "@types/node": "^16.10.2",
         "chai": "^4.3.4",
         "eslint": "^7.32.0",
         "madge": "^5.0.1",
-        "mocha": "^9.1.1",
+        "mocha": "^9.1.2",
         "c8": "^7.9.0",
         "source-map-support": "^0.5.20",
         "ts-json-schema-generator": "^0.95.0",
         "typescript": "^4.4.3"
     },
     "dependencies": {
-        "fast-xml-parser": "^3.20.0",
+        "fast-xml-parser": "^3.20.3",
         "json5": "^2.2.0",
         "vscode-languageserver-protocol": "^3.16.0",
         "vscode-languageserver-types": "^3.16.0"