@abaplint/core 2.79.5 → 2.79.9

package/build/src/abap/5_syntax/_builtin.js

@@ -249,6 +249,7 @@ class BuiltIn {
         components.push({ name: "index", type: new basic_1.IntegerType() });
         components.push({ name: "langu", type: new basic_1.CharacterType(1) });
         components.push({ name: "ldbpg", type: new basic_1.CharacterType(40) });
+        components.push({ name: "pdest", type: new basic_1.CharacterType(4) });
         components.push({ name: "lilli", type: new basic_1.IntegerType() });
         components.push({ name: "linct", type: new basic_1.IntegerType() });
         components.push({ name: "linno", type: new basic_1.IntegerType() });

package/build/src/objects/domain.js

@@ -4,6 +4,7 @@ exports.Domain = void 0;
 const _abstract_object_1 = require("./_abstract_object");
 const Types = require("../abap/types/basic");
 const ddic_1 = require("../ddic");
+const xml_utils_1 = require("../xml_utils");
 class Domain extends _abstract_object_1.AbstractObject {
     getType() {
         return "DOMA";
@@ -46,17 +47,15 @@ class Domain extends _abstract_object_1.AbstractObject {
             return { updated: false, runtime: 0 };
         }
         const dd01v = (_c = (_b = (_a = parsed.abapGit) === null || _a === void 0 ? void 0 : _a["asx:abap"]) === null || _b === void 0 ? void 0 : _b["asx:values"]) === null || _c === void 0 ? void 0 : _c.DD01V;
-        const dd07v_tab = (_g = (_f = (_e = (_d = parsed.abapGit) === null || _d === void 0 ? void 0 : _d["asx:abap"]) === null || _e === void 0 ? void 0 : _e["asx:values"]) === null || _f === void 0 ? void 0 : _f.DD07V_TAB) === null || _g === void 0 ? void 0 : _g.DD07V;
+        const dd07v_tab = (0, xml_utils_1.xmlToArray)((_g = (_f = (_e = (_d = parsed.abapGit) === null || _d === void 0 ? void 0 : _d["asx:abap"]) === null || _e === void 0 ? void 0 : _e["asx:values"]) === null || _f === void 0 ? void 0 : _f.DD07V_TAB) === null || _g === void 0 ? void 0 : _g.DD07V);
         const values = [];
-        if (dd07v_tab) {
-            for (const ddo7v of dd07v_tab) {
-                const value = {
-                    description: ddo7v === null || ddo7v === void 0 ? void 0 : ddo7v.DDTEXT,
-                    value: ddo7v === null || ddo7v === void 0 ? void 0 : ddo7v.DOMVALUE_L,
-                    language: ddo7v === null || ddo7v === void 0 ? void 0 : ddo7v.DDLANGUAGE,
-                };
-                values.push(value);
-            }
+        for (const ddo7v of dd07v_tab) {
+            const value = {
+                description: ddo7v === null || ddo7v === void 0 ? void 0 : ddo7v.DDTEXT,
+                value: ddo7v === null || ddo7v === void 0 ? void 0 : ddo7v.DOMVALUE_L,
+                language: ddo7v === null || ddo7v === void 0 ? void 0 : ddo7v.DDLANGUAGE,
+            };
+            values.push(value);
         }
         this.parsedXML = {
             description: dd01v === null || dd01v === void 0 ? void 0 : dd01v.DDTEXT,

package/build/src/objects/rename/rename_data_element.js

@@ -0,0 +1,24 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RenameDataElement = void 0;
+const __1 = require("..");
+const renamer_helper_1 = require("./renamer_helper");
+class RenameDataElement {
+    constructor(reg) {
+        this.reg = reg;
+    }
+    buildEdits(obj, oldName, newName) {
+        if (!(obj instanceof __1.DataElement)) {
+            throw new Error("RenameDataElement, not a data element");
+        }
+        let changes = [];
+        const helper = new renamer_helper_1.RenamerHelper(this.reg);
+        changes = changes.concat(helper.buildXMLFileEdits(obj, "ROLLNAME", oldName, newName));
+        changes = changes.concat(helper.renameFiles(obj, oldName, newName));
+        return {
+            documentChanges: changes,
+        };
+    }
+}
+exports.RenameDataElement = RenameDataElement;
+//# sourceMappingURL=rename_data_element.js.map

package/build/src/objects/rename/rename_domain.js

@@ -0,0 +1,24 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RenameDomain = void 0;
+const __1 = require("..");
+const renamer_helper_1 = require("./renamer_helper");
+class RenameDomain {
+    constructor(reg) {
+        this.reg = reg;
+    }
+    buildEdits(obj, oldName, newName) {
+        if (!(obj instanceof __1.Domain)) {
+            throw new Error("RenameDomain, not a domain");
+        }
+        let changes = [];
+        const helper = new renamer_helper_1.RenamerHelper(this.reg);
+        changes = changes.concat(helper.buildXMLFileEdits(obj, "DOMNAME", oldName, newName));
+        changes = changes.concat(helper.renameFiles(obj, oldName, newName));
+        return {
+            documentChanges: changes,
+        };
+    }
+}
+exports.RenameDomain = RenameDomain;
+//# sourceMappingURL=rename_domain.js.map

package/build/src/objects/rename/renamer.js

@@ -3,6 +3,8 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.Renamer = void 0;
 const vscode_languageserver_types_1 = require("vscode-languageserver-types");
 const memory_file_1 = require("../../files/memory_file");
+const rename_data_element_1 = require("./rename_data_element");
+const rename_domain_1 = require("./rename_domain");
 const rename_global_class_1 = require("./rename_global_class");
 const rename_global_interface_1 = require("./rename_global_interface");
 class Renamer {
@@ -40,6 +42,10 @@ class Renamer {
         switch (type) {
             case "CLAS":
                 return new rename_global_class_1.RenameGlobalClass(this.reg);
+            case "DTEL":
+                return new rename_data_element_1.RenameDataElement(this.reg);
+            case "DOMA":
+                return new rename_domain_1.RenameDomain(this.reg);
             case "INTF":
                 return new rename_global_interface_1.RenameGlobalInterface(this.reg);
             default:

package/build/src/objects/rename/renamer_helper.js

@@ -35,11 +35,12 @@ class RenamerHelper {
         }
         const tag = xmlTag.toUpperCase();
         const search = "<" + tag + ">" + oldName.toUpperCase() + "</" + tag + ">";
+        const length = tag.length + 2;
         const rows = xml.getRawRows();
         for (let i = 0; i < rows.length; i++) {
             const index = rows[i].indexOf(search);
             if (index >= 0) {
-                const range = vscode_languageserver_types_1.Range.create(i, index + 9, i, index + oldName.length + 9);
+                const range = vscode_languageserver_types_1.Range.create(i, index + length, i, index + oldName.length + length);
                 changes.push(vscode_languageserver_types_1.TextDocumentEdit.create({ uri: xml.getFilename(), version: 1 }, [vscode_languageserver_types_1.TextEdit.replace(range, newName.toUpperCase())]));
             }
         }

package/build/src/objects/view.js

@@ -5,7 +5,6 @@ const Types = require("../abap/types/basic");
 const _abstract_object_1 = require("./_abstract_object");
 const xml_utils_1 = require("../xml_utils");
 const ddic_1 = require("../ddic");
-const _typed_identifier_1 = require("../abap/types/_typed_identifier");
 class View extends _abstract_object_1.AbstractObject {
     getType() {
         return "VIEW";
@@ -31,17 +30,18 @@ class View extends _abstract_object_1.AbstractObject {
         const references = [];
         const ddic = new ddic_1.DDIC(reg);
         for (const field of this.parsedData.fields) {
-            if (field.VIEWFIELD === "*") {
+            if (field.VIEWFIELD === "*" || field.VIEWFIELD === "-") {
                 // ignore, this is a special case of old style .INCLUDE
                 continue;
             }
             const lookup = ddic.lookupTableOrView(field.TABNAME);
+            let found = lookup.type;
             if (lookup.object) {
                 references.push(lookup.object);
             }
-            let found = lookup.type;
-            if (found instanceof _typed_identifier_1.TypedIdentifier) {
-                found = found.getType();
+            if (field.VIEWFIELD === ".APPEND") {
+                // it is already expanded in the abapGit xml
+                continue;
             }
             if (found instanceof Types.StructureType) {
                 const s = found.getComponentByName(field.FIELDNAME);

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.79.5";
+        return "2.79.9";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/avoid_use.js

@@ -35,11 +35,12 @@ class AvoidUse extends _abap_rule_1.ABAPRule {
             key: "avoid_use",
             title: "Avoid use of certain statements",
             shortDescription: `Detects usage of certain statements.`,
-            extendedInformation: `
-DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
+            extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
 
 Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
 
+STATICS: use CLASS-DATA instead
+
 DESCRIBE TABLE LINES: use lines() instead (quickfix exists)`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/constant_classes.js

@@ -7,6 +7,11 @@ const _irule_1 = require("./_irule");
 const __1 = require("..");
 /** Checks that constants classes are in sync with domain fixed values */
 class ConstantClassesConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        /** Specify a list of domain-class pairs which will be validated */
+        this.mapping = [];
+    }
 }
 exports.ConstantClassesConf = ConstantClassesConf;
 class ConstantClasses {

package/build/src/rules/downport.js

@@ -46,6 +46,7 @@ Current rules:
 * VALUE # with internal table lines
 * Table Expressions[ index ] are outlined
 * SELECT INTO @DATA definitions are outlined
+* Some occurrences of string template formatting option ALPHA changed to function module call
 * SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
 
 Only one transformation is applied to a statement at a time, so multiple steps might be required to do the full downport.`,
@@ -142,6 +143,10 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         if (found) {
             return found;
         }
+        found = this.stringTemplateAlpha(high, lowFile);
+        if (found) {
+            return found;
+        }
         found = this.downportSelectInline(low, high, lowFile, highSyntax);
         if (found) {
             return found;
@@ -429,7 +434,51 @@ ${indentation}`);
             const fix = edit_helper_1.EditHelper.replaceToken(lowFile, token, "DEFAULT");
             return issue_1.Issue.atToken(lowFile, i.getFirstToken(), "Downport EMPTY KEY", this.getMetadata().key, this.conf.severity, fix);
         }
-        return;
+        return undefined;
+    }
+    // must be very simple string templates, like "|{ ls_line-no ALPHA = IN }|"
+    stringTemplateAlpha(node, lowFile) {
+        var _a, _b, _c;
+        if (!(node.get() instanceof Statements.Move)) {
+            return undefined;
+        }
+        const topSource = node.findDirectExpression(Expressions.Source);
+        if (topSource === undefined || topSource.getChildren().length !== 1) {
+            return undefined;
+        }
+        const child = topSource.getFirstChild();
+        if (!(child.get() instanceof Expressions.StringTemplate)) {
+            return undefined;
+        }
+        const templateTokens = child.getChildren();
+        if (templateTokens.length !== 3
+            || templateTokens[0].getFirstToken().getStr() !== "|{"
+            || templateTokens[2].getFirstToken().getStr() !== "}|") {
+            return undefined;
+        }
+        const templateSource = child.findDirectExpression(Expressions.StringTemplateSource);
+        const formatting = (_a = templateSource === null || templateSource === void 0 ? void 0 : templateSource.findDirectExpression(Expressions.StringTemplateFormatting)) === null || _a === void 0 ? void 0 : _a.concatTokens();
+        let functionName = "";
+        switch (formatting) {
+            case "ALPHA = IN":
+                functionName = "CONVERSION_EXIT_ALPHA_INPUT";
+                break;
+            case "ALPHA = OUT":
+                functionName = "CONVERSION_EXIT_ALPHA_OUTPUT";
+                break;
+            default:
+                return undefined;
+        }
+        const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
+        const source = (_b = templateSource === null || templateSource === void 0 ? void 0 : templateSource.findDirectExpression(Expressions.Source)) === null || _b === void 0 ? void 0 : _b.concatTokens();
+        const topTarget = (_c = node.findDirectExpression(Expressions.Target)) === null || _c === void 0 ? void 0 : _c.concatTokens();
+        const code = `CALL FUNCTION '${functionName}'
+${indentation}  EXPORTING
+${indentation}    input  = ${source}
+${indentation}  IMPORTING
+${indentation}    output = ${topTarget}.`;
+        const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getFirstToken().getStart(), node.getLastToken().getEnd(), code);
+        return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Downport ALPHA", this.getMetadata().key, this.conf.severity, fix);
     }
     outlineLoopInput(node, lowFile, highSyntax) {
         if (!(node.get() instanceof Statements.Loop)) {

package/build/src/rules/exit_or_check.js

@@ -26,11 +26,9 @@ class ExitOrCheck extends _abap_rule_1.ABAPRule {
             title: "Find EXIT or CHECK outside loops",
             shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
 Use RETURN to leave procesing blocks instead.`,
-            extendedInformation: `
-https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
+            extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
 https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
-https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-return
-`,
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-return`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
         };
     }
@@ -44,19 +42,20 @@ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-re
         const issues = [];
         const stack = [];
         for (const statement of file.getStatements()) {
-            if (statement.get() instanceof Statements.Loop
-                || statement.get() instanceof Statements.While
-                || statement.get() instanceof Statements.SelectLoop
-                || statement.get() instanceof Statements.Do) {
+            const get = statement.get();
+            if (get instanceof Statements.Loop
+                || get instanceof Statements.While
+                || get instanceof Statements.SelectLoop
+                || get instanceof Statements.Do) {
                 stack.push(statement);
             }
-            else if (statement.get() instanceof Statements.EndLoop
-                || statement.get() instanceof Statements.EndWhile
-                || statement.get() instanceof Statements.EndSelect
-                || statement.get() instanceof Statements.EndDo) {
+            else if (get instanceof Statements.EndLoop
+                || get instanceof Statements.EndWhile
+                || get instanceof Statements.EndSelect
+                || get instanceof Statements.EndDo) {
                 stack.pop();
             }
-            else if (this.conf.allowCheck === false && statement.get() instanceof Statements.Check && stack.length === 0) {
+            else if (this.conf.allowCheck === false && get instanceof Statements.Check && stack.length === 0) {
                 const message = "CHECK is not allowed outside of loops";
                 let tokensString = statement.concatTokens();
                 tokensString = tokensString.slice(statement.getFirstToken().getEnd().getCol());
@@ -65,7 +64,7 @@ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-re
                 const issue = issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity, fix);
                 issues.push(issue);
             }
-            else if (this.conf.allowExit === false && statement.get() instanceof Statements.Exit && stack.length === 0) {
+            else if (this.conf.allowExit === false && get instanceof Statements.Exit && stack.length === 0) {
                 const message = "EXIT is not allowed outside of loops";
                 const fix = edit_helper_1.EditHelper.replaceToken(file, statement.getFirstToken(), "RETURN");
                 const issue = issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity, fix);

package/build/src/rules/unused_variables.js

@@ -186,12 +186,10 @@ class UnusedVariables {
         if (statement === undefined) {
             return undefined;
         }
-        else if (statement.get() instanceof Statements.FunctionModule) {
-            return undefined; // function module parameters are not part of the code
-        }
-        else {
+        else if (statement.get() instanceof Statements.Data) {
             return edit_helper_1.EditHelper.deleteStatement(file, statement);
         }
+        return undefined;
     }
 }
 exports.UnusedVariables = UnusedVariables;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.79.5",
+    "version": "2.79.9",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -54,21 +54,21 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.18.9",
+        "@microsoft/api-extractor": "^7.18.11",
         "@types/chai": "^4.2.22",
         "@types/mocha": "^9.0.0",
-        "@types/node": "^16.9.6",
+        "@types/node": "^16.10.2",
         "chai": "^4.3.4",
         "eslint": "^7.32.0",
         "madge": "^5.0.1",
-        "mocha": "^9.1.1",
+        "mocha": "^9.1.2",
         "c8": "^7.9.0",
         "source-map-support": "^0.5.20",
         "ts-json-schema-generator": "^0.95.0",
         "typescript": "^4.4.3"
     },
     "dependencies": {
-        "fast-xml-parser": "^3.20.0",
+        "fast-xml-parser": "^3.20.3",
         "json5": "^2.2.0",
         "vscode-languageserver-protocol": "^3.16.0",
         "vscode-languageserver-types": "^3.16.0"