@abaplint/core 2.79.32 → 2.80.0

package/build/src/rules/align_parameters.js

@@ -0,0 +1,131 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.AlignParameters = exports.AlignParametersConf = void 0;
+const issue_1 = require("../issue");
+const Expressions = require("../abap/2_statements/expressions");
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+class AlignParametersConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.AlignParametersConf = AlignParametersConf;
+class AlignParameters extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new AlignParametersConf();
+    }
+    getMetadata() {
+        return {
+            key: "align_parameters",
+            title: "Align Parameters",
+            shortDescription: `Checks for aligned parameters in function module calls.`,
+            extendedInformation: `https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters`,
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide],
+            badExample: `CALL FUNCTION 'FOOBAR'
+  EXPORTING
+    foo = 2
+    parameter = 3.`,
+            goodExample: `CALL FUNCTION 'FOOBAR'
+  EXPORTING
+    foo       = 2
+    parameter = 3.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        const stru = file.getStructure();
+        if (stru === undefined) {
+            return issues; // parser error
+        }
+        const candidates = [];
+        candidates.push(...this.functionParameterCandidates(stru));
+        /* TODO,
+        stru.findAllExpressionsRecursive(Expressions.MethodCallParam);
+        stru.findAllExpressionsRecursive(Expressions.MethodParameters);
+        stru.findAllExpressionsRecursive(Expressions.ValueBody);
+        */
+        for (const c of candidates) {
+            const i = this.checkCandidate(c, file);
+            if (i) {
+                issues.push(i);
+            }
+        }
+        return issues;
+    }
+    checkCandidate(candidate, file) {
+        if (candidate.parameters.length === 0) {
+            return undefined;
+        }
+        let expectedEqualsColumn = 0;
+        for (const p of candidate.parameters) {
+            const currentCol = p.left.getLastToken().getCol() + p.left.getLastToken().getStr().length + 1;
+            if (currentCol > expectedEqualsColumn) {
+                expectedEqualsColumn = currentCol;
+            }
+        }
+        for (const p of candidate.parameters) {
+            if (p.eq.getCol() !== expectedEqualsColumn) {
+                const pos = candidate.parameters[0].eq;
+                const message = "Align parameters to column " + expectedEqualsColumn;
+                return issue_1.Issue.atPosition(file, pos, message, this.getMetadata().key);
+            }
+        }
+        return undefined;
+    }
+    functionParameterCandidates(stru) {
+        const candidates = [];
+        for (const fp of stru.findAllExpressionsRecursive(Expressions.FunctionParameters)) {
+            const parameters = [];
+            for (const p of fp.findAllExpressions(Expressions.FunctionExportingParameter)) {
+                const children = p.getChildren();
+                if (children.length < 3) {
+                    continue; // unexpected
+                }
+                parameters.push({
+                    left: children[0],
+                    eq: children[1].getFirstToken().getStart(),
+                    right: children[2],
+                });
+            }
+            for (const list of fp.findDirectExpressions(Expressions.ParameterListT)) {
+                for (const pt of list.findDirectExpressions(Expressions.ParameterT)) {
+                    const children = pt.getChildren();
+                    if (children.length < 3) {
+                        continue; // unexpected
+                    }
+                    parameters.push({
+                        left: children[0],
+                        eq: children[1].getFirstToken().getStart(),
+                        right: children[2],
+                    });
+                }
+            }
+            const list = fp.findDirectExpression(Expressions.ParameterListExceptions);
+            if (list) {
+                for (const pt of list.findDirectExpressions(Expressions.ParameterException)) {
+                    const children = pt.getChildren();
+                    if (children.length < 3) {
+                        continue; // unexpected
+                    }
+                    parameters.push({
+                        left: children[0],
+                        eq: children[1].getFirstToken().getStart(),
+                        right: children[2],
+                    });
+                }
+            }
+            if (parameters.length > 0) {
+                candidates.push({ parameters });
+            }
+        }
+        return candidates;
+    }
+}
+exports.AlignParameters = AlignParameters;
+//# sourceMappingURL=align_parameters.js.map

package/build/src/rules/allowed_object_naming.js

@@ -42,7 +42,7 @@ class AllowedObjectNaming {
                 message = "Name not allowed";
             }
         }
-        else if (obj.getName().match(/^(\/[A-Z_\d]{3,8}\/)?[A-Z_\d<> ]+$/i) === null) {
+        else if (obj.getName().match(/^(\/[A-Z_\d]{3,8}\/)?[A-Z_-\d<> ]+$/i) === null) {
             message = "Name not allowed";
         }
         if (message.length > 0) {

package/build/src/rules/ambiguous_statement.js

@@ -20,14 +20,14 @@ class AmbiguousStatement extends _abap_rule_1.ABAPRule {
         return {
             key: "ambiguous_statement",
             title: "Check for ambigious statements",
-            shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
-Add "TABLE" keyword or "@" for escaping SQL variables
-
+            shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
+Add "TABLE" keyword or "@" for escaping SQL variables
+
 Only works if the target version is 740sp05 or above`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `DELETE foo FROM bar.
+            badExample: `DELETE foo FROM bar.
 MODIFY foo FROM bar.`,
-            goodExample: `DELETE foo FROM @bar.
+            goodExample: `DELETE foo FROM @bar.
 MODIFY TABLE foo FROM bar.`,
         };
     }

package/build/src/rules/avoid_use.js

@@ -35,12 +35,12 @@ class AvoidUse extends _abap_rule_1.ABAPRule {
             key: "avoid_use",
             title: "Avoid use of certain statements",
             shortDescription: `Detects usage of certain statements.`,
-            extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
-
-Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
-
-STATICS: use CLASS-DATA instead
-
+            extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
+
+Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
+
+STATICS: use CLASS-DATA instead
+
 DESCRIBE TABLE LINES: use lines() instead (quickfix exists)`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/begin_end_names.js

@@ -23,11 +23,11 @@ class BeginEndNames extends _abap_rule_1.ABAPRule {
             title: "Check BEGIN END names",
             shortDescription: `Check BEGIN OF and END OF names match, plus there must be statements between BEGIN and END`,
             tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
-            badExample: `DATA: BEGIN OF stru,
-      field TYPE i,
+            badExample: `DATA: BEGIN OF stru,
+      field TYPE i,
     END OF structure_not_the_same.`,
-            goodExample: `DATA: BEGIN OF stru,
-      field TYPE i,
+            goodExample: `DATA: BEGIN OF stru,
+      field TYPE i,
     END OF stru.`,
         };
     }

package/build/src/rules/begin_single_include.js

@@ -21,19 +21,19 @@ class BeginSingleInclude extends _abap_rule_1.ABAPRule {
             title: "BEGIN contains single INCLUDE",
             shortDescription: `Finds TYPE BEGIN with just one INCLUDE TYPE, and DATA with single INCLUDE STRUCTURE`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `TYPES: BEGIN OF dummy1.
-  INCLUDE TYPE dselc.
-TYPES: END OF dummy1.
-
-DATA BEGIN OF foo.
-INCLUDE STRUCTURE syst.
-DATA END OF foo.
-
-STATICS BEGIN OF bar.
-INCLUDE STRUCTURE syst.
+            badExample: `TYPES: BEGIN OF dummy1.
+  INCLUDE TYPE dselc.
+TYPES: END OF dummy1.
+
+DATA BEGIN OF foo.
+INCLUDE STRUCTURE syst.
+DATA END OF foo.
+
+STATICS BEGIN OF bar.
+INCLUDE STRUCTURE syst.
 STATICS END OF bar.`,
-            goodExample: `DATA BEGIN OF foo.
-INCLUDE STRUCTURE dselc.
+            goodExample: `DATA BEGIN OF foo.
+INCLUDE STRUCTURE dselc.
 DATA END OF foo.`,
         };
     }

package/build/src/rules/call_transaction_authority_check.js

@@ -24,9 +24,9 @@ class CallTransactionAuthorityCheck extends _abap_rule_1.ABAPRule {
             extendedInformation: `https://docs.abapopenchecks.org/checks/54/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
             badExample: `CALL TRANSACTION 'FOO'.`,
-            goodExample: `TRY.
-    CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.
-  CATCH cx_sy_authorization_error.
+            goodExample: `TRY.
+    CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.
+  CATCH cx_sy_authorization_error.
 ENDTRY.`,
         };
     }

package/build/src/rules/chain_mainly_declarations.js

@@ -45,10 +45,10 @@ class ChainMainlyDeclarations extends _abap_rule_1.ABAPRule {
             key: "chain_mainly_declarations",
             title: "Chain mainly declarations",
             shortDescription: `Chain mainly declarations, allows chaining for the configured statements, reports errors for other statements.`,
-            extendedInformation: `
-https://docs.abapopenchecks.org/checks/23/
-
-https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
+            extendedInformation: `
+https://docs.abapopenchecks.org/checks/23/
+
+https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
 `,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
             badExample: `CALL METHOD: bar.`,

package/build/src/rules/check_abstract.js

@@ -23,8 +23,8 @@ class CheckAbstract extends _abap_rule_1.ABAPRule {
         return {
             key: "check_abstract",
             title: "Check abstract methods and classes",
-            shortDescription: `Checks abstract methods and classes:
-- class defined as abstract and final,
+            shortDescription: `Checks abstract methods and classes:
+- class defined as abstract and final,
 - non-abstract class contains abstract methods`,
             extendedInformation: `If a class defines only constants, use an interface instead`,
             tags: [_irule_1.RuleTag.SingleFile],

package/build/src/rules/check_comments.js

@@ -27,9 +27,9 @@ class CheckComments extends _abap_rule_1.ABAPRule {
         return {
             key: "check_comments",
             title: "Check Comments",
-            shortDescription: `
-Various checks for comment usage.
-
+            shortDescription: `
+Various checks for comment usage.
+
 * End of line comments. Comments starting with "#EC" or "##" are ignored`,
             extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#put-comments-before-the-statement-they-relate-to`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],

package/build/src/rules/check_include.js

@@ -17,9 +17,9 @@ class CheckInclude {
             key: "check_include",
             title: "Check INCLUDEs",
             shortDescription: `Checks INCLUDE statements`,
-            extendedInformation: `
-* Reports unused includes
-* Errors if the includes are not found
+            extendedInformation: `
+* Reports unused includes
+* Errors if the includes are not found
 * Error if including a main program`,
             tags: [_irule_1.RuleTag.Syntax],
         };

package/build/src/rules/check_no_handler_pragma.js

@@ -21,15 +21,15 @@ class CheckNoHandlerPragma extends _abap_rule_1.ABAPRule {
             title: "Check if NO_HANDLER can be removed",
             shortDescription: `Checks NO_HANDLER pragmas that can be removed`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `TRY.
-    ...
-  CATCH zcx_abapgit_exception ##NO_HANDLER.
-    RETURN. " it has a handler
+            badExample: `TRY.
+    ...
+  CATCH zcx_abapgit_exception ##NO_HANDLER.
+    RETURN. " it has a handler
 ENDTRY.`,
-            goodExample: `TRY.
-    ...
-  CATCH zcx_abapgit_exception.
-    RETURN.
+            goodExample: `TRY.
+    ...
+  CATCH zcx_abapgit_exception.
+    RETURN.
 ENDTRY.`,
         };
     }

package/build/src/rules/check_subrc.js

@@ -34,14 +34,14 @@ class CheckSubrc extends _abap_rule_1.ABAPRule {
             key: "check_subrc",
             title: "Check sy-subrc",
             shortDescription: `Check sy-subrc`,
-            extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
-
-If sy-dbcnt is checked after database statements, it is considered okay.
-
-"SELECT SINGLE @abap_true FROM " is considered as an existence check
-
-If IS ASSIGNED is checked after assigning, it is considered okay.
-
+            extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
+
+If sy-dbcnt is checked after database statements, it is considered okay.
+
+"SELECT SINGLE @abap_true FROM " is considered as an existence check
+
+If IS ASSIGNED is checked after assigning, it is considered okay.
+
 FIND statement with MATCH COUNT is considered okay if subrc is not checked`,
             tags: [_irule_1.RuleTag.SingleFile],
             pseudoComment: "EC CI_SUBRC",

package/build/src/rules/commented_code.js

@@ -30,7 +30,7 @@ class CommentedCode extends _abap_rule_1.ABAPRule {
             key: "commented_code",
             title: "Find commented code",
             shortDescription: `Detects usage of commented out code.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
 https://docs.abapopenchecks.org/checks/14/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/constructor_visibility_public.js

@@ -18,10 +18,10 @@ class ConstructorVisibilityPublic {
             key: "constructor_visibility_public",
             title: "Check constructor visibility is public",
             shortDescription: `Constructor must be placed in the public section, even if the class is not CREATE PUBLIC.`,
-            extendedInformation: `
-This only applies to global classes.
-
-https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
+            extendedInformation: `
+This only applies to global classes.
+
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
 https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abeninstance_constructor_guidl.htm`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/contains_tab.js

@@ -25,8 +25,8 @@ class ContainsTab extends _abap_rule_1.ABAPRule {
             key: "contains_tab",
             title: "Code contains tab",
             shortDescription: `Checks for usage of tabs (enable to enforce spaces)`,
-            extendedInformation: `
-https://docs.abapopenchecks.org/checks/09/
+            extendedInformation: `
+https://docs.abapopenchecks.org/checks/09/
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#indent-and-snap-to-tab`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/dangerous_statement.js

@@ -2,6 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.DangerousStatement = exports.DangerousStatementConf = void 0;
 const Statements = require("../abap/2_statements/statements");
+const Expressions = require("../abap/2_statements/expressions");
 const issue_1 = require("../issue");
 const _abap_rule_1 = require("./_abap_rule");
 const _basic_rule_config_1 = require("./_basic_rule_config");
@@ -24,6 +25,8 @@ class DangerousStatementConf extends _basic_rule_config_1.BasicRuleConfig {
         this.deleteTextpool = true;
         this.deleteDynpro = true;
         this.importDynpro = true;
+        /** Finds instances of dynamic SQL: SELECT, UPDATE, DELETE, INSERT, MODIFY */
+        this.dynamicSQL = true;
     }
 }
 exports.DangerousStatementConf = DangerousStatementConf;
@@ -37,6 +40,8 @@ class DangerousStatement extends _abap_rule_1.ABAPRule {
             key: "dangerous_statement",
             title: "Dangerous statement",
             shortDescription: `Detects potentially dangerous statements`,
+            extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
+dynamic SQL can potentially create SQL injection problems`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
         };
     }
@@ -90,9 +95,29 @@ class DangerousStatement extends _abap_rule_1.ABAPRule {
             if (message) {
                 issues.push(issue_1.Issue.atStatement(file, statementNode, this.getDescription(message), this.getMetadata().key, this.conf.severity));
             }
+            if (this.conf.dynamicSQL) {
+                message = this.findDynamicSQL(statementNode);
+                if (message) {
+                    issues.push(issue_1.Issue.atStatement(file, statementNode, this.getDescription(message), this.getMetadata().key, this.conf.severity));
+                }
+            }
         }
         return issues;
     }
+    findDynamicSQL(statementNode) {
+        const statement = statementNode.get();
+        if (statement instanceof Statements.UpdateDatabase
+            || statement instanceof Statements.Select
+            || statement instanceof Statements.SelectLoop
+            || statement instanceof Statements.InsertDatabase
+            || statement instanceof Statements.ModifyDatabase
+            || statement instanceof Statements.DeleteDatabase) {
+            if (statementNode.findFirstExpression(Expressions.Dynamic)) {
+                return "Dynamic SQL";
+            }
+        }
+        return undefined;
+    }
 }
 exports.DangerousStatement = DangerousStatement;
 //# sourceMappingURL=dangerous_statement.js.map

package/build/src/rules/downport.js

@@ -32,27 +32,27 @@ class Downport {
             key: "downport",
             title: "Downport statement",
             shortDescription: `Experimental downport functionality`,
-            extendedInformation: `Much like the 'commented_code' rule this rule loops through unknown statements and tries parsing with
-a higher level language version. If successful, various rules are applied to downport the statement.
-Target downport version is always v702, thus rule is only enabled if target version is v702.
-
-Current rules:
-* NEW transformed to CREATE OBJECT, opposite of https://rules.abaplint.org/use_new/
-* DATA() definitions are outlined, opposite of https://rules.abaplint.org/prefer_inline/
-* FIELD-SYMBOL() definitions are outlined
-* CONV is outlined
-* COND is outlined
-* REDUCE is outlined
-* EMPTY KEY is changed to DEFAULT KEY, opposite of DEFAULT KEY in https://rules.abaplint.org/avoid_use/
-* CAST changed to ?=
-* LOOP AT method_call( ) is outlined
-* VALUE # with structure fields
-* VALUE # with internal table lines
-* Table Expressions[ index ] are outlined
-* SELECT INTO @DATA definitions are outlined
-* Some occurrences of string template formatting option ALPHA changed to function module call
-* SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
-
+            extendedInformation: `Much like the 'commented_code' rule this rule loops through unknown statements and tries parsing with
+a higher level language version. If successful, various rules are applied to downport the statement.
+Target downport version is always v702, thus rule is only enabled if target version is v702.
+
+Current rules:
+* NEW transformed to CREATE OBJECT, opposite of https://rules.abaplint.org/use_new/
+* DATA() definitions are outlined, opposite of https://rules.abaplint.org/prefer_inline/
+* FIELD-SYMBOL() definitions are outlined
+* CONV is outlined
+* COND is outlined
+* REDUCE is outlined
+* EMPTY KEY is changed to DEFAULT KEY, opposite of DEFAULT KEY in https://rules.abaplint.org/avoid_use/
+* CAST changed to ?=
+* LOOP AT method_call( ) is outlined
+* VALUE # with structure fields
+* VALUE # with internal table lines
+* Table Expressions[ index ] are outlined
+* SELECT INTO @DATA definitions are outlined
+* Some occurrences of string template formatting option ALPHA changed to function module call
+* SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
+
 Only one transformation is applied to a statement at a time, so multiple steps might be required to do the full downport.`,
             tags: [_irule_1.RuleTag.Experimental, _irule_1.RuleTag.Downport, _irule_1.RuleTag.Quickfix],
         };
@@ -306,10 +306,10 @@ Only one transformation is applied to a statement at a time, so multiple steps m
                 const fieldName = f.concatTokens();
                 fieldDefinition += indentation + "        " + fieldName + " TYPE " + tableName + "-" + fieldName + ",\n";
             }
-            fieldDefinition = `DATA: BEGIN OF ${name},
+            fieldDefinition = `DATA: BEGIN OF ${name},
 ${fieldDefinition}${indentation}      END OF ${name}.`;
         }
-        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `${fieldDefinition}
+        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `${fieldDefinition}
 ${indentation}`);
         const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, inlineData.getFirstToken().getStart(), inlineData.getLastToken().getEnd(), name);
         const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -345,9 +345,9 @@ ${indentation}`);
         }
         const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
         const name = ((_c = inlineData.findFirstExpression(Expressions.TargetField)) === null || _c === void 0 ? void 0 : _c.concatTokens()) || "error";
-        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `TYPES: BEGIN OF ${uniqueName},
-${fieldDefinitions}${indentation}      END OF ${uniqueName}.
-${indentation}DATA ${name} TYPE STANDARD TABLE OF ${uniqueName} WITH DEFAULT KEY.
+        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `TYPES: BEGIN OF ${uniqueName},
+${fieldDefinitions}${indentation}      END OF ${uniqueName}.
+${indentation}DATA ${name} TYPE STANDARD TABLE OF ${uniqueName} WITH DEFAULT KEY.
 ${indentation}`);
         const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, inlineData.getFirstToken().getStart(), inlineData.getLastToken().getEnd(), name);
         const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -381,11 +381,11 @@ ${indentation}`);
             const uniqueName = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
             const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
             const firstToken = node.getFirstToken();
-            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${pre}.
-${indentation}READ TABLE ${pre} INDEX ${(_a = tableExpression.findFirstExpression(Expressions.Source)) === null || _a === void 0 ? void 0 : _a.concatTokens()} INTO ${uniqueName}.
-${indentation}IF sy-subrc <> 0.
-${indentation}  RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
-${indentation}ENDIF.
+            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${pre}.
+${indentation}READ TABLE ${pre} INDEX ${(_a = tableExpression.findFirstExpression(Expressions.Source)) === null || _a === void 0 ? void 0 : _a.concatTokens()} INTO ${uniqueName}.
+${indentation}IF sy-subrc <> 0.
+${indentation}  RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
+${indentation}ENDIF.
 ${indentation}`);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, startToken.getStart(), tableExpression.getLastToken().getEnd(), uniqueName);
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -484,10 +484,10 @@ ${indentation}`);
         const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
         const source = (_b = templateSource === null || templateSource === void 0 ? void 0 : templateSource.findDirectExpression(Expressions.Source)) === null || _b === void 0 ? void 0 : _b.concatTokens();
         const topTarget = (_c = node.findDirectExpression(Expressions.Target)) === null || _c === void 0 ? void 0 : _c.concatTokens();
-        const code = `CALL FUNCTION '${functionName}'
-${indentation}  EXPORTING
-${indentation}    input  = ${source}
-${indentation}  IMPORTING
+        const code = `CALL FUNCTION '${functionName}'
+${indentation}  EXPORTING
+${indentation}    input  = ${source}
+${indentation}  IMPORTING
 ${indentation}    output = ${topTarget}.`;
         const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getFirstToken().getStart(), node.getLastToken().getEnd(), code);
         return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Downport ALPHA", this.getMetadata().key, this.conf.severity, fix);

package/build/src/rules/exit_or_check.js

@@ -24,10 +24,10 @@ class ExitOrCheck extends _abap_rule_1.ABAPRule {
         return {
             key: "exit_or_check",
             title: "Find EXIT or CHECK outside loops",
-            shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
+            shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
 Use RETURN to leave procesing blocks instead.`,
-            extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
-https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
+            extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
+https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-return`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
         };

package/build/src/rules/exporting.js

@@ -22,7 +22,7 @@ class Exporting extends _abap_rule_1.ABAPRule {
             shortDescription: `Detects EXPORTING statements which can be omitted.`,
             badExample: `call_method( EXPORTING foo = bar ).`,
             goodExample: `call_method( foo = bar ).`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-optional-keyword-exporting
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-optional-keyword-exporting
 https://docs.abapopenchecks.org/checks/30/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/forbidden_identifier.js

@@ -26,7 +26,7 @@ class ForbiddenIdentifier extends _abap_rule_1.ABAPRule {
             key: "forbidden_identifier",
             title: "Forbidden Identifier",
             shortDescription: `Forbid use of specified identifiers, list of regex.`,
-            extendedInformation: `Used in the transpiler to find javascript keywords in ABAP identifiers,
+            extendedInformation: `Used in the transpiler to find javascript keywords in ABAP identifiers,
 https://github.com/abaplint/transpiler/blob/bda94b8b56e2b7f2f87be2168f12361aa530220e/packages/transpiler/src/validation.ts#L44`,
             tags: [_irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/forbidden_void_type.js

@@ -28,8 +28,8 @@ class ForbiddenVoidType {
             key: "forbidden_void_type",
             title: "Forbidden Void Types",
             shortDescription: `Avoid usage of specified void types.`,
-            extendedInformation: `Inspiration:
-BOOLEAN, BOOLE_D, CHAR01, CHAR1, CHAR10, CHAR12, CHAR128, CHAR2, CHAR20, CHAR4, CHAR70,
+            extendedInformation: `Inspiration:
+BOOLEAN, BOOLE_D, CHAR01, CHAR1, CHAR10, CHAR12, CHAR128, CHAR2, CHAR20, CHAR4, CHAR70,
 DATS, TIMS, DATUM, FLAG, INT4, NUMC3, NUMC4, SAP_BOOL, TEXT25, TEXT80, X255, XFELD`,
         };
     }

package/build/src/rules/functional_writing.js

@@ -28,26 +28,26 @@ class FunctionalWriting extends _abap_rule_1.ABAPRule {
             key: "functional_writing",
             title: "Use functional writing",
             shortDescription: `Detects usage of call method when functional style calls can be used.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-calls
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-calls
 https://docs.abapopenchecks.org/checks/07/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
-            badExample: `CALL METHOD zcl_class=>method( ).
-CALL METHOD cl_abap_typedescr=>describe_by_name
-  EXPORTING
-    p_name         = 'NAME'
-  RECEIVING
-    p_descr_ref    = lr_typedescr
-  EXCEPTIONS
-    type_not_found = 1
+            badExample: `CALL METHOD zcl_class=>method( ).
+CALL METHOD cl_abap_typedescr=>describe_by_name
+  EXPORTING
+    p_name         = 'NAME'
+  RECEIVING
+    p_descr_ref    = lr_typedescr
+  EXCEPTIONS
+    type_not_found = 1
     OTHERS         = 2.`,
-            goodExample: `zcl_class=>method( ).
-cl_abap_typedescr=>describe_by_name(
-  EXPORTING
-    p_name         = 'NAME'
-  RECEIVING
-    p_descr_ref    = lr_typedescr
-  EXCEPTIONS
-    type_not_found = 1
+            goodExample: `zcl_class=>method( ).
+cl_abap_typedescr=>describe_by_name(
+  EXPORTING
+    p_name         = 'NAME'
+  RECEIVING
+    p_descr_ref    = lr_typedescr
+  EXCEPTIONS
+    type_not_found = 1
     OTHERS         = 2 ).`,
         };
     }