@abaplint/core 2.79.29 → 2.79.33

package/build/abaplint.d.ts

@@ -641,7 +641,7 @@ declare class ClassConstant extends TypedIdentifier {
     private readonly visibility;
     constructor(id: TypedIdentifier, visibility: Visibility, value: string | {
         [index: string]: string;
-    });
+    } | undefined);
     getVisibility(): Visibility;
 }
 
@@ -2615,6 +2615,7 @@ declare interface IMethodParameters {
     getOptional(): readonly string[];
     getReturning(): TypedIdentifier | undefined;
     getExceptions(): readonly string[];
+    getFilename(): string;
     getDefaultImporting(): string | undefined;
     getParameterDefault(parameter: string): ExpressionNode | undefined;
 }
@@ -3483,6 +3484,7 @@ declare class MethodParameters_2 implements IMethodParameters {
     private readonly defaults;
     private readonly filename;
     constructor(node: StatementNode, filename: string, scope: CurrentScope);
+    getFilename(): string;
     getOptional(): string[];
     getAll(): TypedIdentifier[];
     getDefaultImporting(): string | undefined;

package/build/src/abap/2_statements/expressions/field_chain.js

@@ -6,9 +6,9 @@ const _1 = require(".");
 const tokens_1 = require("../../1_lexer/tokens");
 class FieldChain extends combi_1.Expression {
     getRunnable() {
-        const attr = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.InstanceArrow), (0, combi_1.altPrio)(_1.AttributeName, "*"));
+        const attr = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.InstanceArrow), _1.AttributeName);
         const comp = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.Dash), (0, combi_1.optPrio)(_1.ComponentName));
-        const chain = (0, combi_1.star)((0, combi_1.altPrio)(attr, comp, _1.TableExpression));
+        const chain = (0, combi_1.star)((0, combi_1.altPrio)(_1.Dereference, attr, comp, _1.TableExpression));
         const clas = (0, combi_1.seq)(_1.ClassName, (0, combi_1.tok)(tokens_1.StaticArrow), _1.AttributeName);
         const start = (0, combi_1.altPrio)(clas, _1.SourceField, _1.SourceFieldSymbol);
         const after = (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.DashW), (0, combi_1.seq)((0, combi_1.optPrio)(_1.TableBody), (0, combi_1.optPrio)(_1.FieldOffset), (0, combi_1.optPrio)(_1.FieldLength)));

package/build/src/abap/5_syntax/basic_types.js

@@ -604,7 +604,7 @@ class BasicTypes {
             throw new Error("VALUE missing in expression");
         }
         if (val.concatTokens().toUpperCase() === "VALUE IS INITIAL") {
-            return "";
+            return undefined;
         }
         const constant = val.findFirstExpression(Expressions.Constant);
         if (constant) {

package/build/src/abap/5_syntax/expressions/field_chain.js

@@ -11,6 +11,8 @@ const _reference_1 = require("../_reference");
 const field_offset_1 = require("./field_offset");
 const field_length_1 = require("./field_length");
 const table_expression_1 = require("./table_expression");
+const expressions_1 = require("../../2_statements/expressions");
+const dereference_1 = require("./dereference");
 class FieldChain {
     runSyntax(node, scope, filename, refType) {
         const concat = node.concatTokens();
@@ -64,6 +66,9 @@ class FieldChain {
                     throw new Error("Not a object reference, field chain");
                 }
             }
+            else if (current.get() instanceof expressions_1.Dereference) {
+                context = new dereference_1.Dereference().runSyntax(context);
+            }
             else if (current.get() instanceof Expressions.ComponentName) {
                 context = new component_name_1.ComponentName().runSyntax(context, current);
             }

package/build/src/abap/types/class_attributes.js

@@ -174,7 +174,7 @@ class Attributes {
                 else if (ctyp instanceof Statements.Constant) {
                     const found = new constant_1.Constant().runSyntax(c, scope, this.filename);
                     if (found) {
-                        const attr = new class_constant_1.ClassConstant(found, visibility, found.getValue() || "todo, constant value fallback");
+                        const attr = new class_constant_1.ClassConstant(found, visibility, found.getValue());
                         this.constants.push(attr);
                         scope.addIdentifier(attr);
                     }

package/build/src/abap/types/method_parameters.js

@@ -29,6 +29,9 @@ class MethodParameters {
         this.filename = filename;
         this.parse(node, scope, filename);
     }
+    getFilename() {
+        return this.filename;
+    }
     getOptional() {
         return this.optional;
     }

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.79.29";
+        return "2.79.33";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/allowed_object_naming.js

@@ -42,7 +42,7 @@ class AllowedObjectNaming {
                 message = "Name not allowed";
             }
         }
-        else if (obj.getName().match(/^(\/[A-Z_\d]{3,8}\/)?[A-Z_\d<> ]+$/i) === null) {
+        else if (obj.getName().match(/^(\/[A-Z_\d]{3,8}\/)?[A-Z_-\d<> ]+$/i) === null) {
             message = "Name not allowed";
         }
         if (message.length > 0) {

package/build/src/rules/call_transaction_authority_check.js

@@ -6,6 +6,7 @@ const _abap_rule_1 = require("./_abap_rule");
 const _irule_1 = require("./_irule");
 const Statements = require("../abap/2_statements/statements");
 const issue_1 = require("../issue");
+const version_1 = require("../version");
 class CallTransactionAuthorityCheckConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.CallTransactionAuthorityCheckConf = CallTransactionAuthorityCheckConf;
@@ -13,6 +14,7 @@ class CallTransactionAuthorityCheck extends _abap_rule_1.ABAPRule {
     constructor() {
         super(...arguments);
         this.conf = new CallTransactionAuthorityCheckConf();
+        this.MINIMUM_VERSION = version_1.Version.v740sp02;
     }
     getMetadata() {
         return {
@@ -22,7 +24,10 @@ class CallTransactionAuthorityCheck extends _abap_rule_1.ABAPRule {
             extendedInformation: `https://docs.abapopenchecks.org/checks/54/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
             badExample: `CALL TRANSACTION 'FOO'.`,
-            goodExample: `CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.`,
+            goodExample: `TRY.
+    CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.
+  CATCH cx_sy_authorization_error.
+ENDTRY.`,
         };
     }
     getMessage() {
@@ -35,6 +40,11 @@ class CallTransactionAuthorityCheck extends _abap_rule_1.ABAPRule {
         this.conf = conf;
     }
     runParsed(file, obj) {
+        const currentVersion = this.reg.getConfig().getVersion();
+        // Cloud version does not support CALL TRANSACTION
+        if (currentVersion < this.MINIMUM_VERSION || currentVersion === version_1.Version.Cloud) {
+            return [];
+        }
         const issues = [];
         if (obj.getType() === "INTF") {
             return [];

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.79.29",
+    "version": "2.79.33",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -57,18 +57,18 @@
         "@microsoft/api-extractor": "^7.18.16",
         "@types/chai": "^4.2.22",
         "@types/mocha": "^9.0.0",
-        "@types/node": "^16.10.9",
+        "@types/node": "^16.11.6",
         "chai": "^4.3.4",
-        "eslint": "^8.0.1",
+        "eslint": "^8.1.0",
         "madge": "^5.0.1",
-        "mocha": "^9.1.2",
+        "mocha": "^9.1.3",
         "c8": "^7.10.0",
         "source-map-support": "^0.5.20",
         "ts-json-schema-generator": "^0.96.0",
         "typescript": "^4.4.4"
     },
     "dependencies": {
-        "fast-xml-parser": "^3.20.3",
+        "fast-xml-parser": "^3.21.0",
         "json5": "^2.2.0",
         "vscode-languageserver-protocol": "^3.16.0",
         "vscode-languageserver-types": "^3.16.0"