@abaplint/core 2.79.22 → 2.79.23

package/README.md

@@ -1,7 +1,7 @@
-# @abaplint/core
-
-[abaplint](https://abaplint.org/) core library
-
-Exposes functionallity like the parser and rules, which can be used in other projects.
-
+# @abaplint/core
+
+[abaplint](https://abaplint.org/) core library
+
+Exposes functionallity like the parser and rules, which can be used in other projects.
+
 For more information see https://github.com/abaplint/abaplint

package/build/abaplint.d.ts

@@ -1764,6 +1764,7 @@ declare namespace Expressions {
         ReceiveParameters,
         Redefinition,
         ReduceBody,
+        ReduceNext,
         ReportName,
         SelectLoop_2 as SelectLoop,
         Select_3 as Select,
@@ -4086,6 +4087,10 @@ declare class ReduceBody extends Expression {
     getRunnable(): IStatementRunnable;
 }
 
+declare class ReduceNext extends Expression {
+    getRunnable(): IStatementRunnable;
+}
+
 export declare enum ReferenceType {
     /** for classes and interface references */
     ObjectOrientedReference = "ObjectOrientedReference",

package/build/src/abap/2_statements/expressions/index.js

@@ -137,6 +137,7 @@ __exportStar(require("./read_table_target"), exports);
 __exportStar(require("./receive_parameters"), exports);
 __exportStar(require("./redefinition"), exports);
 __exportStar(require("./reduce_body"), exports);
+__exportStar(require("./reduce_next"), exports);
 __exportStar(require("./report_name"), exports);
 __exportStar(require("./select_loop"), exports);
 __exportStar(require("./select"), exports);

package/build/src/abap/2_statements/expressions/reduce_body.js

@@ -3,11 +3,11 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.ReduceBody = void 0;
 const combi_1 = require("../combi");
 const _1 = require(".");
+const reduce_next_1 = require("./reduce_next");
 class ReduceBody extends combi_1.Expression {
     getRunnable() {
-        const fields = (0, combi_1.seq)(_1.Field, "=", _1.Source);
         const init = (0, combi_1.seq)("INIT", (0, combi_1.plus)(_1.InlineFieldDefinition));
-        return (0, combi_1.seq)((0, combi_1.opt)(_1.Let), init, _1.For, "NEXT", (0, combi_1.plus)(fields));
+        return (0, combi_1.seq)((0, combi_1.opt)(_1.Let), init, _1.For, reduce_next_1.ReduceNext);
     }
 }
 exports.ReduceBody = ReduceBody;

package/build/src/abap/2_statements/expressions/reduce_next.js

@@ -0,0 +1,13 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.ReduceNext = void 0;
+const combi_1 = require("../combi");
+const _1 = require(".");
+class ReduceNext extends combi_1.Expression {
+    getRunnable() {
+        const fields = (0, combi_1.seq)(_1.Field, "=", _1.Source);
+        return (0, combi_1.seq)("NEXT", (0, combi_1.plus)(fields));
+    }
+}
+exports.ReduceNext = ReduceNext;
+//# sourceMappingURL=reduce_next.js.map

package/build/src/abap/5_syntax/expressions/reduce_body.js

@@ -7,6 +7,7 @@ const source_1 = require("./source");
 const inline_field_definition_1 = require("./inline_field_definition");
 const unknown_type_1 = require("../../types/basic/unknown_type");
 const _scope_type_1 = require("../_scope_type");
+const reduce_next_1 = require("./reduce_next");
 class ReduceBody {
     runSyntax(node, scope, filename) {
         if (node === undefined) {
@@ -22,6 +23,9 @@ class ReduceBody {
         for (const s of node.findDirectExpressions(Expressions.Source)) {
             new source_1.Source().runSyntax(s, scope, filename);
         }
+        for (const s of node.findDirectExpressions(Expressions.ReduceNext)) {
+            new reduce_next_1.ReduceNext().runSyntax(s, scope, filename);
+        }
         if (scope.getType() === _scope_type_1.ScopeType.For) {
             scope.pop(node.getLastToken().getEnd());
         }

package/build/src/abap/5_syntax/expressions/reduce_next.js

@@ -0,0 +1,17 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.ReduceNext = void 0;
+const Expressions = require("../../2_statements/expressions");
+const source_1 = require("./source");
+class ReduceNext {
+    runSyntax(node, scope, filename) {
+        if (node === undefined) {
+            return;
+        }
+        for (const s of node.findDirectExpressions(Expressions.Source)) {
+            new source_1.Source().runSyntax(s, scope, filename);
+        }
+    }
+}
+exports.ReduceNext = ReduceNext;
+//# sourceMappingURL=reduce_next.js.map

package/build/src/lsp/help.js

@@ -9,13 +9,13 @@ const dump_scope_1 = require("./dump_scope");
 class Help {
     static find(reg, textDocument, position) {
         let content = "";
-        content = `
-    <a href="#_tokens" rel="no-refresh">Tokens</a> |
-    <a href="#_statements" rel="no-refresh">Statements</a> |
-    <a href="#_structure" rel="no-refresh">Structure</a> |
-    <a href="#_files" rel="no-refresh">Files</a> |
-    <a href="#_info" rel="no-refresh">Info Dump</a>
-    <hr>
+        content = `
+    <a href="#_tokens" rel="no-refresh">Tokens</a> |
+    <a href="#_statements" rel="no-refresh">Statements</a> |
+    <a href="#_structure" rel="no-refresh">Structure</a> |
+    <a href="#_files" rel="no-refresh">Files</a> |
+    <a href="#_info" rel="no-refresh">Info Dump</a>
+    <hr>
     ` +
             "<tt>" + textDocument.uri + " (" +
             (position.line + 1) + ", " +

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.79.22";
+        return "2.79.23";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/abapdoc.js

@@ -23,7 +23,7 @@ class Abapdoc extends _abap_rule_1.ABAPRule {
         return {
             key: "abapdoc",
             title: "Check abapdoc",
-            shortDescription: `Various checks regarding abapdoc.
+            shortDescription: `Various checks regarding abapdoc.
 Base rule checks for existence of abapdoc for public class methods and all interface methods.`,
             tags: [_irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/ambiguous_statement.js

@@ -20,14 +20,14 @@ class AmbiguousStatement extends _abap_rule_1.ABAPRule {
         return {
             key: "ambiguous_statement",
             title: "Check for ambigious statements",
-            shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
-Add "TABLE" keyword or "@" for escaping SQL variables
-
+            shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
+Add "TABLE" keyword or "@" for escaping SQL variables
+
 Only works if the target version is 740sp05 or above`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `DELETE foo FROM bar.
+            badExample: `DELETE foo FROM bar.
 MODIFY foo FROM bar.`,
-            goodExample: `DELETE foo FROM @bar.
+            goodExample: `DELETE foo FROM @bar.
 MODIFY TABLE foo FROM bar.`,
         };
     }

package/build/src/rules/avoid_use.js

@@ -35,12 +35,12 @@ class AvoidUse extends _abap_rule_1.ABAPRule {
             key: "avoid_use",
             title: "Avoid use of certain statements",
             shortDescription: `Detects usage of certain statements.`,
-            extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
-
-Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
-
-STATICS: use CLASS-DATA instead
-
+            extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
+
+Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
+
+STATICS: use CLASS-DATA instead
+
 DESCRIBE TABLE LINES: use lines() instead (quickfix exists)`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/begin_end_names.js

@@ -23,11 +23,11 @@ class BeginEndNames extends _abap_rule_1.ABAPRule {
             title: "Check BEGIN END names",
             shortDescription: `Check BEGIN OF and END OF names match, plus there must be statements between BEGIN and END`,
             tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
-            badExample: `DATA: BEGIN OF stru,
-      field TYPE i,
+            badExample: `DATA: BEGIN OF stru,
+      field TYPE i,
     END OF structure_not_the_same.`,
-            goodExample: `DATA: BEGIN OF stru,
-      field TYPE i,
+            goodExample: `DATA: BEGIN OF stru,
+      field TYPE i,
     END OF stru.`,
         };
     }

package/build/src/rules/begin_single_include.js

@@ -21,19 +21,19 @@ class BeginSingleInclude extends _abap_rule_1.ABAPRule {
             title: "BEGIN contains single INCLUDE",
             shortDescription: `Finds TYPE BEGIN with just one INCLUDE TYPE, and DATA with single INCLUDE STRUCTURE`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `TYPES: BEGIN OF dummy1.
-  INCLUDE TYPE dselc.
-TYPES: END OF dummy1.
-
-DATA BEGIN OF foo.
-INCLUDE STRUCTURE syst.
-DATA END OF foo.
-
-STATICS BEGIN OF bar.
-INCLUDE STRUCTURE syst.
+            badExample: `TYPES: BEGIN OF dummy1.
+  INCLUDE TYPE dselc.
+TYPES: END OF dummy1.
+
+DATA BEGIN OF foo.
+INCLUDE STRUCTURE syst.
+DATA END OF foo.
+
+STATICS BEGIN OF bar.
+INCLUDE STRUCTURE syst.
 STATICS END OF bar.`,
-            goodExample: `DATA BEGIN OF foo.
-INCLUDE STRUCTURE dselc.
+            goodExample: `DATA BEGIN OF foo.
+INCLUDE STRUCTURE dselc.
 DATA END OF foo.`,
         };
     }

package/build/src/rules/chain_mainly_declarations.js

@@ -45,10 +45,10 @@ class ChainMainlyDeclarations extends _abap_rule_1.ABAPRule {
             key: "chain_mainly_declarations",
             title: "Chain mainly declarations",
             shortDescription: `Chain mainly declarations, allows chaining for the configured statements, reports errors for other statements.`,
-            extendedInformation: `
-https://docs.abapopenchecks.org/checks/23/
-
-https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
+            extendedInformation: `
+https://docs.abapopenchecks.org/checks/23/
+
+https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenchained_statements_guidl.htm
 `,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
             badExample: `CALL METHOD: bar.`,

package/build/src/rules/check_abstract.js

@@ -23,8 +23,8 @@ class CheckAbstract extends _abap_rule_1.ABAPRule {
         return {
             key: "check_abstract",
             title: "Check abstract methods and classes",
-            shortDescription: `Checks abstract methods and classes:
-- class defined as abstract and final,
+            shortDescription: `Checks abstract methods and classes:
+- class defined as abstract and final,
 - non-abstract class contains abstract methods`,
             extendedInformation: `If a class defines only constants, use an interface instead`,
             tags: [_irule_1.RuleTag.SingleFile],

package/build/src/rules/check_comments.js

@@ -27,9 +27,9 @@ class CheckComments extends _abap_rule_1.ABAPRule {
         return {
             key: "check_comments",
             title: "Check Comments",
-            shortDescription: `
-Various checks for comment usage.
-
+            shortDescription: `
+Various checks for comment usage.
+
 * End of line comments. Comments starting with "#EC" or "##" are ignored`,
             extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#put-comments-before-the-statement-they-relate-to`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],

package/build/src/rules/check_include.js

@@ -17,9 +17,9 @@ class CheckInclude {
             key: "check_include",
             title: "Check INCLUDEs",
             shortDescription: `Checks INCLUDE statements`,
-            extendedInformation: `
-* Reports unused includes
-* Errors if the includes are not found
+            extendedInformation: `
+* Reports unused includes
+* Errors if the includes are not found
 * Error if including a main program`,
             tags: [_irule_1.RuleTag.Syntax],
         };

package/build/src/rules/check_no_handler_pragma.js

@@ -21,15 +21,15 @@ class CheckNoHandlerPragma extends _abap_rule_1.ABAPRule {
             title: "Check if NO_HANDLER can be removed",
             shortDescription: `Checks NO_HANDLER pragmas that can be removed`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `TRY.
-    ...
-  CATCH zcx_abapgit_exception ##NO_HANDLER.
-    RETURN. " it has a handler
+            badExample: `TRY.
+    ...
+  CATCH zcx_abapgit_exception ##NO_HANDLER.
+    RETURN. " it has a handler
 ENDTRY.`,
-            goodExample: `TRY.
-    ...
-  CATCH zcx_abapgit_exception.
-    RETURN.
+            goodExample: `TRY.
+    ...
+  CATCH zcx_abapgit_exception.
+    RETURN.
 ENDTRY.`,
         };
     }

package/build/src/rules/check_subrc.js

@@ -34,14 +34,14 @@ class CheckSubrc extends _abap_rule_1.ABAPRule {
             key: "check_subrc",
             title: "Check sy-subrc",
             shortDescription: `Check sy-subrc`,
-            extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
-
-If sy-dbcnt is checked after database statements, it is considered okay.
-
-"SELECT SINGLE @abap_true FROM " is considered as an existence check
-
-If IS ASSIGNED is checked after assigning, it is considered okay.
-
+            extendedInformation: `Pseudo comment "#EC CI_SUBRC can be added to suppress findings
+
+If sy-dbcnt is checked after database statements, it is considered okay.
+
+"SELECT SINGLE @abap_true FROM " is considered as an existence check
+
+If IS ASSIGNED is checked after assigning, it is considered okay.
+
 FIND statement with MATCH COUNT is considered okay if subrc is not checked`,
             tags: [_irule_1.RuleTag.SingleFile],
             pseudoComment: "EC CI_SUBRC",

package/build/src/rules/commented_code.js

@@ -30,7 +30,7 @@ class CommentedCode extends _abap_rule_1.ABAPRule {
             key: "commented_code",
             title: "Find commented code",
             shortDescription: `Detects usage of commented out code.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
 https://docs.abapopenchecks.org/checks/14/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/constructor_visibility_public.js

@@ -18,10 +18,10 @@ class ConstructorVisibilityPublic {
             key: "constructor_visibility_public",
             title: "Check constructor visibility is public",
             shortDescription: `Constructor must be placed in the public section, even if the class is not CREATE PUBLIC.`,
-            extendedInformation: `
-This only applies to global classes.
-
-https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
+            extendedInformation: `
+This only applies to global classes.
+
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
 https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abeninstance_constructor_guidl.htm`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/contains_tab.js

@@ -25,8 +25,8 @@ class ContainsTab extends _abap_rule_1.ABAPRule {
             key: "contains_tab",
             title: "Code contains tab",
             shortDescription: `Checks for usage of tabs (enable to enforce spaces)`,
-            extendedInformation: `
-https://docs.abapopenchecks.org/checks/09/
+            extendedInformation: `
+https://docs.abapopenchecks.org/checks/09/
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#indent-and-snap-to-tab`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/downport.js

@@ -19,6 +19,7 @@ const _typed_identifier_1 = require("../abap/types/_typed_identifier");
 const basic_1 = require("../abap/types/basic");
 const config_1 = require("../config");
 const tokens_1 = require("../abap/1_lexer/tokens");
+// todo: refactor each sub-rule to new classes
 class DownportConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.DownportConf = DownportConf;
@@ -31,26 +32,27 @@ class Downport {
             key: "downport",
             title: "Downport statement",
             shortDescription: `Experimental downport functionality`,
-            extendedInformation: `Much like the 'commented_code' rule this rule loops through unknown statements and tries parsing with
-a higher level language version. If successful, various rules are applied to downport the statement.
-Target downport version is always v702, thus rule is only enabled if target version is v702.
-
-Current rules:
-* NEW transformed to CREATE OBJECT, opposite of https://rules.abaplint.org/use_new/
-* DATA() definitions are outlined, opposite of https://rules.abaplint.org/prefer_inline/
-* FIELD-SYMBOL() definitions are outlined
-* CONV is outlined
-* COND is outlined
-* EMPTY KEY is changed to DEFAULT KEY, opposite of DEFAULT KEY in https://rules.abaplint.org/avoid_use/
-* CAST changed to ?=
-* LOOP AT method_call( ) is outlined
-* VALUE # with structure fields
-* VALUE # with internal table lines
-* Table Expressions[ index ] are outlined
-* SELECT INTO @DATA definitions are outlined
-* Some occurrences of string template formatting option ALPHA changed to function module call
-* SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
-
+            extendedInformation: `Much like the 'commented_code' rule this rule loops through unknown statements and tries parsing with
+a higher level language version. If successful, various rules are applied to downport the statement.
+Target downport version is always v702, thus rule is only enabled if target version is v702.
+
+Current rules:
+* NEW transformed to CREATE OBJECT, opposite of https://rules.abaplint.org/use_new/
+* DATA() definitions are outlined, opposite of https://rules.abaplint.org/prefer_inline/
+* FIELD-SYMBOL() definitions are outlined
+* CONV is outlined
+* COND is outlined
+* REDUCE is outlined
+* EMPTY KEY is changed to DEFAULT KEY, opposite of DEFAULT KEY in https://rules.abaplint.org/avoid_use/
+* CAST changed to ?=
+* LOOP AT method_call( ) is outlined
+* VALUE # with structure fields
+* VALUE # with internal table lines
+* Table Expressions[ index ] are outlined
+* SELECT INTO @DATA definitions are outlined
+* Some occurrences of string template formatting option ALPHA changed to function module call
+* SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
+
 Only one transformation is applied to a statement at a time, so multiple steps might be required to do the full downport.`,
             tags: [_irule_1.RuleTag.Experimental, _irule_1.RuleTag.Downport, _irule_1.RuleTag.Quickfix],
         };
@@ -169,6 +171,10 @@ Only one transformation is applied to a statement at a time, so multiple steps m
         if (found) {
             return found;
         }
+        found = this.outlineReduce(high, lowFile, highSyntax);
+        if (found) {
+            return found;
+        }
         found = this.outlineCast(high, lowFile, highSyntax);
         if (found) {
             return found;
@@ -300,10 +306,10 @@ Only one transformation is applied to a statement at a time, so multiple steps m
                 const fieldName = f.concatTokens();
                 fieldDefinition += indentation + "        " + fieldName + " TYPE " + tableName + "-" + fieldName + ",\n";
             }
-            fieldDefinition = `DATA: BEGIN OF ${name},
+            fieldDefinition = `DATA: BEGIN OF ${name},
 ${fieldDefinition}${indentation}      END OF ${name}.`;
         }
-        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `${fieldDefinition}
+        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `${fieldDefinition}
 ${indentation}`);
         const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, inlineData.getFirstToken().getStart(), inlineData.getLastToken().getEnd(), name);
         const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -339,9 +345,9 @@ ${indentation}`);
         }
         const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
         const name = ((_c = inlineData.findFirstExpression(Expressions.TargetField)) === null || _c === void 0 ? void 0 : _c.concatTokens()) || "error";
-        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `TYPES: BEGIN OF ${uniqueName},
-${fieldDefinitions}${indentation}      END OF ${uniqueName}.
-${indentation}DATA ${name} TYPE STANDARD TABLE OF ${uniqueName} WITH DEFAULT KEY.
+        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `TYPES: BEGIN OF ${uniqueName},
+${fieldDefinitions}${indentation}      END OF ${uniqueName}.
+${indentation}DATA ${name} TYPE STANDARD TABLE OF ${uniqueName} WITH DEFAULT KEY.
 ${indentation}`);
         const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, inlineData.getFirstToken().getStart(), inlineData.getLastToken().getEnd(), name);
         const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -375,11 +381,11 @@ ${indentation}`);
             const uniqueName = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
             const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
             const firstToken = node.getFirstToken();
-            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${pre}.
-${indentation}READ TABLE ${pre} INDEX ${(_a = tableExpression.findFirstExpression(Expressions.Source)) === null || _a === void 0 ? void 0 : _a.concatTokens()} INTO ${uniqueName}.
-${indentation}IF sy-subrc <> 0.
-${indentation}  RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
-${indentation}ENDIF.
+            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${pre}.
+${indentation}READ TABLE ${pre} INDEX ${(_a = tableExpression.findFirstExpression(Expressions.Source)) === null || _a === void 0 ? void 0 : _a.concatTokens()} INTO ${uniqueName}.
+${indentation}IF sy-subrc <> 0.
+${indentation}  RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
+${indentation}ENDIF.
 ${indentation}`);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, startToken.getStart(), tableExpression.getLastToken().getEnd(), uniqueName);
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -478,10 +484,10 @@ ${indentation}`);
         const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
         const source = (_b = templateSource === null || templateSource === void 0 ? void 0 : templateSource.findDirectExpression(Expressions.Source)) === null || _b === void 0 ? void 0 : _b.concatTokens();
         const topTarget = (_c = node.findDirectExpression(Expressions.Target)) === null || _c === void 0 ? void 0 : _c.concatTokens();
-        const code = `CALL FUNCTION '${functionName}'
-${indentation}  EXPORTING
-${indentation}    input  = ${source}
-${indentation}  IMPORTING
+        const code = `CALL FUNCTION '${functionName}'
+${indentation}  EXPORTING
+${indentation}    input  = ${source}
+${indentation}  IMPORTING
 ${indentation}    output = ${topTarget}.`;
         const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getFirstToken().getStart(), node.getLastToken().getEnd(), code);
         return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Downport ALPHA", this.getMetadata().key, this.conf.severity, fix);
@@ -541,6 +547,66 @@ ${indentation}    output = ${topTarget}.`;
         }
         return undefined;
     }
+    outlineReduce(node, lowFile, highSyntax) {
+        var _a, _b, _c;
+        for (const i of node.findAllExpressionsRecursive(Expressions.Source)) {
+            const firstToken = i.getFirstToken();
+            if (firstToken.getStr().toUpperCase() !== "REDUCE") {
+                continue;
+            }
+            const type = this.findType(i, lowFile, highSyntax);
+            if (type === undefined) {
+                continue;
+            }
+            const uniqueName = this.uniqueName(firstToken.getStart(), lowFile.getFilename(), highSyntax);
+            const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
+            let body = "";
+            let name = "";
+            const reduceBody = i.findDirectExpression(Expressions.ReduceBody);
+            if (reduceBody === undefined) {
+                continue;
+            }
+            for (const init of reduceBody.findDirectExpressions(Expressions.InlineFieldDefinition)) {
+                name = init.getFirstToken().getStr();
+                body += indentation + `DATA(${name}) = ${(_a = reduceBody.findFirstExpression(Expressions.Source)) === null || _a === void 0 ? void 0 : _a.concatTokens()}.\n`;
+            }
+            const loop = reduceBody.findFirstExpression(Expressions.InlineLoopDefinition);
+            if (loop === undefined) {
+                continue;
+            }
+            const loopSource = (_b = loop.findFirstExpression(Expressions.Source)) === null || _b === void 0 ? void 0 : _b.concatTokens();
+            const loopTarget = (_c = loop.findFirstExpression(Expressions.TargetField)) === null || _c === void 0 ? void 0 : _c.concatTokens();
+            body += indentation + `LOOP AT ${loopSource} INTO DATA(${loopTarget}).\n`;
+            const next = reduceBody.findDirectExpression(Expressions.ReduceNext);
+            if (next === undefined) {
+                continue;
+            }
+            for (const n of next.getChildren()) {
+                if (n.concatTokens().toUpperCase() === "NEXT") {
+                    continue;
+                }
+                else if (n.concatTokens() === "=") {
+                    body += " = ";
+                }
+                else if (n.get() instanceof Expressions.Field) {
+                    body += indentation + "  " + n.concatTokens();
+                }
+                else if (n.get() instanceof Expressions.Source) {
+                    body += n.concatTokens() + ".\n";
+                }
+            }
+            body += indentation + `ENDLOOP.\n`;
+            body += indentation + `${uniqueName} = ${name}.\n`;
+            const abap = `DATA ${uniqueName} TYPE ${type}.\n` +
+                body +
+                indentation;
+            const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getFirstToken().getStart(), abap);
+            const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, firstToken.getStart(), i.getLastToken().getEnd(), uniqueName);
+            const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
+            return issue_1.Issue.atToken(lowFile, firstToken, "Downport REDUCE", this.getMetadata().key, this.conf.severity, fix);
+        }
+        return undefined;
+    }
     outlineValue(node, lowFile, highSyntax) {
         var _a;
         for (const i of node.findAllExpressionsRecursive(Expressions.Source)) {
@@ -570,10 +636,13 @@ ${indentation}    output = ${topTarget}.`;
                     }
                     body += indentation + structureName + "-" + b.concatTokens() + ".\n";
                 }
-                if (b.get() instanceof Expressions.Source) {
+                else if (b.get() instanceof Expressions.Source) {
                     structureName = b.concatTokens();
                 }
-                if (b.concatTokens() === ")") {
+                else if (b instanceof nodes_1.ExpressionNode && b.get() instanceof Expressions.Let) {
+                    body += this.outlineLet(b, indentation, highSyntax, lowFile);
+                }
+                else if (b.concatTokens() === ")") {
                     body += indentation + `APPEND ${structureName} TO ${uniqueName}.\n`;
                 }
             }
@@ -587,6 +656,32 @@ ${indentation}    output = ${topTarget}.`;
         }
         return undefined;
     }
+    outlineLet(node, indentation, highSyntax, lowFile) {
+        var _a;
+        let ret = "";
+        for (const f of node.findDirectExpressions(Expressions.InlineFieldDefinition)) {
+            const c = f.getFirstChild();
+            if (c === undefined) {
+                continue;
+            }
+            const name = c.concatTokens().toLowerCase();
+            const spag = highSyntax.spaghetti.lookupPosition(c.getFirstToken().getStart(), lowFile.getFilename());
+            if (spag === undefined) {
+                continue;
+            }
+            const found = spag.findVariable(name);
+            if (found === undefined) {
+                continue;
+            }
+            const type = found.getType().getQualifiedName() ? (_a = found.getType().getQualifiedName()) === null || _a === void 0 ? void 0 : _a.toLowerCase() : found.getType().toABAP();
+            ret += indentation + "DATA " + name + ` TYPE ${type}.\n`;
+            const source = node.findFirstExpression(Expressions.Source);
+            if (source) {
+                ret += indentation + name + ` = ${source.concatTokens()}.\n`;
+            }
+        }
+        return ret;
+    }
     findType(i, lowFile, highSyntax) {
         var _a;
         const expr = i.findDirectExpression(Expressions.TypeNameOrInfer);

package/build/src/rules/exit_or_check.js

@@ -24,10 +24,10 @@ class ExitOrCheck extends _abap_rule_1.ABAPRule {
         return {
             key: "exit_or_check",
             title: "Find EXIT or CHECK outside loops",
-            shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
+            shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
 Use RETURN to leave procesing blocks instead.`,
-            extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
-https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
+            extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
+https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-return`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
         };