@abaplint/core 2.79.1 → 2.79.2

package/build/src/abap/5_syntax/expressions/field_assignment.js

@@ -18,6 +18,12 @@ class FieldAssignment {
         let type = undefined;
         if (targetType instanceof basic_1.StructureType) {
             type = targetType.getComponentByName(name);
+            if (type === undefined && targetType.containsVoid() === false) {
+                throw new Error(`field ${name} does not exist in structure`);
+            }
+        }
+        else if (targetType instanceof basic_1.VoidType) {
+            type = targetType;
         }
         new source_1.Source().runSyntax(s, scope, filename, type);
     }

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.79.1";
+        return "2.79.2";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/constant_classes.js

@@ -62,8 +62,20 @@ class ConstantClasses {
                 // possibly this is not even a domain with fixed values
                 issues.push(issue_1.Issue.atStatement(classContents, classContents.getStatements()[0], `Domain ${configEntry.domain} does not contain any fixed values. Either add some values or disable this check`, this.getMetadata().key, this.conf.severity));
             }
+            // later we will raise an issue if we did not find it
+            let domainNameConstantFound = false;
             for (const constant of def.constants) {
-                if (configEntry.useExactType && constant.typeName !== configEntry.domain) {
+                if (configEntry.constantForDomainName
+                    && constant.name === configEntry.constantForDomainName) {
+                    // we require the constant value to be uppercase just in case
+                    // in the config it does not matter
+                    if (constant.value !== configEntry.domain.toLocaleUpperCase()) {
+                        issues.push(this.issueAtConstant(constant, `Constant value ${constant.value} must match domain name ${configEntry.domain} `));
+                    }
+                    domainNameConstantFound = true;
+                    continue;
+                }
+                if (configEntry.useExactType && constant.typeName.toLowerCase() !== configEntry.domain.toLowerCase()) {
                     issues.push(this.issueAtConstant(constant, `Use exact type ${configEntry.domain} instead of ${constant.typeName}`));
                     // quickfix will change the type
                 }
@@ -78,10 +90,13 @@ class ConstantClasses {
             }
             for (const d of domainValueInfo) {
                 if (!def.constants.find(c => c.value === d.value)) {
-                    issues.push(issue_1.Issue.atStatement(classContents, classContents.getStatements()[0], `Missing constant for ${d} (domain ${configEntry.domain})`, this.getMetadata().key, this.conf.severity));
+                    issues.push(issue_1.Issue.atStatement(classContents, classContents.getStatements()[0], `Missing constant for ${d.value} (domain ${configEntry.domain})`, this.getMetadata().key, this.conf.severity));
                     // quickfix will add constant
                 }
             }
+            if (configEntry.constantForDomainName && !domainNameConstantFound) {
+                issues.push(issue_1.Issue.atStatement(classContents, classContents.getStatements()[0], `Missing constant ${configEntry.constantForDomainName} for name of domain ${configEntry.domain}`, this.getMetadata().key, this.conf.severity));
+            }
             return issues;
         }
         return [];

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.79.1",
+    "version": "2.79.2",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",