@abaplint/core 2.78.13 → 2.79.3

package/build/abaplint.d.ts

@@ -1350,6 +1350,13 @@ declare class Domain extends AbstractObject {
         updated: boolean;
         runtime: number;
     };
+    getFixedValues(): DomainValue[];
+}
+
+declare interface DomainValue {
+    language: string;
+    value: string;
+    description: string;
 }
 
 declare class Dynamic extends Expression {
@@ -2543,6 +2550,16 @@ export declare interface IInterfaceDefinition extends Identifier {
     getImplementing(): readonly IImplementing[];
 }
 
+declare interface IIssueData {
+    filename: string;
+    message: string;
+    key: string;
+    start: Position;
+    end: Position;
+    severity: Severity;
+    fix?: IEdit;
+}
+
 declare interface IKeyword {
     word: string;
     source: string[];
@@ -2628,6 +2645,7 @@ declare namespace Info {
         InfoMethodParameter,
         InfoMethodDefinition,
         InfoInterfaceDefinition,
+        InfoConstant,
         InfoAlias,
         InfoImplementing,
         InfoClassDefinition,
@@ -2667,6 +2685,14 @@ declare interface InfoClassImplementation {
     methods: readonly Identifier[];
 }
 
+declare interface InfoConstant {
+    identifier: Identifier;
+    name: string;
+    typeName: string;
+    visibility: Visibility;
+    value: string;
+}
+
 declare interface InfoFormDefinition {
     name: string;
     identifier: Identifier;
@@ -2688,6 +2714,7 @@ declare interface InfoInterfaceDefinition {
     interfaces: readonly InfoImplementing[];
     methods: readonly InfoMethodDefinition[];
     aliases: readonly InfoAlias[];
+    constants: readonly InfoConstant[];
     attributes: readonly InfoAttribute[];
 }
 
@@ -3073,7 +3100,8 @@ export declare class Issue {
     static atRange(file: IFile, start: Position, end: Position, message: string, key: string, severity?: Severity, fix?: IEdit): Issue;
     static atToken(file: IFile, token: Token, message: string, key: string, severity?: Severity, fix?: IEdit): Issue;
     static atIdentifier(identifier: Identifier, message: string, key: string, severity?: Severity, fix?: IEdit): Issue;
-    private constructor();
+    constructor(data: IIssueData);
+    getData(): IIssueData;
     getMessage(): string;
     getKey(): string;
     getStart(): Position;
@@ -3646,6 +3674,7 @@ declare namespace Objects {
         DataElement,
         DialogModule,
         Documentation,
+        DomainValue,
         Domain,
         EcattTestConfiguration,
         EcattTestDataContainer,
@@ -5660,6 +5689,7 @@ export declare enum Version {
     v753 = "v753",
     v754 = "v754",
     v755 = "v755",
+    v756 = "v756",
     Cloud = "Cloud"
 }
 

package/build/src/abap/4_file_information/abap_file_information.js

@@ -76,7 +76,7 @@ class ABAPFileInformation {
             this.implementations.push({
                 name: name.getStr(),
                 identifier: new _identifier_1.Identifier(name, this.filename),
-                methods
+                methods,
             });
         }
         for (const statement of structure.findAllStructures(Structures.Form)) {
@@ -100,6 +100,7 @@ class ABAPFileInformation {
             const methods = this.parseMethodDefinition(found, visibility_1.Visibility.Public);
             const attributes = this.parseAttributes(found, visibility_1.Visibility.Public);
             const aliases = this.parseAliases(found, visibility_1.Visibility.Public);
+            const constants = this.parseConstants(found, visibility_1.Visibility.Public);
             const g = i.findDirectExpression(Expressions.ClassGlobal);
             this.interfaces.push({
                 name: interfaceName.getStr(),
@@ -109,6 +110,7 @@ class ABAPFileInformation {
                 interfaces: this.getImplementing(found),
                 aliases,
                 methods,
+                constants,
                 attributes,
             });
         }
@@ -126,6 +128,9 @@ class ABAPFileInformation {
             const aliases = this.parseAliases(found.findFirstStructure(Structures.PublicSection), visibility_1.Visibility.Public);
             aliases.push(...this.parseAliases(found.findFirstStructure(Structures.ProtectedSection), visibility_1.Visibility.Protected));
             aliases.push(...this.parseAliases(found.findFirstStructure(Structures.PrivateSection), visibility_1.Visibility.Private));
+            const constants = this.parseConstants(found.findFirstStructure(Structures.PublicSection), visibility_1.Visibility.Public);
+            constants.push(...this.parseConstants(found.findFirstStructure(Structures.ProtectedSection), visibility_1.Visibility.Protected));
+            constants.push(...this.parseConstants(found.findFirstStructure(Structures.PrivateSection), visibility_1.Visibility.Private));
             const superClassName = (_a = found.findFirstExpression(Expressions.SuperClassName)) === null || _a === void 0 ? void 0 : _a.getFirstToken().getStr();
             const containsGlobal = found.findFirstExpression(Expressions.ClassGlobal);
             const concat = found.findFirstStatement(Statements.ClassDefinition).concatTokens().toUpperCase();
@@ -142,6 +147,7 @@ class ABAPFileInformation {
                 isFinal: found.findFirstExpression(Expressions.ClassFinal) !== undefined,
                 aliases,
                 attributes,
+                constants,
             });
         }
     }
@@ -194,6 +200,29 @@ class ABAPFileInformation {
         }
         return ret;
     }
+    parseConstants(node, visibility) {
+        var _a, _b;
+        if (node === undefined) {
+            return [];
+        }
+        const results = [];
+        for (const constant of node.findAllStatements(Statements.Constant)) {
+            const name = constant.findFirstExpression(Expressions.DefinitionName).getFirstToken();
+            const typeName = constant.findFirstExpression(Expressions.TypeName);
+            // VALUE `const_value` -> `const_value`
+            const literal = (_b = (_a = constant.findFirstExpression(Expressions.Value)) === null || _a === void 0 ? void 0 : _a.getTokens()[1].getStr()) !== null && _b !== void 0 ? _b : "``";
+            // `const_value` -> const_value
+            const value = literal.slice(1, (literal === null || literal === void 0 ? void 0 : literal.length) - 1);
+            results.push({
+                name: name.getStr(),
+                typeName: typeName ? typeName.getFirstToken().getStr() : "",
+                value: value,
+                identifier: new _identifier_1.Identifier(name, this.filename),
+                visibility,
+            });
+        }
+        return results;
+    }
     parseAttributes(node, visibility) {
         if (node === undefined) {
             return [];

package/build/src/abap/5_syntax/_type_utils.js

@@ -20,6 +20,7 @@ class TypeUtils {
             || type instanceof basic_1.AnyType
             || type instanceof basic_1.UnknownType
             || type instanceof basic_1.NumericType
+            || type instanceof basic_1.CSequenceType
             || type instanceof basic_1.DateType
             || type instanceof basic_1.CLikeType
             || type instanceof basic_1.PackedType

package/build/src/abap/5_syntax/expressions/field_assignment.js

@@ -18,6 +18,12 @@ class FieldAssignment {
         let type = undefined;
         if (targetType instanceof basic_1.StructureType) {
             type = targetType.getComponentByName(name);
+            if (type === undefined && targetType.containsVoid() === false) {
+                throw new Error(`field ${name} does not exist in structure`);
+            }
+        }
+        else if (targetType instanceof basic_1.VoidType) {
+            type = targetType;
         }
         new source_1.Source().runSyntax(s, scope, filename, type);
     }

package/build/src/issue.js

@@ -97,6 +97,9 @@ class Issue {
             fix,
         });
     }
+    getData() {
+        return this.data;
+    }
     getMessage() {
         return this.data.message;
     }

package/build/src/lsp/semantic.js

@@ -70,7 +70,7 @@ class SemanticHighlighting {
                     || statementInstance instanceof Statements.MethodImplementation
                     || statementInstance instanceof Statements.EndMethod
                     || statementInstance instanceof Statements.EndClass
-                    || statementInstance instanceof Statements.InterfaceDef
+                    || statementInstance instanceof Statements.Interface
                     || statementInstance instanceof Statements.EndInterface
                     || statementInstance instanceof Statements.Form
                     || statementInstance instanceof Statements.EndForm) {

package/build/src/objects/domain.js

@@ -35,7 +35,7 @@ class Domain extends _abstract_object_1.AbstractObject {
         return this.parsedType;
     }
     parse() {
-        var _a, _b, _c;
+        var _a, _b, _c, _d, _e, _f, _g;
         if (this.parsedXML) {
             return { updated: false, runtime: 0 };
         }
@@ -46,15 +46,32 @@ class Domain extends _abstract_object_1.AbstractObject {
             return { updated: false, runtime: 0 };
         }
         const dd01v = (_c = (_b = (_a = parsed.abapGit) === null || _a === void 0 ? void 0 : _a["asx:abap"]) === null || _b === void 0 ? void 0 : _b["asx:values"]) === null || _c === void 0 ? void 0 : _c.DD01V;
+        const dd07v_tab = (_g = (_f = (_e = (_d = parsed.abapGit) === null || _d === void 0 ? void 0 : _d["asx:abap"]) === null || _e === void 0 ? void 0 : _e["asx:values"]) === null || _f === void 0 ? void 0 : _f.DD07V_TAB) === null || _g === void 0 ? void 0 : _g.DD07V;
+        const values = [];
+        if (dd07v_tab) {
+            for (const ddo7v of dd07v_tab) {
+                const value = {
+                    description: ddo7v === null || ddo7v === void 0 ? void 0 : ddo7v.DDTEXT,
+                    value: ddo7v === null || ddo7v === void 0 ? void 0 : ddo7v.DOMVALUE_L,
+                    language: ddo7v === null || ddo7v === void 0 ? void 0 : ddo7v.DDLANGUAGE,
+                };
+                values.push(value);
+            }
+        }
         this.parsedXML = {
             description: dd01v === null || dd01v === void 0 ? void 0 : dd01v.DDTEXT,
             datatype: dd01v === null || dd01v === void 0 ? void 0 : dd01v.DATATYPE,
             length: dd01v === null || dd01v === void 0 ? void 0 : dd01v.LENG,
             decimals: dd01v === null || dd01v === void 0 ? void 0 : dd01v.DECIMALS,
+            values: values,
         };
         const end = Date.now();
         return { updated: true, runtime: end - start };
     }
+    getFixedValues() {
+        var _a, _b;
+        return (_b = (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.values) !== null && _b !== void 0 ? _b : [];
+    }
 }
 exports.Domain = Domain;
 //# sourceMappingURL=domain.js.map

package/build/src/registry.js

@@ -68,7 +68,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.78.13";
+        return "2.79.3";
     }
     getDDICReferences() {
         return this.references;

package/build/src/rules/check_syntax.js

@@ -4,7 +4,9 @@ exports.CheckSyntax = exports.CheckSyntaxConf = void 0;
 const syntax_1 = require("../abap/5_syntax/syntax");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const _abap_object_1 = require("../objects/_abap_object");
+const issue_1 = require("../issue");
 const _irule_1 = require("./_irule");
+const severity_1 = require("../severity");
 class CheckSyntaxConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.CheckSyntaxConf = CheckSyntaxConf;
@@ -34,7 +36,17 @@ class CheckSyntax {
         if (!(obj instanceof _abap_object_1.ABAPObject)) {
             return [];
         }
-        return new syntax_1.SyntaxLogic(this.reg, obj).run().issues;
+        const issues = new syntax_1.SyntaxLogic(this.reg, obj).run().issues;
+        // the syntax logic does not know the rule severity when its run
+        if (this.conf.severity
+            && this.conf.severity !== severity_1.Severity.Error) {
+            issues.forEach((value, index) => {
+                const data = value.getData();
+                data.severity = this.conf.severity;
+                issues[index] = new issue_1.Issue(data);
+            });
+        }
+        return issues;
     }
 }
 exports.CheckSyntax = CheckSyntax;

package/build/src/rules/constant_classes.js

@@ -0,0 +1,109 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.ConstantClasses = exports.ConstantClassesConf = void 0;
+const issue_1 = require("../issue");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+const __1 = require("..");
+/** Checks that constants classes are in sync with domain fixed values */
+class ConstantClassesConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.ConstantClassesConf = ConstantClassesConf;
+class ConstantClasses {
+    constructor() {
+        this.conf = new ConstantClassesConf();
+    }
+    getMetadata() {
+        return {
+            key: "constant_classes",
+            title: "Validate constant classes",
+            shortDescription: `Checks that a class contains exactly the constants corresponding to a domain's fixed values.`,
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-enumeration-classes-to-constants-interfaces`,
+            tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Experimental],
+        };
+    }
+    initialize(reg) {
+        this.reg = reg;
+        return this;
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    run(obj) {
+        if (this.conf
+            && this.conf.mapping
+            && obj instanceof __1.Objects.Domain) {
+            const configEntry = this.conf.mapping.find(x => x.domain.toUpperCase() === obj.getName().toUpperCase());
+            if (!configEntry) {
+                return [];
+            }
+            const classWithConstants = this.reg.getObject("CLAS", configEntry === null || configEntry === void 0 ? void 0 : configEntry.class.toUpperCase());
+            if (!classWithConstants) {
+                return [issue_1.Issue.atIdentifier(obj.getIdentifier(), `Constant class pattern implementation ${configEntry.class} missing for domain ${configEntry.domain}`, this.getMetadata().key, this.conf.severity)];
+                // quickfix will implement the whole class
+            }
+            const classContents = classWithConstants.getMainABAPFile();
+            if (classContents === undefined) {
+                return [];
+            }
+            const def = classWithConstants.getClassDefinition();
+            if (!def) {
+                // this issue is checked by rule implement_methods.
+                // we will not issue errors that all constants are missing until there is a class implementation
+                return [];
+            }
+            const domainValueInfo = obj.getFixedValues();
+            const domainValues = domainValueInfo.map(x => x.value);
+            const issues = [];
+            if (obj.getFixedValues().length === 0) {
+                // possibly this is not even a domain with fixed values
+                issues.push(issue_1.Issue.atStatement(classContents, classContents.getStatements()[0], `Domain ${configEntry.domain} does not contain any fixed values. Either add some values or disable this check`, this.getMetadata().key, this.conf.severity));
+            }
+            // later we will raise an issue if we did not find it
+            let domainNameConstantFound = false;
+            for (const constant of def.constants) {
+                if (configEntry.constantForDomainName
+                    && constant.name === configEntry.constantForDomainName) {
+                    // we require the constant value to be uppercase just in case
+                    // in the config it does not matter
+                    if (constant.value !== configEntry.domain.toLocaleUpperCase()) {
+                        issues.push(this.issueAtConstant(constant, `Constant value ${constant.value} must match domain name ${configEntry.domain} `));
+                    }
+                    domainNameConstantFound = true;
+                    continue;
+                }
+                if (configEntry.useExactType && constant.typeName.toLowerCase() !== configEntry.domain.toLowerCase()) {
+                    issues.push(this.issueAtConstant(constant, `Use exact type ${configEntry.domain} instead of ${constant.typeName}`));
+                    // quickfix will change the type
+                }
+                if (constant.visibility !== __1.Visibility.Public) {
+                    issues.push(this.issueAtConstant(constant, `Constant ${constant.name} should be public`));
+                    // quickfix will move constant
+                }
+                if (!domainValues.includes(constant.value)) {
+                    issues.push(this.issueAtConstant(constant, `Extra constant ${constant.name} found which is not present in domain ${configEntry.domain}`));
+                    // quickfix will remove constant
+                }
+            }
+            for (const d of domainValueInfo) {
+                if (!def.constants.find(c => c.value === d.value)) {
+                    issues.push(issue_1.Issue.atStatement(classContents, classContents.getStatements()[0], `Missing constant for ${d.value} (domain ${configEntry.domain})`, this.getMetadata().key, this.conf.severity));
+                    // quickfix will add constant
+                }
+            }
+            if (configEntry.constantForDomainName && !domainNameConstantFound) {
+                issues.push(issue_1.Issue.atStatement(classContents, classContents.getStatements()[0], `Missing constant ${configEntry.constantForDomainName} for name of domain ${configEntry.domain}`, this.getMetadata().key, this.conf.severity));
+            }
+            return issues;
+        }
+        return [];
+    }
+    issueAtConstant(constant, message) {
+        return issue_1.Issue.atIdentifier(constant.identifier, message, this.getMetadata().key, this.conf.severity);
+    }
+}
+exports.ConstantClasses = ConstantClasses;
+//# sourceMappingURL=constant_classes.js.map

package/build/src/rules/index.js

@@ -142,4 +142,5 @@ __exportStar(require("./use_new"), exports);
 __exportStar(require("./when_others_last"), exports);
 __exportStar(require("./whitespace_end"), exports);
 __exportStar(require("./xml_consistency"), exports);
+__exportStar(require("./constant_classes"), exports);
 //# sourceMappingURL=index.js.map

package/build/src/rules/obsolete_statement.js

@@ -61,6 +61,8 @@ class ObsoleteStatementConf extends _basic_rule_config_1.BasicRuleConfig {
         this.sortByFS = true;
         /** Checks for CALL TRANSFORMATION OBJECTS */
         this.callTransformation = true;
+        /** Check for POSIX REGEX usage */
+        this.regex = true;
     }
 }
 exports.ObsoleteStatementConf = ObsoleteStatementConf;
@@ -109,7 +111,9 @@ FREE MEMORY: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-us/abapfree
 
 SORT BY FS: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abapsort_itab_obsolete.htm
 
-CALL TRANSFORMATION OBJECTS: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abapcall_transformation_objects.htm`,
+CALL TRANSFORMATION OBJECTS: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abapcall_transformation_objects.htm
+
+POSIX REGEX: https://help.sap.com/doc/abapdocu_755_index_htm/7.55/en-US/index.htm`,
         };
     }
     getConfig() {
@@ -266,6 +270,35 @@ CALL TRANSFORMATION OBJECTS: https://help.sap.com/doc/abapdocu_752_index_htm/7.5
                     issues.push(issue);
                 }
             }
+            if (configVersion >= version_1.Version.v756 && this.conf.regex) {
+                if (sta instanceof Statements.Find || sta instanceof Statements.Replace) {
+                    const concat = staNode.concatTokens().toUpperCase();
+                    if (concat.includes("REGEX")) {
+                        const issue = issue_1.Issue.atStatement(file, staNode, "REGEX obsolete, use PCRE", this.getMetadata().key, this.conf.severity);
+                        issues.push(issue);
+                    }
+                }
+                else {
+                    const classNameExpression = staNode.findAllExpressions(Expressions.ClassName);
+                    const methodNameExpression = staNode.findAllExpressions(Expressions.MethodName);
+                    if (classNameExpression.length !== 0 && methodNameExpression.length !== 0) {
+                        const className = classNameExpression[0].concatTokens();
+                        const methodName = methodNameExpression[0].concatTokens();
+                        if (className === "cl_abap_regex") {
+                            if (methodName === "create_posix") {
+                                const issue = issue_1.Issue.atStatement(file, staNode, "create_posix obsolete, use create_pcre", this.getMetadata().key, this.conf.severity);
+                                issues.push(issue);
+                            }
+                        }
+                        else if (className === "cl_abap_matcher") {
+                            if (methodName.includes("posix")) {
+                                const issue = issue_1.Issue.atStatement(file, staNode, "posix methods obsolete, use pcre methods", this.getMetadata().key, this.conf.severity);
+                                issues.push(issue);
+                            }
+                        }
+                    }
+                }
+            }
         }
         return issues;
     }

package/build/src/version.js

@@ -15,6 +15,7 @@ var Version;
     Version["v753"] = "v753";
     Version["v754"] = "v754";
     Version["v755"] = "v755";
+    Version["v756"] = "v756";
     Version["Cloud"] = "Cloud";
 })(Version = exports.Version || (exports.Version = {}));
 exports.defaultVersion = Version.v755;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.78.13",
+    "version": "2.79.3",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -54,10 +54,10 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.18.7",
+        "@microsoft/api-extractor": "^7.18.9",
         "@types/chai": "^4.2.21",
         "@types/mocha": "^9.0.0",
-        "@types/node": "^16.9.1",
+        "@types/node": "^16.9.2",
         "chai": "^4.3.4",
         "eslint": "^7.32.0",
         "madge": "^5.0.1",