@abaplint/core 2.120.9 → 2.120.11

package/build/abaplint.d.ts

@@ -534,6 +534,7 @@ declare namespace BasicTypes {
         NumericType,
         ObjectReferenceType,
         PackedType,
+        PGenericType,
         SimpleType,
         StringType,
         IStructureComponent,
@@ -1256,6 +1257,7 @@ declare class ClassDefinition_3 extends Identifier implements IClassDefinition {
     isAbstract(): boolean;
     isSharedMemory(): boolean;
     getCreateVisibility(): Visibility;
+    private checkClassNameLength;
     private findSuper;
     private checkMethodNameLength;
     private checkClassConstructorStatic;
@@ -5676,6 +5678,17 @@ declare class PersonalizationObject extends AbstractObject {
     getDescription(): string | undefined;
 }
 
+declare class PGenericType extends AbstractType {
+    private static readonly singleton;
+    static get(): PGenericType;
+    private constructor();
+    toText(): string;
+    isGeneric(): boolean;
+    toABAP(): string;
+    containsVoid(): boolean;
+    toCDS(): string;
+}
+
 declare class Plus extends Token {
     static railroad(): string;
 }
@@ -7879,12 +7892,30 @@ declare class Table extends AbstractObject {
     getType(): string;
     getDescription(): string | undefined;
     getSecondaryIndexes(): SecondaryIndex[] | undefined;
+    getFields(): {
+        FIELDNAME: string;
+        ROLLNAME?: string;
+        COMPTYPE?: string;
+        PRECFIELD?: string;
+        LENG?: string;
+        INTLEN?: string;
+        DATATYPE?: string;
+        DECIMALS?: string;
+        KEYFLAG?: string;
+        GROUPNAME?: string;
+        CHECKTABLE?: string;
+        REFTABLE?: string;
+        REFFIELD?: string;
+        REFTYPE?: string;
+        DDTEXT?: string;
+    }[] | undefined;
     getAllowedNaming(): IAllowedNaming;
     setDirty(): void;
     listKeys(reg: IRegistry): string[];
     parseType(reg: IRegistry): AbstractType;
     getTableCategory(): TableCategory | undefined;
     getEnhancementCategory(): EnhancementCategory;
+    private keyFieldsNotFirst;
     private parseXML;
 }
 

package/build/src/abap/2_statements/expressions/for.js

@@ -16,7 +16,7 @@ class For extends combi_1.Expression {
         const itera = (0, combi_1.seq)(_1.InlineFieldDefinition, (0, combi_1.opt)(then), whil);
         const groupBy = (0, combi_1.seq)("GROUP BY", (0, combi_1.alt)(field_chain_1.FieldChain, (0, combi_1.seq)("(", (0, combi_1.plus)(_1.LoopGroupByComponent), ")")), (0, combi_1.opt)((0, combi_1.seq)((0, combi_1.alt)("ASCENDING", "DESCENDING"), (0, combi_1.opt)("AS TEXT"))), (0, combi_1.opt)("WITHOUT MEMBERS"));
         const t = (0, combi_1.alt)(_1.TargetField, _1.TargetFieldSymbol);
-        const groups = (0, combi_1.ver)(version_1.Release.v740sp08, (0, combi_1.seq)("GROUPS", t, "OF", t, "IN", _1.Source, (0, combi_1.optPrio)(groupBy)));
+        const groups = (0, combi_1.ver)(version_1.Release.v740sp08, (0, combi_1.seq)("GROUPS", t, "OF", t, "IN", _1.Source, (0, combi_1.optPrio)(groupBy)), { also: combi_1.AlsoIn.OpenABAP });
         const f = (0, combi_1.seq)("FOR", (0, combi_1.alt)(itera, inn, groups), (0, combi_1.optPrio)(_1.Let));
         return (0, combi_1.ver)(version_1.Release.v740sp05, f, { also: combi_1.AlsoIn.OpenABAP });
     }

package/build/src/abap/2_statements/expressions/inline_field_definition.js

@@ -5,7 +5,8 @@ const combi_1 = require("../combi");
 const _1 = require(".");
 class InlineFieldDefinition extends combi_1.Expression {
     getRunnable() {
-        return (0, combi_1.altPrio)((0, combi_1.seq)(_1.Field, "=", _1.Source), (0, combi_1.seq)(_1.Field, "TYPE", _1.TypeName));
+        const field = (0, combi_1.altPrio)(_1.Field, _1.FieldSymbol);
+        return (0, combi_1.altPrio)((0, combi_1.seq)(field, "=", _1.Source), (0, combi_1.seq)(_1.Field, "TYPE", _1.TypeName));
     }
 }
 exports.InlineFieldDefinition = InlineFieldDefinition;

package/build/src/abap/2_statements/expressions/reduce_next.js

@@ -7,7 +7,7 @@ const tokens_1 = require("../../1_lexer/tokens");
 const version_1 = require("../../../version");
 class ReduceNext extends combi_1.Expression {
     getRunnable() {
-        const calcAssign = (0, combi_1.ver)(version_1.Release.v754, (0, combi_1.alt)((0, combi_1.seq)((0, combi_1.tok)(tokens_1.WPlus), "="), (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WDash), "="), "/=", "*=", "&&="));
+        const calcAssign = (0, combi_1.ver)(version_1.Release.v754, (0, combi_1.alt)((0, combi_1.seq)((0, combi_1.tok)(tokens_1.WPlus), "="), (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WDash), "="), "/=", "*=", "&&="), { also: combi_1.AlsoIn.OpenABAP });
         const fields = (0, combi_1.seq)(_1.SimpleTarget, (0, combi_1.altPrio)("=", calcAssign), _1.Source);
         return (0, combi_1.seq)("NEXT", (0, combi_1.plus)(fields));
     }

package/build/src/abap/2_statements/statements/rollback_entities.js

@@ -6,7 +6,7 @@ const version_1 = require("../../../version");
 class RollbackEntities {
     getMatcher() {
         const s = "ROLLBACK ENTITIES";
-        return (0, combi_1.verNotLang)(version_1.LanguageVersion.KeyUser, (0, combi_1.ver)(version_1.Release.v754, s));
+        return (0, combi_1.verNotLang)(version_1.LanguageVersion.KeyUser, (0, combi_1.ver)(version_1.Release.v754, s, { also: combi_1.AlsoIn.OpenABAP }));
     }
 }
 exports.RollbackEntities = RollbackEntities;

package/build/src/abap/4_file_information/abap_file_information_parser.js

@@ -234,7 +234,8 @@ class ABAPFileInformationParser {
         return ret;
     }
     parseConstants(node, visibility) {
-        var _a, _b;
+        var _a;
+        var _b;
         if (node === undefined) {
             return [];
         }

package/build/src/abap/5_syntax/_type_utils.js

@@ -115,6 +115,7 @@ class TypeUtils {
             || type instanceof basic_1.DataType
             || type instanceof basic_1.CLikeType
             || type instanceof basic_1.PackedType
+            || type instanceof basic_1.PGenericType
             || type instanceof basic_1.TimeType
             || type instanceof enum_type_1.EnumType) {
             return true;
@@ -330,6 +331,14 @@ class TypeUtils {
         if (calculated) {
             return this.isAssignable(source, target);
         }
+        if (target instanceof basic_1.PGenericType) {
+            return source instanceof basic_1.PackedType
+                || source instanceof basic_1.PGenericType
+                || source instanceof basic_1.VoidType
+                || source instanceof basic_1.AnyType
+                || source instanceof basic_1.DataType
+                || source instanceof basic_1.UnknownType;
+        }
         if (source instanceof basic_1.CharacterType) {
             if (target instanceof basic_1.CharacterType) {
                 if (((_a = source.getAbstractTypeData()) === null || _a === void 0 ? void 0 : _a.derivedFromConstant) === true) {
@@ -444,6 +453,10 @@ class TypeUtils {
                 return false;
             }
         }
+        else if (source instanceof basic_1.PackedType && target instanceof basic_1.PackedType) {
+            return source.getLength() === target.getLength()
+                && source.getDecimals() === target.getDecimals();
+        }
         else if (source instanceof basic_1.FloatType) {
             if (target instanceof basic_1.IntegerType) {
                 return false;

package/build/src/abap/5_syntax/expressions/component_compare.js

@@ -37,18 +37,30 @@ exports.ComponentCompare = void 0;
 const Expressions = __importStar(require("../../2_statements/expressions"));
 const _syntax_input_1 = require("../_syntax_input");
 const component_chain_1 = require("./component_chain");
+const component_name_1 = require("./component_name");
 const source_1 = require("./source");
 class ComponentCompare {
-    static runSyntax(node, input, type) {
+    static runSyntax(node, input, leftType, rightType) {
         const chain = node.findDirectExpression(Expressions.ComponentChainSimple);
         if (chain === undefined) {
             const message = "ComponentCompare, chain not found";
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
             return;
         }
-        const fieldType = component_chain_1.ComponentChain.runSyntax(type, chain, input);
+        const fieldType = component_chain_1.ComponentChain.runSyntax(leftType, chain, input);
         for (const s of node.findDirectExpressions(Expressions.Source)) {
-            source_1.Source.runSyntax(s, input, fieldType);
+            const fieldChain = s.findDirectExpression(Expressions.FieldChain);
+            const first = fieldChain === null || fieldChain === void 0 ? void 0 : fieldChain.getFirstChild();
+            if (rightType && fieldChain && first) {
+                let sourceType = rightType;
+                if (first.concatTokens().toUpperCase() !== "TABLE_LINE") {
+                    sourceType = component_name_1.ComponentName.runSyntax(sourceType, first, input);
+                }
+                component_chain_1.ComponentChain.runSyntax(sourceType, fieldChain, input);
+            }
+            else {
+                source_1.Source.runSyntax(s, input, fieldType);
+            }
         }
     }
 }

package/build/src/abap/5_syntax/expressions/component_cond.js

@@ -37,15 +37,15 @@ exports.ComponentCond = void 0;
 const Expressions = __importStar(require("../../2_statements/expressions"));
 const component_compare_1 = require("./component_compare");
 class ComponentCond {
-    static runSyntax(node, input, type) {
+    static runSyntax(node, input, leftType, rightType) {
         for (const t of node.findDirectExpressions(Expressions.ComponentCondSub)) {
             const c = t.findDirectExpression(Expressions.ComponentCond);
             if (c) {
-                ComponentCond.runSyntax(c, input, type);
+                ComponentCond.runSyntax(c, input, leftType, rightType);
             }
         }
         for (const t of node.findDirectExpressions(Expressions.ComponentCompare)) {
-            component_compare_1.ComponentCompare.runSyntax(t, input, type);
+            component_compare_1.ComponentCompare.runSyntax(t, input, leftType, rightType);
         }
     }
 }

package/build/src/abap/5_syntax/expressions/filter_body.js

@@ -43,21 +43,14 @@ class FilterBody {
         if (node === undefined) {
             return targetType;
         }
-        let type = undefined;
+        const types = [];
         for (const s of node.findDirectExpressions(Expressions.Source)) {
-            if (type === undefined) {
-                type = source_1.Source.runSyntax(s, input);
-            }
-            else {
-                source_1.Source.runSyntax(s, input);
-            }
+            types.push(source_1.Source.runSyntax(s, input));
         }
-        // todo
-        if (node.findDirectTokenByText("EXCEPT") === undefined) {
-            const rowType = type instanceof basic_1.TableType ? type.getRowType() : undefined;
-            component_cond_1.ComponentCond.runSyntax(node.findDirectExpression(Expressions.ComponentCond), input, rowType);
-        }
-        return type ? type : targetType;
+        const inputRowType = types[0] instanceof basic_1.TableType ? types[0].getRowType() : undefined;
+        const filterRowType = types[1] instanceof basic_1.TableType ? types[1].getRowType() : undefined;
+        component_cond_1.ComponentCond.runSyntax(node.findDirectExpression(Expressions.ComponentCond), input, inputRowType, filterRowType);
+        return types[0] ? types[0] : targetType;
     }
 }
 exports.FilterBody = FilterBody;

package/build/src/abap/5_syntax/expressions/inline_field_definition.js

@@ -46,7 +46,8 @@ class InlineFieldDefinition {
     static runSyntax(node, input, targetType) {
         var _a;
         let type = undefined;
-        const field = (_a = node.findDirectExpression(Expressions.Field)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
+        const field = (_a = (node.findDirectExpression(Expressions.Field)
+            || node.findDirectExpression(Expressions.FieldSymbol))) === null || _a === void 0 ? void 0 : _a.getFirstToken();
         if (field === undefined) {
             return undefined;
         }

package/build/src/abap/5_syntax/expressions/method_param.js

@@ -67,6 +67,9 @@ class MethodParam {
         else if (concat === "TYPE X" || concat.startsWith("TYPE X ")) {
             return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), input.filename, basic_1.XGenericType.get(), meta);
         }
+        else if (concat === "TYPE P" || concat.startsWith("TYPE P ")) {
+            return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), input.filename, basic_1.PGenericType.get(), meta);
+        }
         const found = new basic_types_1.BasicTypes(input).parseType(type);
         if (found) {
             return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), input.filename, found, meta);

package/build/src/abap/5_syntax/statements/move.js

@@ -41,6 +41,7 @@ const inline_data_1 = require("../expressions/inline_data");
 const _type_utils_1 = require("../_type_utils");
 const _syntax_input_1 = require("../_syntax_input");
 const dereference_1 = require("../expressions/dereference");
+const basic_1 = require("../../types/basic");
 class Move {
     runSyntax(node, input) {
         const targets = node.findDirectExpressions(Expressions.Target);
@@ -76,6 +77,9 @@ class Move {
             sourceType = dereference_1.Dereference.runSyntax(node, sourceType, input);
         }
         if (inline) {
+            if (sourceType instanceof basic_1.PackedType && (source === null || source === void 0 ? void 0 : source.findDirectExpression(Expressions.ArithOperator))) {
+                sourceType = new basic_1.PackedType(8, 0);
+            }
             inline_data_1.InlineData.runSyntax(inline, input, sourceType);
             targetType = sourceType;
         }

package/build/src/abap/types/basic/index.js

@@ -36,6 +36,7 @@ __exportStar(require("./numeric_generic_type"), exports);
 __exportStar(require("./numeric_type"), exports);
 __exportStar(require("./object_reference_type"), exports);
 __exportStar(require("./packed_type"), exports);
+__exportStar(require("./pgeneric_type"), exports);
 __exportStar(require("./simple_type"), exports);
 __exportStar(require("./string_type"), exports);
 __exportStar(require("./structure_type"), exports);

package/build/src/abap/types/basic/pgeneric_type.js

@@ -0,0 +1,30 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.PGenericType = void 0;
+const _abstract_type_1 = require("./_abstract_type");
+class PGenericType extends _abstract_type_1.AbstractType {
+    static get() {
+        return this.singleton;
+    }
+    constructor() {
+        super();
+    }
+    toText() {
+        return "```p```";
+    }
+    isGeneric() {
+        return true;
+    }
+    toABAP() {
+        throw new Error("p, generic");
+    }
+    containsVoid() {
+        return false;
+    }
+    toCDS() {
+        return "abap.TODO_PGENERIC";
+    }
+}
+exports.PGenericType = PGenericType;
+PGenericType.singleton = new PGenericType();
+//# sourceMappingURL=pgeneric_type.js.map

package/build/src/abap/types/class_definition.js

@@ -97,6 +97,7 @@ class ClassDefinition extends _identifier_1.Identifier {
         // perform checks after everything has been initialized
         this.checkInterfaceVisibility(input, node);
         this.checkMethodsFromSuperClasses(input);
+        this.checkClassNameLength(input);
         this.checkMethodNameLength(input);
         this.checkClassConstructorStatic(input);
     }
@@ -147,6 +148,12 @@ class ClassDefinition extends _identifier_1.Identifier {
       }
     */
     ///////////////////
+    checkClassNameLength(input) {
+        if (this.getName().length > 30) {
+            const message = `Class name "${this.getName()}" is too long, maximum length is 30 characters`;
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, this.getToken(), message));
+        }
+    }
     findSuper(def, input) {
         var _a;
         const token = (_a = def === null || def === void 0 ? void 0 : def.findDirectExpression(expressions_1.SuperClassName)) === null || _a === void 0 ? void 0 : _a.getFirstToken();

package/build/src/ddl/expressions/ddl_clauses.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.DDLValueHelp = exports.DDLForeignKey = exports.DDLForeignKeyTarget = void 0;
+exports.DDLReference = exports.DDLValueHelp = exports.DDLForeignKey = exports.DDLForeignKeyTarget = void 0;
 const combi_1 = require("../../abap/2_statements/combi");
 const ddl_literal_1 = require("./ddl_literal");
 const ddl_name_1 = require("./ddl_name");
@@ -24,4 +24,10 @@ class DDLValueHelp extends combi_1.Expression {
     }
 }
 exports.DDLValueHelp = DDLValueHelp;
+class DDLReference extends combi_1.Expression {
+    getRunnable() {
+        return (0, combi_1.seq)("WITH", "REFERENCE", "TABLE", ddl_name_1.DDLName, "AND", "REFERENCE", "FIELD", ddl_name_1.DDLName);
+    }
+}
+exports.DDLReference = DDLReference;
 //# sourceMappingURL=ddl_clauses.js.map

package/build/src/ddl/expressions/ddl_table_field.js

@@ -8,7 +8,7 @@ const ddl_name_1 = require("./ddl_name");
 const ddl_type_1 = require("./ddl_type");
 class DDLTableField extends combi_1.Expression {
     getRunnable() {
-        const trailingClause = (0, combi_1.alt)(ddl_clauses_1.DDLForeignKey, ddl_clauses_1.DDLValueHelp);
+        const trailingClause = (0, combi_1.alt)(ddl_clauses_1.DDLForeignKey, ddl_clauses_1.DDLReference, ddl_clauses_1.DDLValueHelp);
         return (0, combi_1.seq)((0, combi_1.star)(expressions_1.CDSAnnotation), (0, combi_1.optPrio)("KEY"), ddl_name_1.DDLName, ":", ddl_type_1.DDLType, (0, combi_1.optPrio)("NOT NULL"), (0, combi_1.star)(trailingClause), ";");
     }
 }

package/build/src/objects/_abap_object.js

@@ -98,7 +98,8 @@ class ABAPObject extends _abstract_object_1.AbstractObject {
         return this.textsTranslations;
     }
     findTexts(parsed) {
-        var _a, _b, _c, _d, _e, _f, _g;
+        var _a, _b, _c, _d, _e, _f;
+        var _g;
         this.texts = {};
         if (((_d = (_c = (_b = (_a = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _a === void 0 ? void 0 : _a["asx:abap"]) === null || _b === void 0 ? void 0 : _b["asx:values"]) === null || _c === void 0 ? void 0 : _c.TPOOL) === null || _d === void 0 ? void 0 : _d.item) === undefined) {
             return;
@@ -111,7 +112,7 @@ class ABAPObject extends _abstract_object_1.AbstractObject {
             if (id !== "R" && t.KEY === undefined) {
                 continue;
             }
-            const key = (_g = ((_f = t.KEY) !== null && _f !== void 0 ? _f : t.ID)) === null || _g === void 0 ? void 0 : _g.toUpperCase();
+            const key = (_f = ((_g = t.KEY) !== null && _g !== void 0 ? _g : t.ID)) === null || _f === void 0 ? void 0 : _f.toUpperCase();
             if (key === undefined) {
                 continue;
             }
@@ -122,7 +123,8 @@ class ABAPObject extends _abstract_object_1.AbstractObject {
         }
     }
     findTextsTranslations(parsed) {
-        var _a, _b, _c, _d, _e, _f, _g;
+        var _a, _b, _c, _d, _e, _f;
+        var _g;
         this.textsTranslations = [];
         const values = (_d = (_c = (_b = (_a = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _a === void 0 ? void 0 : _a["asx:abap"]) === null || _b === void 0 ? void 0 : _b["asx:values"]) === null || _c === void 0 ? void 0 : _c.I18N_TPOOL) === null || _d === void 0 ? void 0 : _d.item;
         if (values === undefined) {
@@ -131,7 +133,7 @@ class ABAPObject extends _abstract_object_1.AbstractObject {
         for (const langItem of (0, xml_utils_1.xmlToArray)(values)) {
             const textElements = {};
             for (const item of (0, xml_utils_1.xmlToArray)((_e = langItem.TEXTPOOL) === null || _e === void 0 ? void 0 : _e.item)) {
-                const key = (_g = ((_f = item.KEY) !== null && _f !== void 0 ? _f : item.ID)) === null || _g === void 0 ? void 0 : _g.toUpperCase();
+                const key = (_f = ((_g = item.KEY) !== null && _g !== void 0 ? _g : item.ID)) === null || _f === void 0 ? void 0 : _f.toUpperCase();
                 if (key !== undefined) {
                     textElements[key] = { entry: (0, xml_utils_1.unescape)(item.ENTRY), maxLength: parseInt(item.LENGTH, 10) };
                 }

package/build/src/objects/domain.js

@@ -126,11 +126,13 @@ class Domain extends _abstract_object_1.AbstractObject {
         return { updated: true, runtime: end - start };
     }
     getFixedValues() {
-        var _a, _b;
+        var _a;
+        var _b;
         return (_b = (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.values) !== null && _b !== void 0 ? _b : [];
     }
     getFixedValuesTranslations() {
-        var _a, _b;
+        var _a;
+        var _b;
         return (_b = (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.valuesTranslations) !== null && _b !== void 0 ? _b : [];
     }
 }

package/build/src/objects/rename/rename_icf_service.js

@@ -8,7 +8,8 @@ class RenameICFService {
         this.reg = reg;
     }
     buildEdits(obj, oldName, newName) {
-        var _a, _b, _c, _d;
+        var _a, _b;
+        var _c, _d;
         if (!(obj instanceof __1.ICFService)) {
             throw new Error("RenameICFService, not a ICF Service");
         }
@@ -33,8 +34,8 @@ class RenameICFService {
             }
             return newName;
         })();
-        const cleanOldName = (_b = (_a = oldName.match(/^[^ ]+/)) === null || _a === void 0 ? void 0 : _a[0]) !== null && _b !== void 0 ? _b : oldName;
-        const cleanNewName = (_d = (_c = newName.match(/^[^ ]+/)) === null || _c === void 0 ? void 0 : _c[0]) !== null && _d !== void 0 ? _d : newName;
+        const cleanOldName = (_c = (_a = oldName.match(/^[^ ]+/)) === null || _a === void 0 ? void 0 : _a[0]) !== null && _c !== void 0 ? _c : oldName;
+        const cleanNewName = (_d = (_b = newName.match(/^[^ ]+/)) === null || _b === void 0 ? void 0 : _b[0]) !== null && _d !== void 0 ? _d : newName;
         let changes = [];
         const helper = new renamer_helper_1.RenamerHelper(this.reg);
         changes = changes.concat(helper.buildURLFileEdits(obj, cleanOldName, cleanNewName));

package/build/src/objects/table.js

@@ -80,6 +80,13 @@ class Table extends _abstract_object_1.AbstractObject {
         }
         return (_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.secondaryIndexes;
     }
+    getFields() {
+        var _a;
+        if (this.parsedData === undefined) {
+            this.parseXML();
+        }
+        return (_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.fields;
+    }
     getAllowedNaming() {
         let length = 30;
         const regex = /^((\/[A-Z_\d]{3,8}\/)|[a-zA-Z0-9]{3}|CI_)\w+$/;
@@ -132,9 +139,13 @@ class Table extends _abstract_object_1.AbstractObject {
             && this.parsedData.dataClass === "USER3") {
             return new Types.UnknownType("Data class = USER3 not allowed in cloud");
         }
-        if (this.getTableCategory() === TableCategory.Transparent
-            && this.listKeys(reg).length === 0) {
-            return new Types.UnknownType("Table " + this.getName() + " has no key fields");
+        if (this.getTableCategory() === TableCategory.Transparent) {
+            if (this.listKeys(reg).length === 0) {
+                return new Types.UnknownType("Table " + this.getName() + " has no key fields");
+            }
+            else if (this.keyFieldsNotFirst()) {
+                return new Types.UnknownType("Table " + this.getName() + " key fields must be first");
+            }
         }
         if (this.parsedType) {
             return this.parsedType;
@@ -310,6 +321,21 @@ class Table extends _abstract_object_1.AbstractObject {
         return this.parsedData.enhancementCategory;
     }
     ///////////////
+    keyFieldsNotFirst() {
+        var _a;
+        let seenNonKey = false;
+        for (const field of ((_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.fields) || []) {
+            if (field.KEYFLAG === "X") {
+                if (seenNonKey === true) {
+                    return true;
+                }
+            }
+            else {
+                seenNonKey = true;
+            }
+        }
+        return false;
+    }
     parseXML() {
         var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o;
         const parsed = super.parseRaw2();
@@ -346,6 +372,8 @@ class Table extends _abstract_object_1.AbstractObject {
                 KEYFLAG: field.KEYFLAG,
                 GROUPNAME: field.GROUPNAME,
                 CHECKTABLE: field.CHECKTABLE,
+                REFTABLE: field.REFTABLE,
+                REFFIELD: field.REFFIELD,
                 REFTYPE: field.REFTYPE,
                 DDTEXT: field.DDTEXT,
             });

package/build/src/objects/web_mime.js

@@ -25,7 +25,8 @@ class WebMIME extends _abstract_object_1.AbstractObject {
         return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.params[name.toLowerCase()];
     }
     getParameters() {
-        var _a, _b;
+        var _a;
+        var _b;
         this.parse();
         return (_b = (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.params) !== null && _b !== void 0 ? _b : {};
     }

package/build/src/registry.js

@@ -75,7 +75,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.9";
+        return "2.120.11";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/index.js

@@ -126,6 +126,7 @@ __exportStar(require("./no_comments_between_methods"), exports);
 __exportStar(require("./no_external_form_calls"), exports);
 __exportStar(require("./no_inline_in_optional_branches"), exports);
 __exportStar(require("./no_macros"), exports);
+__exportStar(require("./no_mandt_in_database_operations"), exports);
 __exportStar(require("./no_prefixes"), exports);
 __exportStar(require("./no_public_attributes"), exports);
 __exportStar(require("./no_yoda_conditions"), exports);

package/build/src/rules/no_mandt_in_database_operations.js

@@ -0,0 +1,133 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.NoMandtInDatabaseOperations = exports.NoMandtInDatabaseOperationsConf = void 0;
+const Expressions = __importStar(require("../abap/2_statements/expressions"));
+const Statements = __importStar(require("../abap/2_statements/statements"));
+const issue_1 = require("../issue");
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+class NoMandtInDatabaseOperationsConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.NoMandtInDatabaseOperationsConf = NoMandtInDatabaseOperationsConf;
+class NoMandtInDatabaseOperations extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new NoMandtInDatabaseOperationsConf();
+    }
+    getMetadata() {
+        return {
+            key: "no_mandt_in_database_operations",
+            title: "No MANDT in database operations",
+            shortDescription: "Do not specify the client in database operations; the ABAP runtime handles it automatically.",
+            extendedInformation: "Only check for the name MANDT, not for the field type. The rule does not check for dynamic SQL.",
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Syntax],
+            badExample: `SELECT * FROM zcustomers
+  CLIENT SPECIFIED
+  WHERE mandt = @sy-mandt
+  INTO TABLE @DATA(customers).`,
+            goodExample: `SELECT * FROM zcustomers
+  INTO TABLE @DATA(customers).`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        for (const statement of file.getStatements()) {
+            if (this.isDatabaseOperation(statement) === false) {
+                continue;
+            }
+            const mandt = this.findMandtInCondition(statement);
+            if (mandt !== undefined) {
+                const issue = issue_1.Issue.atToken(file, mandt.getFirstToken(), this.getMetadata().title, this.getMetadata().key, this.conf.severity);
+                issues.push(issue);
+                continue;
+            }
+            const explicitClient = this.findExplicitClient(statement);
+            if (explicitClient !== undefined) {
+                const issue = issue_1.Issue.atToken(file, explicitClient, this.getMetadata().title, this.getMetadata().key, this.conf.severity);
+                issues.push(issue);
+            }
+        }
+        return issues;
+    }
+    isDatabaseOperation(statement) {
+        const type = statement.get();
+        return type instanceof Statements.DeleteDatabase
+            || type instanceof Statements.InsertDatabase
+            || type instanceof Statements.MergeDatabase
+            || type instanceof Statements.ModifyDatabase
+            || type instanceof Statements.OpenCursor
+            || type instanceof Statements.Select
+            || type instanceof Statements.SelectLoop
+            || type instanceof Statements.UpdateDatabase
+            || type instanceof Statements.With
+            || type instanceof Statements.WithLoop;
+    }
+    findMandtInCondition(statement) {
+        for (const condition of statement.findAllExpressions(Expressions.SQLCond)) {
+            for (const field of condition.findAllExpressions(Expressions.SQLFieldName)) {
+                const name = field.concatTokens().toUpperCase();
+                if (name === "MANDT" || name.endsWith("~MANDT")) {
+                    return field;
+                }
+            }
+        }
+        return undefined;
+    }
+    findExplicitClient(statement) {
+        var _a, _b;
+        const tokens = statement.getTokens();
+        for (let index = 0; index < tokens.length; index++) {
+            const current = tokens[index].getStr().toUpperCase();
+            const next = (_a = tokens[index + 1]) === null || _a === void 0 ? void 0 : _a.getStr().toUpperCase();
+            const afterNext = (_b = tokens[index + 2]) === null || _b === void 0 ? void 0 : _b.getStr().toUpperCase();
+            if ((current === "CLIENT" && next === "SPECIFIED")
+                || (current === "USING" && (next === "CLIENT" || next === "CLIENTS"))
+                || (current === "USING" && next === "ALL" && afterNext === "CLIENTS")) {
+                return current === "CLIENT" ? tokens[index] : tokens[index + (next === "ALL" ? 2 : 1)];
+            }
+        }
+        return undefined;
+    }
+}
+exports.NoMandtInDatabaseOperations = NoMandtInDatabaseOperations;
+//# sourceMappingURL=no_mandt_in_database_operations.js.map

package/build/src/rules/xml_consistency.js

@@ -61,6 +61,7 @@ class XMLConsistency {
             extendedInformation: `Checks:
 * XML is well-formed and parseable
 * Naming for CLAS and INTF objects
+* QUAN fields in TABL objects have reference table and field values
 * Texts and translations do not exceed maximum allowed length.`,
             tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.Syntax],
         };
@@ -75,6 +76,7 @@ class XMLConsistency {
         return this;
     }
     run(obj) {
+        var _a;
         const issues = [];
         const file = obj.getXMLFile();
         if (file === undefined) {
@@ -86,6 +88,14 @@ class XMLConsistency {
             if (res !== true) {
                 issues.push(issue_1.Issue.atRow(file, 1, "XML parser error: " + res.err.msg, this.getMetadata().key, this.conf.severity));
             }
+            else {
+                for (const attribute of ["version", "serializer_version"]) {
+                    const value = (_a = xml.match(new RegExp(`<abapGit\\b[^>]*\\b${attribute}="([^"]+)"`))) === null || _a === void 0 ? void 0 : _a[1];
+                    if (value !== undefined && value.match(/^v\d\.\d\.\d$/) === null) {
+                        issues.push(issue_1.Issue.atRow(file, 1, `Unexpected abapGit ${attribute} "${value}"`, this.getMetadata().key, this.conf.severity));
+                    }
+                }
+            }
         }
         // todo, have some XML validation in each object?
         if (obj instanceof Objects.Class) {
@@ -106,6 +116,9 @@ class XMLConsistency {
         else if (obj instanceof Objects.MessageClass) {
             issues.push(...this.runMessageClass(obj, file));
         }
+        else if (obj instanceof Objects.Table) {
+            issues.push(...this.runTable(obj, file));
+        }
         if (obj instanceof _abap_object_1.ABAPObject) {
             issues.push(...this.runTextPool(obj, file));
         }
@@ -249,6 +262,18 @@ class XMLConsistency {
         }
         return issues;
     }
+    runTable(obj, file) {
+        var _a, _b;
+        var _c;
+        const issues = [];
+        for (const field of (_c = obj.getFields()) !== null && _c !== void 0 ? _c : []) {
+            if (field.DATATYPE === "QUAN" && (!((_a = field.REFTABLE) === null || _a === void 0 ? void 0 : _a.trim()) || !((_b = field.REFFIELD) === null || _b === void 0 ? void 0 : _b.trim()))) {
+                const message = `QUAN field ${field.FIELDNAME} must have REFTABLE and REFFIELD set`;
+                issues.push(issue_1.Issue.atRow(file, 1, message, this.getMetadata().key, this.conf.severity));
+            }
+        }
+        return issues;
+    }
 }
 exports.XMLConsistency = XMLConsistency;
 //# sourceMappingURL=xml_consistency.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.120.9",
+    "version": "2.120.11",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -52,20 +52,20 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.58.9",
+        "@microsoft/api-extractor": "^7.58.12",
         "@types/chai": "^4.3.20",
         "@types/mocha": "^10.0.10",
-        "@types/node": "^24.13.2",
+        "@types/node": "^24.13.3",
         "c8": "^11.0.0",
         "chai": "^4.5.0",
-        "eslint": "^9.39.4",
+        "eslint": "^9.39.5",
         "mocha": "^11.7.6",
         "source-map-support": "^0.5.21",
         "ts-json-schema-generator": "^2.9.0",
-        "typescript": "^6.0.3"
+        "typescript": "^7.0.2"
     },
     "dependencies": {
-        "fast-xml-parser": "^5.9.3",
+        "fast-xml-parser": "^5.10.1",
         "json5": "^2.2.3",
         "vscode-languageserver-types": "^3.18.0"
     }