@abaplint/core 2.120.83 → 2.120.85

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (50) hide show
  1. package/build/abaplint.d.ts +20 -7
  2. package/build/src/abap/1_lexer/tokens/abstract_token.js +36 -12
  3. package/build/src/abap/2_statements/result.js +6 -4
  4. package/build/src/abap/5_syntax/_current_scope.js +14 -11
  5. package/build/src/abap/5_syntax/_eml.js +68 -0
  6. package/build/src/abap/5_syntax/_object_oriented.js +10 -0
  7. package/build/src/abap/5_syntax/spaghetti_scope.js +67 -9
  8. package/build/src/abap/5_syntax/statements/message.js +8 -0
  9. package/build/src/abap/5_syntax/statements/modify_entities.js +2 -0
  10. package/build/src/abap/5_syntax/statements/raise.js +6 -0
  11. package/build/src/abap/5_syntax/statements/read_entities.js +2 -0
  12. package/build/src/abap/nodes/expression_node.js +6 -5
  13. package/build/src/bdef/bdef_parser.js +75 -0
  14. package/build/src/bdef/expressions/bdef_action.js +15 -0
  15. package/build/src/bdef/expressions/bdef_alias.js +12 -0
  16. package/build/src/bdef/expressions/bdef_association.js +15 -0
  17. package/build/src/bdef/expressions/bdef_association_body.js +18 -0
  18. package/build/src/bdef/expressions/bdef_authorization_context.js +16 -0
  19. package/build/src/bdef/expressions/bdef_cardinality.js +13 -0
  20. package/build/src/bdef/expressions/bdef_default_function.js +14 -0
  21. package/build/src/bdef/expressions/bdef_define_behavior.js +21 -0
  22. package/build/src/bdef/expressions/bdef_definition.js +12 -0
  23. package/build/src/bdef/expressions/bdef_determination.js +15 -0
  24. package/build/src/bdef/expressions/bdef_determine_action.js +15 -0
  25. package/build/src/bdef/expressions/bdef_event.js +14 -0
  26. package/build/src/bdef/expressions/bdef_field.js +13 -0
  27. package/build/src/bdef/expressions/bdef_field_path.js +13 -0
  28. package/build/src/bdef/expressions/bdef_header.js +15 -0
  29. package/build/src/bdef/expressions/bdef_hierarchy.js +16 -0
  30. package/build/src/bdef/expressions/bdef_implementation_in.js +12 -0
  31. package/build/src/bdef/expressions/bdef_implementation_type.js +19 -0
  32. package/build/src/bdef/expressions/bdef_key.js +14 -0
  33. package/build/src/bdef/expressions/bdef_mapping.js +19 -0
  34. package/build/src/bdef/expressions/bdef_name.js +13 -0
  35. package/build/src/bdef/expressions/bdef_operation.js +13 -0
  36. package/build/src/bdef/expressions/bdef_options.js +15 -0
  37. package/build/src/bdef/expressions/bdef_parameter.js +13 -0
  38. package/build/src/bdef/expressions/bdef_reference.js +15 -0
  39. package/build/src/bdef/expressions/bdef_result.js +13 -0
  40. package/build/src/bdef/expressions/bdef_side_effects.js +25 -0
  41. package/build/src/bdef/expressions/bdef_string.js +11 -0
  42. package/build/src/bdef/expressions/bdef_use.js +18 -0
  43. package/build/src/bdef/expressions/index.js +46 -0
  44. package/build/src/objects/behavior_definition.js +46 -8
  45. package/build/src/registry.js +1 -1
  46. package/build/src/rules/bdef_check_syntax.js +88 -0
  47. package/build/src/rules/bdef_parser_error.js +47 -0
  48. package/build/src/rules/index.js +3 -0
  49. package/build/src/rules/prefer_raise_message.js +118 -0
  50. package/package.json +1 -1
@@ -0,0 +1,88 @@
1
+ "use strict";
2
+ Object.defineProperty(exports, "__esModule", { value: true });
3
+ exports.BDEFCheckSyntax = exports.BDEFCheckSyntaxConf = void 0;
4
+ const expressions_1 = require("../bdef/expressions");
5
+ const ddic_1 = require("../ddic");
6
+ const issue_1 = require("../issue");
7
+ const objects_1 = require("../objects");
8
+ const _basic_rule_config_1 = require("./_basic_rule_config");
9
+ const _irule_1 = require("./_irule");
10
+ class BDEFCheckSyntaxConf extends _basic_rule_config_1.BasicRuleConfig {
11
+ }
12
+ exports.BDEFCheckSyntaxConf = BDEFCheckSyntaxConf;
13
+ class BDEFCheckSyntax {
14
+ constructor() {
15
+ this.conf = new BDEFCheckSyntaxConf();
16
+ }
17
+ getMetadata() {
18
+ return {
19
+ key: "bdef_check_syntax",
20
+ title: "BDEF Check Syntax",
21
+ shortDescription: "Checks behavior definition references to entities and implementation classes",
22
+ extendedInformation: `Performs semantic checks which require other objects to be available.
23
+
24
+ Missing objects are only reported when their names match the configured errorNamespace.`,
25
+ tags: [_irule_1.RuleTag.Syntax],
26
+ };
27
+ }
28
+ getConfig() {
29
+ return this.conf;
30
+ }
31
+ setConfig(conf) {
32
+ this.conf = conf;
33
+ }
34
+ initialize(reg) {
35
+ this.reg = reg;
36
+ return this;
37
+ }
38
+ run(object) {
39
+ if (!(object instanceof objects_1.BehaviorDefinition)) {
40
+ return [];
41
+ }
42
+ const tree = object.getTree();
43
+ const file = object.findSourceFile();
44
+ if (tree === undefined || file === undefined) {
45
+ return [];
46
+ }
47
+ const issues = [];
48
+ this.checkImplementationClasses(tree, issues, file);
49
+ this.checkEntities(tree, issues, file);
50
+ return issues;
51
+ }
52
+ checkImplementationClasses(tree, issues, file) {
53
+ for (const implementation of tree.findAllExpressions(expressions_1.BDEFImplementationIn)) {
54
+ const nameNode = implementation.findDirectExpression(expressions_1.BDEFName);
55
+ if (nameNode === undefined) {
56
+ continue;
57
+ }
58
+ const name = this.name(nameNode);
59
+ if (this.reg.getObject("CLAS", name) === undefined && this.reg.inErrorNamespace(name)) {
60
+ issues.push(issue_1.Issue.atToken(file, nameNode.getFirstToken(), `Implementation class "${name}" not found`, this.getMetadata().key, this.conf.severity));
61
+ }
62
+ }
63
+ }
64
+ checkEntities(tree, issues, file) {
65
+ const ddic = new ddic_1.DDIC(this.reg);
66
+ for (const define of tree.findDirectExpressions(expressions_1.BDEFDefineBehavior)) {
67
+ if (define.getFirstToken().getStr().toUpperCase() !== "DEFINE") {
68
+ // "extend behavior for" refers to entities of the extended BDEF
69
+ continue;
70
+ }
71
+ const nameNode = define.findDirectExpression(expressions_1.BDEFName);
72
+ if (nameNode === undefined) {
73
+ continue;
74
+ }
75
+ const name = this.name(nameNode);
76
+ if (this.reg.inErrorNamespace(name)
77
+ && this.reg.getObject("DDLS", name) === undefined
78
+ && ddic.lookupDDLS(name) === undefined) {
79
+ issues.push(issue_1.Issue.atToken(file, nameNode.getFirstToken(), `Entity "${name}" not found`, this.getMetadata().key, this.conf.severity));
80
+ }
81
+ }
82
+ }
83
+ name(node) {
84
+ return node.concatTokens().replace(/ /g, "");
85
+ }
86
+ }
87
+ exports.BDEFCheckSyntax = BDEFCheckSyntax;
88
+ //# sourceMappingURL=bdef_check_syntax.js.map
@@ -0,0 +1,47 @@
1
+ "use strict";
2
+ Object.defineProperty(exports, "__esModule", { value: true });
3
+ exports.BDEFParserError = exports.BDEFParserErrorConf = void 0;
4
+ const issue_1 = require("../issue");
5
+ const _irule_1 = require("./_irule");
6
+ const _basic_rule_config_1 = require("./_basic_rule_config");
7
+ const objects_1 = require("../objects");
8
+ class BDEFParserErrorConf extends _basic_rule_config_1.BasicRuleConfig {
9
+ }
10
+ exports.BDEFParserErrorConf = BDEFParserErrorConf;
11
+ class BDEFParserError {
12
+ constructor() {
13
+ this.conf = new BDEFParserErrorConf();
14
+ }
15
+ getMetadata() {
16
+ return {
17
+ key: "bdef_parser_error",
18
+ title: "BDEF Parser Error",
19
+ shortDescription: `BDEF parsing`,
20
+ extendedInformation: `Parses behavior definitions and issues parser errors`,
21
+ tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.SingleFile],
22
+ };
23
+ }
24
+ getConfig() {
25
+ return this.conf;
26
+ }
27
+ setConfig(conf) {
28
+ this.conf = conf;
29
+ }
30
+ initialize(_reg) {
31
+ return this;
32
+ }
33
+ run(object) {
34
+ const issues = [];
35
+ if (object instanceof objects_1.BehaviorDefinition) {
36
+ const file = object.findSourceFile();
37
+ if (object.hasParserError() === true && file) {
38
+ const empty = file.getRaw().length === 0 ? ", empty file" : "";
39
+ const message = "BDEF Parser error" + empty;
40
+ issues.push(issue_1.Issue.atRow(file, 1, message, this.getMetadata().key, this.getConfig().severity));
41
+ }
42
+ }
43
+ return issues;
44
+ }
45
+ }
46
+ exports.BDEFParserError = BDEFParserError;
47
+ //# sourceMappingURL=bdef_parser_error.js.map
@@ -29,6 +29,8 @@ __exportStar(require("./allowed_object_naming"), exports);
29
29
  __exportStar(require("./allowed_object_types"), exports);
30
30
  __exportStar(require("./ambiguous_statement"), exports);
31
31
  __exportStar(require("./avoid_use"), exports);
32
+ __exportStar(require("./bdef_check_syntax"), exports);
33
+ __exportStar(require("./bdef_parser_error"), exports);
32
34
  __exportStar(require("./begin_end_names"), exports);
33
35
  __exportStar(require("./begin_single_include"), exports);
34
36
  __exportStar(require("./boolean_flag_via_if"), exports);
@@ -171,6 +173,7 @@ __exportStar(require("./prefer_pragmas"), exports);
171
173
  __exportStar(require("./prefer_abap_bool"), exports);
172
174
  __exportStar(require("./prefer_abap_bool_values"), exports);
173
175
  __exportStar(require("./prefer_raise_exception_new"), exports);
176
+ __exportStar(require("./prefer_raise_message"), exports);
174
177
  __exportStar(require("./prefer_string_template"), exports);
175
178
  __exportStar(require("./prefer_returning_to_exporting"), exports);
176
179
  __exportStar(require("./prefer_xsdbool"), exports);
@@ -0,0 +1,118 @@
1
+ "use strict";
2
+ var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
3
+ if (k2 === undefined) k2 = k;
4
+ var desc = Object.getOwnPropertyDescriptor(m, k);
5
+ if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
6
+ desc = { enumerable: true, get: function() { return m[k]; } };
7
+ }
8
+ Object.defineProperty(o, k2, desc);
9
+ }) : (function(o, m, k, k2) {
10
+ if (k2 === undefined) k2 = k;
11
+ o[k2] = m[k];
12
+ }));
13
+ var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
14
+ Object.defineProperty(o, "default", { enumerable: true, value: v });
15
+ }) : function(o, v) {
16
+ o["default"] = v;
17
+ });
18
+ var __importStar = (this && this.__importStar) || (function () {
19
+ var ownKeys = function(o) {
20
+ ownKeys = Object.getOwnPropertyNames || function (o) {
21
+ var ar = [];
22
+ for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
23
+ return ar;
24
+ };
25
+ return ownKeys(o);
26
+ };
27
+ return function (mod) {
28
+ if (mod && mod.__esModule) return mod;
29
+ var result = {};
30
+ if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
31
+ __setModuleDefault(result, mod);
32
+ return result;
33
+ };
34
+ })();
35
+ Object.defineProperty(exports, "__esModule", { value: true });
36
+ exports.PreferRaiseMessage = exports.PreferRaiseMessageConf = void 0;
37
+ const issue_1 = require("../issue");
38
+ const _abap_rule_1 = require("./_abap_rule");
39
+ const _basic_rule_config_1 = require("./_basic_rule_config");
40
+ const _irule_1 = require("./_irule");
41
+ const Statements = __importStar(require("../abap/2_statements/statements"));
42
+ const Expressions = __importStar(require("../abap/2_statements/expressions"));
43
+ class PreferRaiseMessageConf extends _basic_rule_config_1.BasicRuleConfig {
44
+ constructor() {
45
+ super(...arguments);
46
+ /** List of exception class names to ignore, case insensitive */
47
+ this.ignoreExceptionClasses = [];
48
+ }
49
+ }
50
+ exports.PreferRaiseMessageConf = PreferRaiseMessageConf;
51
+ class PreferRaiseMessage extends _abap_rule_1.ABAPRule {
52
+ constructor() {
53
+ super(...arguments);
54
+ this.conf = new PreferRaiseMessageConf();
55
+ }
56
+ getMetadata() {
57
+ return {
58
+ key: "prefer_raise_message",
59
+ title: "Prefer RAISE EXCEPTION with MESSAGE",
60
+ shortDescription: `Prefer RAISE EXCEPTION with MESSAGE instead of supplying parameter TEXT`,
61
+ extendedInformation: `Reports RAISE EXCEPTION statements where parameter TEXT is supplied.
62
+
63
+ Use a message class instead, so the text is translatable and can be found via where-used.
64
+
65
+ Exception classes can be excluded via configuration "ignoreExceptionClasses".`,
66
+ tags: [_irule_1.RuleTag.SingleFile],
67
+ goodExample: `RAISE EXCEPTION TYPE zcx_error MESSAGE e001(zclass).`,
68
+ badExample: `RAISE EXCEPTION TYPE zcx_error
69
+ EXPORTING text = 'hello world'.`,
70
+ };
71
+ }
72
+ getConfig() {
73
+ return this.conf;
74
+ }
75
+ setConfig(conf) {
76
+ this.conf = conf;
77
+ }
78
+ runParsed(file) {
79
+ var _a, _b, _c, _d;
80
+ var _e;
81
+ const issues = [];
82
+ const ignore = ((_e = this.conf.ignoreExceptionClasses) !== null && _e !== void 0 ? _e : []).map(c => c.toUpperCase());
83
+ for (const statement of file.getStatements()) {
84
+ if (!(statement.get() instanceof Statements.Raise)) {
85
+ continue;
86
+ }
87
+ const concat = statement.concatTokens().toUpperCase();
88
+ if (!concat.startsWith("RAISE EXCEPTION ") && !concat.startsWith("RAISE RESUMABLE EXCEPTION ")) {
89
+ continue;
90
+ }
91
+ else if (concat.includes(" MESSAGE")) {
92
+ continue;
93
+ }
94
+ let className;
95
+ let parameters;
96
+ const newObject = (_b = (_a = statement.findDirectExpression(Expressions.Source)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.MethodCallChain)) === null || _b === void 0 ? void 0 : _b.findDirectExpression(Expressions.NewObject);
97
+ if (newObject) {
98
+ className = (_c = newObject.findDirectExpression(Expressions.TypeNameOrInfer)) === null || _c === void 0 ? void 0 : _c.concatTokens();
99
+ parameters = newObject.findDirectExpression(Expressions.ParameterListS);
100
+ }
101
+ else {
102
+ className = (_d = statement.findDirectExpression(Expressions.ClassName)) === null || _d === void 0 ? void 0 : _d.concatTokens();
103
+ parameters = statement.findDirectExpression(Expressions.ParameterListS);
104
+ }
105
+ if (className === undefined || ignore.includes(className.toUpperCase())) {
106
+ continue;
107
+ }
108
+ const text = parameters === null || parameters === void 0 ? void 0 : parameters.findDirectExpressions(Expressions.ParameterS).find(p => { var _a; return ((_a = p.findDirectExpression(Expressions.ParameterName)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase()) === "TEXT"; });
109
+ if (text) {
110
+ const message = "Prefer RAISE EXCEPTION with MESSAGE, " + className + " raised with parameter TEXT";
111
+ issues.push(issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity));
112
+ }
113
+ }
114
+ return issues;
115
+ }
116
+ }
117
+ exports.PreferRaiseMessage = PreferRaiseMessage;
118
+ //# sourceMappingURL=prefer_raise_message.js.map
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@abaplint/core",
3
- "version": "2.120.83",
3
+ "version": "2.120.85",
4
4
  "description": "abaplint - Core API",
5
5
  "main": "build/src/index.js",
6
6
  "typings": "build/abaplint.d.ts",