@abaplint/core 2.120.73 → 2.120.75

package/build/src/rules/changing_sorted_line.js

@@ -0,0 +1,235 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.ChangingSortedLine = exports.ChangingSortedLineConf = void 0;
+const Expressions = __importStar(require("../abap/2_statements/expressions"));
+const Statements = __importStar(require("../abap/2_statements/statements"));
+const Structures = __importStar(require("../abap/3_structures/structures"));
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const issue_1 = require("../issue");
+const _irule_1 = require("./_irule");
+const syntax_1 = require("../abap/5_syntax/syntax");
+const _abap_object_1 = require("../objects/_abap_object");
+const basic_1 = require("../abap/types/basic");
+const nodes_1 = require("../abap/nodes");
+const _typed_identifier_1 = require("../abap/types/_typed_identifier");
+const tokens_1 = require("../abap/1_lexer/tokens");
+class ChangingSortedLineConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.ChangingSortedLineConf = ChangingSortedLineConf;
+class ChangingSortedLine {
+    constructor() {
+        this.conf = new ChangingSortedLineConf();
+    }
+    getMetadata() {
+        return {
+            key: "changing_sorted_line",
+            title: "Line of a sorted or hashed table passed to CHANGING",
+            shortDescription: `A field symbol on a whole line of a sorted or hashed table, passed to a CHANGING parameter of a method`,
+            extendedInformation: `The key fields of a sorted or hashed table line are write-protected, so the line as a whole is
+write-protected. Binding it to a CHANGING parameter activates, but the call fails at runtime with
+CX_SY_DYN_CALL_ILLEGAL_TYPE, "the actual parameter for ... is write-protected", even when the method does not
+change the key.
+
+Only field symbols assigned in the same method, form or function module are checked, via READ TABLE ... ASSIGNING,
+LOOP AT ... ASSIGNING, INSERT ... INTO TABLE ... ASSIGNING and ASSIGN itab[ ... ] TO.
+
+Fix: read the line into a work area, pass the work area and MODIFY TABLE ... FROM it afterwards,
+or pass only the non-key fields the method needs.`,
+            tags: [_irule_1.RuleTag.SingleFile],
+            badExample: `READ TABLE lt_sum WITH TABLE KEY app = lv_app ASSIGNING FIELD-SYMBOL(<sum>).
+add( CHANGING cs_sum = <sum> ).`,
+            goodExample: `READ TABLE lt_sum WITH TABLE KEY app = lv_app INTO DATA(ls_sum).
+add( CHANGING cs_sum = ls_sum ).
+MODIFY TABLE lt_sum FROM ls_sum.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    initialize(reg) {
+        this.reg = reg;
+        return this;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    run(obj) {
+        if (!(obj instanceof _abap_object_1.ABAPObject) || obj.getType() === "INTF") {
+            return [];
+        }
+        const issues = [];
+        let spaghetti = undefined;
+        for (const file of obj.getABAPFiles()) {
+            const stru = file.getStructure();
+            if (stru === undefined || stru.findFirstExpression(Expressions.MethodParameters) === undefined) {
+                continue;
+            }
+            if (spaghetti === undefined) {
+                spaghetti = new syntax_1.SyntaxLogic(this.reg, obj).run().spaghetti;
+            }
+            const blocks = [...stru.findAllStructures(Structures.Method),
+                ...stru.findAllStructures(Structures.Form),
+                ...stru.findAllStructures(Structures.FunctionModule)];
+            for (const block of blocks) {
+                // field symbol name -> name of the sorted or hashed table it points into
+                const lines = new Map();
+                for (const statement of block.findAllStatementNodes()) {
+                    for (const p of statement.findAllExpressions(Expressions.MethodParameters)) {
+                        this.checkChanging(p, lines, spaghetti, file, issues);
+                    }
+                    this.updateAssigned(statement, lines, spaghetti, file);
+                }
+            }
+        }
+        return issues;
+    }
+    ////////////////
+    checkChanging(params, lines, spaghetti, file, issues) {
+        var _a, _b;
+        let changing = false;
+        for (const child of params.getChildren()) {
+            const str = child.concatTokens().toUpperCase();
+            if (child instanceof nodes_1.ExpressionNode && changing === true && child.get() instanceof Expressions.ParameterListT) {
+                for (const p of child.findDirectExpressions(Expressions.ParameterT)) {
+                    const target = p.findDirectExpression(Expressions.Target);
+                    const fs = (target === null || target === void 0 ? void 0 : target.getChildren().length) === 1 ? target.findDirectExpression(Expressions.TargetFieldSymbol) : undefined;
+                    if (fs === undefined) {
+                        continue;
+                    }
+                    const table = lines.get(fs.concatTokens().toUpperCase());
+                    const type = (_a = this.findReference(fs.getFirstToken().getStart(), spaghetti, file)) === null || _a === void 0 ? void 0 : _a.getType();
+                    if (table === undefined || type === undefined || type.isGeneric()) {
+                        continue;
+                    }
+                    const name = (_b = p.findDirectExpression(Expressions.ParameterName)) === null || _b === void 0 ? void 0 : _b.concatTokens();
+                    const message = `Line of sorted or hashed table ${table} passed to CHANGING ${name} is write-protected, ` +
+                        `the call fails at runtime. Use a work area and MODIFY TABLE ... FROM, or pass only non-key fields`;
+                    issues.push(issue_1.Issue.atToken(file, fs.getFirstToken(), message, this.getMetadata().key, this.conf.severity));
+                }
+            }
+            changing = str === "CHANGING";
+        }
+    }
+    /** Tracks which field symbols the last assignment pointed to a whole line of a sorted or hashed table */
+    updateAssigned(statement, lines, spaghetti, file) {
+        var _a, _b, _c;
+        var _d;
+        const get = statement.get();
+        const fs = get instanceof Statements.Unassign
+            ? statement.findDirectExpression(Expressions.TargetFieldSymbol)
+            : (_a = statement.findFirstExpression(Expressions.FSTarget)) === null || _a === void 0 ? void 0 : _a.findFirstExpression(Expressions.TargetFieldSymbol);
+        if (fs === undefined) {
+            return;
+        }
+        const name = fs.concatTokens().toUpperCase();
+        let table = undefined;
+        let isTableExpression = false;
+        if (get instanceof Statements.ReadTable) {
+            table = (_d = statement.findDirectExpression(Expressions.SimpleSource2)) !== null && _d !== void 0 ? _d : statement.findDirectExpression(Expressions.Source);
+        }
+        else if (get instanceof Statements.Loop) {
+            table = (_b = statement.findDirectExpression(Expressions.LoopSource)) === null || _b === void 0 ? void 0 : _b.getFirstChild();
+        }
+        else if (get instanceof Statements.InsertInternal && statement.findDirectTokenByText("TABLE") !== undefined) {
+            table = statement.findDirectExpression(Expressions.Target);
+        }
+        else if (get instanceof Statements.Assign) {
+            table = (_c = statement.findDirectExpression(Expressions.AssignSource)) === null || _c === void 0 ? void 0 : _c.getFirstChild();
+            isTableExpression = true;
+        }
+        const tableType = table instanceof nodes_1.ExpressionNode ? this.findTableType(table, isTableExpression, spaghetti, file) : undefined;
+        if (table instanceof nodes_1.ExpressionNode && tableType instanceof basic_1.TableType
+            && (tableType.getAccessType() === basic_1.TableAccessType.sorted || tableType.getAccessType() === basic_1.TableAccessType.hashed)) {
+            lines.set(name, table.concatTokens().replace(/\[.*$/, "").trim());
+        }
+        else {
+            lines.delete(name);
+        }
+    }
+    /** The type of a table given by a plain field chain of names, components and attributes, else undefined.
+     *  With tableExpression, the chain must end with a table expression, and the type of the chain before it is returned */
+    findTableType(node, tableExpression, spaghetti, file) {
+        var _a, _b;
+        if (!(node.get() instanceof Expressions.Target)) {
+            const chain = node.getChildren().length === 1 ? node.findDirectExpression(Expressions.FieldChain) : undefined;
+            if (chain === undefined) {
+                return undefined;
+            }
+            node = chain;
+        }
+        const children = [...node.getChildren()];
+        if (tableExpression === true) {
+            if (!(((_a = children.pop()) === null || _a === void 0 ? void 0 : _a.get()) instanceof Expressions.TableExpression)) {
+                return undefined;
+            }
+        }
+        let type = undefined;
+        for (const child of children) {
+            const get = child.get();
+            if (get instanceof Expressions.SourceField
+                || get instanceof Expressions.SourceFieldSymbol
+                || get instanceof Expressions.TargetField
+                || get instanceof Expressions.TargetFieldSymbol
+                || get instanceof Expressions.AttributeName) {
+                type = (_b = this.findReference(child.getFirstToken().getStart(), spaghetti, file)) === null || _b === void 0 ? void 0 : _b.getType();
+            }
+            else if (get instanceof Expressions.ComponentName) {
+                type = type instanceof basic_1.StructureType ? type.getComponentByName(child.concatTokens()) : undefined;
+            }
+            else if (get instanceof Expressions.ClassName || get instanceof tokens_1.StaticArrow) {
+                continue;
+            }
+            else if (!(get instanceof tokens_1.Dash) && !(get instanceof tokens_1.InstanceArrow)) {
+                return undefined;
+            }
+            if (type === undefined) {
+                return undefined;
+            }
+        }
+        return type;
+    }
+    findReference(start, spaghetti, file) {
+        const scope = spaghetti.lookupPosition(start, file.getFilename());
+        for (const r of (scope === null || scope === void 0 ? void 0 : scope.getData().references) || []) {
+            if (r.position.getStart().equals(start) && r.resolved instanceof _typed_identifier_1.TypedIdentifier) {
+                return r.resolved;
+            }
+        }
+        return undefined;
+    }
+}
+exports.ChangingSortedLine = ChangingSortedLine;
+//# sourceMappingURL=changing_sorted_line.js.map

package/build/src/rules/class_attribute_names.js

@@ -30,6 +30,7 @@ class ClassAttributeNames extends _abap_rule_1.ABAPRule {
     constructor() {
         super(...arguments);
         this.conf = new ClassAttributeNamesConf();
+        this.regex = this.compile();
     }
     getMetadata() {
         return {
@@ -57,6 +58,15 @@ ENDCLASS.`,
     }
     setConfig(conf) {
         this.conf = conf;
+        this.regex = this.compile();
+    }
+    compile() {
+        return {
+            statics: new RegExp(this.conf.statics, "i"),
+            instance: new RegExp(this.conf.instance, "i"),
+            constants: new RegExp(this.conf.constants, "i"),
+            ignorePatterns: name_validator_1.NameValidator.compileIgnorePatterns(this.conf),
+        };
     }
     runParsed(file, obj) {
         if (this.conf.patternKind === undefined) {
@@ -89,13 +99,13 @@ ENDCLASS.`,
         for (const a of attr) {
             switch (a.level) {
                 case _abap_file_information_1.AttributeLevel.Instance:
-                    ret = ret.concat(this.checkName(a.identifier, this.conf.instance));
+                    ret = ret.concat(this.checkName(a.identifier, this.conf.instance, this.regex.instance));
                     break;
                 case _abap_file_information_1.AttributeLevel.Static:
-                    ret = ret.concat(this.checkName(a.identifier, this.conf.statics));
+                    ret = ret.concat(this.checkName(a.identifier, this.conf.statics, this.regex.statics));
                     break;
                 case _abap_file_information_1.AttributeLevel.Constant:
-                    ret = ret.concat(this.checkName(a.identifier, this.conf.constants));
+                    ret = ret.concat(this.checkName(a.identifier, this.conf.constants, this.regex.constants));
                     break;
                 default:
                     break;
@@ -103,11 +113,10 @@ ENDCLASS.`,
         }
         return ret;
     }
-    checkName(attr, expected) {
+    checkName(attr, expected, regex) {
         const ret = [];
-        const regex = new RegExp(expected, "i");
         const name = attr.getName();
-        if (name_validator_1.NameValidator.violatesRule(name, regex, this.conf)) {
+        if (name_validator_1.NameValidator.violatesRule(name, regex, this.conf, this.regex.ignorePatterns)) {
             const issue = issue_1.Issue.atIdentifier(attr, this.getDescription(name, expected), this.getMetadata().key, this.conf.severity);
             ret.push(issue);
         }

package/build/src/rules/delete_index_in_loop.js

@@ -0,0 +1,163 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.DeleteIndexInLoop = exports.DeleteIndexInLoopConf = void 0;
+const Statements = __importStar(require("../abap/2_statements/statements"));
+const Expressions = __importStar(require("../abap/2_statements/expressions"));
+const issue_1 = require("../issue");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _abap_rule_1 = require("./_abap_rule");
+const _irule_1 = require("./_irule");
+const token_node_1 = require("../abap/nodes/token_node");
+const _statement_1 = require("../abap/2_statements/statements/_statement");
+class DeleteIndexInLoopConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.DeleteIndexInLoopConf = DeleteIndexInLoopConf;
+class DeleteIndexInLoop extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new DeleteIndexInLoopConf();
+    }
+    getMetadata() {
+        return {
+            key: "delete_index_in_loop",
+            title: "DELETE INDEX sy-tabix inside a LOOP over the same table",
+            shortDescription: `Reports DELETE itab INDEX sy-tabix inside a LOOP AT the same table`,
+            extendedInformation: `sy-tabix is the index of the loop's current row only until another statement writes it.
+READ TABLE, APPEND, INSERT, COLLECT, a nested LOOP and any method called in the loop body
+all set sy-tabix. After that the DELETE removes a different row, and if sy-tabix is 0 it
+raises the runtime error TABLE_INVALID_INDEX.
+
+Use DELETE itab WHERE ..., or collect the rows to keep in a second table.
+
+Not reported: DELETE itab INDEX sy-tabix directly after READ TABLE itab, where sy-tabix
+is the index the READ just set.`,
+            tags: [_irule_1.RuleTag.SingleFile],
+            badExample: `LOOP AT tab INTO row.
+  IF row-flag = abap_true.
+    DELETE tab INDEX sy-tabix.
+  ENDIF.
+ENDLOOP.`,
+            goodExample: `DELETE tab WHERE flag = abap_true.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        const statements = file.getStatements();
+        for (let i = 0; i < statements.length; i++) {
+            const statement = statements[i];
+            if (!(statement.get() instanceof Statements.DeleteInternal) || this.byTabix(statement) === false) {
+                continue;
+            }
+            // DELETE TABLE and DELETE ADJACENT DUPLICATES have a keyword before the target
+            const target = statement.findDirectExpression(Expressions.Target);
+            if (target === undefined || statement.getChildren()[1] !== target) {
+                continue;
+            }
+            const table = target.concatTokens().toUpperCase();
+            if (this.previousReadsTable(i, statements, table) === true
+                || this.enclosingLoopTables(i, statements).includes(table) === false) {
+                continue;
+            }
+            const message = `DELETE ${target.concatTokens()} INDEX sy-tabix inside LOOP AT the same table,`
+                + ` sy-tabix might not be the loop's current row`;
+            issues.push(issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity));
+        }
+        return issues;
+    }
+    ////////////////
+    byTabix(statement) {
+        const children = statement.getChildren();
+        for (let i = 0; i < children.length - 1; i++) {
+            const child = children[i];
+            if (child instanceof token_node_1.TokenNode && child.getFirstToken().getStr().toUpperCase() === "INDEX") {
+                return children[i + 1].concatTokens().toUpperCase() === "SY-TABIX";
+            }
+        }
+        return false;
+    }
+    previousReadsTable(index, statements, table) {
+        var _a;
+        for (let i = index - 1; i >= 0; i--) {
+            const statement = statements[i];
+            if (statement.get() instanceof _statement_1.Comment) {
+                continue;
+            }
+            if (!(statement.get() instanceof Statements.ReadTable)) {
+                return false;
+            }
+            const read = (_a = statement.findDirectExpression(Expressions.SimpleSource2)) !== null && _a !== void 0 ? _a : statement.findDirectExpression(Expressions.Source);
+            return (read === null || read === void 0 ? void 0 : read.concatTokens().toUpperCase()) === table;
+        }
+        return false;
+    }
+    enclosingLoopTables(index, statements) {
+        const tables = [];
+        let depth = 0;
+        for (let i = index - 1; i >= 0; i--) {
+            const statement = statements[i];
+            const s = statement.get();
+            if (s instanceof Statements.EndLoop) {
+                depth++;
+            }
+            else if (s instanceof Statements.Loop) {
+                if (depth === 0) {
+                    const source = statement.findDirectExpression(Expressions.LoopSource);
+                    if (source !== undefined) {
+                        tables.push(source.concatTokens().toUpperCase());
+                    }
+                }
+                else {
+                    depth--;
+                }
+            }
+            else if (s instanceof Statements.MethodImplementation
+                || s instanceof Statements.Form
+                || s instanceof Statements.FunctionModule
+                || s instanceof Statements.Module) {
+                break;
+            }
+        }
+        return tables;
+    }
+}
+exports.DeleteIndexInLoop = DeleteIndexInLoop;
+//# sourceMappingURL=delete_index_in_loop.js.map

package/build/src/rules/final_newline.js

@@ -0,0 +1,78 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.FinalNewline = exports.FinalNewlineConf = void 0;
+const issue_1 = require("../issue");
+const position_1 = require("../position");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const edit_helper_1 = require("../edit_helper");
+const _irule_1 = require("./_irule");
+const objects_1 = require("../objects");
+class FinalNewlineConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.FinalNewlineConf = FinalNewlineConf;
+class FinalNewline {
+    constructor() {
+        this.conf = new FinalNewlineConf();
+    }
+    getMetadata() {
+        return {
+            key: "final_newline",
+            title: "Final newline",
+            shortDescription: `Checks that ABAP and XML files end with exactly one newline`,
+            extendedInformation: `abapGit serializes every file with exactly one newline at the end. A file without it,
+or with empty lines at the end, is changed again on the next pull and shows up in every diff.
+
+Empty files and files containing only line breaks are not checked. A carriage return before the
+newline is ignored, see rule line_break_style. SMIM and W3MI files and XSLT sources are not checked.`,
+            tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
+            badExample: `WRITE 'hello'.`,
+            goodExample: `WRITE 'hello'.\n`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    initialize(_reg) {
+        return this;
+    }
+    run(obj) {
+        const issues = [];
+        if (obj instanceof objects_1.MIMEObject || obj instanceof objects_1.WebMIME) {
+            return issues;
+        }
+        for (const file of obj.getFiles()) {
+            const filename = file.getFilename();
+            if ((filename.endsWith(".abap") || filename.endsWith(".xml")) && !filename.endsWith(".xslt.source.xml")) {
+                const issue = this.checkFile(file);
+                if (issue) {
+                    issues.push(issue);
+                }
+            }
+        }
+        return issues;
+    }
+    checkFile(file) {
+        const rows = file.getRawRows();
+        const last = rows[rows.length - 1];
+        if (last !== "") {
+            const end = new position_1.Position(rows.length, last.length + 1);
+            const fix = edit_helper_1.EditHelper.insertAt(file, end, "\n");
+            return issue_1.Issue.atPosition(file, end, "Add newline at end of file", this.getMetadata().key, this.conf.severity, fix);
+        }
+        let row = rows.length - 2;
+        while (row >= 0 && (rows[row] === "" || rows[row] === "\r")) {
+            row--;
+        }
+        if (row < 0 || row === rows.length - 2) {
+            return undefined;
+        }
+        const start = new position_1.Position(row + 2, 1);
+        const fix = edit_helper_1.EditHelper.deleteRange(file, start, new position_1.Position(rows.length, 1));
+        return issue_1.Issue.atPosition(file, start, "Remove empty lines at end of file", this.getMetadata().key, this.conf.severity, fix);
+    }
+}
+exports.FinalNewline = FinalNewline;
+//# sourceMappingURL=final_newline.js.map

package/build/src/rules/forbidden_identifier.js

@@ -20,6 +20,7 @@ class ForbiddenIdentifier extends _abap_rule_1.ABAPRule {
     constructor() {
         super(...arguments);
         this.conf = new ForbiddenIdentifierConf();
+        this.checks = [];
     }
     getMetadata() {
         return {
@@ -39,9 +40,10 @@ https://github.com/abaplint/transpiler/blob/bda94b8b56e2b7f2f87be2168f12361aa530
         if (this.conf.check === undefined) {
             this.conf.check = [];
         }
+        this.checks = this.conf.check.map(c => new RegExp(c, "i"));
     }
     runParsed(file) {
-        if (this.conf.check.length === 0) {
+        if (this.checks.length === 0) {
             return [];
         }
         let ret = [];
@@ -68,8 +70,7 @@ https://github.com/abaplint/transpiler/blob/bda94b8b56e2b7f2f87be2168f12361aa530
     check(token, file) {
         const str = token.getStr();
         const ret = [];
-        for (const c of this.conf.check) {
-            const reg = new RegExp(c, "i");
+        for (const reg of this.checks) {
             if (reg.exec(str)) {
                 const message = "Identifer \"" + str + "\" not allowed";
                 ret.push(issue_1.Issue.atToken(file, token, message, this.getMetadata().key, this.conf.severity));

package/build/src/rules/forbidden_void_type.js

@@ -22,6 +22,7 @@ exports.ForbiddenVoidTypeConf = ForbiddenVoidTypeConf;
 class ForbiddenVoidType {
     constructor() {
         this.conf = new ForbiddenVoidTypeConf();
+        this.checks = [];
     }
     getMetadata() {
         return {
@@ -41,13 +42,14 @@ DATS, TIMS, DATUM, FLAG, INT4, NUMC3, NUMC4, SAP_BOOL, TEXT25, TEXT80, X255, XFE
         if (this.conf.check === undefined) {
             this.conf.check = [];
         }
+        this.checks = this.conf.check.map(c => new RegExp(c, "i"));
     }
     initialize(reg) {
         this.reg = reg;
         return this;
     }
     run(obj) {
-        if (!(obj instanceof _abap_object_1.ABAPObject) || this.conf.check.length === 0) {
+        if (!(obj instanceof _abap_object_1.ABAPObject) || this.checks.length === 0) {
             return [];
         }
         return this.traverse(new syntax_1.SyntaxLogic(this.reg, obj).run().spaghetti.getTop());
@@ -90,14 +92,7 @@ DATS, TIMS, DATUM, FLAG, INT4, NUMC3, NUMC4, SAP_BOOL, TEXT25, TEXT80, X255, XFE
         if (name === undefined) {
             return false;
         }
-        for (const c of this.conf.check) {
-            const reg = new RegExp(c, "i");
-            const match = reg.test(name);
-            if (match === true) {
-                return true;
-            }
-        }
-        return false;
+        return this.checks.some(reg => reg.test(name));
     }
 }
 exports.ForbiddenVoidType = ForbiddenVoidType;

package/build/src/rules/index.js

@@ -16,6 +16,9 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
 Object.defineProperty(exports, "__esModule", { value: true });
 __exportStar(require("./7bit_ascii"), exports);
 __exportStar(require("./abapdoc"), exports);
+__exportStar(require("./abapdoc_html_tag"), exports);
+__exportStar(require("./abapdoc_leading_at"), exports);
+__exportStar(require("./abapdoc_parameter_names"), exports);
 __exportStar(require("./add_test_attributes"), exports);
 __exportStar(require("./aff_and_xml"), exports);
 __exportStar(require("./align_parameters"), exports);
@@ -38,6 +41,7 @@ __exportStar(require("./cds_naming"), exports);
 __exportStar(require("./cds_parser_error"), exports);
 __exportStar(require("./chain_mainly_declarations"), exports);
 __exportStar(require("./change_if_to_case"), exports);
+__exportStar(require("./changing_sorted_line"), exports);
 __exportStar(require("./check_abstract"), exports);
 __exportStar(require("./check_comments"), exports);
 __exportStar(require("./check_ddic"), exports);
@@ -60,6 +64,7 @@ __exportStar(require("./cyclomatic_complexity"), exports);
 __exportStar(require("./dangerous_statement"), exports);
 __exportStar(require("./db_operation_in_loop"), exports);
 __exportStar(require("./definitions_top"), exports);
+__exportStar(require("./delete_index_in_loop"), exports);
 __exportStar(require("./description_empty"), exports);
 __exportStar(require("./double_space"), exports);
 __exportStar(require("./downport"), exports);
@@ -73,6 +78,7 @@ __exportStar(require("./else_after_all_returns"), exports);
 __exportStar(require("./exit_or_check"), exports);
 __exportStar(require("./expand_macros"), exports);
 __exportStar(require("./exporting"), exports);
+__exportStar(require("./final_newline"), exports);
 __exportStar(require("./fm_global_parameters_obsolete"), exports);
 __exportStar(require("./forbidden_identifier"), exports);
 __exportStar(require("./forbidden_pseudo_and_pragma"), exports);
@@ -96,6 +102,7 @@ __exportStar(require("./in_statement_indentation"), exports);
 __exportStar(require("./indentation"), exports);
 __exportStar(require("./index_completely_contained"), exports);
 __exportStar(require("./inline_data_old_versions"), exports);
+__exportStar(require("./inline_packed_computation"), exports);
 __exportStar(require("./intf_referencing_clas"), exports);
 __exportStar(require("./invalid_table_index"), exports);
 __exportStar(require("./keep_single_parameter_on_one_line"), exports);
@@ -147,6 +154,7 @@ __exportStar(require("./parser_missing_space"), exports);
 __exportStar(require("./pragma_style"), exports);
 __exportStar(require("./prefer_corresponding"), exports);
 __exportStar(require("./prefer_inline"), exports);
+__exportStar(require("./prefer_inline_cast"), exports);
 __exportStar(require("./prefer_insert_into_table"), exports);
 __exportStar(require("./prefer_is_not"), exports);
 __exportStar(require("./prefer_pragmas"), exports);
@@ -159,6 +167,7 @@ __exportStar(require("./prefer_xsdbool"), exports);
 __exportStar(require("./preferred_compare_operator"), exports);
 __exportStar(require("./preferred_parameter_ignored"), exports);
 __exportStar(require("./prefix_is_current_class"), exports);
+__exportStar(require("./range_row_values"), exports);
 __exportStar(require("./reduce_procedural_code"), exports);
 __exportStar(require("./reduce_string_templates"), exports);
 __exportStar(require("./redundant_conversion"), exports);
@@ -175,6 +184,7 @@ __exportStar(require("./short_case"), exports);
 __exportStar(require("./sicf_consistency"), exports);
 __exportStar(require("./slow_parameter_passing"), exports);
 __exportStar(require("./smim_consistency"), exports);
+__exportStar(require("./sort_empty_key"), exports);
 __exportStar(require("./space_before_colon"), exports);
 __exportStar(require("./space_before_dot"), exports);
 __exportStar(require("./sql_escape_host_variables"), exports);
@@ -182,6 +192,7 @@ __exportStar(require("./sql_value_conversion"), exports);
 __exportStar(require("./start_at_tab"), exports);
 __exportStar(require("./static_call_via_instance"), exports);
 __exportStar(require("./strict_sql"), exports);
+__exportStar(require("./subrc_after_assign"), exports);
 __exportStar(require("./superclass_final"), exports);
 __exportStar(require("./superfluous_value"), exports);
 __exportStar(require("./sy_modification"), exports);