@abaplint/core 2.120.71 → 2.120.73

package/build/src/rules/generic_regex.js

@@ -0,0 +1,86 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.GenericRegex = exports.GenericRegexConf = void 0;
+const issue_1 = require("../issue");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+class GenericRegexConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        /** List of forbidden regular expressions, case insensitive, checked against each line of every file.
+         * Patterns use JavaScript regex syntax without enclosing slashes or flags.
+         * @uniqueItems true
+         */
+        this.regexes = [];
+    }
+}
+exports.GenericRegexConf = GenericRegexConf;
+class GenericRegex {
+    constructor() {
+        this.conf = new GenericRegexConf();
+        this.regexes = [];
+    }
+    getMetadata() {
+        return {
+            key: "generic_regex",
+            title: "Generic regex",
+            shortDescription: "Report an issue for each match of a configured regular expression.",
+            extendedInformation: `Checks each line of every object file, including comments, strings, and XML.
+Patterns use JavaScript regular expression syntax without enclosing slashes or flags.
+Matching is case insensitive and does not span multiple lines. Each non-overlapping match is reported.
+Use the standard exclude configuration to skip files.
+
+Example configuration: \`{"generic_regex": {"regexes": ["TODO", "BREAK-POINT"]}}\``,
+            tags: [_irule_1.RuleTag.SingleFile],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        var _a;
+        this.conf = Object.assign(new GenericRegexConf(), conf);
+        this.conf.regexes = (_a = this.conf.regexes) !== null && _a !== void 0 ? _a : [];
+    }
+    initialize(_reg) {
+        this.regexes = this.conf.regexes.map(pattern => {
+            try {
+                return new RegExp(pattern, "gi");
+            }
+            catch (_a) {
+                throw new Error(`generic_regex: Invalid regular expression "${pattern}"`);
+            }
+        });
+        return this;
+    }
+    run(obj) {
+        const issues = [];
+        if (this.regexes.length === 0) {
+            return issues;
+        }
+        for (const file of obj.getFiles()) {
+            const rows = file.getRawRows();
+            for (let row = 0; row < rows.length; row++) {
+                const text = rows[row].replace(/\r$/, "");
+                for (const regex of this.regexes) {
+                    regex.lastIndex = 0;
+                    for (;;) {
+                        const match = regex.exec(text);
+                        if (match === null) {
+                            break;
+                        }
+                        const startCol = match.index + 1;
+                        const message = `Text matches forbidden regular expression "${regex.source}"`;
+                        issues.push(issue_1.Issue.atRowRange(file, row + 1, startCol, startCol + match[0].length, message, this.getMetadata().key, this.conf.severity));
+                        if (match[0].length === 0) {
+                            regex.lastIndex++;
+                        }
+                    }
+                }
+            }
+        }
+        return issues;
+    }
+}
+exports.GenericRegex = GenericRegex;
+//# sourceMappingURL=generic_regex.js.map

package/build/src/rules/index.js

@@ -82,6 +82,7 @@ __exportStar(require("./fully_type_constants"), exports);
 __exportStar(require("./fully_type_itabs"), exports);
 __exportStar(require("./function_module_recommendations"), exports);
 __exportStar(require("./functional_writing"), exports);
+__exportStar(require("./generic_regex"), exports);
 __exportStar(require("./global_class"), exports);
 __exportStar(require("./identical_conditions"), exports);
 __exportStar(require("./identical_contents"), exports);

package/build/src/rules/keyword_case.js

@@ -215,7 +215,7 @@ class KeywordCase extends _abap_rule_1.ABAPRule {
         const firstToken = tokens[0].token;
         const lastToken = tokens[tokens.length - 1].token;
         const firstTokenValue = firstToken.getStr();
-        let description = "";
+        let description;
         if (first.keyword === true) {
             description = `Keyword should be ${this.conf.style} case: "${firstTokenValue}"`;
         }

package/build/src/rules/local_class_naming.js

@@ -58,7 +58,7 @@ ENDCLASS.`,
                 continue;
             }
             const className = classDef.name;
-            let expected = "";
+            let expected;
             if (classDef.isForTesting) {
                 expected = this.conf.test;
             }

package/build/src/rules/many_parentheses.js

@@ -86,7 +86,7 @@ ENDIF.
             issues.push(...this.analyzeCondition(file, cond));
         }
         for (const sub of structure.findAllExpressionsMulti([Expressions.CondSub, Expressions.ComponentCondSub])) {
-            let cond = [];
+            let cond;
             if (sub.get() instanceof Expressions.CondSub) {
                 cond = sub.findDirectExpressions(Expressions.Cond);
             }

package/build/src/rules/obsolete_statement.js

@@ -486,13 +486,9 @@ ENDIF.`,
         }
         else if (statement instanceof Statements.ClassDefinitionLoad ||
             statement instanceof Statements.InterfaceLoad) {
-            let token = undefined;
-            if (statement instanceof Statements.ClassDefinitionLoad) {
-                token = statementNode.getChildren()[3].getFirstToken();
-            }
-            else {
-                token = statementNode.getChildren()[2].getFirstToken();
-            }
+            const token = statement instanceof Statements.ClassDefinitionLoad
+                ? statementNode.getChildren()[3].getFirstToken()
+                : statementNode.getChildren()[2].getFirstToken();
             let startPosition = token.getStart();
             startPosition = new position_1.Position(startPosition.getRow(), startPosition.getCol() - 1);
             return edit_helper_1.EditHelper.deleteRange(file, startPosition, token.getEnd());

package/build/src/rules/parser_missing_space.js

@@ -36,7 +36,6 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.ParserMissingSpace = exports.ParserMissingSpaceConf = void 0;
 const Expressions = __importStar(require("../abap/2_statements/expressions"));
 const issue_1 = require("../issue");
-const position_1 = require("../position");
 const _abap_rule_1 = require("./_abap_rule");
 const nodes_1 = require("../abap/nodes");
 const _basic_rule_config_1 = require("./_basic_rule_config");
@@ -69,7 +68,7 @@ This rule makes sure the spaces are consistently required across the language.`,
     }
     runParsed(file) {
         const issues = [];
-        let start = new position_1.Position(0, 0);
+        let start;
         for (const statement of file.getStatements()) {
             const missing = this.missingSpace(statement);
             if (missing) {

package/build/src/rules/prefer_raise_exception_new.js

@@ -93,14 +93,8 @@ From 752 and up`,
     }
     getFix(file, statement, withExporting) {
         const children = statement.getChildren();
-        let contentFix = undefined;
-        if (withExporting) {
-            const fixText = "( " + children[5].concatTokens() + " ).";
-            contentFix = edit_helper_1.EditHelper.replaceRange(file, children[3].getLastToken().getEnd(), statement.getEnd(), fixText);
-        }
-        else {
-            contentFix = edit_helper_1.EditHelper.replaceRange(file, children[3].getLastToken().getEnd(), statement.getEnd(), "( ).");
-        }
+        const fixText = withExporting ? "( " + children[5].concatTokens() + " )." : "( ).";
+        const contentFix = edit_helper_1.EditHelper.replaceRange(file, children[3].getLastToken().getEnd(), statement.getEnd(), fixText);
         const replaceType = edit_helper_1.EditHelper.replaceToken(file, children[2].getFirstToken(), "NEW");
         return edit_helper_1.EditHelper.merge(contentFix, replaceType);
     }

package/build/src/rules/xml_consistency.js

@@ -67,6 +67,7 @@ class XMLConsistency {
 * Naming for CLAS and INTF objects
 * QUAN fields in TABL objects have reference table and field values
 * Transparent TABL objects have delivery class and size category set
+* TABL fields with a built-in type carry the INTTYPE abapGit serializes for it, for the confirmed pairs
 * Lock parameter names in ENQU objects are max 16 characters
 * Texts and translations do not exceed maximum allowed length.`,
             tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.Syntax],
@@ -333,6 +334,12 @@ class XMLConsistency {
                 const message = `QUAN field ${field.FIELDNAME} must have REFTABLE and REFFIELD set`;
                 issues.push(issue_1.Issue.atRow(file, 1, message, this.getMetadata().key, this.conf.severity));
             }
+            const expected = field.DATATYPE ? XMLConsistency.intTypes[field.DATATYPE] : undefined;
+            if (expected !== undefined && field.INTTYPE !== undefined && field.INTTYPE !== expected) {
+                const message = `Field ${field.FIELDNAME}: INTTYPE "${field.INTTYPE}" does not match DATATYPE ${field.DATATYPE}, ` +
+                    `abapGit serializes "${expected}"`;
+                issues.push(issue_1.Issue.atRow(file, 1, message, this.getMetadata().key, this.conf.severity));
+            }
         }
         if (obj.getTableCategory() === Objects.TableCategory.Transparent) {
             // Confirmed reserved database field names, see issue #4331, DAY and HOUR reported by activation.
@@ -356,4 +363,13 @@ class XMLConsistency {
     }
 }
 exports.XMLConsistency = XMLConsistency;
+// INTTYPE that abapGit serializes for a built-in DATATYPE, confirmed by exported tables;
+// a different value activates, but shows as a diff on every pull
+XMLConsistency.intTypes = {
+    "CHAR": "C", "CLNT": "C", "CUKY": "C", "LANG": "C",
+    "DATS": "D", "TIMS": "T",
+    "INT4": "X", "RAW": "X",
+    "DEC": "P", "CURR": "P",
+    "STRG": "g", "SSTR": "g", "RSTR": "y",
+};
 //# sourceMappingURL=xml_consistency.js.map

package/build/src/utils/form_length_stats.js

@@ -76,7 +76,7 @@ class FormLengthStats {
         return res;
     }
     static findName(stat) {
-        let name = "";
+        let name;
         const nameExpr = stat.findFirstExpression(expressions_1.FormName);
         if (nameExpr) {
             name = nameExpr.getFirstToken().getStr();

package/build/src/utils/method_length_stats.js

@@ -82,7 +82,7 @@ class MethodLengthStats {
         return res;
     }
     static findName(stat) {
-        let name = "";
+        let name;
         const nameExpr = stat.findFirstExpression(expressions_1.MethodName);
         if (nameExpr) {
             name = nameExpr.getFirstToken().getStr();

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.120.71",
+    "version": "2.120.73",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",