@abaplint/core 2.120.71 → 2.120.72

package/build/src/abap/5_syntax/statements/insert_database.js

@@ -38,20 +38,23 @@ const Expressions = __importStar(require("../../2_statements/expressions"));
 const source_1 = require("../expressions/source");
 const dynamic_1 = require("../expressions/dynamic");
 const database_table_1 = require("../expressions/database_table");
+const _check_database_work_area_1 = require("../expressions/_check_database_work_area");
 class InsertDatabase {
     runSyntax(node, input) {
+        const sourceTypes = new Map();
         for (const s of node.findAllExpressions(Expressions.Source)) {
-            source_1.Source.runSyntax(s, input);
+            sourceTypes.set(s, source_1.Source.runSyntax(s, input));
         }
         for (const s of node.findAllExpressions(Expressions.SimpleSource3)) {
-            source_1.Source.runSyntax(s, input);
+            sourceTypes.set(s, source_1.Source.runSyntax(s, input));
         }
         for (const d of node.findAllExpressions(Expressions.Dynamic)) {
             dynamic_1.Dynamic.runSyntax(d, input);
         }
         const dbtab = node.findFirstExpression(Expressions.DatabaseTable);
         if (dbtab !== undefined) {
-            database_table_1.DatabaseTable.runSyntax(dbtab, input);
+            const dbSource = database_table_1.DatabaseTable.runSyntax(dbtab, input);
+            (0, _check_database_work_area_1.checkDatabaseWorkArea)(node, dbSource, sourceTypes, input);
         }
     }
 }

package/build/src/abap/5_syntax/statements/loop.js

@@ -130,7 +130,7 @@ class Loop {
             && topType instanceof basic_1.TableType) {
             // https://github.com/abap2xlsx/abap2xlsx/issues/1341
             const keyName = node.findExpressionAfterToken("KEY");
-            let key = undefined;
+            let key;
             const name = (keyName === null || keyName === void 0 ? void 0 : keyName.get()) instanceof Expressions.SimpleName ? keyName.getFirstToken().getStr().toUpperCase() : undefined;
             // it might be dynamic, in that case we cannot check anything; and
             // primary_key is the predefined name of the primary key every table has

package/build/src/abap/5_syntax/statements/modify_database.js

@@ -39,11 +39,13 @@ const dynamic_1 = require("../expressions/dynamic");
 const database_table_1 = require("../expressions/database_table");
 const source_1 = require("../expressions/source");
 const _reference_1 = require("../_reference");
+const _check_database_work_area_1 = require("../expressions/_check_database_work_area");
 class ModifyDatabase {
     runSyntax(node, input) {
         for (const d of node.findAllExpressions(Expressions.Dynamic)) {
             dynamic_1.Dynamic.runSyntax(d, input);
         }
+        let dbSource = undefined;
         const dbtab = node.findFirstExpression(Expressions.DatabaseTable);
         if (dbtab !== undefined) {
             if (node.getChildren().length === 5) {
@@ -52,19 +54,21 @@ class ModifyDatabase {
                     input.scope.addReference(dbtab.getFirstToken(), found, _reference_1.ReferenceType.DataWriteReference, input.filename);
                 }
                 else {
-                    database_table_1.DatabaseTable.runSyntax(dbtab, input);
+                    dbSource = database_table_1.DatabaseTable.runSyntax(dbtab, input);
                 }
             }
             else {
-                database_table_1.DatabaseTable.runSyntax(dbtab, input);
+                dbSource = database_table_1.DatabaseTable.runSyntax(dbtab, input);
             }
         }
+        const sourceTypes = new Map();
         for (const s of node.findAllExpressions(Expressions.Source)) {
-            source_1.Source.runSyntax(s, input);
+            sourceTypes.set(s, source_1.Source.runSyntax(s, input));
         }
         for (const s of node.findAllExpressions(Expressions.SimpleSource3)) {
-            source_1.Source.runSyntax(s, input);
+            sourceTypes.set(s, source_1.Source.runSyntax(s, input));
         }
+        (0, _check_database_work_area_1.checkDatabaseWorkArea)(node, dbSource, sourceTypes, input);
     }
 }
 exports.ModifyDatabase = ModifyDatabase;

package/build/src/abap/5_syntax/statements/update_database.js

@@ -43,11 +43,13 @@ const identifier_1 = require("../../1_lexer/tokens/identifier");
 const database_table_1 = require("../expressions/database_table");
 const dynamic_1 = require("../expressions/dynamic");
 const _check_database_fields_1 = require("../expressions/_check_database_fields");
+const _check_database_work_area_1 = require("../expressions/_check_database_work_area");
 class UpdateDatabase {
     runSyntax(node, input) {
+        let dbSource = undefined;
         const dbtab = node.findFirstExpression(Expressions.DatabaseTable);
         if (dbtab !== undefined) {
-            const dbSource = database_table_1.DatabaseTable.runSyntax(dbtab, input);
+            dbSource = database_table_1.DatabaseTable.runSyntax(dbtab, input);
             const fields = node.findAllExpressions(Expressions.SQLFieldAndValue)
                 .flatMap(fieldAndValue => fieldAndValue.findDirectExpressions(Expressions.SQLFieldName))
                 .map(field => field.concatTokens().toUpperCase());
@@ -70,15 +72,17 @@ class UpdateDatabase {
                 }
             }
         }
+        const sourceTypes = new Map();
         for (const s of node.findAllExpressions(Expressions.Source)) {
-            source_1.Source.runSyntax(s, input);
+            sourceTypes.set(s, source_1.Source.runSyntax(s, input));
         }
         for (const s of node.findAllExpressions(Expressions.SimpleSource3)) {
-            source_1.Source.runSyntax(s, input);
+            sourceTypes.set(s, source_1.Source.runSyntax(s, input));
         }
         for (const d of node.findAllExpressions(Expressions.Dynamic)) {
             dynamic_1.Dynamic.runSyntax(d, input);
         }
+        (0, _check_database_work_area_1.checkDatabaseWorkArea)(node, dbSource, sourceTypes, input);
         if (input.scope.getType() === _scope_type_1.ScopeType.OpenSQL) {
             input.scope.pop(node.getLastToken().getEnd());
         }

package/build/src/abap/5_syntax/statements/when_type.js

@@ -47,7 +47,7 @@ class WhenType {
         if (nameToken === undefined) {
             return undefined;
         }
-        let type = undefined;
+        let type;
         const className = nameToken.getStr().toUpperCase();
         const found = input.scope.existsObject(className);
         if (found === null || found === void 0 ? void 0 : found.id) {

package/build/src/abap/types/class_attributes.js

@@ -318,7 +318,7 @@ class Attributes {
         return false;
     }
     parseAttribute(node, visibility, input) {
-        let found = undefined;
+        let found;
         const s = node.get();
         if (s instanceof Statements.Data) {
             found = new data_1.Data().runSyntax(node, input);

package/build/src/cds/cds_lexer.js

@@ -188,7 +188,7 @@ class CDSLexer {
                     break;
                 case "@":
                     // @ starts a new annotation; flush current token and start building with @
-                    build = result.add(build, row, col, mode);
+                    result.add(build, row, col, mode);
                     build = "@";
                     break;
                 default:

package/build/src/lsp/help.js

@@ -50,7 +50,7 @@ class Help {
         return content;
     }
     static dumpABAP(file, reg, textDocument, position) {
-        let content = "";
+        let content;
         content = `
     <a href="#_tokens" rel="no-refresh">Tokens</a> |
     <a href="#_statements" rel="no-refresh">Statements</a> |
@@ -83,7 +83,7 @@ class Help {
         return `<h3 id="_info">Info Dump</h3><pre>` + text + "</pre>";
     }
     static cursorInformation(reg, textDocument, position, file) {
-        let ret = "";
+        let ret;
         const found = _lsp_utils_1.LSPUtils.findCursor(reg, { textDocument, position });
         if (found !== undefined) {
             ret = "Statement: " + this.linkToStatement(found.snode.get()) + "<br>\n" +

package/build/src/objects/data_element.js

@@ -121,7 +121,7 @@ class DataElement extends _abstract_object_1.AbstractObject {
     }
     parseType(reg) {
         const references = [];
-        let lookup = undefined;
+        let lookup;
         this.parse();
         if (this.parsedXML === undefined) {
             lookup = { type: new Types.UnknownType("Data Element " + this.getName() + ", parser error") };

package/build/src/objects/table.js

@@ -392,6 +392,7 @@ class Table extends _abstract_object_1.AbstractObject {
                 PRECFIELD: field.PRECFIELD,
                 LENG: field.LENG,
                 INTLEN: field.INTLEN,
+                INTTYPE: field.INTTYPE,
                 DATATYPE: field.DATATYPE,
                 DECIMALS: field.DECIMALS,
                 KEYFLAG: field.KEYFLAG,

package/build/src/registry.js

@@ -75,7 +75,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.71";
+        return "2.120.72";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/align_pseudo_comments.js

@@ -54,7 +54,7 @@ class AlignPseudoComments extends _abap_rule_1.ABAPRule {
             }
             const col = firstCommentToken.getStart().getCol();
             if (previousEnd.getCol() < expectedColumn && col !== expectedColumn) {
-                let fix = undefined;
+                let fix;
                 if (col < expectedColumn) {
                     fix = edit_helper_1.EditHelper.insertAt(file, firstCommentToken.getStart(), " ".repeat(expectedColumn - col));
                 }

package/build/src/rules/align_type_expressions.js

@@ -138,7 +138,7 @@ ENDINTERFACE.`,
             if (f.after.getCol() === column) {
                 continue;
             }
-            let fix = undefined;
+            let fix;
             if (f.after.getCol() < column) {
                 fix = edit_helper_1.EditHelper.insertAt(file, f.after, " ".repeat(column - f.after.getCol()));
             }

package/build/src/rules/change_if_to_case.js

@@ -142,7 +142,7 @@ ENDCASE.`,
         if (tuples.length === 1) {
             return false;
         }
-        let chain = "";
+        let chain;
         if (tuples[0].left === tuples[1].left) {
             chain = tuples[0].left;
         }

package/build/src/rules/check_ddic.js

@@ -68,7 +68,7 @@ class CheckDDIC {
         this.conf = conf;
     }
     run(obj) {
-        let found = undefined;
+        let found;
         if (obj instanceof Objects.DataElement
             || obj instanceof Objects.Domain
             || obj instanceof Objects.Table

package/build/src/rules/class_attribute_names.js

@@ -59,7 +59,6 @@ ENDCLASS.`,
         this.conf = conf;
     }
     runParsed(file, obj) {
-        let issues = [];
         if (this.conf.patternKind === undefined) {
             this.conf.patternKind = "required";
         }
@@ -80,8 +79,7 @@ ENDCLASS.`,
                 attributes = attributes.concat(intfDef.attributes);
             }
         }
-        issues = this.checkAttributes(attributes);
-        return issues;
+        return this.checkAttributes(attributes);
     }
     checkAttributes(attr) {
         if (attr === undefined) {

package/build/src/rules/downport.js

@@ -531,7 +531,7 @@ Make sure to test the downported code, it might not always be completely correct
         if (found) {
             return found;
         }
-        found = this.outlineGetReferenceSimple(high, lowFile);
+        found = this.outlineGetReferenceSimple(high, lowFile, highSyntax);
         if (found) {
             return found;
         }
@@ -1206,7 +1206,17 @@ ${indentation}CATCH ${className} INTO ${targetName}.`;
         const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getStart(), node.getEnd(), code);
         return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Outline DATA", this.getMetadata().key, this.conf.severity, fix);
     }
-    outlineGetReferenceSimple(node, lowFile) {
+    /** the type of a reference to the source: LIKE REF TO it, or REF TO data when its type is generic,
+     *  as LIKE REF TO a generically typed field symbol or parameter does not activate */
+    refTypeOf(sourceName, node, lowFile, highSyntax) {
+        var _a;
+        const spag = highSyntax.spaghetti.lookupPosition(node.getFirstToken().getStart(), lowFile.getFilename());
+        if (((_a = spag === null || spag === void 0 ? void 0 : spag.findVariable(sourceName)) === null || _a === void 0 ? void 0 : _a.getType().isGeneric()) === true) {
+            return "TYPE REF TO data";
+        }
+        return "LIKE REF TO " + sourceName;
+    }
+    outlineGetReferenceSimple(node, lowFile, highSyntax) {
         var _a, _b, _c;
         if (!(node.get() instanceof Statements.GetReference)) {
             return undefined;
@@ -1223,7 +1233,8 @@ ${indentation}CATCH ${className} INTO ${targetName}.`;
         const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
         const firstToken = target.getFirstToken();
         const lastToken = target.getLastToken();
-        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getStart(), `DATA ${targetName} LIKE REF TO ${source.concatTokens()}.\n${indentation}`);
+        const refType = this.refTypeOf(source.concatTokens(), node, lowFile, highSyntax);
+        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getStart(), `DATA ${targetName} ${refType}.\n${indentation}`);
         const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, firstToken.getStart(), lastToken.getEnd(), targetName);
         const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
         return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Outline DATA", this.getMetadata().key, this.conf.severity, fix);
@@ -1240,7 +1251,7 @@ ${indentation}CATCH ${className} INTO ${targetName}.`;
         if (!(((_a = target === null || target === void 0 ? void 0 : target.getFirstChild()) === null || _a === void 0 ? void 0 : _a.get()) instanceof Expressions.InlineData)) {
             return undefined;
         }
-        let type = "";
+        let type;
         const source = node.findFirstExpression(Expressions.Source);
         if (source === undefined) {
             return undefined;
@@ -1330,8 +1341,8 @@ ${indentation}CATCH ${className} INTO ${targetName}.`;
         if (!(node.get() instanceof Statements.Raise)) {
             return undefined;
         }
-        let id = undefined;
-        let number = undefined;
+        let id;
+        let number;
         let startToken = node.findDirectTokenByText("ID");
         if (startToken) {
             const sources = node.findDirectExpressions(Expressions.Source);
@@ -1489,7 +1500,7 @@ ${indentation}${uniqueName2}->if_t100_message~t100key = ${uniqueName1}.\n`;
             || sourceRef.getChildren().length !== 1) {
             return undefined;
         }
-        let code = "";
+        let code;
         if (sourceRef.findFirstExpression(Expressions.TableExpression)) {
             const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
             code = `ASSIGN ${sourceRef.concatTokens()} TO FIELD-SYMBOL(<${uniqueName}>).
@@ -1681,7 +1692,7 @@ LOOP AT ${groupTargetName}tab ${groupTarget}.`;
             || !(tableExpression instanceof nodes_1.ExpressionNode)) {
             return undefined;
         }
-        let condition = "";
+        let condition;
         if (tableExpression.getChildren().length === 3) {
             const index = tableExpression.findDirectExpression(Expressions.Source);
             if (index === undefined) {
@@ -1865,7 +1876,7 @@ ${indentation}${uniqueName}`;
             return undefined;
         }
         const op = secondChild.getFirstToken();
-        let operator = "";
+        let operator;
         switch (op.getStr()) {
             case "+":
                 operator = " + ";
@@ -1907,7 +1918,7 @@ ${indentation}${uniqueName}`;
                 || (formatting === null || formatting === void 0 ? void 0 : formatting.startsWith("ALPHA = ")) === false) {
                 continue;
             }
-            let functionName = "";
+            let functionName;
             switch (formatting) {
                 case "ALPHA = IN":
                     functionName = "CONVERSION_EXIT_ALPHA_INPUT";
@@ -2203,13 +2214,12 @@ ${indentation}    output = ${uniqueName}.\n`;
             const uniqueName = this.uniqueName(firstToken.getStart(), lowFile.getFilename(), highSyntax);
             const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
             let body = "";
-            let name = "";
             const switchBody = i.findDirectExpression(Expressions.SwitchBody);
             if (switchBody === undefined) {
                 continue;
             }
             for (const l of ((_c = switchBody === null || switchBody === void 0 ? void 0 : switchBody.findDirectExpression(Expressions.Let)) === null || _c === void 0 ? void 0 : _c.findDirectExpressions(Expressions.InlineFieldDefinition)) || []) {
-                name = l.getFirstToken().getStr();
+                const name = l.getFirstToken().getStr();
                 body += indentation + `DATA(${name}) = ${(_d = switchBody.findFirstExpression(Expressions.Source)) === null || _d === void 0 ? void 0 : _d.concatTokens()}.\n`;
             }
             body += `DATA ${uniqueName} ${type}.\n`;
@@ -2267,7 +2277,6 @@ ${indentation}    output = ${uniqueName}.\n`;
             const uniqueName = this.uniqueName(firstToken.getStart(), lowFile.getFilename(), highSyntax);
             const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
             let body = "";
-            let name = "";
             const reduceBody = i.findDirectExpression(Expressions.ReduceBody);
             if (reduceBody === undefined) {
                 continue;
@@ -2278,7 +2287,7 @@ ${indentation}    output = ${uniqueName}.\n`;
             }
             let firstName = "";
             for (const init of reduceBody.findDirectExpressions(Expressions.InlineFieldDefinition)) {
-                name = init.getFirstToken().getStr();
+                const name = init.getFirstToken().getStr();
                 if (firstName === "") {
                     firstName = name;
                 }
@@ -2510,7 +2519,7 @@ ${indentation}    output = ${uniqueName}.\n`;
                         after += c.concatTokens();
                     }
                 }
-                let condition = "";
+                let condition;
                 if ((tableExpression === null || tableExpression === void 0 ? void 0 : tableExpression.getChildren().length) === 3) {
                     condition = "INDEX " + ((_d = tableExpression === null || tableExpression === void 0 ? void 0 : tableExpression.findDirectExpression(Expressions.Source)) === null || _d === void 0 ? void 0 : _d.concatTokens());
                 }
@@ -2661,7 +2670,7 @@ ${indentation}    output = ${uniqueName}.\n`;
                 continue;
             }
             const name = nameToken.getStr();
-            let type = "";
+            let type;
             if (high.concatTokens().toUpperCase().startsWith("APPEND INITIAL LINE TO ")) {
                 type = "LIKE LINE OF " + ((_b = high.findFirstExpression(Expressions.Target)) === null || _b === void 0 ? void 0 : _b.concatTokens());
             }
@@ -3027,7 +3036,7 @@ ${indentation}    output = ${uniqueName}.\n`;
         }
         return undefined;
     }
-    getReference(node, lowFile, _highSyntax) {
+    getReference(node, lowFile, highSyntax) {
         var _a, _b, _c;
         if (!(node.get() instanceof Statements.GetReference)) {
             return undefined;
@@ -3041,7 +3050,7 @@ ${indentation}    output = ${uniqueName}.\n`;
         if (targetName === undefined || sourceName === undefined) {
             return undefined;
         }
-        const code = `DATA ${targetName} LIKE REF TO ${sourceName}.\n`;
+        const code = `DATA ${targetName} ${this.refTypeOf(sourceName, node, lowFile, highSyntax)}.\n`;
         const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getFirstToken().getStart(), code);
         const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, inline.getFirstToken().getStart(), inline.getLastToken().getEnd(), targetName);
         const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -3118,18 +3127,30 @@ ${indentation}    output = ${uniqueName}.\n`;
                 const uniqueName = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
                 const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
                 const sy = func === "LINE_EXISTS" ? "sy-subrc" : "sy-tabix";
-                const code = `DATA ${uniqueName} LIKE sy-subrc.\n` +
-                    indentation + `READ TABLE ${tableName} ${condition}TRANSPORTING NO FIELDS.\n` +
-                    indentation + uniqueName + ` = ${sy}.\n` +
-                    indentation;
                 let insertAt = node.getFirstToken().getStart();
                 if (node.get() instanceof statements_1.ElseIf) {
-                    // assumption: no side effects in IF conditions
+                    // assumption: no side effects in IF conditions, except the READ itself, see below
                     insertAt = this.findStartOfIf(node, highFile);
                     if (insertAt === undefined) {
                         continue;
                     }
                 }
+                // the READ sets sy-subrc and sy-tabix, which the built-in function does not,
+                // keep the values for the code that reads them after the inserted READ
+                const keep = [];
+                const reads = this.readSyFields(insertAt, highFile);
+                for (const field of ["sy-subrc", "sy-tabix"]) {
+                    if (reads.has(field)) {
+                        keep.push({ field, name: this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax) });
+                    }
+                }
+                const code = `DATA ${uniqueName} LIKE sy-subrc.\n` +
+                    keep.map(k => indentation + `DATA ${k.name} LIKE ${k.field}.\n`).join("") +
+                    keep.map(k => indentation + `${k.name} = ${k.field}.\n`).join("") +
+                    indentation + `READ TABLE ${tableName} ${condition}TRANSPORTING NO FIELDS.\n` +
+                    indentation + uniqueName + ` = ${sy}.\n` +
+                    keep.map(k => indentation + `${k.field} = ${k.name}.\n`).join("") +
+                    indentation;
                 const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, insertAt, code);
                 const start = expression.getFirstToken().getStart();
                 const end = expression.getLastToken().getEnd();
@@ -3140,6 +3161,46 @@ ${indentation}    output = ${uniqueName}.\n`;
         }
         return undefined;
     }
+    /** sy-subrc and sy-tabix, when read from the position on, in the procedure around it or the file outside of one;
+     *  inside a loop from the start of the outermost loop, as the next pass reads what this one left */
+    readSyFields(position, highFile) {
+        const structure = highFile.getStructure();
+        const contains = (s) => !position.isBefore(s.getFirstToken().getStart())
+            && !position.isAfter(s.getLastToken().getStart());
+        let scope = undefined;
+        for (const s of [Structures.Method, Structures.Form, Structures.FunctionModule]) {
+            for (const p of (structure === null || structure === void 0 ? void 0 : structure.findAllStructuresRecursive(s)) || []) {
+                if (contains(p)) {
+                    scope = p;
+                }
+            }
+        }
+        scope = scope || structure;
+        let from = position;
+        for (const s of [Structures.Loop, Structures.Do, Structures.While, Structures.Select]) {
+            for (const l of (scope === null || scope === void 0 ? void 0 : scope.findAllStructuresRecursive(s)) || []) {
+                if (contains(l) && l.getFirstToken().getStart().isBefore(from)) {
+                    from = l.getFirstToken().getStart();
+                }
+            }
+        }
+        const ret = new Set();
+        for (const s of (scope === null || scope === void 0 ? void 0 : scope.findAllStatementNodes()) || []) {
+            if (s.getLastToken().getStart().isBefore(from)) {
+                continue;
+            }
+            const tokens = s.getTokens();
+            for (let i = 0; i < tokens.length - 2; i++) {
+                if (tokens[i].getStr().toUpperCase() === "SY" && tokens[i + 1].getStr() === "-") {
+                    const field = "sy-" + tokens[i + 2].getStr().toLowerCase();
+                    if (field === "sy-subrc" || field === "sy-tabix") {
+                        ret.add(field);
+                    }
+                }
+            }
+        }
+        return ret;
+    }
     findStartOfIf(node, highFile) {
         const structure = highFile.getStructure();
         for (const c of (structure === null || structure === void 0 ? void 0 : structure.findAllStructuresRecursive(Structures.If)) || []) {
@@ -3152,6 +3213,7 @@ ${indentation}    output = ${uniqueName}.\n`;
         return undefined;
     }
     newToCreateObject(low, high, lowFile, highSyntax) {
+        var _a;
         if (!(low.get() instanceof _statement_1.Unknown)) {
             return undefined;
         }
@@ -3167,7 +3229,7 @@ ${indentation}    output = ${uniqueName}.\n`;
                 && found
                 && source.concatTokens() === found.concatTokens()
                 && target.findDirectExpression(Expressions.InlineData) === undefined) {
-                const abap = this.newParameters(found, target.concatTokens(), highSyntax, lowFile);
+                const abap = (_a = this.newDataReference(high, target, found, lowFile, highSyntax)) !== null && _a !== void 0 ? _a : this.newParameters(found, target.concatTokens(), highSyntax, lowFile);
                 if (abap !== undefined) {
                     fix = edit_helper_1.EditHelper.replaceRange(lowFile, high.getFirstToken().getStart(), high.getLastToken().getEnd(), abap);
                 }
@@ -3206,6 +3268,42 @@ ${indentation}    output = ${uniqueName}.\n`;
             return undefined;
         }
     }
+    /** NEW into a data reference creates data, CREATE OBJECT cannot: "target = NEW #|type( [value] )"
+     *  with a variable typed REF TO a data type becomes CREATE DATA plus the assignment of the value */
+    newDataReference(high, target, found, lowFile, highSyntax) {
+        var _a, _b, _c;
+        if (target.getChildren().length !== 1 || !(((_a = target.getFirstChild()) === null || _a === void 0 ? void 0 : _a.get()) instanceof Expressions.TargetField)) {
+            return undefined;
+        }
+        const children = found.getChildren();
+        const value = found.findDirectExpression(Expressions.Source);
+        // NEW, the type, "(", optionally one value, ")"
+        if (children.length !== 4 + (value ? 1 : 0)) {
+            return undefined;
+        }
+        const name = target.concatTokens();
+        const spag = highSyntax.spaghetti.lookupPosition(high.getFirstToken().getStart(), lowFile.getFilename());
+        const type = (_b = spag === null || spag === void 0 ? void 0 : spag.findVariable(name)) === null || _b === void 0 ? void 0 : _b.getType();
+        if (!(type instanceof basic_1.DataReference)) {
+            return undefined;
+        }
+        const typeName = (_c = found.findDirectExpression(Expressions.TypeNameOrInfer)) === null || _c === void 0 ? void 0 : _c.concatTokens();
+        const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
+        let abap = `CREATE DATA ${name}` + (typeName === "#" ? "" : ` TYPE ${typeName}`) + ".";
+        if (value === undefined) {
+            return abap;
+        }
+        else if (type.getType().isGeneric() === false) {
+            return abap + `\n${indentation}${name}->* = ${value.concatTokens()}.`;
+        }
+        // a generic reference cannot be dereferenced as a target below v756
+        const fs = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax, true);
+        abap = `FIELD-SYMBOLS ${fs} TYPE any.\n` +
+            indentation + abap + "\n" +
+            indentation + `ASSIGN ${name}->* TO ${fs}.\n` +
+            indentation + `${fs} = ${value.concatTokens()}.`;
+        return abap;
+    }
     newParameters(found, name, highSyntax, lowFile) {
         var _a, _b, _c;
         const typeToken = (_a = found.findDirectExpression(Expressions.TypeNameOrInfer)) === null || _a === void 0 ? void 0 : _a.getFirstToken();

package/build/src/rules/empty_structure.js

@@ -63,6 +63,8 @@ class EmptyStructureConf extends _basic_rule_config_1.BasicRuleConfig {
         this.try = true;
         /** Checks for empty WHEN blocks */
         this.when = true;
+        /** Checks for empty CATCH blocks, unless the CATCH has pragma ##NO_HANDLER or pseudo comment "#EC NO_HANDLER */
+        this.catch = false;
         // todo, other category containing ELSE
     }
 }
@@ -175,6 +177,21 @@ result = xsdbool( sy-subrc = 0 ).`,
                 }
             }
         }
+        if (this.getConfig().catch === true) {
+            for (const c of stru.findAllStructuresRecursive(Structures.Catch)) {
+                // a comment in the block does not count, the extended check (SLIN) reports it too
+                if (c.findDirectStructure(Structures.Body) !== undefined) {
+                    continue;
+                }
+                const catchStatement = c.getFirstStatement();
+                if (catchStatement === undefined || this.isNoHandler(catchStatement, statements)) {
+                    continue;
+                }
+                const token = c.getFirstToken();
+                const issue = issue_1.Issue.atToken(file, token, this.getDescription(c.get().constructor.name), this.getMetadata().key, this.conf.severity);
+                issues.push(issue);
+            }
+        }
         if (this.getConfig().when === true) {
             const tries = stru.findAllStructuresRecursive(Structures.When);
             for (const t of tries) {
@@ -188,6 +205,15 @@ result = xsdbool( sy-subrc = 0 ).`,
         }
         return issues;
     }
+    isNoHandler(catchStatement, statements) {
+        if (catchStatement.getPragmas().some(p => p.getStr().toUpperCase() === "##NO_HANDLER")) {
+            return true;
+        }
+        const next = statements[statements.indexOf(catchStatement) + 1];
+        return (next === null || next === void 0 ? void 0 : next.get()) instanceof _statement_1.Comment
+            && next.getStart().getRow() === catchStatement.getEnd().getRow()
+            && next.concatTokens().toUpperCase().replace(/\s/g, "").includes("\"#ECNO_HANDLER");
+    }
 }
 exports.EmptyStructure = EmptyStructure;
 //# sourceMappingURL=empty_structure.js.map

package/build/src/rules/functional_writing.js

@@ -138,7 +138,7 @@ cl_abap_typedescr=>describe_by_name(
         const methodSource = statNode.findDirectExpression(Expressions.MethodSource);
         let methodSourceStr = methodSource === null || methodSource === void 0 ? void 0 : methodSource.concatTokens();
         const methodBody = statNode.findDirectExpression(Expressions.MethodCallBody);
-        let methodBodyStr = "";
+        let methodBodyStr;
         if (methodBody) {
             const methodCallParam = methodBody.findDirectExpression(Expressions.MethodCallParam);
             if (methodCallParam && methodCallParam.getFirstToken().getStr() === "(") {

package/build/src/rules/keyword_case.js

@@ -215,7 +215,7 @@ class KeywordCase extends _abap_rule_1.ABAPRule {
         const firstToken = tokens[0].token;
         const lastToken = tokens[tokens.length - 1].token;
         const firstTokenValue = firstToken.getStr();
-        let description = "";
+        let description;
         if (first.keyword === true) {
             description = `Keyword should be ${this.conf.style} case: "${firstTokenValue}"`;
         }

package/build/src/rules/local_class_naming.js

@@ -58,7 +58,7 @@ ENDCLASS.`,
                 continue;
             }
             const className = classDef.name;
-            let expected = "";
+            let expected;
             if (classDef.isForTesting) {
                 expected = this.conf.test;
             }

package/build/src/rules/many_parentheses.js

@@ -86,7 +86,7 @@ ENDIF.
             issues.push(...this.analyzeCondition(file, cond));
         }
         for (const sub of structure.findAllExpressionsMulti([Expressions.CondSub, Expressions.ComponentCondSub])) {
-            let cond = [];
+            let cond;
             if (sub.get() instanceof Expressions.CondSub) {
                 cond = sub.findDirectExpressions(Expressions.Cond);
             }