@abaplint/core 2.120.70 → 2.120.72

package/build/src/abap/5_syntax/expressions/source.js

@@ -61,6 +61,7 @@ const _typed_identifier_1 = require("../../types/_typed_identifier");
 const _type_utils_1 = require("../_type_utils");
 const _syntax_input_1 = require("../_syntax_input");
 const assert_error_1 = require("../assert_error");
+const version_1 = require("../../../version");
 /*
 * Type interference, valid scenarios:
 * typed = VALUE #( ... ).         right hand side must follow left hand type
@@ -73,7 +74,7 @@ const assert_error_1 = require("../assert_error");
 // TODO: refactor all these method parameters to objects, this is getting messy
 class Source {
     static runSyntax(node, input, targetType, writeReference = false, allowGenericDeference = false, readReference = true) {
-        var _a;
+        var _a, _b, _c, _d;
         if (node === undefined) {
             return undefined;
         }
@@ -151,7 +152,7 @@ class Source {
                 case "CONV":
                     {
                         const foundType = this.determineType(node, input, targetType);
-                        const bodyType = conv_body_1.ConvBody.runSyntax(node.findDirectExpression(Expressions.ConvBody), input);
+                        const bodyType = conv_body_1.ConvBody.runSyntax(node.findDirectExpression(Expressions.ConvBody), input, foundType);
                         const inferred = (_a = node.findDirectExpression(Expressions.TypeNameOrInfer)) === null || _a === void 0 ? void 0 : _a.concatTokens();
                         if (new _type_utils_1.TypeUtils(input.scope).isConvable(foundType, bodyType) === false) {
                             const message = `CONV: Types not compatible, ${foundType === null || foundType === void 0 ? void 0 : foundType.constructor.name}, ${bodyType === null || bodyType === void 0 ? void 0 : bodyType.constructor.name}`;
@@ -168,7 +169,13 @@ class Source {
                             this.traverseRemainingChildren(children, input);
                             return bodyType;
                         }
-                        this.addIfInferred(node, input, foundType);
+                        const bodySource = (_b = node.findDirectExpression(Expressions.ConvBody)) === null || _b === void 0 ? void 0 : _b.findDirectExpression(Expressions.Source);
+                        const nestedType = (_c = bodySource === null || bodySource === void 0 ? void 0 : bodySource.findDirectExpression(Expressions.TypeNameOrInfer)) === null || _c === void 0 ? void 0 : _c.concatTokens();
+                        // CONV # passes its target type into a nested inferred constructor, so
+                        // showing both inferred types would produce duplicate inlay hints.
+                        if (!(inferred === "#" && nestedType === "#")) {
+                            this.addIfInferred(node, input, foundType);
+                        }
                         this.traverseRemainingChildren(children, input);
                         return foundType;
                     }
@@ -225,6 +232,15 @@ class Source {
                 case "CORRESPONDING":
                     {
                         const foundType = this.determineType(node, input, targetType);
+                        if ((foundType === null || foundType === void 0 ? void 0 : foundType.isGeneric()) === true
+                            && ((_d = node.findDirectExpression(Expressions.TypeNameOrInfer)) === null || _d === void 0 ? void 0 : _d.concatTokens()) === "#"
+                            && !(0, version_1.releaseAtLeast)(input.scope.getRelease(), version_1.Release.v756)
+                            && input.scope.getLanguageVersion() !== version_1.LanguageVersion.Cloud
+                            && !input.scope.getOpenABAP()) {
+                            const message = "CORRESPONDING #, the type of the target is generic";
+                            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                            return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                        }
                         corresponding_body_1.CorrespondingBody.runSyntax(node.findDirectExpression(Expressions.CorrespondingBody), input, foundType);
                         this.addIfInferred(node, input, foundType);
                         return foundType;

package/build/src/abap/5_syntax/statements/assign.js

@@ -41,6 +41,7 @@ const basic_1 = require("../../types/basic");
 const dynamic_1 = require("../expressions/dynamic");
 const _type_utils_1 = require("../_type_utils");
 const _syntax_input_1 = require("../_syntax_input");
+const version_1 = require("../../../version");
 class Assign {
     runSyntax(node, input) {
         var _a;
@@ -48,7 +49,7 @@ class Assign {
         const isComponent = ((_a = assignSource === null || assignSource === void 0 ? void 0 : assignSource.getFirstChild()) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase()) === "COMPONENT";
         const sources = (assignSource === null || assignSource === void 0 ? void 0 : assignSource.findDirectExpressionsMulti([Expressions.Source, Expressions.SimpleSource3])) || [];
         const theSource = sources[sources.length - 1];
-        let sourceType = undefined;
+        let sourceType;
         const firstAssign = assignSource === null || assignSource === void 0 ? void 0 : assignSource.getChildren()[0];
         const secondAssign = assignSource === null || assignSource === void 0 ? void 0 : assignSource.getChildren()[1];
         const thirdAssign = assignSource === null || assignSource === void 0 ? void 0 : assignSource.getChildren()[2];
@@ -64,6 +65,19 @@ class Assign {
         }
         else {
             sourceType = source_1.Source.runSyntax(theSource, input, undefined, false, isComponent === false);
+            if ((secondAssign === null || secondAssign === void 0 ? void 0 : secondAssign.concatTokens()) === "->"
+                && (thirdAssign === null || thirdAssign === void 0 ? void 0 : thirdAssign.get()) instanceof Expressions.Dynamic
+                && (sourceType === null || sourceType === void 0 ? void 0 : sourceType.isGeneric()) === true
+                && !(sourceType instanceof basic_1.DataReference)
+                && !(sourceType instanceof basic_1.ObjectReferenceType)
+                && !(sourceType instanceof basic_1.GenericObjectReferenceType)
+                && !(0, version_1.releaseAtLeast)(input.scope.getRelease(), version_1.Release.v756)
+                && input.scope.getLanguageVersion() !== version_1.LanguageVersion.Cloud
+                && !input.scope.getOpenABAP()) {
+                const message = `"${theSource.concatTokens()}" is not a reference variable`;
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                return;
+            }
         }
         if ((assignSource === null || assignSource === void 0 ? void 0 : assignSource.getChildren().length) === 5
             && isComponent) {

package/build/src/abap/5_syntax/statements/insert_database.js

@@ -38,20 +38,23 @@ const Expressions = __importStar(require("../../2_statements/expressions"));
 const source_1 = require("../expressions/source");
 const dynamic_1 = require("../expressions/dynamic");
 const database_table_1 = require("../expressions/database_table");
+const _check_database_work_area_1 = require("../expressions/_check_database_work_area");
 class InsertDatabase {
     runSyntax(node, input) {
+        const sourceTypes = new Map();
         for (const s of node.findAllExpressions(Expressions.Source)) {
-            source_1.Source.runSyntax(s, input);
+            sourceTypes.set(s, source_1.Source.runSyntax(s, input));
         }
         for (const s of node.findAllExpressions(Expressions.SimpleSource3)) {
-            source_1.Source.runSyntax(s, input);
+            sourceTypes.set(s, source_1.Source.runSyntax(s, input));
         }
         for (const d of node.findAllExpressions(Expressions.Dynamic)) {
             dynamic_1.Dynamic.runSyntax(d, input);
         }
         const dbtab = node.findFirstExpression(Expressions.DatabaseTable);
         if (dbtab !== undefined) {
-            database_table_1.DatabaseTable.runSyntax(dbtab, input);
+            const dbSource = database_table_1.DatabaseTable.runSyntax(dbtab, input);
+            (0, _check_database_work_area_1.checkDatabaseWorkArea)(node, dbSource, sourceTypes, input);
         }
     }
 }

package/build/src/abap/5_syntax/statements/loop.js

@@ -130,7 +130,7 @@ class Loop {
             && topType instanceof basic_1.TableType) {
             // https://github.com/abap2xlsx/abap2xlsx/issues/1341
             const keyName = node.findExpressionAfterToken("KEY");
-            let key = undefined;
+            let key;
             const name = (keyName === null || keyName === void 0 ? void 0 : keyName.get()) instanceof Expressions.SimpleName ? keyName.getFirstToken().getStr().toUpperCase() : undefined;
             // it might be dynamic, in that case we cannot check anything; and
             // primary_key is the predefined name of the primary key every table has

package/build/src/abap/5_syntax/statements/modify_database.js

@@ -39,11 +39,13 @@ const dynamic_1 = require("../expressions/dynamic");
 const database_table_1 = require("../expressions/database_table");
 const source_1 = require("../expressions/source");
 const _reference_1 = require("../_reference");
+const _check_database_work_area_1 = require("../expressions/_check_database_work_area");
 class ModifyDatabase {
     runSyntax(node, input) {
         for (const d of node.findAllExpressions(Expressions.Dynamic)) {
             dynamic_1.Dynamic.runSyntax(d, input);
         }
+        let dbSource = undefined;
         const dbtab = node.findFirstExpression(Expressions.DatabaseTable);
         if (dbtab !== undefined) {
             if (node.getChildren().length === 5) {
@@ -52,19 +54,21 @@ class ModifyDatabase {
                     input.scope.addReference(dbtab.getFirstToken(), found, _reference_1.ReferenceType.DataWriteReference, input.filename);
                 }
                 else {
-                    database_table_1.DatabaseTable.runSyntax(dbtab, input);
+                    dbSource = database_table_1.DatabaseTable.runSyntax(dbtab, input);
                 }
             }
             else {
-                database_table_1.DatabaseTable.runSyntax(dbtab, input);
+                dbSource = database_table_1.DatabaseTable.runSyntax(dbtab, input);
             }
         }
+        const sourceTypes = new Map();
         for (const s of node.findAllExpressions(Expressions.Source)) {
-            source_1.Source.runSyntax(s, input);
+            sourceTypes.set(s, source_1.Source.runSyntax(s, input));
         }
         for (const s of node.findAllExpressions(Expressions.SimpleSource3)) {
-            source_1.Source.runSyntax(s, input);
+            sourceTypes.set(s, source_1.Source.runSyntax(s, input));
         }
+        (0, _check_database_work_area_1.checkDatabaseWorkArea)(node, dbSource, sourceTypes, input);
     }
 }
 exports.ModifyDatabase = ModifyDatabase;

package/build/src/abap/5_syntax/statements/update_database.js

@@ -43,11 +43,13 @@ const identifier_1 = require("../../1_lexer/tokens/identifier");
 const database_table_1 = require("../expressions/database_table");
 const dynamic_1 = require("../expressions/dynamic");
 const _check_database_fields_1 = require("../expressions/_check_database_fields");
+const _check_database_work_area_1 = require("../expressions/_check_database_work_area");
 class UpdateDatabase {
     runSyntax(node, input) {
+        let dbSource = undefined;
         const dbtab = node.findFirstExpression(Expressions.DatabaseTable);
         if (dbtab !== undefined) {
-            const dbSource = database_table_1.DatabaseTable.runSyntax(dbtab, input);
+            dbSource = database_table_1.DatabaseTable.runSyntax(dbtab, input);
             const fields = node.findAllExpressions(Expressions.SQLFieldAndValue)
                 .flatMap(fieldAndValue => fieldAndValue.findDirectExpressions(Expressions.SQLFieldName))
                 .map(field => field.concatTokens().toUpperCase());
@@ -70,15 +72,17 @@ class UpdateDatabase {
                 }
             }
         }
+        const sourceTypes = new Map();
         for (const s of node.findAllExpressions(Expressions.Source)) {
-            source_1.Source.runSyntax(s, input);
+            sourceTypes.set(s, source_1.Source.runSyntax(s, input));
         }
         for (const s of node.findAllExpressions(Expressions.SimpleSource3)) {
-            source_1.Source.runSyntax(s, input);
+            sourceTypes.set(s, source_1.Source.runSyntax(s, input));
         }
         for (const d of node.findAllExpressions(Expressions.Dynamic)) {
             dynamic_1.Dynamic.runSyntax(d, input);
         }
+        (0, _check_database_work_area_1.checkDatabaseWorkArea)(node, dbSource, sourceTypes, input);
         if (input.scope.getType() === _scope_type_1.ScopeType.OpenSQL) {
             input.scope.pop(node.getLastToken().getEnd());
         }

package/build/src/abap/5_syntax/statements/when_type.js

@@ -47,7 +47,7 @@ class WhenType {
         if (nameToken === undefined) {
             return undefined;
         }
-        let type = undefined;
+        let type;
         const className = nameToken.getStr().toUpperCase();
         const found = input.scope.existsObject(className);
         if (found === null || found === void 0 ? void 0 : found.id) {

package/build/src/abap/types/class_attributes.js

@@ -318,7 +318,7 @@ class Attributes {
         return false;
     }
     parseAttribute(node, visibility, input) {
-        let found = undefined;
+        let found;
         const s = node.get();
         if (s instanceof Statements.Data) {
             found = new data_1.Data().runSyntax(node, input);

package/build/src/cds/cds_lexer.js

@@ -188,7 +188,7 @@ class CDSLexer {
                     break;
                 case "@":
                     // @ starts a new annotation; flush current token and start building with @
-                    build = result.add(build, row, col, mode);
+                    result.add(build, row, col, mode);
                     build = "@";
                     break;
                 default:

package/build/src/lsp/help.js

@@ -50,7 +50,7 @@ class Help {
         return content;
     }
     static dumpABAP(file, reg, textDocument, position) {
-        let content = "";
+        let content;
         content = `
     <a href="#_tokens" rel="no-refresh">Tokens</a> |
     <a href="#_statements" rel="no-refresh">Statements</a> |
@@ -83,7 +83,7 @@ class Help {
         return `<h3 id="_info">Info Dump</h3><pre>` + text + "</pre>";
     }
     static cursorInformation(reg, textDocument, position, file) {
-        let ret = "";
+        let ret;
         const found = _lsp_utils_1.LSPUtils.findCursor(reg, { textDocument, position });
         if (found !== undefined) {
             ret = "Statement: " + this.linkToStatement(found.snode.get()) + "<br>\n" +

package/build/src/objects/data_element.js

@@ -121,7 +121,7 @@ class DataElement extends _abstract_object_1.AbstractObject {
     }
     parseType(reg) {
         const references = [];
-        let lookup = undefined;
+        let lookup;
         this.parse();
         if (this.parsedXML === undefined) {
             lookup = { type: new Types.UnknownType("Data Element " + this.getName() + ", parser error") };

package/build/src/objects/table.js

@@ -392,6 +392,7 @@ class Table extends _abstract_object_1.AbstractObject {
                 PRECFIELD: field.PRECFIELD,
                 LENG: field.LENG,
                 INTLEN: field.INTLEN,
+                INTTYPE: field.INTTYPE,
                 DATATYPE: field.DATATYPE,
                 DECIMALS: field.DECIMALS,
                 KEYFLAG: field.KEYFLAG,

package/build/src/registry.js

@@ -75,7 +75,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.70";
+        return "2.120.72";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/align_pseudo_comments.js

@@ -54,7 +54,7 @@ class AlignPseudoComments extends _abap_rule_1.ABAPRule {
             }
             const col = firstCommentToken.getStart().getCol();
             if (previousEnd.getCol() < expectedColumn && col !== expectedColumn) {
-                let fix = undefined;
+                let fix;
                 if (col < expectedColumn) {
                     fix = edit_helper_1.EditHelper.insertAt(file, firstCommentToken.getStart(), " ".repeat(expectedColumn - col));
                 }

package/build/src/rules/align_type_expressions.js

@@ -138,7 +138,7 @@ ENDINTERFACE.`,
             if (f.after.getCol() === column) {
                 continue;
             }
-            let fix = undefined;
+            let fix;
             if (f.after.getCol() < column) {
                 fix = edit_helper_1.EditHelper.insertAt(file, f.after, " ".repeat(column - f.after.getCol()));
             }

package/build/src/rules/cds_check_syntax.js

@@ -15,7 +15,7 @@ exports.CDSCheckSyntaxConf = CDSCheckSyntaxConf;
 const KNOWN_QUAN_DATA_ELEMENTS = ["MENGE_D"];
 const KNOWN_CURR_DATA_ELEMENTS = ["BWERT", "DZWERT"];
 // Reserved names, cannot be used as element names, see DDIC table TRESE
-const RESERVED_ELEMENT_NAMES = ["BEGIN", "NUMBER", "POSITION"];
+const RESERVED_ELEMENT_NAMES = ["BEGIN", "NUMBER", "POSITION", "ZONE", "HANDLER", "SECTION"];
 const MAX_LABEL_LENGTH = 40;
 // Annotations which are not supported in CDS view entities
 const VIEW_ENTITY_FORBIDDEN_ANNOTATIONS = ["Semantics.unitOfMeasure", "Semantics.currencyCode"];

package/build/src/rules/change_if_to_case.js

@@ -142,7 +142,7 @@ ENDCASE.`,
         if (tuples.length === 1) {
             return false;
         }
-        let chain = "";
+        let chain;
         if (tuples[0].left === tuples[1].left) {
             chain = tuples[0].left;
         }

package/build/src/rules/check_ddic.js

@@ -68,7 +68,7 @@ class CheckDDIC {
         this.conf = conf;
     }
     run(obj) {
-        let found = undefined;
+        let found;
         if (obj instanceof Objects.DataElement
             || obj instanceof Objects.Domain
             || obj instanceof Objects.Table

package/build/src/rules/class_attribute_names.js

@@ -59,7 +59,6 @@ ENDCLASS.`,
         this.conf = conf;
     }
     runParsed(file, obj) {
-        let issues = [];
         if (this.conf.patternKind === undefined) {
             this.conf.patternKind = "required";
         }
@@ -80,8 +79,7 @@ ENDCLASS.`,
                 attributes = attributes.concat(intfDef.attributes);
             }
         }
-        issues = this.checkAttributes(attributes);
-        return issues;
+        return this.checkAttributes(attributes);
     }
     checkAttributes(attr) {
         if (attr === undefined) {