@abaplint/core 2.120.68 → 2.120.69

package/build/abaplint.d.ts

@@ -513,6 +513,7 @@ declare namespace BasicTypes {
         HexType,
         IntegerType,
         Integer8Type,
+        NGenericType,
         NumericGenericType,
         NumericType,
         ObjectReferenceType,
@@ -5133,6 +5134,14 @@ declare class NewPage implements IStatement {
     getMatcher(): IStatementRunnable;
 }
 
+declare class NGenericType extends NumericType {
+    private static readonly singleton;
+    static get(): NGenericType;
+    private constructor();
+    toText(): string;
+    isGeneric(): boolean;
+}
+
 declare namespace Nodes {
     export {
         ExpressionNode,

package/build/src/abap/5_syntax/expressions/form_param.js

@@ -52,6 +52,9 @@ class FormParam {
             else if (typeName === "P" && bfound instanceof basic_1.PackedType) {
                 bfound = basic_1.PGenericType.get();
             }
+            else if (typeName === "N" && bfound instanceof basic_1.NumericType) {
+                bfound = basic_1.NGenericType.get();
+            }
         }
         if (nameToken && bfound) {
             return new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, bfound, ["form_parameter" /* IdentifierMeta.FormParameter */]);

package/build/src/abap/5_syntax/expressions/method_param.js

@@ -70,6 +70,9 @@ class MethodParam {
         else if (concat === "TYPE P" || concat.startsWith("TYPE P ")) {
             return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), input.filename, basic_1.PGenericType.get(), meta);
         }
+        else if (concat === "TYPE N" || concat.startsWith("TYPE N ")) {
+            return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), input.filename, basic_1.NGenericType.get(), meta);
+        }
         const found = new basic_types_1.BasicTypes(input).parseType(type);
         if (found) {
             return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), input.filename, found, meta);

package/build/src/abap/5_syntax/statements/create_object.js

@@ -203,9 +203,9 @@ class CreateObject {
             if (name === undefined) {
                 continue;
             }
-            const source = p.findDirectExpression(Expressions.Source);
-            const sourceType = source_1.Source.runSyntax(source, input);
             const found = allImporting === null || allImporting === void 0 ? void 0 : allImporting.find(p => p.getName().toUpperCase() === name);
+            const source = p.findDirectExpression(Expressions.Source);
+            const sourceType = source_1.Source.runSyntax(source, input, found === null || found === void 0 ? void 0 : found.getType());
             if (found === undefined) {
                 const message = `constructor parameter "${name}" does not exist`;
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));

package/build/src/abap/types/basic/index.js

@@ -32,6 +32,7 @@ __exportStar(require("./generic_object_reference_type"), exports);
 __exportStar(require("./hex_type"), exports);
 __exportStar(require("./integer_type"), exports);
 __exportStar(require("./integer8_type"), exports);
+__exportStar(require("./ngeneric_type"), exports);
 __exportStar(require("./numeric_generic_type"), exports);
 __exportStar(require("./numeric_type"), exports);
 __exportStar(require("./object_reference_type"), exports);

package/build/src/abap/types/basic/ngeneric_type.js

@@ -0,0 +1,23 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.NGenericType = void 0;
+const numeric_type_1 = require("./numeric_type");
+// "TYPE n" of a method or FORM parameter, where no length can be given.
+// It is a NumericType, so everything that handles n keeps treating it as such
+class NGenericType extends numeric_type_1.NumericType {
+    static get() {
+        return this.singleton;
+    }
+    constructor() {
+        super(1);
+    }
+    toText() {
+        return "```n```";
+    }
+    isGeneric() {
+        return true;
+    }
+}
+exports.NGenericType = NGenericType;
+NGenericType.singleton = new NGenericType();
+//# sourceMappingURL=ngeneric_type.js.map

package/build/src/registry.js

@@ -75,7 +75,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.68";
+        return "2.120.69";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/downport.js

@@ -2419,8 +2419,17 @@ ${indentation}    output = ${uniqueName}.\n`;
                 const extra = (valueBody === null || valueBody === void 0 ? void 0 : valueBody.findDirectExpression(Expressions.For)) ? "  " : "";
                 data = indentation + extra + `DATA ${structureName} LIKE LINE OF ${uniqueName}.\n`;
             }
+            // all rows are built in the same work area, a component a row leaves out must be initial,
+            // not what an earlier row (or an earlier pass of a surrounding loop) put there
+            const clearRows = valueBody !== undefined && this.valueRowsNeedClear(valueBody);
+            const prefix = [];
             for (const a of (valueBody === null || valueBody === void 0 ? void 0 : valueBody.getChildren()) || []) {
                 if (a.get() instanceof Expressions.FieldAssignment) {
+                    if (clearRows === true) {
+                        // the shared prefix applies to every following row, re-applied after each CLEAR
+                        prefix.push(a.concatTokens());
+                        continue;
+                    }
                     if (added === false) {
                         body += data;
                         added = true;
@@ -2444,6 +2453,16 @@ ${indentation}    output = ${uniqueName}.\n`;
                 }
                 if (a instanceof nodes_1.ExpressionNode && a.get() instanceof Expressions.ValueBodyLine) {
                     let skip = false;
+                    if (clearRows === true && this.isStructuredValueRow(a)) {
+                        if (added === false) {
+                            body += data;
+                            added = true;
+                        }
+                        body += indentation + `CLEAR ${structureName}.\n`;
+                        for (const p of prefix) {
+                            body += indentation + structureName + "-" + p + ".\n";
+                        }
+                    }
                     for (const b of (a === null || a === void 0 ? void 0 : a.getChildren()) || []) {
                         if (b.get() instanceof Expressions.FieldAssignment) {
                             if (added === false) {
@@ -2522,6 +2541,39 @@ ${indentation}    output = ${uniqueName}.\n`;
         }
         return undefined;
     }
+    /** a row that is built in the work area, ie. not "( source )" or "( LINES OF source )" */
+    isStructuredValueRow(row) {
+        return row.findDirectExpression(Expressions.Source) === undefined
+            && row.findDirectExpression(Expressions.ValueBodyLines) === undefined;
+    }
+    /** true if a row can observe a component that an earlier row, or an earlier pass of a surrounding loop,
+     * left in the shared work area. Not the case if all rows assign the same components, and the shared
+     * prefix is not changed between rows, eg. FOR rows or "( a = 1 b = 2 ) ( a = 3 b = 4 )" */
+    valueRowsNeedClear(valueBody) {
+        let shape = undefined;
+        let rowSeen = false;
+        for (const c of valueBody.getChildren()) {
+            if (c.get() instanceof Expressions.FieldAssignment) {
+                if (rowSeen === true) {
+                    return true;
+                }
+            }
+            else if (c instanceof nodes_1.ExpressionNode
+                && c.get() instanceof Expressions.ValueBodyLine
+                && this.isStructuredValueRow(c)) {
+                rowSeen = true;
+                const current = c.findDirectExpressions(Expressions.FieldAssignment)
+                    .map(f => { var _a; return (_a = f.findDirectExpression(Expressions.FieldSub)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase().replace(/\s/g, ""); })
+                    .sort()
+                    .join(",");
+                if (shape !== undefined && shape !== current) {
+                    return true;
+                }
+                shape = current;
+            }
+        }
+        return false;
+    }
     outlineLet(node, indentation, highSyntax, lowFile) {
         var _a;
         let ret = "";

package/build/src/rules/rfc_error_handling.js

@@ -54,7 +54,9 @@ class RFCErrorHandling extends _abap_rule_1.ABAPRule {
             title: "RFC error handling",
             tags: [_irule_1.RuleTag.SingleFile],
             shortDescription: `Checks that exceptions 'system_failure' and 'communication_failure' are handled in RFC calls`,
-            extendedInformation: `https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/abenrfc_exception.html`,
+            extendedInformation: `RESOURCE_FAILURE is also required for asynchronous calls with DESTINATION IN GROUP.
+
+https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/abenrfc_exception.html`,
             badExample: `CALL FUNCTION 'ZRFC'
   DESTINATION lv_rfc.`,
             goodExample: `CALL FUNCTION 'ZRFC'
@@ -62,12 +64,12 @@ class RFCErrorHandling extends _abap_rule_1.ABAPRule {
   EXCEPTIONS
     system_failure        = 1 MESSAGE msg
     communication_failure = 2 MESSAGE msg
-    resource_failure      = 3
-    OTHERS                = 4.`,
+    OTHERS                = 3.`,
         };
     }
-    getMessage() {
-        return "RFC error handling: At least one unhandled exception from SYSTEM_FAILURE, COMMUNICATION_FAILURE, RESOURCE_FAILURE";
+    getMessage(requireResourceFailure) {
+        return "RFC error handling: At least one unhandled exception from SYSTEM_FAILURE, COMMUNICATION_FAILURE"
+            + (requireResourceFailure ? ", RESOURCE_FAILURE" : "");
     }
     getConfig() {
         return this.conf;
@@ -82,12 +84,15 @@ class RFCErrorHandling extends _abap_rule_1.ABAPRule {
             if (!(stat.get() instanceof Statements.CallFunction)) {
                 continue;
             }
-            if (!stat.findFirstExpression(Expressions.Destination)) {
+            const destination = stat.findFirstExpression(Expressions.Destination);
+            if (destination === undefined) {
                 continue;
             }
+            const requireResourceFailure = stat.findDirectTokenByText("STARTING") !== undefined
+                && destination.findDirectTokenByText("GROUP") !== undefined;
             const list = stat.findFirstExpression(Expressions.ParameterListExceptions);
             if (list === undefined) {
-                const issue = issue_1.Issue.atToken(file, token, this.getMessage(), this.getMetadata().key, this.conf.severity);
+                const issue = issue_1.Issue.atToken(file, token, this.getMessage(requireResourceFailure), this.getMetadata().key, this.conf.severity);
                 output.push(issue);
                 continue;
             }
@@ -98,8 +103,8 @@ class RFCErrorHandling extends _abap_rule_1.ABAPRule {
             }
             if (names.indexOf("SYSTEM_FAILURE") < 0
                 || names.indexOf("COMMUNICATION_FAILURE") < 0
-                || names.indexOf("RESOURCE_FAILURE") < 0) {
-                const issue = issue_1.Issue.atToken(file, token, this.getMessage(), this.getMetadata().key, this.conf.severity);
+                || (requireResourceFailure && names.indexOf("RESOURCE_FAILURE") < 0)) {
+                const issue = issue_1.Issue.atToken(file, token, this.getMessage(requireResourceFailure), this.getMetadata().key, this.conf.severity);
                 output.push(issue);
                 continue;
             }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.120.68",
+    "version": "2.120.69",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",