@abaplint/core 2.120.58 → 2.120.59

package/build/src/abap/5_syntax/expressions/source.js

@@ -162,6 +162,11 @@ class Source {
                             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                             return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
                         }
+                        if ((foundType === null || foundType === void 0 ? void 0 : foundType.isGeneric()) && bodyType !== undefined) {
+                            this.addIfInferred(node, input, bodyType);
+                            this.traverseRemainingChildren(children, input);
+                            return bodyType;
+                        }
                         this.addIfInferred(node, input, foundType);
                         this.traverseRemainingChildren(children, input);
                         return foundType;

package/build/src/registry.js

@@ -75,7 +75,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.58";
+        return "2.120.59";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/index.js

@@ -191,6 +191,7 @@ __exportStar(require("./types_naming"), exports);
 __exportStar(require("./uncaught_exception"), exports);
 __exportStar(require("./unknown_types"), exports);
 __exportStar(require("./unnecessary_chaining"), exports);
+__exportStar(require("./unnecessary_loop_guard"), exports);
 __exportStar(require("./unnecessary_pragma"), exports);
 __exportStar(require("./unnecessary_return"), exports);
 __exportStar(require("./unreachable_code"), exports);
@@ -203,6 +204,7 @@ __exportStar(require("./unused_variables"), exports);
 __exportStar(require("./use_bool_expression"), exports);
 __exportStar(require("./use_class_based_exceptions"), exports);
 __exportStar(require("./use_line_exists"), exports);
+__exportStar(require("./use_message_class"), exports);
 __exportStar(require("./use_new"), exports);
 __exportStar(require("./when_others_last"), exports);
 __exportStar(require("./whitespace_end"), exports);

package/build/src/rules/unnecessary_loop_guard.js

@@ -0,0 +1,135 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.UnnecessaryLoopGuard = exports.UnnecessaryLoopGuardConf = void 0;
+const issue_1 = require("../issue");
+const Expressions = __importStar(require("../abap/2_statements/expressions"));
+const Statements = __importStar(require("../abap/2_statements/statements"));
+const Structures = __importStar(require("../abap/3_structures/structures"));
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+const edit_helper_1 = require("../edit_helper");
+class UnnecessaryLoopGuardConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.UnnecessaryLoopGuardConf = UnnecessaryLoopGuardConf;
+class UnnecessaryLoopGuard extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new UnnecessaryLoopGuardConf();
+    }
+    getMetadata() {
+        return {
+            key: "unnecessary_loop_guard",
+            title: "Unnecessary loop guard",
+            shortDescription: `Detects unnecessary IS [NOT] INITIAL check before LOOP AT`,
+            extendedInformation: `LOOP AT iterates zero times on an empty table, so an IS [NOT] INITIAL guard is redundant.`,
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix],
+            badExample: `IF lt_data IS NOT INITIAL.
+  LOOP AT lt_data INTO DATA(ls_item).
+    WRITE ls_item-name.
+  ENDLOOP.
+ENDIF.`,
+            goodExample: `LOOP AT lt_data INTO DATA(ls_item).
+  WRITE ls_item-name.
+ENDLOOP.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        const stru = file.getStructure();
+        if (stru === undefined) {
+            return issues;
+        }
+        for (const ifStru of stru.findAllStructuresRecursive(Structures.If)) {
+            if (ifStru.findDirectStructures(Structures.ElseIf).length > 0
+                || ifStru.findDirectStructures(Structures.Else).length > 0) {
+                continue;
+            }
+            const ifStatement = ifStru.findDirectStatement(Statements.If);
+            if (ifStatement === undefined) {
+                continue;
+            }
+            const cond = ifStatement.findDirectExpression(Expressions.Cond);
+            if (cond === undefined) {
+                continue;
+            }
+            const compareNodes = cond.findDirectExpressions(Expressions.Compare);
+            if (compareNodes.length !== 1) {
+                continue;
+            }
+            const m = compareNodes[0].concatTokens().toUpperCase().match(/^(.+?)\s+IS\s+(?:NOT\s+)?INITIAL\s*$/);
+            if (!m) {
+                continue;
+            }
+            const tableName = m[1];
+            const bodyStructures = ifStru.findDirectStructures(Structures.Body);
+            if (bodyStructures.length !== 1) {
+                continue;
+            }
+            const normalStructures = bodyStructures[0].findDirectStructures(Structures.Normal);
+            if (normalStructures.length !== 1) {
+                continue;
+            }
+            const loopStructures = normalStructures[0].findDirectStructures(Structures.Loop);
+            if (loopStructures.length !== 1) {
+                continue;
+            }
+            const loopStatement = loopStructures[0].findDirectStatement(Statements.Loop);
+            if (loopStatement === undefined) {
+                continue;
+            }
+            const loopSource = loopStatement.findFirstExpression(Expressions.LoopSource);
+            if (loopSource === undefined) {
+                continue;
+            }
+            if (loopSource.concatTokens().toUpperCase() !== tableName) {
+                continue;
+            }
+            const endifStatement = ifStru.findDirectStatement(Statements.EndIf);
+            const fix = edit_helper_1.EditHelper.merge(edit_helper_1.EditHelper.deleteStatement(file, ifStatement), edit_helper_1.EditHelper.deleteStatement(file, endifStatement));
+            issues.push(issue_1.Issue.atStatement(file, ifStatement, "Unnecessary IS [NOT] INITIAL check before LOOP AT", this.getMetadata().key, this.conf.severity, fix));
+        }
+        return issues;
+    }
+}
+exports.UnnecessaryLoopGuard = UnnecessaryLoopGuard;
+//# sourceMappingURL=unnecessary_loop_guard.js.map

package/build/src/rules/use_message_class.js

@@ -0,0 +1,87 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.UseMessageClass = exports.UseMessageClassConf = void 0;
+const issue_1 = require("../issue");
+const _abap_rule_1 = require("./_abap_rule");
+const Expressions = __importStar(require("../abap/2_statements/expressions"));
+const Statements = __importStar(require("../abap/2_statements/statements"));
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+class UseMessageClassConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.UseMessageClassConf = UseMessageClassConf;
+class UseMessageClass extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new UseMessageClassConf();
+    }
+    getMetadata() {
+        return {
+            key: "use_message_class",
+            title: "Use message class",
+            shortDescription: `Define messages in SE91 instead of using inline text or variables`,
+            tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
+            badExample: `MESSAGE 'Something went wrong' TYPE 'E'.`,
+            goodExample: `MESSAGE e001(bc_msg).`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file, _obj) {
+        const structure = file.getStructure();
+        if (structure === undefined) {
+            return [];
+        }
+        const issues = [];
+        const key = this.getMetadata().key;
+        for (const statement of structure.findAllStatements(Statements.Message)) {
+            // The parser populates MessageSource only for the class-based forms (e001(bc_msg) or ID/TYPE/NUMBER).
+            // The text form (MESSAGE <source> TYPE <source>) uses MessageSourceSource directly with no MessageSource child.
+            // Absence of MessageSource is therefore a reliable discriminator between the two forms.
+            if (statement.findDirectExpression(Expressions.MessageSource) !== undefined) {
+                continue;
+            }
+            issues.push(issue_1.Issue.atStatement(file, statement, "Use a message class (SE91) instead of inline text or variable", key, this.conf.severity));
+        }
+        return issues;
+    }
+}
+exports.UseMessageClass = UseMessageClass;
+//# sourceMappingURL=use_message_class.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.120.58",
+    "version": "2.120.59",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",