@abaplint/core 2.120.54 → 2.120.55

package/build/src/abap/2_statements/statements/call_transaction.js

@@ -8,7 +8,7 @@ class CallTransaction {
     getMatcher() {
         const options = (0, combi_1.seq)("OPTIONS FROM", expressions_1.Source);
         const messages = (0, combi_1.seq)("MESSAGES INTO", expressions_1.Target);
-        const auth = (0, combi_1.ver)(version_1.Release.v740sp02, (0, combi_1.seq)((0, combi_1.altPrio)("WITH", "WITHOUT"), "AUTHORITY-CHECK"));
+        const auth = (0, combi_1.ver)(version_1.Release.v740sp02, (0, combi_1.seq)((0, combi_1.altPrio)("WITH", "WITHOUT"), "AUTHORITY-CHECK"), { also: combi_1.AlsoIn.OpenABAP });
         const perm = (0, combi_1.per)((0, combi_1.seq)("UPDATE", expressions_1.Source), "AND SKIP FIRST SCREEN", options, messages, (0, combi_1.seq)("MODE", expressions_1.Source));
         const ret = (0, combi_1.seq)("CALL TRANSACTION", expressions_1.Source, (0, combi_1.optPrio)(auth), (0, combi_1.optPrio)((0, combi_1.seq)("USING", expressions_1.Source)), (0, combi_1.opt)(perm));
         return (0, combi_1.verNotLang)(version_1.LanguageVersion.Cloud, ret);

package/build/src/registry.js

@@ -75,7 +75,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.54";
+        return "2.120.55";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/align_parameters.js

@@ -64,7 +64,7 @@ class AlignParameters extends _abap_rule_1.ABAPRule {
 * CREATE OBJECT statements
 * RAISE EVENT statements
 
-https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#align-parameters
 
 Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
 

package/build/src/rules/constant_classes.js

@@ -57,7 +57,7 @@ class ConstantClasses {
             key: "constant_classes",
             title: "Validate constant classes",
             shortDescription: `Checks that a class contains exactly the constants corresponding to a domain's fixed values.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-enumeration-classes-to-constants-interfaces`,
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-enum-to-constants-interfaces`,
             tags: [_irule_1.RuleTag.Styleguide],
         };
     }

package/build/src/rules/downport.js

@@ -2885,6 +2885,10 @@ ${indentation}    output = ${uniqueName}.\n`;
         if (!(high.get() instanceof Statements.CallTransaction)) {
             return undefined;
         }
+        else if (this.lowReg.getConfig().isOpenABAP()) {
+            // open-abap supports the addition
+            return undefined;
+        }
         const tokens = high.getTokens();
         // the lexer splits "AUTHORITY-CHECK" into three tokens: AUTHORITY, -, CHECK
         for (let i = 1; i < tokens.length - 3; i++) {

package/build/src/rules/keyword_case.js

@@ -146,7 +146,7 @@ class KeywordCase extends _abap_rule_1.ABAPRule {
             key: "keyword_case",
             title: "Keyword case",
             shortDescription: `Checks that keywords have the same case. Non-keywords must be lower case.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-your-pretty-printer-team-settings`,
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-your-teams-abap-formatter-settings`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
             badExample: `write 'hello world'.`,
             goodExample: `WRITE 'hello world'.`,

package/build/src/rules/prefer_insert_into_table.js

@@ -53,9 +53,8 @@ class PreferInsertIntoTable extends _abap_rule_1.ABAPRule {
             key: "prefer_insert_into_table",
             title: "Prefer INSERT INTO TABLE over APPEND",
             shortDescription: `Prefer INSERT INTO TABLE over APPEND`,
-            extendedInformation: `INSERT INTO TABLE respects the table type, while APPEND always adds to the end regardless of table type.
-
-https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md`,
+            // eslint-disable-next-line max-len
+            extendedInformation: `INSERT INTO TABLE respects the table type, while APPEND always tries to add to the end. This will dump if the sort order of a sorted table would change.\n\nhttps://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-insert-into-table-to-append-to`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix],
             badExample: `APPEND row TO itab.`,
             goodExample: `INSERT row INTO TABLE itab.`,

package/build/src/rules/sequential_blank.js

@@ -30,6 +30,8 @@ class SequentialBlank extends _abap_rule_1.ABAPRule {
             key: "sequential_blank",
             title: "Sequential blank lines",
             shortDescription: `Checks that code does not contain more than the configured number of blank lines in a row.`,
+            // eslint-disable-next-line max-len
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#add-a-single-blank-line-to-separate-things-but-not-more`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
         };
     }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.120.54",
+    "version": "2.120.55",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",