@abaplint/core 2.120.53 → 2.120.55

package/build/src/abap/2_statements/statements/call_transaction.js

@@ -8,7 +8,7 @@ class CallTransaction {
     getMatcher() {
         const options = (0, combi_1.seq)("OPTIONS FROM", expressions_1.Source);
         const messages = (0, combi_1.seq)("MESSAGES INTO", expressions_1.Target);
-        const auth = (0, combi_1.seq)((0, combi_1.altPrio)("WITH", "WITHOUT"), "AUTHORITY-CHECK");
+        const auth = (0, combi_1.ver)(version_1.Release.v740sp02, (0, combi_1.seq)((0, combi_1.altPrio)("WITH", "WITHOUT"), "AUTHORITY-CHECK"), { also: combi_1.AlsoIn.OpenABAP });
         const perm = (0, combi_1.per)((0, combi_1.seq)("UPDATE", expressions_1.Source), "AND SKIP FIRST SCREEN", options, messages, (0, combi_1.seq)("MODE", expressions_1.Source));
         const ret = (0, combi_1.seq)("CALL TRANSACTION", expressions_1.Source, (0, combi_1.optPrio)(auth), (0, combi_1.optPrio)((0, combi_1.seq)("USING", expressions_1.Source)), (0, combi_1.opt)(perm));
         return (0, combi_1.verNotLang)(version_1.LanguageVersion.Cloud, ret);

package/build/src/registry.js

@@ -75,7 +75,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.53";
+        return "2.120.55";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/align_parameters.js

@@ -64,7 +64,7 @@ class AlignParameters extends _abap_rule_1.ABAPRule {
 * CREATE OBJECT statements
 * RAISE EVENT statements
 
-https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#align-parameters
 
 Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
 

package/build/src/rules/constant_classes.js

@@ -57,7 +57,7 @@ class ConstantClasses {
             key: "constant_classes",
             title: "Validate constant classes",
             shortDescription: `Checks that a class contains exactly the constants corresponding to a domain's fixed values.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-enumeration-classes-to-constants-interfaces`,
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-enum-to-constants-interfaces`,
             tags: [_irule_1.RuleTag.Styleguide],
         };
     }

package/build/src/rules/downport.js

@@ -381,7 +381,11 @@ Make sure to test the downported code, it might not always be completely correct
           return found;
         }
         */
-        let found = this.downportEnum(low, high, lowFile, highSyntax, highFile);
+        let found = this.stripCallTransactionAuthorityCheck(high, lowFile);
+        if (found) {
+            return found;
+        }
+        found = this.downportEnum(low, high, lowFile, highSyntax, highFile);
         if (found) {
             return found;
         }
@@ -2875,6 +2879,31 @@ ${indentation}    output = ${uniqueName}.\n`;
         }
         return false;
     }
+    /** WITH/WITHOUT AUTHORITY-CHECK on CALL TRANSACTION requires v740sp02, so the statement is
+     * Unknown in the low version, note that only WITHOUT is handled here */
+    stripCallTransactionAuthorityCheck(high, lowFile) {
+        if (!(high.get() instanceof Statements.CallTransaction)) {
+            return undefined;
+        }
+        else if (this.lowReg.getConfig().isOpenABAP()) {
+            // open-abap supports the addition
+            return undefined;
+        }
+        const tokens = high.getTokens();
+        // the lexer splits "AUTHORITY-CHECK" into three tokens: AUTHORITY, -, CHECK
+        for (let i = 1; i < tokens.length - 3; i++) {
+            if (tokens[i].getStr().toUpperCase() === "WITHOUT"
+                && tokens[i + 1].getStr().toUpperCase() === "AUTHORITY"
+                && tokens[i + 2].getStr() === "-"
+                && tokens[i + 3].getStr().toUpperCase() === "CHECK") {
+                // also remove the preceding space so no double space is left behind
+                const fix = edit_helper_1.EditHelper.deleteRange(lowFile, tokens[i - 1].getEnd(), tokens[i + 3].getEnd());
+                const message = "Remove WITHOUT AUTHORITY-CHECK from CALL TRANSACTION";
+                return issue_1.Issue.atToken(lowFile, tokens[i], message, this.getMetadata().key, this.conf.severity, fix);
+            }
+        }
+        return undefined;
+    }
     replaceXsdBool(node, lowFile, highSyntax) {
         if (this.lowReg.getConfig().isOpenABAP()) {
             return undefined;

package/build/src/rules/index.js

@@ -145,6 +145,7 @@ __exportStar(require("./parser_missing_space"), exports);
 __exportStar(require("./pragma_style"), exports);
 __exportStar(require("./prefer_corresponding"), exports);
 __exportStar(require("./prefer_inline"), exports);
+__exportStar(require("./prefer_insert_into_table"), exports);
 __exportStar(require("./prefer_is_not"), exports);
 __exportStar(require("./prefer_pragmas"), exports);
 __exportStar(require("./prefer_raise_exception_new"), exports);

package/build/src/rules/keyword_case.js

@@ -146,7 +146,7 @@ class KeywordCase extends _abap_rule_1.ABAPRule {
             key: "keyword_case",
             title: "Keyword case",
             shortDescription: `Checks that keywords have the same case. Non-keywords must be lower case.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-your-pretty-printer-team-settings`,
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-your-teams-abap-formatter-settings`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
             badExample: `write 'hello world'.`,
             goodExample: `WRITE 'hello world'.`,

package/build/src/rules/prefer_insert_into_table.js

@@ -0,0 +1,110 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.PreferInsertIntoTable = exports.PreferInsertIntoTableConf = void 0;
+const issue_1 = require("../issue");
+const Statements = __importStar(require("../abap/2_statements/statements"));
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+const edit_helper_1 = require("../edit_helper");
+class PreferInsertIntoTableConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.PreferInsertIntoTableConf = PreferInsertIntoTableConf;
+class PreferInsertIntoTable extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new PreferInsertIntoTableConf();
+    }
+    getMetadata() {
+        return {
+            key: "prefer_insert_into_table",
+            title: "Prefer INSERT INTO TABLE over APPEND",
+            shortDescription: `Prefer INSERT INTO TABLE over APPEND`,
+            // eslint-disable-next-line max-len
+            extendedInformation: `INSERT INTO TABLE respects the table type, while APPEND always tries to add to the end. This will dump if the sort order of a sorted table would change.\n\nhttps://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-insert-into-table-to-append-to`,
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix],
+            badExample: `APPEND row TO itab.`,
+            goodExample: `INSERT row INTO TABLE itab.`,
+        };
+    }
+    getConfig() { return this.conf; }
+    setConfig(conf) { this.conf = conf; }
+    runParsed(file) {
+        const issues = [];
+        for (const stat of file.getStatements()) {
+            if (!(stat.get() instanceof Statements.Append)) {
+                continue;
+            }
+            if (stat.concatTokens().toUpperCase().includes(" SORTED BY ")) {
+                continue;
+            }
+            const fix = this.buildFix(file, stat);
+            const message = "Prefer INSERT INTO TABLE over APPEND";
+            issues.push(issue_1.Issue.atStatement(file, stat, message, this.getMetadata().key, this.conf.severity, fix));
+        }
+        return issues;
+    }
+    buildFix(file, stat) {
+        const tokens = stat.getTokens();
+        // Find the APPEND token (first token)
+        const appendToken = tokens[0];
+        if (appendToken.getStr().toUpperCase() !== "APPEND") {
+            return undefined;
+        }
+        // Find the last "TO" token that precedes the table target.
+        // In all fixable forms the table target follows the last standalone "TO":
+        //   APPEND row TO itab
+        //   APPEND LINES OF itab2 TO itab
+        //   APPEND LINES OF itab2 FROM 1 TO 3 TO itab   <- last TO is the table
+        //   APPEND INITIAL LINE TO itab
+        let lastToIndex = -1;
+        for (let i = tokens.length - 1; i >= 0; i--) {
+            if (tokens[i].getStr().toUpperCase() === "TO") {
+                lastToIndex = i;
+                break;
+            }
+        }
+        if (lastToIndex < 0) {
+            return undefined;
+        }
+        const toToken = tokens[lastToIndex];
+        const fix1 = edit_helper_1.EditHelper.replaceToken(file, appendToken, "INSERT");
+        const fix2 = edit_helper_1.EditHelper.replaceToken(file, toToken, "INTO TABLE");
+        return edit_helper_1.EditHelper.merge(fix1, fix2);
+    }
+}
+exports.PreferInsertIntoTable = PreferInsertIntoTable;
+//# sourceMappingURL=prefer_insert_into_table.js.map

package/build/src/rules/sequential_blank.js

@@ -30,6 +30,8 @@ class SequentialBlank extends _abap_rule_1.ABAPRule {
             key: "sequential_blank",
             title: "Sequential blank lines",
             shortDescription: `Checks that code does not contain more than the configured number of blank lines in a row.`,
+            // eslint-disable-next-line max-len
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#add-a-single-blank-line-to-separate-things-but-not-more`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
         };
     }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.120.53",
+    "version": "2.120.55",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",