@abaplint/core 2.120.5 → 2.120.6

package/build/abaplint.d.ts

@@ -1259,6 +1259,7 @@ declare class ClassDefinition_3 extends Identifier implements IClassDefinition {
     private findSuper;
     private checkMethodNameLength;
     private checkClassConstructorStatic;
+    private checkInterfaceVisibility;
     private checkMethodsFromSuperClasses;
     private findFriends;
     private addReference;

package/build/src/abap/5_syntax/expressions/inline_data.js

@@ -43,6 +43,10 @@ class InlineData {
     static runSyntax(node, input, type) {
         var _a;
         const token = (_a = node.findFirstExpression(Expressions.TargetField)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
+        if (token && token.getStr().length > 30) {
+            const message = "DATA name too long, " + token.getStr();
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, token, message));
+        }
         if (token && type) {
             if (type instanceof basic_1.CSequenceType || type instanceof basic_1.CLikeType) {
                 type = basic_1.StringType.get();

package/build/src/abap/5_syntax/expressions/inline_fs.js

@@ -38,10 +38,16 @@ const Expressions = __importStar(require("../../2_statements/expressions"));
 const _typed_identifier_1 = require("../../types/_typed_identifier");
 const basic_1 = require("../../types/basic");
 const _reference_1 = require("../_reference");
+const _syntax_input_1 = require("../_syntax_input");
 class InlineFS {
     static runSyntax(node, input, type) {
         var _a;
         const token = (_a = node.findFirstExpression(Expressions.TargetFieldSymbol)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
+        const fs = node.findFirstExpression(Expressions.FieldSymbol);
+        if (fs && fs.concatTokens().length > 30) {
+            const message = "FIELD-SYMBOLS name too long, " + fs.concatTokens();
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, fs.getFirstToken(), message));
+        }
         if (token && type) {
             const identifier = new _typed_identifier_1.TypedIdentifier(token, input.filename, type, ["inline" /* IdentifierMeta.InlineDefinition */]);
             input.scope.addIdentifier(identifier);

package/build/src/abap/5_syntax/statements/at_selection_screen.js

@@ -0,0 +1,59 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.AtSelectionScreen = void 0;
+const Expressions = __importStar(require("../../2_statements/expressions"));
+const _reference_1 = require("../_reference");
+const source_field_1 = require("../expressions/source_field");
+class AtSelectionScreen {
+    runSyntax(node, input) {
+        // "AT SELECTION-SCREEN ON <field>", "ON VALUE-REQUEST FOR <field>",
+        // "ON HELP-REQUEST FOR <field>" and "ON END OF <field>" all reference
+        // a parameter or select-option, register these as read references so
+        // they are not reported as unused.
+        const fields = [
+            ...node.findDirectExpressions(Expressions.FieldSub),
+            ...node.findDirectExpressions(Expressions.Field),
+        ];
+        for (const field of fields) {
+            const token = field.getFirstToken();
+            if (input.scope.findVariable(token.getStr()) !== undefined) {
+                source_field_1.SourceField.runSyntax(field, input, _reference_1.ReferenceType.DataReadReference, false);
+            }
+        }
+    }
+}
+exports.AtSelectionScreen = AtSelectionScreen;
+//# sourceMappingURL=at_selection_screen.js.map

package/build/src/abap/5_syntax/statements/fieldsymbol.js

@@ -38,14 +38,19 @@ const Expressions = __importStar(require("../../2_statements/expressions"));
 const _typed_identifier_1 = require("../../types/_typed_identifier");
 const basic_types_1 = require("../basic_types");
 const unknown_type_1 = require("../../types/basic/unknown_type");
+const _syntax_input_1 = require("../_syntax_input");
 const basic_1 = require("../../types/basic");
 class FieldSymbol {
     runSyntax(node, input) {
-        var _a;
-        const fsname = (_a = node.findFirstExpression(Expressions.FieldSymbol)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
-        if (fsname === undefined) {
+        const fs = node.findFirstExpression(Expressions.FieldSymbol);
+        const fsname = fs === null || fs === void 0 ? void 0 : fs.getFirstToken();
+        if (fs === undefined || fsname === undefined) {
             return;
         }
+        if (fs.concatTokens().length > 30) {
+            const message = "FIELD-SYMBOLS name too long, " + fs.concatTokens();
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, fsname, message));
+        }
         if (node.getChildren().length === 5) {
             // no type specified
             input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(fsname, input.filename, basic_1.VoidType.get("FS-SIMPLE")));

package/build/src/abap/5_syntax/syntax.js

@@ -90,6 +90,7 @@ const if_1 = require("./statements/if");
 const else_if_1 = require("./statements/else_if");
 const append_1 = require("./statements/append");
 const selection_screen_1 = require("./statements/selection_screen");
+const at_selection_screen_1 = require("./statements/at_selection_screen");
 const ranges_1 = require("./statements/ranges");
 const write_1 = require("./statements/write");
 const case_1 = require("./statements/case");
@@ -297,6 +298,7 @@ if (Object.keys(map).length === 0) {
     addToMap(new authority_check_1.AuthorityCheck());
     addToMap(new insert_report_1.InsertReport());
     addToMap(new selection_screen_1.SelectionScreen());
+    addToMap(new at_selection_screen_1.AtSelectionScreen());
     addToMap(new ranges_1.Ranges());
     addToMap(new add_1.Add());
     addToMap(new raise_event_1.RaiseEvent());

package/build/src/abap/types/class_definition.js

@@ -95,6 +95,7 @@ class ClassDefinition extends _identifier_1.Identifier {
             this.createVisibilityValue = visibility_1.Visibility.Public;
         }
         // perform checks after everything has been initialized
+        this.checkInterfaceVisibility(input, node);
         this.checkMethodsFromSuperClasses(input);
         this.checkMethodNameLength(input);
         this.checkClassConstructorStatic(input);
@@ -168,6 +169,17 @@ class ClassDefinition extends _identifier_1.Identifier {
             }
         }
     }
+    checkInterfaceVisibility(input, node) {
+        const sections = [
+            node.findDirectStructure(Structures.ProtectedSection),
+            node.findDirectStructure(Structures.PrivateSection),
+        ];
+        for (const section of sections) {
+            for (const statement of (section === null || section === void 0 ? void 0 : section.findAllStatements(Statements.InterfaceDef)) || []) {
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, statement.getFirstToken(), "INTERFACES can only be declared in public sections"));
+            }
+        }
+    }
     checkMethodsFromSuperClasses(input) {
         var _a;
         const scope = input.scope;

package/build/src/registry.js

@@ -75,7 +75,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.5";
+        return "2.120.6";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.120.5",
+    "version": "2.120.6",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",