@abaplint/core 2.120.44 → 2.120.46

package/build/abaplint.d.ts

@@ -7966,6 +7966,8 @@ declare class Table extends AbstractObject {
     listKeys(reg: IRegistry): string[];
     parseType(reg: IRegistry): AbstractType;
     getTableCategory(): TableCategory | undefined;
+    getDeliveryClass(): string | undefined;
+    getSizeCategory(): string | undefined;
     getEnhancementCategory(): EnhancementCategory;
     private keyFieldsNotFirst;
     private parseXML;

package/build/src/abap/5_syntax/expressions/value_body.js

@@ -131,6 +131,19 @@ class ValueBody {
                     const message = "VALUE, source type CharacterType not compatible with StringType";
                     input.issues.push((0, _syntax_input_1.syntaxIssue)(input, s.getFirstToken(), message));
                 }
+                else if (this.insertsUsingTableKey(targetType)) {
+                    // only STANDARD tables append the rows, and thus allow padding of shorter c and x values
+                    const row = this.characterOrHexLength(rowType);
+                    const source = this.characterOrHexLength(sourceType);
+                    if (row !== undefined
+                        && source !== undefined
+                        && row.abap === source.abap
+                        && row.length !== source.length) {
+                        const message = `VALUE, source type ${source.abap} LENGTH ${source.length} not compatible ` +
+                            `with row type ${row.abap} LENGTH ${row.length}`;
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, s.getFirstToken(), message));
+                    }
+                }
             }
         }
         if (letScoped === true) {
@@ -144,6 +157,25 @@ class ValueBody {
         }
         return targetType ? targetType : type;
     }
+    /** SORTED and HASHED tables insert the constructed rows using the table key, which
+     * requires the rows to be compatible with the row type. STANDARD tables only append
+     * the rows, so shorter c and x values are padded on the right instead. */
+    static insertsUsingTableKey(targetType) {
+        if (!(targetType instanceof basic_1.TableType)) {
+            return false;
+        }
+        const accessType = targetType.getAccessType();
+        return accessType === basic_1.TableAccessType.sorted || accessType === basic_1.TableAccessType.hashed;
+    }
+    static characterOrHexLength(type) {
+        if (type instanceof basic_1.CharacterType) {
+            return { abap: "c", length: type.getLength() };
+        }
+        else if (type instanceof basic_1.HexType) {
+            return { abap: "x", length: type.getLength() };
+        }
+        return undefined;
+    }
 }
 exports.ValueBody = ValueBody;
 //# sourceMappingURL=value_body.js.map

package/build/src/objects/table.js

@@ -310,6 +310,20 @@ class Table extends _abstract_object_1.AbstractObject {
         }
         return (_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.tableCategory;
     }
+    getDeliveryClass() {
+        var _a;
+        if (this.parsedData === undefined) {
+            this.parseXML();
+        }
+        return (_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.deliveryClass;
+    }
+    getSizeCategory() {
+        var _a;
+        if (this.parsedData === undefined) {
+            this.parseXML();
+        }
+        return (_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.sizeCategory;
+    }
     getEnhancementCategory() {
         var _a;
         if (this.parsedData === undefined) {
@@ -337,7 +351,7 @@ class Table extends _abstract_object_1.AbstractObject {
         return false;
     }
     parseXML() {
-        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o, _p, _q, _r, _s, _t, _u, _v, _w, _x, _y, _z, _0, _1, _2, _3, _4;
+        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o, _p, _q, _r, _s, _t, _u, _v, _w, _x, _y, _z, _0, _1, _2, _3, _4, _5, _6, _7, _8, _9, _10, _11, _12;
         const parsed = super.parseRaw2();
         if (parsed === undefined) {
             return;
@@ -357,8 +371,10 @@ class Table extends _abstract_object_1.AbstractObject {
         this.parsedData.tableCategory = (_m = (_l = (_k = (_j = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _j === void 0 ? void 0 : _j["asx:abap"]) === null || _k === void 0 ? void 0 : _k["asx:values"]) === null || _l === void 0 ? void 0 : _l.DD02V) === null || _m === void 0 ? void 0 : _m.TABCLASS;
         this.parsedData.description = (_r = (_q = (_p = (_o = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _o === void 0 ? void 0 : _o["asx:abap"]) === null || _p === void 0 ? void 0 : _p["asx:values"]) === null || _q === void 0 ? void 0 : _q.DD02V) === null || _r === void 0 ? void 0 : _r.DDTEXT;
         this.parsedData.dataClass = (_v = (_u = (_t = (_s = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _s === void 0 ? void 0 : _s["asx:abap"]) === null || _t === void 0 ? void 0 : _t["asx:values"]) === null || _u === void 0 ? void 0 : _u.DD09L) === null || _v === void 0 ? void 0 : _v.TABART;
+        this.parsedData.deliveryClass = (_z = (_y = (_x = (_w = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _w === void 0 ? void 0 : _w["asx:abap"]) === null || _x === void 0 ? void 0 : _x["asx:values"]) === null || _y === void 0 ? void 0 : _y.DD02V) === null || _z === void 0 ? void 0 : _z.CONTFLAG;
+        this.parsedData.sizeCategory = (_3 = (_2 = (_1 = (_0 = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _0 === void 0 ? void 0 : _0["asx:abap"]) === null || _1 === void 0 ? void 0 : _1["asx:values"]) === null || _2 === void 0 ? void 0 : _2.DD09L) === null || _3 === void 0 ? void 0 : _3.TABKAT;
         // fields
-        const fields = (_y = (_x = (_w = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _w === void 0 ? void 0 : _w["asx:abap"]) === null || _x === void 0 ? void 0 : _x["asx:values"]) === null || _y === void 0 ? void 0 : _y.DD03P_TABLE;
+        const fields = (_6 = (_5 = (_4 = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _4 === void 0 ? void 0 : _4["asx:abap"]) === null || _5 === void 0 ? void 0 : _5["asx:values"]) === null || _6 === void 0 ? void 0 : _6.DD03P_TABLE;
         for (const field of (0, xml_utils_1.xmlToArray)(fields === null || fields === void 0 ? void 0 : fields.DD03P)) {
             if (typeof (field === null || field === void 0 ? void 0 : field.FIELDNAME) !== "string") {
                 continue;
@@ -382,13 +398,13 @@ class Table extends _abstract_object_1.AbstractObject {
             });
         }
         // secondary indexes
-        const indexes = (_1 = (_0 = (_z = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _z === void 0 ? void 0 : _z["asx:abap"]) === null || _0 === void 0 ? void 0 : _0["asx:values"]) === null || _1 === void 0 ? void 0 : _1.DD12V;
+        const indexes = (_9 = (_8 = (_7 = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _7 === void 0 ? void 0 : _7["asx:abap"]) === null || _8 === void 0 ? void 0 : _8["asx:values"]) === null || _9 === void 0 ? void 0 : _9.DD12V;
         ;
         this.parsedData.secondaryIndexes = [];
         for (const index of (0, xml_utils_1.xmlToArray)(indexes === null || indexes === void 0 ? void 0 : indexes.DD12V)) {
             const indexName = index.INDEXNAME;
             const indexFields = [];
-            const indexFieldsXml = (_4 = (_3 = (_2 = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _2 === void 0 ? void 0 : _2["asx:abap"]) === null || _3 === void 0 ? void 0 : _3["asx:values"]) === null || _4 === void 0 ? void 0 : _4.DD17V;
+            const indexFieldsXml = (_12 = (_11 = (_10 = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _10 === void 0 ? void 0 : _10["asx:abap"]) === null || _11 === void 0 ? void 0 : _11["asx:values"]) === null || _12 === void 0 ? void 0 : _12.DD17V;
             for (const indexField of (0, xml_utils_1.xmlToArray)(indexFieldsXml === null || indexFieldsXml === void 0 ? void 0 : indexFieldsXml.DD17V)) {
                 if (indexField.INDEXNAME === indexName) {
                     // assumption: fields are listed by POSITION in the xml

package/build/src/registry.js

@@ -75,7 +75,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.44";
+        return "2.120.46";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/allowed_object_naming.js

@@ -17,7 +17,7 @@ class AllowedObjectNaming {
             key: "allowed_object_naming",
             title: "Allowed object naming",
             shortDescription: `Enforces basic name length and namespace restrictions, see note SAP 104010`,
-            tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.SingleFile],
+            tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Syntax],
         };
     }
     initialize(_reg) {

package/build/src/rules/downport.js

@@ -409,6 +409,10 @@ Make sure to test the downported code, it might not always be completely correct
         if (found) {
             return found;
         }
+        found = this.outlineTableExpressionKeyBuiltin(low, high, lowFile, highSyntax);
+        if (found) {
+            return found;
+        }
         found = this.assignWithTable(low, high, lowFile);
         if (found) {
             return found;
@@ -1106,6 +1110,69 @@ ${indentation}`);
         }
         return condition;
     }
+    /** A built-in function is only recognized as one in an operand position that admits an
+     * expression, and "WITH KEY comp = ..." does not become such a position until v740. The
+     * table expression rewrites carry the key operand over verbatim, so
+     * "tab[ comp = to_upper( x ) ]" downports to a READ TABLE that a 702 or 731 compiler can
+     * only read as a functional method call - "method TO_UPPER is unknown", reported as a
+     * SYNTAX_ERROR of the whole class pool. Hoist the call into a variable first, an
+     * assignment IS an expression position at 702.
+     *
+     * Built-ins that predate 702 (lines, strlen, numofchar, ...) carry no release in
+     * BuiltIn.methods; they are accepted in the operand as they are and stay untouched. So do
+     * functional method calls, which are exactly the reading that makes the built-in fail, and
+     * the INDEX operand of "tab[ 1 ]", which is not a key operand. */
+    outlineTableExpressionKeyBuiltin(low, high, lowFile, highSyntax) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        for (const tableExpression of high.findAllExpressionsRecursive(Expressions.TableExpression)) {
+            let afterComponent = false;
+            for (const child of tableExpression.getChildren()) {
+                if (child.get() instanceof Expressions.ComponentChainSimple) {
+                    afterComponent = true;
+                    continue;
+                }
+                else if (afterComponent === false
+                    || !(child.get() instanceof Expressions.Source)
+                    || !(child instanceof nodes_1.ExpressionNode)) {
+                    continue;
+                }
+                const type = this.builtinReturnType(child, lowFile, highSyntax);
+                if (type === undefined) {
+                    continue;
+                }
+                const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+                const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
+                const code = `DATA ${uniqueName} TYPE ${type}.\n` +
+                    indentation + `${uniqueName} = ${child.concatTokens()}.\n` +
+                    indentation;
+                const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), code);
+                const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, child.getFirstToken().getStart(), child.getLastToken().getEnd(), uniqueName);
+                const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
+                return issue_1.Issue.atToken(lowFile, child.getFirstToken(), "Outline built-in function in table expression key", this.getMetadata().key, this.conf.severity, fix);
+            }
+        }
+        return undefined;
+    }
+    /** the ABAP type returned by the built-in function this Source starts with, or undefined
+     * if it does not start with one, or with one that predates 702 */
+    builtinReturnType(source, lowFile, highSyntax) {
+        var _a, _b, _c;
+        const spag = highSyntax.spaghetti.lookupPosition(source.getFirstToken().getStart(), lowFile.getFilename());
+        for (const r of (spag === null || spag === void 0 ? void 0 : spag.getData().references) || []) {
+            if (r.referenceType !== _reference_1.ReferenceType.BuiltinMethodReference
+                || r.position.getStart().equals(source.getFirstToken().getStart()) === false) {
+                continue;
+            }
+            const name = r.position.getName().toUpperCase();
+            if (((_a = _builtin_1.BuiltIn.methods[name]) === null || _a === void 0 ? void 0 : _a.release) === undefined) {
+                return undefined;
+            }
+            return (_c = (_b = _builtin_1.BuiltIn.searchBuiltin(name)) === null || _b === void 0 ? void 0 : _b.getParameters().getReturning()) === null || _c === void 0 ? void 0 : _c.getType().toABAP();
+        }
+        return undefined;
+    }
     outlineCatchSimple(node, lowFile) {
         // outlines "CATCH cx_bcs INTO DATA(lx_bcs_excep).", note that this does not need to look at types
         var _a, _b;
@@ -2716,9 +2783,13 @@ ${indentation}    output = ${uniqueName}.\n`;
                 continue;
             }
             const uniqueName = this.uniqueName(i.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
-            const type = this.findType(i, lowFile, highSyntax);
             const indent = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
-            const abap = `DATA ${uniqueName} TYPE ${type}.\n` +
+            // the CONV type might just be a component of the row type, so prefer the row type
+            const rowOf = this.findRowTypeOf(high, i);
+            const declaration = rowOf === undefined
+                ? `DATA ${uniqueName} TYPE ${this.findType(i, lowFile, highSyntax)}.`
+                : `DATA ${uniqueName} LIKE LINE OF ${rowOf}.`;
+            const abap = declaration + "\n" +
                 indent + `${uniqueName} = ${body}.\n` +
                 indent;
             const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), abap);
@@ -2728,6 +2799,19 @@ ${indentation}    output = ${uniqueName}.\n`;
         }
         return undefined;
     }
+    /** if the source expression is the complete source of an INSERT or APPEND statement, then the
+     * outlined variable must be typed via the row type of the table, returns the table name */
+    findRowTypeOf(high, source) {
+        var _a;
+        if (!(high.get() instanceof Statements.InsertInternal)
+            && !(high.get() instanceof Statements.Append)) {
+            return undefined;
+        }
+        else if (high.getChildren()[1] !== source) {
+            return undefined;
+        }
+        return (_a = high.findDirectExpression(Expressions.Target)) === null || _a === void 0 ? void 0 : _a.concatTokens();
+    }
     // "CAST" to "?="
     outlineCast(low, high, lowFile, highSyntax) {
         var _a;

package/build/src/rules/line_break_style.js

@@ -4,6 +4,7 @@ exports.LineBreakStyle = exports.LineBreakStyleConf = void 0;
 const issue_1 = require("../issue");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const _irule_1 = require("./_irule");
+const objects_1 = require("../objects");
 class LineBreakStyleConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.LineBreakStyleConf = LineBreakStyleConf;
@@ -14,10 +15,11 @@ class LineBreakStyle {
     getMetadata() {
         return {
             key: "line_break_style",
-            title: "Makes sure line breaks are consistent in the ABAP code",
-            shortDescription: `Enforces LF as newlines in ABAP files
+            title: "Makes sure line breaks are consistent",
+            shortDescription: `Enforces LF as newlines in ABAP and XML files
 
 abapGit does not work with CRLF`,
+            extendedInformation: `SMIM and W3MI files are not checked.`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.SingleFile],
         };
     }
@@ -32,8 +34,15 @@ abapGit does not work with CRLF`,
     }
     run(obj) {
         const output = [];
+        if (obj instanceof objects_1.MIMEObject || obj instanceof objects_1.WebMIME) {
+            return output;
+        }
         for (const file of obj.getFiles()) {
-            if (file.getFilename().endsWith(".abap")) {
+            const filename = file.getFilename();
+            if (filename.endsWith(".abap") || filename.endsWith(".xml")) {
+                if (filename.endsWith(".xslt.source.xml")) {
+                    continue;
+                }
                 const rows = file.getRawRows();
                 for (let i = 0; i < rows.length; i++) {
                     if (rows[i].endsWith("\r") === true) {

package/build/src/rules/xml_consistency.js

@@ -64,6 +64,7 @@ class XMLConsistency {
 * XML is well-formed and parseable
 * Naming for CLAS and INTF objects
 * QUAN fields in TABL objects have reference table and field values
+* Transparent TABL objects have delivery class and size category set
 * Lock parameter names in ENQU objects are max 16 characters
 * Texts and translations do not exceed maximum allowed length.`,
             tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.Syntax],
@@ -322,15 +323,25 @@ class XMLConsistency {
         return issues;
     }
     runTable(obj, file) {
-        var _a, _b;
-        var _c;
+        var _a, _b, _c, _d;
+        var _e;
         const issues = [];
-        for (const field of (_c = obj.getFields()) !== null && _c !== void 0 ? _c : []) {
+        for (const field of (_e = obj.getFields()) !== null && _e !== void 0 ? _e : []) {
             if (field.DATATYPE === "QUAN" && (!((_a = field.REFTABLE) === null || _a === void 0 ? void 0 : _a.trim()) || !((_b = field.REFFIELD) === null || _b === void 0 ? void 0 : _b.trim()))) {
                 const message = `QUAN field ${field.FIELDNAME} must have REFTABLE and REFFIELD set`;
                 issues.push(issue_1.Issue.atRow(file, 1, message, this.getMetadata().key, this.conf.severity));
             }
         }
+        if (obj.getTableCategory() === Objects.TableCategory.Transparent) {
+            if (!((_c = obj.getDeliveryClass()) === null || _c === void 0 ? void 0 : _c.trim())) {
+                const message = `Transparent table must have delivery class(CONTFLAG in DD02V) set`;
+                issues.push(issue_1.Issue.atRow(file, 1, message, this.getMetadata().key, this.conf.severity));
+            }
+            if (!((_d = obj.getSizeCategory()) === null || _d === void 0 ? void 0 : _d.trim())) {
+                const message = `Transparent table must have size category(TABKAT in DD09L) set`;
+                issues.push(issue_1.Issue.atRow(file, 1, message, this.getMetadata().key, this.conf.severity));
+            }
+        }
         return issues;
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.120.44",
+    "version": "2.120.46",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",