@abaplint/core 2.120.43 → 2.120.45

package/build/abaplint.d.ts

@@ -558,12 +558,22 @@ declare namespace BasicTypes {
 export { BasicTypes }
 
 declare class BehaviorDefinition extends AbstractObject {
+    private parsedData;
     getType(): string;
     getAllowedNaming(): {
         maxLength: number;
         allowNamespace: boolean;
     };
     getDescription(): string | undefined;
+    setDirty(): void;
+    findSourceFile(): IFile | undefined;
+    listEntities(): readonly {
+        name: string;
+        alias: string | undefined;
+    }[];
+    /** finds the entity name for a given alias, undefined if the alias is not defined */
+    findEntityNameByAlias(alias: string): string | undefined;
+    private parseSource;
 }
 
 declare class BehaviorDefinitionName extends Expression {
@@ -1626,6 +1636,8 @@ export declare class CurrentScope {
     addSQLConversion(fieldName: string, message: string, token: Token): void;
     findFunctionModule(name: string | undefined): FunctionModuleDefinition | undefined;
     findObjectDefinition(name: string | undefined): IClassDefinition | IInterfaceDefinition | undefined;
+    /** the BDEF from "FOR BEHAVIOR OF" of the enclosing global class, undefined if not a behavior pool */
+    findBehaviorDefinition(): BehaviorDefinition | undefined;
     isBadiDef(name: string): boolean;
     existsObject(name: string | undefined): {
         id: Identifier | undefined;
@@ -3888,6 +3900,8 @@ declare interface InfoClassDefinition extends InfoInterfaceDefinition {
     duration: Duration | undefined;
     riskLevel: RiskLevel | undefined;
     isSharedMemory: boolean;
+    /** name of the BDEF from "FOR BEHAVIOR OF", undefined if not a behavior pool */
+    behaviorDefinitionName: string | undefined;
 }
 
 declare interface InfoClassImplementation {
@@ -4599,6 +4613,11 @@ declare class LockObject extends AbstractObject {
     getAllowedNaming(): IAllowedNaming;
     setDirty(): void;
     getPrimaryTable(): string | undefined;
+    getParameters(): {
+        VIEWFIELD: string;
+        TABNAME?: string;
+        FIELDNAME?: string;
+    }[] | undefined;
     parseType(reg: IRegistry): AbstractType;
     parse(): {
         updated: boolean;
@@ -5324,6 +5343,7 @@ declare namespace Objects {
         AuthorizationObjectExtension,
         AuthorizationObject,
         BADIDefinition,
+        ParsedBehaviorDefinition,
         BehaviorDefinition,
         BRFPlusSystemApplication,
         BSPApplication,
@@ -5624,6 +5644,14 @@ declare class ParenRightW extends Token {
     static railroad(): string;
 }
 
+declare type ParsedBehaviorDefinition = {
+    /** entities defined in the behavior definition, alias is undefined if not specified */
+    entities: {
+        name: string;
+        alias: string | undefined;
+    }[];
+};
+
 declare type ParsedDataDefinition = {
     sqlViewName: string | undefined;
     definitionName: string | undefined;
@@ -7938,6 +7966,8 @@ declare class Table extends AbstractObject {
     listKeys(reg: IRegistry): string[];
     parseType(reg: IRegistry): AbstractType;
     getTableCategory(): TableCategory | undefined;
+    getDeliveryClass(): string | undefined;
+    getSizeCategory(): string | undefined;
     getEnhancementCategory(): EnhancementCategory;
     private keyFieldsNotFirst;
     private parseXML;

package/build/src/abap/4_file_information/abap_file_information_parser.js

@@ -37,6 +37,7 @@ exports.ABAPFileInformationParser = void 0;
 const Structures = __importStar(require("../3_structures/structures"));
 const Expressions = __importStar(require("../2_statements/expressions"));
 const Statements = __importStar(require("../2_statements/statements"));
+const nodes_1 = require("../nodes");
 const _identifier_1 = require("./_identifier");
 const Tokens = __importStar(require("../1_lexer/tokens"));
 const visibility_1 = require("./visibility");
@@ -176,6 +177,7 @@ class ABAPFileInformationParser {
                 riskLevel,
                 isAbstract: (cdef === null || cdef === void 0 ? void 0 : cdef.findDirectTokenByText("ABSTRACT")) !== undefined,
                 isSharedMemory: concat.includes(" SHARED MEMORY ENABLED"),
+                behaviorDefinitionName: this.findBehaviorDefinitionName(cdef),
                 isFinal: found.findFirstExpression(Expressions.ClassFinal) !== undefined,
                 aliases,
                 attributes,
@@ -185,6 +187,20 @@ class ABAPFileInformationParser {
         return classes;
     }
     ///////////////////
+    /** "FOR BEHAVIOR OF" and "FOR EVENTS OF" both use the BehaviorDefinitionName expression,
+     * so look at the token two positions before the expression to tell them apart */
+    findBehaviorDefinitionName(cdef) {
+        const children = (cdef === null || cdef === void 0 ? void 0 : cdef.getChildren()) || [];
+        for (let i = 2; i < children.length; i++) {
+            const child = children[i];
+            if (child instanceof nodes_1.ExpressionNode
+                && child.get() instanceof Expressions.BehaviorDefinitionName
+                && children[i - 2].concatTokens().toUpperCase() === "BEHAVIOR") {
+                return child.concatTokens();
+            }
+        }
+        return undefined;
+    }
     getImplementing(input) {
         const ret = [];
         for (const node of input.findAllStatements(Statements.InterfaceDef)) {

package/build/src/abap/5_syntax/_current_scope.js

@@ -232,6 +232,18 @@ class CurrentScope {
         }
         return undefined;
     }
+    /** the BDEF from "FOR BEHAVIOR OF" of the enclosing global class, undefined if not a behavior pool */
+    findBehaviorDefinition() {
+        var _a;
+        if (this.parentObj.getType() !== "CLAS") {
+            return undefined;
+        }
+        const name = (_a = this.parentObj.getClassDefinition()) === null || _a === void 0 ? void 0 : _a.behaviorDefinitionName;
+        if (name === undefined) {
+            return undefined;
+        }
+        return this.reg.getObject("BDEF", name);
+    }
     isBadiDef(name) {
         const upper = name.toUpperCase();
         for (const enhs of this.reg.getObjectsByType("ENHS")) {

package/build/src/abap/5_syntax/basic_types.js

@@ -345,7 +345,7 @@ class BasicTypes {
         return undefined;
     }
     parseTable(node, name) {
-        var _a, _b, _c, _d;
+        var _a, _b, _c;
         const typename = node.findFirstExpression(Expressions.TypeName) || node.findFirstExpression(Expressions.EntityAssociation);
         const text = (_a = node.findFirstExpression(Expressions.TypeTable)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
         if (text === undefined) {
@@ -482,25 +482,31 @@ class BasicTypes {
             return new Types.TableType(structure, options);
         }
         else if (typename && this.isRAPTableFor(text)) {
-            const name = typename.concatTokens();
-            const ddlsName = this.getRAPBaseEntityName(name);
-            const type = (_d = this.input.scope.getDDIC().lookupDDLS(ddlsName)) === null || _d === void 0 ? void 0 : _d.type;
-            if (type) {
-                return new Types.TableType(basic_1.VoidType.get("RAP-TODO"), options);
-            }
-            else if (this.isRAPDerivedEntityName(name)) {
-                return Types.VoidType.get(name);
-            }
-            else if (this.input.scope.getDDIC().inErrorNamespace(ddlsName)) {
-                return new Types.UnknownType(`DDLS ${ddlsName} not found`);
-            }
-            else {
-                return Types.VoidType.get(name);
-            }
+            return this.rapTableFor(typename.concatTokens(), options);
         }
         // fallback to old style syntax, OCCURS etc
         return this.parseType(node, name);
     }
+    /** type of a RAP derived table type, ie the "TABLE FOR LOCK zentity" part of a type */
+    rapTableFor(entityName, options) {
+        var _a;
+        const ddlsName = this.resolveRAPAlias(this.getRAPBaseEntityName(entityName));
+        if ((_a = this.input.scope.getDDIC().lookupDDLS(ddlsName)) === null || _a === void 0 ? void 0 : _a.type) {
+            return new Types.TableType(basic_1.VoidType.get("RAP-TODO"), options !== null && options !== void 0 ? options : {
+                withHeader: false,
+                keyType: Types.TableKeyType.user,
+                primaryKey: { name: "primary_key", type: basic_1.TableAccessType.standard, isUnique: false, keyFields: [] },
+                secondary: [],
+            });
+        }
+        else if (this.isRAPDerivedEntityName(entityName)) {
+            return Types.VoidType.get(entityName);
+        }
+        else if (this.input.scope.getDDIC().inErrorNamespace(ddlsName)) {
+            return new Types.UnknownType(`DDLS ${ddlsName} not found`);
+        }
+        return Types.VoidType.get(entityName);
+    }
     parseType(node, qualifiedName) {
         var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k;
         const typeName = node.findFirstExpression(Expressions.TypeName);
@@ -694,6 +700,12 @@ class BasicTypes {
         const splitAt = Math.min(...candidates);
         return name.substring(0, splitAt);
     }
+    /** inside a behavior pool the entities are referenced via the aliases defined in the BDEF */
+    resolveRAPAlias(name) {
+        var _a;
+        var _b;
+        return (_b = (_a = this.input.scope.findBehaviorDefinition()) === null || _a === void 0 ? void 0 : _a.findEntityNameByAlias(name)) !== null && _b !== void 0 ? _b : name;
+    }
     isRAPDerivedEntityName(name) {
         return name.includes("\\") || name.includes("~");
     }

package/build/src/abap/5_syntax/expressions/value_body.js

@@ -131,6 +131,19 @@ class ValueBody {
                     const message = "VALUE, source type CharacterType not compatible with StringType";
                     input.issues.push((0, _syntax_input_1.syntaxIssue)(input, s.getFirstToken(), message));
                 }
+                else if (this.insertsUsingTableKey(targetType)) {
+                    // only STANDARD tables append the rows, and thus allow padding of shorter c and x values
+                    const row = this.characterOrHexLength(rowType);
+                    const source = this.characterOrHexLength(sourceType);
+                    if (row !== undefined
+                        && source !== undefined
+                        && row.abap === source.abap
+                        && row.length !== source.length) {
+                        const message = `VALUE, source type ${source.abap} LENGTH ${source.length} not compatible ` +
+                            `with row type ${row.abap} LENGTH ${row.length}`;
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, s.getFirstToken(), message));
+                    }
+                }
             }
         }
         if (letScoped === true) {
@@ -144,6 +157,25 @@ class ValueBody {
         }
         return targetType ? targetType : type;
     }
+    /** SORTED and HASHED tables insert the constructed rows using the table key, which
+     * requires the rows to be compatible with the row type. STANDARD tables only append
+     * the rows, so shorter c and x values are padded on the right instead. */
+    static insertsUsingTableKey(targetType) {
+        if (!(targetType instanceof basic_1.TableType)) {
+            return false;
+        }
+        const accessType = targetType.getAccessType();
+        return accessType === basic_1.TableAccessType.sorted || accessType === basic_1.TableAccessType.hashed;
+    }
+    static characterOrHexLength(type) {
+        if (type instanceof basic_1.CharacterType) {
+            return { abap: "c", length: type.getLength() };
+        }
+        else if (type instanceof basic_1.HexType) {
+            return { abap: "x", length: type.getLength() };
+        }
+        return undefined;
+    }
 }
 exports.ValueBody = ValueBody;
 //# sourceMappingURL=value_body.js.map

package/build/src/abap/types/method_parameters.js

@@ -41,6 +41,7 @@ const _typed_identifier_1 = require("./_typed_identifier");
 const basic_1 = require("./basic");
 const method_def_returning_1 = require("../5_syntax/expressions/method_def_returning");
 const method_param_1 = require("../5_syntax/expressions/method_param");
+const basic_types_1 = require("../5_syntax/basic_types");
 const _object_oriented_1 = require("../5_syntax/_object_oriented");
 const _reference_1 = require("../5_syntax/_reference");
 const identifier_1 = require("../1_lexer/tokens/identifier");
@@ -228,24 +229,37 @@ class MethodParameters {
         }
     }
     workaroundRAP(node, input, parentName) {
+        var _a;
         const resultName = node.findExpressionAfterToken("RESULT");
         const concat = node.concatTokens().toUpperCase();
         const isRap = node.findExpressionAfterToken("IMPORTING")
             || (concat.includes(" IMPORTING REQUEST ") ? node.findExpressionAfterToken("REQUEST") : undefined);
         if (isRap) {
+            // "FOR LOCK" handlers have a well defined signature, so the types can be derived
+            const lockEntity = concat.includes(" FOR LOCK ")
+                ? (_a = node.findExpressionAfterToken("LOCK")) === null || _a === void 0 ? void 0 : _a.concatTokens()
+                : undefined;
             for (const foo of node.findDirectExpressions(Expressions.MethodParamName)) {
                 if (foo === resultName) {
                     continue;
                 }
-                this.importing.push(new _typed_identifier_1.TypedIdentifier(foo.getFirstToken(), input.filename, basic_1.VoidType.get("RapMethodParameter"), ["importing" /* IdentifierMeta.MethodImporting */]));
+                const type = lockEntity === undefined
+                    ? basic_1.VoidType.get("RapMethodParameter")
+                    : new basic_types_1.BasicTypes(input).rapTableFor(lockEntity);
+                this.importing.push(new _typed_identifier_1.TypedIdentifier(foo.getFirstToken(), input.filename, type, ["importing" /* IdentifierMeta.MethodImporting */]));
+            }
+            if (lockEntity !== undefined) {
+                // note: "mapped" is not part of the signature for "FOR LOCK"
+                const token = isRap.getFirstToken();
+                this.exporting.push(new _typed_identifier_1.TypedIdentifier(new identifier_1.Identifier(token.getStart(), "failed"), input.filename, basic_1.VoidType.get(`RESPONSE FOR FAILED EARLY ${lockEntity}`), ["exporting" /* IdentifierMeta.MethodExporting */]));
+                this.exporting.push(new _typed_identifier_1.TypedIdentifier(new identifier_1.Identifier(token.getStart(), "reported"), input.filename, basic_1.VoidType.get(`RESPONSE FOR REPORTED EARLY ${lockEntity}`), ["exporting" /* IdentifierMeta.MethodExporting */]));
             }
-            if (concat.includes(" FOR VALIDATE ")
+            else if (concat.includes(" FOR VALIDATE ")
                 || concat.includes(" FOR BEHAVIOR ")
                 || concat.includes(" FOR DETERMINE ")
                 || concat.includes(" FOR FEATURES ")
                 || concat.includes(" FOR INSTANCE FEATURES ")
                 || concat.includes(" FOR GLOBAL AUTHORIZATION ")
-                || concat.includes(" FOR LOCK ")
                 || concat.includes(" FOR PRECHECK ")
                 || concat.includes(" FOR NUMBERING ")
                 || concat.includes(" FOR READ ")

package/build/src/objects/behavior_definition.js

@@ -3,6 +3,10 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.BehaviorDefinition = void 0;
 const _abstract_object_1 = require("./_abstract_object");
 class BehaviorDefinition extends _abstract_object_1.AbstractObject {
+    constructor() {
+        super(...arguments);
+        this.parsedData = undefined;
+    }
     getType() {
         return "BDEF";
     }
@@ -16,6 +20,49 @@ class BehaviorDefinition extends _abstract_object_1.AbstractObject {
         // todo
         return undefined;
     }
+    setDirty() {
+        this.parsedData = undefined;
+        super.setDirty();
+    }
+    findSourceFile() {
+        return this.getFiles().find(f => f.getFilename().endsWith(".asbdef"));
+    }
+    listEntities() {
+        return this.parseSource().entities;
+    }
+    /** finds the entity name for a given alias, undefined if the alias is not defined */
+    findEntityNameByAlias(alias) {
+        var _a;
+        const upper = alias.toUpperCase();
+        for (const entity of this.listEntities()) {
+            if (((_a = entity.alias) === null || _a === void 0 ? void 0 : _a.toUpperCase()) === upper) {
+                return entity.name;
+            }
+        }
+        return undefined;
+    }
+    /////////////////////////
+    parseSource() {
+        var _a;
+        if (this.parsedData !== undefined) {
+            return this.parsedData;
+        }
+        this.parsedData = { entities: [] };
+        const raw = (_a = this.findSourceFile()) === null || _a === void 0 ? void 0 : _a.getRaw();
+        if (raw === undefined) {
+            return this.parsedData;
+        }
+        // BDEF uses "//" for line comments
+        const stripped = raw.replace(/\/\/.*$/gm, "");
+        // eg. "define behavior for ZI_Booking alias Booking", also "define abstract behavior for ..."
+        const regex = /\bdefine\s+(?:\w+\s+)*?behavior\s+for\s+([\w/]+)(?:\s+alias\s+(\w+))?/gi;
+        let match = regex.exec(stripped);
+        while (match !== null) {
+            this.parsedData.entities.push({ name: match[1], alias: match[2] });
+            match = regex.exec(stripped);
+        }
+        return this.parsedData;
+    }
 }
 exports.BehaviorDefinition = BehaviorDefinition;
 //# sourceMappingURL=behavior_definition.js.map

package/build/src/objects/lock_object.js

@@ -4,6 +4,7 @@ exports.LockObject = void 0;
 const basic_1 = require("../abap/types/basic");
 const ddic_1 = require("../ddic");
 const _abstract_object_1 = require("./_abstract_object");
+const xml_utils_1 = require("../xml_utils");
 class LockObject extends _abstract_object_1.AbstractObject {
     getType() {
         return "ENQU";
@@ -24,6 +25,11 @@ class LockObject extends _abstract_object_1.AbstractObject {
         this.parse();
         return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.primaryTable;
     }
+    getParameters() {
+        var _a;
+        this.parse();
+        return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.parameters;
+    }
     parseType(reg) {
         var _a;
         this.parse();
@@ -48,7 +54,7 @@ class LockObject extends _abstract_object_1.AbstractObject {
         }
     }
     parse() {
-        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k;
+        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o;
         if (this.parsedXML) {
             return { updated: false, runtime: 0 };
         }
@@ -62,6 +68,18 @@ class LockObject extends _abstract_object_1.AbstractObject {
         }
         this.parsedXML.primaryTable = (_f = (_e = (_d = (_c = parsed.abapGit) === null || _c === void 0 ? void 0 : _c["asx:abap"]) === null || _d === void 0 ? void 0 : _d["asx:values"]) === null || _e === void 0 ? void 0 : _e.DD25V) === null || _f === void 0 ? void 0 : _f.ROOTTAB;
         this.parsedXML.description = (_k = (_j = (_h = (_g = parsed.abapGit) === null || _g === void 0 ? void 0 : _g["asx:abap"]) === null || _h === void 0 ? void 0 : _h["asx:values"]) === null || _j === void 0 ? void 0 : _j.DD25V) === null || _k === void 0 ? void 0 : _k.DDTEXT;
+        this.parsedXML.parameters = [];
+        const parameters = (_o = (_m = (_l = parsed.abapGit) === null || _l === void 0 ? void 0 : _l["asx:abap"]) === null || _m === void 0 ? void 0 : _m["asx:values"]) === null || _o === void 0 ? void 0 : _o.DD27P_TABLE;
+        for (const parameter of (0, xml_utils_1.xmlToArray)(parameters === null || parameters === void 0 ? void 0 : parameters.DD27P)) {
+            if (typeof (parameter === null || parameter === void 0 ? void 0 : parameter.VIEWFIELD) !== "string") {
+                continue;
+            }
+            this.parsedXML.parameters.push({
+                VIEWFIELD: parameter.VIEWFIELD,
+                TABNAME: parameter.TABNAME,
+                FIELDNAME: parameter.FIELDNAME,
+            });
+        }
         const end = Date.now();
         return { updated: true, runtime: end - start };
     }

package/build/src/objects/table.js

@@ -310,6 +310,20 @@ class Table extends _abstract_object_1.AbstractObject {
         }
         return (_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.tableCategory;
     }
+    getDeliveryClass() {
+        var _a;
+        if (this.parsedData === undefined) {
+            this.parseXML();
+        }
+        return (_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.deliveryClass;
+    }
+    getSizeCategory() {
+        var _a;
+        if (this.parsedData === undefined) {
+            this.parseXML();
+        }
+        return (_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.sizeCategory;
+    }
     getEnhancementCategory() {
         var _a;
         if (this.parsedData === undefined) {
@@ -337,7 +351,7 @@ class Table extends _abstract_object_1.AbstractObject {
         return false;
     }
     parseXML() {
-        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o, _p, _q, _r, _s, _t, _u, _v, _w, _x, _y, _z, _0, _1, _2, _3, _4;
+        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o, _p, _q, _r, _s, _t, _u, _v, _w, _x, _y, _z, _0, _1, _2, _3, _4, _5, _6, _7, _8, _9, _10, _11, _12;
         const parsed = super.parseRaw2();
         if (parsed === undefined) {
             return;
@@ -357,8 +371,10 @@ class Table extends _abstract_object_1.AbstractObject {
         this.parsedData.tableCategory = (_m = (_l = (_k = (_j = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _j === void 0 ? void 0 : _j["asx:abap"]) === null || _k === void 0 ? void 0 : _k["asx:values"]) === null || _l === void 0 ? void 0 : _l.DD02V) === null || _m === void 0 ? void 0 : _m.TABCLASS;
         this.parsedData.description = (_r = (_q = (_p = (_o = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _o === void 0 ? void 0 : _o["asx:abap"]) === null || _p === void 0 ? void 0 : _p["asx:values"]) === null || _q === void 0 ? void 0 : _q.DD02V) === null || _r === void 0 ? void 0 : _r.DDTEXT;
         this.parsedData.dataClass = (_v = (_u = (_t = (_s = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _s === void 0 ? void 0 : _s["asx:abap"]) === null || _t === void 0 ? void 0 : _t["asx:values"]) === null || _u === void 0 ? void 0 : _u.DD09L) === null || _v === void 0 ? void 0 : _v.TABART;
+        this.parsedData.deliveryClass = (_z = (_y = (_x = (_w = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _w === void 0 ? void 0 : _w["asx:abap"]) === null || _x === void 0 ? void 0 : _x["asx:values"]) === null || _y === void 0 ? void 0 : _y.DD02V) === null || _z === void 0 ? void 0 : _z.CONTFLAG;
+        this.parsedData.sizeCategory = (_3 = (_2 = (_1 = (_0 = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _0 === void 0 ? void 0 : _0["asx:abap"]) === null || _1 === void 0 ? void 0 : _1["asx:values"]) === null || _2 === void 0 ? void 0 : _2.DD09L) === null || _3 === void 0 ? void 0 : _3.TABKAT;
         // fields
-        const fields = (_y = (_x = (_w = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _w === void 0 ? void 0 : _w["asx:abap"]) === null || _x === void 0 ? void 0 : _x["asx:values"]) === null || _y === void 0 ? void 0 : _y.DD03P_TABLE;
+        const fields = (_6 = (_5 = (_4 = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _4 === void 0 ? void 0 : _4["asx:abap"]) === null || _5 === void 0 ? void 0 : _5["asx:values"]) === null || _6 === void 0 ? void 0 : _6.DD03P_TABLE;
         for (const field of (0, xml_utils_1.xmlToArray)(fields === null || fields === void 0 ? void 0 : fields.DD03P)) {
             if (typeof (field === null || field === void 0 ? void 0 : field.FIELDNAME) !== "string") {
                 continue;
@@ -382,13 +398,13 @@ class Table extends _abstract_object_1.AbstractObject {
             });
         }
         // secondary indexes
-        const indexes = (_1 = (_0 = (_z = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _z === void 0 ? void 0 : _z["asx:abap"]) === null || _0 === void 0 ? void 0 : _0["asx:values"]) === null || _1 === void 0 ? void 0 : _1.DD12V;
+        const indexes = (_9 = (_8 = (_7 = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _7 === void 0 ? void 0 : _7["asx:abap"]) === null || _8 === void 0 ? void 0 : _8["asx:values"]) === null || _9 === void 0 ? void 0 : _9.DD12V;
         ;
         this.parsedData.secondaryIndexes = [];
         for (const index of (0, xml_utils_1.xmlToArray)(indexes === null || indexes === void 0 ? void 0 : indexes.DD12V)) {
             const indexName = index.INDEXNAME;
             const indexFields = [];
-            const indexFieldsXml = (_4 = (_3 = (_2 = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _2 === void 0 ? void 0 : _2["asx:abap"]) === null || _3 === void 0 ? void 0 : _3["asx:values"]) === null || _4 === void 0 ? void 0 : _4.DD17V;
+            const indexFieldsXml = (_12 = (_11 = (_10 = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _10 === void 0 ? void 0 : _10["asx:abap"]) === null || _11 === void 0 ? void 0 : _11["asx:values"]) === null || _12 === void 0 ? void 0 : _12.DD17V;
             for (const indexField of (0, xml_utils_1.xmlToArray)(indexFieldsXml === null || indexFieldsXml === void 0 ? void 0 : indexFieldsXml.DD17V)) {
                 if (indexField.INDEXNAME === indexName) {
                     // assumption: fields are listed by POSITION in the xml

package/build/src/registry.js

@@ -75,7 +75,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.43";
+        return "2.120.45";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/line_break_style.js

@@ -4,6 +4,7 @@ exports.LineBreakStyle = exports.LineBreakStyleConf = void 0;
 const issue_1 = require("../issue");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const _irule_1 = require("./_irule");
+const objects_1 = require("../objects");
 class LineBreakStyleConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.LineBreakStyleConf = LineBreakStyleConf;
@@ -14,10 +15,11 @@ class LineBreakStyle {
     getMetadata() {
         return {
             key: "line_break_style",
-            title: "Makes sure line breaks are consistent in the ABAP code",
-            shortDescription: `Enforces LF as newlines in ABAP files
+            title: "Makes sure line breaks are consistent",
+            shortDescription: `Enforces LF as newlines in ABAP and XML files
 
 abapGit does not work with CRLF`,
+            extendedInformation: `SMIM and W3MI files are not checked.`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.SingleFile],
         };
     }
@@ -32,8 +34,15 @@ abapGit does not work with CRLF`,
     }
     run(obj) {
         const output = [];
+        if (obj instanceof objects_1.MIMEObject || obj instanceof objects_1.WebMIME) {
+            return output;
+        }
         for (const file of obj.getFiles()) {
-            if (file.getFilename().endsWith(".abap")) {
+            const filename = file.getFilename();
+            if (filename.endsWith(".abap") || filename.endsWith(".xml")) {
+                if (filename.endsWith(".xslt.source.xml")) {
+                    continue;
+                }
                 const rows = file.getRawRows();
                 for (let i = 0; i < rows.length; i++) {
                     if (rows[i].endsWith("\r") === true) {

package/build/src/rules/xml_consistency.js

@@ -64,6 +64,8 @@ class XMLConsistency {
 * XML is well-formed and parseable
 * Naming for CLAS and INTF objects
 * QUAN fields in TABL objects have reference table and field values
+* Transparent TABL objects have delivery class and size category set
+* Lock parameter names in ENQU objects are max 16 characters
 * Texts and translations do not exceed maximum allowed length.`,
             tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.Syntax],
         };
@@ -121,6 +123,9 @@ class XMLConsistency {
         else if (obj instanceof Objects.Table) {
             issues.push(...this.runTable(obj, file));
         }
+        else if (obj instanceof Objects.LockObject) {
+            issues.push(...this.runLockObject(obj, file));
+        }
         if (obj instanceof _abap_object_1.ABAPObject) {
             issues.push(...this.runTextPool(obj, file));
         }
@@ -304,16 +309,39 @@ class XMLConsistency {
         }
         return issues;
     }
+    runLockObject(obj, file) {
+        var _a;
+        const maxParameterLength = 16;
+        const issues = [];
+        for (const parameter of (_a = obj.getParameters()) !== null && _a !== void 0 ? _a : []) {
+            if (parameter.VIEWFIELD.length > maxParameterLength) {
+                const message = `Lock parameter ${parameter.VIEWFIELD} exceeds maximum length of ` +
+                    `${maxParameterLength} characters (actual: ${parameter.VIEWFIELD.length})`;
+                issues.push(issue_1.Issue.atRow(file, 1, message, this.getMetadata().key, this.conf.severity));
+            }
+        }
+        return issues;
+    }
     runTable(obj, file) {
-        var _a, _b;
-        var _c;
+        var _a, _b, _c, _d;
+        var _e;
         const issues = [];
-        for (const field of (_c = obj.getFields()) !== null && _c !== void 0 ? _c : []) {
+        for (const field of (_e = obj.getFields()) !== null && _e !== void 0 ? _e : []) {
             if (field.DATATYPE === "QUAN" && (!((_a = field.REFTABLE) === null || _a === void 0 ? void 0 : _a.trim()) || !((_b = field.REFFIELD) === null || _b === void 0 ? void 0 : _b.trim()))) {
                 const message = `QUAN field ${field.FIELDNAME} must have REFTABLE and REFFIELD set`;
                 issues.push(issue_1.Issue.atRow(file, 1, message, this.getMetadata().key, this.conf.severity));
             }
         }
+        if (obj.getTableCategory() === Objects.TableCategory.Transparent) {
+            if (!((_c = obj.getDeliveryClass()) === null || _c === void 0 ? void 0 : _c.trim())) {
+                const message = `Transparent table must have delivery class(CONTFLAG in DD02V) set`;
+                issues.push(issue_1.Issue.atRow(file, 1, message, this.getMetadata().key, this.conf.severity));
+            }
+            if (!((_d = obj.getSizeCategory()) === null || _d === void 0 ? void 0 : _d.trim())) {
+                const message = `Transparent table must have size category(TABKAT in DD09L) set`;
+                issues.push(issue_1.Issue.atRow(file, 1, message, this.getMetadata().key, this.conf.severity));
+            }
+        }
         return issues;
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.120.43",
+    "version": "2.120.45",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",