@abaplint/core 2.120.42 → 2.120.44

package/build/abaplint.d.ts

@@ -558,12 +558,22 @@ declare namespace BasicTypes {
 export { BasicTypes }
 
 declare class BehaviorDefinition extends AbstractObject {
+    private parsedData;
     getType(): string;
     getAllowedNaming(): {
         maxLength: number;
         allowNamespace: boolean;
     };
     getDescription(): string | undefined;
+    setDirty(): void;
+    findSourceFile(): IFile | undefined;
+    listEntities(): readonly {
+        name: string;
+        alias: string | undefined;
+    }[];
+    /** finds the entity name for a given alias, undefined if the alias is not defined */
+    findEntityNameByAlias(alias: string): string | undefined;
+    private parseSource;
 }
 
 declare class BehaviorDefinitionName extends Expression {
@@ -1626,6 +1636,8 @@ export declare class CurrentScope {
     addSQLConversion(fieldName: string, message: string, token: Token): void;
     findFunctionModule(name: string | undefined): FunctionModuleDefinition | undefined;
     findObjectDefinition(name: string | undefined): IClassDefinition | IInterfaceDefinition | undefined;
+    /** the BDEF from "FOR BEHAVIOR OF" of the enclosing global class, undefined if not a behavior pool */
+    findBehaviorDefinition(): BehaviorDefinition | undefined;
     isBadiDef(name: string): boolean;
     existsObject(name: string | undefined): {
         id: Identifier | undefined;
@@ -3888,6 +3900,8 @@ declare interface InfoClassDefinition extends InfoInterfaceDefinition {
     duration: Duration | undefined;
     riskLevel: RiskLevel | undefined;
     isSharedMemory: boolean;
+    /** name of the BDEF from "FOR BEHAVIOR OF", undefined if not a behavior pool */
+    behaviorDefinitionName: string | undefined;
 }
 
 declare interface InfoClassImplementation {
@@ -4599,6 +4613,11 @@ declare class LockObject extends AbstractObject {
     getAllowedNaming(): IAllowedNaming;
     setDirty(): void;
     getPrimaryTable(): string | undefined;
+    getParameters(): {
+        VIEWFIELD: string;
+        TABNAME?: string;
+        FIELDNAME?: string;
+    }[] | undefined;
     parseType(reg: IRegistry): AbstractType;
     parse(): {
         updated: boolean;
@@ -5324,6 +5343,7 @@ declare namespace Objects {
         AuthorizationObjectExtension,
         AuthorizationObject,
         BADIDefinition,
+        ParsedBehaviorDefinition,
         BehaviorDefinition,
         BRFPlusSystemApplication,
         BSPApplication,
@@ -5624,13 +5644,23 @@ declare class ParenRightW extends Token {
     static railroad(): string;
 }
 
+declare type ParsedBehaviorDefinition = {
+    /** entities defined in the behavior definition, alias is undefined if not specified */
+    entities: {
+        name: string;
+        alias: string | undefined;
+    }[];
+};
+
 declare type ParsedDataDefinition = {
     sqlViewName: string | undefined;
     definitionName: string | undefined;
     description: string | undefined;
+    /** name is the name of the element, nameInSource the name in the prefixed source, if aliased via "as" */
     fields: {
         key: boolean;
         name: string;
+        nameInSource?: string;
         prefix: string;
         annotations: string[];
     }[];

package/build/src/abap/2_statements/statements/write.js

@@ -13,7 +13,7 @@ class Write {
         const to = (0, combi_1.seq)("TO", expressions_1.Target);
         const options = (0, combi_1.per)(mask, to, (0, combi_1.seq)("EXPONENT", expressions_1.Source), "NO-GROUPING", "NO-ZERO", "CENTERED", (0, combi_1.seq)("INPUT", (0, combi_1.opt)(onOff)), "NO-GAP", "LEFT-JUSTIFIED", as, (0, combi_1.seq)("FRAMES", onOff), (0, combi_1.seq)("HOTSPOT", (0, combi_1.opt)(onOff)), "RIGHT-JUSTIFIED", (0, combi_1.seq)("TIME ZONE", expressions_1.Source), (0, combi_1.seq)("UNDER", expressions_1.Source), (0, combi_1.seq)("STYLE", expressions_1.Source), (0, combi_1.seq)("ROUND", expressions_1.Source), (0, combi_1.seq)("QUICKINFO", expressions_1.Source), "ENVIRONMENT TIME FORMAT", dateFormat, (0, combi_1.seq)("UNIT", expressions_1.Source), (0, combi_1.seq)("INTENSIFIED", (0, combi_1.opt)(onOff)), (0, combi_1.seq)("INDEX", expressions_1.Source), (0, combi_1.seq)("DECIMALS", expressions_1.Source), (0, combi_1.seq)("INVERSE", (0, combi_1.opt)(onOff)), expressions_1.Color, (0, combi_1.seq)("CURRENCY", expressions_1.Source), "RESET", "NO-SIGN");
         // Need to refactor all this sometime,
-        const ret = (0, combi_1.seq)("WRITE", (0, combi_1.alt)((0, combi_1.seq)("AT /", (0, combi_1.opt)(expressions_1.Source), (0, combi_1.opt)("NO-GAP")), (0, combi_1.seq)((0, combi_1.opt)(expressions_1.WriteOffsetLength), (0, combi_1.alt)(expressions_1.Source, expressions_1.Dynamic, "/"), (0, combi_1.opt)(options))));
+        const ret = (0, combi_1.seq)("WRITE", (0, combi_1.alt)((0, combi_1.seq)("AT /", (0, combi_1.opt)(expressions_1.Source), (0, combi_1.opt)(options)), (0, combi_1.seq)((0, combi_1.opt)(expressions_1.WriteOffsetLength), (0, combi_1.alt)(expressions_1.Source, expressions_1.Dynamic, "/"), (0, combi_1.opt)(options))));
         return (0, combi_1.verNotLang)(version_1.LanguageVersion.Cloud, ret);
     }
 }

package/build/src/abap/4_file_information/abap_file_information_parser.js

@@ -37,6 +37,7 @@ exports.ABAPFileInformationParser = void 0;
 const Structures = __importStar(require("../3_structures/structures"));
 const Expressions = __importStar(require("../2_statements/expressions"));
 const Statements = __importStar(require("../2_statements/statements"));
+const nodes_1 = require("../nodes");
 const _identifier_1 = require("./_identifier");
 const Tokens = __importStar(require("../1_lexer/tokens"));
 const visibility_1 = require("./visibility");
@@ -176,6 +177,7 @@ class ABAPFileInformationParser {
                 riskLevel,
                 isAbstract: (cdef === null || cdef === void 0 ? void 0 : cdef.findDirectTokenByText("ABSTRACT")) !== undefined,
                 isSharedMemory: concat.includes(" SHARED MEMORY ENABLED"),
+                behaviorDefinitionName: this.findBehaviorDefinitionName(cdef),
                 isFinal: found.findFirstExpression(Expressions.ClassFinal) !== undefined,
                 aliases,
                 attributes,
@@ -185,6 +187,20 @@ class ABAPFileInformationParser {
         return classes;
     }
     ///////////////////
+    /** "FOR BEHAVIOR OF" and "FOR EVENTS OF" both use the BehaviorDefinitionName expression,
+     * so look at the token two positions before the expression to tell them apart */
+    findBehaviorDefinitionName(cdef) {
+        const children = (cdef === null || cdef === void 0 ? void 0 : cdef.getChildren()) || [];
+        for (let i = 2; i < children.length; i++) {
+            const child = children[i];
+            if (child instanceof nodes_1.ExpressionNode
+                && child.get() instanceof Expressions.BehaviorDefinitionName
+                && children[i - 2].concatTokens().toUpperCase() === "BEHAVIOR") {
+                return child.concatTokens();
+            }
+        }
+        return undefined;
+    }
     getImplementing(input) {
         const ret = [];
         for (const node of input.findAllStatements(Statements.InterfaceDef)) {

package/build/src/abap/5_syntax/_current_scope.js

@@ -232,6 +232,18 @@ class CurrentScope {
         }
         return undefined;
     }
+    /** the BDEF from "FOR BEHAVIOR OF" of the enclosing global class, undefined if not a behavior pool */
+    findBehaviorDefinition() {
+        var _a;
+        if (this.parentObj.getType() !== "CLAS") {
+            return undefined;
+        }
+        const name = (_a = this.parentObj.getClassDefinition()) === null || _a === void 0 ? void 0 : _a.behaviorDefinitionName;
+        if (name === undefined) {
+            return undefined;
+        }
+        return this.reg.getObject("BDEF", name);
+    }
     isBadiDef(name) {
         const upper = name.toUpperCase();
         for (const enhs of this.reg.getObjectsByType("ENHS")) {

package/build/src/abap/5_syntax/basic_types.js

@@ -345,7 +345,7 @@ class BasicTypes {
         return undefined;
     }
     parseTable(node, name) {
-        var _a, _b, _c, _d;
+        var _a, _b, _c;
         const typename = node.findFirstExpression(Expressions.TypeName) || node.findFirstExpression(Expressions.EntityAssociation);
         const text = (_a = node.findFirstExpression(Expressions.TypeTable)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
         if (text === undefined) {
@@ -482,25 +482,31 @@ class BasicTypes {
             return new Types.TableType(structure, options);
         }
         else if (typename && this.isRAPTableFor(text)) {
-            const name = typename.concatTokens();
-            const ddlsName = this.getRAPBaseEntityName(name);
-            const type = (_d = this.input.scope.getDDIC().lookupDDLS(ddlsName)) === null || _d === void 0 ? void 0 : _d.type;
-            if (type) {
-                return new Types.TableType(basic_1.VoidType.get("RAP-TODO"), options);
-            }
-            else if (this.isRAPDerivedEntityName(name)) {
-                return Types.VoidType.get(name);
-            }
-            else if (this.input.scope.getDDIC().inErrorNamespace(ddlsName)) {
-                return new Types.UnknownType(`DDLS ${ddlsName} not found`);
-            }
-            else {
-                return Types.VoidType.get(name);
-            }
+            return this.rapTableFor(typename.concatTokens(), options);
         }
         // fallback to old style syntax, OCCURS etc
         return this.parseType(node, name);
     }
+    /** type of a RAP derived table type, ie the "TABLE FOR LOCK zentity" part of a type */
+    rapTableFor(entityName, options) {
+        var _a;
+        const ddlsName = this.resolveRAPAlias(this.getRAPBaseEntityName(entityName));
+        if ((_a = this.input.scope.getDDIC().lookupDDLS(ddlsName)) === null || _a === void 0 ? void 0 : _a.type) {
+            return new Types.TableType(basic_1.VoidType.get("RAP-TODO"), options !== null && options !== void 0 ? options : {
+                withHeader: false,
+                keyType: Types.TableKeyType.user,
+                primaryKey: { name: "primary_key", type: basic_1.TableAccessType.standard, isUnique: false, keyFields: [] },
+                secondary: [],
+            });
+        }
+        else if (this.isRAPDerivedEntityName(entityName)) {
+            return Types.VoidType.get(entityName);
+        }
+        else if (this.input.scope.getDDIC().inErrorNamespace(ddlsName)) {
+            return new Types.UnknownType(`DDLS ${ddlsName} not found`);
+        }
+        return Types.VoidType.get(entityName);
+    }
     parseType(node, qualifiedName) {
         var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k;
         const typeName = node.findFirstExpression(Expressions.TypeName);
@@ -694,6 +700,12 @@ class BasicTypes {
         const splitAt = Math.min(...candidates);
         return name.substring(0, splitAt);
     }
+    /** inside a behavior pool the entities are referenced via the aliases defined in the BDEF */
+    resolveRAPAlias(name) {
+        var _a;
+        var _b;
+        return (_b = (_a = this.input.scope.findBehaviorDefinition()) === null || _a === void 0 ? void 0 : _a.findEntityNameByAlias(name)) !== null && _b !== void 0 ? _b : name;
+    }
     isRAPDerivedEntityName(name) {
         return name.includes("\\") || name.includes("~");
     }

package/build/src/abap/types/method_parameters.js

@@ -41,6 +41,7 @@ const _typed_identifier_1 = require("./_typed_identifier");
 const basic_1 = require("./basic");
 const method_def_returning_1 = require("../5_syntax/expressions/method_def_returning");
 const method_param_1 = require("../5_syntax/expressions/method_param");
+const basic_types_1 = require("../5_syntax/basic_types");
 const _object_oriented_1 = require("../5_syntax/_object_oriented");
 const _reference_1 = require("../5_syntax/_reference");
 const identifier_1 = require("../1_lexer/tokens/identifier");
@@ -228,24 +229,37 @@ class MethodParameters {
         }
     }
     workaroundRAP(node, input, parentName) {
+        var _a;
         const resultName = node.findExpressionAfterToken("RESULT");
         const concat = node.concatTokens().toUpperCase();
         const isRap = node.findExpressionAfterToken("IMPORTING")
             || (concat.includes(" IMPORTING REQUEST ") ? node.findExpressionAfterToken("REQUEST") : undefined);
         if (isRap) {
+            // "FOR LOCK" handlers have a well defined signature, so the types can be derived
+            const lockEntity = concat.includes(" FOR LOCK ")
+                ? (_a = node.findExpressionAfterToken("LOCK")) === null || _a === void 0 ? void 0 : _a.concatTokens()
+                : undefined;
             for (const foo of node.findDirectExpressions(Expressions.MethodParamName)) {
                 if (foo === resultName) {
                     continue;
                 }
-                this.importing.push(new _typed_identifier_1.TypedIdentifier(foo.getFirstToken(), input.filename, basic_1.VoidType.get("RapMethodParameter"), ["importing" /* IdentifierMeta.MethodImporting */]));
+                const type = lockEntity === undefined
+                    ? basic_1.VoidType.get("RapMethodParameter")
+                    : new basic_types_1.BasicTypes(input).rapTableFor(lockEntity);
+                this.importing.push(new _typed_identifier_1.TypedIdentifier(foo.getFirstToken(), input.filename, type, ["importing" /* IdentifierMeta.MethodImporting */]));
+            }
+            if (lockEntity !== undefined) {
+                // note: "mapped" is not part of the signature for "FOR LOCK"
+                const token = isRap.getFirstToken();
+                this.exporting.push(new _typed_identifier_1.TypedIdentifier(new identifier_1.Identifier(token.getStart(), "failed"), input.filename, basic_1.VoidType.get(`RESPONSE FOR FAILED EARLY ${lockEntity}`), ["exporting" /* IdentifierMeta.MethodExporting */]));
+                this.exporting.push(new _typed_identifier_1.TypedIdentifier(new identifier_1.Identifier(token.getStart(), "reported"), input.filename, basic_1.VoidType.get(`RESPONSE FOR REPORTED EARLY ${lockEntity}`), ["exporting" /* IdentifierMeta.MethodExporting */]));
             }
-            if (concat.includes(" FOR VALIDATE ")
+            else if (concat.includes(" FOR VALIDATE ")
                 || concat.includes(" FOR BEHAVIOR ")
                 || concat.includes(" FOR DETERMINE ")
                 || concat.includes(" FOR FEATURES ")
                 || concat.includes(" FOR INSTANCE FEATURES ")
                 || concat.includes(" FOR GLOBAL AUTHORIZATION ")
-                || concat.includes(" FOR LOCK ")
                 || concat.includes(" FOR PRECHECK ")
                 || concat.includes(" FOR NUMBERING ")
                 || concat.includes(" FOR READ ")

package/build/src/cds/cds_determine_types.js

@@ -5,6 +5,7 @@ const basic_1 = require("../abap/types/basic");
 const ddic_1 = require("../ddic");
 class CDSDetermineTypes {
     parseType(reg, parsedData, ddlsName) {
+        var _a;
         const ddic = new ddic_1.DDIC(reg);
         if ((parsedData === null || parsedData === void 0 ? void 0 : parsedData.fields.length) === 0) {
             return basic_1.VoidType.get("DDLS:todo");
@@ -41,10 +42,11 @@ class CDSDetermineTypes {
                         });
                         continue;
                     }
+                    const nameInSource = (_a = f.nameInSource) !== null && _a !== void 0 ? _a : f.name;
                     const lookup = ddic.lookupTableOrView(source.name);
                     if (lookup.type) {
                         if (lookup.type instanceof basic_1.StructureType) {
-                            const type = lookup.type.getComponentByName(f.name);
+                            const type = lookup.type.getComponentByName(nameInSource);
                             if (type) {
                                 components.push({
                                     name: f.name,
@@ -54,7 +56,7 @@ class CDSDetermineTypes {
                             else {
                                 components.push({
                                     name: f.name,
-                                    type: new basic_1.UnknownType(f.name + " not found in " + source.name + ", CDSDetermineTypes"),
+                                    type: new basic_1.UnknownType(nameInSource + " not found in " + source.name + ", CDSDetermineTypes"),
                                 });
                             }
                         }

package/build/src/objects/behavior_definition.js

@@ -3,6 +3,10 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.BehaviorDefinition = void 0;
 const _abstract_object_1 = require("./_abstract_object");
 class BehaviorDefinition extends _abstract_object_1.AbstractObject {
+    constructor() {
+        super(...arguments);
+        this.parsedData = undefined;
+    }
     getType() {
         return "BDEF";
     }
@@ -16,6 +20,49 @@ class BehaviorDefinition extends _abstract_object_1.AbstractObject {
         // todo
         return undefined;
     }
+    setDirty() {
+        this.parsedData = undefined;
+        super.setDirty();
+    }
+    findSourceFile() {
+        return this.getFiles().find(f => f.getFilename().endsWith(".asbdef"));
+    }
+    listEntities() {
+        return this.parseSource().entities;
+    }
+    /** finds the entity name for a given alias, undefined if the alias is not defined */
+    findEntityNameByAlias(alias) {
+        var _a;
+        const upper = alias.toUpperCase();
+        for (const entity of this.listEntities()) {
+            if (((_a = entity.alias) === null || _a === void 0 ? void 0 : _a.toUpperCase()) === upper) {
+                return entity.name;
+            }
+        }
+        return undefined;
+    }
+    /////////////////////////
+    parseSource() {
+        var _a;
+        if (this.parsedData !== undefined) {
+            return this.parsedData;
+        }
+        this.parsedData = { entities: [] };
+        const raw = (_a = this.findSourceFile()) === null || _a === void 0 ? void 0 : _a.getRaw();
+        if (raw === undefined) {
+            return this.parsedData;
+        }
+        // BDEF uses "//" for line comments
+        const stripped = raw.replace(/\/\/.*$/gm, "");
+        // eg. "define behavior for ZI_Booking alias Booking", also "define abstract behavior for ..."
+        const regex = /\bdefine\s+(?:\w+\s+)*?behavior\s+for\s+([\w/]+)(?:\s+alias\s+(\w+))?/gi;
+        let match = regex.exec(stripped);
+        while (match !== null) {
+            this.parsedData.entities.push({ name: match[1], alias: match[2] });
+            match = regex.exec(stripped);
+        }
+        return this.parsedData;
+    }
 }
 exports.BehaviorDefinition = BehaviorDefinition;
 //# sourceMappingURL=behavior_definition.js.map

package/build/src/objects/data_definition.js

@@ -138,19 +138,18 @@ class DataDefinition extends _abstract_object_1.AbstractObject {
         }
         for (const e of (expr === null || expr === void 0 ? void 0 : expr.findDirectExpressions(expressions_1.CDSElement)) || []) {
             let prefix = "";
+            let nameInSource = undefined;
             let found = (_a = e.findDirectExpression(expressions_1.CDSAs)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(expressions_1.CDSName);
-            if (found === undefined) {
-                const list = (_b = e.findDirectExpression(expressions_1.CDSPrefixedName)) === null || _b === void 0 ? void 0 : _b.findAllExpressions(expressions_1.CDSName);
-                if (list) {
-                    if (e.concatTokens().toUpperCase().includes(" REDIRECTED TO ")) {
-                        found = list[0];
-                    }
-                    else {
-                        found = list[list.length - 1];
-                        if (list.length > 1) {
-                            prefix = list[0].concatTokens();
-                        }
-                    }
+            const list = (_b = e.findDirectExpression(expressions_1.CDSPrefixedName)) === null || _b === void 0 ? void 0 : _b.findAllExpressions(expressions_1.CDSName);
+            if (list !== undefined) {
+                const redirected = list.length > 1 && e.concatTokens().toUpperCase().includes(" REDIRECTED TO ");
+                if (list.length > 1 && redirected === false) {
+                    // "prefix.field" is looked up as "field" in "prefix", also when aliased via "as"
+                    prefix = list[0].concatTokens();
+                    nameInSource = list[list.length - 1].concatTokens();
+                }
+                if (found === undefined) {
+                    found = redirected === true ? list[0] : list[list.length - 1];
                 }
             }
             if (found === undefined) {
@@ -172,6 +171,7 @@ class DataDefinition extends _abstract_object_1.AbstractObject {
             }
             this.parsedData.fields.push({
                 name: name,
+                nameInSource: nameInSource,
                 annotations: annotations,
                 prefix: prefix,
                 key: e.findDirectTokenByText("KEY") !== undefined,

package/build/src/objects/lock_object.js

@@ -4,6 +4,7 @@ exports.LockObject = void 0;
 const basic_1 = require("../abap/types/basic");
 const ddic_1 = require("../ddic");
 const _abstract_object_1 = require("./_abstract_object");
+const xml_utils_1 = require("../xml_utils");
 class LockObject extends _abstract_object_1.AbstractObject {
     getType() {
         return "ENQU";
@@ -24,6 +25,11 @@ class LockObject extends _abstract_object_1.AbstractObject {
         this.parse();
         return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.primaryTable;
     }
+    getParameters() {
+        var _a;
+        this.parse();
+        return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.parameters;
+    }
     parseType(reg) {
         var _a;
         this.parse();
@@ -48,7 +54,7 @@ class LockObject extends _abstract_object_1.AbstractObject {
         }
     }
     parse() {
-        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k;
+        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o;
         if (this.parsedXML) {
             return { updated: false, runtime: 0 };
         }
@@ -62,6 +68,18 @@ class LockObject extends _abstract_object_1.AbstractObject {
         }
         this.parsedXML.primaryTable = (_f = (_e = (_d = (_c = parsed.abapGit) === null || _c === void 0 ? void 0 : _c["asx:abap"]) === null || _d === void 0 ? void 0 : _d["asx:values"]) === null || _e === void 0 ? void 0 : _e.DD25V) === null || _f === void 0 ? void 0 : _f.ROOTTAB;
         this.parsedXML.description = (_k = (_j = (_h = (_g = parsed.abapGit) === null || _g === void 0 ? void 0 : _g["asx:abap"]) === null || _h === void 0 ? void 0 : _h["asx:values"]) === null || _j === void 0 ? void 0 : _j.DD25V) === null || _k === void 0 ? void 0 : _k.DDTEXT;
+        this.parsedXML.parameters = [];
+        const parameters = (_o = (_m = (_l = parsed.abapGit) === null || _l === void 0 ? void 0 : _l["asx:abap"]) === null || _m === void 0 ? void 0 : _m["asx:values"]) === null || _o === void 0 ? void 0 : _o.DD27P_TABLE;
+        for (const parameter of (0, xml_utils_1.xmlToArray)(parameters === null || parameters === void 0 ? void 0 : parameters.DD27P)) {
+            if (typeof (parameter === null || parameter === void 0 ? void 0 : parameter.VIEWFIELD) !== "string") {
+                continue;
+            }
+            this.parsedXML.parameters.push({
+                VIEWFIELD: parameter.VIEWFIELD,
+                TABNAME: parameter.TABNAME,
+                FIELDNAME: parameter.FIELDNAME,
+            });
+        }
         const end = Date.now();
         return { updated: true, runtime: end - start };
     }

package/build/src/registry.js

@@ -75,7 +75,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.42";
+        return "2.120.44";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/xml_consistency.js

@@ -46,6 +46,8 @@ class XMLConsistencyConf extends _basic_rule_config_1.BasicRuleConfig {
         super(...arguments);
         /** Problem severity for text and translation length checks */
         this.textAndTranslationLengthSeverity = severity_1.Severity.Error;
+        /** Problem severity for data element(DTEL) field checks */
+        this.dataElementSeverity = severity_1.Severity.Error;
     }
 }
 exports.XMLConsistencyConf = XMLConsistencyConf;
@@ -62,6 +64,7 @@ class XMLConsistency {
 * XML is well-formed and parseable
 * Naming for CLAS and INTF objects
 * QUAN fields in TABL objects have reference table and field values
+* Lock parameter names in ENQU objects are max 16 characters
 * Texts and translations do not exceed maximum allowed length.`,
             tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.Syntax],
         };
@@ -119,6 +122,9 @@ class XMLConsistency {
         else if (obj instanceof Objects.Table) {
             issues.push(...this.runTable(obj, file));
         }
+        else if (obj instanceof Objects.LockObject) {
+            issues.push(...this.runLockObject(obj, file));
+        }
         if (obj instanceof _abap_object_1.ABAPObject) {
             issues.push(...this.runTextPool(obj, file));
         }
@@ -254,7 +260,7 @@ class XMLConsistency {
     }
     checkRequiredField(file, fieldName, value) {
         if (value === undefined || value === "") {
-            return issue_1.Issue.atRow(file, 1, `Missing required field ${fieldName} in DD04V`, this.getMetadata().key, this.conf.severity);
+            return issue_1.Issue.atRow(file, 1, `Missing required field ${fieldName} in DD04V`, this.getMetadata().key, this.conf.dataElementSeverity);
         }
         return undefined;
     }
@@ -302,6 +308,19 @@ class XMLConsistency {
         }
         return issues;
     }
+    runLockObject(obj, file) {
+        var _a;
+        const maxParameterLength = 16;
+        const issues = [];
+        for (const parameter of (_a = obj.getParameters()) !== null && _a !== void 0 ? _a : []) {
+            if (parameter.VIEWFIELD.length > maxParameterLength) {
+                const message = `Lock parameter ${parameter.VIEWFIELD} exceeds maximum length of ` +
+                    `${maxParameterLength} characters (actual: ${parameter.VIEWFIELD.length})`;
+                issues.push(issue_1.Issue.atRow(file, 1, message, this.getMetadata().key, this.conf.severity));
+            }
+        }
+        return issues;
+    }
     runTable(obj, file) {
         var _a, _b;
         var _c;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.120.42",
+    "version": "2.120.44",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",