@abaplint/core 2.120.4 → 2.120.6

package/build/abaplint.d.ts

@@ -1259,6 +1259,7 @@ declare class ClassDefinition_3 extends Identifier implements IClassDefinition {
     private findSuper;
     private checkMethodNameLength;
     private checkClassConstructorStatic;
+    private checkInterfaceVisibility;
     private checkMethodsFromSuperClasses;
     private findFriends;
     private addReference;
@@ -7850,8 +7851,8 @@ export declare class SyntaxLogic {
     private issues;
     private readonly object;
     private readonly reg;
-    private readonly scope;
-    private readonly helpers;
+    private scope;
+    private helpers;
     constructor(reg: IRegistry, object: ABAPObject);
     run(): ISyntaxResult;
     private traverseObject;

package/build/src/abap/5_syntax/expressions/cond_body.js

@@ -57,7 +57,7 @@ class CondBody {
                 type = source_1.Source.runSyntax(s, input, targetType);
             }
             else {
-                source_1.Source.runSyntax(s, input, targetType);
+                source_1.Source.runSyntax(s, input, targetType !== null && targetType !== void 0 ? targetType : type);
             }
         }
         if (scoped === true) {

package/build/src/abap/5_syntax/expressions/inline_data.js

@@ -43,6 +43,10 @@ class InlineData {
     static runSyntax(node, input, type) {
         var _a;
         const token = (_a = node.findFirstExpression(Expressions.TargetField)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
+        if (token && token.getStr().length > 30) {
+            const message = "DATA name too long, " + token.getStr();
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, token, message));
+        }
         if (token && type) {
             if (type instanceof basic_1.CSequenceType || type instanceof basic_1.CLikeType) {
                 type = basic_1.StringType.get();

package/build/src/abap/5_syntax/expressions/inline_fs.js

@@ -38,10 +38,16 @@ const Expressions = __importStar(require("../../2_statements/expressions"));
 const _typed_identifier_1 = require("../../types/_typed_identifier");
 const basic_1 = require("../../types/basic");
 const _reference_1 = require("../_reference");
+const _syntax_input_1 = require("../_syntax_input");
 class InlineFS {
     static runSyntax(node, input, type) {
         var _a;
         const token = (_a = node.findFirstExpression(Expressions.TargetFieldSymbol)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
+        const fs = node.findFirstExpression(Expressions.FieldSymbol);
+        if (fs && fs.concatTokens().length > 30) {
+            const message = "FIELD-SYMBOLS name too long, " + fs.concatTokens();
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, fs.getFirstToken(), message));
+        }
         if (token && type) {
             const identifier = new _typed_identifier_1.TypedIdentifier(token, input.filename, type, ["inline" /* IdentifierMeta.InlineDefinition */]);
             input.scope.addIdentifier(identifier);

package/build/src/abap/5_syntax/expressions/source.js

@@ -117,7 +117,7 @@ class Source {
                 case "SWITCH":
                     {
                         const foundType = this.determineType(node, input, targetType);
-                        const bodyType = switch_body_1.SwitchBody.runSyntax(node.findDirectExpression(Expressions.SwitchBody), input);
+                        const bodyType = switch_body_1.SwitchBody.runSyntax(node.findDirectExpression(Expressions.SwitchBody), input, foundType);
                         if (foundType === undefined || foundType.isGeneric()) {
                             this.addIfInferred(node, input, bodyType);
                         }

package/build/src/abap/5_syntax/expressions/switch_body.js

@@ -39,7 +39,7 @@ const source_1 = require("./source");
 const _syntax_input_1 = require("../_syntax_input");
 const basic_1 = require("../../types/basic");
 class SwitchBody {
-    static runSyntax(node, input) {
+    static runSyntax(node, input, targetType) {
         if (node === undefined) {
             return;
         }
@@ -49,12 +49,12 @@ class SwitchBody {
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
             return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
         }
-        const type = source_1.Source.runSyntax(thenSource, input);
+        const type = source_1.Source.runSyntax(thenSource, input, targetType);
         for (const s of node.findDirectExpressions(Expressions.Source)) {
             if (s === thenSource) {
                 continue;
             }
-            source_1.Source.runSyntax(s, input);
+            source_1.Source.runSyntax(s, input, targetType !== null && targetType !== void 0 ? targetType : type);
         }
         return type;
     }

package/build/src/abap/5_syntax/statements/at_selection_screen.js

@@ -0,0 +1,59 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.AtSelectionScreen = void 0;
+const Expressions = __importStar(require("../../2_statements/expressions"));
+const _reference_1 = require("../_reference");
+const source_field_1 = require("../expressions/source_field");
+class AtSelectionScreen {
+    runSyntax(node, input) {
+        // "AT SELECTION-SCREEN ON <field>", "ON VALUE-REQUEST FOR <field>",
+        // "ON HELP-REQUEST FOR <field>" and "ON END OF <field>" all reference
+        // a parameter or select-option, register these as read references so
+        // they are not reported as unused.
+        const fields = [
+            ...node.findDirectExpressions(Expressions.FieldSub),
+            ...node.findDirectExpressions(Expressions.Field),
+        ];
+        for (const field of fields) {
+            const token = field.getFirstToken();
+            if (input.scope.findVariable(token.getStr()) !== undefined) {
+                source_field_1.SourceField.runSyntax(field, input, _reference_1.ReferenceType.DataReadReference, false);
+            }
+        }
+    }
+}
+exports.AtSelectionScreen = AtSelectionScreen;
+//# sourceMappingURL=at_selection_screen.js.map

package/build/src/abap/5_syntax/statements/constant.js

@@ -53,6 +53,10 @@ class Constant {
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, found.getToken(), message));
                 return new _typed_identifier_1.TypedIdentifier(found.getToken(), input.filename, basic_2.VoidType.get(_syntax_input_1.CheckSyntaxKey), meta, val);
             }
+            if (this.isNameTooLong(found.getName())) {
+                const message = "CONSTANTS name too long, " + found.getName();
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, found.getToken(), message));
+            }
             return new _typed_identifier_1.TypedIdentifier(found.getToken(), input.filename, found.getType(), meta, val);
         }
         const fallback = node.findFirstExpression(Expressions.DefinitionName);
@@ -61,10 +65,17 @@ class Constant {
                 const message = "not possible to have a name with only digits";
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, fallback.getFirstToken(), message));
             }
+            if (this.isNameTooLong(fallback.concatTokens())) {
+                const message = "CONSTANTS name too long, " + fallback.concatTokens();
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, fallback.getFirstToken(), message));
+            }
             return new _typed_identifier_1.TypedIdentifier(fallback.getFirstToken(), input.filename, new basic_1.UnknownType("constant, fallback"));
         }
         throw new assert_error_1.AssertError("Statement Constant: unexpected structure");
     }
+    isNameTooLong(name) {
+        return name.length > 30;
+    }
     isOnlyDigits(name) {
         return /^[0-9]+$/.test(name);
     }

package/build/src/abap/5_syntax/statements/data.js

@@ -51,6 +51,10 @@ class Data {
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, id.getToken(), message));
                 return new _typed_identifier_1.TypedIdentifier(id.getToken(), input.filename, basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey));
             }
+            if (id && this.isNameTooLong(id.getName())) {
+                const message = "DATA name too long, " + id.getName();
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, id.getToken(), message));
+            }
             if ((id === null || id === void 0 ? void 0 : id.getType().isGeneric()) === true
                 && (id === null || id === void 0 ? void 0 : id.getType().containsVoid()) === false) {
                 const message = "DATA definition cannot be generic, " + (name === null || name === void 0 ? void 0 : name.concatTokens());
@@ -64,10 +68,17 @@ class Data {
                 const message = "not possible to have a name with only digits";
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, name.getFirstToken(), message));
             }
+            if (this.isNameTooLong(name.concatTokens())) {
+                const message = "DATA name too long, " + name.concatTokens();
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, name.getFirstToken(), message));
+            }
             return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), input.filename, new unknown_type_1.UnknownType("data, fallback"));
         }
         return undefined;
     }
+    isNameTooLong(name) {
+        return name.length > 30;
+    }
     isOnlyDigits(name) {
         return /^[0-9]+$/.test(name);
     }

package/build/src/abap/5_syntax/statements/fieldsymbol.js

@@ -38,14 +38,19 @@ const Expressions = __importStar(require("../../2_statements/expressions"));
 const _typed_identifier_1 = require("../../types/_typed_identifier");
 const basic_types_1 = require("../basic_types");
 const unknown_type_1 = require("../../types/basic/unknown_type");
+const _syntax_input_1 = require("../_syntax_input");
 const basic_1 = require("../../types/basic");
 class FieldSymbol {
     runSyntax(node, input) {
-        var _a;
-        const fsname = (_a = node.findFirstExpression(Expressions.FieldSymbol)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
-        if (fsname === undefined) {
+        const fs = node.findFirstExpression(Expressions.FieldSymbol);
+        const fsname = fs === null || fs === void 0 ? void 0 : fs.getFirstToken();
+        if (fs === undefined || fsname === undefined) {
             return;
         }
+        if (fs.concatTokens().length > 30) {
+            const message = "FIELD-SYMBOLS name too long, " + fs.concatTokens();
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, fsname, message));
+        }
         if (node.getChildren().length === 5) {
             // no type specified
             input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(fsname, input.filename, basic_1.VoidType.get("FS-SIMPLE")));

package/build/src/abap/5_syntax/syntax.js

@@ -90,6 +90,7 @@ const if_1 = require("./statements/if");
 const else_if_1 = require("./statements/else_if");
 const append_1 = require("./statements/append");
 const selection_screen_1 = require("./statements/selection_screen");
+const at_selection_screen_1 = require("./statements/at_selection_screen");
 const ranges_1 = require("./statements/ranges");
 const write_1 = require("./statements/write");
 const case_1 = require("./statements/case");
@@ -297,6 +298,7 @@ if (Object.keys(map).length === 0) {
     addToMap(new authority_check_1.AuthorityCheck());
     addToMap(new insert_report_1.InsertReport());
     addToMap(new selection_screen_1.SelectionScreen());
+    addToMap(new at_selection_screen_1.AtSelectionScreen());
     addToMap(new ranges_1.Ranges());
     addToMap(new add_1.Add());
     addToMap(new raise_event_1.RaiseEvent());
@@ -335,16 +337,17 @@ class SyntaxLogic {
         this.reg = reg;
         this.issues = [];
         this.object = object;
-        this.scope = _current_scope_1.CurrentScope.buildDefault(this.reg, object);
-        this.helpers = {
-            oooc: new _object_oriented_1.ObjectOriented(this.scope),
-            proc: new _procedural_1.Procedural(this.reg, this.scope),
-        };
     }
     run() {
         if (this.object.syntaxResult !== undefined) {
             return this.object.syntaxResult;
         }
+        // the scope is built here instead of in the constructor, cached results must stay cheap
+        this.scope = _current_scope_1.CurrentScope.buildDefault(this.reg, this.object);
+        this.helpers = {
+            oooc: new _object_oriented_1.ObjectOriented(this.scope),
+            proc: new _procedural_1.Procedural(this.reg, this.scope),
+        };
         this.issues = [];
         this.reg.getDDICReferences().clear(this.object);
         this.reg.getMSAGReferences().clear(this.object);

package/build/src/abap/types/class_definition.js

@@ -95,6 +95,7 @@ class ClassDefinition extends _identifier_1.Identifier {
             this.createVisibilityValue = visibility_1.Visibility.Public;
         }
         // perform checks after everything has been initialized
+        this.checkInterfaceVisibility(input, node);
         this.checkMethodsFromSuperClasses(input);
         this.checkMethodNameLength(input);
         this.checkClassConstructorStatic(input);
@@ -168,6 +169,17 @@ class ClassDefinition extends _identifier_1.Identifier {
             }
         }
     }
+    checkInterfaceVisibility(input, node) {
+        const sections = [
+            node.findDirectStructure(Structures.ProtectedSection),
+            node.findDirectStructure(Structures.PrivateSection),
+        ];
+        for (const section of sections) {
+            for (const statement of (section === null || section === void 0 ? void 0 : section.findAllStatements(Statements.InterfaceDef)) || []) {
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, statement.getFirstToken(), "INTERFACES can only be declared in public sections"));
+            }
+        }
+    }
     checkMethodsFromSuperClasses(input) {
         var _a;
         const scope = input.scope;

package/build/src/registry.js

@@ -75,7 +75,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.4";
+        return "2.120.6";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/unused_variables.js

@@ -59,35 +59,38 @@ class UnusedVariablesConf extends _basic_rule_config_1.BasicRuleConfig {
 exports.UnusedVariablesConf = UnusedVariablesConf;
 class WorkArea {
     constructor() {
-        this.workarea = [];
+        // keyed by filename + start position, this equals Identifier.equals()
+        this.workarea = new Map();
     }
     push(id, count = 1) {
-        for (const w of this.workarea) {
-            if (id.equals(w.id)) {
-                return;
-            }
+        const key = this.buildKey(id);
+        if (this.workarea.has(key)) {
+            return;
         }
-        this.workarea.push({ id, count });
+        this.workarea.set(key, { id, count });
     }
     removeIfExists(id) {
         if (id === undefined) {
             return;
         }
-        for (let i = 0; i < this.workarea.length; i++) {
-            if (id.equals(this.workarea[i].id)) {
-                this.workarea[i].count--;
-                if (this.workarea[i].count === 0) {
-                    this.workarea.splice(i, 1);
-                }
-                return;
+        const key = this.buildKey(id);
+        const found = this.workarea.get(key);
+        if (found !== undefined) {
+            found.count--;
+            if (found.count === 0) {
+                this.workarea.delete(key);
             }
         }
     }
     get() {
-        return this.workarea;
+        return [...this.workarea.values()];
     }
     count() {
-        return this.workarea.length;
+        return this.workarea.size;
+    }
+    buildKey(id) {
+        const start = id.getStart();
+        return id.getFilename() + "," + start.getRow() + "," + start.getCol();
     }
 }
 class UnusedVariables {
@@ -221,6 +224,9 @@ Errors found in INCLUDES are reported for the main program.`,
     }
     buildIssues(obj) {
         const ret = [];
+        const metadata = this.getMetadata();
+        const pragma = metadata.pragma + "";
+        const files = new Map();
         for (const w of this.workarea.get()) {
             const filename = w.id.getFilename();
             if (this.reg.isFileDependency(filename) === true) {
@@ -229,41 +235,51 @@ Errors found in INCLUDES are reported for the main program.`,
             else if (obj instanceof objects_1.Program === false && obj.containsFile(filename) === false) {
                 continue;
             }
-            const statement = this.findStatement(w.id);
-            if (statement === null || statement === void 0 ? void 0 : statement.getPragmas().map(t => t.getStr()).includes(this.getMetadata().pragma + "")) {
-                continue;
+            if (files.has(filename) === false) {
+                files.set(filename, this.findFile(filename));
             }
-            else if (this.suppressedbyPseudo(statement, w.id, obj)) {
-                continue;
+            const file = files.get(filename);
+            let statement = undefined;
+            let statementIndex = -1;
+            if (file !== undefined) {
+                const statements = file.getStatements();
+                const token = w.id.getToken();
+                for (let i = 0; i < statements.length; i++) {
+                    if (statements[i].includesToken(token)) {
+                        statement = statements[i];
+                        statementIndex = i;
+                        break;
+                    }
+                }
+            }
+            if (statement !== undefined && file !== undefined) {
+                if (statement.getPragmas().some(t => t.getStr() === pragma)) {
+                    continue;
+                }
+                else if (this.suppressedbyPseudo(file, statementIndex, w.id, obj)) {
+                    continue;
+                }
             }
             const name = w.id.getName();
             const message = "Variable \"" + name.toLowerCase() + "\" not used";
-            const fix = this.buildFix(w.id, obj);
-            ret.push(issue_1.Issue.atIdentifier(w.id, message, this.getMetadata().key, this.conf.severity, fix));
+            const fix = this.buildFix(w.id, obj, statement);
+            ret.push(issue_1.Issue.atIdentifier(w.id, message, metadata.key, this.conf.severity, fix));
         }
         return ret;
     }
-    suppressedbyPseudo(statement, v, obj) {
-        if (statement === undefined) {
+    suppressedbyPseudo(file, statementIndex, v, obj) {
+        // pseudo comments are only found in files belonging to the object itself, not in eg. includes
+        if (obj.getABAPFileByName(v.getFilename()) === undefined) {
             return false;
         }
-        const file = obj.getABAPFileByName(v.getFilename());
-        if (file === undefined) {
-            return false;
-        }
-        let next = false;
-        for (const s of file.getStatements()) {
-            if (next === true && s.get() instanceof _statement_1.Comment) {
-                return s.concatTokens().includes(this.getMetadata().pseudoComment + "");
-            }
-            if (s === statement) {
-                next = true;
-            }
-        }
+        const statements = file.getStatements();
+        const next = statements[statementIndex + 1];
+        return (next === null || next === void 0 ? void 0 : next.get()) instanceof _statement_1.Comment
+            && next.concatTokens().includes(this.getMetadata().pseudoComment + "");
         return false;
     }
-    findStatement(v) {
-        const file = this.reg.getFileByName(v.getFilename());
+    findFile(filename) {
+        const file = this.reg.getFileByName(filename);
         if (file === undefined) {
             return undefined;
         }
@@ -271,26 +287,17 @@ Errors found in INCLUDES are reported for the main program.`,
         if (!(object instanceof _abap_object_1.ABAPObject)) {
             return undefined;
         }
-        const abapfile = object.getABAPFileByName(v.getFilename());
-        if (abapfile === undefined) {
+        return object.getABAPFileByName(filename);
+    }
+    buildFix(v, obj, statement) {
+        if (statement === undefined || !(statement.get() instanceof Statements.Data)) {
             return undefined;
         }
-        const statement = edit_helper_1.EditHelper.findStatement(v.getToken(), abapfile);
-        return statement;
-    }
-    buildFix(v, obj) {
         const file = obj.getABAPFileByName(v.getFilename());
         if (file === undefined) {
             return undefined;
         }
-        const statement = edit_helper_1.EditHelper.findStatement(v.getToken(), file);
-        if (statement === undefined) {
-            return undefined;
-        }
-        else if (statement.get() instanceof Statements.Data) {
-            return edit_helper_1.EditHelper.deleteStatement(file, statement);
-        }
-        return undefined;
+        return edit_helper_1.EditHelper.deleteStatement(file, statement);
     }
 }
 exports.UnusedVariables = UnusedVariables;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.120.4",
+    "version": "2.120.6",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",