@abaplint/core 2.120.36 → 2.120.38

package/build/abaplint.d.ts

@@ -3559,6 +3559,7 @@ export declare const enum IdentifierMeta {
     FunctionModuleTables = "function_module_tables",
     EventParameter = "event_parameter",
     FormParameter = "form_parameter",
+    FormParameterStructure = "form_parameter_structure",
     ReadOnly = "read_only",
     Tables = "tables",
     Abstract = "abstract",

package/build/src/abap/2_statements/expressions/type_param.js

@@ -3,6 +3,8 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.TypeParam = void 0;
 const combi_1 = require("../combi");
 const _1 = require(".");
+const version_1 = require("../../../version");
+const _derived_types_1 = require("./_derived_types");
 class TypeParam extends combi_1.Expression {
     getRunnable() {
         const table = (0, combi_1.seq)((0, combi_1.altPrio)("STANDARD", "HASHED", "INDEX", "SORTED", "ANY"), "TABLE");
@@ -10,7 +12,10 @@ class TypeParam extends combi_1.Expression {
         const typeLine = "LINE OF";
         const ret = (0, combi_1.seq)((0, combi_1.alt)(foo, typeLine), _1.TypeNameOrInfer, (0, combi_1.opt)(_1.Default));
         const like = (0, combi_1.seq)("LIKE", (0, combi_1.opt)("LINE OF"), _1.FieldChain, (0, combi_1.optPrio)(_1.Default));
-        return (0, combi_1.alt)((0, combi_1.seq)("TYPE", (0, combi_1.alt)(table, ret)), like);
+        const entity = (0, combi_1.alt)(_1.TypeName, _1.EntityAssociation);
+        const rapTable = (0, combi_1.ver)(version_1.Release.v770, (0, combi_1.seq)("TYPE", "TABLE FOR", (0, _derived_types_1.derivedTypesAlt)((0, combi_1.ver)(version_1.Release.v773, (0, combi_1.seq)("ACTION IMPORT", entity), { also: combi_1.AlsoIn.OpenABAP }), (0, combi_1.ver)(version_1.Release.v774, (0, combi_1.seq)("READ LINK", entity), { also: combi_1.AlsoIn.OpenABAP }), (0, combi_1.ver)(version_1.Release.v787, (0, combi_1.seq)("EVENT", entity), { also: combi_1.AlsoIn.OpenABAP })), (0, combi_1.optPrio)("VALUE IS INITIAL")), { also: combi_1.AlsoIn.OpenABAP });
+        // Method parameters also allow the RAP table and response type forms.
+        return (0, combi_1.altPrio)(rapTable, _1.TypeStructure, (0, combi_1.seq)("TYPE", (0, combi_1.alt)(table, ret)), like);
     }
 }
 exports.TypeParam = TypeParam;

package/build/src/abap/5_syntax/_type_utils.js

@@ -575,6 +575,29 @@ class TypeUtils {
         }
         return this.isAssignable(source, target);
     }
+    // Typing with the classic STRUCTURE addition, ie. "FORM foo USING bar STRUCTURE zkey",
+    // is not a compatibility check: ABAP only checks the fragment view up to the end of the
+    // formal structure, so the actual parameter is allowed to be longer. For TABLES parameters
+    // the table key is not part of the check at all.
+    isAssignableStructureTyping(source, target, node) {
+        if (source instanceof basic_1.StructureType && target instanceof basic_1.StructureType) {
+            const sourceComponents = source.getComponents();
+            const targetComponents = target.getComponents();
+            if (sourceComponents.length < targetComponents.length) {
+                return false;
+            }
+            for (let i = 0; i < targetComponents.length; i++) {
+                if (this.isAssignableStrict(sourceComponents[i].type, targetComponents[i].type) === false) {
+                    return false;
+                }
+            }
+            return true;
+        }
+        else if (source instanceof basic_1.TableType && target instanceof basic_1.TableType) {
+            return this.isAssignableStructureTyping(source.getRowType(), target.getRowType());
+        }
+        return this.isAssignableStrict(source, target, node);
+    }
     isAssignable(source, target) {
         if (source === undefined || target === undefined) {
             return true;

package/build/src/abap/5_syntax/expressions/form_param.js

@@ -31,7 +31,7 @@ class FormParam {
             else {
                 type = new basic_1.UnknownType("todo, FORM STRUCTURES typing");
             }
-            return new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, type, ["form_parameter" /* IdentifierMeta.FormParameter */]);
+            return new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, type, ["form_parameter" /* IdentifierMeta.FormParameter */, "form_parameter_structure" /* IdentifierMeta.FormParameterStructure */]);
         }
         if (node.getChildren().length === 1 && nameToken) {
             // untyped FORM parameter

package/build/src/abap/5_syntax/statements/perform.js

@@ -113,7 +113,11 @@ class Perform {
                 continue;
             }
             const parameter = formal[i];
-            if (typeUtils.isAssignableStrict(type, parameter.getType(), source) === false) {
+            const structureTyping = parameter.getMeta().includes("form_parameter_structure" /* IdentifierMeta.FormParameterStructure */);
+            const assignable = structureTyping
+                ? typeUtils.isAssignableStructureTyping(type, parameter.getType(), source)
+                : typeUtils.isAssignableStrict(type, parameter.getType(), source);
+            if (assignable === false) {
                 const message = `PERFORM parameter type not compatible, ${parameter.getName()}`;
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, source.getFirstToken(), message));
                 return false;

package/build/src/abap/types/form_definition.js

@@ -90,7 +90,8 @@ class FormDefinition extends _identifier_1.Identifier {
                 else if (!(type instanceof basic_1.UnknownType) && !(type instanceof basic_1.VoidType)) {
                     type = new basic_1.UnknownType("FORM TABLES type must be table type");
                 }
-                ret.push(new _typed_identifier_1.TypedIdentifier(p.getToken(), input.filename, type, ["form_parameter" /* IdentifierMeta.FormParameter */]));
+                // keep the meta from FormParam, so STRUCTURE typing can be recognized later
+                ret.push(new _typed_identifier_1.TypedIdentifier(p.getToken(), input.filename, type, p.getMeta()));
             }
         }
         return ret;

package/build/src/registry.js

@@ -75,7 +75,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.36";
+        return "2.120.38";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/chain_mainly_declarations.js

@@ -137,6 +137,7 @@ https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/abenchained_stat
                     || statement instanceof Statements.Ranges
                     || statement instanceof Statements.TypePools
                     || statement instanceof Statements.FieldSymbol
+                    || statement instanceof Statements.Nodes
                     || statement instanceof Statements.Data
                     || statement instanceof Statements.DataBegin
                     || statement instanceof Statements.DataEnd)) {

package/build/src/stuff.js

@@ -37,6 +37,7 @@ exports.DECLARATION_STUFF = exports.SELECTION_EVENTS = void 0;
 const Statements = __importStar(require("./abap/2_statements/statements"));
 exports.SELECTION_EVENTS = [
     Statements.StartOfSelection,
+    Statements.Get,
     Statements.AtSelectionScreen,
     Statements.AtLineSelection,
     Statements.AtPF,

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.120.36",
+    "version": "2.120.38",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",