@abaplint/core 2.120.33 → 2.120.35

package/build/abaplint.d.ts

@@ -429,6 +429,8 @@ declare class Attributes implements IAttributes {
     private parse;
     private parseSection;
     private parseAlias;
+    /** does the component exist in the interface, or in one of its aliases or included interfaces? */
+    private existsInInterface;
     private parseAttribute;
 }
 

package/build/src/abap/5_syntax/_object_oriented.js

@@ -204,6 +204,11 @@ class ObjectOriented {
         if (found) {
             return found;
         }
+        if (name.includes("~")) {
+            // event of an implemented interface, ie. "if_name~event_name"
+            const [interfaceName, eventName] = name.split("~");
+            return this.searchEvent(this.scope.findInterfaceDefinition(interfaceName), eventName);
+        }
         for (const a of def.getAliases() || []) {
             if (a.getName().toUpperCase() === name.toUpperCase()) {
                 const comp = a.getComponent();

package/build/src/abap/5_syntax/_type_utils.js

@@ -454,6 +454,11 @@ class TypeUtils {
                 }
                 return false;
             }
+            else if (target instanceof basic_1.TableType
+                || target instanceof basic_1.DataReference
+                || target instanceof basic_1.ObjectReferenceType) {
+                return false;
+            }
             return true;
         }
         else if (source instanceof basic_1.StructureType) {
@@ -478,7 +483,8 @@ class TypeUtils {
             }
             else if (target instanceof basic_1.VoidType
                 || target instanceof basic_1.AnyType
-                || target instanceof basic_1.DataType) {
+                || target instanceof basic_1.DataType
+                || target instanceof basic_1.UnknownType) {
                 return true;
             }
             return false;

package/build/src/abap/types/class_attributes.js

@@ -52,6 +52,7 @@ const constants_1 = require("../5_syntax/structures/constants");
 const type_definitions_1 = require("./type_definitions");
 const types_1 = require("../5_syntax/structures/types");
 const type_1 = require("../5_syntax/statements/type");
+const _syntax_input_1 = require("../5_syntax/_syntax_input");
 const _reference_1 = require("../5_syntax/_reference");
 const alias_1 = require("./alias");
 class Attributes {
@@ -273,6 +274,13 @@ class Attributes {
                 if (foundAttribute) {
                     input.scope.addNamedIdentifier(aliasName.getStr(), foundAttribute);
                 }
+                const component = compName.split("~")[1];
+                if (foundType === undefined
+                    && foundAttribute === undefined
+                    && this.existsInInterface(idef, component, input, []) === false) {
+                    const message = "Component " + component + " not found in interface " + idef.getName();
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, compToken, message));
+                }
             }
             else if (this.declaredInterfaces.includes(name.toUpperCase()) || input.scope.getDDIC().inErrorNamespace(name) === false) {
                 input.scope.addReference(compToken, undefined, _reference_1.ReferenceType.ObjectOrientedVoidReference, input.filename);
@@ -282,6 +290,33 @@ class Attributes {
             }
         }
     }
+    /** does the component exist in the interface, or in one of its aliases or included interfaces? */
+    existsInInterface(idef, component, input, visited) {
+        const upperName = idef.getName().toUpperCase();
+        if (visited.includes(upperName)) {
+            return false;
+        }
+        visited.push(upperName);
+        const upper = component.toUpperCase();
+        if (idef.getTypeDefinitions().getByName(component) !== undefined
+            || idef.getAttributes().findByName(component) !== undefined
+            || idef.getMethodDefinitions().getByName(component) !== undefined
+            || idef.getEvents().some(e => e.getName().toUpperCase() === upper)
+            || idef.getAliases().some(a => a.getName().toUpperCase() === upper)) {
+            return true;
+        }
+        for (const i of idef.getImplementing()) {
+            const sub = input.scope.findInterfaceDefinition(i.name);
+            if (sub === undefined) {
+                // voided or not found, assume the component exists
+                return true;
+            }
+            else if (this.existsInInterface(sub, component, input, visited)) {
+                return true;
+            }
+        }
+        return false;
+    }
     parseAttribute(node, visibility, input) {
         let found = undefined;
         const s = node.get();

package/build/src/registry.js

@@ -75,7 +75,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.120.33";
+        return "2.120.35";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/cds_field_order.js

@@ -88,7 +88,8 @@ class CDSFieldOrder {
     }
     getAssociationNames(tree) {
         const names = new Set();
-        for (const assoc of tree.findAllExpressions(expressions_1.CDSAssociation)) {
+        const found = [...tree.findAllExpressions(expressions_1.CDSAssociation), ...tree.findAllExpressions(expressions_1.CDSComposition)];
+        for (const assoc of found) {
             const relation = assoc.findDirectExpression(expressions_1.CDSRelation);
             if (relation === undefined) {
                 continue;

package/build/src/rules/cds_naming.js

@@ -6,7 +6,6 @@ const _irule_1 = require("./_irule");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const objects_1 = require("../objects");
 const expressions_1 = require("../cds/expressions");
-const cds_name_1 = require("../cds/expressions/cds_name");
 class CDSNamingConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
         super(...arguments);
@@ -78,7 +77,7 @@ https://help.sap.com/docs/SAP_S4HANA_ON-PREMISE/ee6ff9b281d8448f96b4fe6c89f2bdc8
         if (file === undefined) {
             return [];
         }
-        const name = this.getCDSName(tree);
+        const name = o.getDefinitionName();
         if (name === undefined) {
             return [];
         }
@@ -95,13 +94,6 @@ https://help.sap.com/docs/SAP_S4HANA_ON-PREMISE/ee6ff9b281d8448f96b4fe6c89f2bdc8
         }
         return [];
     }
-    getCDSName(tree) {
-        const nameNodes = tree.findDirectExpressions(cds_name_1.CDSName);
-        if (nameNodes.length > 0) {
-            return nameNodes[0].getFirstToken().getStr();
-        }
-        return undefined;
-    }
     getAllowedPrefixes(tree) {
         const root = tree.get();
         if (root instanceof expressions_1.CDSExtendView) {

package/build/src/rules/no_dynamic_stuff.js

@@ -85,17 +85,19 @@ class NoDynamicStuff extends _abap_rule_1.ABAPRule {
             extendedInformation: `Dynamic constructs cannot be checked statically, they are not found by
 where-used lists and refactorings, and they can introduce injection vulnerabilities.
 
-Dynamic tokens containing a literal, eg. CALL METHOD ('CL_FOO')=>('BAR'), are not reported,
-as these are equivalent to the static variant.
+Dynamic tokens are also reported when containing a literal, eg. CALL METHOD go_calendar->('RESET_DAY_INFO'),
+the syntax check does not resolve these either, so they behave like any other dynamic token.
 
 Dynamic SQL is reported by rule dangerous_statement.`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
             badExample: `CALL METHOD (lv_class)=>(lv_method).
+CALL METHOD go_calendar->('RESET_DAY_INFO').
 CALL FUNCTION lv_function_module.
 CREATE OBJECT ref TYPE (lv_class).
 ASSIGN (lv_name) TO <fs>.
 SORT tab BY (lv_field).`,
             goodExample: `cl_class=>method( ).
+go_calendar->reset_day_info( ).
 CALL FUNCTION 'ZFOO'.
 CREATE OBJECT ref TYPE cl_class.
 ASSIGN foo TO <fs>.
@@ -207,10 +209,8 @@ SORT tab BY field.`,
         for (const source of node.findAllExpressions(Expressions.MethodSource)) {
             // Dynamic is always a direct child of MethodSource, dynamics further down
             // are parameters of the method call and not part of the method name
-            for (const dynamic of source.findDirectExpressions(Expressions.Dynamic)) {
-                if (this.isLiteral(dynamic) === false) {
-                    return true;
-                }
+            if (source.findDirectExpression(Expressions.Dynamic) !== undefined) {
+                return true;
             }
         }
         return false;
@@ -221,12 +221,7 @@ SORT tab BY field.`,
         return component !== undefined && this.isLiteral(component) === false;
     }
     hasDynamic(node) {
-        for (const dynamic of node.findAllExpressions(Expressions.Dynamic)) {
-            if (this.isLiteral(dynamic) === false) {
-                return true;
-            }
-        }
-        return false;
+        return node.findFirstExpression(Expressions.Dynamic) !== undefined;
     }
     notLiteral(node) {
         return node !== undefined && this.isLiteral(node) === false;

package/build/src/stuff.js

@@ -56,6 +56,10 @@ exports.DECLARATION_STUFF = [
     Statements.DataBegin,
     Statements.Constant,
     Statements.ConstantBegin,
+    Statements.Static,
+    Statements.StaticBegin,
+    Statements.FieldSymbol,
+    Statements.Ranges,
     Statements.Tables,
     Statements.Include, // this is not super correct, but anyhow
     Statements.Parameter,

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.120.33",
+    "version": "2.120.35",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",