@abaplint/core 2.119.67 → 2.120.1

package/build/abaplint.d.ts

@@ -1491,7 +1491,7 @@ export declare class Config implements IConfiguration {
     getGlobal(): IGlobalConfig;
     getSyntaxSetttings(): ISyntaxSettings;
     getRelease(): ABAPRelease;
-    getOpenABAP(): boolean;
+    isOpenABAP(): boolean;
     getVersion(): Version;
     getLanguageVersion(): LanguageVersion;
     private checkVersion;
@@ -3475,7 +3475,7 @@ export declare interface IConfiguration {
     getVersion(): Version;
     getRelease(): ABAPRelease;
     getLanguageVersion(): LanguageVersion;
-    getOpenABAP(): boolean;
+    isOpenABAP(): boolean;
     getSyntaxSetttings(): ISyntaxSettings;
     readByRule(rule: string): any;
     readByKey(rule: string, key: string): any;

package/build/src/abap/5_syntax/_current_scope.js

@@ -45,7 +45,7 @@ class CurrentScope {
         return this.reg.getConfig().getLanguageVersion();
     }
     getOpenABAP() {
-        return this.reg.getConfig().getOpenABAP();
+        return this.reg.getConfig().isOpenABAP();
     }
     getRegistry() {
         return this.reg;

package/build/src/abap/5_syntax/expressions/_check_offset_length.js

@@ -0,0 +1,59 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.checkOffsetLength = checkOffsetLength;
+const Expressions = __importStar(require("../../2_statements/expressions"));
+const basic_1 = require("../../types/basic");
+const _syntax_input_1 = require("../_syntax_input");
+const _builtin_1 = require("../_builtin");
+// Offsets or lengths cannot be specified for STRING or XSTRING fields
+// passed as a method parameter source. Returns true if an issue was reported.
+function checkOffsetLength(source, sourceType, method, input) {
+    const chain = source.findDirectExpression(Expressions.FieldChain);
+    const isCalculated = source.findDirectExpression(Expressions.Source) !== undefined;
+    const hasOffsetOrLength = chain !== undefined
+        && isCalculated === false
+        && (chain.findDirectExpression(Expressions.FieldOffset) !== undefined
+            || chain.findDirectExpression(Expressions.FieldLength) !== undefined);
+    if (hasOffsetOrLength
+        && !(method instanceof _builtin_1.BuiltInMethod)
+        && (sourceType instanceof basic_1.StringType || sourceType instanceof basic_1.XStringType)) {
+        const message = `Offsets or lengths cannot be specified for fields of type "STRING" or "XSTRING" in the current statement`;
+        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, source.getFirstToken(), message));
+        return true;
+    }
+    return false;
+}
+//# sourceMappingURL=_check_offset_length.js.map

package/build/src/abap/5_syntax/expressions/method_call_param.js

@@ -43,7 +43,7 @@ const source_1 = require("./source");
 const _type_utils_1 = require("../_type_utils");
 const _syntax_input_1 = require("../_syntax_input");
 const constant_1 = require("./constant");
-const _builtin_1 = require("../_builtin");
+const _check_offset_length_1 = require("./_check_offset_length");
 class MethodCallParam {
     static runSyntax(node, input, method) {
         if (!(node.get() instanceof Expressions.MethodCallParam)) {
@@ -104,17 +104,7 @@ class MethodCallParam {
             let sourceType = undefined;
             if (child.get() instanceof Expressions.Source) {
                 sourceType = source_1.Source.runSyntax(child, input, targetType);
-                const chain = child.findDirectExpression(Expressions.FieldChain);
-                const isCalculated = child.findDirectExpression(Expressions.Source) !== undefined;
-                const hasOffsetOrLength = chain !== undefined
-                    && isCalculated === false
-                    && (chain.findDirectExpression(Expressions.FieldOffset) !== undefined
-                        || chain.findDirectExpression(Expressions.FieldLength) !== undefined);
-                if (hasOffsetOrLength
-                    && !(method instanceof _builtin_1.BuiltInMethod)
-                    && (sourceType instanceof basic_1.StringType || sourceType instanceof basic_1.XStringType)) {
-                    const message = `Offsets or lengths cannot be specified for fields of type "STRING" or "XSTRING" in the current statement`;
-                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, child.getFirstToken(), message));
+                if ((0, _check_offset_length_1.checkOffsetLength)(child, sourceType, method, input)) {
                     return;
                 }
             }

package/build/src/abap/5_syntax/expressions/method_parameters.js

@@ -45,6 +45,7 @@ const _syntax_input_1 = require("../_syntax_input");
 const assert_error_1 = require("../assert_error");
 const field_chain_1 = require("./field_chain");
 const _reference_1 = require("../_reference");
+const _check_offset_length_1 = require("./_check_offset_length");
 class MethodParameters {
     constructor() {
         this.requiredParameters = undefined;
@@ -215,7 +216,6 @@ class MethodParameters {
         }
     }
     parameterListS(node, input, method) {
-        var _a;
         if (node === undefined) {
             return [];
         }
@@ -223,14 +223,21 @@ class MethodParameters {
             throw new assert_error_1.AssertError("parameterListS, unexpected node");
         }
         const ret = [];
+        const supplied = new Set();
         for (const c of node.getChildren()) {
             if (!(c.get() instanceof Expressions.ParameterS) || !(c instanceof nodes_1.ExpressionNode)) {
                 throw new assert_error_1.AssertError("parameterListS, unexpected node, child");
             }
-            const name = (_a = c.findDirectExpression(Expressions.ParameterName)) === null || _a === void 0 ? void 0 : _a.getFirstToken().getStr().toUpperCase();
-            if (name === undefined) {
+            const nameNode = c.findDirectExpression(Expressions.ParameterName);
+            const name = nameNode === null || nameNode === void 0 ? void 0 : nameNode.getFirstToken().getStr().toUpperCase();
+            if (name === undefined || nameNode === undefined) {
                 throw new assert_error_1.AssertError("parameterListS, no name determined");
             }
+            if (supplied.has(name)) {
+                const message = `Method parameter "${name}" is supplied more than once`;
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, nameNode.getFirstToken(), message));
+            }
+            supplied.add(name);
             const source = c.findDirectExpression(Expressions.Source);
             if (source === undefined) {
                 throw new assert_error_1.AssertError("parameterListS, no source found");
@@ -248,6 +255,7 @@ class MethodParameters {
                 targetType = method;
             }
             let sourceType = source_1.Source.runSyntax(source, input, targetType);
+            (0, _check_offset_length_1.checkOffsetLength)(source, sourceType, method, input);
             if (sourceType === undefined) {
                 if (method instanceof basic_1.VoidType) {
                     sourceType = method;
@@ -263,7 +271,6 @@ class MethodParameters {
         return ret;
     }
     parameterListT(node, input) {
-        var _a;
         if (node === undefined) {
             return [];
         }
@@ -271,14 +278,21 @@ class MethodParameters {
             throw new assert_error_1.AssertError("parameterListT, unexpected node");
         }
         const ret = [];
+        const supplied = new Set();
         for (const c of node.getChildren()) {
             if (!(c.get() instanceof Expressions.ParameterT) || !(c instanceof nodes_1.ExpressionNode)) {
                 throw new assert_error_1.AssertError("parameterListT, unexpected node, child");
             }
-            const name = (_a = c.findDirectExpression(Expressions.ParameterName)) === null || _a === void 0 ? void 0 : _a.getFirstToken().getStr().toUpperCase();
-            if (name === undefined) {
+            const nameNode = c.findDirectExpression(Expressions.ParameterName);
+            const name = nameNode === null || nameNode === void 0 ? void 0 : nameNode.getFirstToken().getStr().toUpperCase();
+            if (name === undefined || nameNode === undefined) {
                 throw new assert_error_1.AssertError("parameterListT, no name determined");
             }
+            if (supplied.has(name)) {
+                const message = `Method parameter "${name}" is supplied more than once`;
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, nameNode.getFirstToken(), message));
+            }
+            supplied.add(name);
             const target = c.findDirectExpression(Expressions.Target);
             if (target === undefined) {
                 throw new assert_error_1.AssertError("parameterListT, no target found");

package/build/src/abap/5_syntax/statements/catch.js

@@ -41,6 +41,7 @@ const basic_1 = require("../../types/basic");
 const target_1 = require("../expressions/target");
 const _reference_1 = require("../_reference");
 const _syntax_input_1 = require("../_syntax_input");
+const _type_utils_1 = require("../_type_utils");
 class Catch {
     runSyntax(node, input) {
         var _a, _b;
@@ -91,7 +92,22 @@ class Catch {
             }
         }
         else if (target) {
-            target_1.Target.runSyntax(target, input);
+            const targetType = target_1.Target.runSyntax(target, input);
+            if (targetType instanceof basic_1.ObjectReferenceType) {
+                for (const c of node.findDirectExpressions(Expressions.ClassName)) {
+                    const token = c.getFirstToken();
+                    const className = token.getStr().toUpperCase();
+                    const found = input.scope.existsObject(className);
+                    if (found === null || found === void 0 ? void 0 : found.id) {
+                        const catchType = new basic_1.ObjectReferenceType(found.id);
+                        if (new _type_utils_1.TypeUtils(input.scope).isAssignableStrict(catchType, targetType) === false) {
+                            const message = "CATCH target not compatible with " + className;
+                            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, token, message));
+                            return;
+                        }
+                    }
+                }
+            }
         }
     }
 }

package/build/src/cds/expressions/cds_define_abstract.js

@@ -8,7 +8,7 @@ class CDSDefineAbstract extends combi_1.Expression {
     getRunnable() {
         const field = (0, combi_1.seq)((0, combi_1.star)(_1.CDSAnnotation), (0, combi_1.optPrio)((0, combi_1.str)("KEY")), cds_name_1.CDSName, ":", _1.CDSType, ";");
         const compsiOrAssoci = (0, combi_1.seq)((0, combi_1.star)(_1.CDSAnnotation), cds_name_1.CDSName, ":", (0, combi_1.alt)(_1.CDSComposition, _1.CDSAssociation), ";");
-        return (0, combi_1.seq)((0, combi_1.star)(_1.CDSAnnotation), "DEFINE", (0, combi_1.opt)("ROOT"), "ABSTRACT", "ENTITY", cds_name_1.CDSName, (0, combi_1.opt)(_1.CDSWithParameters), (0, combi_1.str)("{"), (0, combi_1.plus)((0, combi_1.alt)(field, compsiOrAssoci)), (0, combi_1.str)("}"), (0, combi_1.opt)(";"));
+        return (0, combi_1.seq)((0, combi_1.star)(_1.CDSAnnotation), (0, combi_1.opt)("DEFINE"), (0, combi_1.opt)("ROOT"), "ABSTRACT", "ENTITY", cds_name_1.CDSName, (0, combi_1.opt)(_1.CDSWithParameters), (0, combi_1.str)("{"), (0, combi_1.plus)((0, combi_1.alt)(field, compsiOrAssoci)), (0, combi_1.str)("}"), (0, combi_1.opt)(";"));
     }
 }
 exports.CDSDefineAbstract = CDSDefineAbstract;

package/build/src/cds/expressions/cds_define_custom.js

@@ -9,7 +9,7 @@ class CDSDefineCustom extends combi_1.Expression {
     getRunnable() {
         const field = (0, combi_1.seq)((0, combi_1.optPrio)((0, combi_1.str)("KEY")), cds_name_1.CDSName, ":", cds_type_1.CDSType, ";");
         const compsiOrAssoci = (0, combi_1.seq)(cds_name_1.CDSName, ":", (0, combi_1.alt)(_1.CDSComposition, _1.CDSAssociation), ";");
-        return (0, combi_1.seq)((0, combi_1.star)(_1.CDSAnnotation), (0, combi_1.str)("DEFINE"), (0, combi_1.opt)((0, combi_1.str)("ROOT")), (0, combi_1.str)("CUSTOM ENTITY"), cds_name_1.CDSName, (0, combi_1.opt)(_1.CDSWithParameters), (0, combi_1.str)("{"), (0, combi_1.plus)((0, combi_1.seq)((0, combi_1.star)(_1.CDSAnnotation), (0, combi_1.alt)(field, compsiOrAssoci))), (0, combi_1.str)("}"), (0, combi_1.opt)(";"));
+        return (0, combi_1.seq)((0, combi_1.star)(_1.CDSAnnotation), (0, combi_1.opt)("DEFINE"), (0, combi_1.opt)("ROOT"), (0, combi_1.str)("CUSTOM ENTITY"), cds_name_1.CDSName, (0, combi_1.opt)(_1.CDSWithParameters), (0, combi_1.str)("{"), (0, combi_1.plus)((0, combi_1.seq)((0, combi_1.star)(_1.CDSAnnotation), (0, combi_1.alt)(field, compsiOrAssoci))), (0, combi_1.str)("}"), (0, combi_1.opt)(";"));
     }
 }
 exports.CDSDefineCustom = CDSDefineCustom;

package/build/src/cds/expressions/cds_define_external_entity.js

@@ -13,7 +13,7 @@ class CDSDefineExternalEntity extends combi_1.Expression {
         const body = (0, combi_1.plus)((0, combi_1.alt)(field, assocOrComp));
         const externalEntity = (0, combi_1.seq)((0, combi_1.opt)("WRITABLE"), "EXTERNAL", "ENTITY", _1.CDSName, (0, combi_1.opt)(externalName), (0, combi_1.opt)(_1.CDSWithParameters));
         const staticEntity = (0, combi_1.seq)("STATIC", "ENTITY", _1.CDSName, (0, combi_1.opt)(externalName));
-        return (0, combi_1.seq)((0, combi_1.star)(_1.CDSAnnotation), "DEFINE", (0, combi_1.alt)(externalEntity, staticEntity), (0, combi_1.str)("{"), body, (0, combi_1.str)("}"), (0, combi_1.opt)((0, combi_1.seq)("WITH", "FEDERATED", "DATA", (0, combi_1.optPrio)((0, combi_1.alt)((0, combi_1.seq)("PROVIDED", "AT", "RUNTIME"), (0, combi_1.seq)("PROVIDED", "BY", _1.CDSName))))), (0, combi_1.opt)(";"));
+        return (0, combi_1.seq)((0, combi_1.star)(_1.CDSAnnotation), (0, combi_1.opt)("DEFINE"), (0, combi_1.alt)(externalEntity, staticEntity), (0, combi_1.str)("{"), body, (0, combi_1.str)("}"), (0, combi_1.opt)((0, combi_1.seq)("WITH", "FEDERATED", "DATA", (0, combi_1.optPrio)((0, combi_1.alt)((0, combi_1.seq)("PROVIDED", "AT", "RUNTIME"), (0, combi_1.seq)("PROVIDED", "BY", _1.CDSName))))), (0, combi_1.opt)(";"));
     }
 }
 exports.CDSDefineExternalEntity = CDSDefineExternalEntity;

package/build/src/cds/expressions/cds_define_hierarchy.js

@@ -15,7 +15,7 @@ class CDSDefineHierarchy extends combi_1.Expression {
         const depthValue = (0, combi_1.altPrio)(_1.CDSString, _1.CDSInteger, _1.CDSPrefixedName);
         const loadMode = (0, combi_1.altPrio)("BULK", "INCREMENTAL", _1.CDSPrefixedName);
         const hierarchyBody = (0, combi_1.seq)("SOURCE", _1.CDSName, (0, combi_1.opt)(_1.CDSParametersSelect), "CHILD", "TO", "PARENT", "ASSOCIATION", _1.CDSName, (0, combi_1.opt)(directory), (0, combi_1.opt)(datePeriod), (0, combi_1.opt)((0, combi_1.seq)("START", "WHERE", _1.CDSCondition)), (0, combi_1.opt)(siblingsOrder), (0, combi_1.opt)((0, combi_1.seq)("LOAD", loadMode)), (0, combi_1.opt)((0, combi_1.seq)("DEPTH", depthValue)), (0, combi_1.opt)((0, combi_1.seq)("NODETYPE", _1.CDSName)), (0, combi_1.opt)((0, combi_1.seq)("MULTIPLE", "PARENTS", (0, combi_1.altPrio)("NOT ALLOWED", "ALLOWED", (0, combi_1.seq)("LEAVES", (0, combi_1.optPrio)("ONLY"))))), (0, combi_1.opt)((0, combi_1.seq)("ORPHANS", (0, combi_1.altPrio)("IGNORE", "ROOT", "ERROR"))), (0, combi_1.opt)((0, combi_1.seq)("CYCLES", (0, combi_1.altPrio)("BREAKUP", "ERROR"))), (0, combi_1.opt)((0, combi_1.seq)("GENERATE", "SPANTREE")), (0, combi_1.opt)((0, combi_1.seq)("CACHE", (0, combi_1.altPrio)("ON", "OFF", "FORCE"))));
-        return (0, combi_1.seq)((0, combi_1.star)(_1.CDSAnnotation), "DEFINE", "HIERARCHY", _1.CDSName, (0, combi_1.opt)(_1.CDSWithParameters), "AS", "PARENT", "CHILD", "HIERARCHY", "(", hierarchyBody, ")", "{", (0, combi_1.seq)(field, (0, combi_1.star)((0, combi_1.seq)(",", field))), "}", (0, combi_1.opt)(";"));
+        return (0, combi_1.seq)((0, combi_1.star)(_1.CDSAnnotation), (0, combi_1.opt)("DEFINE"), "HIERARCHY", _1.CDSName, (0, combi_1.opt)(_1.CDSWithParameters), "AS", "PARENT", "CHILD", "HIERARCHY", "(", hierarchyBody, ")", "{", (0, combi_1.seq)(field, (0, combi_1.star)((0, combi_1.seq)(",", field))), "}", (0, combi_1.opt)(";"));
     }
 }
 exports.CDSDefineHierarchy = CDSDefineHierarchy;

package/build/src/cds/expressions/cds_define_projection.js

@@ -8,7 +8,7 @@ class CDSDefineProjection extends combi_1.Expression {
     getRunnable() {
         // redefine association _Assoc redirected to [composition child | parent] Entity
         const redefineAssoc = (0, combi_1.seq)("REDEFINE", "ASSOCIATION", _1.CDSName, "REDIRECTED", "TO", (0, combi_1.optPrio)((0, combi_1.altPrio)((0, combi_1.seq)("COMPOSITION", "CHILD"), "PARENT")), _1.CDSName);
-        return (0, combi_1.seq)((0, combi_1.star)(_1.CDSAnnotation), "DEFINE", (0, combi_1.opt)("ROOT"), (0, combi_1.opt)("TRANSIENT"), "VIEW", (0, combi_1.ver)(__1.Release.v755, (0, combi_1.opt)("ENTITY")), _1.CDSName, (0, combi_1.opt)(_1.CDSProviderContract), (0, combi_1.opt)(_1.CDSWithParameters), "AS PROJECTION ON", _1.CDSName, (0, combi_1.opt)(_1.CDSParametersSelect), (0, combi_1.opt)(_1.CDSAs), (0, combi_1.star)((0, combi_1.altPrio)(_1.CDSAssociation, redefineAssoc)), (0, combi_1.str)("{"), (0, combi_1.seq)(_1.CDSElement, (0, combi_1.star)((0, combi_1.seq)(",", _1.CDSElement)), (0, combi_1.opt)(",")), (0, combi_1.str)("}"), (0, combi_1.opt)(_1.CDSWhere), (0, combi_1.opt)(";"));
+        return (0, combi_1.seq)((0, combi_1.star)(_1.CDSAnnotation), (0, combi_1.opt)("DEFINE"), (0, combi_1.opt)("ROOT"), (0, combi_1.opt)("TRANSIENT"), "VIEW", (0, combi_1.ver)(__1.Release.v755, (0, combi_1.opt)("ENTITY")), _1.CDSName, (0, combi_1.opt)(_1.CDSProviderContract), (0, combi_1.opt)(_1.CDSWithParameters), "AS PROJECTION ON", _1.CDSName, (0, combi_1.opt)(_1.CDSParametersSelect), (0, combi_1.opt)(_1.CDSAs), (0, combi_1.star)((0, combi_1.altPrio)(_1.CDSAssociation, redefineAssoc)), (0, combi_1.str)("{"), (0, combi_1.seq)(_1.CDSElement, (0, combi_1.star)((0, combi_1.seq)(",", _1.CDSElement)), (0, combi_1.opt)(",")), (0, combi_1.str)("}"), (0, combi_1.opt)(_1.CDSWhere), (0, combi_1.opt)(";"));
     }
 }
 exports.CDSDefineProjection = CDSDefineProjection;

package/build/src/cds/expressions/cds_define_table_entity.js

@@ -12,7 +12,7 @@ class CDSDefineTableEntity extends combi_1.Expression {
         const elementList = (0, combi_1.seq)(_1.CDSElement, (0, combi_1.star)((0, combi_1.seq)(",", _1.CDSElement)), (0, combi_1.opt)(","));
         const elements = (0, combi_1.seq)((0, combi_1.str)("{"), (0, combi_1.altPrio)("*", elementList), (0, combi_1.str)("}"));
         const selectBody = (0, combi_1.seq)("AS", "SELECT", "FROM", _1.CDSSource, (0, combi_1.star)(_1.CDSJoin), (0, combi_1.star)((0, combi_1.altPrio)(_1.CDSComposition, _1.CDSAssociation)), (0, combi_1.opt)(elements), (0, combi_1.optPrio)(_1.CDSWhere));
-        return (0, combi_1.seq)((0, combi_1.star)(_1.CDSAnnotation), "DEFINE", (0, combi_1.opt)("ROOT"), "TABLE", "ENTITY", _1.CDSName, (0, combi_1.opt)(_1.CDSWithParameters), (0, combi_1.altPrio)((0, combi_1.seq)((0, combi_1.str)("{"), inlineBody, (0, combi_1.str)("}")), selectBody), (0, combi_1.opt)(";"));
+        return (0, combi_1.seq)((0, combi_1.star)(_1.CDSAnnotation), (0, combi_1.opt)("DEFINE"), (0, combi_1.opt)("ROOT"), "TABLE", "ENTITY", _1.CDSName, (0, combi_1.opt)(_1.CDSWithParameters), (0, combi_1.altPrio)((0, combi_1.seq)((0, combi_1.str)("{"), inlineBody, (0, combi_1.str)("}")), selectBody), (0, combi_1.opt)(";"));
     }
 }
 exports.CDSDefineTableEntity = CDSDefineTableEntity;

package/build/src/config.js

@@ -181,7 +181,7 @@ class Config {
         }
         return (0, version_1.versionToABAPRelease)(v);
     }
-    getOpenABAP() {
+    isOpenABAP() {
         return this.getRelease() === version_1.Release["open-abap"];
     }
     getVersion() {

package/build/src/registry.js

@@ -75,7 +75,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.119.67";
+        return "2.120.1";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/clear_exporting_parameters.js

@@ -0,0 +1,254 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.ClearExportingParameters = exports.ClearExportingParametersConf = void 0;
+const issue_1 = require("../issue");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+const syntax_1 = require("../abap/5_syntax/syntax");
+const _abap_object_1 = require("../objects/_abap_object");
+const _scope_type_1 = require("../abap/5_syntax/_scope_type");
+const objects_1 = require("../objects");
+const _reference_1 = require("../abap/5_syntax/_reference");
+const basic_1 = require("../abap/types/basic");
+const _statement_1 = require("../abap/2_statements/statements/_statement");
+const edit_helper_1 = require("../edit_helper");
+const Expressions = __importStar(require("../abap/2_statements/expressions"));
+class ClearExportingParametersConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        /** Skip specific parameter names, case insensitive
+         * @uniqueItems true
+         */
+        this.skipNames = [];
+    }
+}
+exports.ClearExportingParametersConf = ClearExportingParametersConf;
+class ClearExportingParameters {
+    constructor() {
+        this.conf = new ClearExportingParametersConf();
+    }
+    getMetadata() {
+        return {
+            key: "clear_exporting_parameters",
+            title: "Clear EXPORTING parameters",
+            shortDescription: `Checks that EXPORTING parameters passed by reference are cleared or assigned before they are read`,
+            extendedInformation: `An EXPORTING parameter passed by reference behaves like a CHANGING parameter: it is not
+initialized when the method is called, so it can still contain a value supplied by the caller. Clear or overwrite it
+before reading it, so a leftover value is not accidentally used.
+
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#clear-or-overwrite-exporting-reference-parameters
+
+https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/abenref_transf_output_param_guidl.htm
+
+Note: EXPORTING parameters passed by VALUE are always initialized and are therefore not reported.
+Reading and writing the parameter in the same statement (e.g. "ev_result = ev_result + 1") is reported,
+as the source is evaluated before the parameter is assigned.
+Objects containing parser or syntax errors are not reported.
+
+Only class and interface method implementations are checked, function module parameters are currently not supported.`,
+            tags: [_irule_1.RuleTag.Styleguide],
+            badExample: `CLASS lcl DEFINITION.
+  PUBLIC SECTION.
+    METHODS foo EXPORTING ev_result TYPE i.
+ENDCLASS.
+CLASS lcl IMPLEMENTATION.
+  METHOD foo.
+    ev_result = ev_result + 1.
+  ENDMETHOD.
+ENDCLASS.`,
+            goodExample: `CLASS lcl DEFINITION.
+  PUBLIC SECTION.
+    METHODS foo EXPORTING ev_result TYPE i.
+ENDCLASS.
+CLASS lcl IMPLEMENTATION.
+  METHOD foo.
+    CLEAR ev_result.
+    ev_result = ev_result + 1.
+  ENDMETHOD.
+ENDCLASS.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+        if (this.conf.skipNames === undefined) {
+            this.conf.skipNames = [];
+        }
+    }
+    initialize(reg) {
+        this.reg = reg;
+        return this;
+    }
+    run(obj) {
+        if (!(obj instanceof _abap_object_1.ABAPObject) || obj instanceof objects_1.Interface) {
+            return [];
+        }
+        for (const file of obj.getABAPFiles()) {
+            for (const statement of file.getStatements()) {
+                if (statement.get() instanceof _statement_1.Unknown) {
+                    return []; // contains parser errors
+                }
+            }
+        }
+        const syntax = new syntax_1.SyntaxLogic(this.reg, obj).run();
+        if (syntax.issues.length > 0) {
+            return []; // contains syntax errors
+        }
+        const issues = [];
+        this.traverse(syntax.spaghetti.getTop(), obj, issues);
+        return issues;
+    }
+    traverse(node, obj, issues) {
+        if (node.getIdentifier().stype === _scope_type_1.ScopeType.Method) {
+            this.checkMethod(node, obj, issues);
+        }
+        for (const child of node.getChildren()) {
+            this.traverse(child, obj, issues);
+        }
+    }
+    checkMethod(node, obj, issues) {
+        const parameters = this.findExportingByReference(node, obj);
+        if (parameters.length === 0) {
+            return;
+        }
+        const references = this.collectReferences(node);
+        for (const parameter of parameters) {
+            const issue = this.checkParameter(parameter, references, obj);
+            if (issue !== undefined) {
+                issues.push(issue);
+            }
+        }
+    }
+    findExportingByReference(node, obj) {
+        var _a;
+        const ret = [];
+        const vars = node.getData().vars;
+        for (const name in vars) {
+            const parameter = vars[name];
+            const meta = parameter.getMeta();
+            if (meta.includes("exporting" /* IdentifierMeta.MethodExporting */) === false
+                || meta.includes("pass_by_value" /* IdentifierMeta.PassByValue */) === true) {
+                continue;
+            }
+            else if ((_a = this.conf.skipNames) === null || _a === void 0 ? void 0 : _a.some(s => s.toUpperCase() === name.toUpperCase())) {
+                continue;
+            }
+            const type = parameter.getType();
+            if (type instanceof basic_1.VoidType || type instanceof basic_1.UnknownType) {
+                continue; // e.g. RAP magic parameters, or unresolved types
+            }
+            else if (this.isPassByValue(parameter, obj) === true) {
+                continue; // VALUE(..) parameters are always initialized
+            }
+            ret.push(parameter);
+        }
+        return ret;
+    }
+    isPassByValue(parameter, obj) {
+        var _a;
+        // the PassByValue meta is not set for EXPORTING parameters, so determine it from the definition
+        const file = obj.getABAPFileByName(parameter.getFilename());
+        if (file === undefined) {
+            return false;
+        }
+        const statement = edit_helper_1.EditHelper.findStatement(parameter.getToken(), file);
+        if (statement === undefined) {
+            return false;
+        }
+        for (const param of statement.findAllExpressions(Expressions.MethodParam)) {
+            const nameToken = (_a = param.findFirstExpression(Expressions.MethodParamName)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
+            if (nameToken !== undefined && nameToken.getStart().equals(parameter.getStart())) {
+                return param.getFirstToken().getStr().toUpperCase() === "VALUE";
+            }
+        }
+        return false;
+    }
+    collectReferences(node) {
+        // methods do not nest, so all descendant scopes (FOR, LET, ...) belong to this method
+        const ret = [...node.getData().references];
+        for (const child of node.getChildren()) {
+            ret.push(...this.collectReferences(child));
+        }
+        return ret;
+    }
+    checkParameter(parameter, references, obj) {
+        let firstRead = undefined;
+        let earliestWrite = undefined;
+        for (const reference of references) {
+            if (reference.resolved === undefined || parameter.equals(reference.resolved) === false) {
+                continue;
+            }
+            const pos = reference.position.getStart();
+            if (reference.referenceType === _reference_1.ReferenceType.DataReadReference) {
+                if (firstRead === undefined || pos.isBefore(firstRead.position.getStart())) {
+                    firstRead = reference;
+                }
+            }
+            else if (reference.referenceType === _reference_1.ReferenceType.DataWriteReference) {
+                if (earliestWrite === undefined || pos.isBefore(earliestWrite)) {
+                    earliestWrite = pos;
+                }
+            }
+        }
+        if (firstRead === undefined) {
+            return undefined; // never read, no hazard
+        }
+        // the parameter is safe only if it is written in a statement strictly before the first read
+        const readStatement = this.statementStart(firstRead.position.getStart(), obj);
+        const writeStatement = earliestWrite === undefined ? undefined : this.statementStart(earliestWrite, obj);
+        if (writeStatement !== undefined && readStatement !== undefined && writeStatement.isBefore(readStatement)) {
+            return undefined;
+        }
+        const message = `EXPORTING parameter "${parameter.getName().toLowerCase()}" read before it is cleared or assigned`;
+        return issue_1.Issue.atIdentifier(firstRead.position, message, this.getMetadata().key, this.conf.severity);
+    }
+    statementStart(pos, obj) {
+        for (const file of obj.getABAPFiles()) {
+            for (const statement of file.getStatements()) {
+                const start = statement.getStart();
+                const end = statement.getEnd();
+                if (pos.equals(start) || (pos.isAfter(start) && pos.isBefore(end))) {
+                    return start;
+                }
+            }
+        }
+        return undefined;
+    }
+}
+exports.ClearExportingParameters = ClearExportingParameters;
+//# sourceMappingURL=clear_exporting_parameters.js.map

package/build/src/rules/downport.js

@@ -204,7 +204,7 @@ Make sure to test the downported code, it might not always be completely correct
     initialize(reg) {
         this.lowReg = reg;
         const config = this.lowReg.getConfig();
-        if (config.getRelease() === version_1.Release.v702 || config.getOpenABAP()) {
+        if (config.getRelease() === version_1.Release.v702 || config.isOpenABAP()) {
             this.initHighReg();
         }
         return this;
@@ -237,7 +237,7 @@ Make sure to test the downported code, it might not always be completely correct
         const ret = [];
         this.counter = 1;
         const config = this.lowReg.getConfig();
-        if (config.getRelease() !== version_1.Release.v702 && !config.getOpenABAP()) {
+        if (config.getRelease() !== version_1.Release.v702 && !config.isOpenABAP()) {
             return ret;
         }
         else if (!(lowObj instanceof _abap_object_1.ABAPObject)) {
@@ -1109,7 +1109,7 @@ ${indentation}`);
     outlineCatchSimple(node, lowFile) {
         // outlines "CATCH cx_bcs INTO DATA(lx_bcs_excep).", note that this does not need to look at types
         var _a, _b;
-        if (this.lowReg.getConfig().getOpenABAP()) {
+        if (this.lowReg.getConfig().isOpenABAP()) {
             return undefined;
         }
         if (!(node.get() instanceof Statements.Catch)) {
@@ -1158,7 +1158,7 @@ ${indentation}CATCH ${className} INTO ${targetName}.`;
         if (!(node.get() instanceof Statements.Move)) {
             return undefined;
         }
-        if (this.lowReg.getConfig().getOpenABAP()) {
+        if (this.lowReg.getConfig().isOpenABAP()) {
             return undefined;
         }
         const target = node.findFirstExpression(Expressions.Target);
@@ -1214,7 +1214,7 @@ ${indentation}CATCH ${className} INTO ${targetName}.`;
         return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Outline DATA", this.getMetadata().key, this.conf.severity, fix);
     }
     partiallyImplemented(node, lowFile) {
-        if (this.lowReg.getConfig().getOpenABAP()) {
+        if (this.lowReg.getConfig().isOpenABAP()) {
             return undefined;
         }
         if (node.get() instanceof Statements.InterfaceDef) {
@@ -1890,7 +1890,7 @@ ${indentation}    output = ${uniqueName}.\n`;
         if (!(node.get() instanceof Statements.Loop)) {
             return undefined;
         }
-        if (this.lowReg.getConfig().getOpenABAP()) {
+        if (this.lowReg.getConfig().isOpenABAP()) {
             return undefined;
         }
         const source = (_a = node.findDirectExpression(Expressions.LoopSource)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.SimpleSource2);
@@ -2566,7 +2566,7 @@ ${indentation}    output = ${uniqueName}.\n`;
     outlineData(node, lowFile, highSyntax) {
         // hmm, no guard here, as DATA(SDF) is valid in 702
         var _a, _b;
-        if (this.lowReg.getConfig().getOpenABAP()) {
+        if (this.lowReg.getConfig().isOpenABAP()) {
             return undefined;
         }
         for (const i of node.findAllExpressionsRecursive(Expressions.InlineData)) {
@@ -2785,7 +2785,7 @@ ${indentation}    output = ${uniqueName}.\n`;
         return false;
     }
     replaceXsdBool(node, lowFile, highSyntax) {
-        if (this.lowReg.getConfig().getOpenABAP()) {
+        if (this.lowReg.getConfig().isOpenABAP()) {
             return undefined;
         }
         const spag = highSyntax.spaghetti.lookupPosition(node.getFirstToken().getStart(), lowFile.getFilename());
@@ -2914,7 +2914,7 @@ ${indentation}    output = ${uniqueName}.\n`;
     }
     replaceLineFunctions(node, lowFile, highSyntax, highFile) {
         var _a, _b;
-        if (this.lowReg.getConfig().getOpenABAP()) {
+        if (this.lowReg.getConfig().isOpenABAP()) {
             return undefined;
         }
         const spag = highSyntax.spaghetti.lookupPosition(node.getFirstToken().getStart(), lowFile.getFilename());

package/build/src/rules/index.js

@@ -45,6 +45,7 @@ __exportStar(require("./check_subrc"), exports);
 __exportStar(require("./check_syntax"), exports);
 __exportStar(require("./check_text_elements"), exports);
 __exportStar(require("./check_transformation_exists"), exports);
+__exportStar(require("./clear_exporting_parameters"), exports);
 __exportStar(require("./class_attribute_names"), exports);
 __exportStar(require("./classic_exceptions_overlap"), exports);
 __exportStar(require("./cloud_types"), exports);
@@ -150,6 +151,7 @@ __exportStar(require("./preferred_compare_operator"), exports);
 __exportStar(require("./prefix_is_current_class"), exports);
 __exportStar(require("./reduce_procedural_code"), exports);
 __exportStar(require("./reduce_string_templates"), exports);
+__exportStar(require("./redundant_conversion"), exports);
 __exportStar(require("./release_idoc"), exports);
 __exportStar(require("./remove_descriptions"), exports);
 __exportStar(require("./rfc_error_handling"), exports);

package/build/src/rules/inline_data_old_versions.js

@@ -32,7 +32,7 @@ class InlineDataOldVersions extends _abap_rule_1.ABAPRule {
     runParsed(file) {
         const issues = [];
         if ((0, version_1.releaseAtLeast)(this.reg.getConfig().getRelease(), version_1.Release.v740sp02)
-            || this.reg.getConfig().getOpenABAP()
+            || this.reg.getConfig().isOpenABAP()
             || this.reg.getConfig().getLanguageVersion() === version_1.LanguageVersion.Cloud) {
             return [];
         }

package/build/src/rules/no_inline_in_optional_branches.js

@@ -80,7 +80,7 @@ Not considered optional branches:
         const release = this.reg.getConfig().getRelease();
         if (release === version_1.Release.v700
             || release === version_1.Release.v702
-            || this.reg.getConfig().getOpenABAP()) {
+            || this.reg.getConfig().isOpenABAP()) {
             return [];
         }
         const struc = file.getStructure();

package/build/src/rules/redundant_conversion.js

@@ -0,0 +1,253 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RedundantConversion = exports.RedundantConversionConf = void 0;
+const Expressions = __importStar(require("../abap/2_statements/expressions"));
+const Statements = __importStar(require("../abap/2_statements/statements"));
+const _reference_1 = require("../abap/5_syntax/_reference");
+const constant_1 = require("../abap/5_syntax/expressions/constant");
+const syntax_1 = require("../abap/5_syntax/syntax");
+const nodes_1 = require("../abap/nodes");
+const _typed_identifier_1 = require("../abap/types/_typed_identifier");
+const basic_1 = require("../abap/types/basic");
+const issue_1 = require("../issue");
+const _abap_object_1 = require("../objects/_abap_object");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+const edit_helper_1 = require("../edit_helper");
+const version_1 = require("../version");
+class RedundantConversionConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.RedundantConversionConf = RedundantConversionConf;
+class RedundantConversion {
+    constructor() {
+        this.conf = new RedundantConversionConf();
+    }
+    getMetadata() {
+        return {
+            key: "redundant_conversion",
+            title: "Redundant Conversion",
+            shortDescription: `Find redundant CONV expressions`,
+            extendedInformation: `Reports CONV expressions whose operand already has the conversion's target type.`,
+            tags: [_irule_1.RuleTag.Quickfix],
+            badExample: `DATA text TYPE string.
+text = CONV string( text ).`,
+            goodExample: `DATA text TYPE string.
+text = text.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    initialize(reg) {
+        this.reg = reg;
+        return this;
+    }
+    run(obj) {
+        var _a, _b;
+        if (!(0, version_1.releaseAtLeast)(this.reg.getConfig().getRelease(), version_1.Release.v740sp02)
+            && !this.reg.getConfig().isOpenABAP()) {
+            return [];
+        }
+        if (!(obj instanceof _abap_object_1.ABAPObject)) {
+            return [];
+        }
+        const syntax = new syntax_1.SyntaxLogic(this.reg, obj).run();
+        if (syntax.issues.length > 0) {
+            return [];
+        }
+        const issues = [];
+        for (const file of obj.getABAPFiles()) {
+            const structure = file.getStructure();
+            if (structure === undefined) {
+                continue;
+            }
+            for (const source of structure.findAllExpressions(Expressions.Source)) {
+                if (source.getFirstToken().getStr().toUpperCase() !== "CONV") {
+                    continue;
+                }
+                const typeExpression = source.findDirectExpression(Expressions.TypeNameOrInfer);
+                const bodySource = (_a = source.findDirectExpression(Expressions.ConvBody)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.Source);
+                if (typeExpression === undefined
+                    || bodySource === undefined) {
+                    continue;
+                }
+                const scope = syntax.spaghetti.lookupPosition(source.getFirstToken().getStart(), file.getFilename());
+                if (scope === undefined) {
+                    continue;
+                }
+                const target = (_b = scope.getData().references.find(reference => reference.referenceType === _reference_1.ReferenceType.InferredType
+                    && reference.position.getStart().equals(typeExpression.getFirstToken().getStart()))) === null || _b === void 0 ? void 0 : _b.resolved;
+                const operandType = this.sourceType(bodySource, scope);
+                if (!(target instanceof _typed_identifier_1.TypedIdentifier)) {
+                    continue;
+                }
+                const operandHasSameType = operandType !== undefined && this.sameType(target.getType(), operandType);
+                const arithmeticHasSameContext = this.arithmeticUsesSameTargetType(source, bodySource, file, scope, target.getType());
+                if (operandHasSameType === false && arithmeticHasSameContext === false) {
+                    continue;
+                }
+                const closingParen = source.getDirectTokens().find(token => token.getStr() === ")" && token.getStart().isAfter(bodySource.getLastToken().getStart()));
+                if (closingParen === undefined) {
+                    continue;
+                }
+                const preserveParentheses = bodySource.findDirectExpression(Expressions.ArithOperator) !== undefined
+                    || bodySource.findDirectTokenByText("&&") !== undefined;
+                // Apply the later edit first so the original positions remain valid when
+                // both parts of the CONV wrapper are changed on the same line.
+                const fix = edit_helper_1.EditHelper.merge(edit_helper_1.EditHelper.replaceRange(file, bodySource.getLastToken().getEnd(), closingParen.getEnd(), preserveParentheses ? ")" : ""), edit_helper_1.EditHelper.replaceRange(file, source.getFirstToken().getStart(), bodySource.getFirstToken().getStart(), preserveParentheses ? "(" : ""));
+                issues.push(issue_1.Issue.atRange(file, source.getFirstToken().getStart(), closingParen.getEnd(), "Redundant CONV expression", this.getMetadata().key, this.conf.severity, fix));
+            }
+        }
+        return issues;
+    }
+    arithmeticUsesSameTargetType(conversion, bodySource, file, scope, conversionType) {
+        var _a, _b;
+        if (bodySource.findDirectExpression(Expressions.ArithOperator) === undefined) {
+            return false;
+        }
+        const statement = file.getStatements().find(candidate => candidate.includesToken(conversion.getFirstToken()));
+        if (!((statement === null || statement === void 0 ? void 0 : statement.get()) instanceof Statements.Move)) {
+            return false;
+        }
+        const targetToken = (_a = statement.findDirectExpression(Expressions.Target)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
+        if (targetToken === undefined) {
+            return false;
+        }
+        const assignmentTarget = (_b = scope.getData().references.find(reference => reference.referenceType === _reference_1.ReferenceType.DataWriteReference
+            && reference.position.getStart().equals(targetToken.getStart()))) === null || _b === void 0 ? void 0 : _b.resolved;
+        return assignmentTarget instanceof _typed_identifier_1.TypedIdentifier
+            && this.sameType(conversionType, assignmentTarget.getType());
+    }
+    sourceType(source, scope) {
+        let context;
+        for (const child of source.getChildren()) {
+            if (!(child instanceof nodes_1.ExpressionNode)) {
+                continue;
+            }
+            else if (child.get() instanceof Expressions.FieldChain) {
+                context = this.fieldChainType(child, scope);
+                if (context === undefined) {
+                    return undefined;
+                }
+            }
+            else if (child.get() instanceof Expressions.Constant) {
+                context = this.infer(context, constant_1.Constant.runSyntax(child));
+            }
+            else if (child.get() instanceof Expressions.Source) {
+                context = this.infer(context, this.sourceType(child, scope));
+            }
+            else if (child.get() instanceof Expressions.ArithOperator) {
+                if (child.concatTokens() === "**") {
+                    context = new basic_1.FloatType();
+                }
+            }
+            else {
+                return undefined;
+            }
+        }
+        if (source.findDirectTokenByText("&&")) {
+            return basic_1.StringType.get();
+        }
+        return context;
+    }
+    fieldChainType(fieldChain, scope) {
+        var _a;
+        const operand = (_a = scope.getData().references.find(reference => reference.referenceType === _reference_1.ReferenceType.DataReadReference
+            && reference.position.getStart().equals(fieldChain.getFirstToken().getStart()))) === null || _a === void 0 ? void 0 : _a.resolved;
+        if (!(operand instanceof _typed_identifier_1.TypedIdentifier)) {
+            return undefined;
+        }
+        let type = operand.getType();
+        for (const child of fieldChain.getChildren()) {
+            if (!(child instanceof nodes_1.ExpressionNode)
+                || child.get() instanceof Expressions.SourceField) {
+                continue;
+            }
+            else if (child.get() instanceof Expressions.ComponentName) {
+                if (type instanceof basic_1.TableType) {
+                    type = type.getRowType();
+                }
+                if (!(type instanceof basic_1.StructureType)) {
+                    return undefined;
+                }
+                type = type.getComponentByName(child.concatTokens());
+            }
+            else {
+                // Offsets, table expressions, attributes, and dereferences need more
+                // context than the initial data reference provides.
+                return undefined;
+            }
+        }
+        return type;
+    }
+    infer(context, found) {
+        if (context instanceof basic_1.FloatType && found instanceof basic_1.IntegerType) {
+            return context;
+        }
+        else if (context instanceof basic_1.IntegerType && found instanceof basic_1.HexType) {
+            return context;
+        }
+        else if ((context instanceof basic_1.IntegerType || context instanceof basic_1.FloatType) && (found === null || found === void 0 ? void 0 : found.isGeneric())) {
+            return context;
+        }
+        return found;
+    }
+    sameType(first, second) {
+        var _a, _b;
+        if (first instanceof basic_1.UnknownType
+            || second instanceof basic_1.UnknownType
+            || first instanceof basic_1.VoidType
+            || second instanceof basic_1.VoidType
+            || first.isGeneric()
+            || second.isGeneric()) {
+            return false;
+        }
+        if (first.constructor !== second.constructor) {
+            return false;
+        }
+        if (first instanceof basic_1.StructureType || first instanceof basic_1.TableType) {
+            const firstName = (_a = first.getQualifiedName()) === null || _a === void 0 ? void 0 : _a.toUpperCase();
+            const secondName = (_b = second.getQualifiedName()) === null || _b === void 0 ? void 0 : _b.toUpperCase();
+            return firstName !== undefined && firstName === secondName;
+        }
+        return first.toABAP() === second.toABAP();
+    }
+}
+exports.RedundantConversion = RedundantConversion;
+//# sourceMappingURL=redundant_conversion.js.map

package/build/src/rules/sql_escape_host_variables.js

@@ -75,7 +75,7 @@ class SQLEscapeHostVariables extends _abap_rule_1.ABAPRule {
         }
         if (!(0, version_1.releaseAtLeast)(this.reg.getConfig().getRelease(), version_1.Release.v740sp02)
             && this.reg.getConfig().getLanguageVersion() !== version_1.LanguageVersion.Cloud
-            && !this.reg.getConfig().getOpenABAP()) {
+            && !this.reg.getConfig().isOpenABAP()) {
             return [];
         }
         for (const s of file.getStatements()) {

package/build/src/rules/use_line_exists.js

@@ -80,7 +80,7 @@ ENDIF.`,
         }
         const release = this.reg.getConfig().getRelease();
         const langVers = this.reg.getConfig().getLanguageVersion();
-        if (this.reg.getConfig().getOpenABAP()) {
+        if (this.reg.getConfig().isOpenABAP()) {
             return [];
         }
         else if (!(0, version_1.releaseAtLeast)(release, version_1.Release.v740sp02) && langVers !== version_1.LanguageVersion.Cloud) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.119.67",
+    "version": "2.120.1",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",