@abaplint/core 2.119.66 → 2.120.0

package/build/src/rules/redundant_conversion.js

@@ -0,0 +1,253 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RedundantConversion = exports.RedundantConversionConf = void 0;
+const Expressions = __importStar(require("../abap/2_statements/expressions"));
+const Statements = __importStar(require("../abap/2_statements/statements"));
+const _reference_1 = require("../abap/5_syntax/_reference");
+const constant_1 = require("../abap/5_syntax/expressions/constant");
+const syntax_1 = require("../abap/5_syntax/syntax");
+const nodes_1 = require("../abap/nodes");
+const _typed_identifier_1 = require("../abap/types/_typed_identifier");
+const basic_1 = require("../abap/types/basic");
+const issue_1 = require("../issue");
+const _abap_object_1 = require("../objects/_abap_object");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+const edit_helper_1 = require("../edit_helper");
+const version_1 = require("../version");
+class RedundantConversionConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.RedundantConversionConf = RedundantConversionConf;
+class RedundantConversion {
+    constructor() {
+        this.conf = new RedundantConversionConf();
+    }
+    getMetadata() {
+        return {
+            key: "redundant_conversion",
+            title: "Redundant Conversion",
+            shortDescription: `Find redundant CONV expressions`,
+            extendedInformation: `Reports CONV expressions whose operand already has the conversion's target type.`,
+            tags: [_irule_1.RuleTag.Quickfix],
+            badExample: `DATA text TYPE string.
+text = CONV string( text ).`,
+            goodExample: `DATA text TYPE string.
+text = text.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    initialize(reg) {
+        this.reg = reg;
+        return this;
+    }
+    run(obj) {
+        var _a, _b;
+        if (!(0, version_1.releaseAtLeast)(this.reg.getConfig().getRelease(), version_1.Release.v740sp02)
+            && !this.reg.getConfig().isOpenABAP()) {
+            return [];
+        }
+        if (!(obj instanceof _abap_object_1.ABAPObject)) {
+            return [];
+        }
+        const syntax = new syntax_1.SyntaxLogic(this.reg, obj).run();
+        if (syntax.issues.length > 0) {
+            return [];
+        }
+        const issues = [];
+        for (const file of obj.getABAPFiles()) {
+            const structure = file.getStructure();
+            if (structure === undefined) {
+                continue;
+            }
+            for (const source of structure.findAllExpressions(Expressions.Source)) {
+                if (source.getFirstToken().getStr().toUpperCase() !== "CONV") {
+                    continue;
+                }
+                const typeExpression = source.findDirectExpression(Expressions.TypeNameOrInfer);
+                const bodySource = (_a = source.findDirectExpression(Expressions.ConvBody)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.Source);
+                if (typeExpression === undefined
+                    || bodySource === undefined) {
+                    continue;
+                }
+                const scope = syntax.spaghetti.lookupPosition(source.getFirstToken().getStart(), file.getFilename());
+                if (scope === undefined) {
+                    continue;
+                }
+                const target = (_b = scope.getData().references.find(reference => reference.referenceType === _reference_1.ReferenceType.InferredType
+                    && reference.position.getStart().equals(typeExpression.getFirstToken().getStart()))) === null || _b === void 0 ? void 0 : _b.resolved;
+                const operandType = this.sourceType(bodySource, scope);
+                if (!(target instanceof _typed_identifier_1.TypedIdentifier)) {
+                    continue;
+                }
+                const operandHasSameType = operandType !== undefined && this.sameType(target.getType(), operandType);
+                const arithmeticHasSameContext = this.arithmeticUsesSameTargetType(source, bodySource, file, scope, target.getType());
+                if (operandHasSameType === false && arithmeticHasSameContext === false) {
+                    continue;
+                }
+                const closingParen = source.getDirectTokens().find(token => token.getStr() === ")" && token.getStart().isAfter(bodySource.getLastToken().getStart()));
+                if (closingParen === undefined) {
+                    continue;
+                }
+                const preserveParentheses = bodySource.findDirectExpression(Expressions.ArithOperator) !== undefined
+                    || bodySource.findDirectTokenByText("&&") !== undefined;
+                // Apply the later edit first so the original positions remain valid when
+                // both parts of the CONV wrapper are changed on the same line.
+                const fix = edit_helper_1.EditHelper.merge(edit_helper_1.EditHelper.replaceRange(file, bodySource.getLastToken().getEnd(), closingParen.getEnd(), preserveParentheses ? ")" : ""), edit_helper_1.EditHelper.replaceRange(file, source.getFirstToken().getStart(), bodySource.getFirstToken().getStart(), preserveParentheses ? "(" : ""));
+                issues.push(issue_1.Issue.atRange(file, source.getFirstToken().getStart(), closingParen.getEnd(), "Redundant CONV expression", this.getMetadata().key, this.conf.severity, fix));
+            }
+        }
+        return issues;
+    }
+    arithmeticUsesSameTargetType(conversion, bodySource, file, scope, conversionType) {
+        var _a, _b;
+        if (bodySource.findDirectExpression(Expressions.ArithOperator) === undefined) {
+            return false;
+        }
+        const statement = file.getStatements().find(candidate => candidate.includesToken(conversion.getFirstToken()));
+        if (!((statement === null || statement === void 0 ? void 0 : statement.get()) instanceof Statements.Move)) {
+            return false;
+        }
+        const targetToken = (_a = statement.findDirectExpression(Expressions.Target)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
+        if (targetToken === undefined) {
+            return false;
+        }
+        const assignmentTarget = (_b = scope.getData().references.find(reference => reference.referenceType === _reference_1.ReferenceType.DataWriteReference
+            && reference.position.getStart().equals(targetToken.getStart()))) === null || _b === void 0 ? void 0 : _b.resolved;
+        return assignmentTarget instanceof _typed_identifier_1.TypedIdentifier
+            && this.sameType(conversionType, assignmentTarget.getType());
+    }
+    sourceType(source, scope) {
+        let context;
+        for (const child of source.getChildren()) {
+            if (!(child instanceof nodes_1.ExpressionNode)) {
+                continue;
+            }
+            else if (child.get() instanceof Expressions.FieldChain) {
+                context = this.fieldChainType(child, scope);
+                if (context === undefined) {
+                    return undefined;
+                }
+            }
+            else if (child.get() instanceof Expressions.Constant) {
+                context = this.infer(context, constant_1.Constant.runSyntax(child));
+            }
+            else if (child.get() instanceof Expressions.Source) {
+                context = this.infer(context, this.sourceType(child, scope));
+            }
+            else if (child.get() instanceof Expressions.ArithOperator) {
+                if (child.concatTokens() === "**") {
+                    context = new basic_1.FloatType();
+                }
+            }
+            else {
+                return undefined;
+            }
+        }
+        if (source.findDirectTokenByText("&&")) {
+            return basic_1.StringType.get();
+        }
+        return context;
+    }
+    fieldChainType(fieldChain, scope) {
+        var _a;
+        const operand = (_a = scope.getData().references.find(reference => reference.referenceType === _reference_1.ReferenceType.DataReadReference
+            && reference.position.getStart().equals(fieldChain.getFirstToken().getStart()))) === null || _a === void 0 ? void 0 : _a.resolved;
+        if (!(operand instanceof _typed_identifier_1.TypedIdentifier)) {
+            return undefined;
+        }
+        let type = operand.getType();
+        for (const child of fieldChain.getChildren()) {
+            if (!(child instanceof nodes_1.ExpressionNode)
+                || child.get() instanceof Expressions.SourceField) {
+                continue;
+            }
+            else if (child.get() instanceof Expressions.ComponentName) {
+                if (type instanceof basic_1.TableType) {
+                    type = type.getRowType();
+                }
+                if (!(type instanceof basic_1.StructureType)) {
+                    return undefined;
+                }
+                type = type.getComponentByName(child.concatTokens());
+            }
+            else {
+                // Offsets, table expressions, attributes, and dereferences need more
+                // context than the initial data reference provides.
+                return undefined;
+            }
+        }
+        return type;
+    }
+    infer(context, found) {
+        if (context instanceof basic_1.FloatType && found instanceof basic_1.IntegerType) {
+            return context;
+        }
+        else if (context instanceof basic_1.IntegerType && found instanceof basic_1.HexType) {
+            return context;
+        }
+        else if ((context instanceof basic_1.IntegerType || context instanceof basic_1.FloatType) && (found === null || found === void 0 ? void 0 : found.isGeneric())) {
+            return context;
+        }
+        return found;
+    }
+    sameType(first, second) {
+        var _a, _b;
+        if (first instanceof basic_1.UnknownType
+            || second instanceof basic_1.UnknownType
+            || first instanceof basic_1.VoidType
+            || second instanceof basic_1.VoidType
+            || first.isGeneric()
+            || second.isGeneric()) {
+            return false;
+        }
+        if (first.constructor !== second.constructor) {
+            return false;
+        }
+        if (first instanceof basic_1.StructureType || first instanceof basic_1.TableType) {
+            const firstName = (_a = first.getQualifiedName()) === null || _a === void 0 ? void 0 : _a.toUpperCase();
+            const secondName = (_b = second.getQualifiedName()) === null || _b === void 0 ? void 0 : _b.toUpperCase();
+            return firstName !== undefined && firstName === secondName;
+        }
+        return first.toABAP() === second.toABAP();
+    }
+}
+exports.RedundantConversion = RedundantConversion;
+//# sourceMappingURL=redundant_conversion.js.map

package/build/src/rules/remove_descriptions.js

@@ -59,10 +59,10 @@ class RemoveDescriptions {
         return {
             key: "remove_descriptions",
             title: "Remove descriptions",
-            shortDescription: `Ensures you have no descriptions in metadata of methods, parameters, etc.
-
-Class descriptions are required, see rule description_empty.
-
+            shortDescription: `Ensures you have no descriptions in metadata of methods, parameters, etc.
+
+Class descriptions are required, see rule description_empty.
+
 Consider using ABAP Doc for documentation.`,
             tags: [],
         };

package/build/src/rules/rfc_error_handling.js

@@ -55,14 +55,14 @@ class RFCErrorHandling extends _abap_rule_1.ABAPRule {
             tags: [_irule_1.RuleTag.SingleFile],
             shortDescription: `Checks that exceptions 'system_failure' and 'communication_failure' are handled in RFC calls`,
             extendedInformation: `https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abenrfc_exception.htm`,
-            badExample: `CALL FUNCTION 'ZRFC'
+            badExample: `CALL FUNCTION 'ZRFC'
   DESTINATION lv_rfc.`,
-            goodExample: `CALL FUNCTION 'ZRFC'
-  DESTINATION lv_rfc
-  EXCEPTIONS
-    system_failure        = 1 MESSAGE msg
-    communication_failure = 2 MESSAGE msg
-    resource_failure      = 3
+            goodExample: `CALL FUNCTION 'ZRFC'
+  DESTINATION lv_rfc
+  EXCEPTIONS
+    system_failure        = 1 MESSAGE msg
+    communication_failure = 2 MESSAGE msg
+    resource_failure      = 3
     OTHERS                = 4.`,
         };
     }

package/build/src/rules/select_add_order_by.js

@@ -58,11 +58,11 @@ class SelectAddOrderBy {
             key: "select_add_order_by",
             title: "SELECT add ORDER BY",
             shortDescription: `SELECTs add ORDER BY clause`,
-            extendedInformation: `
-This will make sure that the SELECT statement returns results in the same sequence on different databases
-
-add ORDER BY PRIMARY KEY if in doubt
-
+            extendedInformation: `
+This will make sure that the SELECT statement returns results in the same sequence on different databases
+
+add ORDER BY PRIMARY KEY if in doubt
+
 If the target is a sorted/hashed table, no issue is reported`,
             tags: [_irule_1.RuleTag.SingleFile],
             badExample: `SELECT * FROM db INTO TABLE @DATA(tab).`,

package/build/src/rules/select_performance.js

@@ -67,14 +67,14 @@ class SelectPerformance {
             key: "select_performance",
             title: "SELECT performance",
             shortDescription: `Various checks regarding SELECT performance.`,
-            extendedInformation: `ENDSELECT: not reported when the corresponding SELECT has PACKAGE SIZE
-
+            extendedInformation: `ENDSELECT: not reported when the corresponding SELECT has PACKAGE SIZE
+
 SELECT *: not reported if using INTO/APPENDING CORRESPONDING FIELDS OF`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Performance],
-            badExample: `SELECT field1, field2 FROM table
-    INTO @DATA(structure) UP TO 1 ROWS ORDER BY field3 DESCENDING.
+            badExample: `SELECT field1, field2 FROM table
+    INTO @DATA(structure) UP TO 1 ROWS ORDER BY field3 DESCENDING.
 ENDSELECT.`,
-            goodExample: `SELECT field1, field2 FROM table UP TO 1 ROWS
+            goodExample: `SELECT field1, field2 FROM table UP TO 1 ROWS
   INTO TABLE @DATA(table) ORDER BY field3 DESCENDING`,
         };
     }

package/build/src/rules/select_single_full_key.js

@@ -59,8 +59,8 @@ class SelectSingleFullKey {
             key: "select_single_full_key",
             title: "Detect SELECT SINGLE which are possibily not unique",
             shortDescription: `Detect SELECT SINGLE which are possibily not unique`,
-            extendedInformation: `Table definitions must be known, ie. inside the errorNamespace
-
+            extendedInformation: `Table definitions must be known, ie. inside the errorNamespace
+
 If the statement contains a JOIN it is not checked`,
             pseudoComment: "EC CI_NOORDER",
             tags: [_irule_1.RuleTag.Quickfix],

package/build/src/rules/selection_screen_texts_missing.js

@@ -18,8 +18,8 @@ class SelectionScreenTextsMissing {
             key: "selection_screen_texts_missing",
             title: "Selection screen texts missing",
             shortDescription: `Checks that selection screen parameters and select-options have selection texts`,
-            extendedInformation: `Excludes parameters and select-options that:
-* are inside a "SELECTION-SCREEN BEGIN OF LINE" block
+            extendedInformation: `Excludes parameters and select-options that:
+* are inside a "SELECTION-SCREEN BEGIN OF LINE" block
 * have the addition "NO-DISPLAY"`,
         };
     }

package/build/src/rules/sicf_consistency.js

@@ -24,8 +24,8 @@ class SICFConsistency {
             key: "sicf_consistency",
             title: "SICF consistency",
             shortDescription: `Checks the validity of ICF services`,
-            extendedInformation: `* Class defined in handler must exist
-* Class must not have any syntax errors
+            extendedInformation: `* Class defined in handler must exist
+* Class must not have any syntax errors
 * Class must implement interface IF_HTTP_EXTENSION`,
         };
     }

package/build/src/rules/slow_parameter_passing.js

@@ -23,23 +23,23 @@ class SlowParameterPassing {
             shortDescription: `Detects slow pass by value passing for methods where parameter is not changed`,
             extendedInformation: `Method parameters defined in interfaces is not checked`,
             tags: [_irule_1.RuleTag.Performance, _irule_1.RuleTag.Quickfix],
-            badExample: `CLASS lcl DEFINITION.
-  PUBLIC SECTION.
-    METHODS bar IMPORTING VALUE(sdf) TYPE string.
-ENDCLASS.
-CLASS lcl IMPLEMENTATION.
-  METHOD bar.
-    WRITE sdf.
-  ENDMETHOD.
+            badExample: `CLASS lcl DEFINITION.
+  PUBLIC SECTION.
+    METHODS bar IMPORTING VALUE(sdf) TYPE string.
+ENDCLASS.
+CLASS lcl IMPLEMENTATION.
+  METHOD bar.
+    WRITE sdf.
+  ENDMETHOD.
 ENDCLASS.`,
-            goodExample: `CLASS lcl DEFINITION.
-  PUBLIC SECTION.
-    METHODS bar IMPORTING sdf TYPE string.
-ENDCLASS.
-CLASS lcl IMPLEMENTATION.
-  METHOD bar.
-    WRITE sdf.
-  ENDMETHOD.
+            goodExample: `CLASS lcl DEFINITION.
+  PUBLIC SECTION.
+    METHODS bar IMPORTING sdf TYPE string.
+ENDCLASS.
+CLASS lcl IMPLEMENTATION.
+  METHOD bar.
+    WRITE sdf.
+  ENDMETHOD.
 ENDCLASS.`,
         };
     }

package/build/src/rules/space_before_dot.js

@@ -62,8 +62,8 @@ class SpaceBeforeDot extends _abap_rule_1.ABAPRule {
             key: "space_before_dot",
             title: "Space before dot",
             shortDescription: `Checks for extra spaces before dots at the ends of statements`,
-            extendedInformation: `
-https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#be-consistent
+            extendedInformation: `
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#be-consistent
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#condense-your-code`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
             badExample: `WRITE bar .`,

package/build/src/rules/sql_escape_host_variables.js

@@ -75,7 +75,7 @@ class SQLEscapeHostVariables extends _abap_rule_1.ABAPRule {
         }
         if (!(0, version_1.releaseAtLeast)(this.reg.getConfig().getRelease(), version_1.Release.v740sp02)
             && this.reg.getConfig().getLanguageVersion() !== version_1.LanguageVersion.Cloud
-            && !this.reg.getConfig().getOpenABAP()) {
+            && !this.reg.getConfig().isOpenABAP()) {
             return [];
         }
         for (const s of file.getStatements()) {

package/build/src/rules/sql_value_conversion.js

@@ -18,12 +18,12 @@ class SQLValueConversion {
             key: "sql_value_conversion",
             title: "Implicit SQL Value Conversion",
             shortDescription: `Ensure types match when selecting from database`,
-            extendedInformation: `
-* Integer to CHAR conversion
-* Integer to NUMC conversion
-* NUMC to Integer conversion
-* CHAR to Integer conversion
-* Source field longer than database field, CHAR -> CHAR
+            extendedInformation: `
+* Integer to CHAR conversion
+* Integer to NUMC conversion
+* NUMC to Integer conversion
+* CHAR to Integer conversion
+* Source field longer than database field, CHAR -> CHAR
 * Source field longer than database field, NUMC -> NUMC`,
             tags: [],
         };

package/build/src/rules/start_at_tab.js

@@ -20,7 +20,7 @@ class StartAtTab extends _abap_rule_1.ABAPRule {
             key: "start_at_tab",
             title: "Start at tab",
             shortDescription: `Checks that statements start at tabstops.`,
-            extendedInformation: `Reports max 100 issues per file
+            extendedInformation: `Reports max 100 issues per file
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#indent-and-snap-to-tab`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
             badExample: ` WRITE a.`,

package/build/src/rules/static_call_via_instance.js

@@ -29,11 +29,11 @@ class StaticCallViaInstance extends _abap_rule_1.ABAPRule {
             shortDescription: `Static method call via instance variable`,
             extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#dont-call-static-methods-through-instance-variables`,
             tags: [_irule_1.RuleTag.Styleguide],
-            badExample: `METHOD run.
-  NEW lcl_helper( )->static_method( ).
+            badExample: `METHOD run.
+  NEW lcl_helper( )->static_method( ).
 ENDMETHOD.`,
-            goodExample: `METHOD run.
-  lcl_helper=>static_method( ).
+            goodExample: `METHOD run.
+  lcl_helper=>static_method( ).
 ENDMETHOD.`,
         };
     }

package/build/src/rules/strict_sql.js

@@ -55,12 +55,12 @@ class StrictSQL extends _abap_rule_1.ABAPRule {
             key: "strict_sql",
             title: "Strict SQL",
             shortDescription: `Strict SQL`,
-            extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abapinto_clause.htm
-
-https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abenopensql_strict_mode_750.htm
-
-Also see separate rule sql_escape_host_variables
-
+            extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abapinto_clause.htm
+
+https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abenopensql_strict_mode_750.htm
+
+Also see separate rule sql_escape_host_variables
+
 Activates from v750 and up`,
             tags: [_irule_1.RuleTag.Upport, _irule_1.RuleTag.Quickfix],
             badExample: `SELECT * FROM ztabl INTO TABLE @rt_content WHERE type = @iv_type ORDER BY PRIMARY KEY.`,

package/build/src/rules/sy_modification.js

@@ -52,14 +52,14 @@ class SyModification extends _abap_rule_1.ABAPRule {
             key: "sy_modification",
             title: "Modification of SY fields",
             shortDescription: `Finds modification of sy fields`,
-            extendedInformation: `https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abensystem_fields.htm
-
-Changes to SY-TVAR* fields are not reported
-
-Modification of SY fields is not allwed in ABAP Cloud language version,
+            extendedInformation: `https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abensystem_fields.htm
+
+Changes to SY-TVAR* fields are not reported
+
+Modification of SY fields is not allwed in ABAP Cloud language version,
 https://help.sap.com/doc/abapdocu_cp_index_htm/CLOUD/en-US/ABENSYSTEM_FIELDS.html`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `sy-uname = 2.
+            badExample: `sy-uname = 2.
 sy = sy.`,
         };
     }

package/build/src/rules/tabl_enhancement_category.js

@@ -17,8 +17,8 @@ class TABLEnhancementCategory {
             key: "tabl_enhancement_category",
             title: "TABL enhancement category must be set",
             shortDescription: `Checks that tables do not have the enhancement category 'not classified'.`,
-            extendedInformation: `SAP note 3063227 changes the default to 'Cannot be enhanced'.
-
+            extendedInformation: `SAP note 3063227 changes the default to 'Cannot be enhanced'.
+
 You may use standard report RS_DDIC_CLASSIFICATION_FINAL for adjustment.`,
             tags: [],
         };

package/build/src/rules/tables_declared_locally.js

@@ -55,8 +55,8 @@ class TablesDeclaredLocally extends _abap_rule_1.ABAPRule {
             shortDescription: `TABLES are always global, so declare them globally`,
             extendedInformation: `https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-us/abaptables.htm`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `FORM foo.
-  TABLES t100.
+            badExample: `FORM foo.
+  TABLES t100.
 ENDFORM.`,
             goodExample: `TABLES t000.`,
         };

package/build/src/rules/type_form_parameters.js

@@ -54,9 +54,9 @@ class TypeFormParameters extends _abap_rule_1.ABAPRule {
             title: "Type FORM parameters",
             shortDescription: `Checks for untyped FORM parameters`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `FORM foo USING bar.
+            badExample: `FORM foo USING bar.
 ENDFORM.`,
-            goodExample: `FORM foo USING bar TYPE string.
+            goodExample: `FORM foo USING bar TYPE string.
 ENDFORM.`,
         };
     }

package/build/src/rules/unnecessary_pragma.js

@@ -62,38 +62,38 @@ class UnnecessaryPragma extends _abap_rule_1.ABAPRule {
             key: "unnecessary_pragma",
             title: "Unnecessary Pragma",
             shortDescription: `Finds pragmas which can be removed`,
-            extendedInformation: `* NO_HANDLER with handler
-
-* NEEDED without definition
-
-* NO_TEXT without texts
-
-* SUBRC_OK where sy-subrc is checked
-
+            extendedInformation: `* NO_HANDLER with handler
+
+* NEEDED without definition
+
+* NO_TEXT without texts
+
+* SUBRC_OK where sy-subrc is checked
+
 NO_HANDLER inside macros are not checked`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `TRY.
-    ...
-  CATCH zcx_abapgit_exception ##NO_HANDLER.
-    RETURN. " it has a handler
-ENDTRY.
-MESSAGE w125(zbar) WITH c_foo INTO message ##NEEDED ##NO_TEXT.
-SELECT SINGLE * FROM tadir INTO @DATA(sdfs) ##SUBRC_OK.
-IF sy-subrc <> 0.
+            badExample: `TRY.
+    ...
+  CATCH zcx_abapgit_exception ##NO_HANDLER.
+    RETURN. " it has a handler
+ENDTRY.
+MESSAGE w125(zbar) WITH c_foo INTO message ##NEEDED ##NO_TEXT.
+SELECT SINGLE * FROM tadir INTO @DATA(sdfs) ##SUBRC_OK.
+IF sy-subrc <> 0.
 ENDIF.`,
-            goodExample: `TRY.
-    ...
-  CATCH zcx_abapgit_exception.
-    RETURN.
-ENDTRY.
-MESSAGE w125(zbar) WITH c_foo INTO message.
-SELECT SINGLE * FROM tadir INTO @DATA(sdfs).
-IF sy-subrc <> 0.
-ENDIF.
-
-DATA: BEGIN OF blah ##NEEDED,
-        test1 TYPE string,
-        test2 TYPE string,
+            goodExample: `TRY.
+    ...
+  CATCH zcx_abapgit_exception.
+    RETURN.
+ENDTRY.
+MESSAGE w125(zbar) WITH c_foo INTO message.
+SELECT SINGLE * FROM tadir INTO @DATA(sdfs).
+IF sy-subrc <> 0.
+ENDIF.
+
+DATA: BEGIN OF blah ##NEEDED,
+        test1 TYPE string,
+        test2 TYPE string,
       END OF blah.`,
         };
     }

package/build/src/rules/unnecessary_return.js

@@ -61,18 +61,18 @@ class UnnecessaryReturn extends _abap_rule_1.ABAPRule {
             shortDescription: `Finds unnecessary RETURN statements`,
             extendedInformation: `Finds unnecessary RETURN statements`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
-            badExample: `FORM hello1.
-  WRITE 'world'.
-  RETURN.
-ENDFORM.
-
-FORM foo.
-  IF 1 = 2.
-    RETURN.
-  ENDIF.
+            badExample: `FORM hello1.
+  WRITE 'world'.
+  RETURN.
+ENDFORM.
+
+FORM foo.
+  IF 1 = 2.
+    RETURN.
+  ENDIF.
 ENDFORM.`,
-            goodExample: `FORM hello2.
-  WRITE 'world'.
+            goodExample: `FORM hello2.
+  WRITE 'world'.
 ENDFORM.`,
         };
     }