@abaplint/core 2.119.62 → 2.119.63

package/build/abaplint.d.ts

@@ -2081,6 +2081,7 @@ declare class Dynamic extends Expression {
 declare type DynproField = {
     name: string;
     type: string;
+    contType: string;
     length: number;
     vislength: number;
     line: number;

package/build/src/abap/2_statements/statements/type_mesh.js

@@ -9,7 +9,7 @@ class TypeMesh {
         const on = (0, combi_1.seq)("ON", expressions_1.NamespaceSimpleName, "=", expressions_1.NamespaceSimpleName, (0, combi_1.star)((0, combi_1.seq)("AND", expressions_1.NamespaceSimpleName, "=", expressions_1.NamespaceSimpleName)));
         const using = (0, combi_1.seq)("USING KEY", expressions_1.NamespaceSimpleName);
         const association = (0, combi_1.seq)("ASSOCIATION", expressions_1.NamespaceSimpleName, "TO", expressions_1.NamespaceSimpleName, (0, combi_1.plus)(on));
-        const ret = (0, combi_1.ver)(version_1.Release.v751, (0, combi_1.seq)("TYPES", expressions_1.NamespaceSimpleName, "TYPE", (0, combi_1.opt)("REF TO"), expressions_1.TypeName, (0, combi_1.plus)(association), (0, combi_1.opt)(using)));
+        const ret = (0, combi_1.ver)(version_1.Release.v740sp05, (0, combi_1.seq)("TYPES", expressions_1.NamespaceSimpleName, "TYPE", (0, combi_1.opt)("REF TO"), expressions_1.TypeName, (0, combi_1.plus)(association), (0, combi_1.opt)(using)));
         return ret;
     }
 }

package/build/src/objects/_dynpros.js

@@ -19,6 +19,7 @@ function parseDynpros(parsed) {
                 fields.push({
                     name: f.NAME,
                     type: f.TYPE,
+                    contType: f.CONT_TYPE,
                     length: parseNumber(f.LENGTH),
                     vislength: parseNumber(f.VISLENGTH),
                     line: parseNumber(f.LINE),

package/build/src/objects/data_definition.js

@@ -155,9 +155,8 @@ class DataDefinition extends _abstract_object_1.AbstractObject {
             }
             if (found === undefined) {
                 // typed virtual element: VIRTUAL <name> : <type>
-                const names = e.findAllExpressions(expressions_1.CDSName);
-                if (e.findDirectTokenByText("VIRTUAL") !== undefined && names.length > 0) {
-                    found = names[0];
+                if (e.findDirectTokenByText("VIRTUAL") !== undefined) {
+                    found = e.findFirstExpression(expressions_1.CDSName);
                 }
             }
             if (found === undefined) {

package/build/src/registry.js

@@ -75,7 +75,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.119.62";
+        return "2.119.63";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/begin_end_names.js

@@ -92,17 +92,22 @@ class BeginEndNames extends _abap_rule_1.ABAPRule {
     test(stru, type, b, e, file) {
         const output = [];
         for (const sub of stru.findAllStructuresRecursive(type)) {
-            let begin = sub.findDirectStatements(b)[0].findFirstExpression(Expressions.NamespaceSimpleName);
+            const beginStatement = sub.findDirectStatement(b);
+            const endStatement = sub.findDirectStatement(e);
+            if (beginStatement === undefined || endStatement === undefined) {
+                continue;
+            }
+            let begin = beginStatement.findFirstExpression(Expressions.NamespaceSimpleName);
             if (begin === undefined) {
-                begin = sub.findDirectStatements(b)[0].findFirstExpression(Expressions.DefinitionName);
+                begin = beginStatement.findFirstExpression(Expressions.DefinitionName);
             }
             if (begin === undefined) {
                 continue;
             }
             const first = begin.getFirstToken();
-            let end = sub.findDirectStatements(e)[0].findFirstExpression(Expressions.NamespaceSimpleName);
+            let end = endStatement.findFirstExpression(Expressions.NamespaceSimpleName);
             if (end === undefined) {
-                end = sub.findDirectStatements(e)[0].findFirstExpression(Expressions.DefinitionName);
+                end = endStatement.findFirstExpression(Expressions.DefinitionName);
             }
             if (end === undefined) {
                 continue;

package/build/src/rules/downport.js

@@ -2984,7 +2984,7 @@ ${indentation}    output = ${uniqueName}.\n`;
                 }
             }
         }
-        if (fix === undefined && high.findAllExpressions(Expressions.NewObject)) {
+        if (fix === undefined) {
             const found = high.findFirstExpression(Expressions.NewObject);
             if (found === undefined) {
                 return undefined;

package/build/src/rules/dynpro_checks.js

@@ -55,12 +55,13 @@ class DynproChecks {
         const ret = [];
         for (let index = 0; index < dynpro.fields.length; index++) {
             const current = dynpro.fields[index];
-            if (current.name === undefined || current.type === "FRAME") {
+            if (current.name === undefined || current.type === "FRAME" || this.hasContainerRelativeCoordinates(current)) {
                 continue;
             }
             for (let compare = index + 1; compare < dynpro.fields.length; compare++) {
                 const other = dynpro.fields[compare];
-                if (other.name === undefined || other.type === "FRAME" || this.overlaps(current, other) === false) {
+                if (other.name === undefined || other.type === "FRAME" || this.hasContainerRelativeCoordinates(other)
+                    || this.overlaps(current, other) === false) {
                     continue;
                 }
                 const message = `Screen ${dynpro.number}, ${current.type} ${current.name} and ${other.type} ${other.name} are overlapping`;
@@ -69,6 +70,9 @@ class DynproChecks {
         }
         return ret;
     }
+    hasContainerRelativeCoordinates(field) {
+        return field.contType === "TABLE_CTRL" || field.contType === "LOOP";
+    }
     overlaps(first, second) {
         if (first.line === 0 || second.line === 0 || first.column === 0 || second.column === 0) {
             return false;

package/build/src/rules/obsolete_statement.js

@@ -394,11 +394,11 @@ ENDIF.`,
                     }
                 }
                 else {
-                    const classNameExpression = staNode.findAllExpressions(Expressions.ClassName);
-                    const methodNameExpression = staNode.findAllExpressions(Expressions.MethodName);
-                    if (classNameExpression.length !== 0 && methodNameExpression.length !== 0) {
-                        const className = classNameExpression[0].concatTokens();
-                        const methodName = methodNameExpression[0].concatTokens();
+                    const classNameExpression = staNode.findFirstExpression(Expressions.ClassName);
+                    const methodNameExpression = staNode.findFirstExpression(Expressions.MethodName);
+                    if (classNameExpression && methodNameExpression) {
+                        const className = classNameExpression.concatTokens();
+                        const methodName = methodNameExpression.concatTokens();
                         if (className === "cl_abap_regex") {
                             if (methodName === "create_posix") {
                                 const issue = issue_1.Issue.atStatement(file, staNode, "create_posix obsolete, use create_pcre", this.getMetadata().key, this.conf.severity);

package/build/src/rules/short_case.js

@@ -87,12 +87,12 @@ class ShortCase extends _abap_rule_1.ABAPRule {
             return [];
         }
         for (const c of struc.findAllStructures(Structures.Case)) {
-            const clist = c.findDirectStatements(Statements.Case);
-            if (clist.length > 0 && this.conf.allow && this.conf.allow.find((e) => { return e === clist[0].getTokens()[1].getStr(); })) {
+            const caseStatement = c.findDirectStatement(Statements.Case);
+            if (caseStatement && this.conf.allow && this.conf.allow.find((e) => { return e === caseStatement.getTokens()[1].getStr(); })) {
                 continue;
             }
             if (c.findDirectStructures(Structures.When).length <= this.conf.length) {
-                if (c.findAllExpressions(Expressions.Or).length > 0) {
+                if (c.findFirstExpression(Expressions.Or)) {
                     continue;
                 }
                 const issue = issue_1.Issue.atToken(file, c.getFirstToken(), this.getMessage(), this.getMetadata().key, this.conf.severity);

package/build/src/rules/try_without_catch.js

@@ -40,9 +40,9 @@ class TryWithoutCatch extends _abap_rule_1.ABAPRule {
         }
         const tries = stru.findAllStructures(structures_1.Try);
         for (const t of tries) {
-            const clean = t.findDirectStructures(structures_1.Cleanup);
-            const c = t.findDirectStructures(structures_1.Catch);
-            if (c.length === 0 && clean.length === 0) {
+            const clean = t.findDirectStructure(structures_1.Cleanup);
+            const c = t.findDirectStructure(structures_1.Catch);
+            if (c === undefined && clean === undefined) {
                 const issue = issue_1.Issue.atToken(file, t.getFirstToken(), this.getMessage(), this.getMetadata().key, this.conf.severity);
                 issues.push(issue);
             }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.119.62",
+    "version": "2.119.63",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",