@abaplint/core 2.119.61 → 2.119.63

package/build/abaplint.d.ts

@@ -412,6 +412,8 @@ declare class Attributes implements IAttributes {
     private readonly filename;
     private readonly aliases;
     private readonly declaredInterfaces;
+    private readonly all;
+    private readonly byName;
     constructor(node: StructureNode, input: SyntaxInput);
     getTypes(): TypeDefinitions;
     getStatic(): ClassAttribute[];
@@ -423,6 +425,7 @@ declare class Attributes implements IAttributes {
     getConstants(): ClassConstant[];
     getConstantsByVisibility(visibility: Visibility): ClassConstant[];
     findByName(name: string): ClassAttribute | ClassConstant | undefined;
+    private buildByName;
     private parse;
     private parseSection;
     private parseAlias;
@@ -2078,6 +2081,7 @@ declare class Dynamic extends Expression {
 declare type DynproField = {
     name: string;
     type: string;
+    contType: string;
     length: number;
     vislength: number;
     line: number;
@@ -4398,7 +4402,6 @@ declare interface ISyntaxResult {
 declare interface ISyntaxSettings {
     /** ABAP language version */
     version?: VersionOldOrNew;
-    languageVersion?: LanguageVersion;
     /** Report error for objects in this regex namespace. Types not in namespace will be void. Case insensitive */
     errorNamespace: string;
     /** List of full named global constants (regex not possible)
@@ -6759,6 +6762,7 @@ declare class Skip implements IStatement {
 
 export declare class SkipLogic {
     private readonly reg;
+    private includeGraph;
     /** TOBJ cache hashmap */
     private tobj;
     constructor(reg: IRegistry);

package/build/src/abap/2_statements/statement_parser.js

@@ -239,7 +239,9 @@ class StatementParser {
                 statement = input;
             }
             else if (length === 1 && lastToken instanceof tokens_1.Pragma) {
-                statement = new nodes_1.StatementNode(new _statement_1.Empty(), undefined, [lastToken]);
+                // special case, everything crashes if StatementNodes doesnt have children
+                statement = new nodes_1.StatementNode(new _statement_1.Empty(), undefined, [lastToken])
+                    .setChildren(this.tokensToNodes([lastToken]));
             }
         }
         return statement;

package/build/src/abap/2_statements/statements/type_mesh.js

@@ -9,7 +9,7 @@ class TypeMesh {
         const on = (0, combi_1.seq)("ON", expressions_1.NamespaceSimpleName, "=", expressions_1.NamespaceSimpleName, (0, combi_1.star)((0, combi_1.seq)("AND", expressions_1.NamespaceSimpleName, "=", expressions_1.NamespaceSimpleName)));
         const using = (0, combi_1.seq)("USING KEY", expressions_1.NamespaceSimpleName);
         const association = (0, combi_1.seq)("ASSOCIATION", expressions_1.NamespaceSimpleName, "TO", expressions_1.NamespaceSimpleName, (0, combi_1.plus)(on));
-        const ret = (0, combi_1.ver)(version_1.Release.v751, (0, combi_1.seq)("TYPES", expressions_1.NamespaceSimpleName, "TYPE", (0, combi_1.opt)("REF TO"), expressions_1.TypeName, (0, combi_1.plus)(association), (0, combi_1.opt)(using)));
+        const ret = (0, combi_1.ver)(version_1.Release.v740sp05, (0, combi_1.seq)("TYPES", expressions_1.NamespaceSimpleName, "TYPE", (0, combi_1.opt)("REF TO"), expressions_1.TypeName, (0, combi_1.plus)(association), (0, combi_1.opt)(using)));
         return ret;
     }
 }

package/build/src/abap/5_syntax/_current_scope.js

@@ -296,7 +296,7 @@ class CurrentScope {
     }
     findTypePoolConstant(name) {
         var _a;
-        if (name === undefined || name.includes("_") === undefined) {
+        if (name === undefined || name.includes("_") === false) {
             return undefined;
         }
         const typePoolName = name.split("_")[0];
@@ -318,7 +318,7 @@ class CurrentScope {
     }
     findTypePoolType(name) {
         var _a;
-        if (name.includes("_") === undefined) {
+        if (name.includes("_") === false) {
             return undefined;
         }
         const typePoolName = name.split("_")[0];

package/build/src/abap/5_syntax/_object_oriented.js

@@ -108,11 +108,9 @@ class ObjectOriented {
     findMethodInInterface(interfaceName, methodName) {
         const idef = this.scope.findInterfaceDefinition(interfaceName);
         if (idef) {
-            const methods = idef.getMethodDefinitions().getAll();
-            for (const method of methods) {
-                if (method.getName().toUpperCase() === methodName.toUpperCase()) {
-                    return { method, def: idef };
-                }
+            const method = idef.getMethodDefinitions().getByName(methodName);
+            if (method) {
+                return { method, def: idef };
             }
             return this.findMethodViaAlias(methodName, idef);
         }
@@ -334,17 +332,14 @@ class ObjectOriented {
         if (defs === undefined) {
             return undefined;
         }
-        for (const method of defs.getAll()) {
-            if (method.getName().toUpperCase() === methodName.toUpperCase()) {
-                if (method.isRedefinition()) {
-                    return this.findMethodInSuper(def, methodName);
-                }
-                else {
-                    return method;
-                }
-            }
+        const method = defs.getByName(methodName);
+        if (method === undefined) {
+            return undefined;
         }
-        return undefined;
+        if (method.isRedefinition()) {
+            return this.findMethodInSuper(def, methodName);
+        }
+        return method;
     }
     findMethodInSuper(child, methodName) {
         let sup = child.getSuperClass();

package/build/src/abap/types/class_attributes.js

@@ -63,6 +63,8 @@ class Attributes {
         this.tlist = [];
         this.filename = input.filename;
         this.parse(node, input);
+        this.all = this.static.concat(this.instance);
+        this.byName = this.buildByName();
         this.types = new type_definitions_1.TypeDefinitions(this.tlist);
     }
     getTypes() {
@@ -75,10 +77,7 @@ class Attributes {
         return this.aliases;
     }
     getAll() {
-        let res = [];
-        res = res.concat(this.static);
-        res = res.concat(this.instance);
-        return res;
+        return this.all;
     }
     getStaticsByVisibility(visibility) {
         const attributes = [];
@@ -113,27 +112,29 @@ class Attributes {
         }
         return attributes;
     }
-    // todo, optimize
     findByName(name) {
-        const upper = name.toUpperCase();
-        for (const a of this.getStatic()) {
-            if (a.getName().toUpperCase() === upper) {
-                return a;
-            }
+        return this.byName[name.toUpperCase()];
+    }
+    /////////////////////////////
+    buildByName() {
+        const ret = {};
+        for (const a of this.static) {
+            ret[a.getName().toUpperCase()] = a;
         }
-        for (const a of this.getInstance()) {
-            if (a.getName().toUpperCase() === upper) {
-                return a;
+        for (const a of this.instance) {
+            const name = a.getName().toUpperCase();
+            if (ret[name] === undefined) {
+                ret[name] = a;
             }
         }
-        for (const a of this.getConstants()) {
-            if (a.getName().toUpperCase() === upper) {
-                return a;
+        for (const a of this.constants) {
+            const name = a.getName().toUpperCase();
+            if (ret[name] === undefined) {
+                ret[name] = a;
             }
         }
-        return undefined;
+        return ret;
     }
-    /////////////////////////////
     parse(node, input) {
         var _a, _b;
         const cdef = node.findDirectStructure(Structures.ClassDefinition);

package/build/src/config.js

@@ -47,10 +47,19 @@ class Config {
         for (const rule of sorted) {
             rules[rule.getMetadata().key] = rule.getConfig();
         }
-        const version = ver !== null && ver !== void 0 ? ver : {
-            release: version_1.Release.Newest.name,
-            language: langVer !== null && langVer !== void 0 ? langVer : version_1.LanguageVersion.Normal,
-        };
+        const version = langVer !== undefined
+            ? {
+                release: ver === undefined || ver === version_1.Version.Cloud
+                    ? version_1.Release.Newest.name
+                    : typeof ver === "string"
+                        ? (0, version_1.versionToABAPRelease)(ver).name
+                        : ver.release,
+                language: langVer,
+            }
+            : ver !== null && ver !== void 0 ? ver : {
+                release: version_1.Release.Newest.name,
+                language: version_1.LanguageVersion.Normal,
+            };
         // defaults: dont skip anything, report everything. The user can decide to skip stuff
         // its difficult to debug errors not being reported
         const config = {
@@ -75,7 +84,6 @@ class Config {
                 }],
             syntax: {
                 version,
-                languageVersion: langVer,
                 errorNamespace: "^(Z|Y|LCL\_|TY\_|LIF\_)",
                 globalConstants: [],
                 ambigiousVoids: [],
@@ -184,9 +192,6 @@ class Config {
         return v;
     }
     getLanguageVersion() {
-        if (this.config.syntax.languageVersion !== undefined) {
-            return this.config.syntax.languageVersion;
-        }
         const v = this.config.syntax.version;
         if (v !== undefined && typeof v !== "string") {
             return v.language;
@@ -211,7 +216,10 @@ class Config {
             return;
         }
         if (version === version_1.Version.Cloud) {
-            this.config.syntax.languageVersion = version_1.LanguageVersion.Cloud;
+            this.config.syntax.version = {
+                release: version_1.Release.Newest.name,
+                language: version_1.LanguageVersion.Cloud,
+            };
         }
         // OpenABAP keeps its own version identity; open-abap-ness is derived from the
         // release in getOpenABAP() rather than a separate stored flag.

package/build/src/objects/_dynpros.js

@@ -19,6 +19,7 @@ function parseDynpros(parsed) {
                 fields.push({
                     name: f.NAME,
                     type: f.TYPE,
+                    contType: f.CONT_TYPE,
                     length: parseNumber(f.LENGTH),
                     vislength: parseNumber(f.VISLENGTH),
                     line: parseNumber(f.LINE),

package/build/src/objects/data_definition.js

@@ -155,9 +155,8 @@ class DataDefinition extends _abstract_object_1.AbstractObject {
             }
             if (found === undefined) {
                 // typed virtual element: VIRTUAL <name> : <type>
-                const names = e.findAllExpressions(expressions_1.CDSName);
-                if (e.findDirectTokenByText("VIRTUAL") !== undefined && names.length > 0) {
-                    found = names[0];
+                if (e.findDirectTokenByText("VIRTUAL") !== undefined) {
+                    found = e.findFirstExpression(expressions_1.CDSName);
                 }
             }
             if (found === undefined) {

package/build/src/registry.js

@@ -75,7 +75,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.119.61";
+        return "2.119.63";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/begin_end_names.js

@@ -92,17 +92,22 @@ class BeginEndNames extends _abap_rule_1.ABAPRule {
     test(stru, type, b, e, file) {
         const output = [];
         for (const sub of stru.findAllStructuresRecursive(type)) {
-            let begin = sub.findDirectStatements(b)[0].findFirstExpression(Expressions.NamespaceSimpleName);
+            const beginStatement = sub.findDirectStatement(b);
+            const endStatement = sub.findDirectStatement(e);
+            if (beginStatement === undefined || endStatement === undefined) {
+                continue;
+            }
+            let begin = beginStatement.findFirstExpression(Expressions.NamespaceSimpleName);
             if (begin === undefined) {
-                begin = sub.findDirectStatements(b)[0].findFirstExpression(Expressions.DefinitionName);
+                begin = beginStatement.findFirstExpression(Expressions.DefinitionName);
             }
             if (begin === undefined) {
                 continue;
             }
             const first = begin.getFirstToken();
-            let end = sub.findDirectStatements(e)[0].findFirstExpression(Expressions.NamespaceSimpleName);
+            let end = endStatement.findFirstExpression(Expressions.NamespaceSimpleName);
             if (end === undefined) {
-                end = sub.findDirectStatements(e)[0].findFirstExpression(Expressions.DefinitionName);
+                end = endStatement.findFirstExpression(Expressions.DefinitionName);
             }
             if (end === undefined) {
                 continue;

package/build/src/rules/downport.js

@@ -2984,7 +2984,7 @@ ${indentation}    output = ${uniqueName}.\n`;
                 }
             }
         }
-        if (fix === undefined && high.findAllExpressions(Expressions.NewObject)) {
+        if (fix === undefined) {
             const found = high.findFirstExpression(Expressions.NewObject);
             if (found === undefined) {
                 return undefined;

package/build/src/rules/dynpro_checks.js

@@ -55,12 +55,13 @@ class DynproChecks {
         const ret = [];
         for (let index = 0; index < dynpro.fields.length; index++) {
             const current = dynpro.fields[index];
-            if (current.name === undefined || current.type === "FRAME") {
+            if (current.name === undefined || current.type === "FRAME" || this.hasContainerRelativeCoordinates(current)) {
                 continue;
             }
             for (let compare = index + 1; compare < dynpro.fields.length; compare++) {
                 const other = dynpro.fields[compare];
-                if (other.name === undefined || other.type === "FRAME" || this.overlaps(current, other) === false) {
+                if (other.name === undefined || other.type === "FRAME" || this.hasContainerRelativeCoordinates(other)
+                    || this.overlaps(current, other) === false) {
                     continue;
                 }
                 const message = `Screen ${dynpro.number}, ${current.type} ${current.name} and ${other.type} ${other.name} are overlapping`;
@@ -69,6 +70,9 @@ class DynproChecks {
         }
         return ret;
     }
+    hasContainerRelativeCoordinates(field) {
+        return field.contType === "TABLE_CTRL" || field.contType === "LOOP";
+    }
     overlaps(first, second) {
         if (first.line === 0 || second.line === 0 || first.column === 0 || second.column === 0) {
             return false;

package/build/src/rules/names_no_dash.js

@@ -39,7 +39,6 @@ const Expressions = __importStar(require("../abap/2_statements/expressions"));
 const _abap_rule_1 = require("./_abap_rule");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const issue_1 = require("../issue");
-const tokens_1 = require("../abap/1_lexer/tokens");
 const expressions_1 = require("../abap/2_statements/expressions");
 const _irule_1 = require("./_irule");
 class NamesNoDashConf extends _basic_rule_config_1.BasicRuleConfig {
@@ -79,32 +78,26 @@ class NamesNoDash extends _abap_rule_1.ABAPRule {
         if (obj.getType() !== "CLAS" && obj.getType() !== "INTF") {
             for (const form of struc.findAllStatements(Statements.Form)) {
                 const expr = form.findFirstExpression(expressions_1.FormName);
-                for (const token of expr.getTokens()) {
-                    if (token instanceof tokens_1.Dash || token instanceof tokens_1.DashW) {
-                        const issue = issue_1.Issue.atToken(file, token, this.getMessage(), this.getMetadata().key, this.conf.severity);
-                        issues.push(issue);
-                        break;
-                    }
+                const token = expr === null || expr === void 0 ? void 0 : expr.findDirectTokenByText("-");
+                if (token) {
+                    const issue = issue_1.Issue.atToken(file, token, this.getMessage(), this.getMetadata().key, this.conf.severity);
+                    issues.push(issue);
                 }
             }
             for (const form of struc.findAllStatements(Statements.Parameter)) {
                 const expr = form.findFirstExpression(Expressions.FieldSub);
-                for (const token of expr.getTokens()) {
-                    if (token instanceof tokens_1.Dash || token instanceof tokens_1.DashW) {
-                        const issue = issue_1.Issue.atToken(file, token, this.getMessage(), this.getMetadata().key, this.conf.severity);
-                        issues.push(issue);
-                        break;
-                    }
+                const token = expr === null || expr === void 0 ? void 0 : expr.findDirectTokenByText("-");
+                if (token) {
+                    const issue = issue_1.Issue.atToken(file, token, this.getMessage(), this.getMetadata().key, this.conf.severity);
+                    issues.push(issue);
                 }
             }
             for (const form of struc.findAllStatements(Statements.SelectOption)) {
                 const expr = form.findFirstExpression(Expressions.FieldSub);
-                for (const token of expr.getTokens()) {
-                    if (token instanceof tokens_1.Dash || token instanceof tokens_1.DashW) {
-                        const issue = issue_1.Issue.atToken(file, token, this.getMessage(), this.getMetadata().key, this.conf.severity);
-                        issues.push(issue);
-                        break;
-                    }
+                const token = expr === null || expr === void 0 ? void 0 : expr.findDirectTokenByText("-");
+                if (token) {
+                    const issue = issue_1.Issue.atToken(file, token, this.getMessage(), this.getMetadata().key, this.conf.severity);
+                    issues.push(issue);
                 }
             }
         }

package/build/src/rules/obsolete_statement.js

@@ -394,11 +394,11 @@ ENDIF.`,
                     }
                 }
                 else {
-                    const classNameExpression = staNode.findAllExpressions(Expressions.ClassName);
-                    const methodNameExpression = staNode.findAllExpressions(Expressions.MethodName);
-                    if (classNameExpression.length !== 0 && methodNameExpression.length !== 0) {
-                        const className = classNameExpression[0].concatTokens();
-                        const methodName = methodNameExpression[0].concatTokens();
+                    const classNameExpression = staNode.findFirstExpression(Expressions.ClassName);
+                    const methodNameExpression = staNode.findFirstExpression(Expressions.MethodName);
+                    if (classNameExpression && methodNameExpression) {
+                        const className = classNameExpression.concatTokens();
+                        const methodName = methodNameExpression.concatTokens();
                         if (className === "cl_abap_regex") {
                             if (methodName === "create_posix") {
                                 const issue = issue_1.Issue.atStatement(file, staNode, "create_posix obsolete, use create_pcre", this.getMetadata().key, this.conf.severity);

package/build/src/rules/short_case.js

@@ -87,12 +87,12 @@ class ShortCase extends _abap_rule_1.ABAPRule {
             return [];
         }
         for (const c of struc.findAllStructures(Structures.Case)) {
-            const clist = c.findDirectStatements(Statements.Case);
-            if (clist.length > 0 && this.conf.allow && this.conf.allow.find((e) => { return e === clist[0].getTokens()[1].getStr(); })) {
+            const caseStatement = c.findDirectStatement(Statements.Case);
+            if (caseStatement && this.conf.allow && this.conf.allow.find((e) => { return e === caseStatement.getTokens()[1].getStr(); })) {
                 continue;
             }
             if (c.findDirectStructures(Structures.When).length <= this.conf.length) {
-                if (c.findAllExpressions(Expressions.Or).length > 0) {
+                if (c.findFirstExpression(Expressions.Or)) {
                     continue;
                 }
                 const issue = issue_1.Issue.atToken(file, c.getFirstToken(), this.getMessage(), this.getMetadata().key, this.conf.severity);

package/build/src/rules/try_without_catch.js

@@ -40,9 +40,9 @@ class TryWithoutCatch extends _abap_rule_1.ABAPRule {
         }
         const tries = stru.findAllStructures(structures_1.Try);
         for (const t of tries) {
-            const clean = t.findDirectStructures(structures_1.Cleanup);
-            const c = t.findDirectStructures(structures_1.Catch);
-            if (c.length === 0 && clean.length === 0) {
+            const clean = t.findDirectStructure(structures_1.Cleanup);
+            const c = t.findDirectStructure(structures_1.Catch);
+            if (c === undefined && clean === undefined) {
                 const issue = issue_1.Issue.atToken(file, t.getFirstToken(), this.getMessage(), this.getMetadata().key, this.conf.severity);
                 issues.push(issue);
             }

package/build/src/rules/unnecessary_pragma.js

@@ -42,6 +42,7 @@ const _basic_rule_config_1 = require("./_basic_rule_config");
 const _statement_1 = require("../abap/2_statements/statements/_statement");
 const _irule_1 = require("./_irule");
 const edit_helper_1 = require("../edit_helper");
+const tokens_1 = require("../abap/1_lexer/tokens");
 class UnnecessaryPragmaConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
         super(...arguments);
@@ -110,6 +111,17 @@ DATA: BEGIN OF blah ##NEEDED,
         for (let i = 0; i < statements.length; i++) {
             const statement = statements[i];
             const nextStatement = statements[i + 1];
+            if (statement.get() instanceof _statement_1.Empty
+                && statement.getChildren().length === 1) {
+                const tokens = statement.getTokens();
+                if (tokens.length === 1
+                    && tokens[0] instanceof tokens_1.Pragma) {
+                    const message = "Pragma without a statement can be removed";
+                    const fix = edit_helper_1.EditHelper.deleteToken(file, tokens[0]);
+                    issues.push(issue_1.Issue.atToken(file, tokens[0], message, this.getMetadata().key, this.conf.severity, fix));
+                    continue;
+                }
+            }
             if (statement.get() instanceof Statements.EndTry) {
                 noHandler = false;
             }

package/build/src/skip_logic.js

@@ -6,9 +6,11 @@ const include_graph_1 = require("./utils/include_graph");
 class SkipLogic {
     constructor(reg) {
         this.reg = reg;
+        this.includeGraph = undefined;
         this.tobj = undefined;
     }
     skip(obj) {
+        var _a;
         const global = this.reg.getConfig().getGlobal();
         if (global.skipGeneratedGatewayClasses === true
             && obj instanceof objects_1.Class
@@ -18,9 +20,9 @@ class SkipLogic {
         else if (global.skipIncludesWithoutMain === true
             && obj instanceof objects_1.Program
             && obj.isInclude() === true) {
-            const ig = new include_graph_1.IncludeGraph(this.reg);
+            (_a = this.includeGraph) !== null && _a !== void 0 ? _a : (this.includeGraph = new include_graph_1.IncludeGraph(this.reg));
             const file = obj.getMainABAPFile();
-            if (file && ig.listMainForInclude(file.getFilename()).length === 0) {
+            if (file && this.includeGraph.listMainForInclude(file.getFilename()).length === 0) {
                 return true;
             }
         }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.119.61",
+    "version": "2.119.63",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",